From patchwork Thu Dec 14 09:10:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492596 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2D97C4167D for ; Thu, 14 Dec 2023 09:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9Y18nX3X1XKrtgv0mOoZdcN/anJCtIR9KDkmis22aag=; b=xq4z6K1JYEBfDX 2WHP3ZRg5le6r8EkgVnNXrGZlv2ca/75J2hQCS11q5zSR9cBYtDSNxU1SBN3TVSSPf6+GJV6+pfY0 o/xIQsX1DtectLr558zu+4u/qsI218kWfUZDeKwi36vuVlj673PrrU1ttRTmtDCODX5vGlPjDc8ha qjYVFe5BuOn95OX1BSVGDT4MVCjT6FAJ9GED3s1i6+fN/nJysiYD9v+PXwPhWyHH23vFmSmwET916 ebZz6oJTorXKhk1xHQvNKF174QRSIyBB4AJP90ADE8Ly+lM7DEWUeP4+cmO6d+OhrlltywqRwU3+p 1lgV+DpedS7lH1Iof5RA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhkl-00HJYS-15; Thu, 14 Dec 2023 09:11:35 +0000 Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhki-00HJWS-1j for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:11:33 +0000 Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-67ad531686eso3365036d6.1 for ; Thu, 14 Dec 2023 01:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545084; x=1703149884; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6IaFDod8qWxr8WQM1D5UKzpQIEJXDdQljMHqbalXZ3w=; b=ORHvj0kZTpJYa7BXQzZJz6movaW3D9yzk7xc5aEBoH12/K3KSMgwwlSPy+m8SWJprw xuS9Ih6BGay8oMVwYFojU3U2MCkQ9Mn17LQCMmQrZN8ld7yPHuj+DTLekq37eF3UrKJf EtxAFCB7bfloBaa5CGNimr4TIQUY3OkONweuPDTBptoe1o+06W9QgydvEjUEw/UQUa3H kqGJc7KiAAHolZRXipG0jhyoM/A9IozylnEJmR+sSgMpGfMIgVL6B8Ucs3qy6ezbBhub oYSYBZUKUBQBIJ15Gf80VkHOryclU6kIko+CA6/eYD9y7nXmtc2DwVl9a4DSvfNwjyM4 nZqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545084; x=1703149884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6IaFDod8qWxr8WQM1D5UKzpQIEJXDdQljMHqbalXZ3w=; b=By6zCfKXiju70uUuEJ5kG0A5bS/eBovlC5bFkqBiO3en0u13PNeJ3jHCQOjUyM262U Oczz1Rt759ncoGGFr6vJ+ILUesvOKylPtgjRgOlhX2ylaQ9IDTtxbWeGIb+NFBZyB1Sq uRreSrVp1YIKoLUyGM7g+XaIEhC/OIWVOCa1SpefYsjxBvmEBYkpQLU95jfihEGau7mC hmWFymzVUzAAoQdGcC/qgDRTZAKIIXaEfU2BBxXexoMJcNov8oLpgouRJs6Sh8Z5lIdD wfgtzvJpbUkM7GjFZCYcei1rwKZs/qnJXdJjEysJbeWvlwpGAW7s36ZyT6aAWMSzQSHh BmcQ== X-Gm-Message-State: AOJu0Yx0vqfsTz/t2u0IncNLlZcxtESMdl+flUESmWCi6w5YtVj6w3Ye fcP8Fxw8fIV/8Ecg+XBakswm X-Google-Smtp-Source: AGHT+IFWS5tXUoDuwKS0Y+S8DpQ1nM36WsP8DhgZT5a4e5se0ymj9dUim0tvEitMjyqjox+W7p/Ugg== X-Received: by 2002:ad4:5dec:0:b0:67a:568e:5b10 with SMTP id jn12-20020ad45dec000000b0067a568e5b10mr15074701qvb.20.1702545083823; Thu, 14 Dec 2023 01:11:23 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:11:23 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 01/16] dt-bindings: phy: qmp-ufs: Fix PHY clocks Date: Thu, 14 Dec 2023 14:40:46 +0530 Message-Id: <20231214091101.45713-2-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011132_573132_D8F0A72E X-CRM114-Status: UNSURE ( 8.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org All QMP UFS PHYs except MSM8996 require 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC or TCSR (since SM8550) MSM8996 only requires 'ref' and 'qref' clocks. Hence, fix the binding to reflect the actual clock topology. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Conor Dooley --- .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 47 +++++++++---------- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml index f3a3296c811c..800f11b29dcd 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml @@ -37,15 +37,12 @@ properties: maxItems: 1 clocks: - minItems: 1 + minItems: 2 maxItems: 3 clock-names: - minItems: 1 - items: - - const: ref - - const: ref_aux - - const: qref + minItems: 2 + maxItems: 3 power-domains: maxItems: 1 @@ -85,22 +82,9 @@ allOf: compatible: contains: enum: + - qcom,msm8998-qmp-ufs-phy - qcom,sa8775p-qmp-ufs-phy - qcom,sc7280-qmp-ufs-phy - - qcom,sm8450-qmp-ufs-phy - then: - properties: - clocks: - minItems: 3 - clock-names: - minItems: 3 - - - if: - properties: - compatible: - contains: - enum: - - qcom,msm8998-qmp-ufs-phy - qcom,sc8180x-qmp-ufs-phy - qcom,sc8280xp-qmp-ufs-phy - qcom,sdm845-qmp-ufs-phy @@ -111,13 +95,18 @@ allOf: - qcom,sm8150-qmp-ufs-phy - qcom,sm8250-qmp-ufs-phy - qcom,sm8350-qmp-ufs-phy + - qcom,sm8450-qmp-ufs-phy - qcom,sm8550-qmp-ufs-phy then: properties: clocks: - maxItems: 2 + minItems: 3 + maxItems: 3 clock-names: - maxItems: 2 + items: + - const: ref + - const: ref_aux + - const: qref - if: properties: @@ -128,22 +117,28 @@ allOf: then: properties: clocks: - maxItems: 1 + minItems: 2 + maxItems: 2 clock-names: - maxItems: 1 + items: + - const: ref + - const: qref additionalProperties: false examples: - | #include + #include ufs_mem_phy: phy@1d87000 { compatible = "qcom,sc8280xp-qmp-ufs-phy"; reg = <0x01d87000 0x1000>; - clocks = <&gcc GCC_UFS_REF_CLKREF_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; - clock-names = "ref", "ref_aux"; + clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_REF_CLKREF_CLK>; + + clock-names = "ref", "ref_aux", "qref"; power-domains = <&gcc UFS_PHY_GDSC>; From patchwork Thu Dec 14 09:10:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB470C4167B for ; Thu, 14 Dec 2023 09:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZEreNeHnv5ssBrVji2MRO+ybT9mDIoEmg/XbYsryc4s=; b=aJ6is7JpA2jCqK Req0iiE+ufeITY7vObIW0R4rMNjKuPsS/wKiiLQ88AM88vB+3cHD4XNrW3LVl0s5Dfz+7EG6zqOQR 0Yv6Jsl4hptkBS2xxs+NkJdc0M/s9ly/wttGaA4hkqODj9kswiFbDVu8nDewSmvP4sYUkPsEJHZ4X IgC94mxJ2U1k7FGrdX4WrIYIvrPPWcglNkQdhHCGiJ2pLDYfrq9A96p7iDzOlcV9xSZ9wnuiFXxpR R5v9iew9D0Vuof0JLziCMBTVHHK7mBVPE873b+ng/OFT9daDIH0jRNJtb795Uf76KZzPq2ItXU+0K KpPXCI+YP7bqozpym48Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhkm-00HJZ1-29; Thu, 14 Dec 2023 09:11:36 +0000 Received: from mail-oo1-xc30.google.com ([2607:f8b0:4864:20::c30]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhkj-00HJXK-2Y for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:11:35 +0000 Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-59067ccb090so5127749eaf.1 for ; Thu, 14 Dec 2023 01:11:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545090; x=1703149890; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qSz/bHjwwlCoYKLoGELFqaslJ84OPxmUtiMSGQ7rw5w=; b=q9dtxl77Gc2237mjnklnwHdvZ/53Lmxxu9xXYlIWuvAQm6wns5IMhVnsUxBe/wWxZH gv2NSqtxv0CL/hmYjjo7CFLjP/wjAndPFFHQPGacXrIw2h9mRwFpmXez4rWrWp/yy4+8 KO7cqzX5GXr8Ep+rrW7fdIfaG+AP4xHpiP/yiw9pzAudOCIshod8zVUsI/Rap0rH7hoz CJimKFcEQdLS1yXLJygSmYfon04PasIxnSHB7bT0LmFak274Ih8L0XN/4lKjRSeIMDvR bTuu2JS/RecdR+3VUetJrnNq0WHMPDkZ0F+1cy1rEHr9rnXtQrN3hEnynel2eDV5Mue3 QDCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545090; x=1703149890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qSz/bHjwwlCoYKLoGELFqaslJ84OPxmUtiMSGQ7rw5w=; b=IXKJ4FZyznnVQ3BewfLXGy1hR30ApeP6b3wReNbhBCb/ZcHqngPiJsOSFJaLmhJFD9 oOnqZiDhRIgpLMt50nOpBZgbF+Yrq3W4FbX+aARN0HdkyDrPRdLe6BX4FVXa6EKCs5Hq x4GewREd/vYsh3d3EpUPkvQl6I9L+4IjR/FkVBYTwdjhWNuAAiB6DOp6ht+PgJgwUT1D 0+wLTb2lZ7XdVPYYU5dGTHmM8vSimMvXJMyUiPTJ7sa8i8Wdl8YANWwL+PcANdyruhFv Qlh5+vDwALf2dZxKKHPWMg8mSeKbFlS7bfvNp66hRC2Umq2yr163M/fGnycie1euOLWa UzUA== X-Gm-Message-State: AOJu0YwCSvXNQSBwruyFHLUNvUMQjfiPr54KsX1spGa1KiORuRkp83kO dtqe640aamY/9cudJaGcLNmuYgoe7j3959kD4A== X-Google-Smtp-Source: AGHT+IFUVL6JpWZGgVnmUsFb1wbwEnnw9CziVP9PAhqAu89DLKiGvOjnVwYt+11NDZPhiMjBcQeYqQ== X-Received: by 2002:a05:6358:7504:b0:172:962c:cb2c with SMTP id k4-20020a056358750400b00172962ccb2cmr1593062rwg.14.1702545089664; Thu, 14 Dec 2023 01:11:29 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:11:29 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 02/16] phy: qcom-qmp-ufs: Switch to devm_clk_bulk_get_all() API Date: Thu, 14 Dec 2023 14:40:47 +0530 Message-Id: <20231214091101.45713-3-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011133_828802_9FF57E29 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Device drivers should just rely on the clocks provided by the devicetree and enable/disable them based on the requirement. There is no need to validate the clocks provided by devicetree in the driver. That's the job of DT schema. So let's switch to devm_clk_bulk_get_all() API that just gets the clocks provided by devicetree and remove hardcoded clocks info. Signed-off-by: Manivannan Sadhasivam --- drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 61 +++---------------------- 1 file changed, 7 insertions(+), 54 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c index 514fa14df634..174b105fda82 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c @@ -837,9 +837,6 @@ struct qmp_phy_cfg { /* Additional sequence for HS G4 */ const struct qmp_phy_cfg_tbls tbls_hs_g4; - /* clock ids to be requested */ - const char * const *clk_list; - int num_clks; /* regulators to be requested */ const char * const *vreg_list; int num_vregs; @@ -865,6 +862,7 @@ struct qmp_ufs { void __iomem *rx2; struct clk_bulk_data *clks; + int num_clks; struct regulator_bulk_data *vregs; struct reset_control *ufs_reset; @@ -897,20 +895,6 @@ static inline void qphy_clrbits(void __iomem *base, u32 offset, u32 val) readl(base + offset); } -/* list of clocks required by phy */ -static const char * const msm8996_ufs_phy_clk_l[] = { - "ref", -}; - -/* the primary usb3 phy on sm8250 doesn't have a ref clock */ -static const char * const sm8450_ufs_phy_clk_l[] = { - "qref", "ref", "ref_aux", -}; - -static const char * const sdm845_ufs_phy_clk_l[] = { - "ref", "ref_aux", -}; - /* list of regulators */ static const char * const qmp_phy_vreg_l[] = { "vdda-phy", "vdda-pll", @@ -948,9 +932,6 @@ static const struct qmp_phy_cfg msm8996_ufsphy_cfg = { .rx_num = ARRAY_SIZE(msm8996_ufsphy_rx), }, - .clk_list = msm8996_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(msm8996_ufs_phy_clk_l), - .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), @@ -986,8 +967,6 @@ static const struct qmp_phy_cfg sa8775p_ufsphy_cfg = { .pcs = sm8350_ufsphy_g4_pcs, .pcs_num = ARRAY_SIZE(sm8350_ufsphy_g4_pcs), }, - .clk_list = sm8450_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sm8450_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v5_regs_layout, @@ -1020,8 +999,6 @@ static const struct qmp_phy_cfg sc7280_ufsphy_cfg = { .pcs = sm8150_ufsphy_hs_g4_pcs, .pcs_num = ARRAY_SIZE(sm8150_ufsphy_hs_g4_pcs), }, - .clk_list = sm8450_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sm8450_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v4_regs_layout, @@ -1054,8 +1031,6 @@ static const struct qmp_phy_cfg sc8280xp_ufsphy_cfg = { .pcs = sm8350_ufsphy_g4_pcs, .pcs_num = ARRAY_SIZE(sm8350_ufsphy_g4_pcs), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v5_regs_layout, @@ -1080,8 +1055,6 @@ static const struct qmp_phy_cfg sdm845_ufsphy_cfg = { .serdes = sdm845_ufsphy_hs_b_serdes, .serdes_num = ARRAY_SIZE(sdm845_ufsphy_hs_b_serdes), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v3_regs_layout, @@ -1108,8 +1081,6 @@ static const struct qmp_phy_cfg sm6115_ufsphy_cfg = { .serdes = sm6115_ufsphy_hs_b_serdes, .serdes_num = ARRAY_SIZE(sm6115_ufsphy_hs_b_serdes), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v2_regs_layout, @@ -1136,8 +1107,6 @@ static const struct qmp_phy_cfg sm7150_ufsphy_cfg = { .serdes = sdm845_ufsphy_hs_b_serdes, .serdes_num = ARRAY_SIZE(sdm845_ufsphy_hs_b_serdes), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v3_regs_layout, @@ -1172,8 +1141,6 @@ static const struct qmp_phy_cfg sm8150_ufsphy_cfg = { .pcs = sm8150_ufsphy_hs_g4_pcs, .pcs_num = ARRAY_SIZE(sm8150_ufsphy_hs_g4_pcs), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v4_regs_layout, @@ -1206,8 +1173,6 @@ static const struct qmp_phy_cfg sm8250_ufsphy_cfg = { .pcs = sm8150_ufsphy_hs_g4_pcs, .pcs_num = ARRAY_SIZE(sm8150_ufsphy_hs_g4_pcs), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v4_regs_layout, @@ -1240,8 +1205,6 @@ static const struct qmp_phy_cfg sm8350_ufsphy_cfg = { .pcs = sm8350_ufsphy_g4_pcs, .pcs_num = ARRAY_SIZE(sm8350_ufsphy_g4_pcs), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v5_regs_layout, @@ -1274,8 +1237,6 @@ static const struct qmp_phy_cfg sm8450_ufsphy_cfg = { .pcs = sm8350_ufsphy_g4_pcs, .pcs_num = ARRAY_SIZE(sm8350_ufsphy_g4_pcs), }, - .clk_list = sm8450_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sm8450_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v5_regs_layout, @@ -1296,8 +1257,6 @@ static const struct qmp_phy_cfg sm8550_ufsphy_cfg = { .pcs = sm8550_ufsphy_pcs, .pcs_num = ARRAY_SIZE(sm8550_ufsphy_pcs), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v6_regs_layout, @@ -1383,7 +1342,7 @@ static int qmp_ufs_com_init(struct qmp_ufs *qmp) return ret; } - ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks); + ret = clk_bulk_prepare_enable(qmp->num_clks, qmp->clks); if (ret) goto err_disable_regulators; @@ -1403,7 +1362,7 @@ static int qmp_ufs_com_exit(struct qmp_ufs *qmp) reset_control_assert(qmp->ufs_reset); - clk_bulk_disable_unprepare(cfg->num_clks, qmp->clks); + clk_bulk_disable_unprepare(qmp->num_clks, qmp->clks); regulator_bulk_disable(cfg->num_vregs, qmp->vregs); @@ -1573,19 +1532,13 @@ static int qmp_ufs_vreg_init(struct qmp_ufs *qmp) static int qmp_ufs_clk_init(struct qmp_ufs *qmp) { - const struct qmp_phy_cfg *cfg = qmp->cfg; struct device *dev = qmp->dev; - int num = cfg->num_clks; - int i; - qmp->clks = devm_kcalloc(dev, num, sizeof(*qmp->clks), GFP_KERNEL); - if (!qmp->clks) - return -ENOMEM; + qmp->num_clks = devm_clk_bulk_get_all(dev, &qmp->clks); + if (qmp->num_clks < 0) + return qmp->num_clks; - for (i = 0; i < num; i++) - qmp->clks[i].id = cfg->clk_list[i]; - - return devm_clk_bulk_get(dev, num, qmp->clks); + return 0; } static void qmp_ufs_clk_release_provider(void *res) From patchwork Thu Dec 14 09:10:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492598 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59DC9C4167D for ; Thu, 14 Dec 2023 09:11:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1AeJicluiiD8Rj+y2XmteEvU6MbX1uwTRGR8r0GW6gA=; b=gpId0FCFtiMPHX 7WCB76VAiKbJUDcnONgb32BxyVADUpaSQgi5+LanikgM/MFPSzw/U0uA3VHNXl6kEr2UAFYnwChi+ RrIBbiJNjweYDugqjeNYH9IOzYsKF+ib/2eN7Y/RDmLoULXKiWt8z6SavMltTOXO20XveVQUP70g3 9BI/JFBK5A6hpxsCqucFCWLYBeVGuDxKQ1lv2QPHe0I4fMGk4A7FbPheo6Xlwup/jYRtwOi5towZZ XKlJAzwV+kenqcKq2ZkzvQ3PATZeKi8hYZCrjSAINmkCjJ2lyvIkBOAUMNYXIwdlMNeFs1I8CiU1R xSTx1uvAoLwu1YhMAnrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhks-00HJaK-0I; Thu, 14 Dec 2023 09:11:42 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhkp-00HJYy-1c for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:11:40 +0000 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-77f8308616eso214826085a.2 for ; Thu, 14 Dec 2023 01:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545095; x=1703149895; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4lYTGtSYRVAJ3w0j3YsinoBhP2NVVpIT5xX2iQPFdpw=; b=QfyGjxoSfFBqekD2/NTj8c+FPmgALDOqG1DUfSe21MRboLjyBbV8aIkNZC390rpBxh rp+aVe0WsAmsALetPyZkFIEINoQcHAxMbI5BXAbWxkHVZKHJy7lcO366P1VHm6JCiSjs TmeRhHXjxTOHifX3u4xRzEqCLbZwpKvD4BstKbzaWZ0KgTkCanb51Do9S2P+OtP+vd2A n7T2dUL7ATggMC6nm+EMWAMovjbEm0mKi6TYGBB3u60La2bLdrxU2edG2c8nwkdXs4dk Xd8+LM7Ng311oWPJniG1vIVHOsrjSy0mfLdIyXx6AyTWz+wWgOXxLt2nsMcpRAoQv8Fi PDVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545095; x=1703149895; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4lYTGtSYRVAJ3w0j3YsinoBhP2NVVpIT5xX2iQPFdpw=; b=A1MS/4moZfV+PXoORqQ7I606DeOsLKr3vtMxFDmu2kxIuKS/ABQrysWqEQFxF6uEdj KzDFdEeSBAJVGzwk6IXqznUZEm+PRC/AWuVhhS5rBc+7LzipwwbQvZQb4UCrWGOmx15O wdwAYVU266OBW2mD4WXN8x4iMO9TPRUT6tYa5rwumiTnyhcvcebCn5mXed7ujN1heUC0 orx1ngkDzpZWX4TEOKfblZs0xx73fx7NHDGf5if1V7F7wNJD74z0QRo9qoiPiqT+ydir KQy0iehIWU+hAfHKsgBslGFXYiIKmEhVWh5NU3QqrqWNLwcStpESvIzQ52PzfrxRb2ms PsSw== X-Gm-Message-State: AOJu0YyY0225EhMru50pABvcnbr+Zhy6jujzytp+TdfQkjxtaG4vkRDC ubTSnGAfh0XYvLt7zUxooRQK X-Google-Smtp-Source: AGHT+IGKjUtEbBXnGiZjfUn0k6n+eh/VheFJ4i3/ykfZueH9WXrg9HF8KfVn30FUrPoO37tXWztR1g== X-Received: by 2002:a37:ad03:0:b0:77e:fdb2:1598 with SMTP id f3-20020a37ad03000000b0077efdb21598mr9933316qkm.10.1702545095584; Thu, 14 Dec 2023 01:11:35 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:11:35 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 03/16] dt-bindings: clock: qcom: Add missing UFS QREF clocks Date: Thu, 14 Dec 2023 14:40:48 +0530 Message-Id: <20231214091101.45713-4-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011139_535763_4B87E8E1 X-CRM114-Status: UNSURE ( 7.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Add missing QREF clocks for UFS MEM and UFS CARD controllers. Fixes: 0fadcdfdcf57 ("dt-bindings: clock: Add SC8180x GCC binding") Signed-off-by: Manivannan Sadhasivam Acked-by: Conor Dooley --- include/dt-bindings/clock/qcom,gcc-sc8180x.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dt-bindings/clock/qcom,gcc-sc8180x.h b/include/dt-bindings/clock/qcom,gcc-sc8180x.h index e893415ae13d..90c6e021a035 100644 --- a/include/dt-bindings/clock/qcom,gcc-sc8180x.h +++ b/include/dt-bindings/clock/qcom,gcc-sc8180x.h @@ -246,6 +246,8 @@ #define GCC_PCIE_3_CLKREF_CLK 236 #define GCC_USB3_PRIM_CLKREF_CLK 237 #define GCC_USB3_SEC_CLKREF_CLK 238 +#define GCC_UFS_MEM_CLKREF_EN 239 +#define GCC_UFS_CARD_CLKREF_EN 240 #define GCC_EMAC_BCR 0 #define GCC_GPU_BCR 1 From patchwork Thu Dec 14 09:10:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492599 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBFEFC4332F for ; Thu, 14 Dec 2023 09:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=chuoXiZzmrJRTMSHTrmjp76jwU4DeCxEBs9PCWHXKZo=; b=nr04Q7NxBtT1qO EBfpHx4aTfjKyzas8UmnrYvaYjrDTwUqCOW+/u/dYtunrsikQKBndgV636VbThGsFfrW1pV8kSPn9 y3zP/Bgxxzs2IJBMX+DNnukR8OsjcZoU2RjptBz1LPyWJ6Bx3+vZk7AtJrbyExO6Rqd04Z51KdzPm 7Woc1tWbOFCWfHOSNyqtnrz81U+OSE0CcOrCeLtAi9JfsiAX+Cy4gZIDlyAdMbleDTzakVr5+Z73T YHgs7+txtslkv32pqQQT7fvgkAr4sE2IwNDNo0Q5MeSWwsY1C48dY5UZAO19+S8uaWyahFH7yWfZe d2fafazpbciZfKdspldg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhkw-00HJav-1b; Thu, 14 Dec 2023 09:11:46 +0000 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhkt-00HJaJ-2C for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:11:45 +0000 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-77f56750defso343323185a.1 for ; Thu, 14 Dec 2023 01:11:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545101; x=1703149901; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1DxFXPJYgIG7bY+rEjLLq6eWKt7yGgrHuHLxSAUgD04=; b=mbk1TMWTHtiTGhxT+hOjOh7V9tEBsOMt51T4A6YPLjVY5DvWAbH5Cv0YiLGAz35Ssw YX3py1AIg9nrDzKKttLwdcCFKHU665AKSew87ua/rocB9vt7mCyRG6MJW2CvyACouMgn rOgOUGaQs1RN5S8nCJkoBha3FBY7gD/lg+ajuWw9/V9BD+9EG6xoMtBpVcE1V+2Scuc6 s2LzA5wz/dipeIahss4xkSK3MVgVcenWTcsLnX1clEB5ur/zNDTgkyC7S/hBZEmNv3th BrVfp6nPdIQ7s0r0xruanxoufE8f35mg9rceBo9ueGi3GN8MTVR3JtSZTLZ0FZ/ejM3x 42ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545101; x=1703149901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1DxFXPJYgIG7bY+rEjLLq6eWKt7yGgrHuHLxSAUgD04=; b=VjAjQVLgOZcqzWcZumrgvEDyIM1asSf60QKwnEiQu0Fiz1NeZ4UD06Lkqabu1NAyEM eEbxU7JfJCcgzt5PfrHHmbQiE0gl7zNGXjVxZmmG5hahvMpGMgucLzzsRmPTmQfwuPhH TlwmkGIkBTGM6f5L9mwZSC7m6PljgahnY/VG/c6GO7vSa1i0HPDaSv8Y3RYM0v4J/idu L6kmeBhe1lc4w5xaGw4rQuabYWBnnRzm4qHkxcs4DPHsd6EIZQ69MAugb64cXRUb76x+ mAMMQea6wZBxVfyH31QY/uRREAX0Q5+pfB7UBFof4HCHc7b7U3T2x4V6DXcCYgZNQ08+ 3Xew== X-Gm-Message-State: AOJu0YzewV6CZCntHoaDOpc8o6mkDX/12EVPPgNpRQhNZvoC5Jpf1xD2 T2AwFVkp41Lbh76YE0OULkMa X-Google-Smtp-Source: AGHT+IFGeYRRHFMd5RKI2JUYh2LUqufJuMqCc51bmtyQWkYRShHZtBSfcVSJiI4Tsb3u+TyDOkV2ug== X-Received: by 2002:a05:620a:cef:b0:77e:fba3:4f0e with SMTP id c15-20020a05620a0cef00b0077efba34f0emr9799895qkj.100.1702545101407; Thu, 14 Dec 2023 01:11:41 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:11:41 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 04/16] clk: qcom: gcc-sc8180x: Add missing UFS QREF clocks Date: Thu, 14 Dec 2023 14:40:49 +0530 Message-Id: <20231214091101.45713-5-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011143_719512_15E11550 X-CRM114-Status: UNSURE ( 9.16 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Add missing QREF clocks for UFS MEM and UFS CARD controllers. Fixes: 4433594bbe5d ("clk: qcom: gcc: Add global clock controller driver for SC8180x") Signed-off-by: Manivannan Sadhasivam --- drivers/clk/qcom/gcc-sc8180x.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/clk/qcom/gcc-sc8180x.c b/drivers/clk/qcom/gcc-sc8180x.c index ae2147381559..544567db45f1 100644 --- a/drivers/clk/qcom/gcc-sc8180x.c +++ b/drivers/clk/qcom/gcc-sc8180x.c @@ -3347,6 +3347,19 @@ static struct clk_branch gcc_ufs_card_2_unipro_core_clk = { }, }; +static struct clk_branch gcc_ufs_card_clkref_en = { + .halt_reg = 0x8c004, + .halt_check = BRANCH_HALT, + .clkr = { + .enable_reg = 0x8c004, + .enable_mask = BIT(0), + .hw.init = &(const struct clk_init_data) { + .name = "gcc_ufs_card_clkref_en", + .ops = &clk_branch2_ops, + }, + }, +}; + static struct clk_branch gcc_ufs_card_ahb_clk = { .halt_reg = 0x75014, .halt_check = BRANCH_HALT, @@ -3561,6 +3574,19 @@ static struct clk_branch gcc_ufs_card_unipro_core_hw_ctl_clk = { }, }; +static struct clk_branch gcc_ufs_mem_clkref_en = { + .halt_reg = 0x8c000, + .halt_check = BRANCH_HALT, + .clkr = { + .enable_reg = 0x8c000, + .enable_mask = BIT(0), + .hw.init = &(const struct clk_init_data) { + .name = "gcc_ufs_mem_clkref_en", + .ops = &clk_branch2_ops, + }, + }, +}; + static struct clk_branch gcc_ufs_phy_ahb_clk = { .halt_reg = 0x77014, .halt_check = BRANCH_HALT, @@ -4413,6 +4439,7 @@ static struct clk_regmap *gcc_sc8180x_clocks[] = { [GCC_UFS_CARD_2_TX_SYMBOL_0_CLK] = &gcc_ufs_card_2_tx_symbol_0_clk.clkr, [GCC_UFS_CARD_2_UNIPRO_CORE_CLK] = &gcc_ufs_card_2_unipro_core_clk.clkr, [GCC_UFS_CARD_2_UNIPRO_CORE_CLK_SRC] = &gcc_ufs_card_2_unipro_core_clk_src.clkr, + [GCC_UFS_CARD_CLKREF_EN] = &gcc_ufs_card_clkref_en.clkr, [GCC_UFS_CARD_AHB_CLK] = &gcc_ufs_card_ahb_clk.clkr, [GCC_UFS_CARD_AXI_CLK] = &gcc_ufs_card_axi_clk.clkr, [GCC_UFS_CARD_AXI_CLK_SRC] = &gcc_ufs_card_axi_clk_src.clkr, @@ -4429,6 +4456,7 @@ static struct clk_regmap *gcc_sc8180x_clocks[] = { [GCC_UFS_CARD_UNIPRO_CORE_CLK] = &gcc_ufs_card_unipro_core_clk.clkr, [GCC_UFS_CARD_UNIPRO_CORE_CLK_SRC] = &gcc_ufs_card_unipro_core_clk_src.clkr, [GCC_UFS_CARD_UNIPRO_CORE_HW_CTL_CLK] = &gcc_ufs_card_unipro_core_hw_ctl_clk.clkr, + [GCC_UFS_MEM_CLKREF_EN] = &gcc_ufs_mem_clkref_en.clkr, [GCC_UFS_PHY_AHB_CLK] = &gcc_ufs_phy_ahb_clk.clkr, [GCC_UFS_PHY_AXI_CLK] = &gcc_ufs_phy_axi_clk.clkr, [GCC_UFS_PHY_AXI_CLK_SRC] = &gcc_ufs_phy_axi_clk_src.clkr, From patchwork Thu Dec 14 09:10:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492600 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43115C4332F for ; Thu, 14 Dec 2023 09:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l9KC+OzREHkw5GV/sCPU3tQJKB2+Asqtxfgj2y238/M=; b=R76QVg18xehv19 wTq3HrwBDMRLpOrRczKgruV/2oZr/WNqL9vClKtus17VsPB4cfQh0hxtaLvctKJyW8JEyPA6SYt82 99+VFoSVbkf+8ECxaaP+xgDo0IBtih+QgajuKVOlcbJWLC2mSE0ByH9bsORvU/86DGwr8H+qnli59 /6jbXKLqPrkQPjr/QKJt8lhNZBhR6+EE2H3fzOEtDSXDuKcAKQ4USQiQCGxv2xGIWFcv77qt9m9AI BsqG5dqKLGMd2jQxsElfd1A2qmWb659SYQu4A97GpqiUTGz3OOL6j8/n2xjeBYFRNsRFmHSqLQ/VH cCTOBmkB1JjSiBov7zDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhl3-00HJcZ-3D; Thu, 14 Dec 2023 09:11:54 +0000 Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhl1-00HJbR-0h for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:11:52 +0000 Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-77f320ca2d5so33907785a.1 for ; Thu, 14 Dec 2023 01:11:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545107; x=1703149907; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KzU01i6st7Fo+4S1d9zRuY0iUyHKgjsO1CA7YDVBW60=; b=ffpb9hqFxlXCVhIC3QGXqSf4B9aqvMDqEHL1H4RGq+BpsWJBJjCHrFFOC+WlkHDVRI +8SIdZ2nzYUqsAR4FePTDKPvvNNJdlVXIjkN8v99BbISOhSJ0vWGRUYrbGK5/j1mXZXW 8rhIg9yYBIQtz8QzTKjKXQ36LIAWU6GUQe0SOYNw++x+XDen/3VnbgvjfddjZoyZeMXg ID5QBoNbAWgP2DmR5hvKJ0atB4bNQ3/ObfUGMB2bkUQhRdX0IZmJHRUm8f7n31cXdD+0 PPRktBAnYpufc6ZHiU4MX6zvsQOsfDJFmW/lU7YkuREzaITz889GBProZKIoyNC5pPno fimQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545107; x=1703149907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KzU01i6st7Fo+4S1d9zRuY0iUyHKgjsO1CA7YDVBW60=; b=r14mPAWRUqY2A0g25riC6r8WxV8L9VVJN9O1XZsIDcHHYvUUFEmlTOtENqRyP0uE81 lID/78bqyp9MttPNFUgM6YXTaSPd0eCNkTnBA14GiI32Qcms4UXB5PPIp6wfQsJ16so6 YULy+M1KFXAxgMpEb/rc+YCz/LsH3uu8OQh4tHXB5jERQI28XRLgYIVEC8y53zbtOwuZ xTTbLtGyPeopdng60phPd6K5L80qLInLChc9zUWpywGDcpxRpziLHcREg1NHLwf/CM0T Yv4OIH4KYv2e1KctoOm+2YZhzBt1HLdveDXus3LCV4ATVpnfScUbgc7n4DHpR3uaP8zD f4Bg== X-Gm-Message-State: AOJu0Yxk1vw+Hq1Iv8bMfqzfSLNYd6g/HyOJSwSZSJHBPOhW3bamoQv6 yinsWNymIfKFnzIPkNtKKO64 X-Google-Smtp-Source: AGHT+IHt2uvwSeovh51fDULXRLbHd6A/TplrDLayAqqLdOB2HDbSO4NgNckuHMbr0eqUuRBeW5jSOg== X-Received: by 2002:a05:620a:6007:b0:77f:2f54:f990 with SMTP id dw7-20020a05620a600700b0077f2f54f990mr14664887qkb.67.1702545107292; Thu, 14 Dec 2023 01:11:47 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:11:46 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 05/16] arm64: dts: qcom: msm8996: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:40:50 +0530 Message-Id: <20231214091101.45713-6-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011151_256357_86EBFE62 X-CRM114-Status: UNSURE ( 9.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in MSM8996 requires 2 clocks: * ref - 19.2MHz reference clock from RPM * qref - QREF clock from GCC Fixes: 27520210e881 ("arm64: dts: qcom: msm8996: Use generic QMP driver for UFS") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 6ba9da9e6a8b..b235f1d651aa 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2105,8 +2105,8 @@ ufsphy: phy@627000 { #size-cells = <1>; ranges; - clocks = <&gcc GCC_UFS_CLKREF_CLK>; - clock-names = "ref"; + clocks = <&rpmcc RPM_SMD_LN_BB_CLK>, <&gcc GCC_UFS_CLKREF_CLK>; + clock-names = "ref", "qref"; resets = <&ufshc 0>; reset-names = "ufsphy"; From patchwork Thu Dec 14 09:10:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492601 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 996BBC4332F for ; Thu, 14 Dec 2023 09:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pLJyx+owKN5vbaAXEip/ncSGXT2I07AxymFXBQSAaS8=; b=pNlwE+Jo0MUcu8 EXockviTeJoZmHmjZ+vU7Af5VpbMLIsmYBrYeUynpjPT3yMqUev1Df2AoA8GrRotaA416wPJ11Ojq Zmy37GRDbMvLXj4MN/HRy3Btebm2DPbrzEKfXPQLVAw+hMCxkcD/7O0P3HAFJ6wiRwaVuxCS6K/ag Y7LRuIZbqX1MaanmBoboY9LOk6FgiWFr+nIpHHxBXM36QheW1H8Kq9NA7P8g3EXuENLDR/xj9+eTy Hwvw+St8TjDHogYJoMkWGOg33Yxs/ZwVaaA9yLFdKXtDgCikDowlI334qN2XognJW08tomulIAvHA hUp9cAc06JUiJ/AUdeWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhl7-00HJdb-1B; Thu, 14 Dec 2023 09:11:57 +0000 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhl5-00HJcY-0Q for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:11:56 +0000 Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-77f37772ab6so490901485a.0 for ; Thu, 14 Dec 2023 01:11:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545113; x=1703149913; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E7tHzmERAQbZImeje4EMokx1gYyccc/9b3w+T8ZyCDU=; b=dmd0AUJmHPwBVca6vSj7zcRMQCRRMegxnuI9pewpeuaRHlHToxL0opCmt38XaCMTBo 0onWNxPwyRTLCKtVPi6WOlwJZtKhYx9iQP91JWQEefpFD6uJ7urts3ylOxmQzdJYGlZf YQUvUG75dHybVGo/tvdJmL74V1NrALjD8aBK+MX2nRVXukk8Mz3youogheH3W1M57PG5 lYnVNgCNP/QRy8BAagUBBhF1UVthJxiN+pVZBEohUVFA7e2AcL2x8RrH1vURsPb9BQp+ CXYffF7Mcl8cuGGJE01HfNPT2exzRbn+2XZkBJ5d4rQzyxeqRD1SB7J90g08RnNz4vup UktA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545113; x=1703149913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E7tHzmERAQbZImeje4EMokx1gYyccc/9b3w+T8ZyCDU=; b=WPTvuupS9M2DpqIuTy+i/g2DOAbEK8/pqZH9t2w3yvwb3J0OwnsZlHN0ZkAEEu682H 0t9oHe62X1LWtqSx8qFQWSHrlH33fp5zFCWe+IGoADkojoz15zKuOeIxeUvqPyH1GqpA 50TOBrEqJ7BBFIbb8M5eIDFWnCUHTRSQ8BKKN+/JWjU2l3n6YH6YKMEl1fyS/PSL7mXA SSqAmDzTWPcn26Zs+wBh/8sNsSvfD+EHg5f3sTYwhdXhrQOilnLb+qooWvmqwMNIyYpf BkK1eegS2NTMYghM3ObrMP/Cmb1DIxI7x48yXr1Gs9+Q/yjczO/YbDeYfyOxNxffkalt X2UA== X-Gm-Message-State: AOJu0YzdSNDOsfX+Yw/DGeK3VdAM8/y9KzX++3EyC2gsjcTfRmHrg2IG YeoZtBCHQ1td5zoQZCUmBnUL X-Google-Smtp-Source: AGHT+IGGOd9jlu9qhHJFGypL3G+lZIGRt/9aClzI8nCmgZYkeu4ehYfW0e9S6L8lARh5IDvJykKmNA== X-Received: by 2002:a05:620a:21d5:b0:77f:3813:4212 with SMTP id h21-20020a05620a21d500b0077f38134212mr11387231qka.86.1702545112885; Thu, 14 Dec 2023 01:11:52 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:11:52 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 06/16] arm64: dts: qcom: msm8998: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:40:51 +0530 Message-Id: <20231214091101.45713-7-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011155_169202_4193D90F X-CRM114-Status: UNSURE ( 8.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in MSM8998 requires 3 clocks: * ref - 19.2MHz reference clock from RPM * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC Fixes: cd3dbe2a4e6c ("arm64: dts: qcom: msm8998: Add UFS nodes") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index b6a3e6afaefd..d4c55e2b0043 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -1051,12 +1051,12 @@ ufsphy: phy@1da7000 { status = "disabled"; ranges; - clock-names = - "ref", - "ref_aux"; - clocks = - <&gcc GCC_UFS_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_AUX_CLK>; + clocks = <&rpmcc RPM_SMD_LN_BB_CLK1>, + <&gcc GCC_UFS_PHY_AUX_CLK>, + <&gcc GCC_UFS_CLKREF_CLK>; + clock-names = "ref", + "ref_aux", + "qref"; reset-names = "ufsphy"; resets = <&ufshc 0>; From patchwork Thu Dec 14 09:10:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492602 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F5CDC4332F for ; Thu, 14 Dec 2023 09:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ik+7u2/eCVG+k1Jujzb5qXo+FdrwJcjOBLUTgxjiSJc=; b=P8rIB2J2eYF1Mq +vWpabmdwDSxAL+7ikwrxDP78qwxxu4K+noAyh69HJpx0BCMXCsbOc3u6YStDmPHIpUgz1k3JZJX/ rQDeWfooJD9Em4+wJAyB/mUuKq7j8C2aCzfJcW8pCfNIbzUJa461I3Z+fPdFo3YbLFOdreUCOyMBm qnpqrQIXJFB8MVXglcYr6p559MX1Ww1a2+EnE2GTa8UM+6KksupNNIFaeEQyKZylp9Mttx9FQ3d/g kGVlHOUjE0K7MRaIvLq+a8t39SvnYt5UqwT5UzUdMn3Kk4nMv9a5OX//skVkUZmtHDJ9oOV6SQt2c FnIhWPql/GD71OAvWAxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlE-00HJev-2j; Thu, 14 Dec 2023 09:12:04 +0000 Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlB-00HJdu-2l for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:12:03 +0000 Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-3b9e07690ccso5129437b6e.3 for ; Thu, 14 Dec 2023 01:11:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545119; x=1703149919; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bQdElwhJNkunjNkKmQMPCEqC6kOTfOJsifUeDg9TJE0=; b=eNeDN4I1cQwhkygEdHn1LrpTJXWHE7qw6c1imrDer01vVyLHMLkyHU2s52V0Ue36kQ wCmFEvIPJEb1S6sWpBGFsK5hiUa4r+zdje25QEfROL3y1rbU0ePRFnpcjv9X4ta2r4w0 krygmzPQi5Uc3j1GU5NQxgc14oIRBt3v1x6cxg1zT4K+PdYiu3hIGtZqKrMC9MbSRazo Yp2Wgh6wPVzfcs/H8dAon34zxKMSscWOj26JRcetpvxHXwnvYDRdSYlsltljfM0z3H7T aq2QjtqlBSsiiuJlAS18F29meb9Z7uFmOkzbp7/KpQK37NMG3JMCaIE/HQwlC11Nxqi2 lfcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545119; x=1703149919; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bQdElwhJNkunjNkKmQMPCEqC6kOTfOJsifUeDg9TJE0=; b=u2l2EereoVwF53sEmouXSR+nvojJ9ITWCT77UkWkJzwcJ6CoXj6oKgou8Yacpt0EXd 9OWZz0eVf3ZG5SHbNuiyZ7/zDkmVhaH9b9WUd1A1QUtU2OnHvPlgJWf/KkS6i4vZp5FU wlf8l+R8TBcfnXfWhMxJMzg5dn8+ULlTCm9lraDXqwSmwz2ZqgZDl5wsEtdxW7vQzala 6E0F71aBO3nE5WkY73cJcAygdkKptXX72MH3S9SsNWMOAezhJoEu2c+CSKGrWana6Pb3 u1vt4SdJorWLS2EnyXw8+tbsBStPloZpP03KnPPOPTsNvwWK2YZpDdOwqh9f3oRvSQmU hLNQ== X-Gm-Message-State: AOJu0Yx70hhmFvQDn4q+7SkSC2NMxmZME4+Jvkyw1pkZrm27FM8CkAbd 69B94gMQCxntkMjvvRXVJ0Hv X-Google-Smtp-Source: AGHT+IE2ZXrQH/tkC6vPcWBqL20LyUag+GiHHbxwgkxRG6aaqafMpRD6r+uRgW7b4qI1XbBm1Rau0w== X-Received: by 2002:a05:6808:1b11:b0:3b8:b063:5d67 with SMTP id bx17-20020a0568081b1100b003b8b0635d67mr11293668oib.78.1702545118828; Thu, 14 Dec 2023 01:11:58 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:11:58 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 07/16] arm64: dts: qcom: sdm845: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:40:52 +0530 Message-Id: <20231214091101.45713-8-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011201_893759_1A33436C X-CRM114-Status: UNSURE ( 8.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SDM845 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC While at it, let's move 'clocks' property before 'clock-names' to match the style used commonly. Fixes: cc16687fbd74 ("arm64: dts: qcom: sdm845: add UFS controller") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index cb3bfd262851..a7529af5bc6d 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -2619,10 +2619,12 @@ ufs_mem_phy: phy@1d87000 { #address-cells = <2>; #size-cells = <2>; ranges; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_MEM_CLKREF_CLK>; clock-names = "ref", - "ref_aux"; - clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Thu Dec 14 09:10:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492603 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86C7DC4332F for ; Thu, 14 Dec 2023 09:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PD6ij3khvuzBY+9Bh9WRb0OQcG55Zw95p+UD5FnKURA=; b=SpproT63mA5YxH UA8p5pDhgc0IlBqC0aJBnQjCwNyVSv4yp/DIds4/pV9UPqaGAMYIvqzYz+HGXGRlBHfUWwEEjxCcN AxkGUeOnOqZDKafAW8uEGw2tZZZT7Yaxo7oi4Z8mR9TYbFmHz66SkJs0/W+K9/NyjvKHX+lKkhfAw wB+J0p/QU7KNaUSdnySct/Q3BPC2s9dtxi3KoZ16UcqgG7VkV3zaPTd9ETGdQ+Qbompaf/csNzqEp 0np2KpU+ppK/pV6mCEZFdGXsxIf1j6woM2d44dMlOLi6bqtIA6ccDlnRgzBuaCEaqHAnw1iY0DINW sbjUCZfdtieoMqRCOznQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlK-00HJgC-0v; Thu, 14 Dec 2023 09:12:10 +0000 Received: from mail-yw1-x112b.google.com ([2607:f8b0:4864:20::112b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlI-00HJf7-0T for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:12:09 +0000 Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-5cece20f006so78772247b3.3 for ; Thu, 14 Dec 2023 01:12:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545125; x=1703149925; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9loaHfrne3H3i5jJvNSoB5V0DmyPKqbag1DqqG2m2L0=; b=KwLX4t8kvwittd3Adl3Ec7WbK482xyaODqppRk7NY5vCQMSurZ1yYb9pw6aqsI/3Oz rt6rXab9WbkbKxjj/HslskPUYmkC33UbKwTbAm1NbgWie+MsZFk3ImW9pWQ2CB3VMA1u 5tVExPXMfGk0MGXK9gFtamSdK84spcalsT/SJrWgeS6K9fnkJ6cZnJAJ7a27tDCEQ0z/ AtszDnSeZJTKRSKahEHYyTUGeEooXWX5Xww/7U9uS4Dzkl+eMfZvW7op+N4KYFwX5AoE wZoG0t/c19POWCepgTdpiJdL+X6TJhJjfbrSdB5rMK7yPtnoL9EsUGnRanGB54HB43Ai LHpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545125; x=1703149925; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9loaHfrne3H3i5jJvNSoB5V0DmyPKqbag1DqqG2m2L0=; b=fZSL0isoEVJQ+inhOW/fLncl2RVJhoHckz7Wvy2PtBSpu971GyMpERhqJrdGGurZbT eQJ4WzDHpXiZBcxrPFLsloNPIbu0tVNsA2UIoP6JPwd41ukAhM8X8VpcKf1/IbDY0aZ/ wxXIscL5+hl1scZsqgQ+/8LgJFiS76mbn12E1UsmL99qN8vUXwZYmwx7qE4aGObt0yFq 7J0mVysWUpAgLyWhXrfkO06V8G++B6QtVzBUEB8C8pqb7F27Gl2VbmU7nfZyhEkwjXZV i/xOgEb0NP8QnGrpc/u8eFWICwTIIAJ8EEYrydWrWSesLq0NcJ7mk3Qj/R5PoOoBOb0A sM7w== X-Gm-Message-State: AOJu0YywdXZlKZfAPVRGlFTkGuITGpMEuXIo68QzyoH79e1nWKeazRbi A3GZtz/NRTagCF8N8UVr2+GJ X-Google-Smtp-Source: AGHT+IGFrvj76C9g7DF6q0IKJE1RWepK4pib253K6Tv9NO1veFIB+KJjqnqPmgkzLZ2ovJOm1w1gxQ== X-Received: by 2002:a05:690c:91:b0:5df:4992:d724 with SMTP id be17-20020a05690c009100b005df4992d724mr7706528ywb.41.1702545124893; Thu, 14 Dec 2023 01:12:04 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:12:04 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 08/16] arm64: dts: qcom: sm6115: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:40:53 +0530 Message-Id: <20231214091101.45713-9-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011208_191451_10CDE57D X-CRM114-Status: UNSURE ( 8.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM6115 requires 3 clocks: * ref - 19.2MHz reference clock from RPM * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC Fixes: 97e563bf5ba1 ("arm64: dts: qcom: sm6115: Add basic soc dtsi") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm6115.dtsi | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi index 839c60351240..40394c412fdf 100644 --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi @@ -1033,8 +1033,12 @@ ufs_mem_phy: phy@4807000 { #size-cells = <2>; ranges; - clocks = <&gcc GCC_UFS_CLKREF_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; - clock-names = "ref", "ref_aux"; + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_CLKREF_CLK>; + clock-names = "ref", + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Thu Dec 14 09:10:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492604 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BFDEC4332F for ; Thu, 14 Dec 2023 09:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+BXy4TYRNXf9tYClNc6Bvn6gLp7Y4E8JAQfmj5ZcfQg=; b=k1W0vd651X2MUb E7o9AIG9oKzWjaIq0aN8gHjLTGOrf2JpxC1AaYpxHiv8pz/s2Ig0SBl0TY9mHTpaGdSJMWjTYuOri Dsm5g/UNIypRF2P9jbfG5c9ma4tXHSfsrRMBcs9N0uovXkwegmylNzxYA/uaxOEkYAQe6zwHwOI66 4iJZec5ZsMcVbhihfcrna9Hn0Pxwjv6IFeU+fyDH5kd7FZnNd4vBHx3xcQdfa86kWlPgJkhVFAmV+ SNLTHeSVeZnDai0kXHbeq1GTp497HnCbEEIWi1GeJAuFg508mtyGhMX5rB31t12/3HcsJt9DC6pxp 8GZmol6m4YQDsg5qnZSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlN-00HJhN-2f; Thu, 14 Dec 2023 09:12:13 +0000 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlL-00HJgd-1U for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:12:12 +0000 Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-77f48aef0a5so278984785a.2 for ; Thu, 14 Dec 2023 01:12:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545130; x=1703149930; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/R/hqTzd/o8JpkxBFS0sj0AJtadDOIWSQt92Ki/rlFQ=; b=t+36pd37vLQjd0XbB5o2tbYvIyhwiv95PAY8Pb24l5NktkeepgC9ABRaq4D8aJVIjn YhFTpjuRgdbPwPfljlU9je+IArB2efQ0Qd5irzZxj/Sm8hkqliKVOwh5nh4GYIkuRzpv doA2n1RJNarA9/M/ht9Tcd1mAucxHK5PeSKwXLnx9w+h1Z/OwS/O5DkJfU/HgrszoJMI O8TC1Fceb7pB/jwUr//yEILXTPXzdYBIixqusx1ZgRe1k7QBeFtt6Iyx6wHRh8MxCRVv zaWNF+DuopqgYQIPyoK1wOyG97Xl48B8/Sgg937wh2KpwrZ2+VGa89JauUkiPg4Vo6He 9dog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545130; x=1703149930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/R/hqTzd/o8JpkxBFS0sj0AJtadDOIWSQt92Ki/rlFQ=; b=CW5Mmz62/UD1ttyNQ1TpOaBx+zcSX28oJ+qLh4zLxX+/Mzqrh/KbN+Yp04P9FA2EDW OXovA9ml9jGv+e9QA+Y3H1LcV3xko3Ejy8cBLmnC2RuEZvSfZ0mxLOdZyDC39qlK4kUT sYCHoTNIepkd+SvCL6q76tAndKUo7Inn3B99rFj1r7130dFBHMI4M4S1chDGSRNbkAG2 bgcaeCVfAsyAKgXnYghsMqafjHypK69RnNrebUAFRJPwIE8kJRg+/ekUT+Fn8bCDWazT IZJAk1fCWiMUGAxF/qOi7x2gHNi/8OxBezKCgLzrMNzvt3pYqSC52uGMoaBHA47bZDeK jJ0Q== X-Gm-Message-State: AOJu0YzUGkmo+YdNY/EaWDQvzlOo9cfsMOBfgtyV5srRMS3PeKYU61xW e/V7wkzmiIF5g7Mw81EYcYfn X-Google-Smtp-Source: AGHT+IH8nNO0Z2A5qhy/eFw6w9HCLUFnLPwuisRFUq9Zu9qVpiWOG+IrWYg6mGZN6+oEXnqT2Pz8tQ== X-Received: by 2002:a05:620a:2707:b0:776:f5bb:f2fc with SMTP id b7-20020a05620a270700b00776f5bbf2fcmr8186278qkp.9.1702545130709; Thu, 14 Dec 2023 01:12:10 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.12.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:12:10 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 09/16] arm64: dts: qcom: sm6125: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:40:54 +0530 Message-Id: <20231214091101.45713-10-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011211_496714_1C0B4441 X-CRM114-Status: UNSURE ( 8.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM6125 requires 3 clocks: * ref - 19.2MHz reference clock from RPM * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC Fixes: f8399e8a2f80 ("arm64: dts: qcom: sm6125: Add UFS nodes") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm6125.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi index eb07eca3a48d..b46d3c1fa47a 100644 --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi @@ -812,10 +812,12 @@ ufs_mem_phy: phy@4807000 { compatible = "qcom,sm6125-qmp-ufs-phy"; reg = <0x04807000 0xdb8>; - clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_MEM_CLKREF_CLK>; clock-names = "ref", - "ref_aux"; + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Thu Dec 14 09:10:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492605 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94C2EC4332F for ; Thu, 14 Dec 2023 09:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TeNbtVpTzB03Q6/WhnCUvLO7dmWGLD8OlGmJtFp+GIs=; b=rat8AusAOu6Cth efGPzeggTdb/v/a/B02xjPQ9AAwtHPtYVCrkm0mf/H0bPdMQTk+I3LFIsllN6cqyTtH/XbguQcs/f W6cWZOYQbCLI4ZDD/XrSnCKl9fUoLe8X2pwq10JKiYyJQAa8sBQyIVLsSb1+eD5K6+4EndLX2vBwd u/uCDVOFVamGKkue32/KptXj/qt11IgygNu1xzEI0geXsRRvsuFbxrXnpMQgBOJ0TAjmOAJ7ilKOi vC/bpiQUuAgX1u82RWu/E6MqWPayjyGgr7QD5DbsxCygM/jJtfH/Cu11zatzehwHbDcKjiwqOLy0T vCiSTCnU7Tt9bzDVtrcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlW-00HJjV-17; Thu, 14 Dec 2023 09:12:22 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlU-00HJiI-05 for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:12:21 +0000 Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-77f380d8f6aso461288085a.2 for ; Thu, 14 Dec 2023 01:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545136; x=1703149936; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h2DCBxer6HmgtNkGKJ5qBuor3JmQBFkVeksd4AY7uXs=; b=V8QzS1XTnEqUsJO54oNxiTjoVDhcuNrS4R1Buw4F1PYuCyKk+fIP9IdB0d8Cb5YiHl cvX84oBk+YoyUZHYbEDwJ7u2NCHdXybpa0dTsCCgsuJu9fMs56ECDqlNayghnJvq1Vu4 SUllG4HVjy7PlJiKq3zs76A5hxJq4v9u0i3Wje2AgI+0ZNqK6ZkFvH/hmOHUYbXvejNO g3LqPH6VyoTdBMxzPUI8HEggEPZJKjrfNN6PlXFVEF/cDzuSl695h8Cpe4UyZfUQPbfh aTs0m9Jf+ef9eSYUrok1makFQ5fli7oMtUc/80VNYTTCLxNgZlWoXHWusmgoNoUa9tj6 1E6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545136; x=1703149936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h2DCBxer6HmgtNkGKJ5qBuor3JmQBFkVeksd4AY7uXs=; b=jbX31HVY9qm1zzCic/aYsYCvuWkDUaw0S6IjauZ0qbd8Z/V4AVHsLl0v4aNpsjLLDS TZ/a0VCMBrYZj1kyYyD0TlvMeBiCLYl48VeeTXY+HXH/tgEXvFDMB/49cBuVab/sx1Ib xiZvON0tsuKLI4mZaWp9KCfR5X6rseTpwCfCaRLtLf0/WDzq1PpepNBGvOLoa0jpQco9 Id5nxtHvCm+VT5lvFl30QL00ZbBmfrswTE4wvdyR3rKIKImz8aVSaUOmmCrv1pt2Ez13 OJz0jXb1hI4dFxvdKDGgOtUJIVnQ+46AnQSXEfpFOJJFhKqIWksasteTMSp18+KfRV6H bBvA== X-Gm-Message-State: AOJu0Ywwz6VYr+HNK2qYFF1310ODiGzGI5YrBupqNTK9jQqPx1iT/1IX 9C9O9EvEwfpJaMb844FgykIf X-Google-Smtp-Source: AGHT+IFeqUZblWasaHyv4TNb43kurEEqUO9LouxNXSij17ija+k+4i+/EtljJ8EFj0dMBIAuZum45g== X-Received: by 2002:a05:620a:6109:b0:77f:983d:9606 with SMTP id oq9-20020a05620a610900b0077f983d9606mr1935569qkn.98.1702545136695; Thu, 14 Dec 2023 01:12:16 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:12:16 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 10/16] arm64: dts: qcom: sm6350: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:40:55 +0530 Message-Id: <20231214091101.45713-11-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011220_067027_13866B13 X-CRM114-Status: UNSURE ( 8.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM6350 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC While at it, let's move 'clocks' property before 'clock-names' to match the style used commonly. Fixes: 5a814af5fc22 ("arm64: dts: qcom: sm6350: Add UFS nodes") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi index 8fd6f4d03490..ef793d48316d 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -1192,10 +1192,12 @@ ufs_mem_phy: phy@1d87000 { #size-cells = <2>; ranges; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_MEM_CLKREF_CLK>; clock-names = "ref", - "ref_aux"; - clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Thu Dec 14 09:10:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492606 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 074AAC4167D for ; Thu, 14 Dec 2023 09:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZhznTXFwkV095RjZ5a3P78PKdHTDR5FKMdBXVw5aCnw=; b=CUgOMvTXwvMyyo OxSGo0HBwKyuyVNQmrZnp7z2GvqaiT/krEnxbxBrN244W3ia3nxLQ/VakaJtvRfj+S74Itk6Jy6PI Ad/48jT2xUGO7wLF2vWoE7cc1OCtE69UPe5pIcqI5efFxmvjK4JJ6i9of6ctAVTxSs77L94HlkSFT MmBvjlD4wiNSkvViBMXz3F4CTedpmKW2Tq5NJ25V66ijffXGeuaxV8o6v24ZFV3eU89vYi36Td1Jy mUn/R3JftdhWPMETACpLfOQv/pIUHBat1Q4LCC9YAmMEZLF1cBmI+TUd+eKXUj1Tv+pvyg1eHNiqO 3103SQxBxu0+unsQwg2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhla-00HJkd-2P; Thu, 14 Dec 2023 09:12:26 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlY-00HJjv-1a for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:12:25 +0000 Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-77f347b0299so490748385a.3 for ; Thu, 14 Dec 2023 01:12:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545142; x=1703149942; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+NpBpw87ancReoayxiYNLEpdh+qbLyvkQJUBfcAOaoQ=; b=lEFRHa3eo6i99JPP0Dne1JM+OQZO3bvtf/DQ2haPglpEgGIILBZZuEKt2GCisHsAx6 CeS+ki4w5I3cDKyW1gCsVkXIe0w5YQdzEqJrLPJIsGZKwOxFfl3ffM/D+9hfpy9D66Sp QGOWwpN9LcjN/fCbLpU1jT7VSs+Fp1ZqTq9aN9PX93HWcqMbVJxBntzvjC4CswN9LM7o tDdsNHf0xfXP1nx/Zrmkj0duybZ/OagKhfTXsGkPUfGIKr6YM/wlGXmOQnF7s08xMmHY rsAJDpb1NsSIbnBEn1d/uLSc6hBTDPw2veaEMt5YVZ+hOJmgCHWrscXNIhFnJUyb1bMg bUTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545142; x=1703149942; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+NpBpw87ancReoayxiYNLEpdh+qbLyvkQJUBfcAOaoQ=; b=gql2A08/mgFxDgptk7E5OqhttgHB9xS3O7HKPl0GWGP4gwvNl6+SaUpr3a6Rgvwqyk aIeJmsD3AwD06f2xPaR+TB9wtPR/Rmil+uZWllzcDZeeXuN2fXwatKOk8WVVLmNG03ka wtxuln2VqCtDUKeWT3pkNnzvHBVosnJM8Pht7Inao/FqKVlY7gs9U2gn9k4wuOdyuoWi VzTeYXApflkuKpw2iqsM4isMPnF6SXwM1hhZYz0Orh+vG2osmDb99pKM6F0prv9CDZ3j K3teHU3Go+DOKddWQvBXtZOdhlBF13kPbSSXCljOdfxaq22hbhqA8v9l3qgrwhTEK8VM dRiQ== X-Gm-Message-State: AOJu0YwqjrFz6iCbEj1eWMNkKBRA89dMBOuRfhF0lm6GdX1RecbgqO1A VxB0BhfBAXb5WAuEiXqi4gKG X-Google-Smtp-Source: AGHT+IHkKGZjjk5nJUoZ+N0uLM2h0SgrsFVpX/16fIAjacSPXopzF1OgPVpV/nLmed6E8PzbjRaw7w== X-Received: by 2002:a05:620a:260e:b0:77e:fba3:81e5 with SMTP id z14-20020a05620a260e00b0077efba381e5mr10587915qko.123.1702545142533; Thu, 14 Dec 2023 01:12:22 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.12.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:12:22 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 11/16] arm64: dts: qcom: sm8150: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:40:56 +0530 Message-Id: <20231214091101.45713-12-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011224_525736_5895B492 X-CRM114-Status: UNSURE ( 8.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM8150 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC While at it, let's move 'clocks' property before 'clock-names' to match the style used commonly. Fixes: 3834a2e92229 ("arm64: dts: qcom: sm8150: Add ufs nodes") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 43d56968a382..18af94852974 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -2065,10 +2065,12 @@ ufs_mem_phy: phy@1d87000 { #address-cells = <2>; #size-cells = <2>; ranges; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_MEM_CLKREF_CLK>; clock-names = "ref", - "ref_aux"; - clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + "ref_aux", + "qref"; power-domains = <&gcc UFS_PHY_GDSC>; From patchwork Thu Dec 14 09:10:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492607 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CA10C4332F for ; Thu, 14 Dec 2023 09:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O2i2En3vWziP0l42oitKQvFZ6KGmnil2kRV5RIh2b1s=; b=tqMEYysE6vZqYS G0mBeKXEaIZITTICa5vYGQn9D4ddzvMxPE5SeEzbCqvQaKE1L4H9vJrsx9HC/F6Nd4/tcnLlpOgja B95O8XQkpTEa4VT7YIHHLOkVYIlIA1D/js/q8TncW7UHfH1CUbWXJVdaUT6GRq9SLZbhZpeqGF/H2 DfSnT06oiMhMgvTugnsl9lHnmQp7ghh5ld2dKYtDfWtmdNSTwZPBsaVcrEpAKi34243mut6xfzBkt vZBwYHrctoGU0MiZxXw2QTErUwqy0FBFpvmPpLsOT8riKcjO+XtZFUzIzSwVv/Zn0Vjf1npwOVwZ8 w3HI4cVdzyd8WXQfofVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlg-00HJlW-0Z; Thu, 14 Dec 2023 09:12:32 +0000 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhle-00HJku-1C for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:12:31 +0000 Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-67ad891ff36so50097016d6.1 for ; Thu, 14 Dec 2023 01:12:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545148; x=1703149948; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gvNQvdCy0O2wlOymvN0iIUEpRjoZ42RcAo4vagPpclg=; b=EqJCZeMfdqPOiMLksWfblTAq+41Xb3S3f/Xh3JbzxZ+L5BatzHykjl3aqyZI1aswAP XEIXUS8deHbV1DFeM8GS8tnQbWBEfbmb9dH2JFzREt9Yqc3CdxyfoBekOunXK3H4xStD nezHd4IyulpiBbL5GCysPxdQjsjW/gTh43YF6tWiR+jaBnu2II9kFL5+8D0Hv8KaTsbN tPRcY9zUHRtRarJE+c1u/c6mgqw2aiVPa+BTZzU028sXqrR2lsC41nbglnJKSZoJI1GR DaxqswfRgLXPmFbVpnRi4fmYo4owqt3q7K47CBqoyfcgRhPoGVdXvmxgsKel9BP9CGbC gZwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545148; x=1703149948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gvNQvdCy0O2wlOymvN0iIUEpRjoZ42RcAo4vagPpclg=; b=NFfs/xBXAL6Vwa7AwOFJRFPMa7w4WPcJWBUFftI++PG0c2xh01Gv/1FILbq1B+4AcE RvgngNZeCDhR6TghYHtPMejDVyfxjoHtWUesMBaKf1eYCbfZ/qK011S7DS5UJ/pf/GZt cpMYfE5nAQzeuHjlhQu2CuyBjt6KhbCpMZt6wQwNektMqCVVmrYowAcbGbX7qTgIeqj1 EYTiq6dzGXGs/ZtWrq6LSHf0OH+1cp8V0pEj0pjJ/uZpyAwr9hu0na4EM41XUycl+TSh 6Jwchm3zywFarho8HT8CFolaYHHmN4DGa9FneQjdmG092F3OabuqpZ7wAjYRFXcZ4TGd 61UQ== X-Gm-Message-State: AOJu0YwvRm8h2CJHnl4IAIPcVr50U6yrZ7EuFJFSDPQGk6RNp7qqrEhu ujHewLOnNNZmzgXaLyMuxgb6 X-Google-Smtp-Source: AGHT+IHKV2g0kNYONFuj/bO3jVZJAPZFJ9rV4Fa7zy4o4C1WAr4wKwvCb2AiIaMwbW9Aq+iM6pw/6Q== X-Received: by 2002:ad4:5ccf:0:b0:67f:4c4:e8a5 with SMTP id iu15-20020ad45ccf000000b0067f04c4e8a5mr1792743qvb.24.1702545148371; Thu, 14 Dec 2023 01:12:28 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.12.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:12:28 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 12/16] arm64: dts: qcom: sm8250: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:40:57 +0530 Message-Id: <20231214091101.45713-13-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011230_409374_B89A3EA0 X-CRM114-Status: UNSURE ( 9.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM8250 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC While at it, let's move 'clocks' property before 'clock-names' to match the style used commonly. Fixes: b7e2fba06622 ("arm64: dts: qcom: sm8250: Add UFS controller and PHY") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index c1b7f9620ec6..e47c515af6cf 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -2486,10 +2486,12 @@ ufs_mem_phy: phy@1d87000 { #address-cells = <2>; #size-cells = <2>; ranges; - clock-names = "ref", - "ref_aux"; clocks = <&rpmhcc RPMH_CXO_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_1X_CLKREF_EN>; + clock-names = "ref", + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Thu Dec 14 09:10:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492608 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5685C4167B for ; Thu, 14 Dec 2023 09:12:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3F8LjyplphwMB2+b0Tp8KT0j9oRP3wErNem1bV0hhaI=; b=eEUEDxh5wwD8AC 1am6824CJNAffQgR7oZa8koMNyRKuiWAncciMSOHiVKcleRPIl2RL8DPwGoe/IKaz0LiCxKW2xcwV E8QGR0NyE6ioQ0TFRjJpXiXyqWKXH9knrW2/2VzmTRkaK8PGGO3S4mpmMdG9XAABhd3fEd66570+3 71OOcmdyYfILMHjD6jNI8G8T9HpC6/nG65eclYT1eGZVTUwc4TZqan77wtT/vfofk9a75vJHAt6Nz WRfyxVoFgwXnfL6BbrvMTVP/Fc9HewLpdEJECgBrtx/qdHc9X0aQ7NSwweAHxoRzG70gzRMckAX7T KHA4lPoPTrYeVqJJJnBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhll-00HJmX-1v; Thu, 14 Dec 2023 09:12:37 +0000 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlj-00HJll-0E for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:12:36 +0000 Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-77f320ca2d5so33947385a.1 for ; Thu, 14 Dec 2023 01:12:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545154; x=1703149954; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hkhidzmVun0Q+RVPRPkagjowO4OR2Vwj/TtI5d1pEJU=; b=pNHgnYBearsCiUFjgxzLoHcDpUqN4UDRi3MDvPjuSNQ3K//H8wErhfyfihWUcnE5pE Oi8Zc3GpWVHLabQPtDgZrzWHmgx/Jjb65Kt/yaZrbJnEC5xsDntBkV4bGFd98yGo3Xkp kbGHL1n4TWgu9bLd3xkDSK4JvHQWD0JQVFqv8x0hesGHIKGOZ6bQJQE3vVsyZ4jJMcE/ EL2Q8xVCT7Vj2ukpww9lh9O7zFlQggafKzI+xXVjWqWOjVmm6Z6B9K5AED+A+EK2pPYx JfZh7EfjeYeJVXsTcxQ2qQTvBnXZG8IfjIl9ItOITKK5/d8wlWrlRksTGdtunGaebxDt 915Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545154; x=1703149954; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hkhidzmVun0Q+RVPRPkagjowO4OR2Vwj/TtI5d1pEJU=; b=CM679+lDvG3y1ijk1cMuBk9W4va/NwJJOdxoQaFhnal+sPDv/Ee6hD2JPuCuNgrnTp 4ZaRTP/ehzz7tldsth7R4Y1F/O0nd6xGgJtRoLgSdcZ6RUqvWRs+cvFgrdh725x3A2au dR0a26sjo7copuEo43ZvBQ+1+OIYcpdouVqBpFLyzD9qFD4N68NmvXrkhMmDBdv4EiQL UconcxfNz9ExqOCHl9oW/wSwtmuGLoh1To14+Rct9WDSB3IAUm7mRpMSYVx8eLPIBAOi 3O/VOFAUKIpsJHzD374E4oZf2o7nRiDVGLvIzhh51KHQTrxu8RePtz4/nIQuo0I5PGR4 mCSQ== X-Gm-Message-State: AOJu0YyLHDmw8oc6wM0FcK70md0QlK8bRWAPLTuSNT7hOgEYN/fNCd7M A3uvbfGFG+T0FteZJi8ufqU+ X-Google-Smtp-Source: AGHT+IHEtm7mEgCIyDmSr/wXhkhEOgi12WL0DLU2N7twPYVrahWhPEqWyDCKPCHrKSIdtshq633qyw== X-Received: by 2002:a05:620a:14af:b0:77e:fba3:3e61 with SMTP id x15-20020a05620a14af00b0077efba33e61mr12750317qkj.42.1702545154261; Thu, 14 Dec 2023 01:12:34 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:12:34 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 13/16] arm64: dts: qcom: sc8180x: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:40:58 +0530 Message-Id: <20231214091101.45713-14-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011235_106111_D9CECC45 X-CRM114-Status: UNSURE ( 8.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SC8180X requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi index 8bcc8c0bb0d0..5591e147bde1 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi @@ -2122,9 +2122,11 @@ ufs_mem_phy: phy-wrapper@1d87000 { reg = <0 0x01d87000 0 0x1000>; clocks = <&rpmhcc RPMH_CXO_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_MEM_CLKREF_EN>; clock-names = "ref", - "ref_aux"; + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Thu Dec 14 09:10:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492609 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F338C4332F for ; Thu, 14 Dec 2023 09:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=skbh9IwQxql/Pf3v1EDX2s9yyK00IwaVZmE8Ga7I36s=; b=eBF9FBVHJnZFTm SW5lPelvbrGXgy5k9tvOekLrjbuVN5epEa5wL1RyjewI2tAgHkeDtvJvvO9UxdsCVXYNYk8F9gPuZ Y6BvWYMfxt7Hwm5sdSWFQ4SZI6e4Jfdpiy2uQ/qvy1VIUtf4bcgBV4r/pnWuQFXvhNgN5zE7x53dq LPLBCJqK+iWgh/yL4mESlT3WSTOJicy291gPH4sG1o/Wy6kjva/KjnHW9tc+od0hSKAOyrsKPGU5r S4gcLMh4SpfhfAvorBJmnZEMKOyEEkTnVBYPtbQahO/ypKBnAhrxCVxVFTt928W9h2GVAHOkIO6fO RP8Hz9ivs/CzIwTNQJxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhls-00HJoB-0A; Thu, 14 Dec 2023 09:12:44 +0000 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlo-00HJnk-33 for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:12:42 +0000 Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-77f59fcb204so331347785a.3 for ; Thu, 14 Dec 2023 01:12:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545160; x=1703149960; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RTvHTb3eBsG5jFvbdhGh0zasO09G1PrRZVvH3m7yDqQ=; b=nQeY6Q8t56sm042z4oUo7MjcF7MSdtVxjHczDNiRzMCPISlZP+26o8eTHtFxMsAvpt 9Rm692GBTRHbOXrnecNip5AR+qXPcjq1IOUqxW63TDIo/39kRoQ9VEei1YZhbIq3CRjB r+AY74Vx7z/IgvZ/fdEM3Q3036+WudO92fJ79K/cbZgmlNhh1oa01TsbYs0c3sC5zQpU G+Xu3BXs0AQFdPGZbaQAATQv+BhLVWyio+bQpgJNj7LmayPAdn4HigRF74Wlw3w9UJl5 1UPKFB1wi0AR7roPEKwK2Jv4GT/NEWs37P3xe92jRwAW1wupaRGae4MKRU1IRIszYTFS mwyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545160; x=1703149960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RTvHTb3eBsG5jFvbdhGh0zasO09G1PrRZVvH3m7yDqQ=; b=Gi5eYHZRdrzjVQlHkmZy9YiLFj+t02msyD1y+fN28BqFvihXURCwHQN39V8LhSPVam k6oe4QR3jD10OF6Qr/i+7G74yaB/4V+3Tb0aQi/bCw5LP3Zdj+1MnsiLKbhoHLAirOAh cNFMM5XnXYn5asLxpGDKwRs/tvBpZa5pe+hwWCIeNmTGlKLFfNfHPf+qgMj34CagjjsK U6WlcEh8gqtVgaunXr7WTem6v+YP4wISlAPt0uXtGyT7aN0MVAO5TPF+2GHHlH+dzIXs f+suSncQQqQIMh5WyoXy1vkd4JYGw58Ih5Cs5BonHeCWTQU558ICFuEeXFkarqyDClE+ roqw== X-Gm-Message-State: AOJu0YwhcANVeuXCMvopBYUlnrIGdQP/rrhJeZn8bC/ie4W9RhsJ1yPB WOHZ9i6r6kHHlCK/fwfsiv5e X-Google-Smtp-Source: AGHT+IEpmVaZuTwzbu1BWhivPFP3wp0kwntHWmdosjIBL5bKy/r96k37U4HBpjYRfuW3aZIMXlXqmA== X-Received: by 2002:a05:620a:20d7:b0:77e:fba3:757d with SMTP id f23-20020a05620a20d700b0077efba3757dmr9763694qka.117.1702545160156; Thu, 14 Dec 2023 01:12:40 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.12.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:12:39 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 14/16] arm64: dts: qcom: sc8280xp: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:40:59 +0530 Message-Id: <20231214091101.45713-15-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011240_980190_FCAD13CE X-CRM114-Status: UNSURE ( 8.02 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SC8280XP requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index cad59af7ccef..37344abbe8bf 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -2256,9 +2256,12 @@ ufs_mem_phy: phy@1d87000 { compatible = "qcom,sc8280xp-qmp-ufs-phy"; reg = <0 0x01d87000 0 0x1000>; - clocks = <&gcc GCC_UFS_CARD_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; - clock-names = "ref", "ref_aux"; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_CARD_CLKREF_CLK>; + clock-names = "ref", + "ref_aux", + "qref"; power-domains = <&gcc UFS_PHY_GDSC>; @@ -2318,9 +2321,12 @@ ufs_card_phy: phy@1da7000 { compatible = "qcom,sc8280xp-qmp-ufs-phy"; reg = <0 0x01da7000 0 0x1000>; - clocks = <&gcc GCC_UFS_1_CARD_CLKREF_CLK>, - <&gcc GCC_UFS_CARD_PHY_AUX_CLK>; - clock-names = "ref", "ref_aux"; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_CARD_PHY_AUX_CLK>, + <&gcc GCC_UFS_1_CARD_CLKREF_CLK>; + clock-names = "ref", + "ref_aux", + "qref"; power-domains = <&gcc UFS_CARD_GDSC>; From patchwork Thu Dec 14 09:11:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492610 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0449C4167B for ; Thu, 14 Dec 2023 09:12:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OeoRYS1E53TgD+rg2giuX5TdTnQN9w4HUk06mU6EGaw=; b=gVz/bPyFrgJnNV WvtQN8FAkq9SuZGPjrW0k/CZJDpEeZCai5yNU6tRumgwMXafGogYbzazYxr2c12h5PTkkEAEatLjG 21ceJe7azjLCFttbBJuDqZVd/WvhZ2kwWLOPHdx4aN6eTWHVh227nt1NdZKkvOEQPBBdXFNUoIKu6 hbltdvY15JBkN9wPpTO4Fn6Xpyn6s1ijSoOBmjFY2HPTI7ia1/JDuifBOBtUvEFfk2HRE3v1lziW/ U7aPkgNWUS1qs59210uYezKaqG6eL6B+uQ58mdNIHBXCLcjTxMZ5tJAzlm3xnt0lU77wYb1t28RhF 8Ow4wqLoX1lBhy8PdEFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlw-00HJoy-1S; Thu, 14 Dec 2023 09:12:48 +0000 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhlu-00HJoR-2I for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:12:47 +0000 Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-77f58040770so405376085a.2 for ; Thu, 14 Dec 2023 01:12:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545166; x=1703149966; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dnV4bcTFVg58y8kcgwcwL2c2t/omr5+/badatgzAJ70=; b=gsj2tSgVS9q4dhCYXTJhXDetZEwC/bxCOkyHFcrm6TyJUfAgs2JoEPP3GKSHRQXaZb uIkh4vx+SRWUwVOBciN4cpKUddSAlz9Z6C0xS+BiYTLoTPQ2kDNuIwMbUYiAUedNxHYE d1CtttLVGy6/YsP1vCFV9vXHavguTIQeSbhgTseKlXhVqmPq3kfO3DygiSxM+ot5uJPO IRgQs3W0rz7yfHKaYIPKtRQmB1co/auYiU/ZfyTkY5JMhlSv6TMN0tXY9YocJ/eUPDzq Ng0xZjPBYaG0fXmrpll9ppSUWAkfBZnpOP5N+RSnfFgoG2P6ovMvfGTyHBFhVo3m1laa tOgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545166; x=1703149966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dnV4bcTFVg58y8kcgwcwL2c2t/omr5+/badatgzAJ70=; b=L2+H2BxpnUPXAOexhIb8Z+8ZMaSEdocH0MeG631YqkFH2OmKX0FmrrCE1zFaGmVfOZ C4gskdfn6LdigQuyLWBqn3CqyRVsr9nGNMR+lZ0Yyq2b9DwHnYpu+ZOwHkZVDy4Eeu9x XedTKJzvXEwaNYKr0LHjO2Erqm1g+LwFPfMTedrT/lV1+5A583umnPLvjp7zFn2mINV8 i+WH9mE0QHWQFtCcnwjyLbhOhFaGd8YwvT3XT/O32TfIyHbTKlCnOkI6nIx/cyhTkX+V gzNOxjxnqB7VagHokM302MBJGdKKraix7feU/QQZuIOPC9v0bf/nqT6KwsnOHapRWjNn A6hA== X-Gm-Message-State: AOJu0Yzq8uE0MAbp5RU1y2NIMn/F2aTTU+kyLYURTYOZvtr0oiw6A0bQ jiJLJLVcx1d1HPxeVjzTowJx X-Google-Smtp-Source: AGHT+IHhZr6wQfQIpC5Du8Ua96GS+QkCSnpo7BicRmN+1IcfH8Ki2ucla4gKq+YP7Ucu3fIwuMU7Pw== X-Received: by 2002:ae9:e00d:0:b0:77d:7446:d4df with SMTP id m13-20020ae9e00d000000b0077d7446d4dfmr11263131qkk.76.1702545166023; Thu, 14 Dec 2023 01:12:46 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.12.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:12:45 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 15/16] arm64: dts: qcom: sm8350: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:41:00 +0530 Message-Id: <20231214091101.45713-16-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011246_747759_0ADEA15B X-CRM114-Status: UNSURE ( 8.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM8350 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC While at it, let's move 'clocks' property before 'clock-names' to match the style used commonly. Fixes: 59c7cf814783 ("arm64: dts: qcom: sm8350: Add UFS nodes") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index f4b8439200f5..38a09d71b3e9 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1727,10 +1727,12 @@ ufs_mem_phy: phy@1d87000 { #address-cells = <2>; #size-cells = <2>; ranges; - clock-names = "ref", - "ref_aux"; clocks = <&rpmhcc RPMH_CXO_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_1_CLKREF_EN>; + clock-names = "ref", + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Thu Dec 14 09:11:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13492611 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39A5DC4167B for ; Thu, 14 Dec 2023 09:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3tP/nZqfnCMhBDjckqV7U6VlnELeZN8+Fhv6BujXXj0=; b=tP1PvvM0YRDB3m j0DCF9YXpHsh3MQbAQck1llmou2QZxeHZ8BrioI0gr2x0KQwxKzK7Cayw6orMULeV9CDpQu0Dl/9S O7QAsTsb/2YC2mHYXOmWZ5cAUH9cLI2gy8VdFv4MHlEdsFWEMM2WrSNe+wl3Heovpo3KcQCsTpN2I DBqlakAvPmOxtN2fwE7M+r3ym62k5AIhGFCa/LaAXUvSWyqqfCnksgIjtJkED4pvzCJ35cQA2Sll1 7upa/pPan2RgACJAQdR7XcRASZe+xkjgGjNFR7sUoMC6A8sOnXER1NeHnFm5UOkdorZjL01qgvUeN PyL9M/iOW2MsNBapn+7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDhm4-00HJr0-35; Thu, 14 Dec 2023 09:12:56 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDhm2-00HJph-1K for linux-phy@lists.infradead.org; Thu, 14 Dec 2023 09:12:55 +0000 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-77f408d123bso297187185a.0 for ; Thu, 14 Dec 2023 01:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702545172; x=1703149972; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=90h9raFSlwYqtZtEwRi3utD1Y8btrpvvb6rt2ijbFWY=; b=UXH3/zCoiQzHLItc9n7BIMUuyinuwU3yVHf4xbULT/Zr/54DH3FEACkzU/D5iVPaeW uB7xAKN3Da4fWRt4Rmi0URVZWWexUKrgMogrvo02fjgBuFHaJvScX3Iraqs0Jis8mEt1 7TgzL9NFUd85RwYY7IbrpDzN0qCpaVmKKwROkBOOQ3UGc/3xb3udzOPbHSxi1XHty/wW ChNF+oX4Y9l1CEYuawpmGHTnKPpxW1Cd21uhSAeH61aeH1gSUUxVISsMDc8WtSvKhd7T wLPhG8IeM303t8ovoKERwITUoRTDh6qVI/sE5dWCD4mOroyJPzAGrQuc76mGbf4rzNY9 e2bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702545172; x=1703149972; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=90h9raFSlwYqtZtEwRi3utD1Y8btrpvvb6rt2ijbFWY=; b=sFP4F1QNNFtYVvEufCreGwMsg7Q3OQo9U/qYO4SE46GHLte58M6qzn79RFY/6d09mh FFWeyLVOaHT9ia0iSd2dCUcFkFojE7HaM4osUZ0L1JxlbfloI4fcnJraxTJRVU6J2nGq equcAKMYH0I8ZJD9FE7kkL/rylwmyHganbnDvajJebISaXoS1TcI503sZLKTVjDLFsb8 msevPOAJRVd0c2bXvrw/kpAXgdkPtFeRzKB93a/w+FP0BQftmdMT4vhW2iYZQRO3XyDX cht2tCxxooXYwIyI8CCZIEcVH8nWagVoUPjk2tzoedX4TKdAouC4E2q+i7dOfBjnWHd6 UL8Q== X-Gm-Message-State: AOJu0Ywb5Q3ZJ64QbAI0sVlh/4i45lCvQuteqUzMcN2sTnUoeetxAcdE ej/9b883cvYPIqfpr9Fc8gIJZ/D7mcPkOvaClg== X-Google-Smtp-Source: AGHT+IEGFG/+5WBdW+QF3Y2B4MEmKQm1lHv2/KY/sKl8G6B/VvdbDTPntO5+kmWw7bf4yF46kQC8FA== X-Received: by 2002:a05:620a:956:b0:77e:fba3:a7af with SMTP id w22-20020a05620a095600b0077efba3a7afmr6304092qkw.141.1702545171754; Thu, 14 Dec 2023 01:12:51 -0800 (PST) Received: from localhost.localdomain ([117.213.102.12]) by smtp.gmail.com with ESMTPSA id qt13-20020a05620a8a0d00b0077d75164ef9sm5144119qkn.124.2023.12.14.01.12.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 01:12:51 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH 16/16] arm64: dts: qcom: sm8550: Fix UFS PHY clocks Date: Thu, 14 Dec 2023 14:41:01 +0530 Message-Id: <20231214091101.45713-17-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> References: <20231214091101.45713-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_011254_446223_12E59033 X-CRM114-Status: UNSURE ( 8.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM8550 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from TCSR Fixes: 35cf1aaab169 ("arm64: dts: qcom: sm8550: Add UFS host controller and phy nodes") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index baa8540868a4..386ffd0d72c4 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -1891,9 +1891,12 @@ crypto: crypto@1dfa000 { ufs_mem_phy: phy@1d80000 { compatible = "qcom,sm8550-qmp-ufs-phy"; reg = <0x0 0x01d80000 0x0 0x2000>; - clocks = <&tcsr TCSR_UFS_CLKREF_EN>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; - clock-names = "ref", "ref_aux"; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&tcsr TCSR_UFS_CLKREF_EN>; + clock-names = "ref", + "ref_aux", + "qref"; power-domains = <&gcc UFS_MEM_PHY_GDSC>;