From patchwork Sat Dec 16 13:34:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 13495571 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD59FC46CA2 for ; Sat, 16 Dec 2023 13:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I/67j1eCuRGj1YVZMq7etJkdWyqjAVrBGe72ngFcWmY=; b=G6N75cGS1vqkGa 0W00vJaAG8gM5Ms2x9Hqk0uV56qITfcXCZU0Xe3uDFAgNYzu6h8+FBrTQRS8maYh9apPaNgz2F6LI LH+cqHkHeVf371BB6WUqiFYbVsGNpC0pQ+sVL4h1afvUdgrpuOyiS0lzVmCpeduM6w1mpj39T3adN GYrNPS/dxmBMw8ztpgCo4y460X5RtS59qAjEHxOHQ1RW9sEp5NcJOCycM43lXuOvY169Rfmd36NPN M6LgFGAJvSUcVZG1dxtPBndpKmhyEFbiCp6tyf/+AOjJTJ538lbLFxZ9/E2I4JQfHeMq0qtW2xH0J 7dSNkRq9NV514vUKwO3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rEUoQ-0067S4-2Z; Sat, 16 Dec 2023 13:34:38 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rEUoJ-0067PT-0L for linux-arm-kernel@lists.infradead.org; Sat, 16 Dec 2023 13:34:32 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-40c6736d10fso19748595e9.1 for ; Sat, 16 Dec 2023 05:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702733669; x=1703338469; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kYkcCRj2aDyNKfpsjAbeqa50uCwjkKY1rnjchlV8BI4=; b=c/sUN8uZXH/GOZ4EgWOrESuu/wKjtZB42C0MNISWT5BILrZ1ULuRl+VeO9f6vP1Md5 aVARhQ2jncL4rV8Bw8HVCd4m9hwTPyBph1OQuZe+4+iXE3JOMBLFbUSc+YUUYYDcQ8LT FhkfzxSUy86+FTDiWyvqKfOd6k186oNaPOeRukAUuU6WYNBPjwHMZCvnZZNAJbswmEYX /gQaGsrBD/OGEXuq3e8z1hUrt5nFEjWpVyCMZScW+LdgE5ShiOZ9ROugbtnoFkKBWrqL ooI4MVpGbUweWyPfFuZ/Xda7Zwtsp8eflFTrk9DKz3+Q3VhZQo7WwxxNWrKP9s98l8Wb 3A/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702733669; x=1703338469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kYkcCRj2aDyNKfpsjAbeqa50uCwjkKY1rnjchlV8BI4=; b=am4pU9U96P3w0JRMykpj9zi9XHOXnjMzHUABlBPsYSCqyBV8UxBebrKo47wMFE7zYa alP+sZJOqdYo+k49ZxtZs4WPfwkJtO1BdPlOHdSi5vXcYE3SHYo/mIY2ecxhmQtkf4vV Njltvh3Y801xgsqF+SMD84td9dIJwZgKdkqc580tku48jitsb/gZlG33w3oOJe1LWBZH putI/P+PC4tPMwWyEKqf+uWsyDjQyeFxOYBHOzceFq/p6IjDiYuoD3JRVYDQSEMwbhkj ysvll0cjzTyjU0BZmS87YpcKp+Smhws2SAlnQD9l4JiqT7iKNdpxF14cx2/uo+18p7rF n20Q== X-Gm-Message-State: AOJu0Yw9LW78tpboN4SN3BtE2QX7QVyziK8yCcAkEK0JSlINEpJU4HWA plP9Ud1+TzzWIpLnU6WcYfI= X-Google-Smtp-Source: AGHT+IG911xAhwr40S4ErD5qmHRV0PNM/nWBQsYJcAqJSi58EQSzDvjWDUWnf87Wfg5I7RBAyT+tHw== X-Received: by 2002:a05:600c:3ca2:b0:40c:5112:a0b with SMTP id bg34-20020a05600c3ca200b0040c51120a0bmr4922033wmb.45.1702733668688; Sat, 16 Dec 2023 05:34:28 -0800 (PST) Received: from localhost.localdomain (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id l16-20020a170906415000b00a232bf6045csm423629ejk.63.2023.12.16.05.34.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Dec 2023 05:34:28 -0800 (PST) From: Jernej Skrabec To: wens@csie.org, samuel@sholland.org Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH 1/3] media: sun8i-di: Fix coefficient writes Date: Sat, 16 Dec 2023 14:34:20 +0100 Message-ID: <20231216133422.2534674-2-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231216133422.2534674-1-jernej.skrabec@gmail.com> References: <20231216133422.2534674-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231216_053431_142054_FF4EC21C X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently coefficients are applied only once, since they don't change. However, this is done before enable bit is set and thus it doesn't get applied properly. Fix that by applying coefficients after enable bit is set. While this means that it will be done evey time, it doesn't bring much time penalty. Fixes: a4260ea49547 ("media: sun4i: Add H3 deinterlace driver") Signed-off-by: Jernej Skrabec --- .../media/platform/sunxi/sun8i-di/sun8i-di.c | 42 +++++++++---------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c index 90ab1d77b6a5..34e099939284 100644 --- a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c +++ b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c @@ -66,6 +66,7 @@ static void deinterlace_device_run(void *priv) struct vb2_v4l2_buffer *src, *dst; unsigned int hstep, vstep; dma_addr_t addr; + int i; src = v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx); dst = v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx); @@ -160,6 +161,26 @@ static void deinterlace_device_run(void *priv) deinterlace_write(dev, DEINTERLACE_CH1_HORZ_FACT, hstep); deinterlace_write(dev, DEINTERLACE_CH1_VERT_FACT, vstep); + /* neutral filter coefficients */ + deinterlace_set_bits(dev, DEINTERLACE_FRM_CTRL, + DEINTERLACE_FRM_CTRL_COEF_ACCESS); + readl_poll_timeout(dev->base + DEINTERLACE_STATUS, val, + val & DEINTERLACE_STATUS_COEF_STATUS, 2, 40); + + for (i = 0; i < 32; i++) { + deinterlace_write(dev, DEINTERLACE_CH0_HORZ_COEF0 + i * 4, + DEINTERLACE_IDENTITY_COEF); + deinterlace_write(dev, DEINTERLACE_CH0_VERT_COEF + i * 4, + DEINTERLACE_IDENTITY_COEF); + deinterlace_write(dev, DEINTERLACE_CH1_HORZ_COEF0 + i * 4, + DEINTERLACE_IDENTITY_COEF); + deinterlace_write(dev, DEINTERLACE_CH1_VERT_COEF + i * 4, + DEINTERLACE_IDENTITY_COEF); + } + + deinterlace_clr_set_bits(dev, DEINTERLACE_FRM_CTRL, + DEINTERLACE_FRM_CTRL_COEF_ACCESS, 0); + deinterlace_clr_set_bits(dev, DEINTERLACE_FIELD_CTRL, DEINTERLACE_FIELD_CTRL_FIELD_CNT_MSK, DEINTERLACE_FIELD_CTRL_FIELD_CNT(ctx->field)); @@ -248,7 +269,6 @@ static irqreturn_t deinterlace_irq(int irq, void *data) static void deinterlace_init(struct deinterlace_dev *dev) { u32 val; - int i; deinterlace_write(dev, DEINTERLACE_BYPASS, DEINTERLACE_BYPASS_CSC); @@ -285,26 +305,6 @@ static void deinterlace_init(struct deinterlace_dev *dev) deinterlace_clr_set_bits(dev, DEINTERLACE_CHROMA_DIFF, DEINTERLACE_CHROMA_DIFF_TH_MSK, DEINTERLACE_CHROMA_DIFF_TH(5)); - - /* neutral filter coefficients */ - deinterlace_set_bits(dev, DEINTERLACE_FRM_CTRL, - DEINTERLACE_FRM_CTRL_COEF_ACCESS); - readl_poll_timeout(dev->base + DEINTERLACE_STATUS, val, - val & DEINTERLACE_STATUS_COEF_STATUS, 2, 40); - - for (i = 0; i < 32; i++) { - deinterlace_write(dev, DEINTERLACE_CH0_HORZ_COEF0 + i * 4, - DEINTERLACE_IDENTITY_COEF); - deinterlace_write(dev, DEINTERLACE_CH0_VERT_COEF + i * 4, - DEINTERLACE_IDENTITY_COEF); - deinterlace_write(dev, DEINTERLACE_CH1_HORZ_COEF0 + i * 4, - DEINTERLACE_IDENTITY_COEF); - deinterlace_write(dev, DEINTERLACE_CH1_VERT_COEF + i * 4, - DEINTERLACE_IDENTITY_COEF); - } - - deinterlace_clr_set_bits(dev, DEINTERLACE_FRM_CTRL, - DEINTERLACE_FRM_CTRL_COEF_ACCESS, 0); } static inline struct deinterlace_ctx *deinterlace_file2ctx(struct file *file) From patchwork Sat Dec 16 13:34:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 13495573 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1BEFC46CA2 for ; Sat, 16 Dec 2023 13:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2XXoyb+fOylBSBIyptpiXhZoz4wvPfoJ1xbw8EyhzEA=; b=juGOgEofns1p3O AY7DSa0O9ZfY9QfbYuRzFNEJlpetv+E4NzMaWeMGZOmAw4C/QWTK1p9XAfid7nKDaf+Gh2m3JlbZl 5eTirDd891GdhpoWvSo/m3cDM6uO7zJ4TFf2NzzNGjyo1sPX78kJl5L3/uDHP8aMnGhkA3bHKPRpK uVDdh1Mcd+iCEbCTJfmckNvRfRuc0Zxd0D2eNPWb5iPbuQq3Fq0u8kjDN90877+sLzbJOaHRz/JHL /3hMhdsWz4+sRzwPNzmfKFH/WoJBZjjo/pSpF3RnmP5hjKQg+tPv+/QAdTarZxtS/iGBxjWpT3AZT MWv/p+N1DaWvPDGzu0Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rEUoR-0067Sb-1D; Sat, 16 Dec 2023 13:34:39 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rEUoJ-0067PU-1v for linux-arm-kernel@lists.infradead.org; Sat, 16 Dec 2023 13:34:32 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40c6ea99429so11158015e9.3 for ; Sat, 16 Dec 2023 05:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702733670; x=1703338470; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MQ54a7sGebhpJsxp9YTsGDagOVgcaEiKJBAxSRg25CE=; b=Q36tahKK1w0yeU5tBw75sZeUUAzGxCpMyovmRHgpyZmVtwgCvR/Kx63Dut4w22acTC Lel6P7Sf5uagsBNLguYv1x/KXA3H+YtCBTZXEzV8M4Fa9uXNMOMKG9Qp+6me8a0JFsZv XMG8cCtVU1Q3zkY0czZXNV3qozz+34GiV35nk54p4You/ORIwX8ZZ0cf2yjzxLJp3Tx8 FyBJOJVUXEyk6pDl+9z0qzlFvBzVTzTqpTfvf947rnV7hVyXO/umaAryzcOzrAegF4Fk c3SwJG/ktyYG6IRAJHejff39o1SMqoapcigBLs0QkMjrneapqAFVfh0l5X8ZynS2uil4 Kzww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702733670; x=1703338470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MQ54a7sGebhpJsxp9YTsGDagOVgcaEiKJBAxSRg25CE=; b=ODB+r9zejsKpXuzxDppJAWrgrKoifLvC4vCrGHDnGt9f6Kx/OMlE8T44lBfRFpxPPG S+V+zX1MGsdtRCLEtbHLXkhfDMR6i3OFea8Ise+lU0BkDOWouZiJ99sBsgB63/c6DMm3 YDj8neE0+apdOnLVAEvWeXQvJwm69IhVUyG/hG4VrVBd5U+L7MW7MwLKtnUiyDRVSJE9 uLn3REfQoShCxRShVOZxx8W+SYs+zvK+bApZjfBAzqwvx6LGtLvOa3HPJXJQHnm7A0SQ ROKc7PdgHqF5Z5z9ZclT2h78RR568vzT57KVjQ/mHWA9iTrxIBEPlsgXH5gIvmCfNPvF 3eAA== X-Gm-Message-State: AOJu0YyuowXZtU7NayCzwdZo+y6y4Rwrtku4E86OIl/ENuOYzxI3zVcp jp/WCJ+xOZ4QtRL2O6QGKzQ9vXy3jl4= X-Google-Smtp-Source: AGHT+IGu8efrSlq+GuBq/ObkC9OhhHEBe/IbQv7ZHkDgjyi9R8rIZVgzPJfTHhK03kt9IfWoxR5u+Q== X-Received: by 2002:a05:600c:244:b0:40c:2b4c:623f with SMTP id 4-20020a05600c024400b0040c2b4c623fmr4435388wmj.82.1702733669609; Sat, 16 Dec 2023 05:34:29 -0800 (PST) Received: from localhost.localdomain (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id l16-20020a170906415000b00a232bf6045csm423629ejk.63.2023.12.16.05.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Dec 2023 05:34:29 -0800 (PST) From: Jernej Skrabec To: wens@csie.org, samuel@sholland.org Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH 2/3] media: sun8i-di: Fix power on/off sequences Date: Sat, 16 Dec 2023 14:34:21 +0100 Message-ID: <20231216133422.2534674-3-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231216133422.2534674-1-jernej.skrabec@gmail.com> References: <20231216133422.2534674-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231216_053431_631268_5FCD5380 X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org According to user manual, reset line should be deasserted before clocks are enabled. Also fix power down sequence to be reverse of that. Fixes: a4260ea49547 ("media: sun4i: Add H3 deinterlace driver") Signed-off-by: Jernej Skrabec --- .../media/platform/sunxi/sun8i-di/sun8i-di.c | 25 ++++++++++--------- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c index 34e099939284..f253a40cc04f 100644 --- a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c +++ b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c @@ -929,11 +929,18 @@ static int deinterlace_runtime_resume(struct device *device) return ret; } + ret = reset_control_deassert(dev->rstc); + if (ret) { + dev_err(dev->dev, "Failed to apply reset\n"); + + goto err_exclusive_rate; + } + ret = clk_prepare_enable(dev->bus_clk); if (ret) { dev_err(dev->dev, "Failed to enable bus clock\n"); - goto err_exclusive_rate; + goto err_rst; } ret = clk_prepare_enable(dev->mod_clk); @@ -950,23 +957,16 @@ static int deinterlace_runtime_resume(struct device *device) goto err_mod_clk; } - ret = reset_control_deassert(dev->rstc); - if (ret) { - dev_err(dev->dev, "Failed to apply reset\n"); - - goto err_ram_clk; - } - deinterlace_init(dev); return 0; -err_ram_clk: - clk_disable_unprepare(dev->ram_clk); err_mod_clk: clk_disable_unprepare(dev->mod_clk); err_bus_clk: clk_disable_unprepare(dev->bus_clk); +err_rst: + reset_control_assert(dev->rstc); err_exclusive_rate: clk_rate_exclusive_put(dev->mod_clk); @@ -977,11 +977,12 @@ static int deinterlace_runtime_suspend(struct device *device) { struct deinterlace_dev *dev = dev_get_drvdata(device); - reset_control_assert(dev->rstc); - clk_disable_unprepare(dev->ram_clk); clk_disable_unprepare(dev->mod_clk); clk_disable_unprepare(dev->bus_clk); + + reset_control_assert(dev->rstc); + clk_rate_exclusive_put(dev->mod_clk); return 0; From patchwork Sat Dec 16 13:34:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 13495572 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBA70C46CD3 for ; Sat, 16 Dec 2023 13:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6Rc7qFiBrCGlkDahazPF1lfEDjreox6dQZyjGtCou40=; b=tnig+1Ozg58/VH tJqKYnBmMARbIuXGcVqyxuKE6+dW+doL/YLvLO58bk0hk7b5Hq694SoTU6849lq+2Z+vsX1genwk9 fn36osgmqME75M7KttmaQDu0cPC+lFPF8lTVyahgv+t4j+STvlVesDhaptnxYdt20GfMP6ZwI/nGK b6QSJq8/MPzAU6Tsydf5emC3np8gCCA1BplPQUYfyPdnqOsZ+PlCLrxR8rzPNYHS4NDh9ND2rhlGH 0PhIlCZrcnQcFltOkNtmMNPMtAN28vuDx0AWV/jdW/On495lII6xCfsuwRuWFhuZYxxHWUDgJsQzO q+hnlIZJMYP8m8+iiu4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rEUoR-0067T5-2z; Sat, 16 Dec 2023 13:34:39 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rEUoK-0067Pt-1w for linux-arm-kernel@lists.infradead.org; Sat, 16 Dec 2023 13:34:33 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-552d39ac3ccso2430497a12.0 for ; Sat, 16 Dec 2023 05:34:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702733671; x=1703338471; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nTmoBalM2UZzwSsqBtYN4pTcgAH6LuJG4x51tAzCQyI=; b=ODtTLf88ZBZzv6Dr/E9fJ+OhVEGlAEzjzRxzJyhJgyKClIMoZMPnM+G2fqnvzZP42N TGKrvcbXkEU4OPD83SDcpE2rkmjU5gg+pCwr1HnAzffC2huWNNlYGpLverh3oikQvt5S Hki35bM+rp1BWcCNz1p4I45+83V6b69kx041h+SMjV1CoRZ3ALMluxTCgGf0bHeI2ugj ZRthwOczIlNvD2kkClStMP4enR74C6KWWr23xah5okBNUBdZdo0NF52+RDg7yoOjQU8i wxJSvEkkX3xLgX+qANLG8Lof++0roWwKrQ1TNiY86C4uAUy+2dGlQKikqbo37NlZKTAw 79yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702733671; x=1703338471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nTmoBalM2UZzwSsqBtYN4pTcgAH6LuJG4x51tAzCQyI=; b=WKPQ0bpR+C008EdPfLwkdTmmwDiDG7g2ezdHmmZt8f5UtORAMB+PI5JKn12VzumSyZ bZVrb5dkepQOzH8FQrO1KfEziG2e1REakU8FoAszLmbJhqcOofbF12O1gjFDxEHdipRy mTH+b0dA8DWkP1zQ7mNRJKrOQG3cFcUAQr9gQ1I+MvQSL2bpbKLXWxwjnUn11eRaB5G+ vecSaZ0+I4NIKMoCVfkqnufkipxis2De1qV/vpa1cK9jaV/9NOFCuSSNDzcx9wAGd/AX FqPPXVkc398ecT0IHnfCCmdEP7qCFl8q6tajWri9rRVUJu1ppZG+KwREfW4CPIF85M0x u0xw== X-Gm-Message-State: AOJu0YwMEX7kwlzACVpslzi+8DbXJAMmY02JUfdd/phYzEWT34VOqVyy BPwa8CIKNBlFubQkimQ7jlU= X-Google-Smtp-Source: AGHT+IH3b10j+8jyAKAtdvCEywyWlISzpZTeWRwzu6lMvYyzMBeGp+kGNS8nahX92FU1+f2A18l15Q== X-Received: by 2002:a17:906:6d4f:b0:a23:31e9:71e4 with SMTP id a15-20020a1709066d4f00b00a2331e971e4mr344349ejt.71.1702733670581; Sat, 16 Dec 2023 05:34:30 -0800 (PST) Received: from localhost.localdomain (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id l16-20020a170906415000b00a232bf6045csm423629ejk.63.2023.12.16.05.34.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Dec 2023 05:34:30 -0800 (PST) From: Jernej Skrabec To: wens@csie.org, samuel@sholland.org Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH 3/3] media: sun8i-di: Fix chroma difference threshold Date: Sat, 16 Dec 2023 14:34:22 +0100 Message-ID: <20231216133422.2534674-4-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231216133422.2534674-1-jernej.skrabec@gmail.com> References: <20231216133422.2534674-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231216_053432_635136_FE5BD26A X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org While there is no good explanation what this value does, vendor driver uses value 31 for it. Align driver with it. Fixes: a4260ea49547 ("media: sun4i: Add H3 deinterlace driver") Signed-off-by: Jernej Skrabec --- drivers/media/platform/sunxi/sun8i-di/sun8i-di.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c index f253a40cc04f..f7ff0937828c 100644 --- a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c +++ b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c @@ -304,7 +304,7 @@ static void deinterlace_init(struct deinterlace_dev *dev) deinterlace_clr_set_bits(dev, DEINTERLACE_CHROMA_DIFF, DEINTERLACE_CHROMA_DIFF_TH_MSK, - DEINTERLACE_CHROMA_DIFF_TH(5)); + DEINTERLACE_CHROMA_DIFF_TH(31)); } static inline struct deinterlace_ctx *deinterlace_file2ctx(struct file *file)