From patchwork Mon Dec 18 12:06:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496770 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA23AC35274 for ; Mon, 18 Dec 2023 12:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M8KK3qvIfUle56XFCoPUC/WOO7y3bZ2q6wX8b5M4J48=; b=odsDXDIrNYRi1b dPcvtQgAWZm7QejS/Q4UF33s2dGx2NbGIFsV5qlVcQ9oMgMNBuh+ZGXbtxbCV2rrgMol2VYkHn4sc 8CLgJM67leJFUWvdrnRsGRJi++jxtPPYynTSLzxUb3KIQwXkvlN5dc3r/e3D9Iq+UhaJD0itSetSG D4ZhJf/AJh7bHUYhtkbiNRzKmpThhhiK4bHCA5gNBjxEsCWlfN+uhtIjav7WmvTuEakMbzu3N37u2 rDhCcis2KZtkxon7l+xdRXAsWPLMiV5A5aC+xxnCilHPxGZvWRAt1tLIjN/DX1luK/MLhxokjGvRo 67a5muavGTkOIHaWEC9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPV-00AYK6-2C; Mon, 18 Dec 2023 12:07:49 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPS-00AYF7-1G for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:07:48 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1d045097b4cso9770195ad.0 for ; Mon, 18 Dec 2023 04:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901252; x=1703506052; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6XGN0l4V5lK+pzpRjICmG52cyuWi32BoHlDHyX2fzxU=; b=FECzST3V9t3EW/QZHC81i6Lz0J3DeKYk2QtCwK8umCVuraIw/mHqrou/in2Kfo8Z7E pyqLZvfa8iTcT/MIYHA+dS61KTJULbjoocKWO38s1yYINV1JZ7divRj7oQkUkxQny98r bhfnljGoRTISxCGDijGpiy6QXEI+5tp1xh0czVpfo/w/v3sxc+X72HJuyV4lJgHWtggZ cWOKTwe6Ms40C8bPX8MHg6BypoNcSvkozymJ62bjAN16vPF/KP08kmW4rNJ+Oe+NerAh r3z3wIQAC5AJFDavA6pMl092JmjXMzPJDQu8an8PLUy8aiK8+kJn1r4fogSsNtZfJgZB vqPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901252; x=1703506052; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6XGN0l4V5lK+pzpRjICmG52cyuWi32BoHlDHyX2fzxU=; b=VVkhhshln0y+tAdgL9S9ErUZFOdnf6UF4O5a3Cnr4rHAadDt1A9tkB69KfyksBn1UX aZYfPF4bcMAGkZjMKXy7KQuylJDqthLwTwjV9na3goRJ3FGl3eVl3cXrOKe2vY2rRPBb NwGi+NZpIhWkKN06955OIVK4l2yEzBAQ6cmQpwqjufUmX8CxCDQwAl0dmJaRvpgxqYp4 070RCYiK0VZGlmSm2TlgQKpcHuoI3qEqSbh+AdXCXZRoiyaRriwdtpaM0I3yNy6X1IYI 1lU7bd07vPo97zXF93kEg9MuPl8fPNnfd/ciVKJLor1AlSjX4PZzMRI5E1wyDiUSFH3S zM+Q== X-Gm-Message-State: AOJu0Yz9l09c0TOKeEORFHJwd3yHNkldaymhKmtBbd0WnJZ6VwIHu/IL Xr25r3+ovEB4QAXgwkdJi5c5 X-Google-Smtp-Source: AGHT+IHktLh27UF6SwWXcuTMGgrd5PzOnnwJaNZnTznA+SHt8DnQ7XBNQGfcgy37yKImL7SiBzdycw== X-Received: by 2002:a17:902:ce91:b0:1d0:6ffd:ceb7 with SMTP id f17-20020a170902ce9100b001d06ffdceb7mr9928945plg.112.1702901252088; Mon, 18 Dec 2023 04:07:32 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:07:31 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam , Conor Dooley Subject: [PATCH v2 01/16] dt-bindings: phy: qmp-ufs: Fix PHY clocks Date: Mon, 18 Dec 2023 17:36:57 +0530 Message-Id: <20231218120712.16438-2-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040746_426530_EAE0F58B X-CRM114-Status: UNSURE ( 9.25 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org All QMP UFS PHYs except MSM8996 require 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC or TCSR (since SM8550) MSM8996 only requires 'ref' and 'qref' clocks. Hence, fix the binding to reflect the actual clock topology. This change obviously breaks the ABI, but it is inevitable since the clock topology needs to be accurately described in the binding. Reviewed-by: Conor Dooley Signed-off-by: Manivannan Sadhasivam --- .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 47 +++++++++---------- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml index f3a3296c811c..800f11b29dcd 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml @@ -37,15 +37,12 @@ properties: maxItems: 1 clocks: - minItems: 1 + minItems: 2 maxItems: 3 clock-names: - minItems: 1 - items: - - const: ref - - const: ref_aux - - const: qref + minItems: 2 + maxItems: 3 power-domains: maxItems: 1 @@ -85,22 +82,9 @@ allOf: compatible: contains: enum: + - qcom,msm8998-qmp-ufs-phy - qcom,sa8775p-qmp-ufs-phy - qcom,sc7280-qmp-ufs-phy - - qcom,sm8450-qmp-ufs-phy - then: - properties: - clocks: - minItems: 3 - clock-names: - minItems: 3 - - - if: - properties: - compatible: - contains: - enum: - - qcom,msm8998-qmp-ufs-phy - qcom,sc8180x-qmp-ufs-phy - qcom,sc8280xp-qmp-ufs-phy - qcom,sdm845-qmp-ufs-phy @@ -111,13 +95,18 @@ allOf: - qcom,sm8150-qmp-ufs-phy - qcom,sm8250-qmp-ufs-phy - qcom,sm8350-qmp-ufs-phy + - qcom,sm8450-qmp-ufs-phy - qcom,sm8550-qmp-ufs-phy then: properties: clocks: - maxItems: 2 + minItems: 3 + maxItems: 3 clock-names: - maxItems: 2 + items: + - const: ref + - const: ref_aux + - const: qref - if: properties: @@ -128,22 +117,28 @@ allOf: then: properties: clocks: - maxItems: 1 + minItems: 2 + maxItems: 2 clock-names: - maxItems: 1 + items: + - const: ref + - const: qref additionalProperties: false examples: - | #include + #include ufs_mem_phy: phy@1d87000 { compatible = "qcom,sc8280xp-qmp-ufs-phy"; reg = <0x01d87000 0x1000>; - clocks = <&gcc GCC_UFS_REF_CLKREF_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; - clock-names = "ref", "ref_aux"; + clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_REF_CLKREF_CLK>; + + clock-names = "ref", "ref_aux", "qref"; power-domains = <&gcc UFS_PHY_GDSC>; From patchwork Mon Dec 18 12:06:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496771 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96A1BC46CCD for ; Mon, 18 Dec 2023 12:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZEreNeHnv5ssBrVji2MRO+ybT9mDIoEmg/XbYsryc4s=; b=gNQTmvm9ntUmwM 9Hc9+gVKd/fDf5LaDaxUHKSgWpqtsEQgg7np1LMJwEKSWzIID60xF42todO+id/PTeqvM2Uypqoj4 Y+xc2cR9ZQGukTGJ6inY2zjqkrYisaUeFGmSvmo20K4pVgDm830OgzB+3apoMUXzOZ2vcWr2eykru zCq0Uoe5w9QBlI/V+c/eTd33oLwQZ1Wdght6Gbd504eA0aw09DZXe+LJaF0bEbp/f5Zi5/f5q6p84 8PVe8q3JDTNRmzvYoVWE+GEwEs3v46ZYo0T1V5dZT/Lc1xpiLfoQ0JLU0Uw9QXSYN3xHQABH9C84y GPqdocS9tPJpapvyxAvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPV-00AYJt-0y; Mon, 18 Dec 2023 12:07:49 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPR-00AYH6-2B for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:07:47 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1d307cf18fdso9632555ad.3 for ; Mon, 18 Dec 2023 04:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901257; x=1703506057; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qSz/bHjwwlCoYKLoGELFqaslJ84OPxmUtiMSGQ7rw5w=; b=bHl+Kt6Y8e3fnCOLHSwSNCg+1XSMFbDw9HL44u6duMILxI5WW3CBww98bH6e4+X2W7 Ul9K8xT6h+5xIf2IrDiyjKHEIaayl4Yg8AxWC7NiDWV3IQ1N8CJKgdfAi6+DN9rkvWDG xmrgJm6bito85yLYcYIuM+0YScoywIDLDXdNet+Q7CS7l0cMkC4GafcvIhftFpLHz1Cp WwypBzYt+HzVqJ+J4BQV8TVn8nl56Iwqqc6LnsqNToLM3xrAbohXqwH9wJh8t4KkZlBC g4VusVDXQzQFxdNV0+9BO5P1qmgemE7LyJKo9ybNRZS9sa+m0edpDxnv2sonB2sAgyxY 6LVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901257; x=1703506057; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qSz/bHjwwlCoYKLoGELFqaslJ84OPxmUtiMSGQ7rw5w=; b=n1RTqquOr1d2Sm3/fQYuTqjuloHbkneS7PvvcTGs9tFR3Q8Yn5IYTK5FXmHCVsvDO+ diUFC5/waaRzcMn0rjjcctTnjfCpyuzsmar1Y4qoH4iUpwSuS2OXjEiNerQSk3Xk4bw0 YFaPUebByxG0txo/QTs5Cp/w+fTFIWFk4O/vhwmLpM84ZmXD5bflBCTlgMEzNYuhTfyp Ry35aKeICx5Y/0aT7gaSmemSEmbNY3QvrsBtKTt0febiq5NLtEgVHOoSXtDA41BB60XM VD86daRY93dpQ1rzV6dlVHWzwohQNPjCMUtiRLAITcxIsCGI/Xm5Oe5+iXE60egO8VQQ ptVg== X-Gm-Message-State: AOJu0Yy1RJbYqvE+iKLTPaPahZQxeIp4O4V1/Cb7oJwXwdQlGEokD3JM qjqhMxyFwXRp5XX9QltjL9gC X-Google-Smtp-Source: AGHT+IG0t9oGeyfc7/rtJ11LwNl5za4dkimLF1SW6sE2PBnGyaGkf6vRgSEwEaOXIIyn5pgNgmTpCw== X-Received: by 2002:a17:902:da87:b0:1d3:acef:6f4c with SMTP id j7-20020a170902da8700b001d3acef6f4cmr651234plx.21.1702901257374; Mon, 18 Dec 2023 04:07:37 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:07:37 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 02/16] phy: qcom-qmp-ufs: Switch to devm_clk_bulk_get_all() API Date: Mon, 18 Dec 2023 17:36:58 +0530 Message-Id: <20231218120712.16438-3-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040745_716400_12F7AF79 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Device drivers should just rely on the clocks provided by the devicetree and enable/disable them based on the requirement. There is no need to validate the clocks provided by devicetree in the driver. That's the job of DT schema. So let's switch to devm_clk_bulk_get_all() API that just gets the clocks provided by devicetree and remove hardcoded clocks info. Signed-off-by: Manivannan Sadhasivam --- drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 61 +++---------------------- 1 file changed, 7 insertions(+), 54 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c index 514fa14df634..174b105fda82 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c @@ -837,9 +837,6 @@ struct qmp_phy_cfg { /* Additional sequence for HS G4 */ const struct qmp_phy_cfg_tbls tbls_hs_g4; - /* clock ids to be requested */ - const char * const *clk_list; - int num_clks; /* regulators to be requested */ const char * const *vreg_list; int num_vregs; @@ -865,6 +862,7 @@ struct qmp_ufs { void __iomem *rx2; struct clk_bulk_data *clks; + int num_clks; struct regulator_bulk_data *vregs; struct reset_control *ufs_reset; @@ -897,20 +895,6 @@ static inline void qphy_clrbits(void __iomem *base, u32 offset, u32 val) readl(base + offset); } -/* list of clocks required by phy */ -static const char * const msm8996_ufs_phy_clk_l[] = { - "ref", -}; - -/* the primary usb3 phy on sm8250 doesn't have a ref clock */ -static const char * const sm8450_ufs_phy_clk_l[] = { - "qref", "ref", "ref_aux", -}; - -static const char * const sdm845_ufs_phy_clk_l[] = { - "ref", "ref_aux", -}; - /* list of regulators */ static const char * const qmp_phy_vreg_l[] = { "vdda-phy", "vdda-pll", @@ -948,9 +932,6 @@ static const struct qmp_phy_cfg msm8996_ufsphy_cfg = { .rx_num = ARRAY_SIZE(msm8996_ufsphy_rx), }, - .clk_list = msm8996_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(msm8996_ufs_phy_clk_l), - .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), @@ -986,8 +967,6 @@ static const struct qmp_phy_cfg sa8775p_ufsphy_cfg = { .pcs = sm8350_ufsphy_g4_pcs, .pcs_num = ARRAY_SIZE(sm8350_ufsphy_g4_pcs), }, - .clk_list = sm8450_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sm8450_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v5_regs_layout, @@ -1020,8 +999,6 @@ static const struct qmp_phy_cfg sc7280_ufsphy_cfg = { .pcs = sm8150_ufsphy_hs_g4_pcs, .pcs_num = ARRAY_SIZE(sm8150_ufsphy_hs_g4_pcs), }, - .clk_list = sm8450_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sm8450_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v4_regs_layout, @@ -1054,8 +1031,6 @@ static const struct qmp_phy_cfg sc8280xp_ufsphy_cfg = { .pcs = sm8350_ufsphy_g4_pcs, .pcs_num = ARRAY_SIZE(sm8350_ufsphy_g4_pcs), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v5_regs_layout, @@ -1080,8 +1055,6 @@ static const struct qmp_phy_cfg sdm845_ufsphy_cfg = { .serdes = sdm845_ufsphy_hs_b_serdes, .serdes_num = ARRAY_SIZE(sdm845_ufsphy_hs_b_serdes), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v3_regs_layout, @@ -1108,8 +1081,6 @@ static const struct qmp_phy_cfg sm6115_ufsphy_cfg = { .serdes = sm6115_ufsphy_hs_b_serdes, .serdes_num = ARRAY_SIZE(sm6115_ufsphy_hs_b_serdes), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v2_regs_layout, @@ -1136,8 +1107,6 @@ static const struct qmp_phy_cfg sm7150_ufsphy_cfg = { .serdes = sdm845_ufsphy_hs_b_serdes, .serdes_num = ARRAY_SIZE(sdm845_ufsphy_hs_b_serdes), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v3_regs_layout, @@ -1172,8 +1141,6 @@ static const struct qmp_phy_cfg sm8150_ufsphy_cfg = { .pcs = sm8150_ufsphy_hs_g4_pcs, .pcs_num = ARRAY_SIZE(sm8150_ufsphy_hs_g4_pcs), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v4_regs_layout, @@ -1206,8 +1173,6 @@ static const struct qmp_phy_cfg sm8250_ufsphy_cfg = { .pcs = sm8150_ufsphy_hs_g4_pcs, .pcs_num = ARRAY_SIZE(sm8150_ufsphy_hs_g4_pcs), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v4_regs_layout, @@ -1240,8 +1205,6 @@ static const struct qmp_phy_cfg sm8350_ufsphy_cfg = { .pcs = sm8350_ufsphy_g4_pcs, .pcs_num = ARRAY_SIZE(sm8350_ufsphy_g4_pcs), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v5_regs_layout, @@ -1274,8 +1237,6 @@ static const struct qmp_phy_cfg sm8450_ufsphy_cfg = { .pcs = sm8350_ufsphy_g4_pcs, .pcs_num = ARRAY_SIZE(sm8350_ufsphy_g4_pcs), }, - .clk_list = sm8450_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sm8450_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v5_regs_layout, @@ -1296,8 +1257,6 @@ static const struct qmp_phy_cfg sm8550_ufsphy_cfg = { .pcs = sm8550_ufsphy_pcs, .pcs_num = ARRAY_SIZE(sm8550_ufsphy_pcs), }, - .clk_list = sdm845_ufs_phy_clk_l, - .num_clks = ARRAY_SIZE(sdm845_ufs_phy_clk_l), .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), .regs = ufsphy_v6_regs_layout, @@ -1383,7 +1342,7 @@ static int qmp_ufs_com_init(struct qmp_ufs *qmp) return ret; } - ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks); + ret = clk_bulk_prepare_enable(qmp->num_clks, qmp->clks); if (ret) goto err_disable_regulators; @@ -1403,7 +1362,7 @@ static int qmp_ufs_com_exit(struct qmp_ufs *qmp) reset_control_assert(qmp->ufs_reset); - clk_bulk_disable_unprepare(cfg->num_clks, qmp->clks); + clk_bulk_disable_unprepare(qmp->num_clks, qmp->clks); regulator_bulk_disable(cfg->num_vregs, qmp->vregs); @@ -1573,19 +1532,13 @@ static int qmp_ufs_vreg_init(struct qmp_ufs *qmp) static int qmp_ufs_clk_init(struct qmp_ufs *qmp) { - const struct qmp_phy_cfg *cfg = qmp->cfg; struct device *dev = qmp->dev; - int num = cfg->num_clks; - int i; - qmp->clks = devm_kcalloc(dev, num, sizeof(*qmp->clks), GFP_KERNEL); - if (!qmp->clks) - return -ENOMEM; + qmp->num_clks = devm_clk_bulk_get_all(dev, &qmp->clks); + if (qmp->num_clks < 0) + return qmp->num_clks; - for (i = 0; i < num; i++) - qmp->clks[i].id = cfg->clk_list[i]; - - return devm_clk_bulk_get(dev, num, qmp->clks); + return 0; } static void qmp_ufs_clk_release_provider(void *res) From patchwork Mon Dec 18 12:06:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496772 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C80FC46CD3 for ; Mon, 18 Dec 2023 12:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1AeJicluiiD8Rj+y2XmteEvU6MbX1uwTRGR8r0GW6gA=; b=QNNnP1cK5Y3a0U 6hhg8YQMlLahsaAMbMEAgJXIdoPVgYqUkhQspi9AVfP2vBi36kvfrXrV1zHvZPUgq1R0QBpCbzfV1 XJe2YrTEL5LG7Z3wbCv+YjW4936t+MreUDSUXRTDH78ID9DFGkvNOkx9+bWfBZWPbEwf9LWFVp3yf 9W/a1Bkh+FBha9h8DWdACZcgzXHPcUoKBLzBrBuKhpitcPWcxvRBKbhiDaE7P9sVsvEqHRyVnz6re hDdICVXi5O0vDDEoUR6RZPqbYQqIk/P1OtSkH8muDi3VvoV0DNLSqIMLFbXcoYsstynaATtMYc0pN 93+ZtuLMreCz4xUY1o4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPV-00AYKT-33; Mon, 18 Dec 2023 12:07:49 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPT-00AYIJ-1F for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:07:48 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1d3ad3ad517so2509905ad.0 for ; Mon, 18 Dec 2023 04:07:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901263; x=1703506063; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4lYTGtSYRVAJ3w0j3YsinoBhP2NVVpIT5xX2iQPFdpw=; b=U6yaVbquXzHdoQkvUPJWislpsle2xEr6ZxLtPrAk6h3tkMTVaxDaUGBH35n+bo0A/Q MVbivt9oLp63YUdcKaXLhBzugSe6J/dqfP64in83av8okL2iS4ioWN7AemyWzZ8bJKoK GgD40cLPCv+zINKTdXtK5t8C+O3hxfUXv70sHmp4LhW351mxqH01hr3rAgTUJGWLpXTV OGQjSa3KdTJLL5VL0+p8roznd3j6DpRsm8Vzz4Zyv7NQ66A1Xku+6OSUHfuOxsaMD/I/ v/KHqQFz3pq6vlXT2feo7jwS9MFIw5XmBF8Q2U+o2gCHyZPoFefAtqQcfj1NjyqSU1Y0 1M8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901263; x=1703506063; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4lYTGtSYRVAJ3w0j3YsinoBhP2NVVpIT5xX2iQPFdpw=; b=RHmTrO3XgbMSDlUljHGrb9QKDFOm6h2zFoB4dDHvidFwY++teHyhJABq79mAmS5ZCp Xn3uLfhHTiTgYk/qDvwdwUJIYNba9B85q8aoOhB9dwPWdsD5aq5oCcaHMhuso8J7VCJn 2smNiyzy4vW55TwfEYkzCGBa5x5bRL1D9jRd5TsjWiLpVFHZyFV3lawpmLk3XOrxJRV5 nFfPPL3FQRK6g+OsBxhC9Hv0PfyRLprkEkMl4vj/fBufNKOQLu2zvAvSpuqIbd+UyYjP 38aWsgj9Kmy8j18r7Y9c1f4wyGcGjXPSefCEJhoGqoCrTRh3WomGR4MZ6aH4gi4rOdtu nOLA== X-Gm-Message-State: AOJu0YzbXjCV1pI25Fg8O+LH5TPJKyuPUG23/4Y+0/Q9wKarSBpQ6uuW AtJTGhN2Ibfl/pGXpXpltSvm X-Google-Smtp-Source: AGHT+IFchFcItXdYBMDjNrlYDL5eL8NpYrejRm/1PBJqhUeZQOSSH05NdaFx3MvPVMg5AHAMkiQ1PQ== X-Received: by 2002:a17:903:32c7:b0:1d3:6110:32fd with SMTP id i7-20020a17090332c700b001d3611032fdmr4820556plr.110.1702901263463; Mon, 18 Dec 2023 04:07:43 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:07:43 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 03/16] dt-bindings: clock: qcom: Add missing UFS QREF clocks Date: Mon, 18 Dec 2023 17:36:59 +0530 Message-Id: <20231218120712.16438-4-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040747_434218_62978028 X-CRM114-Status: UNSURE ( 7.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Add missing QREF clocks for UFS MEM and UFS CARD controllers. Fixes: 0fadcdfdcf57 ("dt-bindings: clock: Add SC8180x GCC binding") Signed-off-by: Manivannan Sadhasivam Acked-by: Krzysztof Kozlowski --- include/dt-bindings/clock/qcom,gcc-sc8180x.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dt-bindings/clock/qcom,gcc-sc8180x.h b/include/dt-bindings/clock/qcom,gcc-sc8180x.h index e893415ae13d..90c6e021a035 100644 --- a/include/dt-bindings/clock/qcom,gcc-sc8180x.h +++ b/include/dt-bindings/clock/qcom,gcc-sc8180x.h @@ -246,6 +246,8 @@ #define GCC_PCIE_3_CLKREF_CLK 236 #define GCC_USB3_PRIM_CLKREF_CLK 237 #define GCC_USB3_SEC_CLKREF_CLK 238 +#define GCC_UFS_MEM_CLKREF_EN 239 +#define GCC_UFS_CARD_CLKREF_EN 240 #define GCC_EMAC_BCR 0 #define GCC_GPU_BCR 1 From patchwork Mon Dec 18 12:07:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496773 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9455AC35274 for ; Mon, 18 Dec 2023 12:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=chuoXiZzmrJRTMSHTrmjp76jwU4DeCxEBs9PCWHXKZo=; b=g5yi4TKh156rmq mYjO3XbS1kt9kr5LmRnDyr1rskSv8uqBFHiR2t/QuZWJJD8T3S1je9gGdJ8MX9r6kkACoM6b2XC9c Baz0xdvS7wu4YwxHyQchjaF6ctQmdQKjf1tN0XiIHzoMuzSgE42bHtXiogS6pm1iw5MEDwzGnjYi3 BYjfYDSU1DrVDzNDwHErqE46g2vzNbfqXwX8sncv6evWDUJ36zvzMlQrcs3GDLdTkqQW8+pbE2s8W ud+ynqK5tEBvvnwGTPj032UzIasJ7piJbw7QA22+Q6lAKTNTOYqeAp3MIUOgKfs+Clrs83wmcwdzN GIS5ZQQGd5Uo4ZMH/ECw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPY-00AYL5-18; Mon, 18 Dec 2023 12:07:52 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPV-00AYK5-2k for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:07:51 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1d3ce28ac3cso1377765ad.0 for ; Mon, 18 Dec 2023 04:07:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901269; x=1703506069; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1DxFXPJYgIG7bY+rEjLLq6eWKt7yGgrHuHLxSAUgD04=; b=WCkyt7FTAV4wwqMr/j3QjRNz5KBs964kwJ6povNRpnIbI3kI6MDwdYcX99Fcsf0Y9o PWEYVMwt5itVWt/ZBR9SEtkpI2WlXRlbe693wy6MXtrRJc4ZP3PaCkvftLZRgxIkmf0N 0v7TctiFNY73YtqorxnGXUZiBB/kstOCfPXf6UYZhFjCYOKTTZOMQJbHcU8nubgkF7ie o0dQh5uWysypxHaxcqWmldu2zo2nnPEf215pci5kOe8xJjnzyi8yU2oxn9wO3SOh5p1O 8iHvovlQJ8BJ8YfZP6IFX13Lw8PNwS7fqgsTyYSfNpNYLpAZFQPUnzPE3kNyOxqyQeao mv2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901269; x=1703506069; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1DxFXPJYgIG7bY+rEjLLq6eWKt7yGgrHuHLxSAUgD04=; b=bAs96i7TxAPimxoYMXnVO3iFVVxEKQbgiViwy5kDLK5iTLI13r1Q4g6E94EDne6sql nZ7yz4WOa/sQGot00LZ52EH7WRH6Hdp/FqI6RZX7RETsTEDUIJH5omt9wYdNc1dImAXU BLdXfvMNfT6ZpwFgH/RKpZc8u8ziFFu1ILAnhYvSEjbAKKiezmAkywWEOboTOKgiOHIb Y8Qno2zeVbZS6sDOP7CRSwzrKU2IRhj974kkrwc/6MyK3WqRH6k5A0tEXSkIs4e/oUeb TfEwUGMsLroDIESjyGZeRau98AFH2vo3zDg/abl7Ml91vXMZti8xdkbz7kKdJ1lbqf71 pP3Q== X-Gm-Message-State: AOJu0Yy6En3RSOx218/zmq324Ksfi5tfEFEYLlcG+aMAJ8rGTJntwD7k 5+XkM2BxQUmmZ+yLSiQJNTFB X-Google-Smtp-Source: AGHT+IEK1evDaORIVdgFmQY6oqeCQ/c/a7zO1rPGBojethcXGGLrT6jJIMMz7NCm2ipjlMCXMK2xiA== X-Received: by 2002:a17:903:110e:b0:1d3:1773:8555 with SMTP id n14-20020a170903110e00b001d317738555mr5851554plh.115.1702901269314; Mon, 18 Dec 2023 04:07:49 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:07:48 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 04/16] clk: qcom: gcc-sc8180x: Add missing UFS QREF clocks Date: Mon, 18 Dec 2023 17:37:00 +0530 Message-Id: <20231218120712.16438-5-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040749_889254_F79D48B6 X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Add missing QREF clocks for UFS MEM and UFS CARD controllers. Fixes: 4433594bbe5d ("clk: qcom: gcc: Add global clock controller driver for SC8180x") Signed-off-by: Manivannan Sadhasivam Acked-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sc8180x.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/clk/qcom/gcc-sc8180x.c b/drivers/clk/qcom/gcc-sc8180x.c index ae2147381559..544567db45f1 100644 --- a/drivers/clk/qcom/gcc-sc8180x.c +++ b/drivers/clk/qcom/gcc-sc8180x.c @@ -3347,6 +3347,19 @@ static struct clk_branch gcc_ufs_card_2_unipro_core_clk = { }, }; +static struct clk_branch gcc_ufs_card_clkref_en = { + .halt_reg = 0x8c004, + .halt_check = BRANCH_HALT, + .clkr = { + .enable_reg = 0x8c004, + .enable_mask = BIT(0), + .hw.init = &(const struct clk_init_data) { + .name = "gcc_ufs_card_clkref_en", + .ops = &clk_branch2_ops, + }, + }, +}; + static struct clk_branch gcc_ufs_card_ahb_clk = { .halt_reg = 0x75014, .halt_check = BRANCH_HALT, @@ -3561,6 +3574,19 @@ static struct clk_branch gcc_ufs_card_unipro_core_hw_ctl_clk = { }, }; +static struct clk_branch gcc_ufs_mem_clkref_en = { + .halt_reg = 0x8c000, + .halt_check = BRANCH_HALT, + .clkr = { + .enable_reg = 0x8c000, + .enable_mask = BIT(0), + .hw.init = &(const struct clk_init_data) { + .name = "gcc_ufs_mem_clkref_en", + .ops = &clk_branch2_ops, + }, + }, +}; + static struct clk_branch gcc_ufs_phy_ahb_clk = { .halt_reg = 0x77014, .halt_check = BRANCH_HALT, @@ -4413,6 +4439,7 @@ static struct clk_regmap *gcc_sc8180x_clocks[] = { [GCC_UFS_CARD_2_TX_SYMBOL_0_CLK] = &gcc_ufs_card_2_tx_symbol_0_clk.clkr, [GCC_UFS_CARD_2_UNIPRO_CORE_CLK] = &gcc_ufs_card_2_unipro_core_clk.clkr, [GCC_UFS_CARD_2_UNIPRO_CORE_CLK_SRC] = &gcc_ufs_card_2_unipro_core_clk_src.clkr, + [GCC_UFS_CARD_CLKREF_EN] = &gcc_ufs_card_clkref_en.clkr, [GCC_UFS_CARD_AHB_CLK] = &gcc_ufs_card_ahb_clk.clkr, [GCC_UFS_CARD_AXI_CLK] = &gcc_ufs_card_axi_clk.clkr, [GCC_UFS_CARD_AXI_CLK_SRC] = &gcc_ufs_card_axi_clk_src.clkr, @@ -4429,6 +4456,7 @@ static struct clk_regmap *gcc_sc8180x_clocks[] = { [GCC_UFS_CARD_UNIPRO_CORE_CLK] = &gcc_ufs_card_unipro_core_clk.clkr, [GCC_UFS_CARD_UNIPRO_CORE_CLK_SRC] = &gcc_ufs_card_unipro_core_clk_src.clkr, [GCC_UFS_CARD_UNIPRO_CORE_HW_CTL_CLK] = &gcc_ufs_card_unipro_core_hw_ctl_clk.clkr, + [GCC_UFS_MEM_CLKREF_EN] = &gcc_ufs_mem_clkref_en.clkr, [GCC_UFS_PHY_AHB_CLK] = &gcc_ufs_phy_ahb_clk.clkr, [GCC_UFS_PHY_AXI_CLK] = &gcc_ufs_phy_axi_clk.clkr, [GCC_UFS_PHY_AXI_CLK_SRC] = &gcc_ufs_phy_axi_clk_src.clkr, From patchwork Mon Dec 18 12:07:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496779 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A274C35274 for ; Mon, 18 Dec 2023 12:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l9KC+OzREHkw5GV/sCPU3tQJKB2+Asqtxfgj2y238/M=; b=fpwj2SN84qorif ooNXgr2o+gxeZEjGM/HawyrLp5PY03yv0aydXIWOjXWXDOUTmy1D4azp4S+mYIfzBt8VpncclzgMk wnkhcLC6hg5zQF9FcS4BK6y5hZM5ETpnbaCw67HC8lLIaSgNMEU60ue77VU9IIP0f4/sq0EPCplLG bLlnB6fY0SQMVCjihfrXLJ4vFtQPnsY7PCN/2n5eVLdyCbWu/s3JRelmlfL+VP8hmGxnTmWKL94/g nnM4C+Vm+F9y31CHjCnaBDgGji18pQ8//vFHgO944HF34peL7DtKoUCrilQxOUuPd0/82Qz0W91BY JUxu3v9BHLI3X0rphl0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPf-00AYNc-2h; Mon, 18 Dec 2023 12:07:59 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPd-00AYLs-09 for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:07:59 +0000 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-5ca29c131ebso2442796a12.0 for ; Mon, 18 Dec 2023 04:07:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901275; x=1703506075; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KzU01i6st7Fo+4S1d9zRuY0iUyHKgjsO1CA7YDVBW60=; b=W54t/IWFN5VRRkDbEk8JI9xZaaS7BAsV8Qj7NkPnbxflJMLoTgZRH6eG0b+SLFa3mf iMLDBJGaMLFR+L8+9jAVemi+kTNaNF308F1lswuqnvL0X1L1ZqgWoMR6vhByfU+OmsE4 CJUkZzctHlcxlLsBYqYAtbHq+Fnbo2PKL25fV3/HhUVEfu47WnKw208H9T82ruw4VmEd kIhRX0aIogDU3yHwDvrXExhsJr6GkK2a0CHTUa4PSsePgPKTLWzqp+UJPM05HcRbOQ6t 0GXPrKoMjkILfaJBGVEd2bNcccfe3ErLMRleBH+wWi3nicBTAIRIik2/lJ1YK7XtRZjd Ye+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901275; x=1703506075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KzU01i6st7Fo+4S1d9zRuY0iUyHKgjsO1CA7YDVBW60=; b=T8PSZkKa3/VZmIThyLtQmRqxYfAn9OKeJbrMMjowEH5lmMbli70n3vIoJlIsFp2+6X vrDQk0OuZFL8KI3zyyf7dBrkZNpxw2wSSGGqW8h8kPiSjFQhzhk3YD51FXkBaSukDjZA ncJyFky+4EyJHnW2TX8a7WWZSSl/mftembNoPVx3ooFmigbGyNR1uxtlVu9sk3aH5uK5 jw7/4rV+9Bjk2nWC5ue3DdIqHw3645K2/iRmCBR0cGh9A2E5jrGcrgVhL4C5VAiT/9sL aOPH0Qq0oYlcPsEV81LHTB7VwInpe5zJRKPgUbEaFMMUk7zrzuUAeLPda5AlwZt9S78B z3ng== X-Gm-Message-State: AOJu0YyCXHQh94MNYdSltRfpRe7RtzzNOtrermAoFR9zLuTsSRfc9JaP CY7vE0oV4fUE9AT0cUunhMQh X-Google-Smtp-Source: AGHT+IGpYOV/SJS+GqznnUdK0MyAkEm3zZZSxOs9irbVbbQ1gkqu08h5/o5UYUypquxsVeUHv6aoQg== X-Received: by 2002:a17:902:d54c:b0:1d3:3952:8885 with SMTP id z12-20020a170902d54c00b001d339528885mr13518743plf.11.1702901275224; Mon, 18 Dec 2023 04:07:55 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:07:54 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 05/16] arm64: dts: qcom: msm8996: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:01 +0530 Message-Id: <20231218120712.16438-6-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040757_078968_BEFEAE8C X-CRM114-Status: UNSURE ( 9.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in MSM8996 requires 2 clocks: * ref - 19.2MHz reference clock from RPM * qref - QREF clock from GCC Fixes: 27520210e881 ("arm64: dts: qcom: msm8996: Use generic QMP driver for UFS") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 6ba9da9e6a8b..b235f1d651aa 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -2105,8 +2105,8 @@ ufsphy: phy@627000 { #size-cells = <1>; ranges; - clocks = <&gcc GCC_UFS_CLKREF_CLK>; - clock-names = "ref"; + clocks = <&rpmcc RPM_SMD_LN_BB_CLK>, <&gcc GCC_UFS_CLKREF_CLK>; + clock-names = "ref", "qref"; resets = <&ufshc 0>; reset-names = "ufsphy"; From patchwork Mon Dec 18 12:07:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AD24C35274 for ; Mon, 18 Dec 2023 12:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pLJyx+owKN5vbaAXEip/ncSGXT2I07AxymFXBQSAaS8=; b=GKtx0fNYiywJZl rCOFL91BH2c/Xn2nA7UciUcfpZUJTyj1N5T+2XULFkaFbD1w79XYgeervTDRON+FxyVqLO5eIEtnZ dRrS8eLWm2b2tbV6YcHQ+Fc8FMHyOK7FCswBV2ewl/qb8+Bogu2mO/bPe6kETorGkge5eywCCva9U QwqBhlQtyGsXwZ068Ym8X0J6m4FgdeF9MZp8jA+R8ApcDp18eCds+tVVZjMd3CE6BjjvaiwCBnFR1 4eSHEnzuJiP3B6gtBaMwwHNPbFvBJ5fy/Uhxqq9ftP9cK9ByV9m0bKwl/j39D4hH7bt6jE/G4YJBj LjjOUevY5KC3Q0kWMsoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPm-00AYPk-2m; Mon, 18 Dec 2023 12:08:06 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPl-00AYOE-02 for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:08:06 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1d3c1a0d91eso2368275ad.2 for ; Mon, 18 Dec 2023 04:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901281; x=1703506081; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E7tHzmERAQbZImeje4EMokx1gYyccc/9b3w+T8ZyCDU=; b=V2duq+esGJ16tcOxrJMFqLnaUE5SESeFp9bpjkSyD7I2BqXqiiOGhhRsxvUtbvd7AL VJM+ik9WT61gQqzai9llMoXxKjqg+mfFDEQpijV6KMOpW2jt5Hi3xQp4q1NrPC0AmpP0 zg0pyC8sz3f46jSD+zy7yDgIiIwHZIL+0IxdfKSe2PgpvV21PttRi4fvwlJkHn1Y7FGJ au2BTU10S8vBAePtPlNLv+n1fmTdsjwdg3osIccitY9kC2FeqDb9phtm77aJECQ0VMjQ J6xgahFlHexSQlVuIItKhHYP8jhfNXZnKSy7dJrwJgSIuVXEfc+jnAZyPapoLRMJUK/5 JFTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901281; x=1703506081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E7tHzmERAQbZImeje4EMokx1gYyccc/9b3w+T8ZyCDU=; b=TdYBAs1097kJymUuUAn/OB55ry9e+otqsi6vghKXbEWPzQ+JFMQWnPbaLa1BLqqEEq QnvquqCXvH6NaTH21iH4F1qUxTDyCMHevx87+X2CWBhob+jwzF0x9/aBFk7iiJWHkweu SU0AYg8kfnbFb3bQpLAyAY5HVFdCTeXy1QhThq7XSWBzsewhZ55qCAFrrJ/UGp+mJGSd 3sNTF0INRS9cOYVYl4rR07r9aHNAJtbRoIotGh5QrzU5/kWxii0WdZnrx6mD/TfaIQ4B wQV4axVViAm1oAIREJsbHE+/TDOTzS0j3QMwy4d/NxWLxQOVhK927r/ZfZDcGz4vUI4M Go6Q== X-Gm-Message-State: AOJu0YyU9wkW7pZlf4iFl53i2aYmbVhuG1dkHcaon/fKrvenROGPPGBm YHRVVxwloC346ARNQPHD2pKV X-Google-Smtp-Source: AGHT+IFpmFbwrX35pR8JXljDwh59BiNAQY5Eow8L0IqGWR6FSSBRUPbJHpRKtOzNMeLuiWR9vuMXoQ== X-Received: by 2002:a17:902:ced2:b0:1d3:6408:211a with SMTP id d18-20020a170902ced200b001d36408211amr4518454plg.129.1702901281187; Mon, 18 Dec 2023 04:08:01 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.07.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:08:00 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 06/16] arm64: dts: qcom: msm8998: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:02 +0530 Message-Id: <20231218120712.16438-7-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040805_046482_91B9B6ED X-CRM114-Status: UNSURE ( 8.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in MSM8998 requires 3 clocks: * ref - 19.2MHz reference clock from RPM * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC Fixes: cd3dbe2a4e6c ("arm64: dts: qcom: msm8998: Add UFS nodes") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index b6a3e6afaefd..d4c55e2b0043 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -1051,12 +1051,12 @@ ufsphy: phy@1da7000 { status = "disabled"; ranges; - clock-names = - "ref", - "ref_aux"; - clocks = - <&gcc GCC_UFS_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_AUX_CLK>; + clocks = <&rpmcc RPM_SMD_LN_BB_CLK1>, + <&gcc GCC_UFS_PHY_AUX_CLK>, + <&gcc GCC_UFS_CLKREF_CLK>; + clock-names = "ref", + "ref_aux", + "qref"; reset-names = "ufsphy"; resets = <&ufshc 0>; From patchwork Mon Dec 18 12:07:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DC68C35274 for ; Mon, 18 Dec 2023 12:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ik+7u2/eCVG+k1Jujzb5qXo+FdrwJcjOBLUTgxjiSJc=; b=Z4JxkjwStvhgdk MMCqaGtki6klnOjZJNSNrGsGcDKwcMPsF+RL2iE+A/V8WVLBStj0xPQVbW9ei4ekQSbAYlvFGW6D5 M+BlzmSQEBvRflEgcNfa4iA7sVNMTLNX1uCKLe10uZrZ8EyWu/tT74w62eU1wPf4L4lddWkmgvoFr K953XiqkaAL0q5fclRr9AHFE5yo3zYOPEEnp7l+t/pZXcJqrrjpWmOkBCWryUnC1d57tDajj5YwiQ riyRKxKQUrTuYltiocigkZ2slRLhv/NxeSa9A6iae7MjNdv5P4ls7z0Rn64x+pf8CuF2Kob34UoH5 oIe4nzbr2Xfm4svA+oDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPr-00AYQn-0p; Mon, 18 Dec 2023 12:08:11 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPp-00AYPw-0j for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:08:10 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1d39afa1eecso15672185ad.2 for ; Mon, 18 Dec 2023 04:08:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901287; x=1703506087; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bQdElwhJNkunjNkKmQMPCEqC6kOTfOJsifUeDg9TJE0=; b=T6xVHRyEpj3m8TTXIUkafow2O8jEuHlHsQp5i53br08PO8BaypYN4307HEVFYNkx3+ wRA3o3oOkOeNfGk/uIWMgE1dwc9AC3ffxb1HBfaggSpIH7WjT1xMZhA7SY2YZv4BKaGr ScD2MZ/BtuWfcVpPyzyaxrh6bFh4nf5FVev9jTTkMYl9a5+gTxcITkhanox405XfRxmZ kXhUpbX0UbRi+HbFR+y6ZETkM51EVnx1jj5PXshJ2ylojBOHJCc8U3MVawADgHDf0gh3 OyimB4TL7r0yYzTWW9K28b+pCrgi83aPDVVpnQ9Se2o2O/H3IM5LU36/0SKO4ThUKEq5 UmvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901287; x=1703506087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bQdElwhJNkunjNkKmQMPCEqC6kOTfOJsifUeDg9TJE0=; b=JeMlv2fnRF+97eUEByPpcAb0lVywMJrDHo1A418MsYaRHBLR1f2Af0EQzgQVOBDNRP KHs/40In4pay4J89YNS1MorQVXZkEnXPE8ACcPBqzvHGmA9YBMteGhXBU/i9rZw4ed2u laffR/jsual84pnFdAwp0oxmSO1xFLEd1voGQZ509snDLYbbex8+fDqpHhK2YdWzgnVc XRm1nu0blGTKZBI48ejWF2booVJJEnNw6kidbczFvxCnAa4tk3S9gxsS/6wWbpRTsEXn T2ojU/yQyJWBkebWg32jkAfU6LAEi77UWMrTSHEQI2AoIajhOLIlq8SfNl2I8OI/kQfk Ufuw== X-Gm-Message-State: AOJu0YwFdDJf6Ujroqq3hp4cdkdnP7C2B2YRZJKA91xjchLdIRokw+Kz YH9bUOIHDGDNGink7mPqmIGL X-Google-Smtp-Source: AGHT+IFNgLs5EPRIQlG8vNg7cDLPbZb3pQzoiuB8DApHzGVX2h2mUfRn7BSJx96zPNyECoKW+QnqKA== X-Received: by 2002:a17:902:f68b:b0:1d0:6ffe:9f7 with SMTP id l11-20020a170902f68b00b001d06ffe09f7mr20769460plg.85.1702901287157; Mon, 18 Dec 2023 04:08:07 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.08.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:08:06 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 07/16] arm64: dts: qcom: sdm845: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:03 +0530 Message-Id: <20231218120712.16438-8-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040809_263036_0F7F8585 X-CRM114-Status: UNSURE ( 8.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SDM845 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC While at it, let's move 'clocks' property before 'clock-names' to match the style used commonly. Fixes: cc16687fbd74 ("arm64: dts: qcom: sdm845: add UFS controller") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index cb3bfd262851..a7529af5bc6d 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -2619,10 +2619,12 @@ ufs_mem_phy: phy@1d87000 { #address-cells = <2>; #size-cells = <2>; ranges; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_MEM_CLKREF_CLK>; clock-names = "ref", - "ref_aux"; - clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Mon Dec 18 12:07:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496782 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D4B2C46CCD for ; Mon, 18 Dec 2023 12:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PD6ij3khvuzBY+9Bh9WRb0OQcG55Zw95p+UD5FnKURA=; b=3Clia/NLdv70gv 1RAFP9mu/uVnz0/0bzEJVnhX3rHhE735IrGp7GLJnBxdYBdA8cLnF08Ta/6WDjud7yLTHVUD9Q6Oz sNR/kbRbQesHXt5ONRXjN7xY0OiK6EX7YHdR+YX6QIAmknKT6SobstrqaP9G9Lmrf6o6GsNMtiaz2 FRJkt0NfrkPj3PiXy6rG6ln7d5SXZxKrsW27pg0WBg/94fyqmgOHHYXFEkHMV7sicaURSo9JZyYqJ ln34HyLMUhcSflyh79GbJRh5U60ZyXNs0IOev2UoUmEecmhiBG2cjGdcdRY5wbEzWMxIZIjLmJpMk +JkR5YAKzN5YlLED3Prg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPz-00AYTm-2U; Mon, 18 Dec 2023 12:08:19 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPw-00AYRA-0R for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:08:18 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1d3d0faf262so907925ad.3 for ; Mon, 18 Dec 2023 04:08:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901293; x=1703506093; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9loaHfrne3H3i5jJvNSoB5V0DmyPKqbag1DqqG2m2L0=; b=yijqb5mAdp7OcPdXGU79/nanbvxkPKTSfZk1P+1xuOIZHnU0qO9nFXt/wB0vWV+RRv n7DfFl15xRKos64txqpRFLZB8zj+JRfpJZZObyzg8lW2KVZhupqBynv1017sTFT5rtkg qRj02Y5iyHshmQ25CiHupOZc3uST9xyYLsfm4igLVt0mfL2QUSed186MD4F9P/4g7ZAf XsOMnTtqfvvT2//l8M9xWKqpetgnF50r9aZSr7rWtc11LDBpLQfiaVyFP86o4Edn++/H 89aI7L9dkvYo7BSqrXX4YOwPrWLooPDdxicBHooX7dbdqZJj35l5x1HhrdTHgTz31inn DJ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901293; x=1703506093; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9loaHfrne3H3i5jJvNSoB5V0DmyPKqbag1DqqG2m2L0=; b=xSv3clbBxBkxIfwGVX778bbz+11L48hxy6HKbAfgP+14hbZn406eR1k+oBGKESWPmX zQhHHdGlMpic2WCfqyrFhMGiwsblv91ZD9MS+Y18Up4WHnATJvZE3RdhTpv+qKq55i5S iCq6MLCQjSgfrNh7R2UebXZCr9Fime4cfL20AqDy0ICM1zGQBhVF1H4hiroPI7ObuhPD g5admqud3l9V4mEwiEexwJCXjafkt7I88H9BWw6+L37Omz8pN59LbyRkb9tzY5PA4X8D 0K8KSuxE340/d+J+2XBdCPS42zJs3u2TnSddNFrNJTf0DURevB/dUdRTOuxf8AE3vWfA x8bA== X-Gm-Message-State: AOJu0YxnO5ULZN3FcDauekDFesCmkZF2wulJQFb4gJGNyb67rgOl68Na xSeuW+qcZ2VnnOmaWF/QCnbb X-Google-Smtp-Source: AGHT+IGaxr64tfg1aM5VCDEAL5s2XMkt87LjGgVw1oRinho5wP3KRT0+O3ZPy6QGZ/LPQE6WGGw8Pw== X-Received: by 2002:a17:902:7846:b0:1d3:47ba:ba45 with SMTP id e6-20020a170902784600b001d347baba45mr8139066pln.136.1702901293170; Mon, 18 Dec 2023 04:08:13 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:08:12 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 08/16] arm64: dts: qcom: sm6115: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:04 +0530 Message-Id: <20231218120712.16438-9-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040816_172181_61DD8958 X-CRM114-Status: UNSURE ( 8.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM6115 requires 3 clocks: * ref - 19.2MHz reference clock from RPM * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC Fixes: 97e563bf5ba1 ("arm64: dts: qcom: sm6115: Add basic soc dtsi") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm6115.dtsi | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi index 839c60351240..40394c412fdf 100644 --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi @@ -1033,8 +1033,12 @@ ufs_mem_phy: phy@4807000 { #size-cells = <2>; ranges; - clocks = <&gcc GCC_UFS_CLKREF_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; - clock-names = "ref", "ref_aux"; + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_CLKREF_CLK>; + clock-names = "ref", + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Mon Dec 18 12:07:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496783 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FD30C35274 for ; Mon, 18 Dec 2023 12:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+BXy4TYRNXf9tYClNc6Bvn6gLp7Y4E8JAQfmj5ZcfQg=; b=YlSHpq3OiI058B TUnw1clkHDfbHA5L/JJmhxf22nFz469TV5SUdehcB5Ugmqz9fMUP1YWhvuW/rNKxm11/3OyPHXwb7 o7eZBE5vCJkuw3Bw2DNME/pr+jptonntvEE1NJwRvv1p/pcYyEFxw/q8AjCml7U67NcqdsarepFgT wxpeAPaGJM6vHjqRPZoIJMgsz+CwTjCXRH3ra6b9TvNbf1fCqDidF48Kt5dRYRwXXjp2m5whFapF0 GLMX9aPJeDEdB/8MzIuALImE0FaeYcKS03SncVXOsPMxa3hTTj8DeWipi6dvKgOWJxP8iu+CTpjXa Tiic3IAPIweDqXOohn5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQ2-00AYUU-0R; Mon, 18 Dec 2023 12:08:22 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCPz-00AYTY-2C for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:08:20 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1d3ab37d0d1so3474065ad.0 for ; Mon, 18 Dec 2023 04:08:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901299; x=1703506099; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/R/hqTzd/o8JpkxBFS0sj0AJtadDOIWSQt92Ki/rlFQ=; b=zczxH6xMnupUdVmkx9ynJVKdGn2Th39StIbyiuIfsKlMTp46relBz8xa9ueBik/MEt hAkXd03xxRdcqQz8rWKdeq9N8ISp5szwE6deAoev3g8rY89gBczWYAVcYJvS02rK2s3n FDV0PaWOQL3CsUs9mrLdOxleRMg0BO8sJRAPN/FVIm0tW9QTZlZHYCnuqIjnCWDEmsgN EbO8z3REwx1wCwmqtcZAdHbnusj7ZL8gv4EOaV35pfoEECyy4IZdRR//rKZk4mAH6MEH Gge7gpyBUmQLKzGrOT8FcCj/KPTxIEWkWe9hxV+2YFQU8droWekhzQR0R2JqukCVZbVu LFgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901299; x=1703506099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/R/hqTzd/o8JpkxBFS0sj0AJtadDOIWSQt92Ki/rlFQ=; b=Q0WmcrGQ8F94z/xGwqP2eC7fpvIULnTEd5gVS4d62ChoZnMBm9xrdwB718TLVJM7Hn IGa7wx9aHe4YUU4JKC9ULsIC5uGwkI6xPv0bcjVt6u4DQlexPwX+lOpYqQC+m7pbhe/U iP/tOOdSROFMeilN9hy68TrYrQ2i9MKGXx8i50TqnIXQjMUjbZxKwZ4d+Ou6kYowYDbx 5KpQztEyTcJj72GdO5L7gjDr9JIw2HBR6FGSUhml/yhI4Ti9zW4RPJts5LmHO89FLqoO H4myIj3puQdQvlJU0sJ/WLu99ypAE8C2sUMgCbDZCgs3Fuz0avtZsBtmYRTamjkTBeLW hj7Q== X-Gm-Message-State: AOJu0YycpF580OudJgXwWvqDT67ObZ+XbabQvVKOvmmHx13Alt0UrIg3 kNUXZL6C6NG3PGjb0pZf3Lpq X-Google-Smtp-Source: AGHT+IGkvDJKUZhvMT1zocpm838dWNiBdAdJ7LY+l+3dLPhpispjyloWmDVXqZesfg+UeMzUtuQUDQ== X-Received: by 2002:a17:902:f690:b0:1d3:c3b7:50f5 with SMTP id l16-20020a170902f69000b001d3c3b750f5mr470070plg.87.1702901299155; Mon, 18 Dec 2023 04:08:19 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:08:18 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 09/16] arm64: dts: qcom: sm6125: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:05 +0530 Message-Id: <20231218120712.16438-10-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040819_715373_28AB2542 X-CRM114-Status: UNSURE ( 8.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM6125 requires 3 clocks: * ref - 19.2MHz reference clock from RPM * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC Fixes: f8399e8a2f80 ("arm64: dts: qcom: sm6125: Add UFS nodes") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm6125.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi index eb07eca3a48d..b46d3c1fa47a 100644 --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi @@ -812,10 +812,12 @@ ufs_mem_phy: phy@4807000 { compatible = "qcom,sm6125-qmp-ufs-phy"; reg = <0x04807000 0xdb8>; - clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_MEM_CLKREF_CLK>; clock-names = "ref", - "ref_aux"; + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Mon Dec 18 12:07:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8285DC35274 for ; Mon, 18 Dec 2023 12:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TeNbtVpTzB03Q6/WhnCUvLO7dmWGLD8OlGmJtFp+GIs=; b=j15zvbOTN3tSmd gM1e0XD6cknOos8MG5IgW9Jt6h5Qkq799PElM4Y6ElqB6fWa8z5OMl/iS0TiR7E93oxYgsU9o0HVP bi+6++MlrirURdV8D5tawcJR6WgSc5un7IjTA5Ehs/eE2hIEUADHFm0y7X62uIrXYMB/a5N4f8BZC 3vz0qbnlZboNfXvJ2ZU1eawCO3dlnjLu+CFxkX4BvTL7y5Rc+H9KEpbjthVN2EZKNAvvI+N0udM0y FAK6CiB1J655+zsMYi5Vjb5GFBscx8+7pPt/L6WSqtHNRl++PhO8HJpBFW2yn/ifODjf/xEi+9tpf PIBK1CtZawfzs/LacsrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQ8-00AYWb-0q; Mon, 18 Dec 2023 12:08:28 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQ5-00AYVk-29 for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:08:26 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1d39afa1eecso15674615ad.2 for ; Mon, 18 Dec 2023 04:08:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901305; x=1703506105; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h2DCBxer6HmgtNkGKJ5qBuor3JmQBFkVeksd4AY7uXs=; b=J4p04+T+Qfz1Vnc7xXXnFKQf/7aQUtRuRZU5zG3zb7MdkGUESItsz7AAvtAhOKCfmi VmSJSaun2fIe3WHlLmSpHtgjA78bRChv7loaKSdCR2IlmqULaJMlVLbEXhVFVlcRBrBf E1YhEdVzcZAKzCvRySvYQpbHxoaLxOf+jKpLMOJIzv/64BhIbiFt4IJmMkTO5qWmf/Uw kFTTo9BAI3HrSNDZzQKIvULQfny6IvVcJlGG6LUTjadHfIFKZj7dxppwkq53VWLfvsuD 3Ow+eRmOuMhGVr3qUsyjXR3D6IrIgafejkj7doQQqxIGpm3jdxE7WbkyFX2spYfnHtm2 V8qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901305; x=1703506105; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h2DCBxer6HmgtNkGKJ5qBuor3JmQBFkVeksd4AY7uXs=; b=h2jtUqqyVVr7X83km4JKwMZhLcDmOk2jyiqiSSjnBYK6X0uubgBuGOeJPG9YCNFOEG q5XEhDzsVAC7lGJd5deZdEiLBgwKdTBGlxljQtyS8bUw6osK/UUnZEfTXZZwmvCnRgEL oCIbE8my2kPLpxA0cahGaSUUb3jrww4+oOiESpG0zutKrmDxerSVbCRe2OA7PD/PJwHM jEJyJv6wnNMnXzA+Y/bgCsgY8u8XTVes2omYBqldHy1sZielpnNR7HOo99SDKl1+SXXN dsa1Dr4PGfS6T/bgk/EAguLA425IkMEhnvvgfJG0KJQomGIK/Pmpkt45SHt5G+sUks6f Opdw== X-Gm-Message-State: AOJu0YzAMpUAR5WfUZwHKrINoxcfadylYbBk7zVgvnAbzBmqoJoBxnZy teijoxZd7gscv88fIHkU9hL/ X-Google-Smtp-Source: AGHT+IG/sSV0F3DjhxgA0eUfeqM6bud3z5a+Hp9pLUdJQxo2YI68XJottXg0G9ttIG4LWYgUbeE6cw== X-Received: by 2002:a17:903:189:b0:1cf:d644:f3ad with SMTP id z9-20020a170903018900b001cfd644f3admr20702728plg.3.1702901305096; Mon, 18 Dec 2023 04:08:25 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:08:24 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 10/16] arm64: dts: qcom: sm6350: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:06 +0530 Message-Id: <20231218120712.16438-11-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040825_705606_17506E20 X-CRM114-Status: UNSURE ( 8.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM6350 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC While at it, let's move 'clocks' property before 'clock-names' to match the style used commonly. Fixes: 5a814af5fc22 ("arm64: dts: qcom: sm6350: Add UFS nodes") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi index 8fd6f4d03490..ef793d48316d 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -1192,10 +1192,12 @@ ufs_mem_phy: phy@1d87000 { #size-cells = <2>; ranges; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_MEM_CLKREF_CLK>; clock-names = "ref", - "ref_aux"; - clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Mon Dec 18 12:07:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496785 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C99EC35274 for ; Mon, 18 Dec 2023 12:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZhznTXFwkV095RjZ5a3P78PKdHTDR5FKMdBXVw5aCnw=; b=bwY1nJiIk76JwB tV/XzpN9+5psCf80IHRtPoyye8jYACrHwEuQLwAcaINFMa+RZAG61UbWAJZLXJEGzH47dDBX9W1u6 KHv15i7xh05gIchBumgKp4+jtbxP+OYPO9pbHVVZIgZZKgbu3qA20ivV9IehrpJP3liWDc0v+rmnU i2E7cigNyUvD1z92qdwNLv9oE7Rt7fL33Qixjah6TFfybReGfhyhnvsLGQ9aQPmhuIxkt+3Xz9GpI JE6Gk/CqgDjwlcgfr+trdZka+wf4KCaZPrkqIceIlT1xgYC+xX6tqKyPtjSNK1xu7EbhrVz9ZW/pl Og8M0ML43CKUpxxvz4fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQE-00AYZA-2S; Mon, 18 Dec 2023 12:08:34 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQB-00AYY1-2W for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:08:33 +0000 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-5c66bbb3d77so1107136a12.0 for ; Mon, 18 Dec 2023 04:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901311; x=1703506111; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+NpBpw87ancReoayxiYNLEpdh+qbLyvkQJUBfcAOaoQ=; b=gh0qiVsPjqrw+/pIhFaQCdNfrpjtAXGPnjj6Gc+rxX8ss1aUvLB6cCsQXZnqXk1Sov A3K4g+DNrGmzEGFGyJdL9m01SjIL7rg9eRph0lVKjoYtt8QXte35SLN6p40h0G2tFG+K jlqB5J6j9dGmn9529t8FrBGlLTe6HXchLiJEeeaAtbqRcanTr/jBkbtOy6fOVuOgoOk1 BsyV/LMZ3q4iHF6Qp4hjN/TK9Y60D98ZgZuoNQ2BsqtJX9oIk3vaRBE4q+T7IJbp0MpO FRNODV+T568D1ucM3EujwMRXUzvKoVx8gUm8BxIzlDN+rmrFbWFYTuKNVEu6ySHMzV07 PHog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901311; x=1703506111; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+NpBpw87ancReoayxiYNLEpdh+qbLyvkQJUBfcAOaoQ=; b=LXVK1Wg6Kf54J2Za685Sg00G4rr5oU1MlAUkt/+09kaITCwMl2YTd8wNrZZGnVDyDG bONZT0GfT0/Keij+sgHozqH2TjY4JubU4I+nlqYvxkg9vxDlvZHkXjuz4E/PDrJ1ekkI GH0DjDrZIEv1HCwMEKK1BsKaGlkx00rePFGdolN8DF7WUZg8GbSyAkHQUyFt1F1Dhtbc B/o4JNWBlLqi4mTYWKHJBlybWH7ywHOCnckj4Dbb5tc/RevNi3wMmV4lyxP10E9NwvJd w32vaMXyrxotP9HGXlR3hRw29x4bHeMmTSbkEKPajN2ih1XIawQ3PBlg3By1+j+gIKva F/Dg== X-Gm-Message-State: AOJu0YxKtzFnA+RdSY7z9iz9y8NK3d6h0Wj80gCmTxYcJXsqHIjbVLEg vSYRqaC9jxTWSHzbUzXnsi0N X-Google-Smtp-Source: AGHT+IHWUgQYCUGlqwV406h6zHwdKzU4NG59nQYN4sJQ2Em0W4gzvKZvabKGPJlQn2udUzFH5dAm9g== X-Received: by 2002:a17:903:1106:b0:1d3:aab1:6273 with SMTP id n6-20020a170903110600b001d3aab16273mr870341plh.118.1702901310948; Mon, 18 Dec 2023 04:08:30 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:08:30 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 11/16] arm64: dts: qcom: sm8150: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:07 +0530 Message-Id: <20231218120712.16438-12-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040831_820710_5EEBAC1C X-CRM114-Status: UNSURE ( 8.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM8150 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC While at it, let's move 'clocks' property before 'clock-names' to match the style used commonly. Fixes: 3834a2e92229 ("arm64: dts: qcom: sm8150: Add ufs nodes") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 43d56968a382..18af94852974 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -2065,10 +2065,12 @@ ufs_mem_phy: phy@1d87000 { #address-cells = <2>; #size-cells = <2>; ranges; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_MEM_CLKREF_CLK>; clock-names = "ref", - "ref_aux"; - clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + "ref_aux", + "qref"; power-domains = <&gcc UFS_PHY_GDSC>; From patchwork Mon Dec 18 12:07:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496786 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9120DC46CCD for ; Mon, 18 Dec 2023 12:08:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O2i2En3vWziP0l42oitKQvFZ6KGmnil2kRV5RIh2b1s=; b=xQaRJqBJ0Oxhd+ cKeF3b1fZYTuH9yARnUxHBPI+6Rh4WdN1CY/18Hv7II0uYOVKoCTR1fbwShLe+W5JbdDCHWLEbhGM aNRB9CbpSepbIsf5WiQxPCprI+f9vAc3DqQyuovSLZHEDeMsVcvFiMs+o9P6THoirzZ738BWYBa49 JyBm2BawJkVf5ze3RLU/hgMYdRIdU9zLFX3v4HByHz3ouvK247HaLg2KbviIuBMcDpy9Fcc0c02LE EZA3JVRiJwsSLE0yYUPQizXRXKALV+VVdl6jEtW6ampXqHszOyCpIZlwVGu5cDvClv3SxcOiDeJij VmjuGFX90UUVu2M+FdfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQL-00AYcn-12; Mon, 18 Dec 2023 12:08:41 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQI-00AYab-2X for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:08:40 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1d3ce28ace2so1721055ad.3 for ; Mon, 18 Dec 2023 04:08:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901317; x=1703506117; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gvNQvdCy0O2wlOymvN0iIUEpRjoZ42RcAo4vagPpclg=; b=G4vjTcnfgRNQomSxzX36GJe/qK7An+MuJdl4fxduQc95310yRf3qtIF4cTBOd6hW+W BteZGs+F2F7AGGGuA21ZGYmBp4AqqRfcnRieiYesAH7z5ETsMKYKJcgyInlS2+BboOWt YG6PHLqGzyEXx/ry9YL6VrZzDv5CQoNQrpP+UCvCcF6P8Ar50HvUXk2YzbaLn181vEIW hRLC6J8AarIzYhqcfip+05Da1PdvqnMjGowflttP8Wo0bVXPlLkfzg/syOfAzdcI4+eg RZYGM2XFswNnjky2d1CfHa4B+7ryXlXxiW2Xw+JxAwKYWIwH9y8PUsM6imWbnmH6mbV3 IO4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901317; x=1703506117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gvNQvdCy0O2wlOymvN0iIUEpRjoZ42RcAo4vagPpclg=; b=X2Pn97WUH3nfMjD4cmClxjlrk5tyXE0uS8EKEmNyAQGVjUWCGvU2g2T4nwz7aOWE7z Z6J6G31z/NBy0iQ60L9sWis8XAs56WKgMe3fwmpM4qw6C2Nt4wuOAKxdMwTdoXOuXdOj tNv68Twg5pr9pNmz5Ov4QPg6PyLRS46rstHLilcz2b09GeEpetq0XaEaTAaIpdUmiUTj xLQ66lVAcf0rRlGWpJKV9QtUglcep9Jkua6LNn/Eb9wJRRH0WDO6JpGYHk5/xpauyQdA 1LFAZZ91jwrmesDK/uNaeRaWtXGYQxq2CqFCd+KrYv1si3vEUuBXsAdX//1bIKxgYWdP uQzw== X-Gm-Message-State: AOJu0Yz5Td+kCrvSybgvsIsAeBBJESQfXUSfet+G1tXtyB0Wcg/s+NeX TcPXBDEeSJfi5T+6q6brYoZt X-Google-Smtp-Source: AGHT+IEmFgwhty4eOC1HWIN6R/wmWkUmpHUAMlQfWfME+fkRcMzo7kKJtBRaeLQkaRQozYVIufi4aw== X-Received: by 2002:a17:903:24c:b0:1d0:6ffd:9e1e with SMTP id j12-20020a170903024c00b001d06ffd9e1emr18461127plh.112.1702901316940; Mon, 18 Dec 2023 04:08:36 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:08:36 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 12/16] arm64: dts: qcom: sm8250: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:08 +0530 Message-Id: <20231218120712.16438-13-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040838_830269_9751F49E X-CRM114-Status: UNSURE ( 8.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM8250 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC While at it, let's move 'clocks' property before 'clock-names' to match the style used commonly. Fixes: b7e2fba06622 ("arm64: dts: qcom: sm8250: Add UFS controller and PHY") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index c1b7f9620ec6..e47c515af6cf 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -2486,10 +2486,12 @@ ufs_mem_phy: phy@1d87000 { #address-cells = <2>; #size-cells = <2>; ranges; - clock-names = "ref", - "ref_aux"; clocks = <&rpmhcc RPMH_CXO_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_1X_CLKREF_EN>; + clock-names = "ref", + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Mon Dec 18 12:07:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496787 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C1B3C35274 for ; Mon, 18 Dec 2023 12:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3F8LjyplphwMB2+b0Tp8KT0j9oRP3wErNem1bV0hhaI=; b=oCZGWu+P5wp2An +LKYzFnn1CWUGEFPnOQkiwRuwygbbtEKk7R5qGVMUhri7zgQxuC6hyq+whcaNiJ6tMFmEOZVdzWgT FaHyTO3nAmRfX5x6SO9TcA0hCzyQH3ogcmR5rFtYqUvVKGu/97e/qo6/MT7ZI4PdAD6cuuMI720o2 H2i2yinSKh5ePl06F1EUFx7g/jKayGXe2X6361+7Esw2HlHupIJmkLQHCwWF8ch0dVkFjk2M4wnOp ifMh3hJSmhQa/bCqUkr5T5M/3Cugg6VnmleI9WckgDHz/DIYViD+yCs1+I0NWUr9mUUgR/TTgYJrG qEzdBAGf9wdscEF3i9jA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQT-00AYfN-2i; Mon, 18 Dec 2023 12:08:49 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQR-00AYdN-15 for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:08:48 +0000 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-5c6ce4dffb5so798349a12.0 for ; Mon, 18 Dec 2023 04:08:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901323; x=1703506123; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hkhidzmVun0Q+RVPRPkagjowO4OR2Vwj/TtI5d1pEJU=; b=IWg9Cw+mrMLnyXj73okfL+6cqRCFdwRGzMCF+jqdWnaQBBdv22d99Wpa7DnNOZgpsI IH9C1htQPzVQSmBs4SGZSyvP4znHmlen9YiIoVs22DhoLbQwXLrXyHKV0TgP+lzN3nkU twmlt9V4Lz78ip1IkWUIKCSuHS2PdHCWeFXkLb9nw3FEFjlZivFsse9TdnYWvE5wJ0mm ldzX5z70BpHoevl//teoHK6hLRd1s1kTk1tatOQBv0Ba7V7fWgKZmNUSvMlWzADXT1q4 Y8QQTK75R8pSYqq6WjEF0XOWuzWd7Hw5xCtQ0d6/HiXckAKaZaB2WGAdsZt7v8ASA+GP IGeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901323; x=1703506123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hkhidzmVun0Q+RVPRPkagjowO4OR2Vwj/TtI5d1pEJU=; b=mSsIk6XGIBPgVyHaBVI3qia+UI15l3jDfr7YOJOhZTIKYkQ05ug6fR52ngyQlHnDF7 dUY5Qh+z9yG/dfkt0kD26Tgnc5/jjA4sH5i+s8ij8PtedWTxgjrbySNZeYnH6nwjDA7k w2Bso0O5zH/gATmovaECA6DdSZk0PzmsbavhYqTP8FI1d7ueD8nqP/NaB067E87JTI/h R1duGWBIDIDxVtrCBGgb8uIjkYT2Ly8Q8eXzKLQOEGfNHomRzWnQr6K2Dl5UMuaVb5oM tLXxCDa96+z2ojpD/byRLQU0ADwKkYebbj4RS4+mO6qMpGE2YEHwby9sY3e23OdSUedc jSgQ== X-Gm-Message-State: AOJu0Yz8nXg0Hkfqz1/eVu7jLZdbDF78bll93n30mJs2uAxyOHWHhUSw wq3u8B+WVyI+DlwoVqt0tShm X-Google-Smtp-Source: AGHT+IEFzKmwQ9jijXgAmsmDSBEbNm51X5eQbNutP//715SDDDau68UX4AE2HLchbkXj/fguvb8Jzw== X-Received: by 2002:a17:902:b197:b0:1d0:6ffd:6e66 with SMTP id s23-20020a170902b19700b001d06ffd6e66mr7691134plr.94.1702901322911; Mon, 18 Dec 2023 04:08:42 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:08:42 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 13/16] arm64: dts: qcom: sc8180x: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:09 +0530 Message-Id: <20231218120712.16438-14-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040847_380739_26708E46 X-CRM114-Status: UNSURE ( 8.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SC8180X requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi index 8bcc8c0bb0d0..5591e147bde1 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi @@ -2122,9 +2122,11 @@ ufs_mem_phy: phy-wrapper@1d87000 { reg = <0 0x01d87000 0 0x1000>; clocks = <&rpmhcc RPMH_CXO_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_MEM_CLKREF_EN>; clock-names = "ref", - "ref_aux"; + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Mon Dec 18 12:07:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496788 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BCC7C35274 for ; Mon, 18 Dec 2023 12:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=skbh9IwQxql/Pf3v1EDX2s9yyK00IwaVZmE8Ga7I36s=; b=pSFBcGq293YzRD Fvw2i1/lJeNvi6Vs08+t6C9vvI59VD+nKq+g1clhGJYT5E3G/O7Pcelw8LLlBxm780oleBiltICrh jrbYkxbU5365zEE/fBwWqgV/+qiR8F7KsO/q6sCjGuUMqMIppgNoCteDun+3O7dEYWVHtxQ9VQwhp G+E+lh2muA4ofCLqiBQ++00CwkHm//wwU3r//wfIg0FLaPlu8tZmv3PMBZZejg7JzbG20pJk6BxhQ fRocjQ/wWvuYyoqZ8pakYzlosCH+2P0P49QPBqr0wnbuvOk8DiOArIreDHQ40bM/UW94nHhspxGx8 16u/PW4xOR7PVniveW/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQX-00AYgs-0i; Mon, 18 Dec 2023 12:08:53 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQU-00AYf2-1p for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:08:51 +0000 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1d39afa1eecso15677995ad.2 for ; Mon, 18 Dec 2023 04:08:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901328; x=1703506128; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RTvHTb3eBsG5jFvbdhGh0zasO09G1PrRZVvH3m7yDqQ=; b=VQXgHP1qACnLfxYLBzbgBSE63IRJ3SsK5iRWv7m463UBLMC5XWmvzj1PeueUmZhfUv x47tBWKKSslFBzreSC3jAIFr39cC7ua/CN9sIgYj//h3UhucD43ReqzoXQT90cctOwMZ jBzqINhlJDhBe90s5lfKSBUESgBUnDQrDRmvkLaoReOjNCVKh/qdvXaiZf7CzuCv5bWh 7I2o/RnOHq28UsTsBeMwdrUGq0pNWGl1O1Msx5BZXmZEXJ+c9orguIC0a5D0l0Dby2tk 6dEwxmb2bNMFDUJzxrfJ0egE9URHcE2bLSHXM9OaW25aVdhNl/bKEQfeVBuy99xj1dKw mF0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901328; x=1703506128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RTvHTb3eBsG5jFvbdhGh0zasO09G1PrRZVvH3m7yDqQ=; b=tzsnYyJ7LlCLCyvglA7VIVIJdgU1QtTrZIdQrcRnEY4Kpmjw3aJAyXpHc4OkLCyJ7B sBkEvnFbQ5cvgcDPmJJvFTSgRzoyjJITiiDWbC7aWl9UfBM9JTJIgJWqMyek4mVSZZjN AAOfxsWDKqJe/dzghQnb0NxNX5FYiP1mZ/P5G1X655diRRZBqxz0nT/zYGmTYf13cBW0 ei5oqyfhvW5BhM/xehmO9TYReXz3NXcviAx/0NWm0RR7AxZUHn5FeLrz5IumjiPoaC4g Uk0yiowCzB4uG44kA9PeCOEiy5HcSrf3KeoGtOQb9XWK+DfNAvJbdLItVNZMnThsx++u wG4Q== X-Gm-Message-State: AOJu0YyrLi6poF02iUu/KKPwUxzq5693/iZI0cQODAkEhCxpidu/MppP 63Xrf+5gntJQGJx6/YgEfW2c X-Google-Smtp-Source: AGHT+IHfpzfQ7Ho4J5k5zn3DQtdaxoP2BboWND0BEobz+wq9+jlz0BY2a2FXfVNGhh1hdWdcLpfjzg== X-Received: by 2002:a17:902:ce8c:b0:1d0:9228:575e with SMTP id f12-20020a170902ce8c00b001d09228575emr19580256plg.43.1702901328528; Mon, 18 Dec 2023 04:08:48 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:08:48 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 14/16] arm64: dts: qcom: sc8280xp: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:10 +0530 Message-Id: <20231218120712.16438-15-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040850_601974_52E441ED X-CRM114-Status: UNSURE ( 7.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SC8280XP requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index cad59af7ccef..37344abbe8bf 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -2256,9 +2256,12 @@ ufs_mem_phy: phy@1d87000 { compatible = "qcom,sc8280xp-qmp-ufs-phy"; reg = <0 0x01d87000 0 0x1000>; - clocks = <&gcc GCC_UFS_CARD_CLKREF_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; - clock-names = "ref", "ref_aux"; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_CARD_CLKREF_CLK>; + clock-names = "ref", + "ref_aux", + "qref"; power-domains = <&gcc UFS_PHY_GDSC>; @@ -2318,9 +2321,12 @@ ufs_card_phy: phy@1da7000 { compatible = "qcom,sc8280xp-qmp-ufs-phy"; reg = <0 0x01da7000 0 0x1000>; - clocks = <&gcc GCC_UFS_1_CARD_CLKREF_CLK>, - <&gcc GCC_UFS_CARD_PHY_AUX_CLK>; - clock-names = "ref", "ref_aux"; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_CARD_PHY_AUX_CLK>, + <&gcc GCC_UFS_1_CARD_CLKREF_CLK>; + clock-names = "ref", + "ref_aux", + "qref"; power-domains = <&gcc UFS_CARD_GDSC>; From patchwork Mon Dec 18 12:07:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2B7BC35274 for ; Mon, 18 Dec 2023 12:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OeoRYS1E53TgD+rg2giuX5TdTnQN9w4HUk06mU6EGaw=; b=1g03d0CU3rduui bTIFnvDHRvPathiAqAVzg7vyUcjUi5JwfmKTJwD+B7hYjYnFPCudCHw+U0jiqQHBL8YzsH6LGC1jT nMHbOtaqFRAn/cXpXfXApVMRFf0Alwkacp5/RxDQ8aSpFTRyqSwB2ix7SEvjbEUqUKY74MjU2l4vY P62atkeQea1ULOtK3nRN/eJQwziYx31zi1fpQ2o9tggPSXRHU4ZnCoRktHpIRx6QikDO5BZgrvVbF 0ieE8lF7LSVIWUyF+4Bvq4Ez0YQtdrRpRHZcQraj0GoYhmmllWXsabt+NWTQo2t/Dh48Z79PT2Qvx /y1iiB02H0Xqr+5fyDoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQc-00AYit-2B; Mon, 18 Dec 2023 12:08:58 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQa-00AYhg-1A for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:08:57 +0000 Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-5c229dabbb6so1020340a12.0 for ; Mon, 18 Dec 2023 04:08:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901334; x=1703506134; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dnV4bcTFVg58y8kcgwcwL2c2t/omr5+/badatgzAJ70=; b=fHf1Dpi/6zgelQotFIad8mvWfXLg7npNhc68JYBF7snEC1zOcKRokFIUc4wTfsyRej kuNi6Lp2meMA+8pKrPEXvZozkZIqn3QrERvhGYSoIogjI3vHpFWaTKdOT1QRyu21QbdQ P/Kfe315YK4KuT+1/NcXpii9uNlKjaBUv30C2LR44QCUEhTb3aawT/kGB6jUPJE3BNZD 2EV5qdkjXqY3IQL3tQa1rOlMM9lrAaiZys4y10slHvapJDxnpJH1ynrN8PT5gkP/gAGW qAhAXAxPiO7sEek0GsllYlW1ROQ05GTeqbf8t5YDtNlBl84bOvKXZP1EwlH61RUtG4gx sY8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901334; x=1703506134; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dnV4bcTFVg58y8kcgwcwL2c2t/omr5+/badatgzAJ70=; b=V8Nqrv/MwxNiO8QhAb3Em+30mf5nN/qx1rneIJwiCu2DprbuGrYIXMJ8Ro8gBX9yPb AB0CqDqoS6702OwawMJ2NQlrVNfGFSWZfTb7ChGPvX+rNN1J9GdO4Hr5NUISP2h2TCHW m+QukPcCmYoFeLBRprDDZc0BWBywLTH6l5pjAyDe44cJ6lSDPkq6xDkMmbopjNpyq6M0 JRzm29YnfbscDo+AmkVDlXFg5SJSHgK+el98rmL+5prMAK8HfrdNN5w7pymlSfHzvKJj NYFU3JW+UUvoBIiEGFbZHY8bY/wTdcVS6sRSifBSy1wcTQ+XgL4jDlE5XSoKTTbwhRWg fF/Q== X-Gm-Message-State: AOJu0YypQmdCOsrMEbJmAG0lSjppeWvAk2V+Vwr4OjcHikCbg4Zrz0IP GkAGXnknlWp38aiNLhZ5XqO2 X-Google-Smtp-Source: AGHT+IHuv5DOigTJpGQgYUD2uD4WFD1pDTqLP86zuwQpiBhfnEWtjDbqCvw3kbTgKREgnnrh11wFeg== X-Received: by 2002:a05:6a20:5603:b0:18f:97c:ba1d with SMTP id ir3-20020a056a20560300b0018f097cba1dmr7867193pzc.119.1702901334495; Mon, 18 Dec 2023 04:08:54 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:08:54 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 15/16] arm64: dts: qcom: sm8350: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:11 +0530 Message-Id: <20231218120712.16438-16-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040856_395880_26DB1F01 X-CRM114-Status: UNSURE ( 8.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM8350 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from GCC While at it, let's move 'clocks' property before 'clock-names' to match the style used commonly. Fixes: 59c7cf814783 ("arm64: dts: qcom: sm8350: Add UFS nodes") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index f4b8439200f5..38a09d71b3e9 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1727,10 +1727,12 @@ ufs_mem_phy: phy@1d87000 { #address-cells = <2>; #size-cells = <2>; ranges; - clock-names = "ref", - "ref_aux"; clocks = <&rpmhcc RPMH_CXO_CLK>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&gcc GCC_UFS_1_CLKREF_EN>; + clock-names = "ref", + "ref_aux", + "qref"; resets = <&ufs_mem_hc 0>; reset-names = "ufsphy"; From patchwork Mon Dec 18 12:07:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13496790 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5ABF9C35274 for ; Mon, 18 Dec 2023 12:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3tP/nZqfnCMhBDjckqV7U6VlnELeZN8+Fhv6BujXXj0=; b=j+JiS/xqfIVPKq 8lq58RdcOS7iPSF9liQ0OqyKuoLo31eAeR/SSx9P2wKXiMxp8yQNdA6T2OeJgkziVp8eZ12f6cCpl ZA4r2280EZehatimmx9iErPdGn/xm042wWjwCQaIPNtjyX9e3BHtZv+coqxq+RxMHYCPoI6eiGB0k 7Kndc4/NfAEH3UJ8eetZoYQyjUWYYetLzrNf7aSrstG29uqud5qT4BKUU/VqQm6WncnSx/nKLlEul gSOIl1NGZ1uC3hlmZdNck10+LRbC5XoaVG0b+BfJxudwpIpjnfWg4OhISgBlXUFAquD8kTvwnfKgF 7Z1UrAMM9r7nxFcy0gWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQi-00AYkU-0N; Mon, 18 Dec 2023 12:09:04 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFCQe-00AYjN-2s for linux-phy@lists.infradead.org; Mon, 18 Dec 2023 12:09:02 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1d3aa0321b5so11010135ad.2 for ; Mon, 18 Dec 2023 04:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702901340; x=1703506140; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=90h9raFSlwYqtZtEwRi3utD1Y8btrpvvb6rt2ijbFWY=; b=tybZ9flqssw4RI9y8kPyfgiTyoXXliafPwV+CVDO4m8aM/06cw9fTk2aHuiaoxEDCz q8ZjTn08AVEh1sZZ4SpmEuzSPHF6TyWgtRgS/cYkH6RLS2NuVtobZDH+gBNuBjL4ixkU SGma2nxHjPVxIZndgewitHzKvD/PL3F5Vz/gsPxjK8uK9eLjFHkHMXZRiSw3jOsxLA5b babXqXrNmQqyPeeZ7VySIxZq2lNwNI6rNgMsX0L/qjFfLnunR8HspAIaRt/9fwRJjeyy NTTMRwAbap+66dpJVcDatltRi3hbIHC9vzUpoGaUp5haXdc5anPRzF3+SEC/qbo3mYHP mg0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702901340; x=1703506140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=90h9raFSlwYqtZtEwRi3utD1Y8btrpvvb6rt2ijbFWY=; b=jcmgPBqAcYI5ckZxi7pSi5tqx4awWGIQ79W4Emst9zPklS1aZyLtJ5OrXh7K8PW2u/ 7j9CxxBHq/A8PhRp7y4cD5GuDfqOeF2GIwIrpKRa7mPfXSES9bnzqmrBnhrdQ4pwf7sR l01xXXBB49DsMMXDvSOzTcI8tp3BFDNLpJhgeSo+XUglBqvjGKyPmDRAEE9LAcEjPm5z Au6dS2RmpyMcBFhyIjhtQOtkktxqiT/YwHeBownYtpCoKQsyoCxZ176j/ndeVOYLIn4l JCmVA6OzBLdKQ+w2i8iAiHB2KhzuM9m9w/YX6zMJXeXmnN49x8h94Kr9a4688v1naixE 08ZA== X-Gm-Message-State: AOJu0YzCDDbdV9tbLT4+VHNyzKylc6ama6snTxR5rgVXZ1c9e/CxkFQv jmyjhAdR4IoHCld4ouYFRLZE X-Google-Smtp-Source: AGHT+IH6YQIoz7g6eSuI6OBkFycERp/zo6TTsmB3JpzQ5Mkr+OSBAEVaXvjIhrOv9oP9NCPayYUGgA== X-Received: by 2002:a17:903:2292:b0:1d0:92a0:4929 with SMTP id b18-20020a170903229200b001d092a04929mr21153502plh.85.1702901340343; Mon, 18 Dec 2023 04:09:00 -0800 (PST) Received: from localhost.localdomain ([117.207.27.21]) by smtp.gmail.com with ESMTPSA id j18-20020a170902c3d200b001d368c778dasm1285709plj.235.2023.12.18.04.08.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 04:09:00 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, quic_cang@quicinc.com, Manivannan Sadhasivam Subject: [PATCH v2 16/16] arm64: dts: qcom: sm8550: Fix UFS PHY clocks Date: Mon, 18 Dec 2023 17:37:12 +0530 Message-Id: <20231218120712.16438-17-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> References: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_040900_930594_A938765D X-CRM114-Status: UNSURE ( 8.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QMP PHY used in SM8550 requires 3 clocks: * ref - 19.2MHz reference clock from RPMh * ref_aux - Auxiliary reference clock from GCC * qref - QREF clock from TCSR Fixes: 35cf1aaab169 ("arm64: dts: qcom: sm8550: Add UFS host controller and phy nodes") Signed-off-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio Reviewed-by: Can Guo --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index baa8540868a4..386ffd0d72c4 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -1891,9 +1891,12 @@ crypto: crypto@1dfa000 { ufs_mem_phy: phy@1d80000 { compatible = "qcom,sm8550-qmp-ufs-phy"; reg = <0x0 0x01d80000 0x0 0x2000>; - clocks = <&tcsr TCSR_UFS_CLKREF_EN>, - <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; - clock-names = "ref", "ref_aux"; + clocks = <&rpmhcc RPMH_CXO_CLK>, + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, + <&tcsr TCSR_UFS_CLKREF_EN>; + clock-names = "ref", + "ref_aux", + "qref"; power-domains = <&gcc UFS_MEM_PHY_GDSC>;