From patchwork Sun Dec 31 18:34:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507296 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1976E8F74 for ; Sun, 31 Dec 2023 18:35:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hOoMo8OB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D9C2C433C9; Sun, 31 Dec 2023 18:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047723; bh=V9EzQJL3jNrtFJInUWiTGBP8hPvQMGNcWvChWubTNXg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hOoMo8OB7BShA+uvLjv7+GcN3Esw6hPtaQSdiUIpaV8Ahs1O4GPLKmRPIt9J0BV/8 +2BuBHIgP5qEcSLXS4eMI0EJf1GI1vi3A6bJLJSvLKDZPGPrPQ9xhmTwp0Rqdlah68 vMDg00oaEJshHeDXDDvnWXhXjE5/CzfGb5p9WBsBesfiUuKRhLL/1GqEonwtxt0bHY zsi1D9vfMK+MGGclqKHFrLLf1rJKartXgessiJhT2VXjbB/aVV6jUfU3amWcPgoJSK awfghOCfmsavnGGd4qjX9Ut6ENZnHCh5ahVFJYn2e31cQKfyppT+5PCdJfmQvCKJzL sixdWex1B14DQ== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron , kernel test robot , Hans de Goede Subject: [PATCH 01/24] iio: accel: da280: Stop using ACPI_PTR() Date: Sun, 31 Dec 2023 18:34:51 +0000 Message-ID: <20231231183514.566609-2-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron In general using ACPI_PTR() leads to more fragile code for a very minor saving in storage in the case of !CONFIG_ACPI so in IIO we prefer not to use it if the only ACPI specific code is the acpi_device_id table. In this case will also suppress a unused variable warning. Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202302142222.vVU0E4eu-lkp@intel.com/ Signed-off-by: Jonathan Cameron Cc: Hans de Goede Reviewed-by: Hans de Goede --- drivers/iio/accel/da280.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/accel/da280.c b/drivers/iio/accel/da280.c index 572bfe9694b0..d792d2d20344 100644 --- a/drivers/iio/accel/da280.c +++ b/drivers/iio/accel/da280.c @@ -186,7 +186,7 @@ MODULE_DEVICE_TABLE(i2c, da280_i2c_id); static struct i2c_driver da280_driver = { .driver = { .name = "da280", - .acpi_match_table = ACPI_PTR(da280_acpi_match), + .acpi_match_table = da280_acpi_match, .pm = pm_sleep_ptr(&da280_pm_ops), }, .probe = da280_probe, From patchwork Sun Dec 31 18:34:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507297 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA47E944D for ; Sun, 31 Dec 2023 18:35:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aH8vLqph" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1002CC433C8; Sun, 31 Dec 2023 18:35:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047725; bh=XssyMWi+Rf4taKkSYeRbmsKuH49r35AwXsSxnagho28=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aH8vLqph0wXWLvuyxY32+HNUBDBg++hFE9YAgG0k+32ZRXAfzxsAsV78FqXZXP+Ip 6K17bQNbHss9v4/EUUadnrzbFKI70Q9QT7lyEd+Ou/GHIdESfMAMivGDYPJ6MnKTyu F4IDdlJdLfvT8Cs+BLNEemRDnTar+hRkKePComUS2qTnnl/M14JVsG1leHOf+78blL xYUNLrJu5HeJ/OHHgHO2rl2tQFRrN7RZ2vVFi/TLtgkNxY13wKS7Lultsx/Ti+mWrM Jk3B8c98S4N+DTNtn1KTnbvz57AZk32rd8gkIPZzHjXO2op7Gmjwy0mRh+5S3jjkID UVn2Rpc5frwuw== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron , Hans de Goede Subject: [PATCH 02/24] iio: accel: kxcjk-1013: Move acpi_device_id table under ifdef CONFIG_ACPI Date: Sun, 31 Dec 2023 18:34:52 +0000 Message-ID: <20231231183514.566609-3-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron This avoids a build warning due to the use of ACPI_PTR(). Given the driver already has APCI specific code under CONFIG_ACPI move the table rather than removing the ACPI_PTR() call as we already have the complexity of CONFIG_ACPI. Signed-off-by: Jonathan Cameron Cc: Hans de Goede Reviewed-by: Hans de Goede --- drivers/iio/accel/kxcjk-1013.c | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c index 894709286b0c..7f084f73da84 100644 --- a/drivers/iio/accel/kxcjk-1013.c +++ b/drivers/iio/accel/kxcjk-1013.c @@ -422,6 +422,23 @@ static int kiox010a_dsm(struct device *dev, int fn_index) ACPI_FREE(obj); return 0; } + +static const struct acpi_device_id kx_acpi_match[] = { + {"KXCJ1013", KXCJK1013}, + {"KXCJ1008", KXCJ91008}, + {"KXCJ9000", KXCJ91008}, + {"KIOX0008", KXCJ91008}, + {"KIOX0009", KXTJ21009}, + {"KIOX000A", KXCJ91008}, + {"KIOX010A", KXCJ91008}, /* KXCJ91008 in the display of a yoga 2-in-1 */ + {"KIOX020A", KXCJ91008}, /* KXCJ91008 in the base of a yoga 2-in-1 */ + {"KXTJ1009", KXTJ21009}, + {"KXJ2109", KXTJ21009}, + {"SMO8500", KXCJ91008}, + { }, +}; +MODULE_DEVICE_TABLE(acpi, kx_acpi_match); + #endif static int kxcjk1013_set_mode(struct kxcjk1013_data *data, @@ -1687,22 +1704,6 @@ static const struct dev_pm_ops kxcjk1013_pm_ops = { kxcjk1013_runtime_resume, NULL) }; -static const struct acpi_device_id kx_acpi_match[] = { - {"KXCJ1013", KXCJK1013}, - {"KXCJ1008", KXCJ91008}, - {"KXCJ9000", KXCJ91008}, - {"KIOX0008", KXCJ91008}, - {"KIOX0009", KXTJ21009}, - {"KIOX000A", KXCJ91008}, - {"KIOX010A", KXCJ91008}, /* KXCJ91008 in the display of a yoga 2-in-1 */ - {"KIOX020A", KXCJ91008}, /* KXCJ91008 in the base of a yoga 2-in-1 */ - {"KXTJ1009", KXTJ21009}, - {"KXJ2109", KXTJ21009}, - {"SMO8500", KXCJ91008}, - { }, -}; -MODULE_DEVICE_TABLE(acpi, kx_acpi_match); - static const struct i2c_device_id kxcjk1013_id[] = { {"kxcjk1013", KXCJK1013}, {"kxcj91008", KXCJ91008}, From patchwork Sun Dec 31 18:34:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507298 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60324944D for ; Sun, 31 Dec 2023 18:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OSJ/nJ72" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4E75C433C9; Sun, 31 Dec 2023 18:35:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047726; bh=5DipDRJ9SjxNVEu8yeOLsiEkzWBhgemvmWE2TkWJW2U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OSJ/nJ72d+7Wp540wXYSBRa93Suw5EKBFKaY71Ov/eoslzQIVwjO4ntV1XCtsNJ2c zUDurevCZJ9NNsAZphHWjPNsqiAHha8tDN/Y31xn/ikzpNytQy74tz/TpiKm5wfqHM qVCJlqxVo9e8d020lAK7pUPTRO25TB+7gj9w1VHrKHWtiqtwYYCYkKmOQyOnNA3547 SjWzhvHysu0Ouv1JLLg5fAP4cXQq2cUvXITeNMlcfVWQx/hWkkUXWLdhALE7JkN3In JkDH8OFg5tisHfI4VlQdAFuUm4UA7yAUdOseh3+8CWuUS46Z6166fgdonkkMvu5FaZ e0JvY22fCyR5Q== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 03/24] iio: accel: mma9551: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:34:53 +0000 Message-ID: <20231231183514.566609-4-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Whilst here tidy up a trivial bit of unusual indentation. Signed-off-by: Jonathan Cameron --- drivers/iio/accel/mma9551.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c index d823f2edc6d4..083c08f65baf 100644 --- a/drivers/iio/accel/mma9551.c +++ b/drivers/iio/accel/mma9551.c @@ -604,9 +604,9 @@ MODULE_DEVICE_TABLE(i2c, mma9551_id); static struct i2c_driver mma9551_driver = { .driver = { .name = MMA9551_DRV_NAME, - .acpi_match_table = ACPI_PTR(mma9551_acpi_match), + .acpi_match_table = mma9551_acpi_match, .pm = pm_ptr(&mma9551_pm_ops), - }, + }, .probe = mma9551_probe, .remove = mma9551_remove, .id_table = mma9551_id, From patchwork Sun Dec 31 18:34:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507299 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE2DF944D for ; Sun, 31 Dec 2023 18:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sXaGfS9X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53DA7C433C7; Sun, 31 Dec 2023 18:35:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047728; bh=Y9YWQi2G0k8si42KNs+Kt8en+QdNvjfhjI67g/YvgAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sXaGfS9X9700chXVzhZqySeFCuKh4dg0n491ZqpfdruYK92PHpd0GQ9utvMGLPALx wbOy1sru8DSHv76ddz0OV5QUxj3Rwu+CWWBETIjZh4CqdwqpNKoV1lbeBK+SxN+8Yi LnTzKQfCRTVaWbDHTqs6zNyJS0KddMig7CMGbfu0U5efyhJf0e5yFmVOzDPiq0qrpF 3MEJ6yXgMAyLo8zbjtadqxf8KW7a4FMZ/WQrDBwD3q+ZRdK43FJvH1Y7xYa0cKhznZ Rbaabp7KgOH/iFRuudI3xBezByfDj8f80oms8gjZbUSHYeulJhTj0ZrPdaFFCz/elK 9cTp4i0ZF9/5g== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 04/24] iio: accel: mma9553: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:34:54 +0000 Message-ID: <20231231183514.566609-5-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Whilst here tidy up a trivial bit of unusual indentation. Signed-off-by: Jonathan Cameron --- drivers/iio/accel/mma9553.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c index d01aba4aecba..3cbd0fd4e624 100644 --- a/drivers/iio/accel/mma9553.c +++ b/drivers/iio/accel/mma9553.c @@ -1243,9 +1243,9 @@ MODULE_DEVICE_TABLE(i2c, mma9553_id); static struct i2c_driver mma9553_driver = { .driver = { .name = MMA9553_DRV_NAME, - .acpi_match_table = ACPI_PTR(mma9553_acpi_match), + .acpi_match_table = mma9553_acpi_match, .pm = pm_ptr(&mma9553_pm_ops), - }, + }, .probe = mma9553_probe, .remove = mma9553_remove, .id_table = mma9553_id, From patchwork Sun Dec 31 18:34:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507300 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40C568F74 for ; Sun, 31 Dec 2023 18:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zdbg8uaW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE773C433C9; Sun, 31 Dec 2023 18:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047729; bh=456AjWXLRjGpH4Z80fUU/qpPxrTXGxIFTQemgQjxU2U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zdbg8uaWFNq8IESP0VCl/VWvrsAmpAypSN+L355KPpU2Y7/8XdMnqf0vQamqwWp8X jmFiRiCO7ChpMaCoJD1W98D0LOoFWOXSYnCNhyMC/j0DCQJlsKwFxILf3WZJQRHJyk LLjnYe1rnxGMbsVAwJAefXnR2mvO/Ru9/1AxkbGTT0f9a31X/ubzQOSN9S6YDGdYv4 f/W+M9pG1sBLJJHycVaoCmuwSP8KrX8TXrJvOdzfRv0ULFXKL5yHp8rEdhb/3mqca1 5BkpjE8Uel1HS5GYHAnU68m0POddr+ZoeIr4p/r6dkJCU/K9IhW8XZuNGiC/AtAAki 0H/MfZtap/VfA== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron , kernel test robot Subject: [PATCH 05/24] iio: accel: mxc4005: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:34:55 +0000 Message-ID: <20231231183514.566609-6-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Switch include to mod_devicetable.h as that contains the only acpi specific definitions needed in this driver. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311181952.1usxCcup-lkp@intel.com/ Signed-off-by: Jonathan Cameron --- drivers/iio/accel/mxc4005.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c index 82e8d0b39049..8118cc13614a 100644 --- a/drivers/iio/accel/mxc4005.c +++ b/drivers/iio/accel/mxc4005.c @@ -8,7 +8,7 @@ #include #include #include -#include +#include #include #include #include @@ -493,7 +493,7 @@ MODULE_DEVICE_TABLE(i2c, mxc4005_id); static struct i2c_driver mxc4005_driver = { .driver = { .name = MXC4005_DRV_NAME, - .acpi_match_table = ACPI_PTR(mxc4005_acpi_match), + .acpi_match_table = mxc4005_acpi_match, .of_match_table = mxc4005_of_match, }, .probe = mxc4005_probe, From patchwork Sun Dec 31 18:34:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507301 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AF2E63B9 for ; Sun, 31 Dec 2023 18:35:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e/eFhfKq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E54DC433C7; Sun, 31 Dec 2023 18:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047732; bh=NcYuJqGkvepwidYq1uxd1HYYL1S8OOKNcD4Mn3XYMAk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e/eFhfKqeeYpSKDL3nEPf4q3OfzE7ddjlGLxfc9dpDxWTcX7+9YFn2M6ObLcPXUGO zzqgJ0p4QaMDC2gM6OqMeoxtF5f7h1cg6cukNKwa/8u24u3mccPOiAHCiznhpMtgwE ssbIw0gJQvmvEjYnYUpp730NrhIr/M7Epky+ZEp+tT+yxLafZbB6HwhG8w82z2b7Cp BFnGn59Jrx8AlpGaSc1idpnGqV5qVwZ7ftsFRaQoHAz6Vz/Lt+NIfHKPeAzTSMVr37 mWOrLEXhW7Z/SozZHzVLwMmWzuyxPkVwVfhSg5MnYWt6VsE8dC/aD+66HLuWA+fxa3 UwvTjN29lmJxQ== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron , kernel test robot Subject: [PATCH 06/24] iio: accel: mxc6255: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:34:56 +0000 Message-ID: <20231231183514.566609-7-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Switch include to mod_devicetable.h as that contains the only acpi specific definitions needed in this driver. Reported-by: kernel test robot Signed-off-by: Jonathan Cameron --- I can only find this one reported in a much larger build report (where it was noise) so no obvious closes tag to use. --- drivers/iio/accel/mxc6255.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/mxc6255.c b/drivers/iio/accel/mxc6255.c index 33c2253561e6..ac228128c4f9 100644 --- a/drivers/iio/accel/mxc6255.c +++ b/drivers/iio/accel/mxc6255.c @@ -12,7 +12,7 @@ #include #include #include -#include +#include #include #include @@ -181,7 +181,7 @@ MODULE_DEVICE_TABLE(i2c, mxc6255_id); static struct i2c_driver mxc6255_driver = { .driver = { .name = MXC6255_DRV_NAME, - .acpi_match_table = ACPI_PTR(mxc6255_acpi_match), + .acpi_match_table = mxc6255_acpi_match, }, .probe = mxc6255_probe, .id_table = mxc6255_id, From patchwork Sun Dec 31 18:34:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507302 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E05DB944D for ; Sun, 31 Dec 2023 18:35:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B/UsHDp2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC14FC433C7; Sun, 31 Dec 2023 18:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047733; bh=91/2rhnDMxfUbkLeoZq4Ko/Q2Z0itmXUS0QXoJH51mk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B/UsHDp2+j0sPSbMiXSYyOTTcHdAkVsmeJGprbwbpeWw7ArL1szGm4/G/pOxSaiHn dvzQV5DMkkkpaoTwdabh2MQLi+fyXuNev/6Rv15Yh/dmk3WKlQXc1xuXUwFEPRfcIS DJJU+xMg6/0jcEwXMExNVsnXdvmUHKRWMQwTtSmN+FXqE03revAkoi9JHivPGGKJyn WP81WcGJtR7EKdl2S/81Dc4WXFsaRPrH6XPsFBd0L2GH4CoFv5OxVVvMh06Tx/h3dR OSdVxPTX0kFTS61mOipFa1BZxxTb4xDynHzYj146mhBeooOgwj2fTsrdpgVfTQAtLc x7tj2P16bxPkQ== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 07/24] iio: accel: stk8ba50: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:34:57 +0000 Message-ID: <20231231183514.566609-8-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Switch include to mod_devicetable.h as that contains the only acpi specific definitions needed in this driver. Signed-off-by: Jonathan Cameron --- drivers/iio/accel/stk8ba50.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/stk8ba50.c b/drivers/iio/accel/stk8ba50.c index 3415ac1b4495..668edc88c89d 100644 --- a/drivers/iio/accel/stk8ba50.c +++ b/drivers/iio/accel/stk8ba50.c @@ -7,11 +7,11 @@ * STK8BA50 7-bit I2C address: 0x18. */ -#include #include #include #include #include +#include #include #include #include @@ -541,7 +541,7 @@ static struct i2c_driver stk8ba50_driver = { .driver = { .name = "stk8ba50", .pm = pm_sleep_ptr(&stk8ba50_pm_ops), - .acpi_match_table = ACPI_PTR(stk8ba50_acpi_id), + .acpi_match_table = stk8ba50_acpi_id, }, .probe = stk8ba50_probe, .remove = stk8ba50_remove, From patchwork Sun Dec 31 18:34:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507303 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C899944B for ; Sun, 31 Dec 2023 18:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UH2Xm/Cf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A2A4C433C9; Sun, 31 Dec 2023 18:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047735; bh=Fy0gIq8SLn8DScjo7AXzO7QcZGedQ53QEqk6TGyvWIA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UH2Xm/CfX+rQze6XYJkPLRfzmdYQV1wUBQhKUSdWu+zn2BF7zFsTdPt/k3jPE+H7Z 1N7hL94zUrykkMBPnoRLN20vrfDUhKXAKkoeP3S7Q4Q7mHwxr8HXhpxFwGi5cVlNUx mOesAPRa2kXw5CkHLfF7fXe25MnwWLDq33t8beDgYuXDQ1VKTNlv74/u0CYs+DYfr0 WqQSzSWyIMZ+P3HqI9ZaA4aDJtc63q+JUxuLavlRoHqRmE5iE1IvtJrQZVM96BFobj 2RjbJlRQHVEVFlsesEbK9ENG/Zm1veai+FuPM95p907oAgqDGyUlj2EUkJXS+YN2H3 cn8ESJWB7qM3A== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 08/24] iio: accel: bmc150: Drop ACPI_PTR() Date: Sun, 31 Dec 2023 18:34:58 +0000 Message-ID: <20231231183514.566609-9-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron In general the complexity of avoiding maybe unused variable warnings is not worth dealing with for the small amount of data saved. In thie case, the i2c driver does include some other code under a CONFIG_ACPI guard but remove the ACPI_PTR() usage anyway to bring keep it inline with the spi driver. Drop include of linux/acpi.h in the spi driver that doesn't need it as struct acpi_device_id is defined in mod_devicetable.h which is already included. Signed-off-by: Jonathan Cameron --- drivers/iio/accel/bmc150-accel-i2c.c | 2 +- drivers/iio/accel/bmc150-accel-spi.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/bmc150-accel-i2c.c b/drivers/iio/accel/bmc150-accel-i2c.c index ee1ba134ad42..f08594b372cf 100644 --- a/drivers/iio/accel/bmc150-accel-i2c.c +++ b/drivers/iio/accel/bmc150-accel-i2c.c @@ -266,7 +266,7 @@ static struct i2c_driver bmc150_accel_driver = { .driver = { .name = "bmc150_accel_i2c", .of_match_table = bmc150_accel_of_match, - .acpi_match_table = ACPI_PTR(bmc150_accel_acpi_match), + .acpi_match_table = bmc150_accel_acpi_match, .pm = &bmc150_accel_pm_ops, }, .probe = bmc150_accel_probe, diff --git a/drivers/iio/accel/bmc150-accel-spi.c b/drivers/iio/accel/bmc150-accel-spi.c index 921fb46be0b8..a6b9f599eb7b 100644 --- a/drivers/iio/accel/bmc150-accel-spi.c +++ b/drivers/iio/accel/bmc150-accel-spi.c @@ -7,7 +7,6 @@ #include #include #include -#include #include #include @@ -70,7 +69,7 @@ MODULE_DEVICE_TABLE(spi, bmc150_accel_id); static struct spi_driver bmc150_accel_driver = { .driver = { .name = "bmc150_accel_spi", - .acpi_match_table = ACPI_PTR(bmc150_accel_acpi_match), + .acpi_match_table = bmc150_accel_acpi_match, .pm = &bmc150_accel_pm_ops, }, .probe = bmc150_accel_probe, From patchwork Sun Dec 31 18:34:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507304 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 682C59449 for ; Sun, 31 Dec 2023 18:35:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qzvaj+eT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AE9DC433C7; Sun, 31 Dec 2023 18:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047736; bh=zWlhy6ZNkjB3qcJbh53BaTcO2Nf62ujM4U2RDSpLLfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qzvaj+eT6yIhjElsWQ7kqjJGNGf6we06zq8hLilTcDxmA6IvF5DLPbGyJQMpTCnRc 683erOUkjfFHpNRM2VNC8wdRhfsF3FTWP0kDMNhULdI3jmboAlVVIJVBCAD7DT82Pg 5Sf3X+IRhSzPQnSGgxHZrArn3MqnOYWs98iaDgJxiDmRD75ZltJ1DRYJr2sxDhjaah cRwtSHAV+p5yrn6nM8ALV7NtkAQ5J5sQuqG8Od/+YEr6xCXWZQmo11fLxwrp4UsHWM qG164BWsVf+M45f9K89y9vor+VzWrdvA+uZEKkZNYTjrbUGBuOOferQaapMq7bi4qb 1vm5RoDbcdWjQ== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron , Mike Looijmans Subject: [PATCH 09/24] iio: gyro: bmg160: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:34:59 +0000 Message-ID: <20231231183514.566609-10-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Switch include to mod_devicetable.h as that contains the only acpi specific definitions needed in this driver. Signed-off-by: Jonathan Cameron Cc: Mike Looijmans --- drivers/iio/gyro/bmg160_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/gyro/bmg160_i2c.c b/drivers/iio/gyro/bmg160_i2c.c index 2f9675596138..9c8e20c25e96 100644 --- a/drivers/iio/gyro/bmg160_i2c.c +++ b/drivers/iio/gyro/bmg160_i2c.c @@ -3,7 +3,7 @@ #include #include #include -#include +#include #include "bmg160.h" @@ -66,7 +66,7 @@ MODULE_DEVICE_TABLE(of, bmg160_of_match); static struct i2c_driver bmg160_i2c_driver = { .driver = { .name = "bmg160_i2c", - .acpi_match_table = ACPI_PTR(bmg160_acpi_match), + .acpi_match_table = bmg160_acpi_match, .of_match_table = bmg160_of_match, .pm = &bmg160_pm_ops, }, From patchwork Sun Dec 31 18:35:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507305 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C51C9449 for ; Sun, 31 Dec 2023 18:35:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LXrwQUoN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75564C433C8; Sun, 31 Dec 2023 18:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047738; bh=hTeQeEUNwCvuIMH13pvMttdlmqibt20Bw3vIpd6HuaE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LXrwQUoNSAWlDofgDX0i6cbhyiysqFcBLOGQqQgrsoXpUxmvGXSu9D98D3bgWsjaN geHtc3ykFJyTGHk+LCVnt2qkWkbbo2q2rSwtPalVMA9YlDx+inace6kHtwOu/FeDt3 vh8oTKW+q/tWa/63V9JgpveNrZwBauFGotyazF/1mDJkv/9YrtvjxSEPUOLKS5cVPQ aH4pnoZEDPOb4V6ZMpehQHqp2eH0epaUFofwAyFqeJevIawYd0r4HeOxXucL+V9ebw ybS0YSH/g9h3QkWknIBDH0NDNMFEiQS1VIx5JNrYBdhylzfrjLh3T8bfo3zA3n72PW EuueaIHgYhp+Q== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 10/24] iio: humidity: hts221: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:35:00 +0000 Message-ID: <20231231183514.566609-11-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Switch include to mod_devicetable.h as that contains the only ACPI specific definitions needed in this driver. Signed-off-by: Jonathan Cameron --- drivers/iio/humidity/hts221_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/humidity/hts221_i2c.c b/drivers/iio/humidity/hts221_i2c.c index 30f2068ea156..5cb263e0ef5a 100644 --- a/drivers/iio/humidity/hts221_i2c.c +++ b/drivers/iio/humidity/hts221_i2c.c @@ -9,7 +9,7 @@ #include #include -#include +#include #include #include #include @@ -63,7 +63,7 @@ static struct i2c_driver hts221_driver = { .name = "hts221_i2c", .pm = pm_sleep_ptr(&hts221_pm_ops), .of_match_table = hts221_i2c_of_match, - .acpi_match_table = ACPI_PTR(hts221_acpi_match), + .acpi_match_table = hts221_acpi_match, }, .probe = hts221_i2c_probe, .id_table = hts221_i2c_id_table, From patchwork Sun Dec 31 18:35:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507306 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33C7E946F for ; Sun, 31 Dec 2023 18:35:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ik3DvDbN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F008C433C7; Sun, 31 Dec 2023 18:35:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047740; bh=uwn1TUxZOUiSXjc/bFfi+mAKWflhsH6WURAePKltE6A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ik3DvDbNB0A7nHOR8x9NRjealwWXTz3pGrrm4CODOii7HW+5X+YMmJsKCQMhXxkAx FUUOnZAlYyZM0st394Zd/sQtT/Jal0RU7Ohm6pEQ1xqHOGEjSAq2PVKZEPV/JySkD+ C411t2XFaq3uss9Ygw1UNb3ZWV83N+VJW3CRMH+RYyFqwzKfvEECUgUtK9aNi5WlJB e4/qfMsFl8pvKDdvOcVY6yW0JxG09M6GFPPtjngYYJqMZ5QHNso1ori1ArzF72o7KH OQK+Qs/kLS9DgSckInA/6O2W9f/C9RbY/atXz7BstY7Fcyy+dXoSUwaLeS1/T2rdER 6tLxmpajr2jAA== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron , kernel test robot , Carlos Song Subject: [PATCH 11/24] iio: imu: fxos8700: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:35:01 +0000 Message-ID: <20231231183514.566609-12-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Drop unused acpi.h include. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311231427.vEQAuxvI-lkp@intel.com/ Signed-off-by: Jonathan Cameron Cc: Carlos Song --- drivers/iio/imu/fxos8700_i2c.c | 3 +-- drivers/iio/imu/fxos8700_spi.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/imu/fxos8700_i2c.c b/drivers/iio/imu/fxos8700_i2c.c index 2ace306d0f9a..e99677ad96a2 100644 --- a/drivers/iio/imu/fxos8700_i2c.c +++ b/drivers/iio/imu/fxos8700_i2c.c @@ -10,7 +10,6 @@ * 1 | 0 | 0x1C * 1 | 1 | 0x1F */ -#include #include #include #include @@ -57,7 +56,7 @@ MODULE_DEVICE_TABLE(of, fxos8700_of_match); static struct i2c_driver fxos8700_i2c_driver = { .driver = { .name = "fxos8700_i2c", - .acpi_match_table = ACPI_PTR(fxos8700_acpi_match), + .acpi_match_table = fxos8700_acpi_match, .of_match_table = fxos8700_of_match, }, .probe = fxos8700_i2c_probe, diff --git a/drivers/iio/imu/fxos8700_spi.c b/drivers/iio/imu/fxos8700_spi.c index 27e694cce173..6b0dc7a776b9 100644 --- a/drivers/iio/imu/fxos8700_spi.c +++ b/drivers/iio/imu/fxos8700_spi.c @@ -2,7 +2,6 @@ /* * FXOS8700 - NXP IMU, SPI bits */ -#include #include #include #include @@ -46,7 +45,7 @@ static struct spi_driver fxos8700_spi_driver = { .probe = fxos8700_spi_probe, .id_table = fxos8700_spi_id, .driver = { - .acpi_match_table = ACPI_PTR(fxos8700_acpi_match), + .acpi_match_table = fxos8700_acpi_match, .of_match_table = fxos8700_of_match, .name = "fxos8700_spi", }, From patchwork Sun Dec 31 18:35:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507307 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6579F9471 for ; Sun, 31 Dec 2023 18:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tHBNeW7Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2391FC433C8; Sun, 31 Dec 2023 18:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047742; bh=D3aPnMEHrmQx31mzfIDVLYetS7lHL6csyTayGeo/+QI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tHBNeW7ZvfB8AMnlWtqpDpL6XxUfQZj+TEfXWWkDQmVN4u1sxDp2UD4LHYSkDznd7 5UIUpCEhAgoqgNs++eKvJchpQWXG4rd+dJjyTm4AtJ2AOKJ5tA0+HnEGLWELl5cIew L4tsVAvFq5DaoQ8piU2Mqxt0Pg+hQy1uf4cHHAcQ+GnAMJGiL64euMVo7z7gbYr82M nSY3LRM7Rtts/2sDHkBsAD14d2D1nmQWA+maz2UW38M6JxEM6hsr5bjJwAULkRwdNh Tz0ZINXTOwS4duaBWrLYk48yqbmuk2De5NH7wp17PqTTRt75fv0KjRq7U700OWBxwT hRcV8FaZ2EX0A== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 12/24] iio: imu: kmx61: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:35:02 +0000 Message-ID: <20231231183514.566609-13-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Signed-off-by: Jonathan Cameron --- drivers/iio/imu/kmx61.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c index 958167b31241..7d3e061f3046 100644 --- a/drivers/iio/imu/kmx61.c +++ b/drivers/iio/imu/kmx61.c @@ -1514,7 +1514,7 @@ MODULE_DEVICE_TABLE(i2c, kmx61_id); static struct i2c_driver kmx61_driver = { .driver = { .name = KMX61_DRV_NAME, - .acpi_match_table = ACPI_PTR(kmx61_acpi_match), + .acpi_match_table = kmx61_acpi_match, .pm = pm_ptr(&kmx61_pm_ops), }, .probe = kmx61_probe, From patchwork Sun Dec 31 18:35:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507308 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CC889449 for ; Sun, 31 Dec 2023 18:35:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I86AGei/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3F9CC433C7; Sun, 31 Dec 2023 18:35:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047743; bh=Lvpx8Bxt2jg94Hk0bcBhVt3BqENH0sXYyi35Io7CEpw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I86AGei/WASanIV3XSCZ0VYM3L19Du5oZ/emg4JKFdi6D6GQxxBweKQGdfTTYisP+ 8QLUB8nloCIML84VOs8KSkvMozXUMes4o8tx5hx7sEHiyfm9EerIBv2P7IZlcDQqtS HESE39HGpcmy5mQCEh6fo60CM4jvwSGtI4MIG6vAVllKsMRlIDDremgrvBrhzN4vig BjKFLdcC8gcHKqtxL1RZwHESBJ8fQZ1aJQmUopsOnWaWTmFJhkeIbfZLGtA+RfREJS WkR9ZzSF8yhiR5UrutEQPYMf9mrt/X2Hgtvy83lpwAOAr3uGRW2YTIznKkfcSqnud3 srHQ7/PJutEPA== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 13/24] iio: light: jsa1212: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:35:03 +0000 Message-ID: <20231231183514.566609-14-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Switch include from acpi.h to mod_devicetable.h which includes the definition of struct acpi_device_id. Signed-off-by: Jonathan Cameron --- drivers/iio/light/jsa1212.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/jsa1212.c b/drivers/iio/light/jsa1212.c index 37e2807041a1..869196746045 100644 --- a/drivers/iio/light/jsa1212.c +++ b/drivers/iio/light/jsa1212.c @@ -12,10 +12,10 @@ #include #include #include +#include #include #include #include -#include #include #include #include @@ -438,7 +438,7 @@ static struct i2c_driver jsa1212_driver = { .driver = { .name = JSA1212_DRIVER_NAME, .pm = pm_sleep_ptr(&jsa1212_pm_ops), - .acpi_match_table = ACPI_PTR(jsa1212_acpi_match), + .acpi_match_table = jsa1212_acpi_match, }, .probe = jsa1212_probe, .remove = jsa1212_remove, From patchwork Sun Dec 31 18:35:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507309 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4D5D8F6F for ; Sun, 31 Dec 2023 18:35:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nX1aCVXm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71F67C433C8; Sun, 31 Dec 2023 18:35:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047745; bh=1SaETNdIZL7KKdVLS7xXDMccw4tEMdbpxBHfKZkl/VI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nX1aCVXmVwUPu288BMGZI6qVqhKYvm7yZPqDKzwchonGZI7Rn40n96EFa1IaJUAqa fDvC4fyfEZi3mKrKQWniaNbC24iipyFdq35YgY1Av3aUJdjBQ/Pc/vPB+xsVpaq6Ga l+CKCpgOqjUbdyinxWqObF7rBNo9x0E/7NK0O2ugDSea4U2PuFDokQcfoP46DlhHOY lDYd/oQu0Kjxx5bVBT+TqXWlQ9tXb6V/i8RBbOOlKcU9DTQSu5YvORUE/gXhTSUr3c WEw5PeWJdhPI6TalRhmK07zVdnVPZlZHRMWCkZUafyH/L7DTPiE1K2BqNcSNp4KL5S ZpfvR3Fx1FiiQ== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 14/24] iio: light: ltr501: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:35:04 +0000 Message-ID: <20231231183514.566609-15-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Include linux/mod_devicetable.h which includes the definition of struct acpi_device_id (hence somewhat related to the main change) Signed-off-by: Jonathan Cameron --- drivers/iio/light/ltr501.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c index 061c122fdc5e..8c516ede9116 100644 --- a/drivers/iio/light/ltr501.c +++ b/drivers/iio/light/ltr501.c @@ -10,6 +10,7 @@ */ #include +#include #include #include #include @@ -1639,7 +1640,7 @@ static struct i2c_driver ltr501_driver = { .name = LTR501_DRV_NAME, .of_match_table = ltr501_of_match, .pm = pm_sleep_ptr(<r501_pm_ops), - .acpi_match_table = ACPI_PTR(ltr_acpi_match), + .acpi_match_table = ltr_acpi_match, }, .probe = ltr501_probe, .remove = ltr501_remove, From patchwork Sun Dec 31 18:35:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507310 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F5AF946F for ; Sun, 31 Dec 2023 18:35:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fj0voqZn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 477F8C433C7; Sun, 31 Dec 2023 18:35:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047748; bh=cyCRz59QJCpgqOottnhsRenKeKV6/ecrahYphOrQYWg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fj0voqZnUlSf2yzCWyiGlorqcR7nSTTzbAaOQUm97Y+x5g5xb+9SYo/B524V4L4qX X9VoC/67dgfpENo9Og6pIbHwHqKtB2tgRORoad5xB+SUIep9ksJntjhXyHYo+QNwvL RMwERsRH9Z5qHQX0ZNofygOeYxyOze6YzUxIAB+U1WvFB9u45e7A0lmujo4xh/WAlv 6roHHL+BYYDB2q0ZikoWepTFYoYlOR2kJuplHJ1Wkt9jN046cKDz2gEh4MDR2vryVs hMMKKXo6n67j4BvN3S5Am7DTmQ2j9icXFW8S/CYT3ZCCls7+cR7uF+ujEl38iyP0ZC pgqYQMWy94y/g== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 15/24] iio: light: rpr0521: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:35:05 +0000 Message-ID: <20231231183514.566609-16-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Switch include from acpi.h to mod_devicetable.h which includes the definition of struct acpi_device_id. Signed-off-by: Jonathan Cameron --- drivers/iio/light/rpr0521.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/rpr0521.c b/drivers/iio/light/rpr0521.c index bbb8581622f2..40d5732b5e32 100644 --- a/drivers/iio/light/rpr0521.c +++ b/drivers/iio/light/rpr0521.c @@ -10,11 +10,11 @@ */ #include +#include #include #include #include #include -#include #include #include @@ -1119,7 +1119,7 @@ static struct i2c_driver rpr0521_driver = { .driver = { .name = RPR0521_DRV_NAME, .pm = pm_ptr(&rpr0521_pm_ops), - .acpi_match_table = ACPI_PTR(rpr0521_acpi_match), + .acpi_match_table = rpr0521_acpi_match, }, .probe = rpr0521_probe, .remove = rpr0521_remove, From patchwork Sun Dec 31 18:35:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507311 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 672D7947A for ; Sun, 31 Dec 2023 18:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FU20b2V+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C2E3C433C8; Sun, 31 Dec 2023 18:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047749; bh=wY8Wk3PVZiVMJs5dhjyfFPaFpSBNAGpPuDZe380g8/M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FU20b2V+wr3keFwihZdXr6WIHICr3rkbehi96KgxGdwl4xuL4fR63qmWPODLLuqzk fEUvk/qipEenuLg/lhcKzOH4RZSnfzX857nVg6/YxO7DzfsQhMM2EpGdPiaeCwrwSs Qbldvt+ktr00GJyA6zzuGcduiTs67eoiQSQfWxtedWyIlnkRa+Am3WJ4EsL0Ksj7mB BcS+BG2oxBgd5pfEzb2auooui6RUFsUc1bx9fRfP9PNm5hsiZ2rzqb53Nv2Dhd2agR /EwwoWhoXc1SsY56e+a4QH6y346aJIl4xYbkb1XiHkI2HSYlO9RwN7MvA0vxUTyM2/ 3RXLT7jGilIuw== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron , kernel test robot Subject: [PATCH 16/24] iio: light: stk3310: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:35:06 +0000 Message-ID: <20231231183514.566609-17-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Switch include from acpi.h to mod_devicetable.h which includes the definition of struct acpi_device_id. Reported-by: kernel test robot Signed-off-by: Jonathan Cameron --- The report I can immediately find is in a much larger set of unrelated errors hence no closes tag. --- drivers/iio/light/stk3310.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c index 72b08d870d33..7b71ad71d78d 100644 --- a/drivers/iio/light/stk3310.c +++ b/drivers/iio/light/stk3310.c @@ -7,11 +7,11 @@ * IIO driver for STK3310/STK3311. 7-bit I2C address: 0x48. */ -#include #include #include #include #include +#include #include #include #include @@ -712,7 +712,7 @@ static struct i2c_driver stk3310_driver = { .name = "stk3310", .of_match_table = stk3310_of_match, .pm = pm_sleep_ptr(&stk3310_pm_ops), - .acpi_match_table = ACPI_PTR(stk3310_acpi_id), + .acpi_match_table = stk3310_acpi_id, }, .probe = stk3310_probe, .remove = stk3310_remove, From patchwork Sun Dec 31 18:35:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507312 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2558D946F for ; Sun, 31 Dec 2023 18:35:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Aje/du5X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F1F3C433C8; Sun, 31 Dec 2023 18:35:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047752; bh=Jl5ePVqEDcvKIvolKW52LBt61KYC/GPdlCvoEoStObc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Aje/du5XL2vKnTJiANA+ymJYTX3q9fkgnwEfu6Y+pWHAIGCLQ6co5aPC8FSKhkT4Y g2LyACQD9yr80Pt/g4UikpWFFe9jQUQeqzmWJguPCdyWLab5cQ7NEkZ2sMABXmjP/a pmkLswAwJ9thg2YNOVRkYyeYJLOXJ6fX8KWcDwd+x8qdE5kUvc8MRHUA8K57RpsySW uqk3ha2zaozEIne2KQJPvh3DFkh6a/klENzOy90fqIV+ph1yJs2oaBIzxb17gnLinb g0t3BFt3XdA9DP0ywiG2XcU3ApVtxtAUz2KPzs1k7dIq47l6RUQqbShgElmPxy67W1 FwGuaWKqP5ezw== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron , kernel test robot Subject: [PATCH 17/24] iio: light: us5182d: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:35:07 +0000 Message-ID: <20231231183514.566609-18-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Switch include from acpi.h to mod_devicetable.h which includes the definition of struct acpi_device_id. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311190738.gldzuIXo-lkp@intel.com/ Signed-off-by: Jonathan Cameron --- drivers/iio/light/us5182d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c index 61b3b2aea626..9189a1d4d7e1 100644 --- a/drivers/iio/light/us5182d.c +++ b/drivers/iio/light/us5182d.c @@ -9,7 +9,7 @@ #include #include -#include +#include #include #include #include @@ -972,7 +972,7 @@ static struct i2c_driver us5182d_driver = { .name = US5182D_DRV_NAME, .pm = pm_ptr(&us5182d_pm_ops), .of_match_table = us5182d_of_match, - .acpi_match_table = ACPI_PTR(us5182d_acpi_match), + .acpi_match_table = us5182d_acpi_match, }, .probe = us5182d_probe, .remove = us5182d_remove, From patchwork Sun Dec 31 18:35:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507313 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE55A9470 for ; Sun, 31 Dec 2023 18:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VE9q1i0e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82420C433C7; Sun, 31 Dec 2023 18:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047753; bh=gAjHpl35RhX0uaorrf0CmrQXx8Jcp6zuIYXWxXZ13/o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VE9q1i0e+ENPU0mISqQhn1KRaXJO4GvtU9tyxL+mjdIV4+u+eOngq8Svx0wCQ9akp 6AGXhPLax62NZJ/+xQTmj/NYNCAtHrWu3aIaVIdKpM7SmASmuI0tvq9S1Y91Y1xxQR uDa13jbXS65ZEC7HInJdc24O/7uDR/5vu0GNwMEOXEUQ6JivJxM5ILnW/n0tVLGPsv tQNZHkHZjGJhfdW2qbU77OWNSg/NLfnm6QoMjf+dawFDiBaV8QGFZ50TxCwH7UmNVB zFo8U/+hkV7f1rybo0A1Mo8VhsmlpD/OPABfcGZC9imqpKupTE5rPHsA0DTaHiCkZc TI/ItKuytMeBg== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron , kernel test robot Subject: [PATCH 18/24] iio: magnetometer: bmc150: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:35:08 +0000 Message-ID: <20231231183514.566609-19-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Drop unused linux/acpi.h includes. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312040109.Csnmqnb2-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202311171116.47sUbZV5-lkp@intel.com/ Signed-off-by: Jonathan Cameron --- drivers/iio/magnetometer/bmc150_magn_i2c.c | 3 +-- drivers/iio/magnetometer/bmc150_magn_spi.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/magnetometer/bmc150_magn_i2c.c b/drivers/iio/magnetometer/bmc150_magn_i2c.c index 281d1fa31c8e..48d9c698f520 100644 --- a/drivers/iio/magnetometer/bmc150_magn_i2c.c +++ b/drivers/iio/magnetometer/bmc150_magn_i2c.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include "bmc150_magn.h" @@ -68,7 +67,7 @@ static struct i2c_driver bmc150_magn_driver = { .driver = { .name = "bmc150_magn_i2c", .of_match_table = bmc150_magn_of_match, - .acpi_match_table = ACPI_PTR(bmc150_magn_acpi_match), + .acpi_match_table = bmc150_magn_acpi_match, .pm = &bmc150_magn_pm_ops, }, .probe = bmc150_magn_i2c_probe, diff --git a/drivers/iio/magnetometer/bmc150_magn_spi.c b/drivers/iio/magnetometer/bmc150_magn_spi.c index 882987721071..abc75a05c46a 100644 --- a/drivers/iio/magnetometer/bmc150_magn_spi.c +++ b/drivers/iio/magnetometer/bmc150_magn_spi.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include "bmc150_magn.h" @@ -55,7 +54,7 @@ static struct spi_driver bmc150_magn_spi_driver = { .remove = bmc150_magn_spi_remove, .id_table = bmc150_magn_spi_id, .driver = { - .acpi_match_table = ACPI_PTR(bmc150_magn_acpi_match), + .acpi_match_table = bmc150_magn_acpi_match, .name = "bmc150_magn_spi", }, }; From patchwork Sun Dec 31 18:35:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507314 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19061AD25 for ; Sun, 31 Dec 2023 18:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NLq3jwLC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 262BCC433C8; Sun, 31 Dec 2023 18:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047754; bh=QqqWuEipCzKVQESUlVNEUpvOqTx6euQIx4FtdGhGOkE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NLq3jwLC0rx6F4wQO/9WH74s1UgFqYEdpH/j4i5H9hs26i0ATcAgWp63pCM8pwPKJ mpM2CAF94dMcsINRLVckXRdCnF7sfJjtsB/2/XqBa4n7yNj3Zw36XFhc+uXDvUm/D/ k7oG9FGn1o99kgYv3BknMGM+HccM7IYX8+VT/0Pxa0OWgzg0zft9PIMwIAxQgvN35a e0euH7yyM47TZsSES5vmCyYfh/hB+AUz5NhMpedzdDRZHCv6E2jmFzQzc7FmaR9jXi KaWPikyL3D1IDq30Qk07rdVh9IeH5M0abkqbD4jTjWpRDuJykxF/cH/z+bMBMaTU0W CPokx/XwAMalg== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 19/24] iio: magnetometer: mmc35240: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:35:09 +0000 Message-ID: <20231231183514.566609-20-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Switch include from acpi.h to mod_devicetable.h which includes the definition of struct acpi_device_id. Signed-off-by: Jonathan Cameron --- drivers/iio/magnetometer/mmc35240.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c index b495b8a63928..6b9f4b056191 100644 --- a/drivers/iio/magnetometer/mmc35240.c +++ b/drivers/iio/magnetometer/mmc35240.c @@ -10,11 +10,11 @@ */ #include +#include #include #include #include #include -#include #include #include @@ -573,7 +573,7 @@ static struct i2c_driver mmc35240_driver = { .name = MMC35240_DRV_NAME, .of_match_table = mmc35240_of_match, .pm = pm_sleep_ptr(&mmc35240_pm_ops), - .acpi_match_table = ACPI_PTR(mmc35240_acpi_match), + .acpi_match_table = mmc35240_acpi_match, }, .probe = mmc35240_probe, .id_table = mmc35240_id, From patchwork Sun Dec 31 18:35:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507315 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57E64AD25 for ; Sun, 31 Dec 2023 18:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bJ4HTaAw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A769C433C8; Sun, 31 Dec 2023 18:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047756; bh=TFFWIIjCmLsPf5u7zPp74sVLrXDsrklat03JWq0cwTQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bJ4HTaAwCg8xXfoONlU4SqYryNHa7sWcB0W5mlZGEePNKCeqi3RTq53gAOGYpo8G5 YIuSOzvar7pITbn0aqJW92MvKv8vEr786ZTlcGM2NV32aXBbfiAJNI8yDBYIPfMLMA yj3oGnJLkLjVHEfrPDk6FOwIxYnIKGOpWbhpXRZJPBjr+Bdg5LChx4DSaetIle2ENJ fXgaM2QdvRFnDbAb9K60ZiyhtzYvUnSJxviPdz22y56qpLLIfdcvYJjxnMDALx5N+B YsipXFJp2hZYxlEJYDGMjqC9qDqZWSYGfruAYpB1rfQC2f2b8lnCbsyoZBv6unfRWg Ap/Q+Y7By2VFg== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron , kernel test robot Subject: [PATCH 20/24] iio: potentiometer: max5487: Drop ACPI_PTR() usage Date: Sun, 31 Dec 2023 18:35:10 +0000 Message-ID: <20231231183514.566609-21-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron Avoiding unused variable warnings when using this macro adds complexity that in simple cases like this one is not justified for the small saving in data. Switch include from acpi.h to mod_devicetable.h which includes the definition of struct acpi_device_id. Reported-by: kernel test robot Signed-off-by: Jonathan Cameron --- I can't find a specific listing for this one so no closes tag. --- drivers/iio/potentiometer/max5487.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/potentiometer/max5487.c b/drivers/iio/potentiometer/max5487.c index 42723c996c9f..4838d2e72f53 100644 --- a/drivers/iio/potentiometer/max5487.c +++ b/drivers/iio/potentiometer/max5487.c @@ -5,8 +5,8 @@ * Copyright (C) 2016 Cristina-Gabriela Moraru */ #include +#include #include -#include #include #include @@ -144,7 +144,7 @@ MODULE_DEVICE_TABLE(acpi, max5487_acpi_match); static struct spi_driver max5487_driver = { .driver = { .name = "max5487", - .acpi_match_table = ACPI_PTR(max5487_acpi_match), + .acpi_match_table = max5487_acpi_match, }, .id_table = max5487_id, .probe = max5487_spi_probe, From patchwork Sun Dec 31 18:35:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507316 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFB019449 for ; Sun, 31 Dec 2023 18:35:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YqPE7SFP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F102C433C7; Sun, 31 Dec 2023 18:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047759; bh=gtohdYKYVmvIZMgiZK1b3gRkd22ji9IpmJvxnSfQ2kc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YqPE7SFPqhWardG9bbyFgKqZ9+VkkMprpPqQjIPtTe6cXGZSntCGYynTQ9KKtxjaR K2YQ9G10x1iU+gLEfddyLPm6Ftk/A7zoj4pRoo0aU0IQH7omvlcBaO26d5qwNl3Qtd fnz40spiDPD9Ki/qMu3RllKAY8GN5a1VR/YKJMe1ORg58frY2WEx7PLhHGGhDY4T0y CCT2oLEIrJu6vp2ZG527Qnbw6NuYZAp71S7jwUPFFbBobgAu/5jaTf2Rxtz++0fgph HBVWPuSWyqYIVWj09rM4qaQlvlnSTFLKtkncS2T9LhFo8Tgw7OJ/tZm21MZMMSahj9 fCn6rfnDv7V8Q== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron , Linus Walleij , Denis CIOCCA Subject: [PATCH 21/24] iio: st_sensors: drop ACPI_PTR() and CONFIG_ACPI guards Date: Sun, 31 Dec 2023 18:35:11 +0000 Message-ID: <20231231183514.566609-22-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron The complexity of config guards needed for ACPI_PTR() is not worthwhile for the small amount of saved data. This example was doing it correctly but I am proposing dropping this so as to reduce chance of cut and paste where it is done wrong. Also drop now unneeded linux/acpi.h include. Signed-off-by: Jonathan Cameron Cc: Linus Walleij Cc: Denis CIOCCA --- drivers/iio/accel/st_accel_i2c.c | 5 +---- drivers/iio/pressure/st_pressure_i2c.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/iio/accel/st_accel_i2c.c b/drivers/iio/accel/st_accel_i2c.c index 71ee861b2980..fd3749871121 100644 --- a/drivers/iio/accel/st_accel_i2c.c +++ b/drivers/iio/accel/st_accel_i2c.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include @@ -127,14 +126,12 @@ static const struct of_device_id st_accel_of_match[] = { }; MODULE_DEVICE_TABLE(of, st_accel_of_match); -#ifdef CONFIG_ACPI static const struct acpi_device_id st_accel_acpi_match[] = { {"SMO8840", (kernel_ulong_t)LIS2DH12_ACCEL_DEV_NAME}, {"SMO8A90", (kernel_ulong_t)LNG2DM_ACCEL_DEV_NAME}, { }, }; MODULE_DEVICE_TABLE(acpi, st_accel_acpi_match); -#endif static const struct i2c_device_id st_accel_id_table[] = { { LSM303DLH_ACCEL_DEV_NAME }, @@ -204,7 +201,7 @@ static struct i2c_driver st_accel_driver = { .driver = { .name = "st-accel-i2c", .of_match_table = st_accel_of_match, - .acpi_match_table = ACPI_PTR(st_accel_acpi_match), + .acpi_match_table = st_accel_acpi_match, }, .probe = st_accel_i2c_probe, .id_table = st_accel_id_table, diff --git a/drivers/iio/pressure/st_pressure_i2c.c b/drivers/iio/pressure/st_pressure_i2c.c index 5101552e3f38..389523d6ae32 100644 --- a/drivers/iio/pressure/st_pressure_i2c.c +++ b/drivers/iio/pressure/st_pressure_i2c.c @@ -7,7 +7,6 @@ * Denis Ciocca */ -#include #include #include #include @@ -55,13 +54,11 @@ static const struct of_device_id st_press_of_match[] = { }; MODULE_DEVICE_TABLE(of, st_press_of_match); -#ifdef CONFIG_ACPI static const struct acpi_device_id st_press_acpi_match[] = { {"SNO9210", LPS22HB}, { }, }; MODULE_DEVICE_TABLE(acpi, st_press_acpi_match); -#endif static const struct i2c_device_id st_press_id_table[] = { { LPS001WP_PRESS_DEV_NAME, LPS001WP }, @@ -114,7 +111,7 @@ static struct i2c_driver st_press_driver = { .driver = { .name = "st-press-i2c", .of_match_table = st_press_of_match, - .acpi_match_table = ACPI_PTR(st_press_acpi_match), + .acpi_match_table = st_press_acpi_match, }, .probe = st_press_i2c_probe, .id_table = st_press_id_table, From patchwork Sun Dec 31 18:35:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507317 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E992E9449 for ; Sun, 31 Dec 2023 18:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a+J1Eeej" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05E5DC433C8; Sun, 31 Dec 2023 18:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047760; bh=rQ2Uddv0tF3IE2PFgll/8V/KdM/+WNckGYfiCppXnm8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a+J1EeejJXgNbVEFa45ZbK6c+wB9RONTMIXWoNUeEg6VUDmH7RJuP/C17VsJ6QM2Z 7vuGjgNz4wRDc3Wp3wPGE6mFTE98KxnyX2jZsVeTQG/GLJj0YA+A3GEsvJZ9Gpv/2z s2UHCw8t+owt4z8Nso3vGUVb5rykPtXC2DnoT9UDhUjNs+nG0h8jm+VWaWGcz/ETGL ICeI4WsFajhLK6JabwWA/LmmZxGI4bb+mpyFp/72c3q5slcupSoMUvD/xsN7LbPvhe eVQPO769+S2Fa7uN7dcpTu03PMeh/VHEvkdneq7WFVb0DoYD5jwlamQGZtB0qu4EH8 AN4rqVovszvjg== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 22/24] iio: pressure: hp206c: drop ACPI_PTR() and CONFIG_ACPI guards Date: Sun, 31 Dec 2023 18:35:12 +0000 Message-ID: <20231231183514.566609-23-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron The complexity of config guards needed for ACPI_PTR() is not worthwhile for the small amount of saved data. This example was doing it correctly but I am proposing dropping this so as to reduce chance of cut and paste where it is done wrong. Also drop now unneeded linux/acpi.h include and added linux/mod_devicetable.h for struct acpi_device_id definition. Signed-off-by: Jonathan Cameron --- drivers/iio/pressure/hp206c.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/pressure/hp206c.c b/drivers/iio/pressure/hp206c.c index a072de6cb59c..261af1562827 100644 --- a/drivers/iio/pressure/hp206c.c +++ b/drivers/iio/pressure/hp206c.c @@ -11,12 +11,12 @@ */ #include +#include #include #include #include #include #include -#include #include @@ -400,20 +400,18 @@ static const struct i2c_device_id hp206c_id[] = { }; MODULE_DEVICE_TABLE(i2c, hp206c_id); -#ifdef CONFIG_ACPI static const struct acpi_device_id hp206c_acpi_match[] = { {"HOP206C", 0}, { }, }; MODULE_DEVICE_TABLE(acpi, hp206c_acpi_match); -#endif static struct i2c_driver hp206c_driver = { .probe = hp206c_probe, .id_table = hp206c_id, .driver = { .name = "hp206c", - .acpi_match_table = ACPI_PTR(hp206c_acpi_match), + .acpi_match_table = hp206c_acpi_match, }, }; From patchwork Sun Dec 31 18:35:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507318 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 225219449 for ; Sun, 31 Dec 2023 18:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lncGjpmy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 317B1C433C9; Sun, 31 Dec 2023 18:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047762; bh=pgtJ2HP5ytDsie/NpUvjS4mrbcfUcJ7DEBGfRsrjUok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lncGjpmy884oFhMe8gj+b5SxItuzN2qdCwKHrbk+EL7LwXhkM3GibnzUFmx2Nr4Yh YawIU8BMLyE40U8NcZlsfyQUDrw8xwX2ZE5roQLXR1UIMgd3Lv1N5JCgEcEiLCUDLG yfbuedgPH4v6ldxrj9wQOxcMvHP6WgErrEKXYruYD5rGEyOtkO8DNUidLSSNhI1myi lihTO9wI4WVAR19lQbY2ulJwVMaA2hHJWYC73nxj09S3RagkY4YKQl78LJnoSo1QDF ku8YYFRp38jsi9MSbISdomt5BsSzuIkkQTysCcVFhOQAT1HJW3D1xMFU7xUfk6EUS5 MOgx6zwVF6WpA== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 23/24] iio: light: max44000: drop ACPI_PTR() and CONFIG_ACPI guards Date: Sun, 31 Dec 2023 18:35:13 +0000 Message-ID: <20231231183514.566609-24-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron The complexity of config guards needed for ACPI_PTR() is not worthwhile for the small amount of saved data. This example was doing it correctly but I am proposing dropping this so as to reduce chance of cut and paste where it is done wrong. Also drop now unneeded linux/acpi.h include and added linux/mod_devicetable.h for struct acpi_device_id definition. Signed-off-by: Jonathan Cameron --- drivers/iio/light/max44000.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/max44000.c b/drivers/iio/light/max44000.c index db96c5b73100..26b464b1b650 100644 --- a/drivers/iio/light/max44000.c +++ b/drivers/iio/light/max44000.c @@ -10,6 +10,7 @@ */ #include +#include #include #include #include @@ -19,7 +20,6 @@ #include #include #include -#include #define MAX44000_DRV_NAME "max44000" @@ -603,18 +603,16 @@ static const struct i2c_device_id max44000_id[] = { }; MODULE_DEVICE_TABLE(i2c, max44000_id); -#ifdef CONFIG_ACPI static const struct acpi_device_id max44000_acpi_match[] = { {"MAX44000", 0}, { } }; MODULE_DEVICE_TABLE(acpi, max44000_acpi_match); -#endif static struct i2c_driver max44000_driver = { .driver = { .name = MAX44000_DRV_NAME, - .acpi_match_table = ACPI_PTR(max44000_acpi_match), + .acpi_match_table = max44000_acpi_match, }, .probe = max44000_probe, .id_table = max44000_id, From patchwork Sun Dec 31 18:35:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13507319 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB2CA9449 for ; Sun, 31 Dec 2023 18:36:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="COiWfw7+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E8ECC433C8; Sun, 31 Dec 2023 18:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704047763; bh=T83QePi6HC6U/3scuy9n7Zok2bayZEqRBHyr/AL1fio=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=COiWfw7+ks+L+c8jZW9Sk6t6gs8qMeRfvRTESfXFHNN18I4kN1P6CFU2O7H43tFHm rWkbM8uxH2ELOIPc61yib2aItioqd7gGWDzr/Rfec9zHmIFLjXl+gqrZTBC1mnJoGO ellHj6Eh9llhNJDpYUGGQuA6GvQQgo5vJEcgHstb7m5NyHkkVoQiM8t4OyBemplwcz nxx55of5Neq+clziJ3zp3swHZuBcYYinURC+VKBadV2EYUGDSSmN1vjGHNp61JV6ez Q1zDJb8pePN5TMX71BNy/8qIJHTaWA7V9k2u1YKSE2q+cV1MtOZIKOaA48b3IkVfs3 wE/iut0o/oTkA== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Jonathan Cameron Subject: [PATCH 24/24] iio: adc: ti-adc109s102: drop ACPI_PTR() and CONFIG_ACPI guards Date: Sun, 31 Dec 2023 18:35:14 +0000 Message-ID: <20231231183514.566609-25-jic23@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231231183514.566609-1-jic23@kernel.org> References: <20231231183514.566609-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron The complexity of config guards needed for ACPI_PTR() is not worthwhile for the small amount of saved data. This example was doing it correctly but I am proposing dropping this so as to reduce chance of cut and paste where it is done wrong. Signed-off-by: Jonathan Cameron --- drivers/iio/adc/ti-adc108s102.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iio/adc/ti-adc108s102.c b/drivers/iio/adc/ti-adc108s102.c index c82a161630e1..69fcbbc7e418 100644 --- a/drivers/iio/adc/ti-adc108s102.c +++ b/drivers/iio/adc/ti-adc108s102.c @@ -293,13 +293,11 @@ static const struct of_device_id adc108s102_of_match[] = { }; MODULE_DEVICE_TABLE(of, adc108s102_of_match); -#ifdef CONFIG_ACPI static const struct acpi_device_id adc108s102_acpi_ids[] = { { "INT3495", 0 }, { } }; MODULE_DEVICE_TABLE(acpi, adc108s102_acpi_ids); -#endif static const struct spi_device_id adc108s102_id[] = { { "adc108s102", 0 }, @@ -311,7 +309,7 @@ static struct spi_driver adc108s102_driver = { .driver = { .name = "adc108s102", .of_match_table = adc108s102_of_match, - .acpi_match_table = ACPI_PTR(adc108s102_acpi_ids), + .acpi_match_table = adc108s102_acpi_ids, }, .probe = adc108s102_probe, .id_table = adc108s102_id,