From patchwork Mon Jan 1 21:00:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Weber X-Patchwork-Id: 13508715 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D799C4706F for ; Mon, 1 Jan 2024 21:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t5NVNZ7DJPOw0kqfFihPPG3aH5RZYgH/nvjHF6yMNxs=; b=cIoUtZEGOXexjO XMtvBDCqxMHM43C7oeTkNJaULK9VzLOCb5QwwGJMhpO/wpB4gB2UPi6YV1/md6wXbNM9S353iKQ0F 1FZ26wq35P/8TqdY3PmOodnyeohOe5+xUQh59eWJflkianlCeuCyiZM/Iht9gNIBVFED5DLSh7D6d LgGfmTbX5zAh2jZQGHwzjRUWl1SR+iwz4WfoCw4hOMFzOW9AYs2NwHUpHRkyWxorQSpvoBqFtqB3Y jQ8gDgoR+grnfKO5cm1xp8oV33kcqsVGKrAdXbUduxlBQ0Cd0+ALEULE61a2iUuhl2trLDeavBxge WKxkv8X91PKvfIzX0xfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKPOe-006ixe-2b; Mon, 01 Jan 2024 21:00:28 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKPOa-006iwk-3B for linux-arm-kernel@lists.infradead.org; Mon, 01 Jan 2024 21:00:27 +0000 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2ccb4adbffbso72902911fa.0 for ; Mon, 01 Jan 2024 13:00:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704142823; x=1704747623; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G+XZ4nybj4bZroxHF/K5QreEHMx55uD+jWsZAAJ9ETE=; b=W65TWYPpolxxgkkiZEKMFnXBlpAd2DAOUcq4U3MGXh6CF/GXkd19Z4Wv/2Q4edU7ET H9PsToqP/6m0oa4b3llggPNXmxQRcJVzqNVlRCKLW+reMXnU1dtPAHbDlRt6Qrb3vx5i yp7yFLRwdlQ9WWAmu6Z3NIsftVZ7cI2HbQWwyUjHSLUTCqz9jzotYvSQQWswI6wZsayi 0+1BZWTdsscpPL3qxDd2v/39bZRqeyp006nhCp2XayzaZ6qOmS+SxdOJx8Mla4yaY7mP rHN9kPw3lcYHqEugrWW877beKhk0bk9jHCxq0YdwldoUzAOUFaavwPHOCWqzzp1PK6eD KVdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704142823; x=1704747623; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G+XZ4nybj4bZroxHF/K5QreEHMx55uD+jWsZAAJ9ETE=; b=n0mWGH8NinD3Wjs6YHVAnOBuk2Bf76NdVtpRRIkYofiSd94/uwTDdxK8hjuSST2f46 KJVCixklGJpHlQfLSceOW1zm3yJs/PDEI3fK//ngn4A51lk4Cswpphwi59eunBCmm6P5 px6wzVIXps8+BjXFYQTpLJ/H8z7RCWSUIKvp/GLg3U7TkjnWtiI8FID9b66jnK/trt2l c8V38s/W4+d1HyYFrHQaEPWD8sjYCbaZ2aQf0UxhQmtgU4GIPU/6zrIOfKtO+n9bobIf 5N08n+aw+8IrsjSCyRKAJhuEfC5NI+pVXR/Dv7sPpk17TpdPdGmkjTPUoeAUJJN4lzXI 42Sg== X-Gm-Message-State: AOJu0YyMAbsKeyvpmSVeGBsMvgxWGl6N7udWQCY0kwG9AOMwLbWu7wS0 /4KfxJJV4/FzRNOlGagsW7k= X-Google-Smtp-Source: AGHT+IEyt54Orz1g1iSdDIT58gjh8S+dJZUEQWPhmkpP2Zw9GRBQBsp4FnO+/E+W4japXdG6IOsJrg== X-Received: by 2002:a2e:a229:0:b0:2cc:df75:79b3 with SMTP id i9-20020a2ea229000000b002ccdf7579b3mr3727095ljm.12.1704142822801; Mon, 01 Jan 2024 13:00:22 -0800 (PST) Received: from hex.my.domain (83.11.207.119.ipv4.supernova.orange.pl. [83.11.207.119]) by smtp.gmail.com with ESMTPSA id i15-20020a05640200cf00b0055404e08589sm15122045edu.85.2024.01.01.13.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 13:00:22 -0800 (PST) From: Artur Weber Date: Mon, 01 Jan 2024 22:00:15 +0100 Subject: [PATCH 1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd MIME-Version: 1.0 Message-Id: <20240101-tab3-display-fixes-v1-1-887ba4dbd16b@gmail.com> References: <20240101-tab3-display-fixes-v1-0-887ba4dbd16b@gmail.com> In-Reply-To: <20240101-tab3-display-fixes-v1-0-887ba4dbd16b@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Artur Weber X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704142819; l=781; i=aweber.kernel@gmail.com; s=20231030; h=from:subject:message-id; bh=kgQ6hReH0wzI/acEF9QXTsrDq3bCAXF+wc7FhUZWg+4=; b=7ohf2QoqecR3WiauAHzQUR3+ckbuzk8rHVISPaWwZek5KfK2snxhjEVFaYXEd/XhZKmMWgcbW mL7cAAnGc+uCDAIE86dOdGOy9C0Y9j499m3IgkJ5UnsF480rkJKSsaU X-Developer-Key: i=aweber.kernel@gmail.com; a=ed25519; pk=RhDBfWbJEHqDibXbhNEBAnc9FMkyznGxX/hwfhL8bv8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240101_130025_086259_46518D46 X-CRM114-Status: GOOD ( 13.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org After more investigation, I've found that it's not the panel driver config that needs to be modified to invert the data polarity, but the FIMD config. Add the missing invert-vclk option that is required to get the display to work correctly. Signed-off-by: Artur Weber --- arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi index d7954ff466b4..e5254e32aa8f 100644 --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi @@ -434,6 +434,7 @@ &exynos_usbphy { }; &fimd { + samsung,invert-vclk; status = "okay"; }; From patchwork Mon Jan 1 21:00:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Weber X-Patchwork-Id: 13508716 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7194AC47073 for ; Mon, 1 Jan 2024 21:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UVyz6V65mF6FKZzpL0foJTlY+qN0tUmTXWW2i++2nJM=; b=bPWeB32Dt8QOpD 3wLgriJjBqb6/7mCW8tph3MqE0mQJ6+277IgxipEsazAvXHe18PkmYeVsvyITcFX95qSrjiN1SWkw IXleEbgJD4nj1ZcRwqIpHLZ01Aiu2lnm7Iieeih//kP1noNMQvQUGNa3AxlAyYubqOxhuyZ/3ThL/ db8SlqXeXCqRGVdgqrPdslyWYBmEM5yOA2itpvHv+OHMfAonPoAAdgjXn2oMZQhwybmw3j625uvI/ OCEfxBUgTAEjmU9udpT7+SpaSozb2GLM3Tyuz3cVSN5Yz7jbT2U6geWXmGI4UEfSpZuxzGgH2HkIV AOqys/b3iPyqEz6eaGRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKPOg-006iyP-0C; Mon, 01 Jan 2024 21:00:30 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKPOd-006ixE-2Q for linux-arm-kernel@lists.infradead.org; Mon, 01 Jan 2024 21:00:28 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-50e7c6f0487so5510804e87.3 for ; Mon, 01 Jan 2024 13:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704142824; x=1704747624; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZKO7t2hG9wQZbOuOZ2OBdmSsh90rgqQlCZCF6Y6YFcg=; b=YKZ5FLILYCS8R2cA9CuTLCnSyGSa444NFPekrvtgcq734FT/LiPcR2Pkf3nLMDaxc3 CH8e3rbWtzpHP13h4opKl5y5lBLqeP2CVCsxcGwBfnp6m0AGD9VYwJIzwzGJCIh3wvo3 BEFiwbv6JL9/nmCNPbLSi6vcbObdUBvP3GnhlZ0cxtS9hJwLIhPK1qsTstCwsHjRq7+Z DRwQOEyGn3/nSM2hNUWeICgUq/bBCGb+HbWIIZbiAP6kXQOoIMK+Fe6LW35nmyHo6rOz GLJus/qxO66VhTeni53+68SQdj8cibcCOEBQ4cCyugHq5/tPzqYq9dNLA+fWCrZ3zWAJ sAUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704142824; x=1704747624; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZKO7t2hG9wQZbOuOZ2OBdmSsh90rgqQlCZCF6Y6YFcg=; b=ByROVYZoRyf2IQVapm04Kz1AElxLdMwZOmiB7nfSNU2/Iuu9LVuy+nPMr63pt0kHUM sq08vI5GhIuhGX80etlbo61ylY/nJefAl5hNLcwkiax4piAXtUpRUC0zJlkGCpZCKqLR 3+PvF81H+xFmjjM+2s5qAEcAVE8RIrLMSqIhtEJ0+mZsBopJB5Xp1gnzj6qL1p44ZGhA TrtWF5MP4yd7UXBDdHazY8dttfApMICq3TkXqD76swg+HKdQd9el78QkYNxB967Yvjmd X1vipLticVQRdX0R7N6nwatbIaNcfIA2fk5G+Mzr0Y8hOVdGdkg6XaZSGLbMFZIRc7Jk 1u2w== X-Gm-Message-State: AOJu0Yzmnc9TcPiT416yyGNrnd4yJbP0PvVLQFHERuEyBh94AsKWoWmi KiYSWS40jiWm2TbByzZdHeY= X-Google-Smtp-Source: AGHT+IE86fSR+lttAonljpboKktMB8Ji41vcG9rV4MNjyxOno5Zp8U6svFT8fnkFNZxZ561m0wvtBA== X-Received: by 2002:a05:6512:33d5:b0:50e:7e1c:9049 with SMTP id d21-20020a05651233d500b0050e7e1c9049mr4083434lfg.70.1704142824646; Mon, 01 Jan 2024 13:00:24 -0800 (PST) Received: from hex.my.domain (83.11.207.119.ipv4.supernova.orange.pl. [83.11.207.119]) by smtp.gmail.com with ESMTPSA id i15-20020a05640200cf00b0055404e08589sm15122045edu.85.2024.01.01.13.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 13:00:23 -0800 (PST) From: Artur Weber Date: Mon, 01 Jan 2024 22:00:16 +0100 Subject: [PATCH 2/2] drm/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02 MIME-Version: 1.0 Message-Id: <20240101-tab3-display-fixes-v1-2-887ba4dbd16b@gmail.com> References: <20240101-tab3-display-fixes-v1-0-887ba4dbd16b@gmail.com> In-Reply-To: <20240101-tab3-display-fixes-v1-0-887ba4dbd16b@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Artur Weber X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704142819; l=1047; i=aweber.kernel@gmail.com; s=20231030; h=from:subject:message-id; bh=pg28sLvX5GdC5bOF/yyzGASGCCoIgKs1qHIpKvHG7pQ=; b=V1bj5lEkTVkRcuqmS/0vog/IRKcLOnQ/VyKrfKyWkMBtEXBwTIYRhz1D8Isd2VzvjtsLbDXb0 DvkWU1R5FlRBed5qaJ/SpcpwyEMKCETBnjzMpeIDR9/2JAqKyROVfsf X-Developer-Key: i=aweber.kernel@gmail.com; a=ed25519; pk=RhDBfWbJEHqDibXbhNEBAnc9FMkyznGxX/hwfhL8bv8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240101_130027_788561_4B4A7F60 X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It turns out that I had misconfigured the device I was using the panel with; the bus data polarity is not high for this panel, I had to change the config on the display controller's side. Fix the panel config to properly reflect its accurate settings. Signed-off-by: Artur Weber Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c index ea5a85779382..f23d8832a1ad 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c @@ -309,7 +309,7 @@ static const struct s6d7aa0_panel_desc s6d7aa0_lsl080al02_desc = { .off_func = s6d7aa0_lsl080al02_off, .drm_mode = &s6d7aa0_lsl080al02_mode, .mode_flags = MIPI_DSI_MODE_VSYNC_FLUSH | MIPI_DSI_MODE_VIDEO_NO_HFP, - .bus_flags = DRM_BUS_FLAG_DE_HIGH, + .bus_flags = 0, .has_backlight = false, .use_passwd3 = false,