From patchwork Thu Jan 4 01:01:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 13510705 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CBA71851 for ; Thu, 4 Jan 2024 01:01:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ZW2UUTZo" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d4d5b37670so19015ad.0 for ; Wed, 03 Jan 2024 17:01:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1704330078; x=1704934878; darn=vger.kernel.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=2IhGejtn+iaMOhhsmXwg30hKf0llnx8ljjscuCmMfk0=; b=ZW2UUTZomA7HeMcRnrziOisjSA6428fW1ivZVwVk3oHrnOdVLDiAKbHSgeA3+n7lNR qe2xhz3bT0kKzuTv7mSh1y5VSUe3jNl8mOKBWmwyH+Y7v16bhwxcmOTWvuYcavh1PtwN Kwxjhp1eixePttYYR7VmWyC4F2BH6lmNc08Yo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704330078; x=1704934878; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2IhGejtn+iaMOhhsmXwg30hKf0llnx8ljjscuCmMfk0=; b=qj34vwAsBx1GDKEa07LD5nm0uchhs1lTB+k+FnZeIaLiIeaVt5btDyvmsLlIlmdvPI t/Nuj7XPrF8KjM3ZR5HR8mbjfygxaDm3mitqqDPUSvdJIBpj0HqMPsgknd5OSGqiMiY3 gQ8iE8kQoki9j+sCUMRe7dDuSKBOnhPKYm2wDTxl+7Hz/KzMS4T4FruZupW8RJenSnrE WVxg164ufD9nb9T/g2U+kK+KaSVEatIspCqb7gIRKuwy6Ec5DYiqZTie78NKjVPoCTBN EiqD0KI9loauR6xoqg2N+m8KDyQryiWOaa4ltNuAwn6NaZN+qQc/2Pmxjknnj4DyV0Ay 10/A== X-Gm-Message-State: AOJu0Yw6PPCBA8BEjdoqgwiN+xSIctVNOZFrhLRjJetsSEJ45qlXCSPC hkXMKpGoD+Pk1w3X9xdwMvlPuwJBulbd X-Google-Smtp-Source: AGHT+IFV//mAWdUojtyRTdIpA8EnXTCnt7iFC7Mb1OH9PPgxW+fxqTehlqgNCyuRMnw4v0M7K+OecA== X-Received: by 2002:a17:903:41ce:b0:1d4:53cf:fb99 with SMTP id u14-20020a17090341ce00b001d453cffb99mr8372563ple.24.1704330077422; Wed, 03 Jan 2024 17:01:17 -0800 (PST) Received: from lvnvda5233.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id z7-20020a170902708700b001d495ec2cdfsm11038571plk.33.2024.01.03.17.01.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jan 2024 17:01:17 -0800 (PST) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com, arnd@kernel.org Subject: [PATCH net-next] bnxt_en: Fix compile error without CONFIG_RFS_ACCEL Date: Wed, 3 Jan 2024 17:01:08 -0800 Message-Id: <20240104010108.41100-1-michael.chan@broadcom.com> X-Mailer: git-send-email 2.32.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Fix the following compile error: .../bnxt.c: In function 'bnxt_cfg_ntp_filters': .../bnxt.c:14077:37: error: implicit declaration of function 'rps_may_expire_flow' [-Werror=implicit-function-declaration] 14077 | if (rps_may_expire_flow(bp->dev, fltr->base.rxq, | ^~~~~~~~~~~~~~~~~~~ bnxt_cfg_ntp_filters() is only used when CONFIG_RFS_ACCEL is enabled. User configured ntuple filters are directly added and will not go through this function. Wrap the body of bnxt_cfg_ntp_filters() with CONFIG_RFS_ACCEL. Fixes: 59cde76f33fa ("bnxt_en: Refactor filter insertion logic in bnxt_rx_flow_steer().") Reported-by: Arnd Bergmann Link: https://lore.kernel.org/netdev/20240103102332.3642417-1-arnd@kernel.org/ Reported-by: kernel test robot Reviewed-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 827821e89c40..8f10ab4d4a43 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -14059,6 +14059,7 @@ void bnxt_del_ntp_filter(struct bnxt *bp, struct bnxt_ntuple_filter *fltr) static void bnxt_cfg_ntp_filters(struct bnxt *bp) { +#ifdef CONFIG_RFS_ACCEL int i; for (i = 0; i < BNXT_NTP_FLTR_HASH_SIZE; i++) { @@ -14096,6 +14097,7 @@ static void bnxt_cfg_ntp_filters(struct bnxt *bp) } if (test_and_clear_bit(BNXT_HWRM_PF_UNLOAD_SP_EVENT, &bp->sp_event)) netdev_info(bp->dev, "Receive PF driver unload event!\n"); +#endif } static int bnxt_udp_tunnel_set_port(struct net_device *netdev, unsigned int table,