From patchwork Fri Jan 5 06:53:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Weber X-Patchwork-Id: 13511734 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 531C8C3DA6E for ; Fri, 5 Jan 2024 06:53:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DFBA610E57C; Fri, 5 Jan 2024 06:53:19 +0000 (UTC) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7717E10E56E for ; Fri, 5 Jan 2024 06:53:17 +0000 (UTC) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a27e323fdd3so128511466b.2 for ; Thu, 04 Jan 2024 22:53:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704437596; x=1705042396; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Gs6Zdo5lqPMyDcy2Y9AErHFR4G8ZNcqDUY2nx2C99rw=; b=GX5SvvLj+4yzAIT9OEs2O23F3P9YRYBh6GX7DggL2LM4rHQ4qoII+NdhJK6w6u0FoJ QDA9KpjoZ3QCMihT/zfoRhbMIQEk5d7TFTrWW2elhogfZugMW4+2AHyhHh3raGcMRz95 wbWhCtREVelcZxS20lhnEN6pRITOLwbl2GHRdEKd50cKg4qcSW2KvtkYHG2TKdzBooNM 6M35zLvn76XnzIqIjJdCUI7v6tqQHc4HBjQPupv976VG1VfrXPp/IqSMD3BGa9gdds60 PmHfBTjdjco88dApyWRDzRobnd/7B6Zq3VK4CmMp+fITtPzXcDsK4x26mz1n02Fkg+E0 zOwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704437596; x=1705042396; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gs6Zdo5lqPMyDcy2Y9AErHFR4G8ZNcqDUY2nx2C99rw=; b=lK9cRgTIhDhuJumip82XAu+ccjMe+Y+jLBNaI0cLzAhaXg53Ws0QvRgoCDSPMxwEpH KS760+Yu/OIWtrY4FmHr5GNrgPEX5qXoOsQmyq6DeQ8319hXpoMf9F+rJadsdsSbQHAI zyrWEsks7EOplMHIBp9zcZBdsjK+FX6r7aqBXgAv2bCtPBs/m7O7WkiiiZzQ3ivGCnS+ zRMInsJO2yhbgxmnW1cBaWGti+pT6wC/Xtvfc+BH0AN7o4a2Z8E4m6xADs+X/AhspRwJ GbvPBjB4j3ZwZ06MQbL2T1bpD/UTDJOCqnwdUl5+CBbeWjasstlOtij59qF+nsvjTP3b 7YKQ== X-Gm-Message-State: AOJu0YzmypLfkhryjmKgNOA3PsD6mcZtGtBo5ZMHlsIXhkkzSFWN/vyZ 4+zGkEa79wmFWaaI0VbchJs= X-Google-Smtp-Source: AGHT+IGK9xkg0CCNYNDKzTYncS8IxaFYD6jd3LQSs6N1y6nKezYqqpIO5ypVgZmxqvaMktFrE99/jA== X-Received: by 2002:a17:906:c55:b0:a28:77b:bb36 with SMTP id t21-20020a1709060c5500b00a28077bbb36mr797610ejf.134.1704437595580; Thu, 04 Jan 2024 22:53:15 -0800 (PST) Received: from hex.my.domain (83.11.207.119.ipv4.supernova.orange.pl. [83.11.207.119]) by smtp.gmail.com with ESMTPSA id g23-20020a17090669d700b00a28e2b72db2sm518809ejs.56.2024.01.04.22.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 22:53:15 -0800 (PST) From: Artur Weber Date: Fri, 05 Jan 2024 07:53:01 +0100 Subject: [PATCH v2 1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd MIME-Version: 1.0 Message-Id: <20240105-tab3-display-fixes-v2-1-904d1207bf6f@gmail.com> References: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> In-Reply-To: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704437592; l=860; i=aweber.kernel@gmail.com; s=20231030; h=from:subject:message-id; bh=Hj/KIXM8+wrf3C6zb6NPg6hk9u+G2N6Miq9I309cmwA=; b=y9TBDXAW40WhQZ9RyljbqE9HKhzBXZ64rvQTNoPAID3ula15xCJhQhW/2iksx6g5BkUiOZ9Zd PdpWEQ9LjCzDZWJLsH+POGdfXFFhAi1McL/WcJTJJjyZwgTczWGXKVr X-Developer-Key: i=aweber.kernel@gmail.com; a=ed25519; pk=RhDBfWbJEHqDibXbhNEBAnc9FMkyznGxX/hwfhL8bv8= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Artur Weber , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After more investigation, I've found that it's not the panel driver config that needs to be modified to invert the data polarity, but the FIMD config. Add the missing invert-vclk option that is required to get the display to work correctly. Fixes: ee37a457af1d ("ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards") Signed-off-by: Artur Weber --- arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi index d7954ff466b4..e5254e32aa8f 100644 --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi @@ -434,6 +434,7 @@ &exynos_usbphy { }; &fimd { + samsung,invert-vclk; status = "okay"; }; From patchwork Fri Jan 5 06:53:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Weber X-Patchwork-Id: 13511733 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE005C3DA6E for ; Fri, 5 Jan 2024 06:53:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AACC10E56E; Fri, 5 Jan 2024 06:53:19 +0000 (UTC) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F33910E56E for ; Fri, 5 Jan 2024 06:53:18 +0000 (UTC) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a28b0207c1dso100982966b.3 for ; Thu, 04 Jan 2024 22:53:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704437597; x=1705042397; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gN9G9Kb0Ei3BRgzRKo9RDwtoeSks6/gH2+/hiv2p4q0=; b=I1EDux/M9VFH0XtfkZleVk9y5xowUtrqq5uKaRjhkZ+0wZ8ALDA95Y1iAsZHpm1MIJ mkOz+DZNUwZppjNghpNkXZUrgEa9MnU8PlwJMaPGdKdzMDrkk7ydaojthqtRdpOQQLK4 0xJBTpv8KVttHTxccIXCLhRNm/8rtXA4WaEbMMUqhu4NpWA/SBC7BMY0fdU8mgpkOJHa AZtyZ72FeXmDyLz4gwUWH/5AAtkZQWvlZnvy3wgdfPK54lZD1/R0WutUnUW/WgRnEM+0 we0ICpIxSVKOk3jB6BJVLwmLiZqcYpFwSrwQOR0FLwAZb3YDO7OyvF08cXgMziGqkT+I aFHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704437597; x=1705042397; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gN9G9Kb0Ei3BRgzRKo9RDwtoeSks6/gH2+/hiv2p4q0=; b=o+KKvlgioIRfuziXCkyn77MJnR/QZlG/qWHdISvK10kwZrqQuMC3p1O9+vd92BbuR9 aFmQ+W7PTKCqbGDbu2v2mtq1TsNaOUL5eUzgKoRNYoBbSCHpw18VCjHSsulznVn9ECVE 4P2mBjXrkaPp6nSxnZnlXcGm+durx3M/qKgYEpmW3nYc22dlHjRG4kQcmzn11SzM7TXx R6Yp09YHTJClUNH7o/n4SJISuNqu9vtCvCJ0OOG9XdfdbZyGUnFjl4MksTcK9RUdQR1w fptZTxuVNV0mJ615w5wTat1oO8lsuC3HfVMC7kNJC3harG8ElbpQ5oFxXgIOmIXIQrgS WAXg== X-Gm-Message-State: AOJu0Yxb/W7gYtkm8bIn7ng5LTEnlPz0tT0V3KGWNSHFzsR1VT49YbOQ PxeuR5G9Uf/m8YZwqXCWwFw= X-Google-Smtp-Source: AGHT+IESYsMQvwgG8Vjc2evgLPbZfxJkSk1hOrSDFtYcr8hG6M1PSfHIVVY+DSWVNgmznTt1z7F9yg== X-Received: by 2002:a17:906:fa0d:b0:a18:4b1b:9522 with SMTP id lo13-20020a170906fa0d00b00a184b1b9522mr921754ejb.41.1704437596911; Thu, 04 Jan 2024 22:53:16 -0800 (PST) Received: from hex.my.domain (83.11.207.119.ipv4.supernova.orange.pl. [83.11.207.119]) by smtp.gmail.com with ESMTPSA id g23-20020a17090669d700b00a28e2b72db2sm518809ejs.56.2024.01.04.22.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 22:53:16 -0800 (PST) From: Artur Weber Date: Fri, 05 Jan 2024 07:53:02 +0100 Subject: [PATCH v2 2/2] drm/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02 MIME-Version: 1.0 Message-Id: <20240105-tab3-display-fixes-v2-2-904d1207bf6f@gmail.com> References: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> In-Reply-To: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704437592; l=1183; i=aweber.kernel@gmail.com; s=20231030; h=from:subject:message-id; bh=zbV+r29VU46Ob/u8YrKcYcH1MdK6Qsp4rJGmvF1IAUs=; b=VrgBYBiZXrQxVeRGeUJTG5/9Lpc//qRFKYcfsvWONuxI8I4GIlZmC0QPmRikzgvYRGQ5U8gLD rcnhxSXRzcoD/ck0/wclvhBbGoIp3yABok93VCTPc8c70RJYq0/NkNd X-Developer-Key: i=aweber.kernel@gmail.com; a=ed25519; pk=RhDBfWbJEHqDibXbhNEBAnc9FMkyznGxX/hwfhL8bv8= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Artur Weber , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It turns out that I had misconfigured the device I was using the panel with; the bus data polarity is not high for this panel, I had to change the config on the display controller's side. Fix the panel config to properly reflect its accurate settings. Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver") Reviewed-by: Jessica Zhang Signed-off-by: Artur Weber --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c index ea5a85779382..f23d8832a1ad 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c @@ -309,7 +309,7 @@ static const struct s6d7aa0_panel_desc s6d7aa0_lsl080al02_desc = { .off_func = s6d7aa0_lsl080al02_off, .drm_mode = &s6d7aa0_lsl080al02_mode, .mode_flags = MIPI_DSI_MODE_VSYNC_FLUSH | MIPI_DSI_MODE_VIDEO_NO_HFP, - .bus_flags = DRM_BUS_FLAG_DE_HIGH, + .bus_flags = 0, .has_backlight = false, .use_passwd3 = false,