From patchwork Fri Jan 5 06:53:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Weber X-Patchwork-Id: 13511736 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD9B5C3DA6E for ; Fri, 5 Jan 2024 06:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Bsh4cDoXaCpUpHd7MtBASBhm+p/ezyvwwoZszYWbtI=; b=VOyl6RNzgKvAKh EJWzp259tLpmfU/mOTvP3AJES+NltM+JWXRl/JsQmWRiiOvtXEshesnb/cJljKDY5NoKb2/mLLOEb 0pRxdUlW/CSEtqqSABipvzf2WnJ2sCP25G7TU2qzjz2/W5ZW7Ge7YWI/K+u6LIRRvrIADy7iTebnS UJbBS3zcGW9unvZGpLuR0md/9eJbDTIkAEVpcTafoDVdF2bDR33CNozwu/N5AWqRYDV7bzuEf7WzK rEXnxhSyeqZ9Gs8jlmbm2ub0aAemlVP4yjxof9GLt7zV4gtDacLHk6Yd9IaGGpG13BYzAHcmJn56V enP06QzH4yIe7PMRldPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLe56-00G60Y-2B; Fri, 05 Jan 2024 06:53:24 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLe51-00G5yV-2H for linux-arm-kernel@lists.infradead.org; Fri, 05 Jan 2024 06:53:22 +0000 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a26fa294e56so129022166b.0 for ; Thu, 04 Jan 2024 22:53:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704437596; x=1705042396; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Gs6Zdo5lqPMyDcy2Y9AErHFR4G8ZNcqDUY2nx2C99rw=; b=B6QMMIEVr1NiiJq8DURyBwIkTEgKz/d7oFKm32XLP2zViVgGiPMYwqngUp1UOOLu+a VhBEFYVrDhcM3CSIGAR1qs0iQbRfoL0QAu7nICWali2/Jh8JkkLUr7Z8F/n7+4CUxJvy 81OSm84tlxBJMj8YDEuyJDubGif/jTViCIrf6frKyHQVcVfSNscp+Ul4J7CLTxeDqI2n lLi3FcWkK+nH1CQPoNosVTzM7FPh53stP1TI2DAfr4/rq2tiZCNz7KY9h3LLX+8xG8r7 5ERHiQ/Sb46RLBv0xNCOj/hD3cBLL2MhGasfwqZM7NfP/QpNo2rWLC/zP5oNb84ydo5A fChA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704437596; x=1705042396; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gs6Zdo5lqPMyDcy2Y9AErHFR4G8ZNcqDUY2nx2C99rw=; b=cvpGLvoTsXs1cVF+BqlJfDm16a/ZaicN/ZSsSgkR/UsTxp7cGdSN67x4f9a8Orpjh0 eGRqOSKfIeqeJlm0bOl8qTtppS5bmJidZ08ZwiNjDsaMEjDG0o82L7aLqk55oKXB3xt2 UO8CgvkwWkoVZPdfJX4u/uAM8jnrLpCduGGTIqq61o3qqoQiH+lXcSG/UfX93WOVzaLp rdBntwDnzfg3Y3cD2btAEHdyCRsm9AB5RnQAGZ5PRZIPFx96QZFi4xKHieaKJyfjSwRD cf9jd49F6FOt6ceMDMKoZ56BgdcVPyUxoJmR+JU6Cpe+mEavqeuJov15bnnpU7FFXsZz oiJg== X-Gm-Message-State: AOJu0YwxZyw1bVwI3womvrcFGwuQtlQDZyBC5dZGfmp/103p1ifm70ea ciXc4aIojTMTc64j0GE+mH0= X-Google-Smtp-Source: AGHT+IGK9xkg0CCNYNDKzTYncS8IxaFYD6jd3LQSs6N1y6nKezYqqpIO5ypVgZmxqvaMktFrE99/jA== X-Received: by 2002:a17:906:c55:b0:a28:77b:bb36 with SMTP id t21-20020a1709060c5500b00a28077bbb36mr797610ejf.134.1704437595580; Thu, 04 Jan 2024 22:53:15 -0800 (PST) Received: from hex.my.domain (83.11.207.119.ipv4.supernova.orange.pl. [83.11.207.119]) by smtp.gmail.com with ESMTPSA id g23-20020a17090669d700b00a28e2b72db2sm518809ejs.56.2024.01.04.22.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 22:53:15 -0800 (PST) From: Artur Weber Date: Fri, 05 Jan 2024 07:53:01 +0100 Subject: [PATCH v2 1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd MIME-Version: 1.0 Message-Id: <20240105-tab3-display-fixes-v2-1-904d1207bf6f@gmail.com> References: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> In-Reply-To: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Artur Weber X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704437592; l=860; i=aweber.kernel@gmail.com; s=20231030; h=from:subject:message-id; bh=Hj/KIXM8+wrf3C6zb6NPg6hk9u+G2N6Miq9I309cmwA=; b=y9TBDXAW40WhQZ9RyljbqE9HKhzBXZ64rvQTNoPAID3ula15xCJhQhW/2iksx6g5BkUiOZ9Zd PdpWEQ9LjCzDZWJLsH+POGdfXFFhAi1McL/WcJTJJjyZwgTczWGXKVr X-Developer-Key: i=aweber.kernel@gmail.com; a=ed25519; pk=RhDBfWbJEHqDibXbhNEBAnc9FMkyznGxX/hwfhL8bv8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240104_225319_747002_86FB1F34 X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org After more investigation, I've found that it's not the panel driver config that needs to be modified to invert the data polarity, but the FIMD config. Add the missing invert-vclk option that is required to get the display to work correctly. Fixes: ee37a457af1d ("ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards") Signed-off-by: Artur Weber --- arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi index d7954ff466b4..e5254e32aa8f 100644 --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi @@ -434,6 +434,7 @@ &exynos_usbphy { }; &fimd { + samsung,invert-vclk; status = "okay"; }; From patchwork Fri Jan 5 06:53:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Weber X-Patchwork-Id: 13511737 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69A06C47077 for ; Fri, 5 Jan 2024 06:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ax3/EyEuF1gy5HmpEYNCIuJVaDyBx2pefzzZfvDpWbA=; b=Va1HvXsOQ6iqrf yZXovcQwQ+kosTz2tnhmgNzn6gFV8EcL0CyE1fY4BPXkGzt+GYrZrRW+vpqROI09P1VjZMWAKxUMA fsZ1HVSz8plNlSKs4ZXtgf2JmFSQAamHhOxSTIYCnYUYy8ANk9TNQZ/EfkIcmVU4BKdDcraNdL+Ri KhU9cqGLa25g/lIzw6OVKxxs+KkQHqHpEFRVgeDql/pjnde9NBfdA9rMy1hvSJXWkzCoDcGroJ/Bn q+wQ5R70ynF8mSEUC2y7KuwrlZf46PeWVYaDXfHnc/JqYV/S5Atq+NWFUWr0kEypjH5DEtzgXg38n In8vIFuQRD/G5CEZvcRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLe55-00G5zy-02; Fri, 05 Jan 2024 06:53:23 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLe51-00G5yW-2G for linux-arm-kernel@lists.infradead.org; Fri, 05 Jan 2024 06:53:20 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a28a997f3dfso101383066b.0 for ; Thu, 04 Jan 2024 22:53:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704437597; x=1705042397; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gN9G9Kb0Ei3BRgzRKo9RDwtoeSks6/gH2+/hiv2p4q0=; b=MsewIihcuycj3lqAllggTJWIw3L8NBRFV5W+4x2CTfutDf+uGfy53h7Z/zYfbCUbNF j1528KK+I/9jkR86j1ICXpCIMzd1v1UfcNx1saXbGlA9GvDJsL4/CXdGsszjtnMsbEFj MFm71CEE3tPBzoERnwch+z6sGpv2OpHHt7ItXqPa6dHrcXr585hGcyhROscE1VOr+gGo T3JdP5cU/V6XYeH21KqtlqZ1iL4/UMvGanM17B30gRtCEzpKIrr+Cn+x+2Wx5HgZZIOd 0BiQmQU9Gp3aK4ivHrvEJ4myJjN89YtLh9ExjPdNPbCmWHcrEwjHeSY44+BnB5a6N8Dc 2cGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704437597; x=1705042397; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gN9G9Kb0Ei3BRgzRKo9RDwtoeSks6/gH2+/hiv2p4q0=; b=Th8HgZzJjfwzBkJUmsQ2TfN1PyJ2ieExq+JpDsh9IoXjh1znVK/MvEyXF7ygNTe8dA D/g2VRCfC6W/quTXQ4vYOlBexzwKZar6hD4r5/tiTR7AiFlX5BoXb0FMSGMbiX+xKLyQ YVtiryq1xmgXVR/l+NsE5zoQtStyPTRjcKqp0yJnD3cqei9caLzeGdm9bklg4x5pYsBx oi+domUnuFPrDAmymTX1WfA6QqR2Mc0fKqsb+H7P1xZww3fJHXy1IY4mxr3Cfw9OT3U8 pp68fNA+PJl1jVLYv8iZy2vrw+RF9KuZTuzt6fKi/k/p0yK69h5TkMiDJTJxdLyO7lFC 0izw== X-Gm-Message-State: AOJu0Ywb2M7jL1IZ8XJfwUOZkyKUuY81LL1S3CGVDB127SECjaXpEeJn l8XZ8ApEUfr8U4FLEw3g7onRyB5ShGU= X-Google-Smtp-Source: AGHT+IESYsMQvwgG8Vjc2evgLPbZfxJkSk1hOrSDFtYcr8hG6M1PSfHIVVY+DSWVNgmznTt1z7F9yg== X-Received: by 2002:a17:906:fa0d:b0:a18:4b1b:9522 with SMTP id lo13-20020a170906fa0d00b00a184b1b9522mr921754ejb.41.1704437596911; Thu, 04 Jan 2024 22:53:16 -0800 (PST) Received: from hex.my.domain (83.11.207.119.ipv4.supernova.orange.pl. [83.11.207.119]) by smtp.gmail.com with ESMTPSA id g23-20020a17090669d700b00a28e2b72db2sm518809ejs.56.2024.01.04.22.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 22:53:16 -0800 (PST) From: Artur Weber Date: Fri, 05 Jan 2024 07:53:02 +0100 Subject: [PATCH v2 2/2] drm/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02 MIME-Version: 1.0 Message-Id: <20240105-tab3-display-fixes-v2-2-904d1207bf6f@gmail.com> References: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> In-Reply-To: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Artur Weber X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704437592; l=1183; i=aweber.kernel@gmail.com; s=20231030; h=from:subject:message-id; bh=zbV+r29VU46Ob/u8YrKcYcH1MdK6Qsp4rJGmvF1IAUs=; b=VrgBYBiZXrQxVeRGeUJTG5/9Lpc//qRFKYcfsvWONuxI8I4GIlZmC0QPmRikzgvYRGQ5U8gLD rcnhxSXRzcoD/ck0/wclvhBbGoIp3yABok93VCTPc8c70RJYq0/NkNd X-Developer-Key: i=aweber.kernel@gmail.com; a=ed25519; pk=RhDBfWbJEHqDibXbhNEBAnc9FMkyznGxX/hwfhL8bv8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240104_225319_738932_B1E7E11D X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It turns out that I had misconfigured the device I was using the panel with; the bus data polarity is not high for this panel, I had to change the config on the display controller's side. Fix the panel config to properly reflect its accurate settings. Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver") Reviewed-by: Jessica Zhang Signed-off-by: Artur Weber --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c index ea5a85779382..f23d8832a1ad 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c @@ -309,7 +309,7 @@ static const struct s6d7aa0_panel_desc s6d7aa0_lsl080al02_desc = { .off_func = s6d7aa0_lsl080al02_off, .drm_mode = &s6d7aa0_lsl080al02_mode, .mode_flags = MIPI_DSI_MODE_VSYNC_FLUSH | MIPI_DSI_MODE_VIDEO_NO_HFP, - .bus_flags = DRM_BUS_FLAG_DE_HIGH, + .bus_flags = 0, .has_backlight = false, .use_passwd3 = false,