From patchwork Wed Jan 10 10:20:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515894 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C19BAC3DA6E for ; Wed, 10 Jan 2024 10:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=evIIvHROwJnKePlstudqW4pihkk1jxMI9orsb5xDmB8=; b=F+MUcazsn8Z6d+ BiM9QZs95W9PKUA53kzMF+QZQtziPSV+fyc8a9EYaHEBuUrScjijCXua+N361bxov7wlxfN53Pv1U aUYCjxiP2+2ehVYnalPyS3uOjvCkLmBCqN1KjFtVwqp1JAhp8F8hKvoZv40qGmZP6btMy8xLP0QVU vkIY/1lMxBJIsFNvoGsyDg8tkbslwiQTRMJ8hD387JnMyVZo58dqo/TA5ASJvG3p5RYGD+N00iswK 5cCwyqED8+WhyctgYGUdmbHh1nIYOFT0Ya9pET/1X9drBmgEq2YslgTPGdIfVmzHRkN1w7w0H0Fb0 NAwQG5JaJsrjbR5d49CA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNVhy-00Azzh-0d; Wed, 10 Jan 2024 10:21:14 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVhu-00AzvQ-0C for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:11 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40d4f5d902dso42002685e9.2 for ; Wed, 10 Jan 2024 02:21:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882068; x=1705486868; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a/c7oDT8RKSeNrIFhGqJZw8sJoinUsXp+DaHWK6w1PA=; b=rc6lNtS8QOAcst6mluYdk5JdA+SNpEwYZSuUDXYtVaXWKYn4N1U0LtNTrTffuf2eqV VGTz/7TKr1yUVM+bryRJSjPYcH1z0VUHza4l6SQATxehgJiMpLHqkU/156aebh3y+QwA SWbOvMuzf1VaXMuO04hVQFljOu/3lpNhjF5mfMy7m2Y3Wu5FWyHYt4+woXUENPzbFE+0 Vetb3qwYuv4b7aNnWeAP6ba+Ip9xDW6hcGjoqePPzx/E4L+Z7jJU8AfBBUY2axjczUBg khMHFgiNFyb4Iab9HcXPypz/LZoGWFQwV8WkJOQKtQOcL6MVaOpFuFdIAjoOxbyXV6HQ +WVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882068; x=1705486868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a/c7oDT8RKSeNrIFhGqJZw8sJoinUsXp+DaHWK6w1PA=; b=N/MbDq571GFJxszrrfGjHrM1j4+oVfv8Qsg8UeBaKY1LEvJO3/sdjJV6LSOar/nUKC tgvaeIL5rspPuGoZVWES3rh9cu4qjGav1uStn0OVQTWKm+YRZZ46wCzwe5w3yTlzqQOP K00PZXgv4WcFb8rizm9pD9NLJN0mYme9n7mHcj0gyQ9qpEVgBuqXgLaLgkjRFQASstg1 33ZWBL+nQqHcRZjBqcth97SwVsOAUJRJb0UVSD7/ZNjCGV45Ncalx2FnGfqy3nhgpduD qxXQ3jPMMy7BfxmKLTcslNf6NKmO6V1bTIbS+J3XEBFHOudLJiu4XZeE5IIb7igj9mTd hFXA== X-Gm-Message-State: AOJu0YxTABNstofd2MnLExXiwueOy3GYYpyGJ0JdPK7rUcFjXoEd/bS2 HHlOAJA8i5kcGOwgbCu+uzqrOxOne0J9Vg== X-Google-Smtp-Source: AGHT+IEQmAz/yRZ4JQb4KH0cdGwc6wBVKJX8n66A4HzKVJGrDTgM6umRzceJA14m6Bo9F2DGOz85Jw== X-Received: by 2002:a05:600c:b88:b0:40e:4cc6:9ff5 with SMTP id fl8-20020a05600c0b8800b0040e4cc69ff5mr406137wmb.100.1704882068122; Wed, 10 Jan 2024 02:21:08 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:07 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 01/18] tty: serial: samsung: prepare for different IO types Date: Wed, 10 Jan 2024 10:20:45 +0000 Message-ID: <20240110102102.61587-2-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022110_100110_23630F1E X-CRM114-Status: GOOD ( 16.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org GS101's Connectivity Peripheral blocks (peric0/1 blocks) which include the I3C and USI (I2C, SPI, UART) only allow 32-bit register accesses. If using 8-bit register accesses, a SError Interrupt is raised causing the system unusable. Instead of specifying the reg-io-width = 4 everywhere, for each node, the requirement should be deduced from the compatible. Prepare the samsung tty driver to allow IO types different than UPIO_MEM. ``struct uart_port::iotype`` is an unsigned char where all its 8 bits are exposed to uapi. We can't make NULL checks on it to verify if it's set, thus always set it from the driver's data. Use u8 for the ``iotype`` member of ``struct s3c24xx_uart_info`` to emphasize that the iotype is an 8 bit mask. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 71d17d804fda..b8fe9df20202 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -84,6 +84,7 @@ struct s3c24xx_uart_info { unsigned long clksel_mask; unsigned long clksel_shift; unsigned long ucon_mask; + u8 iotype; /* uart port features */ @@ -1742,7 +1743,6 @@ static void s3c24xx_serial_init_port_default(int index) { spin_lock_init(&port->lock); - port->iotype = UPIO_MEM; port->uartclk = 0; port->fifosize = 16; port->flags = UPF_BOOT_AUTOCONF; @@ -1989,6 +1989,8 @@ static int s3c24xx_serial_probe(struct platform_device *pdev) break; } + ourport->port.iotype = ourport->info->iotype; + if (np) { of_property_read_u32(np, "samsung,uart-fifosize", &ourport->port.fifosize); @@ -2399,6 +2401,7 @@ static const struct s3c24xx_serial_drv_data s3c6400_serial_drv_data = { .name = "Samsung S3C6400 UART", .type = TYPE_S3C6400, .port_type = PORT_S3C6400, + .iotype = UPIO_MEM, .fifosize = 64, .has_divslot = 1, .rx_fifomask = S3C2440_UFSTAT_RXMASK, @@ -2428,6 +2431,7 @@ static const struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = { .name = "Samsung S5PV210 UART", .type = TYPE_S3C6400, .port_type = PORT_S3C6400, + .iotype = UPIO_MEM, .has_divslot = 1, .rx_fifomask = S5PV210_UFSTAT_RXMASK, .rx_fifoshift = S5PV210_UFSTAT_RXSHIFT, @@ -2457,6 +2461,7 @@ static const struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = { .name = "Samsung Exynos UART", \ .type = TYPE_S3C6400, \ .port_type = PORT_S3C6400, \ + .iotype = UPIO_MEM, \ .has_divslot = 1, \ .rx_fifomask = S5PV210_UFSTAT_RXMASK, \ .rx_fifoshift = S5PV210_UFSTAT_RXSHIFT, \ @@ -2517,6 +2522,7 @@ static const struct s3c24xx_serial_drv_data s5l_serial_drv_data = { .name = "Apple S5L UART", .type = TYPE_APPLE_S5L, .port_type = PORT_8250, + .iotype = UPIO_MEM, .fifosize = 16, .rx_fifomask = S3C2410_UFSTAT_RXMASK, .rx_fifoshift = S3C2410_UFSTAT_RXSHIFT, @@ -2546,6 +2552,7 @@ static const struct s3c24xx_serial_drv_data artpec8_serial_drv_data = { .name = "Axis ARTPEC-8 UART", .type = TYPE_S3C6400, .port_type = PORT_S3C6400, + .iotype = UPIO_MEM, .fifosize = 64, .has_divslot = 1, .rx_fifomask = S5PV210_UFSTAT_RXMASK, From patchwork Wed Jan 10 10:20:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515895 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 730D5C47073 for ; Wed, 10 Jan 2024 10:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f86hfgFlK0WVs5bMZ9xOmiUi9z4u/uSN/7Fy96YaHbI=; b=Wf1QX3oc4f+GaB ++iG1bFRigTB7umxZqFGRGgq0Dk8ByRI/rvqAHKcOdUgmnCTFlMZhLkV/xrwkjrKb1Uw1uhKCcuQW NftHEhDW5HTKqOfCnCmoTIohRBOWFU9GJFePkRYCencHSOgMT5CdM1jDwPu7xEXjZ4PUbJuI9l43f 2sHeqlfsHAt0f8czHmZYeHRIltQk7qqkqxCZsiPwQoM9Tve2pWUT4n/ssg10sfQLx3G1EzUmP3oXn 5UZqeQtIoG76XE4PuKuyRQGoAm+8PeFcwMK4dEiDaW1dlIazQvdnvosaYtl4Wbu1sbwz1BnZewfpX Fa7QYHns+SaeFP5UqAFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi3-00B03f-15; Wed, 10 Jan 2024 10:21:19 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVhv-00Azvj-1S for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:13 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50eabd1c701so4850929e87.3 for ; Wed, 10 Jan 2024 02:21:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882069; x=1705486869; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WA1wqdkIBgQshp7OOT7q6kHMVXJcjDA2G18H91tm8Z8=; b=sudLLc7h5OzyOnEDTTEHt91L2+uKBQPm1vpeGvpjMbr8hvzx2uVqW7virplxJ+xRmE tDMqDtCOuir41JzmqXjWF0/qDsOh8HexVjXJFn8XhIXGsUTCvml4RkOYcixS0a8CkFyY yhlYye2lcaCWn+hXHyndg7m8cJyNACEtqGKExO27ybnLzkwQahS393HsImxTostD7qRv SJOCbcbq5Itw9vCUSJMnhoj/gi4NskWvkZoqx6ZLdLFxhr7XWVr10Lfp1txHCqhsdUpt O6K5l8J7IEpXa8waSDhwNTe6fkNybD6irwgALDTkgg4D3OJasDFg2tufpF6umGdwvNoI H5bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882069; x=1705486869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WA1wqdkIBgQshp7OOT7q6kHMVXJcjDA2G18H91tm8Z8=; b=Syd8kXOordSiGLNfNJ7oWH84eTXQtny3KSLA5yRfyMO2HNXjnM5vYxU82hVeHS1xdI ID8oo5Kk7GYAZMJ0jvKgOFpcu/dkncoa7xtzcFG/iKjg3ZffBSDX1oPNC0vtYm0yOkjN Lp3dbkiCH6rib95DaKilDsIfu8iOXH7MBY/DDfVHzNlmMP1lF5Xy6fr+FzqO9nBWAO12 79mr64PjOFS+Ncutd0QfPF7Tf6LkyuiCCL7ALXjxUDlt2cqEYbRF/lSI64wNIiekfRNX /QbuiyKuZtlFUKDsXSbbn2dvrR+bmgEc0Du9YWOTnlVfZp8HGz4lSuKdeXQ0atdxgncb 6KEw== X-Gm-Message-State: AOJu0YzZOwVgl4Qb0vvZrchYYfRa09080MqC97szweC8Jr3Wn6HvAqqW pFAnZkkMFf4B9uP4MpvFzi/GES44/n3TOA== X-Google-Smtp-Source: AGHT+IELjvrXw11hASDuqeoOjnXHBb/wHFRSBI3T8k5uASK1m5nJmKIYBXNYKwon+CNtfclv5aKAuA== X-Received: by 2002:a05:6512:131f:b0:50e:d347:b83 with SMTP id x31-20020a056512131f00b0050ed3470b83mr344642lfu.115.1704882068958; Wed, 10 Jan 2024 02:21:08 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:08 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 02/18] tty: serial: samsung: set UPIO_MEM32 iotype for gs101 Date: Wed, 10 Jan 2024 10:20:46 +0000 Message-ID: <20240110102102.61587-3-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022111_514856_33E5FC70 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org GS101's Connectivity Peripheral blocks (peric0/1 blocks) which include the I3C and USI (I2C, SPI, UART) only allow 32-bit register accesses. Instead of specifying the reg-io-width = 4 everywhere, for each node, the requirement should be deduced from the compatible. Infer UPIO_MEM32 iotype from the "google,gs101-uart" compatible. Update the uart info name to be GS101 specific in order to differentiate from the other exynos platforms. All the other settings are not changed. exynos_fifoszdt_serial_drv_data was replaced by gs101_serial_drv_data because the iotype restriction is gs101 specific and there was no other user of exynos_fifoszdt_serial_drv_data. Reviewed-by: Peter Griffin Reviewed-by: Krzysztof Kozlowski Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 38 +++++++++++++++++++++++--------- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index b8fe9df20202..20ec6ef1a52f 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2495,25 +2495,43 @@ static const struct s3c24xx_serial_drv_data exynos850_serial_drv_data = { .fifosize = { 256, 64, 64, 64 }, }; -/* - * Common drv_data struct for platforms that specify samsung,uart-fifosize in - * device tree. - */ -static const struct s3c24xx_serial_drv_data exynos_fifoszdt_serial_drv_data = { - EXYNOS_COMMON_SERIAL_DRV_DATA(), +static const struct s3c24xx_serial_drv_data gs101_serial_drv_data = { + .info = { + .name = "Google GS101 UART", + .type = TYPE_S3C6400, + .port_type = PORT_S3C6400, + .iotype = UPIO_MEM32, + .has_divslot = 1, + .rx_fifomask = S5PV210_UFSTAT_RXMASK, + .rx_fifoshift = S5PV210_UFSTAT_RXSHIFT, + .rx_fifofull = S5PV210_UFSTAT_RXFULL, + .tx_fifofull = S5PV210_UFSTAT_TXFULL, + .tx_fifomask = S5PV210_UFSTAT_TXMASK, + .tx_fifoshift = S5PV210_UFSTAT_TXSHIFT, + .def_clk_sel = S3C2410_UCON_CLKSEL0, + .num_clks = 1, + .clksel_mask = 0, + .clksel_shift = 0, + }, + .def_cfg = { + .ucon = S5PV210_UCON_DEFAULT, + .ufcon = S5PV210_UFCON_DEFAULT, + .has_fracval = 1, + }, + /* samsung,uart-fifosize must be specified in the device tree. */ .fifosize = { 0 }, }; #define EXYNOS4210_SERIAL_DRV_DATA (&exynos4210_serial_drv_data) #define EXYNOS5433_SERIAL_DRV_DATA (&exynos5433_serial_drv_data) #define EXYNOS850_SERIAL_DRV_DATA (&exynos850_serial_drv_data) -#define EXYNOS_FIFOSZDT_DRV_DATA (&exynos_fifoszdt_serial_drv_data) +#define GS101_SERIAL_DRV_DATA (&gs101_serial_drv_data) #else #define EXYNOS4210_SERIAL_DRV_DATA NULL #define EXYNOS5433_SERIAL_DRV_DATA NULL #define EXYNOS850_SERIAL_DRV_DATA NULL -#define EXYNOS_FIFOSZDT_DRV_DATA NULL +#define GS101_SERIAL_DRV_DATA NULL #endif #ifdef CONFIG_ARCH_APPLE @@ -2601,7 +2619,7 @@ static const struct platform_device_id s3c24xx_serial_driver_ids[] = { .driver_data = (kernel_ulong_t)ARTPEC8_SERIAL_DRV_DATA, }, { .name = "gs101-uart", - .driver_data = (kernel_ulong_t)EXYNOS_FIFOSZDT_DRV_DATA, + .driver_data = (kernel_ulong_t)GS101_SERIAL_DRV_DATA, }, { }, }; @@ -2624,7 +2642,7 @@ static const struct of_device_id s3c24xx_uart_dt_match[] = { { .compatible = "axis,artpec8-uart", .data = ARTPEC8_SERIAL_DRV_DATA }, { .compatible = "google,gs101-uart", - .data = EXYNOS_FIFOSZDT_DRV_DATA }, + .data = GS101_SERIAL_DRV_DATA }, {}, }; MODULE_DEVICE_TABLE(of, s3c24xx_uart_dt_match); From patchwork Wed Jan 10 10:20:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515897 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2178DC47073 for ; Wed, 10 Jan 2024 10:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9jnvaY6nKK71Fn5nWK/YVDZi1dTqA+q9u5K0hMbA3Fc=; b=z7nFAwxfE0+Nwt ZrmVJplk15JzVJZDyZUK2Q+awrarovv2eAhGbybgY6k4HsRL/kwWuhd7IbC7nRsBR4CrsLm3tsDK7 cYu+jYcG612RWznTuyiMoHb3X7AZidT7sByd8U4hiy2jKdiMiHCh5OYAi4ZCrBtztS6IkmMWYohGv 2BD8EbtWHNwIkd9qIv6gunAZHk4VUrq7zq2tC33Yy2CkWvyOYvsOhHXucmx04ABgh7r454BdfUfyY 2gJh223inN4HI0zhUhuAUDqxHhzg69Acr76XvVXx0vUUXcN7OsXvMEZaMnTGYlzOACkZtJf2/BsAU ngSN3LCzugxFaohuEwYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi4-00B04a-24; Wed, 10 Jan 2024 10:21:20 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVhv-00AzwH-2i for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:13 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-40e5451c13aso9365555e9.2 for ; Wed, 10 Jan 2024 02:21:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882069; x=1705486869; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fsnoBIJqRKL8fx5Abgy7bxSlqGNMKE0Lqg/re65WEDg=; b=E02oIhc2obko/IT5mKw6fV1Qw7O5r8StVufvvYqZeEAxmmH8RAKTY1lCFE9QkvkOc+ wA09ei6KXCDfIjfGBu3TqDpss4KBNgWkJCB/4mF26gVNwKTzbjQYj0dxTewUqrFc7hZS G7QmuSyqnI1tRlsHovwEOapv+2MUs7aJhe4i5ZSF9h4LJhKUkytyIk6RvWLOJWICUjTU /s3tOn0jIrs8eq1Ft+cGzsvew7x0vjghdLxur+tW+GfRnA41J0oVv5f0tQ97j6y6MJI1 nrVkWodYCcqLalL0ddUzKG7qhTrfFQu514ag65Io/aLQV/xDpzw1Z38U7MCawbhg0F9X RULQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882069; x=1705486869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fsnoBIJqRKL8fx5Abgy7bxSlqGNMKE0Lqg/re65WEDg=; b=bn/94dZKJChYj5PskqdsxvCp4rWkxl+KJdIhs5PnDGDyyFldwiW2BTpDenSpwALDmU xnKAdxRiiKP7yExz1NOGPpW6B3LJX3ujRvJ2GN63pC3cvbwH+JqGYKEamuEjwWXHLVG3 BlBQUGwr+Srng3j8ots0rtYjf0L1SWcCcuVhIaW0mcksOIzBzBefT9PU9xrzfP4nRgbz W+PP1EQqFjKI1mJOEnB+Zwyldvc1/YZbyjCbKCFunLUWXOMDtrWu+NTwwJTxks17Shg6 SOS+lQKzDEaiK3MigtkGuZ2q2y1vDHh4w2KZhvfIwsnUkP1EENzwmo4/eOOqCwCXUtF0 bvGA== X-Gm-Message-State: AOJu0YwRqxWbjSp/mBo0oPzJSSrx8yPLcmn7S5IefrlnifSe0facIN3L otm60sLJYMdclhbtymLm8nRfg1ilwY9HcQ== X-Google-Smtp-Source: AGHT+IFyetyaA6/1wjXTRap8gF7AQlclivTZB7k1d1dyppWTKQU0nJEVHPWzIx2rYQXgLUJlRHX0RA== X-Received: by 2002:a05:600c:32a7:b0:40e:44eb:c40 with SMTP id t39-20020a05600c32a700b0040e44eb0c40mr312383wmp.30.1704882069641; Wed, 10 Jan 2024 02:21:09 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:09 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 03/18] tty: serial: samsung: add gs101 earlycon support Date: Wed, 10 Jan 2024 10:20:47 +0000 Message-ID: <20240110102102.61587-4-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022111_911489_0BB6F0DB X-CRM114-Status: GOOD ( 10.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The entire bus (PERIC) on which the GS101 serial resides only allows 32-bit register accesses. The reg-io-width dt property is disallowed for the "google,gs101-uart" compatible and instead the iotype is inferred from the compatible. Always set UPIO_MEM32 iotype for the gs101 earlycon. Reviewed-by: Peter Griffin Reviewed-by: Krzysztof Kozlowski Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 20ec6ef1a52f..74bc5151dad4 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2810,6 +2810,17 @@ OF_EARLYCON_DECLARE(exynos4210, "samsung,exynos4210-uart", OF_EARLYCON_DECLARE(artpec8, "axis,artpec8-uart", s5pv210_early_console_setup); +static int __init gs101_early_console_setup(struct earlycon_device *device, + const char *opt) +{ + /* gs101 always expects MMIO32 register accesses. */ + device->port.iotype = UPIO_MEM32; + + return s5pv210_early_console_setup(device, opt); +} + +OF_EARLYCON_DECLARE(gs101, "google,gs101-uart", gs101_early_console_setup); + /* Apple S5L */ static int __init apple_s5l_early_console_setup(struct earlycon_device *device, const char *opt) From patchwork Wed Jan 10 10:20:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515896 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D93DC47074 for ; Wed, 10 Jan 2024 10:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k/iV9IsSVUC6AqfA3u0X8M2hKh6Ijop+sR2mNB/3Kp0=; b=TAqc12XOks/WcF Kac4DyR9KfpWZQ+3NpsO8UXMm58+/OQzKNSqqKUrbkw2RhTPtad1kHrA+quBZEL7Aq8fiHQTTQt/g V7G2MuP+Q7/m6T5PCkdnFvs4HJEJeQE+xqHFAD/M4eAgw1XBKJkGZORjnPpssaedMKxN+TKNPxrJI kho8aLQEpEi7zvhtCuikbcy0FEYLjaJ9pBf5s2TwdT0O9myz3dnEEd3RAO7Vz0ndCFcmPM1smciaC slXhvulOW+a7+zYg2riPCu3we33jgGk4UF38g3DtQx0of83/hoLtai1fx76gLe8TKFyJFgp4qWFia OwrgSDGu7mPOxTQdKs7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi5-00B05j-1u; Wed, 10 Jan 2024 10:21:21 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVhw-00Azwp-1y for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:14 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40e585ec8ebso2401395e9.3 for ; Wed, 10 Jan 2024 02:21:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882070; x=1705486870; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rCIwgQ4YttU9lzxXqEJuv2Mwb9Cj5TAyRM4oPuL0tc0=; b=A998FWPc1R0Z33dRGo9Bgjz9M7XppqInjjb4KVaJDfK1upc7/qoUkazSbWqDombpMu z2rac9jQddUiAiair2itp3cQerqPAHvr3H9ND9wJEMXtfYDNRGjAyLVyKr+I3c/58yTs KIPLQzvSw1dLYyjY3/EllAiY0sm73LXQy5Y7LA1gptPPUHgzmd/0FUuePJsY75jdFNyg 0xOo+IyYPLY8xawJky4nBCZI49NU4sACKSj9BDyT2BlbTn+qMdJmrB4qLjL1LUHcU6dd g+kFzDVP8j7FMKPQEVYSKJ4tPlziAKZj5aEpWQExpTv7kgjh0sYP/tJT7BuYkzyZlj5p MSzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882070; x=1705486870; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rCIwgQ4YttU9lzxXqEJuv2Mwb9Cj5TAyRM4oPuL0tc0=; b=sgwl4qpp/hh00EdiWcif+pbc02s7cFHr72MUQvuJ4rWjh9Xy6zgtpp9C7cIQsSEgX1 8AM7cuSzBg4dpz4ruBnPMFgTMJ3/ynQHuajSpz4w+2Lig3kuNtzERt/Q8qY4vguf6jlV t+olbj67odfqha1qBXXumRoBiNYUfSRPVvFmVKWTzJBfGTzwg9RbUqBBGatrh2u13YXA 9gkrFWgUvVS/HkhGQ43jizMXASyq0FCTgynh9tGBlq2lO8ZUrpgWKIYfzkfMr09Lrskz iMN7ORrG6gO30k72l83KNGBjT0LuaDnRJ/nw2WI2zLMLI3xbMNp/DzK/2wUjqdjpE14l ChAw== X-Gm-Message-State: AOJu0YyIWUg/IvD+juKETMZ+3EBCsAnNKBmsMRXYcbBSzvmT4Ype+jtJ a1XpmDIoFCamPvEpEi2EJeACFR/A699QDQ== X-Google-Smtp-Source: AGHT+IHt/P5/L5xH5AAfveckh63ganb8NEGmYwtf9RT0JC1yoNO6aAavNRUXC/fTYmqSHMRcJOKt7w== X-Received: by 2002:a05:600c:2143:b0:40e:4156:9059 with SMTP id v3-20020a05600c214300b0040e41569059mr371775wml.177.1704882070457; Wed, 10 Jan 2024 02:21:10 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:09 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 04/18] tty: serial: samsung: sort headers alphabetically Date: Wed, 10 Jan 2024 10:20:48 +0000 Message-ID: <20240110102102.61587-5-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022112_653259_A69FC409 X-CRM114-Status: UNSURE ( 9.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sorting headers alphabetically helps locating duplicates, and makes it easier to figure out where to insert new headers. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 74bc5151dad4..f37d6724bfe5 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -21,26 +21,27 @@ * BJD, 04-Nov-2004 */ -#include +#include +#include +#include +#include #include -#include +#include +#include +#include +#include #include #include -#include -#include +#include #include -#include +#include +#include +#include +#include #include -#include #include #include -#include -#include -#include -#include -#include -#include -#include + #include /* UART name and device definitions */ From patchwork Wed Jan 10 10:20:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CBADC47258 for ; Wed, 10 Jan 2024 10:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=va3hoW4MN1lNlbrm6rd7f/0RV5G+vl0UGY5IPRuM428=; b=ed4ESScZDU+PMi uGvaZSTfQZ3DxphNVpVbYoO4sG6pMcsgR/83fHMn1SnTwFjk6CsSCMr+N5XJT03Hd4rRQuSNqz9S6 AJCfYlt6bgs2uo7muPOlMdjj2dnAZupPhiQwEa+V9hdKZ0yAxA5dXUdHdDtId2vLOrnMcMCQPqlNT czlO/xlk3nZkNATMOcW14ECS0wPplRyNzOyZcMB6Fa+jIsgNDEB4OuZ3PG4IRwRbYHTrGm6lzJ+fW UtO/fkYoYN5EVMeDgnLIPQWmDhU46Ir7vJSpH/m8biFcib6MR0oDft0kPFLa0qiEoxlG7/JZV/mq0 iKvCWGjvdux9B2uhbCSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi7-00B07U-0C; Wed, 10 Jan 2024 10:21:23 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVhx-00AzxT-1k for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:14 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40e5508ecb9so10396545e9.3 for ; Wed, 10 Jan 2024 02:21:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882071; x=1705486871; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O4iYdXj/TSCgsEZp2b2vJFAs1qXmGMx2hLD5PPyxfe4=; b=LUmjgUUrZCMoogis7irJsGFH0OpU2mkIdWJxmlN0wLr2LXmL9f1+Op+YZ//Y1l0NoJ lfJ5L7gAxsc3V6BS2fsd+fQB4DntVtKdJpJw5ng+PPF62LL88OccJnleS/ZURwsmCUYG VL3Gk+SST6eEcG64JUf9jifRomKDPl9BlYuSlq6bRmhuRVgyvnot23AwhOuMW27sz8ls ZGaCkTpsPwXnSfa4odGzK66k0n6kIfiV5FYUjbWxu3pu7X35B0m5LeNKvV70gjqiYjrS hmYQr5IeixUdeSSCK2+6kBpqPC/z4pJDgH3ssh+SF7oJtkzLh5WiPuvx3Bnp0s+pU1Gv ZFjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882071; x=1705486871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O4iYdXj/TSCgsEZp2b2vJFAs1qXmGMx2hLD5PPyxfe4=; b=E2Iyn4OKqrhx2LZZSXi6mYdF8oMqHMRDgm+NIoyNfibnE6VOi2TEE1AvSPim+XcmeX rVXML1I5dnL8tCB3hGXoaJF33xF6FGI5SG2TToiTlZXkOYeuESpD/zEEtGCZM3WrUuhN jHLdCOu9LK2g8rOGpUbJrDm7/dwABOlSskTZ9dN3hxrOT0HLtlYbqYbXWMbKo+EdF2Vf orTAtsJrj0bGWETWx+AAffkVIIJT3UBxmIgPTdyAoHkHc6ZyFGHa6naVLuZo68VjO2gM +Qrth2ViK5mZpjvkxP6Wg+5kPEjNPD5Pzpi2e11c07y3xjW2+tSz/rjd66bSSXSOLAOR V08A== X-Gm-Message-State: AOJu0Ywwn1+b3Gudxvp0l8H/0cUPTDnU/Gt04xMRwda+oVx4KEQGpZd7 9TF89HMkI0th/bs0iNWJdRq9Mj5PjemJQg== X-Google-Smtp-Source: AGHT+IEJaLJEuywZyJ4sRLPFSPZQHxuethScWjz9nRPWcCw2dTCMG2kd8LT+vUP10sFOjNedK0JasQ== X-Received: by 2002:a05:600c:3d1a:b0:40e:461e:26a6 with SMTP id bh26-20020a05600c3d1a00b0040e461e26a6mr471328wmb.36.1704882071439; Wed, 10 Jan 2024 02:21:11 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:10 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 05/18] tty: serial: samsung: explicitly include Date: Wed, 10 Jan 2024 10:20:49 +0000 Message-ID: <20240110102102.61587-6-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022113_606606_063E1E6C X-CRM114-Status: UNSURE ( 9.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org samsung_tty.c uses u32 and relies on to include . Explicitly include . We shall aim to have the driver self contained. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index f37d6724bfe5..b8b71a0109ea 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -41,6 +41,7 @@ #include #include #include +#include #include From patchwork Wed Jan 10 10:20:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515900 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B87B1C47073 for ; Wed, 10 Jan 2024 10:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YcSmg+BHhtw+YozpX1aQcfm54XEtn7kteRK5xLIPWxw=; b=bjmIJGcqX2ibl/ KQmghnkEayOZ5BXwXeJUaO2BVLIUBtu1SnvF6C6bH8T8/ob/IDLXmg63f1Ufu7V3cX4uZiVNjdXCZ U/O8+4ZaE4AZ2Ml5s5+8YIm1pN8+k/wAdDBiQxrQmnmhn/Qj7/wWgwevI+7ooudy39OjZkxyUvk1q Zqdc4O2a5Wp8Z45LZgaWvKt9s+lSW5K6holCB1didvZV7Qa9Le6iwEIcjVIU0UrRoXyDG2jnm8owt vDkqIC0NMKvy+g5B2nd+g3XUAqbdQWZgTXiizYZPMaOJ6O+NeBSWShYoFigXZhIr4MO7/sOBfyCOb ehcl3E8PCg9GujCNSJYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNViA-00B0Ak-0A; Wed, 10 Jan 2024 10:21:26 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVhy-00AzyB-1R for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:17 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3376ead25e1so2405805f8f.3 for ; Wed, 10 Jan 2024 02:21:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882072; x=1705486872; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LfuH3wSlm6aDB+5MQe7gxyw0I5hRCPtFyKG+AY6rcK0=; b=vbky8Fgd23cTdfc4PWH7dQ83bco/Hsvj7o2F+Wl2mDE13lRvUPb7cHZSIvHyVjBIzU kQqLfZcoEql35xOyBjBPXeAiUBe90XlntOXCxsr5FNGMfuOKSCgjMh0pDVsOSIPHxmfe V9SI4cjQlv02eIynzn4uCMpONp2+Lz0NDTUHJmOhtEKJYgsYEDBGN7xBrjufG2gwpzME P8bQO/sb7QjBkU17EaO9G/hINnn3h2CsPs+eofA6ZFIx9iuBKahZ+TVoBzavAVw2f5aX LWm0rn+W4Qu+PSpb0p6MiEJYdIF5F7BU/qkW1+rmH2knFN7P1YadWajgNGmh9+T9qh3Z NQ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882072; x=1705486872; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LfuH3wSlm6aDB+5MQe7gxyw0I5hRCPtFyKG+AY6rcK0=; b=cd7fKIkJXceYjp88w+oqWOS/9C+eAGvxUsMZdULP4Mv+UUgMVQngrXDnEF0tcNpihK dAckOhcbhZs+6GZ1S4yR+RPbidlo2vRbXfWixtgUx6wZoJMwP0Vo6rxoOPp1eA8PFAjC o9qBixGursySQg4qVIPH4UASOEXObsIQVXHdsnX/Y6qhggE67IkX0opFgZxYPt3yVJta bQRNFNedNJKrigWzMwlbPCkrwtgrKu4kTLeBu/1J2Qyxw5MW0NmWVOA5Bap805XyVl8P mnTLCcv7E6ovgDB1gTizHYEKaKLQ/QY8A+7U4kEn3KuB8hVa0iwAUpw7uEqarM9AFjQi 14Mw== X-Gm-Message-State: AOJu0YyIYUbgML6r6hhwy151ZMPY66H6ObsbcGRJADqSdkWMEZa7IRwB u6glvgBOV+d+ywA/GxxkzqJik4JWKSPggw== X-Google-Smtp-Source: AGHT+IHxCH+x8Bd49h96aENkSSiu3NcMtRR69yY6qu1FUYAozJ3aiG1NexaAB58eotSyJt97Xv++1Q== X-Received: by 2002:a05:600c:5390:b0:40e:3f37:d893 with SMTP id hg16-20020a05600c539000b0040e3f37d893mr457342wmb.17.1704882072241; Wed, 10 Jan 2024 02:21:12 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:11 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 06/18] tty: serial: samsung: use u32 for register interactions Date: Wed, 10 Jan 2024 10:20:50 +0000 Message-ID: <20240110102102.61587-7-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022114_611685_94B66FA8 X-CRM114-Status: GOOD ( 19.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org All registers of the IP have 32 bits. Use u32 variables when reading or writing from/to the registers. The purpose of those variables becomes clearer. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 79 ++++++++++++++++---------------- 1 file changed, 39 insertions(+), 40 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index b8b71a0109ea..d5f9bec24b8e 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -199,7 +199,7 @@ static void wr_reg(const struct uart_port *port, u32 reg, u32 val) /* Byte-order aware bit setting/clearing functions. */ static inline void s3c24xx_set_bit(const struct uart_port *port, int idx, - unsigned int reg) + u32 reg) { unsigned long flags; u32 val; @@ -212,7 +212,7 @@ static inline void s3c24xx_set_bit(const struct uart_port *port, int idx, } static inline void s3c24xx_clear_bit(const struct uart_port *port, int idx, - unsigned int reg) + u32 reg) { unsigned long flags; u32 val; @@ -245,8 +245,8 @@ static void s3c24xx_serial_rx_enable(struct uart_port *port) { struct s3c24xx_uart_port *ourport = to_ourport(port); unsigned long flags; - unsigned int ucon, ufcon; int count = 10000; + u32 ucon, ufcon; uart_port_lock_irqsave(port, &flags); @@ -269,7 +269,7 @@ static void s3c24xx_serial_rx_disable(struct uart_port *port) { struct s3c24xx_uart_port *ourport = to_ourport(port); unsigned long flags; - unsigned int ucon; + u32 ucon; uart_port_lock_irqsave(port, &flags); @@ -591,7 +591,7 @@ static inline const struct s3c2410_uartcfg } static int s3c24xx_serial_rx_fifocnt(const struct s3c24xx_uart_port *ourport, - unsigned long ufstat) + u32 ufstat) { const struct s3c24xx_uart_info *info = ourport->info; @@ -663,7 +663,7 @@ static void s3c64xx_start_rx_dma(struct s3c24xx_uart_port *ourport) static void enable_rx_dma(struct s3c24xx_uart_port *ourport) { struct uart_port *port = &ourport->port; - unsigned int ucon; + u32 ucon; /* set Rx mode to DMA mode */ ucon = rd_regl(port, S3C2410_UCON); @@ -686,7 +686,7 @@ static void enable_rx_dma(struct s3c24xx_uart_port *ourport) static void enable_rx_pio(struct s3c24xx_uart_port *ourport) { struct uart_port *port = &ourport->port; - unsigned int ucon; + u32 ucon; /* set Rx mode to DMA mode */ ucon = rd_regl(port, S3C2410_UCON); @@ -711,13 +711,14 @@ static void s3c24xx_serial_rx_drain_fifo(struct s3c24xx_uart_port *ourport); static irqreturn_t s3c24xx_serial_rx_chars_dma(void *dev_id) { - unsigned int utrstat, received; struct s3c24xx_uart_port *ourport = dev_id; struct uart_port *port = &ourport->port; struct s3c24xx_uart_dma *dma = ourport->dma; struct tty_struct *tty = tty_port_tty_get(&ourport->port.state->port); struct tty_port *t = &port->state->port; struct dma_tx_state state; + unsigned int received; + u32 utrstat; utrstat = rd_regl(port, S3C2410_UTRSTAT); rd_regl(port, S3C2410_UFSTAT); @@ -759,9 +760,9 @@ static irqreturn_t s3c24xx_serial_rx_chars_dma(void *dev_id) static void s3c24xx_serial_rx_drain_fifo(struct s3c24xx_uart_port *ourport) { struct uart_port *port = &ourport->port; - unsigned int ufcon, ufstat, uerstat; unsigned int fifocnt = 0; int max_count = port->fifosize; + u32 ufcon, ufstat, uerstat; u8 ch, flag; while (max_count-- > 0) { @@ -945,7 +946,7 @@ static irqreturn_t s3c64xx_serial_handle_irq(int irq, void *id) { const struct s3c24xx_uart_port *ourport = id; const struct uart_port *port = &ourport->port; - unsigned int pend = rd_regl(port, S3C64XX_UINTP); + u32 pend = rd_regl(port, S3C64XX_UINTP); irqreturn_t ret = IRQ_HANDLED; if (pend & S3C64XX_UINTM_RXD_MSK) { @@ -964,7 +965,7 @@ static irqreturn_t apple_serial_handle_irq(int irq, void *id) { const struct s3c24xx_uart_port *ourport = id; const struct uart_port *port = &ourport->port; - unsigned int pend = rd_regl(port, S3C2410_UTRSTAT); + u32 pend = rd_regl(port, S3C2410_UTRSTAT); irqreturn_t ret = IRQ_NONE; if (pend & (APPLE_S5L_UTRSTAT_RXTHRESH | APPLE_S5L_UTRSTAT_RXTO)) { @@ -983,8 +984,8 @@ static irqreturn_t apple_serial_handle_irq(int irq, void *id) static unsigned int s3c24xx_serial_tx_empty(struct uart_port *port) { const struct s3c24xx_uart_info *info = s3c24xx_port_to_info(port); - unsigned long ufstat = rd_regl(port, S3C2410_UFSTAT); - unsigned long ufcon = rd_regl(port, S3C2410_UFCON); + u32 ufstat = rd_regl(port, S3C2410_UFSTAT); + u32 ufcon = rd_regl(port, S3C2410_UFCON); if (ufcon & S3C2410_UFCON_FIFOMODE) { if ((ufstat & info->tx_fifomask) != 0 || @@ -1000,7 +1001,7 @@ static unsigned int s3c24xx_serial_tx_empty(struct uart_port *port) /* no modem control lines */ static unsigned int s3c24xx_serial_get_mctrl(struct uart_port *port) { - unsigned int umstat = rd_reg(port, S3C2410_UMSTAT); + u32 umstat = rd_reg(port, S3C2410_UMSTAT); if (umstat & S3C2410_UMSTAT_CTS) return TIOCM_CAR | TIOCM_DSR | TIOCM_CTS; @@ -1010,8 +1011,8 @@ static unsigned int s3c24xx_serial_get_mctrl(struct uart_port *port) static void s3c24xx_serial_set_mctrl(struct uart_port *port, unsigned int mctrl) { - unsigned int umcon = rd_regl(port, S3C2410_UMCON); - unsigned int ucon = rd_regl(port, S3C2410_UCON); + u32 umcon = rd_regl(port, S3C2410_UMCON); + u32 ucon = rd_regl(port, S3C2410_UCON); if (mctrl & TIOCM_RTS) umcon |= S3C2410_UMCOM_RTS_LOW; @@ -1031,7 +1032,7 @@ static void s3c24xx_serial_set_mctrl(struct uart_port *port, unsigned int mctrl) static void s3c24xx_serial_break_ctl(struct uart_port *port, int break_state) { unsigned long flags; - unsigned int ucon; + u32 ucon; uart_port_lock_irqsave(port, &flags); @@ -1189,7 +1190,7 @@ static void apple_s5l_serial_shutdown(struct uart_port *port) { struct s3c24xx_uart_port *ourport = to_ourport(port); - unsigned int ucon; + u32 ucon; ucon = rd_regl(port, S3C2410_UCON); ucon &= ~(APPLE_S5L_UCON_TXTHRESH_ENA_MSK | @@ -1215,7 +1216,7 @@ static int s3c64xx_serial_startup(struct uart_port *port) { struct s3c24xx_uart_port *ourport = to_ourport(port); unsigned long flags; - unsigned int ufcon; + u32 ufcon; int ret; wr_regl(port, S3C64XX_UINTM, 0xf); @@ -1260,7 +1261,7 @@ static int apple_s5l_serial_startup(struct uart_port *port) { struct s3c24xx_uart_port *ourport = to_ourport(port); unsigned long flags; - unsigned int ufcon; + u32 ufcon; int ret; wr_regl(port, S3C2410_UTRSTAT, APPLE_S5L_UTRSTAT_ALL_FLAGS); @@ -1345,7 +1346,7 @@ static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level, static inline int s3c24xx_serial_getsource(struct uart_port *port) { const struct s3c24xx_uart_info *info = s3c24xx_port_to_info(port); - unsigned int ucon; + u32 ucon; if (info->num_clks == 1) return 0; @@ -1359,7 +1360,7 @@ static void s3c24xx_serial_setsource(struct uart_port *port, unsigned int clk_sel) { const struct s3c24xx_uart_info *info = s3c24xx_port_to_info(port); - unsigned int ucon; + u32 ucon; if (info->num_clks == 1) return; @@ -1476,9 +1477,8 @@ static void s3c24xx_serial_set_termios(struct uart_port *port, struct clk *clk = ERR_PTR(-EINVAL); unsigned long flags; unsigned int baud, quot, clk_sel = 0; - unsigned int ulcon; - unsigned int umcon; unsigned int udivslot = 0; + u32 ulcon, umcon; /* * We don't support modem control lines. @@ -1760,7 +1760,7 @@ static void s3c24xx_serial_resetport(struct uart_port *port, const struct s3c2410_uartcfg *cfg) { const struct s3c24xx_uart_info *info = s3c24xx_port_to_info(port); - unsigned long ucon = rd_regl(port, S3C2410_UCON); + u32 ucon = rd_regl(port, S3C2410_UCON); ucon &= (info->clksel_mask | info->ucon_mask); wr_regl(port, S3C2410_UCON, ucon | cfg->ucon); @@ -1906,7 +1906,7 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, wr_regl(port, S3C64XX_UINTSP, 0xf); break; case TYPE_APPLE_S5L: { - unsigned int ucon; + u32 ucon; ucon = rd_regl(port, S3C2410_UCON); ucon &= ~(APPLE_S5L_UCON_TXTHRESH_ENA_MSK | @@ -2110,7 +2110,7 @@ static int s3c24xx_serial_resume_noirq(struct device *dev) /* restore IRQ mask */ switch (ourport->info->type) { case TYPE_S3C6400: { - unsigned int uintm = 0xf; + u32 uintm = 0xf; if (ourport->tx_enabled) uintm &= ~S3C64XX_UINTM_TXD_MSK; @@ -2126,7 +2126,7 @@ static int s3c24xx_serial_resume_noirq(struct device *dev) break; } case TYPE_APPLE_S5L: { - unsigned int ucon; + u32 ucon; int ret; ret = clk_prepare_enable(ourport->clk); @@ -2188,10 +2188,10 @@ static const struct dev_pm_ops s3c24xx_serial_pm_ops = { static struct uart_port *cons_uart; static int -s3c24xx_serial_console_txrdy(struct uart_port *port, unsigned int ufcon) +s3c24xx_serial_console_txrdy(struct uart_port *port, u32 ufcon) { const struct s3c24xx_uart_info *info = s3c24xx_port_to_info(port); - unsigned long ufstat, utrstat; + u32 ufstat, utrstat; if (ufcon & S3C2410_UFCON_FIFOMODE) { /* fifo mode - check amount of data in fifo registers... */ @@ -2207,7 +2207,7 @@ s3c24xx_serial_console_txrdy(struct uart_port *port, unsigned int ufcon) } static bool -s3c24xx_port_configured(unsigned int ucon) +s3c24xx_port_configured(u32 ucon) { /* consider the serial port configured if the tx/rx mode set */ return (ucon & 0xf) != 0; @@ -2222,7 +2222,7 @@ s3c24xx_port_configured(unsigned int ucon) static int s3c24xx_serial_get_poll_char(struct uart_port *port) { const struct s3c24xx_uart_port *ourport = to_ourport(port); - unsigned int ufstat; + u32 ufstat; ufstat = rd_regl(port, S3C2410_UFSTAT); if (s3c24xx_serial_rx_fifocnt(ourport, ufstat) == 0) @@ -2234,8 +2234,8 @@ static int s3c24xx_serial_get_poll_char(struct uart_port *port) static void s3c24xx_serial_put_poll_char(struct uart_port *port, unsigned char c) { - unsigned int ufcon = rd_regl(port, S3C2410_UFCON); - unsigned int ucon = rd_regl(port, S3C2410_UCON); + u32 ufcon = rd_regl(port, S3C2410_UFCON); + u32 ucon = rd_regl(port, S3C2410_UCON); /* not possible to xmit on unconfigured port */ if (!s3c24xx_port_configured(ucon)) @@ -2251,7 +2251,7 @@ static void s3c24xx_serial_put_poll_char(struct uart_port *port, static void s3c24xx_serial_console_putchar(struct uart_port *port, unsigned char ch) { - unsigned int ufcon = rd_regl(port, S3C2410_UFCON); + u32 ufcon = rd_regl(port, S3C2410_UFCON); while (!s3c24xx_serial_console_txrdy(port, ufcon)) cpu_relax(); @@ -2262,7 +2262,7 @@ static void s3c24xx_serial_console_write(struct console *co, const char *s, unsigned int count) { - unsigned int ucon = rd_regl(cons_uart, S3C2410_UCON); + u32 ucon = rd_regl(cons_uart, S3C2410_UCON); unsigned long flags; bool locked = true; @@ -2289,11 +2289,9 @@ s3c24xx_serial_get_options(struct uart_port *port, int *baud, int *parity, int *bits) { struct clk *clk; - unsigned int ulcon; - unsigned int ucon; - unsigned int ubrdiv; unsigned long rate; unsigned int clk_sel; + u32 ulcon, ucon, ubrdiv; char clk_name[MAX_CLK_NAME_LENGTH]; ulcon = rd_regl(port, S3C2410_ULCON); @@ -2743,7 +2741,8 @@ static int samsung_early_read(struct console *con, char *s, unsigned int n) { struct earlycon_device *dev = con->data; const struct samsung_early_console_data *data = dev->port.private_data; - int ch, ufstat, num_read = 0; + int num_read = 0; + u32 ch, ufstat; while (num_read < n) { ufstat = rd_regl(&dev->port, S3C2410_UFSTAT); From patchwork Wed Jan 10 10:20:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515898 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1008FC3DA6E for ; Wed, 10 Jan 2024 10:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=usIZXr8xVdhtasDzZ9rwhclilyfOE+jY6kIPIofJkjQ=; b=RCe6NSLCKA0R5j V0QH7ktPOI5+rpRCfslYdNH/rRl4Mcy/bFss0IvrP41UFEt9udaNzbmuDJmncV+GH0qALqs7M8AIU mOwXTzxFMRHuYpyr/eRJgwzkT6xoW7JMCIotGHo7QqvjZK3aCaEsaX3ifjgnyIFBzvU0zIlRWMUXi P1rGaM4oT+wPqFYFuD/Pp/rT+Di19YxtgccD8x08xSg8DzTHWyvUeLKTIahI5cxhRDm8R4mv8SJ8d 2hVe4wew8QoCyy/Ivp1Vpd4ODn3TiumNhK+T26oSwR/qln31v2m+bYzq4alOyrlnlBsTMx9EqTDyD 1nDmcr6FYS3fjykcs9hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi8-00B08k-1A; Wed, 10 Jan 2024 10:21:24 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVhy-00Azyt-1L for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:15 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40e4d515cdeso20487935e9.1 for ; Wed, 10 Jan 2024 02:21:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882073; x=1705486873; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mwqnqS/wycxZAhr2uerf+qQVYpnKiVk2U9Lnh+3LXKA=; b=VuMRPvN42XAl7EQ6Uv7+t8FnxKAmiXNdR/FDR+J5eCtXUlOyGvtul9rv9WfnrXNwD9 oY2f2l7VlEIgAzRAqJV5JzhzZ1QVSvNyIpfNbNeh9cNmEd6FxFYgIaJlCmQrqCVTXaxW EwjgtNkfX48DlujNjIG5ABdIqkQoWOpH8Q0DqkAXApF+bfQLN3HHYrn6M6myVtUFYB7/ Qvm6He84skaetMVROgZ+iGMT8q4JNUOAP90wVUua1IJvxyH79oAP3+KvT6Fob2k9nfJ8 cQOI3hDKoeuaISiRM7poGenEaoX+Ox+D9R5rpnBfPa8xV8GYBTdc121y/JXiE6XmBj2S lXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882073; x=1705486873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mwqnqS/wycxZAhr2uerf+qQVYpnKiVk2U9Lnh+3LXKA=; b=DlR/loBSPIFy/Gpk05QYlNdMPolCIhc4cGpOs3eAX7K2qlvEzZUG45UF8GNFx4S34c qc/gIm94mK4dVIq7xNoH8a9oKVIYCoDRr0130ZhsUL/JEmKDKcLPyhU5/8Z1gHddZm+S 5DASl+FLy0c5mJoBPzUZ9PVYtAqQUEcBANd+skkFfV0qnCsqdyd9aqHXoGJUfIGuR89b xDaSuLVaufblkkFbHyPa1goJRVbGiUmzqSCX5SNCkPl8mEAOGncZbwe8y8GbXCWk4mcO /ZiIKJv1iX2GmtIy55NdjulCdLi6/S3zI4YOCXOIoHtWx0xPSpHqIz+y0m4xp6hhqSMj SGEA== X-Gm-Message-State: AOJu0YxyzZXVRT5Vtxbu7rXMSEJwma5S3Vkzh6P59j+GMw/Z+HjyDx9c ckkVm7610B/9DCuWvXsA0Gh2Ycvw7tmWIg== X-Google-Smtp-Source: AGHT+IGcQBbhMHK+EKOMon1hp4+KGJv3InwLXWLO1SrdmS31XEWMZkMTbvJjozVPLu3hLFnAqJN0FA== X-Received: by 2002:a05:600c:519b:b0:40e:49b2:2c9e with SMTP id fa27-20020a05600c519b00b0040e49b22c9emr439607wmb.34.1704882073274; Wed, 10 Jan 2024 02:21:13 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:12 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 07/18] tty: serial: samsung: remove braces on single statement block Date: Wed, 10 Jan 2024 10:20:51 +0000 Message-ID: <20240110102102.61587-8-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022114_482586_8A8D0111 X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Braces {} are not necessary for single statement blocks. Remove braces on single statement block. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index d5f9bec24b8e..11ae3a1dcdc3 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2062,9 +2062,8 @@ static void s3c24xx_serial_remove(struct platform_device *dev) { struct uart_port *port = s3c24xx_dev_to_port(&dev->dev); - if (port) { + if (port) uart_remove_one_port(&s3c24xx_uart_drv, port); - } uart_unregister_driver(&s3c24xx_uart_drv); } From patchwork Wed Jan 10 10:20:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515901 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BACA4C3DA6E for ; Wed, 10 Jan 2024 10:21:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sbPhg8gHK+5TbDrCgfyhOFIw4B9B8nPs3oIeRAMDWrc=; b=lKumIgAJLjMnum VS8tan2+WBcAjGJtBN6NjEs/NyfrilMq7DKi5VJoaBBCdCNqVjkj/AsnfNVg9nSZe4ihgsYQEubGz hwaw5sahjbQP5+3XY5dDhqUAKAfQnXfv67aPH2/MX6PNoc5QLLg6XaJyzlxQ5YJniGeNUFrml3eE3 6DIRTxnVX0N282UaLvLsoRQziiQMkamjzXKqIJ/e0BTjFxAE0G4DtuLfLiQyFsnlROjQ/lMFNhKBM XaCCblT+tt/njfEfXk11NdBQvMJFY9K68T3AB9BM4T4hzxAIg8nspK6Xw26kNj3fgtGBjq1YTFYG0 NpHcJ95pUglVE+lzam9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi9-00B0A0-15; Wed, 10 Jan 2024 10:21:25 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVhz-00B00S-1L for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:17 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40e5701cbbaso2090425e9.0 for ; Wed, 10 Jan 2024 02:21:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882074; x=1705486874; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uJiSbOx+y9kAD9nYaP7HZ6jgQVEvK0yZ8eFJjkZeaz4=; b=nBwAl5ck2l15rZVNTVrfdSgUxk0omN1GBd8Fu9GOPniuBWqitCTY70k0RRev70jQ2m mnpPEJ3mNTbeoAjPjtntd2TiaofWfwfsLDouj9rSJOC2WkD6BPobQOI14O7lImpeD3gs 92AUqAuB3v8krH1xBYF9dnWaoyKZSTvNfnQxG96l8mcDk2zIPAj1QWt6Jwqh2oT+XaOJ 27JuiUQ0xuNDo0/Ymquh8mpX9PC13SrtzlTm4OlXWXqQt0bFGPg1wzL0JUhsnoR65DvK FwzhFFWmwkTvzjj652LBBQRWHMLN9NLXkpb0uA8ufUDLHvjBXdalDKMLHrqUkx50vfpK b2Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882074; x=1705486874; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uJiSbOx+y9kAD9nYaP7HZ6jgQVEvK0yZ8eFJjkZeaz4=; b=CvB1yq+6GnpZhk4PWZObrnfQpJivdZ7pKzXOgROasYYJyLVUkTQgHNWc9frRopbZFr YtONZOIgKPy7VTnZdybdI7XrJEd/NKyMR8kPLTC9twJ8fsaM85WKjCnA/U5fwhq652Vd PSiXC8jSB/lSUyv+3JdUtsRX7BMhpRZh/qZIUb3vgpJY8PsTuFmqlwWAFlOkDM/wIAPb dNB9EVkIcOl3fGrVcTxiqEiXfwvXRvTRJjcDnrpDOgCoqrBAFvnW3vj802/oAyFqwN6N nqgIDOlP0I3YI8eX0R/O/2h2dFfb3CFIIGF9Wl7UprnMORxqg1bUC+R1K65LhsOvgcW6 raqQ== X-Gm-Message-State: AOJu0YwMasNkVcr3zpmxfr8a2vy4RWxIBWtjvrucHvvxMTiKCpD6NaUt X56rsx3/EjnKoeRH6zZGlto9nmdrhRvDTQ== X-Google-Smtp-Source: AGHT+IF1VVx7NZ4+jYpZe5nZJn+QtrY9rCxcI5pj277eW+yQK3URG35FfJHed1DogBS4MlQyh203yw== X-Received: by 2002:a05:600c:3b97:b0:40d:94ba:cb8c with SMTP id n23-20020a05600c3b9700b0040d94bacb8cmr489208wms.109.1704882074171; Wed, 10 Jan 2024 02:21:14 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:13 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 08/18] tty: serial: samsung: move open brace '{' on the next line Date: Wed, 10 Jan 2024 10:20:52 +0000 Message-ID: <20240110102102.61587-9-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022115_502354_539F53FA X-CRM114-Status: GOOD ( 11.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Move open brace '{' following function definition on the next line. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 11ae3a1dcdc3..b9d1ef67468c 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -1740,7 +1740,8 @@ static struct uart_driver s3c24xx_uart_drv = { static struct s3c24xx_uart_port s3c24xx_serial_ports[UART_NR]; -static void s3c24xx_serial_init_port_default(int index) { +static void s3c24xx_serial_init_port_default(int index) +{ struct uart_port *port = &s3c24xx_serial_ports[index].port; spin_lock_init(&port->lock); From patchwork Wed Jan 10 10:20:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515904 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44172C3DA6E for ; Wed, 10 Jan 2024 10:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/ve7UIchqsqQWxc8vL7LnriubdIaq5WC5zj/Y9M9UcA=; b=DlJU0UFulXdsiS diVP8mVecTYj+0VqpSEeC+q0rSNr8MjPC+X4+eCPcJqAkArejunOZdd/tAxm62O2n5hBlIcs2Xm5B EtHR/ZSvkblRSBIjP+In+IDoiwJ+3elB+9pB+vOlVCh1rxXxCqI/PhgUdwu6NKqQp585sWAynVMP8 Y6sS40t8vEtZ+Z7KG28Avd/j8VW1mAVzyOuJvNRsA/odWS08wjr7uj/ktRJLwLZQWZyjjXmO/rGTO FGaR6durI2o4IC9SMXvT0zda5WTbJDVh+hY/AvUfIzLwVsegBt8OX93ysQlzKR2fQQEEBElBJO4yB W5nnA59BQWHCnaFEA1MQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNViL-00B0Jl-1z; Wed, 10 Jan 2024 10:21:37 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi1-00B016-1p for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:19 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40d88fff7faso41078515e9.3 for ; Wed, 10 Jan 2024 02:21:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882074; x=1705486874; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XpLNRFI7Q+nWhYT1sc52rnbfGdxVUedlk9wvDQAxZZo=; b=LD1dIH7QrCJxYqPHoUQdvdL6yuAmzzD7+oSIR4ShNxMkJ5jXksgi0eVZphRp2Mv3lT QH7AEyskAE+v5yO38EbefYjA+6A5zDVzRBOAgWDOUn7R0FLJJvkz3gRodoKNbwZ+uudb 3uD5/joXf6rtMAfB6wvYCeZX5p/v8D1fEKLMg9U0e7Ohv7uhRqOY+CwLXT4Jc9DUO09l wGzz9CxdzzKFCOENdtdtALS2Wy3p/X9uqmCCWAKdc5ZkLG3pVFFQGdBuM19YaBGuROdg yJVln8vlAOhS4Peu/xWHouHHBBpuOAS1D1WgMsuJkBFnRe9JrCGsf635sIpdMHA40WyC TNDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882074; x=1705486874; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XpLNRFI7Q+nWhYT1sc52rnbfGdxVUedlk9wvDQAxZZo=; b=KIP4Tm2ifoa0ZhSRB5DJ4KQlVTf0w1v5sB74NqdAREDpSFc0jQlq+lxTD8t4kAOKg4 lXkNFbCq1YKzMRiaGf8/LyB3yza9QGNmOonxpv0FpIrvb4ye1IASHcrx1IzK+NAkmfzv MBp8FkRU0nnrQ07/0XRrk7FQCGDrIKWLR168TnuTa5OepsFGxEsD4IiL7EKkBlhX2ldC 7OIePlDgJ0n0xIZ4WPqPfU5/jKEi8FOBa1xQ3tOxM9kWCfRwjUmaui8AuHQOOWLA9JZE SwiShXhdt7AwgU+9OszbqDoSIaRq3hDoXkdrqJXlpcEjFFr9sXIggfehgcx0bl/02P0C dWQw== X-Gm-Message-State: AOJu0YwckmVJs5yaZ1/sPmBLX03VBiFzRByjm7CfZOyzLPy7qG7YAhLZ bJiF0AhzwDi4FYmSxsZ/5PttsYY4juYDvw== X-Google-Smtp-Source: AGHT+IGUYbHFbchWngawNO9+st/Bnrd1dMjCfFRd06ZBdJ7tUXEyUMFqYOKHkId3ObbsvmgEoSrIWQ== X-Received: by 2002:a05:600c:2195:b0:40e:42ce:1b67 with SMTP id e21-20020a05600c219500b0040e42ce1b67mr192335wme.246.1704882074792; Wed, 10 Jan 2024 02:21:14 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:14 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 09/18] tty: serial: samsung: drop superfluous comment Date: Wed, 10 Jan 2024 10:20:53 +0000 Message-ID: <20240110102102.61587-10-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022118_122609_0958D17F X-CRM114-Status: UNSURE ( 9.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The comment brings no benefit as we can already see from the method's name, ``s3c24xx_serial_pm``, that it deals with power management. Drop the superfluous comment. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index b9d1ef67468c..90c49197efc7 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -1296,8 +1296,6 @@ static int apple_s5l_serial_startup(struct uart_port *port) return ret; } -/* power power management control */ - static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level, unsigned int old) { From patchwork Wed Jan 10 10:20:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7779C3DA6E for ; Wed, 10 Jan 2024 10:22:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ai+b+ZlhVVEEGSqtWn9nfPq/GYmSJ35EcnWDCZjHaAM=; b=kGg5v9wrseTD/m keWmWHXCyYASBK9odjt2UTMa9STp5lbXlsCZkWnEof4styOMqK22Y76s6OO2KrnAEx35zKQe5DgE8 6KaEU9XnZBOBh4ZAQ7CaGhdqYAHPOudUWWJqsPqrghDgJA4QYYHMQyVC12bfxaroQcnA7SDtW2OYq 5uKuG6rbJUiznKtYHgMVmpXhmZ6TxkT/UTrbcP/utJExGGTZpEP6GU54DpeU/j2p7Pvu2TCaBdlnp C8NesNzRTXQPMkZCYK3IwZ3j6GYc25KvGtFUNQTeGJri03Zbp+PEqRe1uhyqaUPt/rLWyw4J9Werl ti0Sv0SxWgY6qurdz3ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNViN-00B0Lh-3D; Wed, 10 Jan 2024 10:21:40 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi0-00B01e-26 for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:19 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40e5770d34fso3221415e9.3 for ; Wed, 10 Jan 2024 02:21:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882075; x=1705486875; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2v2KRYXA+keXRfq45rf7VwhlRc8wCU8IH+wWuas1Yt0=; b=pdAw+I48nGFGi3nxf70cjL07SUUaZmh3xMbgpd6KaTUtICvRmiSDLuhXotiwsE3VJh DTw28YFIm0BbIrrfyM72cde7VxANkwghzC7krRliu8WosoQju5MnnO1XrS6M2C0JCmzW c/KeMowLTC/kNcjmLGtvrBKtcK0afe3ctlZD5el3vNTRH8T38Mx7czWPWyijtPP7MvD+ g5hVD4jxs+/sJCrGKtH44Inrcfekpt6RO15NuhaL9U7/vU92zwYjlpG3zVFZkQfWCzSH mHOjlhILs92xQAQTUGKVNNU7c1CS7/pmGrtuplbP+3knlcXGJCp6rJVLyN/zQj5+fF3L xGFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882075; x=1705486875; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2v2KRYXA+keXRfq45rf7VwhlRc8wCU8IH+wWuas1Yt0=; b=qsv2/L63mBdB7J7pQzLE61d01O6P9vC0Qv5+TsndxdFiI4TMMhhru+eNohBI0HOoJ9 ufXA1cqQIyJj2+a5cfmMZAnmKLfcYQqJxa5SeiSGCBauGIsmSDvAb877H5xm6EVYHHHr r3cEWqZf45/RXzSqDJzGbvUQAPgCStopjyPih/EgD1twgzaTytbvd/hjd3AbQk5CY5kB 18zshVJ8TERXmcsk1Ymjxiv9vbkKM6Q96VK4xZCI6gBKNfxvqNV9ZcfLNUZoE/OrXMW8 RxGxyNoNBuMUw7+q8nA7HljaTRHcRBMTZkSRkFWR0jrtu3ZYpu+mKiE9DkESJH09ykKZ h/0w== X-Gm-Message-State: AOJu0Yyhhh//6KImKaxqWqrN9+b45vgEHTaLAFpsWU+MxyzEUETgSpO2 8/JpTpqbme5jJQij9pNyVcgQvznrTpywJw== X-Google-Smtp-Source: AGHT+IGLeDeKQhsCLP5+R4lOabowbyfiHLzCDX82nYtvoNIupA5AR/1fHezyqisxDb7TJ9bwCXPMhA== X-Received: by 2002:a05:600c:1d95:b0:40e:4084:b948 with SMTP id p21-20020a05600c1d9500b0040e4084b948mr414155wms.94.1704882075513; Wed, 10 Jan 2024 02:21:15 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:15 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 10/18] tty: serial: samsung: make max_count unsigned int Date: Wed, 10 Jan 2024 10:20:54 +0000 Message-ID: <20240110102102.61587-11-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022118_107897_96446461 X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ``max_count`` negative values are not used. Since ``port->fifosize`` is an unsigned int, make ``max_count`` the same. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 90c49197efc7..dbbe6b8e3ceb 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -760,8 +760,8 @@ static irqreturn_t s3c24xx_serial_rx_chars_dma(void *dev_id) static void s3c24xx_serial_rx_drain_fifo(struct s3c24xx_uart_port *ourport) { struct uart_port *port = &ourport->port; + unsigned int max_count = port->fifosize; unsigned int fifocnt = 0; - int max_count = port->fifosize; u32 ufcon, ufstat, uerstat; u8 ch, flag; From patchwork Wed Jan 10 10:20:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515906 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 739A9C3DA6E for ; Wed, 10 Jan 2024 10:22:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PlByeNHjt0XxJXH76Lu4GMiI9W+4qqIp69dAwRabp60=; b=IhRs9bp2GCkgcZ BBgtA7pZJlJGb5+91yFafMrSbs57I9CtZmgD2QZj4MquurvgCpZqanfMtuzdCW5Fp5TAHXf1uHAT0 JaygYv+/0bwvrluVAylkXwmrLYuOcPnaOq0pWhEUGPkSvA4SlGZRzLzjvwq57FhA2cooKpDzvhaL/ 5XBVYsjcFKIAhNfHJztZ00pg573FHHzcBizG4VwjdKpT3srP/swMiUJ1UX2Es+5cJmgwWZ5nFTO0D gf99h5ELuoa5vaQPu4AVa7TbT87VO/HPns9MslR8/PqQQctNnotXEgBQCwqTi4HJhjzaBwDFCAWgL ufHzd9mCcyBXRfKSnL6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNViV-00B0Re-1w; Wed, 10 Jan 2024 10:21:48 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi2-00B01n-1z for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:21 +0000 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2cd56dac1adso34669931fa.2 for ; Wed, 10 Jan 2024 02:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882076; x=1705486876; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nZqqbWPwYwhLrpcSvI/iFs7tmVPH9J4dNpzf8ql04hU=; b=m3nCaXlXntNYlqqPFVoAOb6goRoLuxVDd8ZoYzVwNFDgdCfXv9QV9FfvLmtSpABcot p+0VUmsvIh2o9w85j557IHsjLfJF+eKJFaBVASRGrR16IHmyzk/iRrXT5mMeN8rJbAv+ hUXkF5+ASXjCXmSMLeIFFiMmSdf7jjWvfPrK9SxV7e5r+F4dWxiINha9QB2Dk8rqX2mm PfinzZOMs5hCE171K/9SdnGFtzqcXorrW6O3i0YmfdUgz0aRxHuTc2fGGSPpSthiGSd5 TbyTvUmNTuBo1TslTqAbcjESu6+fDlldYC9U/jlSU3PRCVLfo6UauJ+HWD5Tp+BWxnJW K8Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882076; x=1705486876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nZqqbWPwYwhLrpcSvI/iFs7tmVPH9J4dNpzf8ql04hU=; b=rIR75R4qqtrxYTnj24Se+N2KqbbwHGF3WfO35hFvYyQfiw+pfE7A2aW0zvDgdeWfCz hssL2JjKNoO3PerlufJ4+QaEaFK4Zvy2uJMDpBcKnVw2aHPbj/sfX2yodr4ooMji2cd0 EQeB4t89wCwWO6VLP3Al241Re2PWeygov7oT/+m0sENsbqMYyHNVZ+jly64VTKJUVnqJ N10qfuovPEZvnop8X0ZjSFRe2otrZTfvYWvCyuTKvPIqWnl11bHVtnE0YnewaCL5We5V em3uNf1ixc4/s6vtvg57F5YW0qgAknIeN9WE+J7o8HOTji2+JPvtm1NeB8hkQhZqR9Ut xSBg== X-Gm-Message-State: AOJu0YyC+gw0CcEzpo/m9ET/qsn1+9f7qNNP1Idvl5Y0BVQLP9wAFTKj xrSu/MR2GvwKexwg3+3gODgPzqP0zg8RuQ== X-Google-Smtp-Source: AGHT+IHUDinlorp0iKAoAamRhoFsnXh8pnrCQea2LbnsIeK75SvmBljlO0KL8/orqVUjuZxufpV6mQ== X-Received: by 2002:ac2:4554:0:b0:50e:8137:9a10 with SMTP id j20-20020ac24554000000b0050e81379a10mr307722lfm.129.1704882076456; Wed, 10 Jan 2024 02:21:16 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:15 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 11/18] tty: serial: samsung: don't compare with zero an if (bitwise expression) Date: Wed, 10 Jan 2024 10:20:55 +0000 Message-ID: <20240110102102.61587-12-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022118_663548_76B2B164 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since an if tests the numeric value of an expression, certain coding shortcuts can be used. The most obvious one is writing if (expression) instead of if (expression != 0) Since our case is a bitwise expression, it's more natural and clear to use the ``if (expression)`` shortcut. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index dbbe6b8e3ceb..f2413da14b1d 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -988,8 +988,7 @@ static unsigned int s3c24xx_serial_tx_empty(struct uart_port *port) u32 ufcon = rd_regl(port, S3C2410_UFCON); if (ufcon & S3C2410_UFCON_FIFOMODE) { - if ((ufstat & info->tx_fifomask) != 0 || - (ufstat & info->tx_fifofull)) + if ((ufstat & info->tx_fifomask) || (ufstat & info->tx_fifofull)) return 0; return 1; From patchwork Wed Jan 10 10:20:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90657C47073 for ; Wed, 10 Jan 2024 10:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GgJLmIGzX1m+rDyNMyqvDml5boiJI/+ZGkUwtEktgQM=; b=u1QqP1Kxnbb70o sp94GpAxZ7g889J1/F43mCkc0cC6hZlvnlUorp3uLEQAkxCTnaXjcSPcFYaErlF4a2g2usai0GDNK HLh5EouXbctUwmvp1PIrqpK83s3iHq1KyjWSkVyGXhjmKMm3DFK3wrgbigKv6oCVtm/az9pkxSb9v nWk9uvjrXcz994/Uhuzr0/E03D474sRdGDLbduE+X2rOJmOcC2RSa8XzGx+K6iGjEdnR99Vw7kkMD 5bs8rhtfkxnOiDTsM8aJ3Chm57uCaHBry5CFHtTxXrekOitantZsYTykrFE032GVDX/FCUM120ja1 Bg1Q/Fr0MqQkUv2exnAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNViP-00B0N6-2i; Wed, 10 Jan 2024 10:21:41 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi2-00B01p-1c for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:21 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40d8902da73so37762485e9.2 for ; Wed, 10 Jan 2024 02:21:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882077; x=1705486877; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X4OrxluJS1Dxt0QsygYV4JA7ss0pHdXLycYpqP8S/nY=; b=uAq2+FbEXIHOVUyP4k5et02ihEVVIQvODYl/g3owpXadq4atM87XmjvhEO57c+DQxu qOPaZ6riChWORfMrYSsx27fxGBH7tpEln7Fr828t0M2AYX8uHToBWvsw0llSb9aWGRo8 Y+HKbhbN0E6R2+RZfchVRBJI0JbFiLMoUpfv9EhhpLEx+eS2+Da4lXwK2h3JdKoDLjcO 8g92I8fHOKYh9hHnQeVZ3TISAyMM9GsA7TPxNPZ5hVs0pZaW0zpuTsFZ/OtHCHoHD8AW dIaVgcDWyE3zx3aVjlnY4a72QbW8EIb/d/+/3b3mtJSZN5AScis9+pWKsbuFPtP61USR OFlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882077; x=1705486877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X4OrxluJS1Dxt0QsygYV4JA7ss0pHdXLycYpqP8S/nY=; b=mtOxJ/liHpQuedzqpPURbuWhGxjk0ziWAatoizut9Pl8eceOvqOnU8ZZ7rNNIewRTt b4s4pdn6aoVfQ7/2ByzUuBCikVq2usdLjOJGIwlacAg8JEXdWmDZxdSJemq+mRHx62aP JUsxatUHkHmyrKzk0lUBF4IxT8Brwd6YIBQLzxYF3IpOcMUU0qccgkqYnpzEP2Qc+ggF VtaqM/uRrkGRzmsAgUQnaQRMGk25XTztARl7ouVaHX5zR27IdpDwcnfg9bj4/ykmEMpu 263YtI1rOq3w/QysjTHkjvCHnzwuUnYPb/XF4YmuQbJywIBQK8fXlfth46xYQF9jxxHP 1avA== X-Gm-Message-State: AOJu0YyJBmS3htfv4Tjpf/AEjnzUdOCXmsCmBRphP4KlZKSlltMhMqSe U7SrzXiSWdOhxyZ5W3y8A/o6RvqZzH7c3A== X-Google-Smtp-Source: AGHT+IH2pHpqQ2IvcL8mLqW4mDIBGBWO/XFWarVigmK91FlJxQn+wyWXYGgkF4J4hdXMLY2WPdpvQQ== X-Received: by 2002:a05:600c:511e:b0:40e:42b4:23b6 with SMTP id o30-20020a05600c511e00b0040e42b423b6mr498393wms.55.1704882077261; Wed, 10 Jan 2024 02:21:17 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:16 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 12/18] tty: serial: samsung: use TIOCSER_TEMT for tx_empty() Date: Wed, 10 Jan 2024 10:20:56 +0000 Message-ID: <20240110102102.61587-13-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022118_545381_7A17FC3F X-CRM114-Status: GOOD ( 10.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The core expects for tx_empty() either TIOCSER_TEMT when the tx is empty or 0 otherwise. Respect the core and use TIOCSER_TEMT. Signed-off-by: Tudor Ambarus --- drivers/tty/serial/samsung_tty.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index f2413da14b1d..46fba70f3d77 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -990,11 +990,10 @@ static unsigned int s3c24xx_serial_tx_empty(struct uart_port *port) if (ufcon & S3C2410_UFCON_FIFOMODE) { if ((ufstat & info->tx_fifomask) || (ufstat & info->tx_fifofull)) return 0; - - return 1; + return TIOCSER_TEMT; } - return s3c24xx_serial_txempty_nofifo(port); + return s3c24xx_serial_txempty_nofifo(port) ? TIOCSER_TEMT : 0; } /* no modem control lines */ From patchwork Wed Jan 10 10:20:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9044AC3DA6E for ; Wed, 10 Jan 2024 10:22:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MukK1Z3CwrOec6/n4tDuQ3TRfyfzWCG/nL7gbi3CCxs=; b=D2GUgw+X7p5p16 OpS2R8dRiKm8bY5Z8Kngq0aubVibldX1SeI+iuBFQu0FbSlsbvRY7lI7+mQVcrpM8GDWDPV8UTB9h FeDwP2FH3/CnweTf9VWDM4QYbfOdxAXgX3KYE0ERKdEFbVBPBFzCL64AmHqRw7WUHzfwM3htLvngO cjrUexY1Owc0Mvwg90oNMd7gvBw54kURaB6yLFV5bUfJ2QfYKLVfD346nF5AF28oWLNrZrXzAIsz3 cJXoSPIoS13qH8ojzbz30UNEgJAOJIRB29qQxvohaqiTPnnin0DMuWvtNovwyFYG/FXzDLqBS2JqX nnxGOw3WKJpXDZ0r8oEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNViS-00B0Oy-0a; Wed, 10 Jan 2024 10:21:44 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi3-00B02g-0X for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:21 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40d88fff7faso41079165e9.3 for ; Wed, 10 Jan 2024 02:21:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882078; x=1705486878; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zUZkD3RxZyomRUtnLq1bNhUO9I/uygo4/DAHV/FeOS0=; b=hjXNA63/c7tWlwhjQHafLjAkBgm9ykkoQhzE3QGBYOTA1mMemu95s//LMZR37IGQyq SnI6VdqiI31xFRgqAxs8LcoW9eU4jelJyUD1MpASj86GEVx/EuQViXKW1oozsDPuQ2tu 2eY4P4Tj1sag3K+5yjaKV/GfmtYBotfsQbBIzfmrZ/v0LnyinBxd5DbbloI7pMi5P0V0 kcOhrarqoc76ydLmzjq/6vm7nmURM1ArOsxEdv/cMVO4s5G+/WLRsR+4fsyZuI/LffBM uwnRjMDVU6VY/z6Vxckv33mCOPAMXLldCFPdt4qTafNu0sX4z/Sk5AvuOV5G05lmcwEC l6QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882078; x=1705486878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zUZkD3RxZyomRUtnLq1bNhUO9I/uygo4/DAHV/FeOS0=; b=NpuovRUbQmaCjj90gkUWkHuDCTa+SrSgN7KCytxaWnabtncRNzwkWii+JPocLmAIm1 WKQfLJjBf26/6/pGQCIYrEuwMVJ34G7IdDy6YrMDO0e4iZFh8duDE95vlh2ZpQ/KmD3o mnPRwrlcesX6o1S275zJ/BYm7odzFQQ52Ce/GqrW5251ogaB4entbmhcgZxB4uo3gzjw AKSxJN9WEtUNOY5ud7DUt819xYXD4b2vk68BXo0MC7102dKGtHzKCdDzw0fGFJhfIBTL tLpMtcottNU8Spcq2yJRFm72MWBt85ILZ8CzGdeL0wFm3TBAqWLDiZvmYxfY8HdI5k60 /RAQ== X-Gm-Message-State: AOJu0YzQnsV4EWyGCY6UAeXYldlNE1Jlv2OMSFR2sAJQ3hpypN6rS/oG QhbXfAvr4G5HYtA9DjvtJEABifiitq9ygA== X-Google-Smtp-Source: AGHT+IGYLsOFrNdKSYUGQJjzwSLK/RYL6+X1/WFxwE+OfMrXS+TWExfIax6TS45wnteKjsb5eI8ulg== X-Received: by 2002:a05:600c:45d2:b0:40d:7c1a:cce4 with SMTP id s18-20020a05600c45d200b0040d7c1acce4mr208326wmo.213.1704882078025; Wed, 10 Jan 2024 02:21:18 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:17 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 13/18] tty: serial: samsung: return bool for s3c24xx_serial_txempty_nofifo() Date: Wed, 10 Jan 2024 10:20:57 +0000 Message-ID: <20240110102102.61587-14-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022119_260879_A9770594 X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org s3c24xx_serial_txempty_nofifo() returned either 0 or BIT(2), which is counterintuitive. Make the method return bool, and return true when TX is empty and false otherwise. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 46fba70f3d77..63e993bed296 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -236,9 +236,9 @@ static inline const char *s3c24xx_serial_portname(const struct uart_port *port) return to_platform_device(port->dev)->name; } -static int s3c24xx_serial_txempty_nofifo(const struct uart_port *port) +static bool s3c24xx_serial_txempty_nofifo(const struct uart_port *port) { - return rd_regl(port, S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXE; + return !!(rd_regl(port, S3C2410_UTRSTAT) & S3C2410_UTRSTAT_TXE); } static void s3c24xx_serial_rx_enable(struct uart_port *port) @@ -782,7 +782,7 @@ static void s3c24xx_serial_rx_drain_fifo(struct s3c24xx_uart_port *ourport) ch = rd_reg(port, S3C2410_URXH); if (port->flags & UPF_CONS_FLOW) { - int txe = s3c24xx_serial_txempty_nofifo(port); + bool txe = s3c24xx_serial_txempty_nofifo(port); if (ourport->rx_enabled) { if (!txe) { From patchwork Wed Jan 10 10:20:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AE07C3DA6E for ; Wed, 10 Jan 2024 10:22:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zb2Tb6Lis4houSHuROuc7kR6msaeFvc3F1ao1SAbqG8=; b=EacuW4b3kv+7oy W5pz73wojgtMxUVHubzJgaD5xSqXTIsuxEebQBKVBPrsUDVo9FZRgLgm4kdOk/4hXPDHjh3/nTMwm RNM3QWyHCo1nOWIciEKr5Ff6LXz08xGDx6t3qfyoSOZDCKSRtTQLrboKjjl6+a0tO2N8ImUctQ6WE VW+4ZWs4uwcp/phCBIrlFYcD2jcjvn/vUuO++rHW+PwfnzmHRGEP9GvXUFXnkObOucwU5dvYGi7yr iGjTwU9b/an6eyT0kxqQFlhs8waFfpY1NOzFvpcuvGOhoLaYSNNqMEjDXJrN0qHSwWgg3tQL7Stdw XnPZQu+JI6j3ZpTB2BKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNViY-00B0UY-1y; Wed, 10 Jan 2024 10:21:50 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi5-00B03l-0Z for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:23 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40e461c1f44so34903625e9.3 for ; Wed, 10 Jan 2024 02:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882079; x=1705486879; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UmHRPW27RDnkA+g75aUBVezswJMsnzKsK+kYqojzJWA=; b=mtuu8koAm/YdIOpJxjXQUhbxtcNo4LU4vjjQBJN8k/IG4RVGweEyHfvNEcDx8MgUme e/xsYaI838k85HYiLPKitHPPD3rzYDEIbKgo/af22qFcIfpmd5tRMOP0Xm4RF1KAqwps I30vVQCZTWN1f8/NAhaVexf9BIKhU2jLAWdPcecS497VXaqgKNkgMD+QbvoE2GfddAny qQS0fO7B+h1bqKrQ3y29hRzr/db4oTVuYOwN5hakeQLcuBvKriQ3V6w97e22m35uR0qa NSkviKBYE2EuIfo4QgEaDTSl7vufVYS5Q994cxiYBJ/bXKhwH8I8FF6ZwyqKUDIb7ODO f0Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882079; x=1705486879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UmHRPW27RDnkA+g75aUBVezswJMsnzKsK+kYqojzJWA=; b=UKVEWh9ldOPwmaftjaqDywhKZ9xX3UfpwnMcRkRsLRSMf5VGEfs/Abu3KFBAsp/xy7 FxEwidipOZF2YycNVmqNoAnHGvtb0pPOCdHpvz0VydYHPuxAC8RKRG+IR0yo0QXhpytj bSlTfAGip4i+jYuvQTw0KnTYRSaO7GqUOXfDdirfgP0bBtk4TejOND7FFTGQmOlzEn10 xsODOfqlHdfuJ2vtg000D6lNuSs/G37JdFSvOpFmXn+UQmBSdm/4+TtN+Pr/zAN+tMBj 0epXRd41f7WY9BCQTQaFhB8FfEx+ZOeAn9aQ02wsCwhY+WMHFChgbkNkn+sy5O/PKALV Jlqw== X-Gm-Message-State: AOJu0Yx9D1w29VlNXmNx0z6Exef8BMdlF082i6T0RG1brZa1FQ+tEmJh xuB0vY6QI4btITqD+AmCn5f3CEGJViPwuw== X-Google-Smtp-Source: AGHT+IF+Oagp4pVfoPn3Qez+PCLQ0H1IzVpFxNqvHn3qcWSqeS9VWnZ6GpgOzUfsQ+2xzQchsRL06w== X-Received: by 2002:a05:600c:45c6:b0:40d:932b:c4eb with SMTP id s6-20020a05600c45c600b0040d932bc4ebmr405924wmo.176.1704882078926; Wed, 10 Jan 2024 02:21:18 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:18 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 14/18] tty: serial: samsung: return bool for s3c24xx_serial_console_txrdy() Date: Wed, 10 Jan 2024 10:20:58 +0000 Message-ID: <20240110102102.61587-15-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022121_251439_CCBAAC51 X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org s3c24xx_serial_console_txrdy() returned just 0 or 1 to indicate whether the TX is empty or not. Change its return type to bool. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 63e993bed296..37c0ba2a122c 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2183,7 +2183,7 @@ static const struct dev_pm_ops s3c24xx_serial_pm_ops = { static struct uart_port *cons_uart; -static int +static bool s3c24xx_serial_console_txrdy(struct uart_port *port, u32 ufcon) { const struct s3c24xx_uart_info *info = s3c24xx_port_to_info(port); @@ -2193,13 +2193,13 @@ s3c24xx_serial_console_txrdy(struct uart_port *port, u32 ufcon) /* fifo mode - check amount of data in fifo registers... */ ufstat = rd_regl(port, S3C2410_UFSTAT); - return (ufstat & info->tx_fifofull) ? 0 : 1; + return !(ufstat & info->tx_fifofull); } /* in non-fifo mode, we go and use the tx buffer empty */ utrstat = rd_regl(port, S3C2410_UTRSTAT); - return (utrstat & S3C2410_UTRSTAT_TXE) ? 1 : 0; + return !!(utrstat & S3C2410_UTRSTAT_TXE); } static bool From patchwork Wed Jan 10 10:20:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515908 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D36DBC47074 for ; Wed, 10 Jan 2024 10:22:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cKHYeo7/05Yv0GiVCIp3owG4F3zhQY3fsA40YPc/9OM=; b=LwKyHJRBP8IkQQ ymm4XybJ/6tpYhCVjT8cKl++lmGbVuCc70OEI4ZNi2zR9SKiDU07LiZJIZuYE+UxqmnR+eZ/uoKJA /xnu+qqHsu2Nt8EZrWwFB/hTEYENpwc7bOA10+EWcymh8S7STI4XKzOWrxXxSasQaZdyYz5zG62LP +Fqa8dclC3jG802kLuHSAzlXf7Cn6/W+Wbj92SZrRA58zRiw2hnjdUNjwRLcgKZta03SMUmYu5a8q dPseKl8KFyvlRQBoWYaU91iWHzU5HQY6Tc77yaF8oOPQbciy932M4NUj5AmMAURzkTEeaM1QDz80o 1MYeid95uiELrIMKNTKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNVia-00B0Wb-2T; Wed, 10 Jan 2024 10:21:52 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi6-00B04S-0a for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:23 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40e5701cbbaso2090975e9.0 for ; Wed, 10 Jan 2024 02:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882079; x=1705486879; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=usOFTN8z9J8oP1ehPXietRPaPrvt1NPPISnLCzCNgPc=; b=Ne984Ermw0b1UDnqGZkg2FGCMI5JWQeb+0Yq4lv7KvSjtvdY5QMkJuzRg3qb8cE/iQ ahcMhybxQr7kxsxYq/3s9Qp7FZDyQxL/MRXsQb/lpwc3q364xU3PQ/90wGc3LDMbEspD sAIAN6BQM2D5yaIzj0xZXSmZ2QCSfa/Syzj9tcl3AXHGjThBpCvsZHkx7iv0AZl89i3C D2kXzyleIBI+geOkWGR7IHwI6Q1vu60SXYcJjaiGMeamoJ/iGGBCizGQS51EnYVjfhb9 hjWMFjLI61vCtVTiVbkLysoaQrkYdUTxorQZzy/Mi6vx0QZy7nXNHlWS7TIv/71eFTvT uWlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882079; x=1705486879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=usOFTN8z9J8oP1ehPXietRPaPrvt1NPPISnLCzCNgPc=; b=hvp+IGOaJGBz/HRY8xOBaPZQoTvWsXq8OQeQ2tLEG6Wo3QyULsYbB+ZyRvswj5I411 ARF0a6YYjPDieql04XkuJ2TG5V1moR5lPR3z/ZO/7UfyxyUY2wkj8dOzsl15QaElnnMK tUcDsTlWlYRwXN78gMjFGkeFP1WUvadWopVeIVUMRwQ9eKZTJE6EPVzINQAFpXrZpVy6 hQvPVY7VuYgBKXmptRZSF+Lg/Hst87RB/V1oKmV9AARkpvP2Je8g8eSn8uZugXEQaQGl Q0ZOvhVv0EalnBAh4t8XHn2tLid0O+/nUPsqfdfs73eZ8VpZrI0Jx+3fp2ArhLohPIKI 5fMQ== X-Gm-Message-State: AOJu0YwOsU0IeTZC+0MnaIi23ysNUxD1c/aFfKQVKjdLtjif3ZY4ucgN PzGg5SVkg+FlxhTLzDB9DnEWt5VaSSrlTA== X-Google-Smtp-Source: AGHT+IGDIg8QSdxKZ/9GjLkRR0mxgPFDnsnalInD3L7mu7gsQjaMvnyMWk8ZG1bGrUhDYCOjPQyiAg== X-Received: by 2002:a7b:c855:0:b0:40d:b191:10e with SMTP id c21-20020a7bc855000000b0040db191010emr577084wml.175.1704882079484; Wed, 10 Jan 2024 02:21:19 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:19 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 15/18] tty: serial: samsung: change return type for s3c24xx_serial_rx_fifocnt() Date: Wed, 10 Jan 2024 10:20:59 +0000 Message-ID: <20240110102102.61587-16-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022122_357883_3F60E28D X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Change the return type of the s3c24xx_serial_rx_fifocnt() method to ``unsigned int`` as the method only returns the fifo size and does not handle error codes. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 37c0ba2a122c..436739cf9225 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -590,8 +590,8 @@ static inline const struct s3c2410_uartcfg return ourport->cfg; } -static int s3c24xx_serial_rx_fifocnt(const struct s3c24xx_uart_port *ourport, - u32 ufstat) +static unsigned int +s3c24xx_serial_rx_fifocnt(const struct s3c24xx_uart_port *ourport, u32 ufstat) { const struct s3c24xx_uart_info *info = ourport->info; From patchwork Wed Jan 10 10:21:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515910 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A6B4C47073 for ; Wed, 10 Jan 2024 10:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5DR7hq2Ts8o/mtvcHWKLtVthQQ9VlbzGCgQh6bgmyh0=; b=XAaRfMXktFM3Ge hifJTo/YU+93avmqupSHcMmiiHCuWZKQZuVoAVD/8oGcwFbNRiHBZFMYaUYYCOaQN2L24EjEvKxDi z4VhxTjbEpJuYpCDqQnQzqIYiGybt0LrALU65UAZ2goK4RzaM6oEA89tEM1QFGPvwZ2b8MOr31frA O0afO9gI6r17DkqiPY4ymTt6qFcaDTlT6HCCmG9W7kIltnIZomzoIe5QSXAk3tHysz2yG92V8M4e+ jQWRWcOXODaPx0xCuBXMkLlZAF7e2wkMmqbFhxWF+M/IiCjwmewI5rFzoQbRdovESiB3Rs9K5GmFv 5VVTcNBjMWq4VtnfFw2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNVii-00B0eF-2N; Wed, 10 Jan 2024 10:22:00 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi6-00B05M-29 for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:24 +0000 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3368ae75082so2793563f8f.1 for ; Wed, 10 Jan 2024 02:21:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882080; x=1705486880; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L7ZrSjFHYr2/iB6uZVD8VtG9hhedczp9x5lal7G3QGg=; b=HZlK03uN7btNolYHZyh47xvNsityGEa7B4+FhDkx1BGlGqKxzSJknApqQXnfmakN1i +YzgF2ibMuyyQ5udgMK4f36WvxJeBOI4iyhxJFeBi40EloaGZ33PwD1cU2jm9IS/xGIP MRAHlVOUNwvq4pKB2nhaAa3jDsrXx26uHDUFOYl/wQ7CLHhpGkIZH11hGbAUCitOPB3+ ceJ0hlNZdLOOSzyRQJFPOB8fToi59QCRUbyBhjK7/CAyh0ocKccb+nrG42maUt8jaP1z xRKHWgEb2z942UJH/69KGvTLUTmjsFXXByXZJ9aUzg8iia/8jqvyjn2Fp/8t9LMfEG1u va3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882080; x=1705486880; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L7ZrSjFHYr2/iB6uZVD8VtG9hhedczp9x5lal7G3QGg=; b=cP/XqGLIPOur/3tu2WB0X7kwE59WGz6j6z+JfgIvN1zPZ6RawDgB8+1yx9NB3d12/9 iGL/7m7EiwrDVQpeSGuR3zVOL+AWu9Toag6GOQOfdI2olaurYIXl/Q7UP25+0xAyRXYe FaNhFvF4g7Dqhm83WyY0+DAHpmD9j7BeykdAXWk2yvrotZMcn5bg1R6q9Sqd/xf6IV4K p22O4uAGAub9bkdvxEOyo3B8prSwevGX5fiHmMAc8ey64wfI4VkjstcaYnxzbP+vcOWR sE/BM+kJ51iKswMDqLSsVBEUxfJ3INTZTKs7hZkeLkYWsAsF4R14fTqelchUkEQBE24a MD8A== X-Gm-Message-State: AOJu0YyZHRAX+aUb2V198IKK++Gteqld8NXaxWnTqjpdCrRjIz2COCwP XO1pw4v/ulN4T4y/mgXn8LNVapRD4OMC1Q== X-Google-Smtp-Source: AGHT+IHoYzn6WU3WEl02h7AGFS46UkkaeF7/tdZLhTAKWS8rP6lbLfNioU95JNHcQz4U24VBuNGvkg== X-Received: by 2002:a05:600c:4e91:b0:40e:49af:264c with SMTP id f17-20020a05600c4e9100b0040e49af264cmr482213wmq.62.1704882080468; Wed, 10 Jan 2024 02:21:20 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:19 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 16/18] tty: serial: samsung: shrink the clock selection to 8 clocks Date: Wed, 10 Jan 2024 10:21:00 +0000 Message-ID: <20240110102102.61587-17-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022122_730942_8363CB7B X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org provides a clock selection pool of maximum 4 clocks. Update the driver to consider a pool selection of maximum 8 clocks. The final scope is to reduce the memory footprint of ``struct s3c24xx_uart_info``. Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 436739cf9225..5df2bcebf9fb 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -81,11 +81,11 @@ struct s3c24xx_uart_info { unsigned long tx_fifomask; unsigned long tx_fifoshift; unsigned long tx_fifofull; - unsigned int def_clk_sel; - unsigned long num_clks; unsigned long clksel_mask; unsigned long clksel_shift; unsigned long ucon_mask; + u8 def_clk_sel; + u8 num_clks; u8 iotype; /* uart port features */ @@ -1339,7 +1339,7 @@ static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level, #define MAX_CLK_NAME_LENGTH 15 -static inline int s3c24xx_serial_getsource(struct uart_port *port) +static inline u8 s3c24xx_serial_getsource(struct uart_port *port) { const struct s3c24xx_uart_info *info = s3c24xx_port_to_info(port); u32 ucon; @@ -1352,8 +1352,7 @@ static inline int s3c24xx_serial_getsource(struct uart_port *port) return ucon >> info->clksel_shift; } -static void s3c24xx_serial_setsource(struct uart_port *port, - unsigned int clk_sel) +static void s3c24xx_serial_setsource(struct uart_port *port, u8 clk_sel) { const struct s3c24xx_uart_info *info = s3c24xx_port_to_info(port); u32 ucon; @@ -1372,14 +1371,15 @@ static void s3c24xx_serial_setsource(struct uart_port *port, static unsigned int s3c24xx_serial_getclk(struct s3c24xx_uart_port *ourport, unsigned int req_baud, struct clk **best_clk, - unsigned int *clk_num) + u8 *clk_num) { const struct s3c24xx_uart_info *info = ourport->info; struct clk *clk; unsigned long rate; - unsigned int cnt, baud, quot, best_quot = 0; + unsigned int baud, quot, best_quot = 0; char clkname[MAX_CLK_NAME_LENGTH]; int calc_deviation, deviation = (1 << 30) - 1; + u8 cnt; for (cnt = 0; cnt < info->num_clks; cnt++) { /* Keep selected clock if provided */ @@ -1472,9 +1472,10 @@ static void s3c24xx_serial_set_termios(struct uart_port *port, struct s3c24xx_uart_port *ourport = to_ourport(port); struct clk *clk = ERR_PTR(-EINVAL); unsigned long flags; - unsigned int baud, quot, clk_sel = 0; + unsigned int baud, quot; unsigned int udivslot = 0; u32 ulcon, umcon; + u8 clk_sel = 0; /* * We don't support modem control lines. @@ -1775,10 +1776,9 @@ static int s3c24xx_serial_enable_baudclk(struct s3c24xx_uart_port *ourport) struct device *dev = ourport->port.dev; const struct s3c24xx_uart_info *info = ourport->info; char clk_name[MAX_CLK_NAME_LENGTH]; - unsigned int clk_sel; struct clk *clk; - int clk_num; int ret; + u8 clk_sel, clk_num; clk_sel = ourport->cfg->clk_sel ? : info->def_clk_sel; for (clk_num = 0; clk_num < info->num_clks; clk_num++) { @@ -2286,9 +2286,9 @@ s3c24xx_serial_get_options(struct uart_port *port, int *baud, { struct clk *clk; unsigned long rate; - unsigned int clk_sel; u32 ulcon, ucon, ubrdiv; char clk_name[MAX_CLK_NAME_LENGTH]; + u8 clk_sel; ulcon = rd_regl(port, S3C2410_ULCON); ucon = rd_regl(port, S3C2410_UCON); From patchwork Wed Jan 10 10:21:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515909 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D376DC3DA6E for ; Wed, 10 Jan 2024 10:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YS2mK90tliAfBsLPFjqVjDVDbwHzfEg1vyDM9aXqgD4=; b=sJiBAHvi1IXbwe 1RK1gdV3SIkRzRjfTABvdo/U06kg8I9xaE8q1NU8pvxfebQL43YVuID0ZLHH0xalIKBdfqq0n4Vuw k8JnHizufhc/hbE/1bUKyROUfn6qTKlJhM93/Rz7ex3pskleLfjBWn+fOMMDfElbHWapOq0yfBX27 7avZs05WpTEWwKXlqr4C5NOHblQZQmqmM3KDA+9aqpq/0mTqBfRqprutczWzv95D/eBmegJnmGDK5 MRU2ekzsiUFy7HItgePrAGE6qedQ+bqU5is5V1CXbtM0aOe7Kecl978ScQ8kgf8R2HwthI203spwT nTvtGPWBggoygHV0UDQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNVid-00B0Zh-2x; Wed, 10 Jan 2024 10:21:55 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi6-00B05p-1c for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:24 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40e4582ed74so32220005e9.1 for ; Wed, 10 Jan 2024 02:21:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882081; x=1705486881; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aIejJEXeNUqkKRlWpyybjPC4hGJCbHArkKwU6CRLU6k=; b=Less3Zz4MJ51AFfW6yEOTNpImf94k1HKt5Q3iOppV4Hf6pKFclA6Zsoj6De2LjoVS3 zoPPVVDZ/GoK/J4B4m4gJDKLEatQUNBpu/vD+61tCQwc4BwgEQwN1xq6ZdTLAdxhNn8C mdQ2prUx8azuBcHL4zdCso0RP8jDZ9LK1UEWKQMW+mTR7zMpjUr2DYmlU6xYUWFeJO54 kcS35HGpgiWEpJ2nb6SxnMg9YjTpDRWbvae9XEM6EQ0ao6oZpaiqRS68KV+fJkBfB96Q C03061UVGbMS9PPe0mjeMgnG0RRZqFbWLnlvffIMNbtjDuw/9Gi5iggP2rbdu+vT7UGl GmQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882081; x=1705486881; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aIejJEXeNUqkKRlWpyybjPC4hGJCbHArkKwU6CRLU6k=; b=VAVxTJpt40twCvYLqhk+BWMopifisKuypVITw3LePhQLnUgzSy1AHlJJdqqf9v61FU vCagxHG0WMsnGW7h3ivgDQCmEFRlb1NQNlRlYbqqTVmUsFp4pbkndhMGsdxa3FczY6zk lla3XR2LGnOLnrScO3A9pZTwDzSdvjiUJyTOOc6Oz9wlraAtEGd6IAE3zEFDzvjuRhL/ QtChKqQImtpowsRn26GWP7ccjc2W9EW1liLTdHQQ7ydlp56xOwYuPZsnqw3oQTQqKBcG sHaB1mXzlAsw+E+bOHSG4r2tzx4zbRd338ull1pSOA3W1WhAZGGaPaUmQq8Ylesq28mz isHA== X-Gm-Message-State: AOJu0YzT3bFaa5rNCHEmPLpJNsjBPqP93nvaEokdWpkPHuRb4mAcoH3n ESWTkE8cZhTTIn7KIIb7kzY234xYE7yGEg== X-Google-Smtp-Source: AGHT+IFtDvi8wjZKg9pm0ERSI9OUVSk7oMwH+ipIk06V0XhYNU2+w7zsSgC+1btLE2dAAQHJq3B/vw== X-Received: by 2002:a05:600c:1d97:b0:40e:567f:38d7 with SMTP id p23-20020a05600c1d9700b0040e567f38d7mr188898wms.225.1704882081232; Wed, 10 Jan 2024 02:21:21 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:20 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 17/18] tty: serial: samsung: shrink port feature flags to u8 Date: Wed, 10 Jan 2024 10:21:01 +0000 Message-ID: <20240110102102.61587-18-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022122_576282_00BD5D04 X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There's a single flag defined as of now. Shrink the feature flags to u8 and aim for a better memory footprint for ``struct s3c24xx_uart_info``. Signed-off-by: Tudor Ambarus --- drivers/tty/serial/samsung_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 5df2bcebf9fb..598d9fe7a492 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -90,7 +90,7 @@ struct s3c24xx_uart_info { /* uart port features */ - unsigned int has_divslot:1; + u8 has_divslot:1; }; struct s3c24xx_serial_drv_data { From patchwork Wed Jan 10 10:21:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13515911 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 021F3C3DA6E for ; Wed, 10 Jan 2024 10:22:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qfq/JlApOXRL1Ra70HtF4nmZtTnvpGot7w0tzOFwK8M=; b=S2kuyz+q3B/kZa L9pVayAU0dgBkIxCcY8LN3dTEZXwenDsMsxvSIzpzA1Hqn0ogxcEmUtDtIubKHc+PM1Eyr7fjz4Sr mzmdNRyITz+eoFYXD19Y3EmhEuhmtCP4ALvoxHZlEOYFZryrrhE2C3vLN/KxVClt2yi5mZ2DOqGto pZA2EaufdvjFzlpQX/Z4lTfc5ffsI9VtAGvjmPa96z9NB/qKE3Jcozcb2BdD4tkiBU8B6xq7kNswD Vs344Q8DSICKcXZ4s1C8ynbi+9dWT6GgkN5mVsgg/v2WaFhC7+mnmuSiGzagQKgKWHgGE318txyNh PUWGJ2JHQWzRduRdiTQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNVik-00B0g2-1T; Wed, 10 Jan 2024 10:22:02 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNVi7-00B079-1K for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 10:21:24 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40e5701cbbaso2091245e9.0 for ; Wed, 10 Jan 2024 02:21:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704882082; x=1705486882; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ummHx1igHBI+mPkPK31ezfxthw+Jgvbj/YdjUw2HyQ4=; b=vZnbUec5pSxXDHlUvN0lWgsvLbkDDsqpB5CiK0+/xpJL0386DsM/TLpZGoCn6IpowT 90ccg08fb5UAg+datFgiffJ3aaY2neaXlCyt/ISzPa9esOw1l5ziJceZQnAgP2Xx7j2Y 5jdIxLyShGbth7p08KKIeLyhG8t3kRTO6LXeXGeWeU792nZIGclQbH0gF2ZG0Dp2cpjI pPyD20ShvpxoCwTsvuq+dghCZUG6nzU2ku0zA2RWGkQTg0icnqZJ0LpNy6fsdpQbmrtj ofPrVNecExt/rVRo69SjEen+spiWKcEe2P95vBsWJBQH9IMVMEDKIDlIJzA8vqmug0Zd Ip0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704882082; x=1705486882; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ummHx1igHBI+mPkPK31ezfxthw+Jgvbj/YdjUw2HyQ4=; b=rVzY25pzw6sq8sETVcnJD4E8AB+mLd2N1QnUuTEkZl/RU43NE+noFEq4WS1ILHJuJp uJIGXnOdOcix9WYZ46NIvKVf64oP0cYyZCmO6q6C9iJ2z2wvMYcaxphL8OhHm1Tg0JtZ I6tFYEnHMrQuB/qqNym++NkzU7oLNMXUedP4yXphRUFUUOuLh1K6Zc88JBPL2APwLd2U ax09B6S1ZMJw98SfP/BymEzNDPIW9hQj5214JkrBBM4MPxC3Mv3aO4TdYjbkxZqId+MK MYwwKxtI49rT+2WClCUzjJwhPW/tj0RccUBLL/ehHodD/8/t9CkdbMXqSMaXJJjqDeoh qk5g== X-Gm-Message-State: AOJu0YxSSqS4lcEkMMZTgFXjiVt0qmsHhoYhe0YSLHYUlxEIsTXxwvMH buNn10J9PJm4rduD8MFeRJ+DaNQcCgZhWg== X-Google-Smtp-Source: AGHT+IG0xYD6noOiAF06pJmAKPKFGS5k9kf0z5T6NNAMgrhXlZB3r2GVRIKB+IrSXxoBiSdSWW9UzA== X-Received: by 2002:a7b:ce99:0:b0:40d:88b8:1bd1 with SMTP id q25-20020a7bce99000000b0040d88b81bd1mr525747wmj.185.1704882082174; Wed, 10 Jan 2024 02:21:22 -0800 (PST) Received: from ta2.c.googlers.com.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm1625302wmq.29.2024.01.10.02.21.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 02:21:21 -0800 (PST) From: Tudor Ambarus To: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus Subject: [PATCH 18/18] tty: serial: samsung: shrink memory footprint of ``struct s3c24xx_uart_info`` Date: Wed, 10 Jan 2024 10:21:02 +0000 Message-ID: <20240110102102.61587-19-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog In-Reply-To: <20240110102102.61587-1-tudor.ambarus@linaro.org> References: <20240110102102.61587-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_022123_481696_9EF90D9E X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use u32 for the members of ``struct s3c24xx_uart_info`` that are used for register interactions. The purpose of these members becomes clearer. The greater benefit of this change is that it also reduces the memory footprint of the struct, allowing 64-bit architectures to use a single cacheline for the entire struct. struct s3c24xx_uart_info { const char * name; /* 0 8 */ enum s3c24xx_port_type type; /* 8 4 */ unsigned int port_type; /* 12 4 */ unsigned int fifosize; /* 16 4 */ u32 rx_fifomask; /* 20 4 */ u32 rx_fifoshift; /* 24 4 */ u32 rx_fifofull; /* 28 4 */ u32 tx_fifomask; /* 32 4 */ u32 tx_fifoshift; /* 36 4 */ u32 tx_fifofull; /* 40 4 */ u32 clksel_mask; /* 44 4 */ u32 clksel_shift; /* 48 4 */ u32 ucon_mask; /* 52 4 */ u8 def_clk_sel; /* 56 1 */ u8 num_clks; /* 57 1 */ u8 iotype; /* 58 1 */ u8 has_divslot:1; /* 59: 0 1 */ /* size: 64, cachelines: 1, members: 17 */ /* padding: 4 */ /* bit_padding: 7 bits */ }; Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/tty/serial/samsung_tty.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 598d9fe7a492..40dceb41acb7 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -75,15 +75,15 @@ struct s3c24xx_uart_info { enum s3c24xx_port_type type; unsigned int port_type; unsigned int fifosize; - unsigned long rx_fifomask; - unsigned long rx_fifoshift; - unsigned long rx_fifofull; - unsigned long tx_fifomask; - unsigned long tx_fifoshift; - unsigned long tx_fifofull; - unsigned long clksel_mask; - unsigned long clksel_shift; - unsigned long ucon_mask; + u32 rx_fifomask; + u32 rx_fifoshift; + u32 rx_fifofull; + u32 tx_fifomask; + u32 tx_fifoshift; + u32 tx_fifofull; + u32 clksel_mask; + u32 clksel_shift; + u32 ucon_mask; u8 def_clk_sel; u8 num_clks; u8 iotype;