From patchwork Sat Jan 20 06:57:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 13524325 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49066C47258 for ; Sat, 20 Jan 2024 06:57:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BD816B007B; Sat, 20 Jan 2024 01:57:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86D226B007D; Sat, 20 Jan 2024 01:57:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75C0D6B007E; Sat, 20 Jan 2024 01:57:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 663EF6B007B for ; Sat, 20 Jan 2024 01:57:56 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 084CD1C0F0A for ; Sat, 20 Jan 2024 06:57:55 +0000 (UTC) X-FDA: 81698784552.20.ABBC45A Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf12.hostedemail.com (Postfix) with ESMTP id BA2AF40012 for ; Sat, 20 Jan 2024 06:57:52 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705733874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=EVEE3EgTe4kOOWptawfLoXU6j9AoIRMi9wHn0wKIPmk=; b=IVJGxh2abHOFZ8MapCUSvJCPhZ2mH7lWrwcyDEKquXPuA8sU2vu5XwBNT11C/Vas6WLrGQ 13llg3LzrXJ4l8BD47w8/gCn+mabtQue1CUb1nDfkw96pgGo+fY4Up4unzys/iaWtil1Z4 ItQ9pE/qjij4wujPMFvFsSqCfbRNLSw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705733874; a=rsa-sha256; cv=none; b=tQCuME9u3U3ReKbRMwBQMkOVI47S1jufkpYxb4aBUgH3X7YgPnLCSl3bp6k90mgrmnhXgB MDH74bWfFYTPgxpRNj/+tmMumOn4yhZp6UIbR0JbennXWie/9+6Bju11ICYwZGWW7rwqmN pOnoATCB5fnqKHasU4vr8qM6kxbTKxM= Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4TH6jz06rgzGpnH; Sat, 20 Jan 2024 14:57:27 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 285AA18001C; Sat, 20 Jan 2024 14:57:48 +0800 (CST) Received: from huawei.com (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 20 Jan 2024 14:57:47 +0800 From: Miaohe Lin To: , CC: , , Subject: [PATCH] mm/memory-failure: fix crash in split_huge_page_to_list from soft_offline_page Date: Sat, 20 Jan 2024 14:57:29 +0800 Message-ID: <20240120065729.3276395-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspam-User: X-Stat-Signature: xrcrp517gs3e5tf9o344orw9r76fhszi X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BA2AF40012 X-HE-Tag: 1705733872-188616 X-HE-Meta: U2FsdGVkX19JRFfb6dNJPvJAJVhvM4YubthXPywDBfftebdWPOb/vOcYfHtStUrxYAw8TEpSxO0/g/y8Vg/QDnYl13wPB1sFraCiZYqgck1AAD7UlDzCVEXWDwDMBlhMEXlel0wNU4Q5RnYHoEHfPF3WpRK4yxa12yISxW9KRD98rjQPvOJ0/z5Xw3ZTmm1PHXGdt28mTtnNASXMsICsCcg4uk/sBzzk5e7X0CaZpBz/tVi0xS8HZtNvSNG4Mmf3E18pyLIFSApcGOo7FhQnJpk+D51grIxCtIXz8LO8+InBelresXMx8AYIIv3TJgsPSjY0e8cDEEvxSIcwTfmULg8/GjHemhHlGkcph3hm3BTyYdtxgItIf9++W533eL2zF/Cjw3h2lzijzrPObfdzFb5SSMfFBnpei/zPGMJ2/15FsyzmN8IdRWPf4NZzOaRwunm1D2N4p5Ri/mBMOzdBbHpZcZR790XIv2eOdzjE+rasSwWVtmb8IkG+k6NLsRsEH2+mgWQyJQaIvbwHQM3Q7Bre1HRelW8nk997Wphwgrs/MI2MKm8W3VV891a8FXxiW3Ri7lAkPwGTuNLW/2qiEJPk5k6FGXTA1dflETMMvoi8PDAQxTA/mqRyDxK+4GLe61PFjRX/TRCySlFNdyFW6gkL45duFWdQmDSW+eNb9V82JBu2RM6cQ2vUsuk37Whh/Xna5FP+cP6fEp7ulsmtjp4NidcHZo/OrB+XyH8hdpALr2eSZFlm8Nta2k5RSWny3PhltSvcaf4+BS9KtMJDLQaryEeDNDF05SW+TQUsrA1S27D7BsspSkfL+eKLNHDWp2k1QZSupAdlJz0oIA2EOauPF7YbcM5SvwSMtlZdWpLbKQN+sA9jY955xi4LtBQGNEU9YcbnwoqAeMusblOjrPUFCfX2BD2utu9DFUpVwP9pX8cYRM2qBYQLknJrnj7AMjHvwoXSXVn2vthm3Lt KuTzlrv7 8ricKs8qIjzUtoV63m+hbKv6TtgNtkA9+N+ZOzmlZZrOhBl2L+QvkLceOxGad8Vj0r1kxD8wKB8gMFAXPRbiys8UGyjCPjQYk049rFvUa5hZFKqteI+vPk36mF+zcpFWho+YIVomKPWSHhcGyMJ8wHlpksN/WdQRTIAWeh8j+v1k8buyglnxDBSNweL2ZlFWzMKi6BLlD+1eq2K/55ThVcUojr1bmLnmf04NWa2ua5Q3OUbuqxlURILAQhw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When I did soft offline stress test, a machine was observed to crash with the following message: kernel BUG at include/linux/memcontrol.h:554! invalid opcode: 0000 [#1] PREEMPT SMP NOPTI CPU: 5 PID: 3837 Comm: hwpoison.sh Not tainted 6.7.0-next-20240112-00001-g8ecf3e7fb7c8-dirty #97 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 RIP: 0010:folio_memcg+0xaf/0xd0 Code: 10 5b 5d c3 cc cc cc cc 48 c7 c6 08 b1 f2 b2 48 89 ef e8 b4 c5 f8 ff 90 0f 0b 48 c7 c6 d0 b0 f2 b2 48 89 ef e8 a2 c5 f8 ff 90 <0f> 0b 48 c7 c6 08 b1 f2 b2 48 89 ef e8 90 c5 f8 ff 90 0f 0b 66 66 RSP: 0018:ffffb6c043657c98 EFLAGS: 00000296 RAX: 000000000000004b RBX: ffff932bc1d1e401 RCX: ffff933abfb5c908 RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff933abfb5c900 RBP: ffffea6f04019080 R08: ffffffffb3338ce8 R09: 0000000000009ffb R10: 00000000000004dd R11: ffffffffb3308d00 R12: ffffea6f04019080 R13: ffffea6f04019080 R14: 0000000000000001 R15: ffffb6c043657da0 FS: 00007f6c60f6b740(0000) GS:ffff933abfb40000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000559c3bc8b980 CR3: 0000000107f1c000 CR4: 00000000000006f0 Call Trace: ? die+0x32/0x90 ? do_trap+0xde/0x110 ? folio_memcg+0xaf/0xd0 ? do_error_trap+0x60/0x80 ? folio_memcg+0xaf/0xd0 ? exc_invalid_op+0x53/0x70 ? folio_memcg+0xaf/0xd0 ? asm_exc_invalid_op+0x1a/0x20 ? folio_memcg+0xaf/0xd0 ? folio_memcg+0xae/0xd0 split_huge_page_to_list+0x4d/0x1380 ? sysvec_apic_timer_interrupt+0xf/0x80 try_to_split_thp_page+0x3a/0xf0 soft_offline_page+0x1ea/0x8a0 soft_offline_page_store+0x52/0x90 kernfs_fop_write_iter+0x118/0x1b0 vfs_write+0x30b/0x430 ksys_write+0x5e/0xe0 do_syscall_64+0xb0/0x1b0 entry_SYSCALL_64_after_hwframe+0x6d/0x75 RIP: 0033:0x7f6c60d14697 Code: 10 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 RSP: 002b:00007ffe9b72b8d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 000000000000000c RCX: 00007f6c60d14697 RDX: 000000000000000c RSI: 0000559c3bc8b980 RDI: 0000000000000001 RBP: 0000559c3bc8b980 R08: 00007f6c60dd1460 R09: 000000007fffffff R10: 0000000000000000 R11: 0000000000000246 R12: 000000000000000c R13: 00007f6c60e1a780 R14: 00007f6c60e16600 R15: 00007f6c60e15a00 The problem is that page->mapping is overloaded with slab->slab_list or slabs fields now, so slab pages could be taken as non-LRU movable pages if field slabs contains PAGE_MAPPING_MOVABLE or slab_list->prev is set to LIST_POISON2. These slab pages will be treated as thp later leading to crash in split_huge_page_to_list(). Signed-off-by: Miaohe Lin Fixes: 130d4df57390 ("mm/sl[au]b: rearrange struct slab fields to allow larger rcu_head") --- mm/memory-failure.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 636280d04008..20058f7ac3e9 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1377,8 +1377,13 @@ void ClearPageHWPoisonTakenOff(struct page *page) */ static inline bool HWPoisonHandlable(struct page *page, unsigned long flags) { - /* Soft offline could migrate non-LRU movable pages */ - if ((flags & MF_SOFT_OFFLINE) && __PageMovable(page)) + /* + * Soft offline could migrate non-LRU movable pages. + * Note that page->mapping is overloaded with slab->slab_list or slabs + * fields which might make slab pages appear like non-LRU movable pages. + * So __PageMovable() has to be done after PageSlab() is checked. + */ + if ((flags & MF_SOFT_OFFLINE) && !PageSlab(page) && __PageMovable(page)) return true; return PageLRU(page) || is_free_buddy_page(page);