From patchwork Tue Jan 23 03:46:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13526808 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59C85C47258 for ; Tue, 23 Jan 2024 03:47:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC04E6B0087; Mon, 22 Jan 2024 22:47:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D70656B008A; Mon, 22 Jan 2024 22:47:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEA4D6B008C; Mon, 22 Jan 2024 22:47:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A72AB6B0087 for ; Mon, 22 Jan 2024 22:47:12 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 81B661C11EC for ; Tue, 23 Jan 2024 03:47:12 +0000 (UTC) X-FDA: 81709190304.27.83FA6C0 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf12.hostedemail.com (Postfix) with ESMTP id 7FA5340003 for ; Tue, 23 Jan 2024 03:47:10 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=R8JVod3l; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=IBydtwlk; dmarc=pass (policy=none) header.from=sent.com; spf=pass (imf12.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705981630; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mC6ae0v7zXTnCM6lhVafmauC3M7j0hzzYKYZ+UScLOA=; b=NWaJuFvZx3qW108cuuPsVYgsDTFCOU7m8BnlS5XU17cnC90vtaA6Xgz1bEe6jDiRdzktUh t2buiL4DDIf2Q/IiU6O9OLCnH934seIRpjlwvE7sbJlJEE5dR6hMcD6dgIpAzQvHF+ets7 AceCFiTJALQ+iTnDB5q+JL7+/RN00MY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=R8JVod3l; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=IBydtwlk; dmarc=pass (policy=none) header.from=sent.com; spf=pass (imf12.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705981630; a=rsa-sha256; cv=none; b=WGXeLNvpotgBtMaDhxIG6Kc5qsnu/53W0176njGkPr65e8UXDKxH5eruOeg5iYQXPIAFoT nf+uqqYUeIyHmoU+XMjEYm0Ad03SO9Tw7ZCxnonkaRCFhDBAZ26/gPO59GjYsVqVzQJLVM kEBYduXHS9GZMgDRjf2rABJ9wdcjwgI= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 39D365C0051; Mon, 22 Jan 2024 22:47:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 22 Jan 2024 22:47:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1705981628; x=1706068028; bh=mC6ae0v7zXTnCM6lhVafmauC3M7j0hzzYKY Z+UScLOA=; b=R8JVod3laPmb7g1HLtsYlFfqWul2+VE2dg3TQlgwT3R5cPWzbis EcZkF+hmp86rGEd6ibctWpwxhzerM8OsVEvs8/Yr7HA2RWvxe5b/xrq9zwUNS1v0 M+3wVSTD3eNLrED3w2G/ZM11O/jyeLhf4wpxkT2sj/0sAvg6aV5v/xfC9d/a/GIb ZhvssWRXPSwph6Pa+atCSApUSwUwXuDD3A3AHJoU47PAenkdkURR0GUOL3lP1ESt KiaVNtVpqEn6hTgDmbV5hR4iRI+EK0UblW3Wmha4wPSd2tFEoITwM1H/4dSAzz03 zrv6xTwoQ5uE1MVN4SEtipS+r/RHpdCMb+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1705981628; x=1706068028; bh=mC6ae0v7zXTnCM6lhVafmauC3M7j0hzzYKY Z+UScLOA=; b=IBydtwlk9+lvDYtAAJ8KD4EgF1URCX6jmKxJV6kJUZZylFudmUa t1e68onsyFym0E8LQt6q7fsJmxputLlJh3XVYp+jur7Rgu5X9nJ1Aah2n11OySOn sTM/yRuXWY8cxihEUQ/3YKiKxkPIQW34g0OPQfdl5WANkeINHBkhstCX3BhkVqiP QadejVULEhjzkZefAcGBCUkuXc7eR3JG1RPFORj3VMvhseq0fKGrlnRh2KbpH5EG 513h2uRqcBY6KSIuB3oT5mlYXULKr0YMFmL1HLV4St0SVYsPnbkQsJ+vVGEziMlu LXUi1kNb69FU+PBU8baYumXkx+AaZd1gq/Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdekjedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Jan 2024 22:47:07 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v2 1/3] mm/compaction: enable compacting >0 order folios. Date: Mon, 22 Jan 2024 22:46:33 -0500 Message-ID: <20240123034636.1095672-2-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240123034636.1095672-1-zi.yan@sent.com> References: <20240123034636.1095672-1-zi.yan@sent.com> Reply-To: Zi Yan MIME-Version: 1.0 X-Rspamd-Queue-Id: 7FA5340003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: w7gj6pca5wcj58xg36g6neaqzutj4kfg X-HE-Tag: 1705981630-342632 X-HE-Meta: U2FsdGVkX190MZVtLOCUNjInK3k6WWPY28ga2yWV5KT8fLP7U7mk6te3NwQ2AIGCrAM8Z5faC00gYzCVcdQQWbr1CuzlIr5OTn0oibYWYyDFbkXs50mB5wjW1fJfH2exWsjz5S7XW4d7sURLUQqwRVoiLHrjp7x48gLHu65W4gA4HBhi04Ofk4g/+l+AS/pnQhpUMu2HCQwKE7FsEcCM2k9rZaehMTwuG7/gu97PBrtrSmP4Zv00IBn5vit7FUc3nVtYhHezZVh5+qU9XvOSpN4tJt8YtA67zIhTKF8UeZiQ+yhcinCYgOgd2Bo+34LSSePzBXg5BiZej3fqhC137u9uQrG6zbg3+mlROFeF1C4kxJELu+YXv6xiG/fpN1xiu8e1+i+cUAJEMY0Dk/PmAkXEujdjHtDz4WyCRMmsYLPwcYaRXMzXoNAyAAPupGEQexEGrYadPtrDpLFra/esoozB1egyBgcCqOHDMgL+zS4I6lxlpodQr8+Wqs2EQsAUBgYn3AimXVUYhqT+tSrD0DmU2HF3jYaURV3E74j/lS2dGW42YLLCv5xSkgjWEBFJykKRkT0Oid+JXXQZhOaybI4mUi1N01e6X5Uu52ND9DJrBj1rbW9cyRlBOso0hIMTJJriU+DRtlgqZdPhUse/rqOYdnbAxoUH8jc0Bp+yklixHTChIb18RQFfO8zhM8Ow4jiswINoj44URXOruFWDmrTIIbRJgI+Y42Mz4TkcPCQO7nduWiINAIS7MvVJnfYar7TBzHL4qsFB/fPl7h5lfdPOGyB2Hyuc4vY5D5gKRIc0Wym57d2Nvf26TqWNnkkAA1NH+wtAF9IgWcA8lVkzea+ZxFB8KoV9ll50u4i/LjuKe8NcKYvxU7szOCFOT4qGa+r/ZbLlpBw0jpaPK5kcSVA5N2p+x/nrBIXi4UFfaVpghGf83GDWxcx1bqzkHz4ZA99q9Ajxq8g4l+dMSGJ tdU8t652 MYYP4eTELd3CH7PbuRkfLXodOHaals40+mnPdVD3m7kw/PLD1jGgDq6aiIpJwkFl0H44/vFNjOygh8oeFNGcH8PVEijlULGRGHf9X9znN6604N+cnpGlNIe0GwR1YAvQzlf+06PwQmKdg7T1mLz3cYIZuchndC3ckjIgXroOm+Zifi3u7R4k31ebFZXce8pTdoJOMlHA/dQNoVbJnkC7LBm3hYUFm+h4yCZodYTSYz9A2jWQAQbuHvysR3iqSwg66hYXgxj75wvFMtHQj5BPDUP4Uq5e5pltqZiJXuvRQnd5xsTei0Wmuz3fjhifCOeig5AiKD8+ZXcYug0IP8vLejsRAmeXbcP6INlAjbRNJPNp4IBbDQEHCL+NTUr4wcKqiLlkXODhpA/1eJo/TwGn6XmlH59N5iAPnKzORd2+H7dmXHhIjwfM5ZfzWCZKhSYg/SMPclazxIsqOtnwbFPpfS3BakLt+4YfBszyuxghhAj2U5bMIU+Wkb3PR/GEC0ZgdhRWFIfN4nY13xsqZ1EvNfe9aIEVH6TQ50pTH+ITWIj+YSwk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zi Yan migrate_pages() supports >0 order folio migration and during compaction, even if compaction_alloc() cannot provide >0 order free pages, migrate_pages() can split the source page and try to migrate the base pages from the split. It can be a baseline and start point for adding support for compacting >0 order folios. Suggested-by: Huang Ying Signed-off-by: Zi Yan Reviewed-by: Baolin Wang --- mm/compaction.c | 43 +++++++++++++++++++++++++++++++++++-------- 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 27ada42924d5..61389540e1f1 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -816,6 +816,21 @@ static bool too_many_isolated(struct compact_control *cc) return too_many; } +/* + * 1. if the page order is larger than or equal to target_order (i.e., + * cc->order and when it is not -1 for global compaction), skip it since + * target_order already indicates no free page with larger than target_order + * exists and later migrating it will most likely fail; + * + * 2. compacting > pageblock_order pages does not improve memory fragmentation, + * skip them; + */ +static bool skip_isolation_on_order(int order, int target_order) +{ + return (target_order != -1 && order >= target_order) || + order >= pageblock_order; +} + /** * isolate_migratepages_block() - isolate all migrate-able pages within * a single pageblock @@ -1009,7 +1024,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, /* * Regardless of being on LRU, compound pages such as THP and * hugetlbfs are not to be compacted unless we are attempting - * an allocation much larger than the huge page size (eg CMA). + * an allocation larger than the compound page size. * We can potentially save a lot of iterations if we skip them * at once. The check is racy, but we can consider only valid * values and the only danger is skipping too much. @@ -1017,11 +1032,18 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, if (PageCompound(page) && !cc->alloc_contig) { const unsigned int order = compound_order(page); - if (likely(order <= MAX_PAGE_ORDER)) { - low_pfn += (1UL << order) - 1; - nr_scanned += (1UL << order) - 1; + /* + * Skip based on page order and compaction target order + * and skip hugetlbfs pages. + */ + if (skip_isolation_on_order(order, cc->order) || + PageHuge(page)) { + if (order <= MAX_PAGE_ORDER) { + low_pfn += (1UL << order) - 1; + nr_scanned += (1UL << order) - 1; + } + goto isolate_fail; } - goto isolate_fail; } /* @@ -1146,10 +1168,11 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, } /* - * folio become large since the non-locked check, - * and it's on LRU. + * Check LRU folio order under the lock */ - if (unlikely(folio_test_large(folio) && !cc->alloc_contig)) { + if (unlikely(skip_isolation_on_order(folio_order(folio), + cc->order) && + !cc->alloc_contig)) { low_pfn += folio_nr_pages(folio) - 1; nr_scanned += folio_nr_pages(folio) - 1; folio_set_lru(folio); @@ -1767,6 +1790,10 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) struct compact_control *cc = (struct compact_control *)data; struct folio *dst; + /* this makes migrate_pages() split the source page and retry */ + if (folio_test_large(src) > 0) + return NULL; + if (list_empty(&cc->freepages)) { isolate_freepages(cc); From patchwork Tue Jan 23 03:46:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13526809 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E80EC47DDF for ; Tue, 23 Jan 2024 03:47:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4BEC6B0092; Mon, 22 Jan 2024 22:47:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EECC6B0096; Mon, 22 Jan 2024 22:47:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CA8C6B0092; Mon, 22 Jan 2024 22:47:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 68BDD6B008A for ; Mon, 22 Jan 2024 22:47:13 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 399F21C12BD for ; Tue, 23 Jan 2024 03:47:13 +0000 (UTC) X-FDA: 81709190346.29.DB92927 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf05.hostedemail.com (Postfix) with ESMTP id 337E610001F for ; Tue, 23 Jan 2024 03:47:10 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=TGPjcuaB; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=tqVvXjVA; spf=pass (imf05.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705981630; a=rsa-sha256; cv=none; b=gzlw1sBquMcXL8Yn77At4X0PHwANMzweNx5u2KJbF4c+0Os4dSs9lxCSJdYSRVUzr44eTm 1XnE9G4w8ZhSPN6EAft1YLHEDdP+WlZqLHnN8KMxSXrvx7/d9ot6wuhejYCNlteKhyReyw pqCb6DKlVjTyvAEFbn0oudjaqT9rjUI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=TGPjcuaB; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=tqVvXjVA; spf=pass (imf05.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705981630; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OGWh8nwjD+/F70nRvDY2KROL0h10J6GLLU2GjbyVFgk=; b=Semqcp3y85rWPKBhPz0rrywZaqhKxQ0Aqx1Sqi0dsBjqHwpB+oRaoaduMEwPk40h8sEJ9+ AI/XqmUJZuo/a5euZ5cC6UjbLHTqpviZ17htklGy0p3nXcONlggM9g7kVTCpTW7v8nIISN ejpf6UPXFFFAHv7dUbslXkkDd3U8zbM= Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 940C55C0330; Mon, 22 Jan 2024 22:47:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 22 Jan 2024 22:47:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1705981629; x=1706068029; bh=OGWh8nwjD+/F70nRvDY2KROL0h10J6GLLU2 GjbyVFgk=; b=TGPjcuaByLyZV1Rdhrq/FKYymI5xvg9LZGK/2tn2BbtF7NofOLA ixPOWHNiSULzRbh5ytOTGxCQqMqYZy+oJjmMfUlH6t4UwhxJ8Drhtx+Av0tmz+pv 0YOwL9pSXtgkBZpqGX65exujNB+tyOYY7QyXPvopEPNbBCF7omPF/hu6p5ewahmv tdJkl1c/RjOztczeoywOxv0BJgZeKCfzm8/S7wOAodpTfNJAd6xzPHqQgG4vcDDl 9kAk0FNhx6Z33gYsI20JBF68okJAnKCsDndtlqT1khjqCcAlMnrCI5ZSetMP5I8i C04PoKW6qj1AdlyDZN2qiAKe2Rv7YINE1tw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1705981629; x=1706068029; bh=OGWh8nwjD+/F70nRvDY2KROL0h10J6GLLU2 GjbyVFgk=; b=tqVvXjVAhViwWsuQ0tXVg3IvxjqMdLLDDo5Oxbel+wxtcu7m7Tw 71MNXYVST7GLueUgO5y8nYsOv5AdILI7aNevErF9mp5D/arDq7PwON567x10SuKp a2Z7zMiQJQ6Xl5hoS0b94lZCwVVJN7etujpA0qgvmWxmN9UpofxfR7j+ZQduik4G EzcK++YZXFgp5xuHnyOPXhyjw++gDJ0Lfk4G99+cjeIyRlLEA7wcmLrwFGb83T0k 5GaaJGBYAuKxv6eUuODMymZauhCfHQY3PjBSNEpXeL1wfnNuc9FCo5/REAefzSR3 jTTo1Ir3ifb8VRN4Tt3dRGgK3RotXqq+7Qg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdekjedgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Jan 2024 22:47:08 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v2 2/3] mm/compaction: add support for >0 order folio memory compaction. Date: Mon, 22 Jan 2024 22:46:34 -0500 Message-ID: <20240123034636.1095672-3-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240123034636.1095672-1-zi.yan@sent.com> References: <20240123034636.1095672-1-zi.yan@sent.com> Reply-To: Zi Yan MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 337E610001F X-Stat-Signature: ssya1t64ttmoxwz9thcg7yf9j7sn3i1i X-Rspam-User: X-HE-Tag: 1705981630-26888 X-HE-Meta: U2FsdGVkX1+JwffDFag0/eZUzimVJyiWllKAplTgmRl7xAdp2LzRFGzJB2R2zIbDNDSq4pubTn4JGtTvnXY/ZL0Mt/LvryZdx76qoL4xXJnTed/8oMLD9XhkhjnU2oGyT11UpWBLNAHuybSiWqD6aBJKQ9nhcVDT/t6Z+RfTmP0+PC9LtdNiCPQo7OgkWqnOSeetmGNgMA31BRvAPPtvC45y6nVLWH98xKnTDwyGFQZSaiRsL5xgnYCl3xXxOOAsC41leYtKYSyostTYyhMRT1kFh1iPCmp0sCLS+bpdCpZf9L/ELEEIdHZC/MLo+gKd7pW06t2GZ83xjR7ggbMiI0+GA6AjjHKEK1qEPGWvpYH3iTS0aRsu6epfAy1+Hb1gFWjN9AJXX6FIhc50EYjiysnX6d9CVFzPQEgjq42YKO3zRNe0DdFHQCtFVrf+GU2luq1zcZHDIQLZm12ChtU2zPIQ96xZqYQDkAtevjCCmjusQHCjV//YpFAyOJLTsyw75dJbiJt7yUZPRwVR9QjTYHSlNLx83Thmo+9upju875NasBB3r85yWk4ueXQ5EPGCFcuue1sGeBDLrFvI3jK/htd0xQulapmc49bqqxGP25BRwbuO3zIZLBfEuyGWSUASeikUYdsHbD3dAGPiUrcIu339v85a1j7DtMz+7F9lcAkcTrk37FJFBQLqIqi+BsQ7nSylouSOb5r6S9N2pRWrYhqbS6taX9LbM6BhSQnPOLacTyHJaDwgnWv68/7dTcohA5POKe3tXKHhaND9yxOF1iS/z1bcASOwqoykC0bRNyrvh+vRhHrKeDS8i6UpyC248YG1q7Vd9c/hW4aUxS02cHvlm5nl1BJnmYSyE0JUtxm5UYbSp/Y1yL1K8jY8lcZeoH7KAaW5yQI4Nl6sx8V+Kpthhm9+t65EMvEhz/ob1OE2CZN5/OTHhEHWw2Jk1Q/cdDvzzsQ/4O9KB6xtyts uvIavumr PuAsVJcE9X2zBjQnz/z+EeulgEl09PjVL41krXzwW6WYSbHrLsCiFXa+CRx74CFSy0e36QewdLefKPBMIiFr5+8KyMEGARCOWh9ik3lKl/oFU6yQCsXqJdQJYEBHDBwnwjubLbkAO8RNT6cUNfcooEHHzEEwJFjOr0lW6kSo8tV+ycZN66otN2sGvt1RR7NADf7yUT+PTYbUbi9FaAr0P1qL7xj8JIhE/69/TYcA9ge2vbDqMoXWnLxMmuJK5HZANWQA+oSzsVENQQeY06J2vnZ2YMQ5y95ovfzTmV3ONdiMZ32nvL+4OmS4SpME47oIFfLJuTmJIbIW5RPBW+Cpgv2tb+8Bok5j94WeFj2CxUSg15P+KF1pouPfS4zH6XhAcd8SYOdhfF7l92ucsthony2gyGZeAvCen9L1P6S70FvvpzElOrMWQ3aUEntt+XKJEyOS2JsU1kkiIWKucQ6vQ1MHsZEDovmrvMjNLQvkOyShUwfALYJDYaGB3/UD7aSFQwn3btxrDT+3gjrU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zi Yan Before last commit, memory compaction only migrates order-0 folios and skips >0 order folios. Last commit splits all >0 order folios during compaction. This commit migrates >0 order folios during compaction by keeping isolated free pages at their original size without splitting them into order-0 pages and using them directly during migration process. What is different from the prior implementation: 1. All isolated free pages are kept in a NR_PAGE_ORDERS array of page lists, where each page list stores free pages in the same order. 2. All free pages are not post_alloc_hook() processed nor buddy pages, although their orders are stored in first page's private like buddy pages. 3. During migration, in new page allocation time (i.e., in compaction_alloc()), free pages are then processed by post_alloc_hook(). When migration fails and a new page is returned (i.e., in compaction_free()), free pages are restored by reversing the post_alloc_hook() operations using newly added free_pages_prepare_fpi_none(). Step 3 is done for a latter optimization that splitting and/or merging free pages during compaction becomes easier. Note: without splitting free pages, compaction can end prematurely due to migration will return -ENOMEM even if there is free pages. This happens when no order-0 free page exist and compaction_alloc() return NULL. Signed-off-by: Zi Yan --- mm/compaction.c | 148 +++++++++++++++++++++++++++++------------------- mm/internal.h | 9 ++- mm/page_alloc.c | 6 ++ 3 files changed, 103 insertions(+), 60 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 61389540e1f1..11f9898e39da 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -66,45 +66,67 @@ static inline void count_compact_events(enum vm_event_item item, long delta) #define COMPACTION_HPAGE_ORDER (PMD_SHIFT - PAGE_SHIFT) #endif -static unsigned long release_freepages(struct list_head *freelist) +static void init_page_list(struct page_list *p) { - struct page *page, *next; - unsigned long high_pfn = 0; - - list_for_each_entry_safe(page, next, freelist, lru) { - unsigned long pfn = page_to_pfn(page); - list_del(&page->lru); - __free_page(page); - if (pfn > high_pfn) - high_pfn = pfn; - } - - return high_pfn; + INIT_LIST_HEAD(&p->pages); + p->nr_pages = 0; } -static void split_map_pages(struct list_head *list) +static void split_map_pages(struct page_list *freepages) { - unsigned int i, order, nr_pages; + unsigned int i, order, total_nr_pages; struct page *page, *next; LIST_HEAD(tmp_list); - list_for_each_entry_safe(page, next, list, lru) { - list_del(&page->lru); + for (order = 0; order < NR_PAGE_ORDERS; order++) { + total_nr_pages = freepages[order].nr_pages * (1 << order); + freepages[order].nr_pages = 0; + + list_for_each_entry_safe(page, next, &freepages[order].pages, lru) { + unsigned int nr_pages; + + list_del(&page->lru); - order = page_private(page); - nr_pages = 1 << order; + nr_pages = 1 << order; - post_alloc_hook(page, order, __GFP_MOVABLE); - if (order) - split_page(page, order); + post_alloc_hook(page, order, __GFP_MOVABLE); + if (order) + split_page(page, order); - for (i = 0; i < nr_pages; i++) { - list_add(&page->lru, &tmp_list); - page++; + for (i = 0; i < nr_pages; i++) { + list_add(&page->lru, &tmp_list); + page++; + } } + freepages[0].nr_pages += total_nr_pages; + list_splice_init(&tmp_list, &freepages[0].pages); } +} - list_splice(&tmp_list, list); +static unsigned long release_free_list(struct page_list *freepages) +{ + int order; + unsigned long high_pfn = 0; + + for (order = 0; order < NR_PAGE_ORDERS; order++) { + struct page *page, *next; + + list_for_each_entry_safe(page, next, &freepages[order].pages, lru) { + unsigned long pfn = page_to_pfn(page); + + list_del(&page->lru); + /* + * Convert free pages into post allocation pages, so + * that we can free them via __free_page. + */ + post_alloc_hook(page, order, __GFP_MOVABLE); + __free_pages(page, order); + if (pfn > high_pfn) + high_pfn = pfn; + } + freepages[order].nr_pages = 0; + } + return high_pfn; } #ifdef CONFIG_COMPACTION @@ -583,7 +605,7 @@ static bool compact_unlock_should_abort(spinlock_t *lock, static unsigned long isolate_freepages_block(struct compact_control *cc, unsigned long *start_pfn, unsigned long end_pfn, - struct list_head *freelist, + struct page_list *freelist, unsigned int stride, bool strict) { @@ -657,7 +679,8 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, nr_scanned += isolated - 1; total_isolated += isolated; cc->nr_freepages += isolated; - list_add_tail(&page->lru, freelist); + list_add_tail(&page->lru, &freelist[order].pages); + freelist[order].nr_pages++; if (!strict && cc->nr_migratepages <= cc->nr_freepages) { blockpfn += isolated; @@ -722,7 +745,11 @@ isolate_freepages_range(struct compact_control *cc, unsigned long start_pfn, unsigned long end_pfn) { unsigned long isolated, pfn, block_start_pfn, block_end_pfn; - LIST_HEAD(freelist); + int order; + struct page_list tmp_freepages[NR_PAGE_ORDERS]; + + for (order = 0; order < NR_PAGE_ORDERS; order++) + init_page_list(&tmp_freepages[order]); pfn = start_pfn; block_start_pfn = pageblock_start_pfn(pfn); @@ -753,7 +780,7 @@ isolate_freepages_range(struct compact_control *cc, break; isolated = isolate_freepages_block(cc, &isolate_start_pfn, - block_end_pfn, &freelist, 0, true); + block_end_pfn, tmp_freepages, 0, true); /* * In strict mode, isolate_freepages_block() returns 0 if @@ -770,15 +797,15 @@ isolate_freepages_range(struct compact_control *cc, */ } - /* __isolate_free_page() does not map the pages */ - split_map_pages(&freelist); - if (pfn < end_pfn) { /* Loop terminated early, cleanup. */ - release_freepages(&freelist); + release_free_list(tmp_freepages); return 0; } + /* __isolate_free_page() does not map the pages */ + split_map_pages(tmp_freepages); + /* We don't use freelists for anything. */ return pfn; } @@ -1462,7 +1489,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) if (!page) return; - isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); + isolate_freepages_block(cc, &start_pfn, end_pfn, cc->freepages, 1, false); /* Skip this pageblock in the future as it's full or nearly full */ if (start_pfn == end_pfn && !cc->no_set_skip_hint) @@ -1591,7 +1618,7 @@ static void fast_isolate_freepages(struct compact_control *cc) nr_scanned += nr_isolated - 1; total_isolated += nr_isolated; cc->nr_freepages += nr_isolated; - list_add_tail(&page->lru, &cc->freepages); + list_add_tail(&page->lru, &cc->freepages[order].pages); count_compact_events(COMPACTISOLATED, nr_isolated); } else { /* If isolation fails, abort the search */ @@ -1668,13 +1695,12 @@ static void isolate_freepages(struct compact_control *cc) unsigned long isolate_start_pfn; /* exact pfn we start at */ unsigned long block_end_pfn; /* end of current pageblock */ unsigned long low_pfn; /* lowest pfn scanner is able to scan */ - struct list_head *freelist = &cc->freepages; unsigned int stride; /* Try a small search of the free lists for a candidate */ fast_isolate_freepages(cc); if (cc->nr_freepages) - goto splitmap; + return; /* * Initialise the free scanner. The starting point is where we last @@ -1734,7 +1760,7 @@ static void isolate_freepages(struct compact_control *cc) /* Found a block suitable for isolating free pages from. */ nr_isolated = isolate_freepages_block(cc, &isolate_start_pfn, - block_end_pfn, freelist, stride, false); + block_end_pfn, cc->freepages, stride, false); /* Update the skip hint if the full pageblock was scanned */ if (isolate_start_pfn == block_end_pfn) @@ -1775,10 +1801,6 @@ static void isolate_freepages(struct compact_control *cc) * and the loop terminated due to isolate_start_pfn < low_pfn */ cc->free_pfn = isolate_start_pfn; - -splitmap: - /* __isolate_free_page() does not map the pages */ - split_map_pages(freelist); } /* @@ -1789,23 +1811,22 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) { struct compact_control *cc = (struct compact_control *)data; struct folio *dst; + int order = folio_order(src); - /* this makes migrate_pages() split the source page and retry */ - if (folio_test_large(src) > 0) - return NULL; - - if (list_empty(&cc->freepages)) { + if (!cc->freepages[order].nr_pages) { isolate_freepages(cc); - - if (list_empty(&cc->freepages)) + if (!cc->freepages[order].nr_pages) return NULL; } - dst = list_entry(cc->freepages.next, struct folio, lru); + dst = list_first_entry(&cc->freepages[order].pages, struct folio, lru); + cc->freepages[order].nr_pages--; list_del(&dst->lru); - cc->nr_freepages--; - - return dst; + post_alloc_hook(&dst->page, order, __GFP_MOVABLE); + if (order) + prep_compound_page(&dst->page, order); + cc->nr_freepages -= 1 << order; + return page_rmappable_folio(&dst->page); } /* @@ -1816,9 +1837,17 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) static void compaction_free(struct folio *dst, unsigned long data) { struct compact_control *cc = (struct compact_control *)data; + int order = folio_order(dst); + struct page *page = &dst->page; + + folio_set_count(dst, 0); + free_pages_prepare_fpi_none(page, order); - list_add(&dst->lru, &cc->freepages); - cc->nr_freepages++; + INIT_LIST_HEAD(&dst->lru); + + list_add(&dst->lru, &cc->freepages[order].pages); + cc->freepages[order].nr_pages++; + cc->nr_freepages += 1 << order; } /* possible outcome of isolate_migratepages */ @@ -2442,6 +2471,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) const bool sync = cc->mode != MIGRATE_ASYNC; bool update_cached; unsigned int nr_succeeded = 0; + int order; /* * These counters track activities during zone compaction. Initialize @@ -2451,7 +2481,8 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) cc->total_free_scanned = 0; cc->nr_migratepages = 0; cc->nr_freepages = 0; - INIT_LIST_HEAD(&cc->freepages); + for (order = 0; order < NR_PAGE_ORDERS; order++) + init_page_list(&cc->freepages[order]); INIT_LIST_HEAD(&cc->migratepages); cc->migratetype = gfp_migratetype(cc->gfp_mask); @@ -2637,7 +2668,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) * so we don't leave any returned pages behind in the next attempt. */ if (cc->nr_freepages > 0) { - unsigned long free_pfn = release_freepages(&cc->freepages); + unsigned long free_pfn = release_free_list(cc->freepages); cc->nr_freepages = 0; VM_BUG_ON(free_pfn == 0); @@ -2656,7 +2687,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) trace_mm_compaction_end(cc, start_pfn, end_pfn, sync, ret); - VM_BUG_ON(!list_empty(&cc->freepages)); VM_BUG_ON(!list_empty(&cc->migratepages)); return ret; diff --git a/mm/internal.h b/mm/internal.h index f309a010d50f..886040a907d3 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -447,6 +447,8 @@ extern void prep_compound_page(struct page *page, unsigned int order); extern void post_alloc_hook(struct page *page, unsigned int order, gfp_t gfp_flags); +extern bool free_pages_prepare_fpi_none(struct page *page, unsigned int order); + extern int user_min_free_kbytes; extern void free_unref_page(struct page *page, unsigned int order); @@ -473,6 +475,11 @@ int split_free_page(struct page *free_page, /* * in mm/compaction.c */ + +struct page_list { + struct list_head pages; + unsigned long nr_pages; +}; /* * compact_control is used to track pages being migrated and the free pages * they are being migrated to during memory compaction. The free_pfn starts @@ -481,7 +488,7 @@ int split_free_page(struct page *free_page, * completes when free_pfn <= migrate_pfn */ struct compact_control { - struct list_head freepages; /* List of free pages to migrate to */ + struct page_list freepages[NR_PAGE_ORDERS]; /* List of free pages to migrate to */ struct list_head migratepages; /* List of pages being migrated */ unsigned int nr_freepages; /* Number of isolated free pages */ unsigned int nr_migratepages; /* Number of pages to migrate */ diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5be4cd8f6b5a..c7c135e6d5ee 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1179,6 +1179,12 @@ static __always_inline bool free_pages_prepare(struct page *page, return true; } +__always_inline bool free_pages_prepare_fpi_none(struct page *page, + unsigned int order) +{ + return free_pages_prepare(page, order, FPI_NONE); +} + /* * Frees a number of pages from the PCP lists * Assumes all pages on list are in same zone. From patchwork Tue Jan 23 03:46:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13526810 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A549C47258 for ; Tue, 23 Jan 2024 03:47:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EABAC6B008A; Mon, 22 Jan 2024 22:47:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E5AF76B0095; Mon, 22 Jan 2024 22:47:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3D876B008A; Mon, 22 Jan 2024 22:47:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 84D056B008A for ; Mon, 22 Jan 2024 22:47:13 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 35765A1986 for ; Tue, 23 Jan 2024 03:47:13 +0000 (UTC) X-FDA: 81709190346.24.1240FEE Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf23.hostedemail.com (Postfix) with ESMTP id 333B014000B for ; Tue, 23 Jan 2024 03:47:11 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=Qb1tyZd8; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=y6CtXNfh; spf=pass (imf23.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705981631; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nFXKGo9rKF119RBUFLJm4CCIEN+EywVvwTP6Mlui2MY=; b=YzWtSxM2ITmeJmbFpsPzrJyMECDta8HleCBhO05OBxRqwlLnIAIrqxJzvHN0GQ0D9Cim3a VZvnEw4zEJhniGgMTTRNiasEiu5jljjAHysSrp11ktKQpACa8RqQrJAzv90vxeBxNUywWF IT1kaZfh3osi8uUX8s6zcuJOCFwybGI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=sent.com header.s=fm3 header.b=Qb1tyZd8; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=y6CtXNfh; spf=pass (imf23.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705981631; a=rsa-sha256; cv=none; b=HC1gwkFI0Nvsg/BSUAolLTJoHb4Q+rlQk6aylhSCnJw9cltIBPA4hzmVkxulmpgDqY03Sp p4OVM8Y3LGiGvXK1XiDPEL3M37sUPvC4Vhc/ngYScN/6oQLhH3BQYRzz+NCPKej+uJrZ6z UzS/RyK8StXvsH0rWzfEjleGYNQQXcg= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6F0165C0335; Mon, 22 Jan 2024 22:47:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 22 Jan 2024 22:47:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1705981630; x=1706068030; bh=nFXKGo9rKF119RBUFLJm4CCIEN+EywVvwTP 6Mlui2MY=; b=Qb1tyZd8hBxmQdzvOqm/NUrXgHvdk6O59nKJ/UAjsWmR+NJt8o0 sQMQ3BHdYvYBMUEaTgEVGQ1Yg0p04a5toQcQHryZNBnFE/N5HHcXAjP1RpfJGbBg zPxkJCCea7vc0sx3iBeqQy2Kxpj5MYwfVZHYJh8Yqrw/4c2PUnINhNsXKCl+3Wwn Z78At21kPb3Rb1YBAt0Fjjn0QCaYhlfnl/tbX02RhfSUi3eBNufKh+/pEgpOOvE7 DQW1765+/v+nbu7Tf8agm8NoaVUoa4ohTLXtbJk7cY2KtIYz35JKRDhqDy5SnuqG 5/D/WpH1IkLPUgbJm1HcW4IcFI0J+VhgOxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1705981630; x=1706068030; bh=nFXKGo9rKF119RBUFLJm4CCIEN+EywVvwTP 6Mlui2MY=; b=y6CtXNfhQE6UEMdpchPy2BMY5+J1ZsljEUixwVzuhCDkmIckFIu MXK96g2nWTilV5FRWN9CrDxiyGd9DbYosxAXS9pSZYbZqN17/nULWf+mylk3uEm8 CCC6nENgxubwk4/OmfXmDfGlB2tHQI5SQV8A4vVyHUsqRKvAvRr6s03hxvmCeViT jJerNmHRpIN0E0Fo0RChyTjp5BNs4uZjvZk4SnQFETm0b+iJL0bK5GBtbM5PFhzq z574F6aBUj9JBJjAZdDvWvX+Jpk47SjgmRkm6lTvWSFKzUeYVen1otfGPdf9/UGI k75oGdJXDYQGfdq8CvnGI/Tp74NEEKpvGWw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdekjedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Jan 2024 22:47:09 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v2 3/3] mm/compaction: optimize >0 order folio compaction with free page split. Date: Mon, 22 Jan 2024 22:46:35 -0500 Message-ID: <20240123034636.1095672-4-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240123034636.1095672-1-zi.yan@sent.com> References: <20240123034636.1095672-1-zi.yan@sent.com> Reply-To: Zi Yan MIME-Version: 1.0 X-Rspamd-Queue-Id: 333B014000B X-Rspam-User: X-Stat-Signature: yb4ygwcbn3up9af7c57tr6747s4n98om X-Rspamd-Server: rspam01 X-HE-Tag: 1705981631-716099 X-HE-Meta: U2FsdGVkX19sJ/L1gVsOWY/XcTO5NhfZYuL0Uc7cYhwn3qQXMlsaV3vQn2YHDHPSsdueKywm9S0xTCBKX+E5RHOuLm5+GJRmNAp4EbAidJbxiQN0DDfNohNIzGThHyBtrKtMGT8uklkzsadca6wW2v7VvJKVpGTPiCnaPRUBB8H4qLuFWfAtPzss9WmXcL3CsHMeBPCvDDzqOQtKRQfcxyHKx/w7JJwQsnBvTZUFnj+/cMtovilYcNy/Ow3eJ26nwLPkiYdUg63LFVauY1Qps2bIbWrOHHa6BCqRQulWbFv0pxpoaQqzn4Oocblxwrr20BqkCGNPxpoTMk70/WtVOHQpVd6ozEMV5pOF47FU8R26p8oI92RZRWDP06itWqibT3I+4AfqfNRx+Blni3MM9CnnL+PelSPoNEToqNaNLT/RfvDZ3cXoi+SfSFZN1Y37c5oG0dFp9JmiFQLWXJpg8hAeMB0jMooFctnnV0dzarpFWQNw29tnEE3kOXJtVUrRg1xJu/SFfNBAF7tQK6M1tKmjcdOmqvuiRPIW3IXySe6Kc/HHvVcpV0uuhn0ZhrgQRj/NXbzIk+KaWaHmfSg9YNEMvNHqGtiKZLGA7Trzk6UjKi4QiKKmU/Iha/BDVIlZ93+ZRP0Qd85ET3iqw9rN/fiwsZAB9NNgwmpXxMBQOvR5vnytJXFROfWULi4d3jf29oBKbqY7D5wHAsu8yhHIPiYsiVhbobKuQhkSn7NjF0Oop8Uu42gYS9IYMVQ0wPoGbBNjFPc4GdvH2dpxaZcj4FKb9r9e+MyaSAcRx6NM+M4xe1mD0VN2f/RqHTW0WXenB5ZtV+Ivzu3wipbMK/S9RKkpSohbNreKMUlP7jyv7C4bhm1Ndd5ts01IzQ9YWAnVnDtaUERxPfwFy+AXU7SIUL7GSz8SC6ps0+m9i//nH72qhJb2kaYnYpgrF6pSdv+ATFNzDc0Utat6wuTnU4b iA/MNiXi t+I/iFjBC1l1PsLW2Ac/uUqUHIP5HtEP5mBlVFxYMlSzeL9cTImuENvLbffevTdpYNQbHt8OnSWa1FLWZ0uwjN4kYqfM2R4g5ItBCMQj6obxI/51upZm1k+zcv2V/kZ42iHIaDlc/rkO5nI1aDvR2F+FN/618sbZKR+rYOk8oYbb0I4E0iBWZC/2Iq6JaUaup5YkZ0RVgPAPYlTtPHceTuiSNRFi4UoadbroDFlih8GxccYVn8xbj/d01ZfkKQJuKyXEivKQ9H9ja5LJPrRdJwAmoRtiGw2i8ZkHvyxI759R3q2ea7hSy1lcQOs/vSDJGkNlLmDMY0yHtCwTEali3OFc7g/oSpUr7lAEBZHJyufr3F3iE8HPmiS+0CArYFQsPCBr02PbbT5Tr0QpW8tKo0gaD7+LVwhCsvH5kemJCf4ItZj/wSzFwfgBWo8hN874EMbsZCP11U/+ctGCv8BuggnMUx7b13YclyZld/LR9ZIcJLTy19UQywtnlhWzDfCoW9troMHUByo3TBxM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zi Yan During migration in a memory compaction, free pages are placed in an array of page lists based on their order. But the desired free page order (i.e., the order of a source page) might not be always present, thus leading to migration failures and premature compaction termination. Split a high order free pages when source migration page has a lower order to increase migration successful rate. Note: merging free pages when a migration fails and a lower order free page is returned via compaction_free() is possible, but there is too much work. Since the free pages are not buddy pages, it is hard to identify these free pages using existing PFN-based page merging algorithm. Signed-off-by: Zi Yan --- mm/compaction.c | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index 11f9898e39da..052c82481d64 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1812,9 +1812,43 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) struct compact_control *cc = (struct compact_control *)data; struct folio *dst; int order = folio_order(src); + bool has_isolated_pages = false; +again: if (!cc->freepages[order].nr_pages) { - isolate_freepages(cc); + int i; + + for (i = order + 1; i < NR_PAGE_ORDERS; i++) { + if (cc->freepages[i].nr_pages) { + struct page *freepage = + list_first_entry(&cc->freepages[i].pages, + struct page, lru); + + int start_order = i; + unsigned long size = 1 << start_order; + + list_del(&freepage->lru); + cc->freepages[i].nr_pages--; + + while (start_order > order) { + start_order--; + size >>= 1; + + list_add(&freepage[size].lru, + &cc->freepages[start_order].pages); + cc->freepages[start_order].nr_pages++; + set_page_private(&freepage[size], start_order); + } + dst = (struct folio *)freepage; + goto done; + } + } + if (!has_isolated_pages) { + isolate_freepages(cc); + has_isolated_pages = true; + goto again; + } + if (!cc->freepages[order].nr_pages) return NULL; } @@ -1822,6 +1856,7 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) dst = list_first_entry(&cc->freepages[order].pages, struct folio, lru); cc->freepages[order].nr_pages--; list_del(&dst->lru); +done: post_alloc_hook(&dst->page, order, __GFP_MOVABLE); if (order) prep_compound_page(&dst->page, order);