From patchwork Wed Jan 24 07:36:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528685 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81CABC46CD2 for ; Wed, 24 Jan 2024 07:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2i2h9X4eNJS+2xUJdF2yYyoVbXxkwvbjxPw7k1MHCPo=; b=FXfxtmdK/C6iiW eiUc8Yfl6+QyjXmHjMVAAqKLjDa91zeBSMPF7DEYfyDCwYMwAqPPUp81IyYZq/G3TrrPDDaQdjurc NT7R2eYOvwJ+bjDY4DiVR+iMxff+pSV06Fo9+aqURt8fyeaG1IsygqUb7jlwTmL9K2TlYxq1p8+Cr 2PyHPJUalXMl2XbhgFdv7EEJvvrIFt+wp7Kajf7YJbchmbG1DIrkEX5hwP+KHBnVICI7w7qaCj0sV NQgLVAn0Kv0kjY0JKRrBDTtC/XG0Vo8Vj7Bcwy20ygmVdPFRKvoWAEetpLDaBidTTkX7UqK+BMZOZ YJU32yXnx8m61sDQY1YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXoa-001sIr-0H; Wed, 24 Jan 2024 07:36:52 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXoX-001sHR-2C for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:36:50 +0000 Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-5cddfe0cb64so2613776a12.0 for ; Tue, 23 Jan 2024 23:36:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081808; x=1706686608; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=acrJlYqUICjl/fNKMSHxOuQG7AfEPQFGVB71vx3dR1c=; b=MLWbHOohe6ctmiblpT4FsBdsaSJscuUI1ChtS2tqR/5DPc3PUEji6u50KlQ8Xtuc+5 r0UiJkxFupzqWMfVy6LcfmaAiykIg48+MQpEEx0qb66awAJBtdyanvLvOhmLinkTm8VL xZcQV8jM5vDOwfUcY61uJPMc60mEbsum81we5TAJoX/AEgei6Kz6rwsZsh+5PC6sjJvK 3AWFZfUU6Nc19ZBlnnyXseduzg6QHRQB74dnL/mqo4DNebWeyhMCASjL8Y3//vGzOzch wUThFZ82YnrcaLOquxbd1cf/pScaZ0yKK/j/GKze4DJec/yfGRUx4qqlIkYx3h4n38XX yq9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081808; x=1706686608; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=acrJlYqUICjl/fNKMSHxOuQG7AfEPQFGVB71vx3dR1c=; b=JG6o4/8SRSL6R6MDWoxaGAxDGI9a509wyrBKp3uxwAayqv5asDI9j9dK4ptlOye8Cr yvMngO1MCoSIz0HLid5YLN39Hon7GUAyJgXcYS4VudX9ZNaDMpAXifQBfB0dVhrrgmvG 5Bmc5o3NSDT2MYJ404AqVbNF81Gz9xaONyrnnMgyB4wH+JuI0o1Jk25hT1k8LiqhHp1Q D3ZxW4RI2e45wxgwVKtro8eSQXLqIEBPfT1XT8zdzR+Z6js5r1MxYabbAdR4vLrEt1nc OkYlqaWmXvXIZLoC55ygUdmKhwITsaf82czZNfpE+WSYXyw8c8vQFxfsF22OoAfIFJhb CHSg== X-Gm-Message-State: AOJu0YzSM2KNGwam1EeLjnkwYMVUut8lDfFD6BOcysWwONU++rZVkFgg pNm+J64wPXn5OfQHOX1iWb9RARB0bAfWUC2VN0MMxXUuLr0P5wtV4kcbPwgE6A== X-Google-Smtp-Source: AGHT+IHMZADYbjyE70v0RtIuM4joKlEWmfgzB62tpW1UDbeUqXCniEdLIob+5sbOtqxUtYoqeFybMg== X-Received: by 2002:a05:6a20:bf03:b0:199:aeaf:cd3b with SMTP id gc3-20020a056a20bf0300b00199aeafcd3bmr270676pzb.42.1706081808139; Tue, 23 Jan 2024 23:36:48 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:36:47 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:29 +0530 Subject: [PATCH 01/14] dt-bindings: phy: qcom,ipq8074-qmp-pcie: Drop PCIE_AUX_CLK from pcie_phy node MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-1-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1433; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=/R7t+UW6ZmKuKk7MIzT+d0YPo+66e3175rDe543o5Ic=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4CiEXvEQ+narxvebS5XjcYmsO6QpgRHqHvp rAqTcXLWsyJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AgAKCRBVnxHm/pHO 9eoUB/9jif/45s9Im3bQE1b5z3netk6pqcfdn67RHHTYUyCIixCOxMKgvmqEN9n48XIP/d9RFRt R7IlQxs2liAg57al7DMCRjYQUeAkMXAu+cF43aY+PxK+xXa/QBy1Tb1KT08qC5AhLmaGDjYLlmL EwnWwzX43aet5J+7NxdvgbtPxlVkGGDAKrroJeWin7T02c47+/915MJ+mjIFnWdHUX2b+NfFjm/ bnSiNEf73NJRZjPFsug7zRq63JB5dG2dONZPsogzL6Plym+hinqwcGQnzOTpSJBU8QFy9SUJRAy SDiAHnJUf63xHOazM9doqVZJe5OXjdAJoRCwSitEo6Dr2A1I X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233649_718362_65860377 X-CRM114-Status: UNSURE ( 9.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from the binding. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml index 634cec5d57ea..a953ac197dfd 100644 --- a/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,ipq8074-qmp-pcie-phy.yaml @@ -25,11 +25,10 @@ properties: - description: serdes clocks: - maxItems: 3 + maxItems: 2 clock-names: items: - - const: aux - const: cfg_ahb - const: pipe @@ -72,11 +71,9 @@ examples: compatible = "qcom,ipq6018-qmp-pcie-phy"; reg = <0x00084000 0x1000>; - clocks = <&gcc GCC_PCIE0_AUX_CLK>, - <&gcc GCC_PCIE0_AHB_CLK>, + clocks = <&gcc GCC_PCIE0_AHB_CLK>, <&gcc GCC_PCIE0_PIPE_CLK>; - clock-names = "aux", - "cfg_ahb", + clock-names = "cfg_ahb", "pipe"; clock-output-names = "gcc_pcie0_pipe_clk_src"; From patchwork Wed Jan 24 07:36:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528686 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA1D0C47422 for ; Wed, 24 Jan 2024 07:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c5VRZrl+JBoCE7KdBOxPetR6PNizWT3qINGiMhyuCUI=; b=CMQq/+I8wSYB/D 7zHmxnwIcD3nGGuSD23DBLp9Su9l1sfCIhbIGCcud0YWRREHWd/NpAPVezS9cW5cuWP2LNoZJGimP jBBdyJy05ObtxTgwdGJ3WUw2TyThPj7lK/Xh6JE9FDwqyOqReHhtw4okRAr6tdwWpkBeG7hD/eSVP Sjfi/eyQtGGDZTHP136gflKar6vDPRGJBRs8LGFoQvK+s3WmesgQUr4O0gRXGnGS6fSbB8PJrnqzO aMXn+gJ788566ogfdx9R8szs4PFB3uEtmSamPaXMRtzqS6dSzLY0mUlIg3L3hK1lfQ74ksqlbuL13 cuGCOtvObXR9usTHRYQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXof-001sKN-1f; Wed, 24 Jan 2024 07:36:57 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXod-001sJQ-0W for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:36:56 +0000 Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-5cec32dedf3so2733520a12.0 for ; Tue, 23 Jan 2024 23:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081814; x=1706686614; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NEnCFhhmwsb7wajVYXLbkhkhFCstNg2EJe/RBvp+MYA=; b=I5dJbOf3IMrwE97cg+3tsynucxPHlmH26RQEG4NHH/tzTZPPi9gAuMekMF8nRmtx4j G9khZvbPPscaWxsbWFUZo6hAHMGxdmbqZI8eX+CY7hb5DK0D5R7KKyxtudcic+aY1uZe rOoISHExKa8hFwoYKEw8CnWMiLCS4YfJHLXSWjWvL5S9DFt1IQT4EIvp4HUM6rSXg5FN Ow59buCl7Bh2hNrD2YRhDUrlFXayd+4dhKM7ElrZPSwQ8k0AVOOBrB/qGs3yuWRfTXlM Z/Pd07ZbNQCehqpBAI+IB3fMA6CnrPUZAG29zuRNfRsh4UxC2Ko4nTVw3tNDXTiGNWo8 sElw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081814; x=1706686614; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NEnCFhhmwsb7wajVYXLbkhkhFCstNg2EJe/RBvp+MYA=; b=KpN1D06yMwAcgcOwwHf6rtbCqh0VjC5PBDDyEjWbJwHVqTt29/Ii9Dd7MYG5x8gyW5 MuF+JXDr4sQQpd5ZmcG1oTdrDPDQvgtb6D5ONEb/tugUpHVkYh9R/ABFfkKgwbCh1gIw xLKG1QwsYsLe8HkYC5q2z2rtvkq9nC5Y/bpdQFxj6o3Svu6Rqf5LviyEAK7yQZ6hcUvW hVR+MFXAqOR+YJvjkoKINmZg1xZ3J0smUF71JPoHPEe6ver8xGxJLCeNja4P6Q+IC+Xy pbZPdrxqmiBpuVFi4hxhdIqK1Bo9FsMTsh8Ppr5LQbvOSC1UrgMJM3iV8J7h0fGHWudy 9t4A== X-Gm-Message-State: AOJu0YwxFzcJ7PBHRI433M+eF/hMQY1XNeCKphrH1pqFUNKPYjlAmtTz BDLjdj489o0hnQbGROmKkPBCbs4QTzIyV10deGNJZl5kJUbUABwx4Xa0RSkDtQ== X-Google-Smtp-Source: AGHT+IF5vLJU2eGh5b5arpYHW5lYcd7oWV3PajDcJ2tAy3xBarUKGSR/ATJC0UF0GUZB4gYaeGJ2JA== X-Received: by 2002:a17:903:120a:b0:1d4:2330:85a3 with SMTP id l10-20020a170903120a00b001d4233085a3mr341846plh.20.1706081813873; Tue, 23 Jan 2024 23:36:53 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.36.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:36:53 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:30 +0530 Subject: [PATCH 02/14] arm64: dts: qcom: ipq6018: Drop PCIE_AUX_CLK from pcie_phy node MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-2-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=979; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=fGj8Hc8YGkorO50XWw23uE3LCV1avN5lQsXZGvyanM8=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4CGTLW5PHE4v+QOjUwEzMEiiZ5MfA5DaNcj cyvMk7JDkGJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AgAKCRBVnxHm/pHO 9fWvB/42xwjITFqhAyVbIdl55fGwYHKR5rjdxAep68tNBpd/TDx47zwOB4CQorP44+PsGLFCCuJ Kd+miwAqOtGDcUbCdlmEtGByRdfJ4lYIJSThJHw+8cZMHdJfPOTbQgQx72cRm21eTxP62gerfNU ghiEAGHcO4Cn7M0s4yznO6JUcBxCJJh2ZvD0Xrq1pMZXtErnpGMvMTxcI2qlSzVHLqCFvfUVViK 1lMyaKbezsLE8Erot6tjnO8oqu+s8kQL2Fz/eSWOPxygbqdJhwiBM5sfhFSJjeu91I3ZFhfE7Jv 1SRvB5M7rigAG/cuuo3CWLPvKtwZAMZt/sdlvK8ka2s6b+m6 X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233655_201599_88EFB93C X-CRM114-Status: UNSURE ( 8.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy node. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index 5e1277fea725..1767e5abd76d 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -283,11 +283,9 @@ pcie_phy: phy@84000 { reg = <0x0 0x00084000 0x0 0x1000>; status = "disabled"; - clocks = <&gcc GCC_PCIE0_AUX_CLK>, - <&gcc GCC_PCIE0_AHB_CLK>, + clocks = <&gcc GCC_PCIE0_AHB_CLK>, <&gcc GCC_PCIE0_PIPE_CLK>; - clock-names = "aux", - "cfg_ahb", + clock-names = "cfg_ahb", "pipe"; clock-output-names = "gcc_pcie0_pipe_clk_src"; From patchwork Wed Jan 24 07:36:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528687 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FA88C47422 for ; Wed, 24 Jan 2024 07:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u+pqLqUvhCkT4thpZhgXfd1CPfyQ8W1zuJIAXuxLtfI=; b=hbqemkuMFVOdvE TihSD6dOhIUDJpd8Mmk2YjO6QIccyjmovCZjaHbCHrCp7FynAzeiZ23HjJ/qbyIQO/KZT8R64DNa+ xM5OdNdiLqKRhpUWmza41kJ+X2zc3Fdl7nvtDw/3JjPC8MQuz/XWcN05jkttLEXUhDkYjEWI0+KuF VgSKWilCC0YYANe4yZPVvuMMFAVWxn+c7m0pl8QbgrmlT5Hgqg+h99ZqzN5K2sb3bt9mlaDK+x04a Pw/qr/CKP7aoD7mJMXL2NOXTqCtT1CRi8dIayl9SalN/BUJkEQuYtINjcWQs/pBgUoLk7UJitw47j NcOzX7UWmYWuosN+Usgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXok-001sMh-34; Wed, 24 Jan 2024 07:37:02 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXoi-001sLg-2c for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:02 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1d711d7a940so44977865ad.1 for ; Tue, 23 Jan 2024 23:36:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081819; x=1706686619; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fBFfSaJckS21En/NRtO5B8XnRhjsR2n6FJYjapBTDSs=; b=AWXT7Khg+vFCYWa2YmHSK+JBekSBgo+cCg4WfLQxvDQ3z9qlIj9c5+7BWGcihD4REQ ClXNk9JQi1j0misH5OTjCHBJGZkBtLks7AIP1w+0UOcgyFaZ8HnQkHQZsU9iyw5PhqBt cj/YYFFZrRa+KNn06LLaYtBZRajoYyxxR4un0mcZh9MZ1ogCXk5LDzS/hRzGG73lc5G0 IAJOFl4g8KAIvwWR8f47ecjJTuoRqlIaPbA6y8WtI8wU3bW/YQxnL7VT6E8PNkg3+ZQP 92n6ZZudnAzJSH/3DgXfIr+UwZ8/P5RaCbukFO3tkuRPM6Wtf3XQFUNFDcVXiFqJQIpf jc6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081819; x=1706686619; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fBFfSaJckS21En/NRtO5B8XnRhjsR2n6FJYjapBTDSs=; b=u3oW27w50eXzyfJprULg1emDt3Cy6bdw1Oc7Yt8nEMfJVBzT2NBle363PEPT021iCs QEc0MFIxU4XZ4s/ksh47Px3D1FwpTMKvZEjC2pTCbUnlQmtwiqXD+P3WxRdhLvr7RySG xcLVVm6I259/ZtUR4AJ7pdyKhQ0V6+Xu/ASGWWImfWmhswkcV1UPwJYfIuU/dqafoXt9 ud5U7pc5jenA42T9P/IdlkrajQCzzKO0lpostGXp4AZ1X/FaRFhRevEr8vtq9AgwpsAS VzGfgPh9G1uXYxEN7ga4TFQ4u14xXv81srBoImdOuV8StBMgDulwrjLDl3dcPvNiq+ny a5iA== X-Gm-Message-State: AOJu0Yx8DorqUz1O5+XYv45e8dz8EwWj7VzfvY+hWK0O+I1JzrVc7lWe edAQiMYuX6oeH+q8rEMXb7iJ7xdKEPm45e+uDoF2/QzY81TZZKQU6Bv8Ifn62g== X-Google-Smtp-Source: AGHT+IE/wIYSrBooEZbLDcaYsE02CGekV66QkvsrVyx5eIErSHKRtYDq10wSgZoYRynCa5FasB0XrA== X-Received: by 2002:a17:902:b086:b0:1d7:450c:be68 with SMTP id p6-20020a170902b08600b001d7450cbe68mr420926plr.66.1706081819311; Tue, 23 Jan 2024 23:36:59 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.36.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:36:58 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:31 +0530 Subject: [PATCH 03/14] arm64: dts: qcom: ipq8074: Drop PCIE_AUX_CLK from pcie_phy nodes MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-3-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1432; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=tYw91gWuWNXo6BYZKlOtQvxOlV3OGyDBw5hpVkCGZg4=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4D9c6rL/7BFeef/cHzRgNKqQG03Iu+2lSju AQE1U2qnCKJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AwAKCRBVnxHm/pHO 9VhrB/wP2eETp8NYOX5qto7ovhKQ2P4/3bYol1vt6g4fztAd3bHWpS9MUKd8KRh3dClCjYyXF9a apf4vWrS7pBAcxfIuzNWKyMkGJXN2o9LaIUgxayNJh5NpKHQx6ayHxd5fPlfOc/LMgLV8Fxodys m4oB3HB5yJZGlIlI3gNFKGVej//Rl1/QlkmKIiTQgQGgQwBLOGPrOssNn5QQ77PKahrqwMmr48C iBeoWdT/2cIhJwLBlknzbJzv+SL6LoPOIATBDo8PXmens/WyDVPzR+djCAU2FMsRcwN9sCgo4lR jx1HO0hJ4jMe+fAcjZ/XabH6wlUWpH1A37pQNWQpLqZgkDX7 X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233700_850452_42C0F502 X-CRM114-Status: UNSURE ( 9.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy nodes. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi index cf295bed3299..6ae6833e8969 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -201,11 +201,9 @@ pcie_qmp0: phy@84000 { compatible = "qcom,ipq8074-qmp-gen3-pcie-phy"; reg = <0x00084000 0x1000>; - clocks = <&gcc GCC_PCIE0_AUX_CLK>, - <&gcc GCC_PCIE0_AHB_CLK>, + clocks = <&gcc GCC_PCIE0_AHB_CLK>, <&gcc GCC_PCIE0_PIPE_CLK>; - clock-names = "aux", - "cfg_ahb", + clock-names = "cfg_ahb", "pipe"; clock-output-names = "pcie20_phy0_pipe_clk"; @@ -224,11 +222,9 @@ pcie_qmp1: phy@8e000 { compatible = "qcom,ipq8074-qmp-pcie-phy"; reg = <0x0008e000 0x1000>; - clocks = <&gcc GCC_PCIE1_AUX_CLK>, - <&gcc GCC_PCIE1_AHB_CLK>, + clocks = <&gcc GCC_PCIE1_AHB_CLK>, <&gcc GCC_PCIE1_PIPE_CLK>; - clock-names = "aux", - "cfg_ahb", + clock-names = "cfg_ahb", "pipe"; clock-output-names = "pcie20_phy1_pipe_clk"; From patchwork Wed Jan 24 07:36:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528688 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D16FBC47422 for ; Wed, 24 Jan 2024 07:37:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4QuCeeUBpHIsMzg1e4bb1+PIk/Vy50JJPYNq2hiwacA=; b=GGoihOSzRyD0+B bpQQUgxT1YpYeSFuvUlejkr08/cJZeUaAC1z46ofIYsc7NnHZNbncecB6rImzK5dqxHYW5lR57w4E 76j51dgXiCzLufddIK4x/WUo8nAI+pnvBA6p5FysD4NM/H2lOYRWouHIGl5Y8K7GcaIreWdGLZyVN JSju5Thv5gMiX/SJpy/QlOjk/uXMF45cUNyLwjb2PUpTN5FF9jwndzERazM/HuAuEsuXw3MDcWHyj LMsIrLQva2PeuB2yky2eTJYSymkfbk0z/3ewOLkQO8zt1yXdcrPB712d1OtxXkjHATiEv0V7B9ZJa rz23pWqe1ciqAGCTn5xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXoq-001sNk-1J; Wed, 24 Jan 2024 07:37:08 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXon-001sN0-0N for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:06 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1d7354ba334so30721605ad.1 for ; Tue, 23 Jan 2024 23:37:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081824; x=1706686624; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TYkvTvEMLj4JoaODxeTHusWVUfI5+qI8qMmzgmBVEBE=; b=j6+ayXd+VsMu33InJUzWHiPb7VxUnluhpLE7R+kDIqphd4iKasY9vakQ89R4kbhJ4z 134yKBrMneFRS01ejfy3k3a+ayJ4Iz5WMkofIAaX1U2WywbrIzjaLdLcyIBP/7deqXYU 9TVYmg2CbV4GTZ5JMox2Bj+yqNat3cCxbAjJu9GXO5TU9NROF5dy9i18+nyJpa3Q/tr5 +a56tKvyKpedbKVQtF7xqiP/5/Vu0N+Ny6K5Jjij/pSAd9n7jFr58Jga/dzN6YCQ0iSB pomJpx0jyLXRSz6aAedwvO+wQS3NKt3uQ0k9i3y2RKZ7kOjWOsXLGlXm8W7+51T+0Rp4 AOiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081824; x=1706686624; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TYkvTvEMLj4JoaODxeTHusWVUfI5+qI8qMmzgmBVEBE=; b=d99PQgXpyqVTOYgSkOHgoGqD23HelYMbP1Vdq9IQkYBLmYCcLv+FW6iVq5PBV1aPgz iwLZkOPnynf+8w9ZTTT9i1HELhTcXRko8VsGh88pCTsyVaINI4WKzkNzJUZ2BT4veXDZ KDsgfKKIMHUjd2yLQClrtdDv9D3h/B22V5cLe1MIwRm0at90yTouCUVpV8hbn3o6t4D4 cz2POX7ZHDxJlVVh2qrbsvLMNAcUkAMUBYUN8kmq2An71Cg07SgXiVJR7NfvHY9cpyaH e8bxPRKYYh1ipFPE7Xj5P4wuwoUA2G7lFrhXhFnf8JjmGFNy8IDVfN3j3Pvoyd/4VK31 fCDA== X-Gm-Message-State: AOJu0YxL5XqytczdlbrgnTwrXrYCs0/28OBC1GqJ8x8zDy/6bo79yFaB ODcM2u3tpQz3B9gVIHbei05rfw9/L6ZVI5tyUZfa4WURxPkfQy4Nak0wVQtIfg== X-Google-Smtp-Source: AGHT+IGTjeibUHV4ILPDRl0hWCHWuyMofMnIPtbp+2gsEYpQvq4noe4HRVKYN4q12hIlzAyNaf3Y4g== X-Received: by 2002:a17:902:7401:b0:1d7:e84:4ede with SMTP id g1-20020a170902740100b001d70e844edemr494893pll.67.1706081824565; Tue, 23 Jan 2024 23:37:04 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:04 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:32 +0530 Subject: [PATCH 04/14] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Fix the usage of aux clk MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-4-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=6248; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=FUkkiV+2vDk+h8Fu4sCklCuzOARyg+ribP0i686xTfw=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4DHLbLRu4/rLPOQs1IQsAM94Al1MnHSEL/G wX5JYbKC+uJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AwAKCRBVnxHm/pHO 9V8RB/4lFYgeiPK6H+XbHF+JN0qyPo58sySDUBLf/BX0tIhPOzwJ6npj041l/nk5ec9gDfo+CaN tJN7h8IN6S8zqtRZrIy2JpUo2nctn7HEPPoeRuk2DLVh6rTPwxGcFa01gSuDGZ+ajytR+/0Z+wd 3ZtZXVcUaHBxJXJEznY8SUrE24e99wXNhCJBIvKGT9+b/6eo0RPdy9m+dDm6a0R4zbL8QQg60Mb e2WBw9v+QGK8KSPyaBupTaM4ycBHxC82P3Ryvw7RmdJTuym6QexRpM5wLaAqPrStq4S4NXq95Il 5yImBNw7KWTyGuutHy0uYxDMv9X3sk3SwQGY3o6cFYpOehfw X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233705_152069_5483E700 X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On some platforms, PHY block requires PCIE_PHY_AUX_CLK to be used when the PCIe link enters L1SS state. On those platforms, a dedicated PCIE_PHY_AUX_CLK is available from GCC. Other than this, the PHY block doesn't require any other "aux" clock, including PCIE_AUX_CLK which only required by the PCIe controller. Historically, the DTs of the platforms requiring "aux" clock passed PCIE_PHY_AUX_CLK as "aux" clock. But over the period of time, platforms that do not require this dedicated "aux" clock mistakenly started passing the PCIE_AUX_CLK as the "aux" clock. More recently, SA8775P platform passed both "aux" (PCIE_AUX_CLK) and "phy_aux" (PCIE_PHY_AUX_CLK) clocks. So to clean up this mess, let's remove the newly introduced "phy_aux" clock and just use "aux" clock to supply PCIE_PHY_AUX_CLK for platforms that require it. For the platforms that do not require a dedicated "aux" clock, the clock is removed from DT. While at it, let's also define "qcom,sc7280-qmp-pcie-phy" compatible for SC7280 SoC which was earlier using the compatible "qcom,sm8250-qmp-gen3x2-pcie-phy" as the clock requirement has changed and also restructure the "clock-names" property for the affected platforms. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Krzysztof Kozlowski --- .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 79 ++++++++++++++-------- 1 file changed, 52 insertions(+), 27 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml index 6c03f2d5fca3..2396a457f9c8 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml @@ -18,6 +18,7 @@ properties: enum: - qcom,sa8775p-qmp-gen4x2-pcie-phy - qcom,sa8775p-qmp-gen4x4-pcie-phy + - qcom,sc7280-qmp-pcie-phy - qcom,sc8180x-qmp-pcie-phy - qcom,sc8280xp-qmp-gen3x1-pcie-phy - qcom,sc8280xp-qmp-gen3x2-pcie-phy @@ -44,19 +45,12 @@ properties: maxItems: 2 clocks: - minItems: 5 - maxItems: 7 + minItems: 4 + maxItems: 6 clock-names: - minItems: 5 - items: - - const: aux - - const: cfg_ahb - - const: ref - - enum: [rchng, refgen] - - const: pipe - - const: pipediv2 - - const: phy_aux + minItems: 4 + maxItems: 6 power-domains: maxItems: 1 @@ -130,6 +124,28 @@ allOf: reg: maxItems: 1 + - if: + properties: + compatible: + contains: + enum: + - qcom,sc7280-qmp-pcie-phy + - qcom,sm8350-qmp-gen3x1-pcie-phy + - qcom,sm8450-qmp-gen3x1-pcie-phy + - qcom,sm8450-qmp-gen3x2-pcie-phy + - qcom,sm8550-qmp-gen3x2-pcie-phy + - qcom,sm8650-qmp-gen3x2-pcie-phy + then: + properties: + clocks: + maxItems: 4 + clock-names: + items: + - const: cfg_ahb + - const: ref + - enum: [rchng, refgen] + - const: pipe + - if: properties: compatible: @@ -144,19 +160,19 @@ allOf: - qcom,sm8250-qmp-gen3x1-pcie-phy - qcom,sm8250-qmp-gen3x2-pcie-phy - qcom,sm8250-qmp-modem-pcie-phy - - qcom,sm8350-qmp-gen3x1-pcie-phy - - qcom,sm8450-qmp-gen3x1-pcie-phy - - qcom,sm8450-qmp-gen3x2-pcie-phy - - qcom,sm8550-qmp-gen3x2-pcie-phy - qcom,sm8550-qmp-gen4x2-pcie-phy - - qcom,sm8650-qmp-gen3x2-pcie-phy - qcom,sm8650-qmp-gen4x2-pcie-phy then: properties: clocks: maxItems: 5 clock-names: - maxItems: 5 + items: + - const: aux + - const: cfg_ahb + - const: ref + - enum: [rchng, refgen] + - const: pipe - if: properties: @@ -169,9 +185,14 @@ allOf: then: properties: clocks: - minItems: 6 + maxItems: 5 clock-names: - minItems: 6 + items: + - const: cfg_ahb + - const: ref + - const: rchng + - const: pipe + - const: pipediv2 - if: properties: @@ -183,9 +204,15 @@ allOf: then: properties: clocks: - minItems: 7 + minItems: 6 clock-names: - minItems: 7 + items: + - const: aux + - const: cfg_ahb + - const: ref + - const: rchng + - const: pipe + - const: pipediv2 - if: properties: @@ -215,13 +242,12 @@ examples: compatible = "qcom,sc8280xp-qmp-gen3x2-pcie-phy"; reg = <0x01c18000 0x2000>; - clocks = <&gcc GCC_PCIE_2B_AUX_CLK>, - <&gcc GCC_PCIE_2B_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_2B_CFG_AHB_CLK>, <&gcc GCC_PCIE_2A2B_CLKREF_CLK>, <&gcc GCC_PCIE2B_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_2B_PIPE_CLK>, <&gcc GCC_PCIE_2B_PIPEDIV2_CLK>; - clock-names = "aux", "cfg_ahb", "ref", "rchng", + clock-names = "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; power-domains = <&gcc PCIE_2B_GDSC>; @@ -242,13 +268,12 @@ examples: compatible = "qcom,sc8280xp-qmp-gen3x4-pcie-phy"; reg = <0x01c24000 0x2000>, <0x01c26000 0x2000>; - clocks = <&gcc GCC_PCIE_2A_AUX_CLK>, - <&gcc GCC_PCIE_2A_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_2A_CFG_AHB_CLK>, <&gcc GCC_PCIE_2A2B_CLKREF_CLK>, <&gcc GCC_PCIE2A_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_2A_PIPE_CLK>, <&gcc GCC_PCIE_2A_PIPEDIV2_CLK>; - clock-names = "aux", "cfg_ahb", "ref", "rchng", + clock-names = "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; power-domains = <&gcc PCIE_2A_GDSC>; From patchwork Wed Jan 24 07:36:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528689 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 447BDC47422 for ; Wed, 24 Jan 2024 07:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=poIrIRltSD+XV40ArJDYuO/YJSXJnUuSWpI8CD/ac8I=; b=tAetcg85HxRjjx zNTTFMWYdpd1POeYYTmleqHr86t/UxNPap/YZOFvaKTz7zPvbuvjv8EzgtORiIAHMEM5mnauBek8p p6R2TvRqS9wP7RfVAZxgBeIi/VfV5nk6W/W1x9QEmB4YCdt9nRd/YGbMVIDzfSHaqYXcrVlJ1YIe6 Qq9B8xoQsFuK0nojJIK9vV7CTrHaF8dLr2RBo+Qm8rKk9quQrREmEYVmjyJBFHCqBnElUOZTIPUve XGxEDJ0UhJhasWwHW4iQzw16A8kjrrCBlWqeaQwhL8UMls1aqRiFuaRMSSe6gfSHRBKZTFd2zjWo3 E6FI7UHgN4vlAbvZEfKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXov-001sPm-2j; Wed, 24 Jan 2024 07:37:13 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXot-001sOV-0l for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:12 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1d70a986c4aso22720025ad.2 for ; Tue, 23 Jan 2024 23:37:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081830; x=1706686630; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OZuZcdUnAaZplEI/q0+jQccDNm87eHwhpTq9IdQtppg=; b=QbmAU7rFHQU7B3LzdtVBlClGmjWd5KcjCsWjEN3pHon6DRZYQwDKYUt1+1b+3UGgzy lbNVFA15QYoVpwZC//2n8JObQrIzzT6411pYHGjUgPUwXB3C3Oyt81YTodacpiSpgRhk uuKRRB/7RtekDf+3Mq7ANOtq4/BlsGPbv66t5IbtZLJWkohb2vRPjKTOsXrjNINYU4Cw 9S3sIDyj9GO8LZC7KJKXhhsVYah3rbTeUujJNYPdho4l4QN7q4H6CKJDuEB0q8jCGIMH 7unj7RDIedybeg91Lm/iH+/X5GVo7QafvRBkjJHNRDkTsrtpJUA1D3nyL5XpAJKza9wJ 9eJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081830; x=1706686630; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OZuZcdUnAaZplEI/q0+jQccDNm87eHwhpTq9IdQtppg=; b=OqRalsB2vFbuqWJ1iv8a/BLD/pgSRcf17NosLwqsLWi+3gqVcN3b2U2LMRanCRRjYo zmk1M7mCrbpHw1N8w0M3NyXChv7BPZf/cdmx6fJ22aTNP7/ovAWHaOTnuzY5sUYpZdSm CvyYHJxv2ZyuJQ8qGitQZf/DY+Btv60d4iFiwUuxRcCzFYF126B5nU258WzNBUjFZv7l Dq5PwetpcIiJrshxmK8nGZPsd8gqJFODoIBdEGXVkvnnTHRBBApDkSPSYSY26Ocb3vnA sTeksIHu/j9zRCR8CbPVR1z9ghFM6PqUNPYinRBuqKH75BhemoaHhk3W+fDCkp27Vdw5 1sfw== X-Gm-Message-State: AOJu0Yxqgg+b029WTBSvXgXs+lkix3NYo7oQbCPOnQUUxiWVke+xtREs 5OU156aG4jvPrzoFhQj73YCq3kVnjyhHcYNGJdchLjRX+FU47NN7cBGOigXkgQ== X-Google-Smtp-Source: AGHT+IG/mhM1tXpIYDJ+QgSt5kfSy06HMtXU3+wdXvqf7yd/1q4iuQ8Li1G5PSzHd1qUO9SSeGiszQ== X-Received: by 2002:a17:902:a9ca:b0:1d7:599d:ed25 with SMTP id b10-20020a170902a9ca00b001d7599ded25mr293175plr.39.1706081829738; Tue, 23 Jan 2024 23:37:09 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:09 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:33 +0530 Subject: [PATCH 05/14] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document missing compatible for SM8350 3x2 PHY MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-5-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1285; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=w51HxUcd7PIFxEJ6OgE0FVVFmZ15T0vvM8776BQDfiI=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4Do/rhrRxBBcGh4nzbe8uTfLLa/A6k1e8Nm cQmYLYOUzuJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AwAKCRBVnxHm/pHO 9WSnB/wMBNvlf+Eb1MLAZ8tHAt7hDQbZWgUDPDi2vLIc8inCjo3y79EjNMOBDVB8rvgiO6TDEkF TvJIRY+rMb+1aAPNL/PGpk9TQHAOUHj9jIbQEHkZf3Ff+x0HThfGIQjSEiqTqWSwFZE8p1o/Z7u DVsMJL4cpCICemBXdHgOZW354scZhFwG4lJevvjElux9zZ1ZP6yeme47movn5L0e8oI8FMhHg6L gHZCqGC+Z3AeNALkvgGj89QPtz1x69XxWUmRzRn6mvdyXsyzC6fxRhikZ5fttFyaLW3sRKrHqXb 8fHNzR6BVRYNQcBT9Qs3tlIUuRWNVfn4Dce4+rcsM568XqXA X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233711_274969_2404738B X-CRM114-Status: UNSURE ( 7.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Document the compatible for SM8350 PCIe Gen3 x2 lane PHY. Signed-off-by: Manivannan Sadhasivam Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml index 2396a457f9c8..77338184cdb4 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml @@ -33,6 +33,7 @@ properties: - qcom,sm8250-qmp-gen3x2-pcie-phy - qcom,sm8250-qmp-modem-pcie-phy - qcom,sm8350-qmp-gen3x1-pcie-phy + - qcom,sm8350-qmp-gen3x2-pcie-phy - qcom,sm8450-qmp-gen3x1-pcie-phy - qcom,sm8450-qmp-gen4x2-pcie-phy - qcom,sm8550-qmp-gen3x2-pcie-phy @@ -131,6 +132,7 @@ allOf: enum: - qcom,sc7280-qmp-pcie-phy - qcom,sm8350-qmp-gen3x1-pcie-phy + - qcom,sm8350-qmp-gen3x2-pcie-phy - qcom,sm8450-qmp-gen3x1-pcie-phy - qcom,sm8450-qmp-gen3x2-pcie-phy - qcom,sm8550-qmp-gen3x2-pcie-phy From patchwork Wed Jan 24 07:36:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528690 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC57FC47422 for ; Wed, 24 Jan 2024 07:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ha05jvE+BnB0gnxH7becp8G335gQKFPg0sezbj0fh0M=; b=Pj0eE2Uv+xOdjg wKrEBkNPeQJtwALdpI7k1h+uGZdZLER5RBrb2xbMXB6vZfK3TyupwGaOCKxH1HtgBqiY6TczbMprz fTRVagWTfrHwFHiGhrPd4ESWhQ+QCmFHCFraaADy8UsGCKMBhVU34z5NGHHexSkNQrkiFF3PSka73 y5tyMW9gDEYRPla9X7fcDgvxDq67u38CVm2xL+hbPmKfBniyDgn0Imk/M893A/8A3K9/rgJcePIj9 Hfjg8dFeif0jYTydmgz0A4ffXE/z8CcqOFtyEsk5stRLlPUY/ez+rqDeRCLD5IEZ+KCvG6zulcJxs BQVkRvjFXcB7uHqQtO8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXp2-001sRx-0y; Wed, 24 Jan 2024 07:37:20 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXoy-001sQR-1u for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:18 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1d7431e702dso21746175ad.1 for ; Tue, 23 Jan 2024 23:37:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081835; x=1706686635; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CNpTFIF16BG7YGRQCCrKfm7GwY9WoZx+GmuixbAdH6M=; b=y+DpX0vjLt3IFEyJdbq67xUG0l+int8c0TU5ChjHwfom4A67DOx82wEBGbMC6iEPoJ rKtsvQp+Gs/ldTeBrFES+9EMSTlEcIJRrxohBVrcFgKlhynwoiBrJahLbQNqPTKhqcRl tNK2JuwHruZaECiWYORhTk+QcnLK+XCairk73yT1q81/UdyEYot/+bgsxwTiVtJxRaAO OswNSyZSiOQcDdhVUo7OmCrYYFVMpnXXXxOgDxr1/Z+WN08QbEP0EiqjjQRXhtiAorel x4ocTd85lDLfwBLkLJIrsZT1sUjKeQ59kgu2K0hP+nhitpCQyI6wY7XWWSrGnX3Av5cF ykLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081835; x=1706686635; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CNpTFIF16BG7YGRQCCrKfm7GwY9WoZx+GmuixbAdH6M=; b=OKgmWQhHYBRuwDvZ6Px8Mpv6CiYUcSN9C0979rIPfU4v2jyABzKxF710qHDmXg7WuF UPXT+uSrNhHbzQbqM7QDSDGAE/LBlf4L5xSBtMmLOh0CSyBZum/lsNZ9IL34BXw7K8US dr9s694qUhiosGVnnjsC8vfUbL/vM3Fg5bUa8ibrY8Ur4Ysx/hN+tPDkHP7LO+YCr/Iw sJF3yBQIlQVjNMaoLoBAr3r1r4dxsMbNkOPCBzrcz3tGtrZS2G+4MmkgGA1T+reDh+M7 +65XxkOh13ni8dS67BHin24u7qf3VsR6gBlUDnqfT1PZIH90ECPqrb2lAqz5FUX+wgAo gLJQ== X-Gm-Message-State: AOJu0YzrAiVvS7ICvH1QnLW/i1nk5rvS6s/46kUBMgsAdnughZwVT4AA 5lMuar+XIxj2CwpVnc+lGraEYxXXYk4Api9Rkk8CJE6bCYKi7bisaEdGcPodKw== X-Google-Smtp-Source: AGHT+IE3jPeSwyuGuMyRlRHopR8kJWwDY/R6l4wnlHb2ZcILwydWkelUDnM75QY0zsO1jxoWEPgN7g== X-Received: by 2002:a17:902:e802:b0:1d7:6f5a:d390 with SMTP id u2-20020a170902e80200b001d76f5ad390mr360391plg.55.1706081835084; Tue, 23 Jan 2024 23:37:15 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:14 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:34 +0530 Subject: [PATCH 06/14] phy: qcom: qmp-pcie: Add a new compatible for SC7280 SoC MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-6-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=941; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=zeX+jh65HInrDo/RwQDt8aTaE8xiSCz2Utb21fD2lmY=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4DPIrhoZpasm0P2lW3phBrp9L8uQenezf2i GE6tEIxzAGJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+AwAKCRBVnxHm/pHO 9ei7B/9RToHX5l2RmHvp4lJTQYUyyAWAKvGhetr7g8UkSowxxLzt9SI0p28kQVEWSeR5q2TlaOE fAwneBwub3bWVMESD+kmppRH5QblNn09PQHyw0yHQat1Zd73WI+qADs5cH6epiSkGxXnbOleJKN lD7oo9jgQ2AXnpVt7PU+dKYjgWakTEGwoXwX+Uv3FgbQnU8UonNs/7al7khJ2BPIXIuqUUw8iz5 vBX8JYDX6nDOW7ER8lYt7R9Ku47EUof15a3zXe1K5et4wHusFYsAt5jKx6XgSzZg7Bx4fjR3YSn bUmZ7IF5jCwOuX+6J21ks3UoA4mLdVR8pqbmT5zUMCSxYKfb X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233716_625851_DDED72EE X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Since this platform requires different clocks compared to SM8250, use a different compatible. But the drvdata of SM8250 can be reused safely. Signed-off-by: Manivannan Sadhasivam --- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c index 2af7115ef968..9a220cbd9615 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -3822,6 +3822,9 @@ static const struct of_device_id qmp_pcie_of_match_table[] = { }, { .compatible = "qcom,sa8775p-qmp-gen4x4-pcie-phy", .data = &sa8775p_qmp_gen4x4_pciephy_cfg, + }, { + .compatible = "qcom,sc7280-qmp-pcie-phy", + .data = &sm8250_qmp_gen3x2_pciephy_cfg, }, { .compatible = "qcom,sc8180x-qmp-pcie-phy", .data = &sc8180x_pciephy_cfg, From patchwork Wed Jan 24 07:36:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528691 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A542C47422 for ; Wed, 24 Jan 2024 07:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aKUrcbhr52bhjKMZPg38/WpRXIq8B9AipRt6eQhW+nI=; b=Vb0J8+e2M/WH8F HgO4XZfbRCxK9YY04cYmH9ELQYPt6+Uyf1yAWtArz1+8KTdoAjKFFePILDlz/aLWBzkC369Lczj+y 0U2qLoCsluI1PNRN3PXQTH/vV424mhzfp7TP5kMfBb0TxTBWlta7Lz7RG3FU5VCP0CmClDx481xSw CXar/SREqcr/Z7K3sWqqvLFm1sOpACWuPMNrOS1gLB8nREkgVJ7xAhWAc74Wby6cv/n9UKxSROEks AX+NjTUMGKqIHkgbTsof4t8h8uzMXPnbUj0owl9BQcF+cN5WEdL302i7wbJ2AT+BNIcePKrdo1FSO wyVlZ0xyVUG9xj8XNhxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXp5-001sT3-2C; Wed, 24 Jan 2024 07:37:23 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXp3-001sS5-0A for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:22 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1d76943baafso16003565ad.2 for ; Tue, 23 Jan 2024 23:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081840; x=1706686640; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oJnupBgFvOzDewfsN2fbqfoXAijS1cIjpRbgOobXJnE=; b=AX2SyfBfme7/SONLfHttKeVpvhUPFvPievWNmmGuDYfaI2f2VBQ+Zayi4YfJyKNCFt 3rd5/iSb8lP6h9hNaUlgHlBihMGn9qCih2OyE0ihzaMlxuE7nE7Czbqtbx8gqZfoXUpY sr/ILwbejgd/O2qm/Mv1bjLyG774jFK4UUqfXR6K0GjRrHpvc+CpzLEVgMLTtF6WZ7mV l/5EjUI3yQpYZzTPDayMVXFQK5ADwfnXtqJX2+n7BJ3BoWNMJi4xsjL9UHi36YqtqVrA X0KIxAjr7Q3PO6ORixH/qST9OEV1r/gLQVxxCVpgQgkmOPz6td20RkF0W/7jrTHWVJ9e BGvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081840; x=1706686640; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oJnupBgFvOzDewfsN2fbqfoXAijS1cIjpRbgOobXJnE=; b=ibWx74LeGQA313R3FF2sCDdv1bRdTTQi3jc+eEwuGkQdibBLCddqp2H+9YeOvlR3Fj cOZJmJ1damOD2YJXZiO+PrFgXQs3it7aC3PCwUeSb35oBFTP4N8Bhh+3cLjrrZAk3fA+ RapokMqUiKctwKybQdkhykx7qE/I3fhojD+6qa4VUPNmvyqs2xf9d9XGisEGqQf4urad ArEBJvolblwWfJUWrPIqfa96XWnvhdalrmgQZkR4ETQg30hfti7arIuUAlZ6E9dAIktm Q+Nd24Xvx7h8ZYy3bOQGYjN89UoX4AVVvAseJ7kYgNfmEqUAOTIMfEQhmAFoO6g8/d1m ly8A== X-Gm-Message-State: AOJu0Ywwq6zpZuk+PWs0hSxQUiIZDZ1J/Oa5n9bc+O38maILiFX9ngSy 9fU+KZ+mJKvzjvIr+9SvBp5Bv2f3kpGjDnaZd4sOLx2TtqIC+eFbHR4t377WFQ== X-Google-Smtp-Source: AGHT+IFgsPWxZquxFDzz8I+/ShqqZin/JEW0/exyiv5vB1JusQRtCefw4n6e95w8cWZvyOJd08aWdQ== X-Received: by 2002:a17:903:8d0:b0:1d5:f255:d386 with SMTP id lk16-20020a17090308d000b001d5f255d386mr363745plb.11.1706081840194; Tue, 23 Jan 2024 23:37:20 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:19 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:35 +0530 Subject: [PATCH 07/14] phy: qcom: qmp-pcie: Add a comment to clarify the use of "aux and "phy_aux" clocks MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-7-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1589; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=SMDJRGbt8Jv9ABIlOfDcm2JYxpzZQjqrX46K5L5t/xk=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4Ey0uoNqHHYLtSpRKMWtRALxolVDEIjsBe1 zYzwB5mGOmJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BAAKCRBVnxHm/pHO 9WzXCACg8RokdsMoSt1cI+uOd7qIPPW8HvoqXvRdXwF/FVdYRM+4YTHK6EJJElspwuRhLnphsdy I/+Z8lnLaKfuPLCXoircyEnF9PPdsGKbcCCII0YGpCWaSmLIkvRddCBfZvXKsN9gaegvATDg9Pe xA7iGWN9VVDOmdVyOJdadAtul4vlv3KrUW8QdLJL0vCouWa/OJx9m6CwnZ5A+iUMXO7gmWvgCrj WQsUUQfmlRWqZAmEkT1p8XoYs7Fwo5a7T8LDXcKSdbbkQTHNI0FbpTPq9IDoWqkqv/hGznNtaVb BKEJ7RfVUA3wOjPqCq86Shm4jUiYP6nbnLRDjXzXLdFxdPKZ X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233721_088147_1FB3191C X-CRM114-Status: GOOD ( 10.55 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PCIe PHY hw on some SoCs require PCIE_PHY_AUX_CLK when the link enters L1SS state. Historically, DTs of those SoCs passed this clock as "aux" clock. But, SA8775P passed PCIE_PHY_AUX_CLK as "phy_aux" and PCIE_AUX_CLK as "aux" mistakenly as the latter is not needed at all. Even though the SA8775P DT got fixed, both of these clocks are kept here for backwards compatibility. So add a comment to make it clear. Signed-off-by: Manivannan Sadhasivam --- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c index 9a220cbd9615..044e3c5ba341 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -2328,7 +2328,15 @@ static inline void qphy_clrbits(void __iomem *base, u32 offset, u32 val) readl(base + offset); } -/* list of clocks required by phy */ +/* list of clocks required by phy + * + * PCIe PHY hw on some SoCs require PCIE_PHY_AUX_CLK when the link enters L1SS + * state. Historically, DTs of those SoCs passed this clock as "aux" clock. But, + * SA8775P passed PCIE_PHY_AUX_CLK as "phy_aux" and PCIE_AUX_CLK as "aux" + * mistakenly as the latter is not needed at all. Even though the SA8775P DT got + * fixed, both of these clocks are kept here for backwards compatibility. + */ + static const char * const qmp_pciephy_clk_l[] = { "aux", "cfg_ahb", "ref", "refgen", "rchng", "phy_aux", }; From patchwork Wed Jan 24 07:36:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528692 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4694C47422 for ; Wed, 24 Jan 2024 07:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YlVqtpfDSN7Kk7DJ1GH9lRDK7QGaVvgdXtJFzNzSdiA=; b=B8mMBrDPX9KBHZ xttnugxbxXRq9r1sFYkj5edyj18f1VT/F0JwxYMr6eGeCueVg+IpEDNtVIdO+liboL0W0WCiP2Sq3 cf2ZStkKyEBBGd6gvo1a/U4YwN3Rk6qXra1+XpPsauslpewR5NzDunAkfZMIC5wwrC03UZiMl59BU PvuLfKattWi7Arr8KtQAd3wHf2ZEJbkQfzpUctptxikdGq/Lzdda15O/iY4xvRKK5PxWU7/Iu9dDj cTPkTk+3zlwgKldZs9Wzl77k2T/rSKciV7e7rOGaXWkWN81kCy5TM3/8mgdH3vK4hu6WE4WAzmGcI MRe7LoR0TTJyNGSMZKow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpE-001sVS-0i; Wed, 24 Jan 2024 07:37:32 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpB-001sTd-0E for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:30 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1d51ba18e1bso46528685ad.0 for ; Tue, 23 Jan 2024 23:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081845; x=1706686645; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CXDDfi064rCtRThZJZGkVDjzRTpEFvKlRw59+OoT04Y=; b=rgKLLV8ZtastS4Jz1aqMeS1Hr5hu9wa/w9sSbFTNNBMyYlkbdkkorxmTmhIHH9y9sn SqarHUZe3c9UXu4YCFzc+m8KC12D/QUvYDvoI0QESY/KmLRYZWe/YNya9qwOn9Aux8TM l8VagOLBOLpNweFgosTtl7F+M8WfG1rr9NESw491rBw6PWfxqNUe77n5VQhdLsnNznR+ ntv7AXMAqlYYUznAdxJdA8BoHpDPCe9ZHQD5FQJ1oEp2oFgSE9a1+oSTiYRO7dGPzN5x EwLgDaUDQGQgffOqMZZ4dm6OAVDOQ4qt1v2fSHEb+zRWgVnxeTi4Vapy5WI8nqv1T8fG 1PTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081845; x=1706686645; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CXDDfi064rCtRThZJZGkVDjzRTpEFvKlRw59+OoT04Y=; b=tfP4Ck2cTYcLbXWVpT498itSU24+1kpXoooXeM+k/R6WDCtjUocDzz5b30e9ui9YVt ip/abfplnVaePR1jqlvd36kHTIb1dd8hHIizu8PhHtasZjDrep/7r17z+HVCK7w1G9l/ 41ljjtqz8jelFrDy0CJUKhfjLu9aqJb4tazWbXbEv2jhBQxd5hZdzSezP/PzU1kaiQgy 9Ep6UZEAUJYRGramscR5JD9iYelvyQwhP56PuYxv5uUq7J7Cmz7g/QXQeXXcE9p2e+jv oVBNtJaP66b0NYw06gGRBapmDSKhXX7UQuAB0N3h4ECAqsEkk3GjH2sYNkznSjTOybfL LD4A== X-Gm-Message-State: AOJu0YyEp4JwLKbFZvVMeFzHuIUHfLq8iHwIPN+vS5XmiNiF8hlOLUC7 eizCxnpaZPijG+JOPs8nX7BFCNOllC96fW/i5xE8ZsHrFFzkOXI353vh3s27zg== X-Google-Smtp-Source: AGHT+IF99KK54fuqFFMfmzqMybtJrANjExFeTmDyL1Qt8Q4Zi7bMzYpz82W5D68CZj4gDoCyRGD5yA== X-Received: by 2002:a17:903:1206:b0:1d7:5b9a:c121 with SMTP id l6-20020a170903120600b001d75b9ac121mr632265plh.20.1706081845404; Tue, 23 Jan 2024 23:37:25 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:25 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:36 +0530 Subject: [PATCH 08/14] arm64: dts: qcom: sc7280: Drop PCIE_AUX_CLK from pcie_phy node MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-8-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1245; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=xQGmJ609x5rY5WnQZu2UiuYBmCFSMa/qh9a8EVqrblk=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4E35ElitvKxvgn52B7cnJz0JUaxM9PnNc0A YZLT3RUs1+JATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BAAKCRBVnxHm/pHO 9WzEB/9AWVJHzHB6yiYRzLzH5QMJyCI3Uey/WEyC9zrlInlCFP8ttR0TRYGIqNPMtlsudajr4Gh RwpC8CAwS3A4Jf0oosP/6RXE1zNUfu2UjlcdqwOOxHs8AHMNKKM3toEfV0hFTdMklLboKyoEpgW sj2l+ax0lyo1k2+nMyO9dzjY/ydeqp96BnCqc+N/TRwcJ3md0oC/ZejQjOYqewn84720yaqyduf kstWJuleC/arnJeAq0oQL/W/vG4KnHN0bm+4Do+Ab2t+dKkViydZvkDALc8juNUZ0jUrVUJ5ndh KHNGEK7XglGMRE/SqBmQdOXjH9s7XvhAlHttDhKii90je4kW X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233729_111285_D6AB7A55 X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy node. This also warrants a new compatible as the clocks differ between SC7280 and SM8250. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 83b5b76ba179..00fa14777417 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -2238,15 +2238,13 @@ pcie1: pcie@1c08000 { }; pcie1_phy: phy@1c0e000 { - compatible = "qcom,sm8250-qmp-gen3x2-pcie-phy"; + compatible = "qcom,sc7280-qmp-pcie-phy"; reg = <0 0x01c0e000 0 0x1000>; - clocks = <&gcc GCC_PCIE_1_AUX_CLK>, - <&gcc GCC_PCIE_1_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_1_CFG_AHB_CLK>, <&gcc GCC_PCIE_CLKREF_EN>, <&gcc GCC_PCIE1_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_1_PIPE_CLK>; - clock-names = "aux", - "cfg_ahb", + clock-names = "cfg_ahb", "ref", "refgen", "pipe"; From patchwork Wed Jan 24 07:36:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528693 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D4B1C47422 for ; Wed, 24 Jan 2024 07:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n4jAGHF8zlXMKgPN16JCgMEJhUaRopjJ26V0glxAEIM=; b=JKITQPORkWy0xt 7iXrtr4YvWD5B9gUVNi35KFzrb/8eTUrfw97jWlv2TmZ7hcfNI7zymkqh9vaK26zXmS+o8FUH6B5Y 0RbpauOXR9xmPY41xGIi5zv5sBUmCJdggHBvzlYEuateW9LhjXKDz6XyoeKGZ34jOxbHrMmNXB5RH UYTyEAY1LhK0o6bC+1XCnMpKCpzmSGH+tWOdWOCI8H1pyVK8uXtDN01EP9Pd7725YUCZUux9HYShG voIKpihBn3RfKdP57BFKR6B+QD4QUHU4SJoqsqLoxfJBs+DojIzTKSkCfvjv369fo/xWhCg1kuAs4 3YI1rdpJ1fMtCDw//auA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpJ-001sWw-2C; Wed, 24 Jan 2024 07:37:37 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpH-001sUy-1b for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:36 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1d74dce86f7so24707725ad.2 for ; Tue, 23 Jan 2024 23:37:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081850; x=1706686650; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7tKk/gUA2vZt4YWRFyEnjgkAtVvTsiFIxZN8q5DEuUk=; b=GasEa2YYE68hGMQwjdZLd26vWDP/6vA2EYLYK5nfLNqrjwDZTWdjrNnJqUdiQGV/Ui T7ZnjtyiZ2xNGlVBBqOCNsq+tDb9eMNkvvK5cs8JRLlGX5pB7fyD4VHBFQ8yFHuMI9Qf IgYThHMG9OjJLNx5cZSz0Z8WeWmCXBoPb12OiqJ8UJOZqGxIF/Qj8b/pMtZVPvATivV1 KQ9uGIa6L9cJBZQgIQtSW1aY8Mxpu7Xb77T7NMtxscAHuVs5Mcl1qVs4m6RYPiAKLbnH 3r1o+DlXu9LBer5BuQg4yB57yK0Jq4xUY3haPYFenxaaV+enllFwQiLD2BmpETS/ku2G uEjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081850; x=1706686650; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7tKk/gUA2vZt4YWRFyEnjgkAtVvTsiFIxZN8q5DEuUk=; b=FM82tGjy7JS2wsJUaTKDfjVKXaMuRGMoBGyAYBpVSQ1pAcBHNyvb6g6+le1Q76SSRr LZ89BO1HPeaXlpmJYXfnYPCRCh28ZaiEC6/r0at0sllFM+/mUnaUA5lICgl2iMdcMaR5 +cFGIgfpvMklMQL6gY9iDnvemInFSEFxVvhM7CFbDbV6Z+hXEFQMk/CoFXnRQkps4Taq 5RsrxLPu5inLJeaJilRVdvChuoKyUOoxkEoN8lVPf/PRU0IBVdsyV+f/DaOBnvlea9Sz f+0HY4iVRudD0w6aEj7Uj71VaBLkIy4WsE/dGEHHxKkJGXZyxRRwV+OqocURAjYme4Hc VWJQ== X-Gm-Message-State: AOJu0YxLjxUavOmFFSPmtf+y8YtqHemUXjtZxg5qiCZUXmAEvLN8hbkE j0Wrjzqk6OuxJYnF1TvwWv3HgTaUj70xeg5T1G4vQNEv51BL+Wmdtf4zBLHocw== X-Google-Smtp-Source: AGHT+IE5gSR9S1hNumT5Gs9vRn/HrJ2yq2svOakpJLMn1E1SeeC1nBHi/YQbyiTo51gPSYVY5Nv8ug== X-Received: by 2002:a17:903:492:b0:1d3:d27f:77c9 with SMTP id jj18-20020a170903049200b001d3d27f77c9mr390645plb.14.1706081850722; Tue, 23 Jan 2024 23:37:30 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:30 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:37 +0530 Subject: [PATCH 09/14] arm64: dts: qcom: sc8280xp: Drop PCIE_AUX_CLK from pcie_phy nodes MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-9-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=3664; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=5NPwNoYz985HYek6uHJDI/5wY+uuiyXnKa4opvBCJj8=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4EVGO3TtV6DQzvJ/PExud2tothVXBlk9nJc KgeDCk+AGuJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BAAKCRBVnxHm/pHO 9ae/B/45By/VPGVbVxv8n0z7xSGfU/JGiMFrTjUS69Gmsob8PF7fxftlTWwZCLkrUgIuJRBzdkb ZkHzrSGbdR0j2Foxfp/j51A4pVzGBC45wverE1WOVAm7SXjE1RiAe+KFpN70Jnciy0gDs0voIsC I8h+my8LE3a9yTp9A2F0se8GWbdtNlTIXQLB3l5n1QNEohi+6AaJMXKXo2RAZ0T91aPbtOmcn9z tkxrffCFt8jriWYRyJB7Nw1aHfs7LoWB70dND9G+MqYRK9dMhufB9K7BXZgQniBJZ9xkoe29Tzt jJRaUqkSIdQFvvfxsXfrJN5i+O0TgUj8StTbu76AE2zXoRtv X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233735_533712_DFB3A6B5 X-CRM114-Status: UNSURE ( 8.11 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy nodes. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index febf28356ff8..cc33ef47d5a7 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1785,13 +1785,12 @@ pcie4_phy: phy@1c06000 { compatible = "qcom,sc8280xp-qmp-gen3x1-pcie-phy"; reg = <0x0 0x01c06000 0x0 0x2000>; - clocks = <&gcc GCC_PCIE_4_AUX_CLK>, - <&gcc GCC_PCIE_4_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_4_CFG_AHB_CLK>, <&gcc GCC_PCIE_4_CLKREF_CLK>, <&gcc GCC_PCIE4_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_4_PIPE_CLK>, <&gcc GCC_PCIE_4_PIPEDIV2_CLK>; - clock-names = "aux", "cfg_ahb", "ref", "rchng", + clock-names = "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; assigned-clocks = <&gcc GCC_PCIE4_PHY_RCHNG_CLK>; @@ -1883,13 +1882,12 @@ pcie3b_phy: phy@1c0e000 { compatible = "qcom,sc8280xp-qmp-gen3x2-pcie-phy"; reg = <0x0 0x01c0e000 0x0 0x2000>; - clocks = <&gcc GCC_PCIE_3B_AUX_CLK>, - <&gcc GCC_PCIE_3B_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_3B_CFG_AHB_CLK>, <&gcc GCC_PCIE_3A3B_CLKREF_CLK>, <&gcc GCC_PCIE3B_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_3B_PIPE_CLK>, <&gcc GCC_PCIE_3B_PIPEDIV2_CLK>; - clock-names = "aux", "cfg_ahb", "ref", "rchng", + clock-names = "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; assigned-clocks = <&gcc GCC_PCIE3B_PHY_RCHNG_CLK>; @@ -1982,13 +1980,12 @@ pcie3a_phy: phy@1c14000 { reg = <0x0 0x01c14000 0x0 0x2000>, <0x0 0x01c16000 0x0 0x2000>; - clocks = <&gcc GCC_PCIE_3A_AUX_CLK>, - <&gcc GCC_PCIE_3A_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_3A_CFG_AHB_CLK>, <&gcc GCC_PCIE_3A3B_CLKREF_CLK>, <&gcc GCC_PCIE3A_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_3A_PIPE_CLK>, <&gcc GCC_PCIE_3A_PIPEDIV2_CLK>; - clock-names = "aux", "cfg_ahb", "ref", "rchng", + clock-names = "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; assigned-clocks = <&gcc GCC_PCIE3A_PHY_RCHNG_CLK>; @@ -2082,13 +2079,12 @@ pcie2b_phy: phy@1c1e000 { compatible = "qcom,sc8280xp-qmp-gen3x2-pcie-phy"; reg = <0x0 0x01c1e000 0x0 0x2000>; - clocks = <&gcc GCC_PCIE_2B_AUX_CLK>, - <&gcc GCC_PCIE_2B_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_2B_CFG_AHB_CLK>, <&gcc GCC_PCIE_2A2B_CLKREF_CLK>, <&gcc GCC_PCIE2B_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_2B_PIPE_CLK>, <&gcc GCC_PCIE_2B_PIPEDIV2_CLK>; - clock-names = "aux", "cfg_ahb", "ref", "rchng", + clock-names = "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; assigned-clocks = <&gcc GCC_PCIE2B_PHY_RCHNG_CLK>; @@ -2181,13 +2177,12 @@ pcie2a_phy: phy@1c24000 { reg = <0x0 0x01c24000 0x0 0x2000>, <0x0 0x01c26000 0x0 0x2000>; - clocks = <&gcc GCC_PCIE_2A_AUX_CLK>, - <&gcc GCC_PCIE_2A_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_2A_CFG_AHB_CLK>, <&gcc GCC_PCIE_2A2B_CLKREF_CLK>, <&gcc GCC_PCIE2A_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_2A_PIPE_CLK>, <&gcc GCC_PCIE_2A_PIPEDIV2_CLK>; - clock-names = "aux", "cfg_ahb", "ref", "rchng", + clock-names = "cfg_ahb", "ref", "rchng", "pipe", "pipediv2"; assigned-clocks = <&gcc GCC_PCIE2A_PHY_RCHNG_CLK>; From patchwork Wed Jan 24 07:36:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528694 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70FE7C47422 for ; Wed, 24 Jan 2024 07:37:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oiTOSM8t07kybbUPCQeSjza50ucFSgSutX4vACJnPiM=; b=ggOzdorXtKVBRC vy9tyUwicLx0BdZG++pbstpyblpoPATbN89iR3JzH0f2wtr+yeM9en3H1ahYHefzXwkg51z/v0zgw JXBEPaPQXCaajzyCjtb+70cjU2imGrjo3Ldp6rGFxPArLi8zWIgu+Ip549LPlEaNWxJyF/9X0P4XZ GfwO0061hhJHQcof5rjfb2p6ZOJ//JrqWNGrhdgIoVJ+2DU7eSNNVkslOPVqNZ5jQ+TL4WgxDHflc b3IrkfNqCWgsgBIFpInSozSJhZ3N6LLc1lFdY8MR45j1mJWdIMwJaC70q/xgwsBf8sk+hTXW6DCGX 8mOLUuYbUPLn/heFj2fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpM-001sXU-05; Wed, 24 Jan 2024 07:37:40 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpJ-001sWh-2p for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:39 +0000 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1d70a98c189so30094555ad.1 for ; Tue, 23 Jan 2024 23:37:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081856; x=1706686656; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l7zLlm6d5CA8X7mFvOVBpegHqSNqfCtqpbevUvsC+dc=; b=IB20K0pGJMkITj8ZuE/XuUGwIunpKMKIqGK61zsF1RMB/5vRQj/py18KUyUOFwO3aZ 1tpICIsDhv/gp7sRNkO/h8zBgjS7NL5yb2yCzKTYiUr4ZzWNgOgLKaf+nBKxIGccMIvp 83go1XRy8KFztOxkoi394euGz/eQM4wqAlyVraVwPzZRpsmOXiRpCLklL169Bz8I4fHq pr9iuDz6P2rSLLX8+IFyNBmZKw0kAmsFBYdSc+nCoKb/68B3E6jhFOTCtddJQrjLwmBc 0QNthU+0QYGeA+vDbKq+tCpe3q3DpC4eUJq9aWns7Na9aoV3d8DdW5MMZhjaKz/M4wtV oZIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081856; x=1706686656; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l7zLlm6d5CA8X7mFvOVBpegHqSNqfCtqpbevUvsC+dc=; b=LnJqw1TZwHJm1o5PC+82oMxEjuUudXwwUgFUIgRpyo7C5dv8h3eND8n2CNMybzvfWA MUqJCmkzcx3GZR6HrLwCvd7QjhucTb7O+6+vlmAYYzItD1NcpWxn7rM0h3jBarcBylYE wFhkXWvAg6Bb2ph5LaLgB3bBNqXXdnlAMi42rhfQv4AVbRhZtMXv+CJJyXA9QM3uez6t mM97dFiIsnh2hxMs/on6kfpZxpqSPmurtaYh4niL4IWs6BIuNqQ0OMZKCcIo6aKsBzSx 3f2uCM6pIyjqoVrSKWlgwYXdufFme8aCxgmTpZm2n5WZi8Umj+4cTLliY4MRKTK6xZR2 RYLg== X-Gm-Message-State: AOJu0YxLZfxuiiDOQmToNVnIX9xiG6U98BMx2jgDRxIfZvKKXKcEGOm9 oxgZPRTdRqo2LYCu7PiwGUhbDKdv8nLIe/toFtWKOPW+JHCKebeHcZTWM1ld+w== X-Google-Smtp-Source: AGHT+IHlsAL4NqkYacbzZuLMy3cYbkj5DCyJUwh+SajhTTNjeDpitNlfwHG4VfJa42WgZplyNBAqSw== X-Received: by 2002:a17:903:11cc:b0:1d7:46a2:9383 with SMTP id q12-20020a17090311cc00b001d746a29383mr326721plh.33.1706081856061; Tue, 23 Jan 2024 23:37:36 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:35 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:38 +0530 Subject: [PATCH 10/14] arm64: dts: qcom: sm8350: Drop PCIE_AUX_CLK from pcie_phy nodes MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-10-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1736; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=49EHGJo+BF0aAusaw6YV9QxMus+FF03TSQS/+RfWzT8=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4EBMA0JPQ+taWm5D5iCJHV6WyXEqHPIoZZD U6GiyBn8wSJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BAAKCRBVnxHm/pHO 9Tf9B/wNcnSzONZ35yT0CY2kXhWYHcTu/lh+g6/zyMICDLDyuUoIMb84lVoC1rzB15CMmHG5HYL uc14OFvnZFRmLblaowYZ/f5Gc/MX1XdfLaBrkYtj5V4xNaBjlT3cOdSRxXbtW8dda2fkIz2CJ48 CcESQ81hAKgTLVk0h4dD0nAy/7E32DB/JFTlLbbe6CcTCpY4lBw/o3JSZuA+5xqXgJMGl2SkwM8 1IJb0QfcO1jIR2kcVwtinNom162H83LDvSZhcvgCf0WQlH802OzK6Mv+nDTLUUEPlvNrMRgul5z VFa01hCGZD73rM3RkRBHO3v8SvvcXVIl/u4NTdYV5umIymGM X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233737_914288_01FEA503 X-CRM114-Status: UNSURE ( 9.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy nodes. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index e78c83a897c2..23a9060f21d9 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1571,12 +1571,11 @@ pcie0: pcie@1c00000 { pcie0_phy: phy@1c06000 { compatible = "qcom,sm8350-qmp-gen3x1-pcie-phy"; reg = <0 0x01c06000 0 0x2000>; - clocks = <&gcc GCC_PCIE_0_AUX_CLK>, - <&gcc GCC_PCIE_0_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_0_CFG_AHB_CLK>, <&gcc GCC_PCIE_0_CLKREF_EN>, <&gcc GCC_PCIE0_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_0_PIPE_CLK>; - clock-names = "aux", "cfg_ahb", "ref", "rchng", "pipe"; + clock-names = "cfg_ahb", "ref", "rchng", "pipe"; resets = <&gcc GCC_PCIE_0_PHY_BCR>; reset-names = "phy"; @@ -1654,12 +1653,11 @@ pcie1: pcie@1c08000 { pcie1_phy: phy@1c0e000 { compatible = "qcom,sm8350-qmp-gen3x2-pcie-phy"; reg = <0 0x01c0e000 0 0x2000>; - clocks = <&gcc GCC_PCIE_1_AUX_CLK>, - <&gcc GCC_PCIE_1_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_1_CFG_AHB_CLK>, <&gcc GCC_PCIE_1_CLKREF_EN>, <&gcc GCC_PCIE1_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_1_PIPE_CLK>; - clock-names = "aux", "cfg_ahb", "ref", "rchng", "pipe"; + clock-names = "cfg_ahb", "ref", "rchng", "pipe"; resets = <&gcc GCC_PCIE_1_PHY_BCR>; reset-names = "phy"; From patchwork Wed Jan 24 07:36:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5290C47422 for ; Wed, 24 Jan 2024 07:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yg52AsTytXDe23rpwuZGXIzUFXwz4fnzONp2RTR5y9Y=; b=CaAc85rCDkIHy+ w8x9TYEjm21CaTKRk/730jlJjUCJ2rMEO+S3XLSZrmSni1H8WCDphMqibHGEFoYQfMtKqn6OkIEpO 6H/29dOqt5BIZIMBymZPsisHAhIolqoMe/9FaQTwxFXC8Z+6j5vcBbCAjL0Vpq4s/Ac7Muje54Gya NqHkVtBKr3XlIRba48n6mgY10XO/OMWNd4tK3JhWJzfbzQRQL4wdcU3PrHyVeg9ihdxzK9/uRvkpu YH2hsVg/qSZulWjsay1Gj4X7hdYbKla/eT1yBLjLMxelKulRoPEx5KJeysZuu0i2s8k6Ri1BBZ8dB Zx3ameTzCk4RSgCn3kzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpQ-001sYk-1M; Wed, 24 Jan 2024 07:37:44 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpN-001sYB-2I for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:42 +0000 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1d6ff29293dso34332205ad.0 for ; Tue, 23 Jan 2024 23:37:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081861; x=1706686661; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iKf4wr/PhU8C8jJcjTd70SR5SaHAZ16yhIfEOdFxtCU=; b=GYyhKhNDV+tye+kWnsC2tMOBh+TOp40ETfeb911LKzwEZzEjBfrNQceIL+8ELEliuw mivwUCfLOmO6k6Hypz3Jh7Y/qnGXk6f+j29OVQsnRKl1O+NYpoVjxFNCF5m3LFBNkJL/ 9anldNPxAUbnGJwx+FUXdjWLQOi5prUYqFKuJa5bGzyW+x3T6V3BA5zwRlQsa05Yoqiw KeXPGBlgPF+xAbu1RYPQMSEx5ny+r5kAGGWNKoKRUbU/F2CnveGu8aLgkN1Jsobc+RbH RpjOZdtyg6+uf9OKTcTzj6XSd6cUP1EanWxKl4dUEh9248sM5lnu2t31aUx9GsOyRjq5 ow2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081861; x=1706686661; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iKf4wr/PhU8C8jJcjTd70SR5SaHAZ16yhIfEOdFxtCU=; b=CuPcmy8JaKcAMW1DYMdF7LDFMsa9JqPEWWuZ3Lsl+B2icWZ5p6Xwo5kg574fQKxZa7 Hh/e8wRIlJstWuxU42QRwat4jy8/ISgP9a9IHavzs5mRhGuJkxKSeW3cLrsDk+bcB0ek Kv0n0A61TMljuVfSOmsxgPTnN00lAk0LZvA+70lu6rxyukxv3VYG16Vz9+E+L/A59OwB owTBnEbKBOvcPASe1DR3EUr3k1pApSfvkWhaoHtYq6QJsK96G2HfJv3UGu7QyMY98sZW DOvyKxj/xxFJNzVczGUke0DIDOCpiU55Fwr3Xu8d8JlRADD9Ak9Gtj+wc2mryxM2St/W rCCA== X-Gm-Message-State: AOJu0YzH7Ztsx+jlOPVmKYX2U422OMrSP+7jEAzHxQuvngBiv4UkPkmA OJBpveWK/iWYL4aUNcgnr4b16sZSl7P5Pvjo9tzp0d2md+2mCUUZojkCLCDGXw== X-Google-Smtp-Source: AGHT+IFzkjDdfXVH1eFhiSZ/tTh3VQLR3Zc4fY3VVxilv+uGwzMM7MRyx1ANpgPtt9PStovNzoxI6A== X-Received: by 2002:a17:902:d34c:b0:1d7:17ce:cc5b with SMTP id l12-20020a170902d34c00b001d717cecc5bmr300844plk.133.1706081861253; Tue, 23 Jan 2024 23:37:41 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:40 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:39 +0530 Subject: [PATCH 11/14] arm64: dts: qcom: sm8450: Drop PCIE_AUX_CLK from pcie_phy node MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-11-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1078; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=q4REQuD/EeSNLvb14a6jAbCKy8un8bWTNayXDrd2sPM=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4FuIFWugJBxWD5/8i6mcSozobTq0w7ntmVL VXJIpEnfTKJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BQAKCRBVnxHm/pHO 9QAsB/9WNzb2oQg0/MVu/Ww+cCD6j6lVrfmW+ehkb9jNlHHSOJbLRlu3JI1T39wTq26klASZlbZ +7h2sNu4y+h4T1zNFyxE+sqhAXkOkO4E0wiLMcFaDg2Hh2YOnAC2wMe5ieylobU/Oy33OuJCMTE GqSttxJ8dfRJjr8Ks9tH8r02I5kPEGjwHaOg8d3YzlddoOyM8ywBOFiTMHNcqNj6nk+J8FylhvB lY96HKZx28DIjqFR8z1vQ2ft8VlwJgjXfK/u2ckDV7GYilXZM9PCSY6Jn2b1tpeVsr8HJR1RGuH uCMB1vw4LnwteK6iPQABiiocCqFgYw6wNNC9cZ0mPbTgubXw X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233741_755063_729149FA X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy node. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 01e4dfc4babd..1e0091dabaf1 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -1830,13 +1830,11 @@ pcie0_phy: phy@1c06000 { compatible = "qcom,sm8450-qmp-gen3x1-pcie-phy"; reg = <0 0x01c06000 0 0x2000>; - clocks = <&gcc GCC_PCIE_0_AUX_CLK>, - <&gcc GCC_PCIE_0_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_0_CFG_AHB_CLK>, <&gcc GCC_PCIE_0_CLKREF_EN>, <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_0_PIPE_CLK>; - clock-names = "aux", - "cfg_ahb", + clock-names = "cfg_ahb", "ref", "rchng", "pipe"; From patchwork Wed Jan 24 07:36:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528696 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46DF5C47422 for ; Wed, 24 Jan 2024 07:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gWV2IOr0CXfAsaVWE+rDIDCm3oE0Z8YTrY2OoTYouBk=; b=QySd3Q3krxA21C kesx5V5JRqGSB7AP7XSx4fpqrkluJnRFwsnB6H0RpayfLtltYU46jSrSVZcPZxtaP3gxiKYAF/pMo Zbwo7etFWkmSixpZSEByb9qqok5OeoXWIsLiK7GpI8QU7eef6v48bsPykL1XTa/3dsriyr8fPFL/x aczy0iOANsBrL6n2peXvEIyLTGHPqbQRi0AN0aibsIxSeMA5kKpSEg+K9YzThbnsKduhRJmsxc6fH n9+PkCL8wWqqR4zyWTFjCSwtybGXprI5qBnQveE82o0Nz+IZT4EMqOS4S72TRBwVsFbI3+lRV7ULV +ACueQCTorR1UX4iaaLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpU-001saa-2k; Wed, 24 Jan 2024 07:37:48 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpT-001sZi-0C for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:48 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1d73066880eso30743685ad.3 for ; Tue, 23 Jan 2024 23:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081866; x=1706686666; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Mr0QFQLGsGU3UCE22ZWg0GRl1d55JhYRsXZlu7CT5Ek=; b=e1RduZ+ZMvww6AyNyIU/SORIzypQN04L9mSycSCLgzYaVJ4VqY46emfKskyCHTqnke PGa/M9p1DdDum2AH8Rj0fOYXh1gObzqJQx+FJGV4vYm55HPNZjLs2eJLpLDxPanFLumm +lufctRtJUXy4obbKrP1Ek5449wVD0uxgpfYeB1cB40RA023C6owW5vQRyMgUv9unJTn aq5nuI54oyogbiv2+xK6swYGe70GKSncyre1L9dhRge2UBcLUNOg731gCMuOvPvDaVy/ JbnL0sL2Wcl0SPIHa0H668A73WU/dr+i+ebwb5/5ShCCewiAJ3KFnFRS9DRXxQWpgeT4 JmgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081866; x=1706686666; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mr0QFQLGsGU3UCE22ZWg0GRl1d55JhYRsXZlu7CT5Ek=; b=hB3yQLFwe68BbmSeuOuVdhW5Wu0QfA7zGcj1+pNRKZh1QqvAvgE6oMh7daieQPILFI bVQW4LQnU/7HD5twgOXyRDYWq5/VT2egsl3qzYpmgfT1VjITDWrUrfRPC/o4H7LtPH42 qOAB/6kM8epoil2lUHCYW5/hpFMYSm5a74X7XMF1No7Fd4F88eB6YX1Jxw4aYwaeuRzy IpSrlWDE0p7D5X+5U5HdEANE0Hvdv3Wt6myTLVWFaWyYpL6bKFXDUfali0FgvQ9xkSEA GoLg++eDfCOVDN4K47JA3aTtpll1K55x9geNadMqM0HgrStaz2K2RY/0x+dsyP/wmHZW UjXw== X-Gm-Message-State: AOJu0Yx8iIyLJfQ9B5HpLbB0wAf8SCgZeG/J17foTgf/HbTPj4u0+M7S T/VsTIeJI24Gxhs1o7nIWYjH7+nlrvltHahI+XYK533/8rNAW+wiXsRJl+tTMw== X-Google-Smtp-Source: AGHT+IEemWCxH9v5TmBpKga6APSBH20NfGHRPu+nLdozyRscwokzFFdRSMk/PTPGdmr44O68Z+RdUw== X-Received: by 2002:a17:902:a616:b0:1d0:6ffe:a1a with SMTP id u22-20020a170902a61600b001d06ffe0a1amr440390plq.120.1706081866524; Tue, 23 Jan 2024 23:37:46 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:46 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:40 +0530 Subject: [PATCH 12/14] arm64: dts: qcom: sm8550: Drop PCIE_AUX_CLK from pcie_phy node MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-12-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1138; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=qbS3T4RFVlJivCmN4hJ4Xsqqhf8ddqNIBdThgGXkGnY=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4FTWuUoQIXeVx6vSsYrfv+1E10lScR+ZHtL eUWXb94QZmJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BQAKCRBVnxHm/pHO 9dc8B/98bZbvZy8V9hBe0ncd/s65E4uiIGidQTmD+Dz0V9tH1ytXtu/tD2tpMNqK+QTIAJJq59X 3cuKmhgSQDgXiiz98Shz+xCq8TjmqYMNfyjopeq7+mHoGbS3y54BhY8pW7V+cpQmzMDJ/UcZNMp X1+8h+POmcY90EJ38NkAv16uOlwkv1dNyv/SpsV1vBSuc2OQ0tZhf2HGq7ukHPlPspq+0YO5ibA ABdoRog+r63cOF0yzw9CvkVacAQNkPK9y4qOhgNjk2AtcHR1Lt3K28V07t0RiIqWQK1X/kf9xvw T835vebbz9UYnVxLEPB23lI58DzhZjWFzE50unZQ6Wmdhubs X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233747_098036_E827880B X-CRM114-Status: UNSURE ( 8.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy node. Signed-off-by: Manivannan Sadhasivam Tested-by: Neil Armstrong # on SM8550-HDK --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index ee1ba5a8c8fc..f074683f7940 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -1760,13 +1760,11 @@ pcie0_phy: phy@1c06000 { compatible = "qcom,sm8550-qmp-gen3x2-pcie-phy"; reg = <0 0x01c06000 0 0x2000>; - clocks = <&gcc GCC_PCIE_0_AUX_CLK>, - <&gcc GCC_PCIE_0_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_0_CFG_AHB_CLK>, <&tcsr TCSR_PCIE_0_CLKREF_EN>, <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_0_PIPE_CLK>; - clock-names = "aux", "cfg_ahb", "ref", "rchng", - "pipe"; + clock-names = "cfg_ahb", "ref", "rchng", "pipe"; resets = <&gcc GCC_PCIE_0_PHY_BCR>; reset-names = "phy"; From patchwork Wed Jan 24 07:36:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528697 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC151C47422 for ; Wed, 24 Jan 2024 07:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M2Q0mmFr7eazau6GAk+yew2LepfHvFIgmj8pfvgQi2Q=; b=hdF5IydGdEdVTK rxjhl2YdZaBnZS311ybQFIxu5bwKfM8xOvB8nHN3O/f49isUF55ewgJVGZvYujcrXt2K0z+XvN3gk UrruzU0RHpuDeNkbbxbT2Np1arNr3yGlUnYci+hjgVkrY2weXJL8+qi2m2Xl/sm5nGMeXNEvNV1se fDmRjAT1pS0rnps4v33IieSqcWW71fz+Y4PxSzhQfi3+RBaZdtJoWLQVNxkcXVPjsG5JhY9ngG6ok c/8qzOcIlzaDM332IsDnywtm+TqQLLRWcr+WPSJ8RPwx+EqdzJov93Y6TT5sxjOjzh50F8OLP6uoy hO/CI4BwnsHsWRhn4S6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpb-001scI-0y; Wed, 24 Jan 2024 07:37:55 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpY-001sbg-0s for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:53 +0000 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1d70a986c4aso22723255ad.2 for ; Tue, 23 Jan 2024 23:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081871; x=1706686671; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=x/+eeHXYW9j18ErdmeKAUblHZYPts3oUBFN9HRjn0+o=; b=AgXFUzNAdkBn+6csOZeK9hLamVKL5DIj2gIrL2So8NS1GiDtQ2pPGgdi+yBM33sKSe X79xRZdokMaf60r/iaijzKQyOPTU7iyw52kCo+NzIaBCEDk4/bgdhCjddT8hFQEchihH uw6xLwkpzeszXGYRiqHI2PjxJSFnpuPqxl4fdJ968SjyyP+zQXW/NS/8t8QifU4Lj6nH P1mzwKWx8TnWX48J32IWcP8FEG+mNsi2cOsqjebswhByJySJmn7l1gefceYxdVMEeR0R OAFgLx6ACIyTSlwXqPaC6te1q2lWWxmdC0Krf5iQNTksF1Vlw0PplZYBH1+UBKoyV8N5 6ZXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081871; x=1706686671; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x/+eeHXYW9j18ErdmeKAUblHZYPts3oUBFN9HRjn0+o=; b=R3YT+7DAVRjHdC8goTeVcjoAyiouMCYUD25cOASAXFd+JGndNtC4jHJDt8EVit5t41 BcCBuaUFlt2CfMGCpDIAPKBO5bnQQYLfNKaCKMdW6CKKuuGhgos8Rj4UAgGYfYTb5cYq LAA5SZvokxZhNHPxfVNNFHdWiB6fRmkua4c+KlO8/S6IYVz3YyS4FTEhNrLccLYsyxqs XV2tmpY30YMOQrL+X+qNbf7ndf+tj8yEVfXIUTJIZDkGWsY2yiFpaTRyMDy4VLqSuP4V XVtPcO7nn5eV34FTPtjlc88BW7KkLOi8xOUooXBNHNAWyJktglzU1D/GV5cS2pXjMHpr jeFg== X-Gm-Message-State: AOJu0Yzxm3TOyA2TtPPybh3pKeuch0Ym0xSOJISnu3NVftohcuA7cvKE QCeaXUyYmwMKjEVxd83sdHAfGBFJ4qT9fRZiyI/XNbsNSyp80s33BAW7vAsoEA== X-Google-Smtp-Source: AGHT+IGj8U0OzY/bykwYZTLT4LfvcdMXaEwp0Y2P7Vpl0XFVBweFCBMR4mKw+7UkPyjrZCQ91xNUoA== X-Received: by 2002:a17:902:f687:b0:1d7:4c1a:2058 with SMTP id l7-20020a170902f68700b001d74c1a2058mr253915plg.105.1706081871600; Tue, 23 Jan 2024 23:37:51 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:51 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:41 +0530 Subject: [PATCH 13/14] arm64: dts: qcom: sm8650: Drop PCIE_AUX_CLK from pcie_phy node MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-13-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1080; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=xR8wvtP+QITH8T8kLA9WFdRX9QC0BEnzA8VfMLDLOeM=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4F9I2jnHfAODN1h6LhID1P5M4ffX5SDTNOK tmbdlVDGn2JATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BQAKCRBVnxHm/pHO 9e9HB/9IOUcSo3ViZRQJMCk/7G0FlXlhNFCiC5rUFKMDKuWujGHro13gDGJjTczje/BKnWxULGQ xvxbYT108gLh5mEcp90g5HVfToMp1AArsS3Fqnai8z0TkKnd+2dfxOFFow35x16YJnZmlE502Ae gw/DKa8Yi3+H7Pogj6id8NcfMHlRwkwwzBE6psr1YYv4uIIdIlKAqJvtav8irLGgRCHnD+IfL2L wYgrv/PZB13YCBXxVS2lSTYEgTY9HHM2SpVutjUixxncsHPi+v+Ic0I6Wu5T8Y+f2yaBax3w9Ll E80RfnrBnVFBA/a+DyEiXU1+AXBZ1W0D07uUrZBUR2iYa8GH X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233752_309200_0D942873 X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy node. Signed-off-by: Manivannan Sadhasivam Tested-by: Neil Armstrong # on SM8650-QRD --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index 2df77123a8c7..b31e60599891 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -2276,13 +2276,11 @@ pcie0_phy: phy@1c06000 { compatible = "qcom,sm8650-qmp-gen3x2-pcie-phy"; reg = <0 0x01c06000 0 0x2000>; - clocks = <&gcc GCC_PCIE_0_AUX_CLK>, - <&gcc GCC_PCIE_0_CFG_AHB_CLK>, + clocks = <&gcc GCC_PCIE_0_CFG_AHB_CLK>, <&tcsr TCSR_PCIE_0_CLKREF_EN>, <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_0_PIPE_CLK>; - clock-names = "aux", - "cfg_ahb", + clock-names = "cfg_ahb", "ref", "rchng", "pipe"; From patchwork Wed Jan 24 07:36:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 13528698 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36012C47422 for ; Wed, 24 Jan 2024 07:38:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YCbKCaTEPNmScfM11Y9oKyaZb3u715SbiVghiU7xU6U=; b=XWJZqvYEQruTeG JEW17hsA5hRbAVMw2WCkRv1xGNl3NgkugLbB212/roqA7h5PSHsO5JaSfvq8A5ClPLEDZ3JSsZwj0 XsZg13xzvLu14Li2MT1glDb0HW5yFRusA/oDmaKEsFjGbhwS52ZyzlGu36FSpC11cMra+X3dSixhf q75LV36vi4n+jR/xuP6zOAgkix02QiM+uJv7Ux4XAqMyo8ZqynlIkMncyqQ70AVS2wL7sX5QPXKno cuQQvztZDlfhHy7sQn9mRbpIoosSvi57fveTW/PtGaUoFCJaZu10I2eOwJCm1oUJ4h1iIybWn6iXq aH2qKUtIWDvy3Vt5EJDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpg-001sdS-2V; Wed, 24 Jan 2024 07:38:00 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSXpd-001scd-1e for linux-phy@lists.infradead.org; Wed, 24 Jan 2024 07:37:58 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1d7232dcb3eso23411245ad.2 for ; Tue, 23 Jan 2024 23:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706081877; x=1706686677; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DJs+PMBAGDBvXkVQNcVnd/NTo5VAtnKOcQ/VzO4TVvE=; b=eez2ef9GWUDXoM5CjcRJpmZC4IbxbkpK09bkVaGFE+SV8wvtYD8vkXpNjXeijNMOwi GCfSk6PhHH007DERwC/H+TtT3p/C6uEqPpbfBiZMkDTn62CRPKvenHo3RjoOeUVEH5f+ k8s882iWN9f/+WCleEbK4eQ2AZI67cg/gx7m2yNU33mlHFBNhVZXxiA5RPdtQcOnvJno bTcRZ3Y6Rg8ulHDh2zU5CvGK5uZQSxst9YXNAMoZyuNpjGtsA6wE2zAu3Lg1vwXtAsEP T53lkq5HmzkdPZpgK/fL/at1bNoBw8Qbj6f7l3gjrkZCH2ZmgldSV/EHU3/ugsNRUbpT 19gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706081877; x=1706686677; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DJs+PMBAGDBvXkVQNcVnd/NTo5VAtnKOcQ/VzO4TVvE=; b=sY3nQvnJnHQSOHgGn3GhEFb3dJy7GU6uEbPVVidh/7MYdDLYU/4IRzgyIkAzTfM11t ehCTlV2BFcDQpUgYdgrkAra3n5xkmWdjaUBeJrc3+/DAhwAevzI8RIwCqir0aT47/Qyp 2gMf4DMQe/81J6/PKpJpIYp9SvCLj9KgVXVnguu6epQhFXAQ04mThgC6MgjlJ+o78Isk RTJFusXLKIDFppr2K+wolMaNfh2fWLgqQwnkzFS62IUPkJ9O638FOJf/LXoaZLFJ0Ayd Ed6ipy4rs6IeJ/JjrdAtZQPIHuhLfFE+cEisygDb7cMW1svc/zCnXMTsdtZ5kMgkuEyJ eliQ== X-Gm-Message-State: AOJu0YySSby/9HtPJuOaFMerudN7MOfdegkcu1MQyAmP+xVrSL79n+WO 2h5WAhVsicvpIK1iPoBkZPoNFwg9ChxnVV07C6sUcHXji8BUtrz7pn3Rui8KbQ== X-Google-Smtp-Source: AGHT+IEE2l1wj9BXbay2mDG16hgBi9RNBmfBy9y9+PIFIVWJ/aOh9+lHuObbBTLFHE3YbFHRDrktmQ== X-Received: by 2002:a17:902:728c:b0:1d7:199:cfb3 with SMTP id d12-20020a170902728c00b001d70199cfb3mr292163pll.70.1706081876913; Tue, 23 Jan 2024 23:37:56 -0800 (PST) Received: from [127.0.1.1] ([117.217.189.109]) by smtp.gmail.com with ESMTPSA id t3-20020a170902b20300b001d726d9f591sm7386982plr.196.2024.01.23.23.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 23:37:56 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 24 Jan 2024 13:06:42 +0530 Subject: [PATCH 14/14] arm64: dts: qcom: sa8775p: Drop PCIE_AUX_CLK from pcie_phy nodes MIME-Version: 1.0 Message-Id: <20240124-pcie-aux-clk-fix-v1-14-d8a4852b6ba6@linaro.org> References: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> In-Reply-To: <20240124-pcie-aux-clk-fix-v1-0-d8a4852b6ba6@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=2114; i=manivannan.sadhasivam@linaro.org; h=from:subject:message-id; bh=AV0AQVKEuKDRIth7QZV7qLd22LfBtighoMaozbvkXAg=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBlsL4Fhhiw+ROelMo4VRCj1+Kx7T9cS2AThYZkc DknKia3ul+JATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCZbC+BQAKCRBVnxHm/pHO 9bthCACRQjvyFRVJy3hTYxwCqypCA959YVl640Spi+/5TQUxSwUS5HOza3ZjI6ZCE6ZAV0awrPp Ma31wRRoKSgL0QcvLroRMpG1W5pN5E1/CJq/7joMoTGV0Gytn1w4fGIB6/kSXkiPqOPMbNMCVFF Ngelg4E2chxrplR8oOICcl/mKuhw922a3poiiA+oCWhEqfmYWYYtsF2apAswH19tebHdmBaK1SZ R6CuqE5X5TaD+C9YLOpC2/R0IwNZhXa5IF44UqN+Z2XWohLPbBrvLIpcPH81pLIQtrGgFaeeM8N gbnY/iNcmWsx9j3N5iilOXhEMCW5MWYCIzifzYfgmlKRHqBf X-Developer-Key: i=manivannan.sadhasivam@linaro.org; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_233757_546755_E8BAB689 X-CRM114-Status: UNSURE ( 9.11 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PCIe PHY hw doesn't require PCIE_AUX_CLK for functioning. This clock is only required by the PCIe controller. Hence drop it from pcie_phy nodes. While at it, let's also rename "phy_aux" clock to "aux" clock and move it to first entry to maintain uniformity with other SoCs. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index a7eaca33d326..b99626c52800 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -3590,16 +3590,15 @@ pcie0_phy: phy@1c04000 { compatible = "qcom,sa8775p-qmp-gen4x2-pcie-phy"; reg = <0x0 0x1c04000 0x0 0x2000>; - clocks = <&gcc GCC_PCIE_0_AUX_CLK>, + clocks = <&gcc GCC_PCIE_0_PHY_AUX_CLK>, <&gcc GCC_PCIE_0_CFG_AHB_CLK>, <&gcc GCC_PCIE_CLKREF_EN>, <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_0_PIPE_CLK>, - <&gcc GCC_PCIE_0_PIPEDIV2_CLK>, - <&gcc GCC_PCIE_0_PHY_AUX_CLK>; + <&gcc GCC_PCIE_0_PIPEDIV2_CLK>; clock-names = "aux", "cfg_ahb", "ref", "rchng", "pipe", - "pipediv2", "phy_aux"; + "pipediv2"; assigned-clocks = <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>; assigned-clock-rates = <100000000>; @@ -3690,16 +3689,15 @@ pcie1_phy: phy@1c14000 { compatible = "qcom,sa8775p-qmp-gen4x4-pcie-phy"; reg = <0x0 0x1c14000 0x0 0x4000>; - clocks = <&gcc GCC_PCIE_1_AUX_CLK>, + clocks = <&gcc GCC_PCIE_1_PHY_AUX_CLK>, <&gcc GCC_PCIE_1_CFG_AHB_CLK>, <&gcc GCC_PCIE_CLKREF_EN>, <&gcc GCC_PCIE_1_PHY_RCHNG_CLK>, <&gcc GCC_PCIE_1_PIPE_CLK>, - <&gcc GCC_PCIE_1_PIPEDIV2_CLK>, - <&gcc GCC_PCIE_1_PHY_AUX_CLK>; + <&gcc GCC_PCIE_1_PIPEDIV2_CLK>; clock-names = "aux", "cfg_ahb", "ref", "rchng", "pipe", - "pipediv2", "phy_aux"; + "pipediv2"; assigned-clocks = <&gcc GCC_PCIE_1_PHY_RCHNG_CLK>; assigned-clock-rates = <100000000>;