From patchwork Sat Jan 27 00:35:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13533846 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFF78C48285 for ; Sat, 27 Jan 2024 00:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h4Flvk4GqgnATT2GBzcwG0dDc92eAaC2wshXLT5kRu8=; b=zxA4AoqDmHB91W Yav0S50vW22IQNeNEEpWjk2cCeA1tRLjaxV51e+TIIhjzG8M9DPcodQyKK87R8ZoSlceN0g7f4RSx CMK/PoCXFjrvp25BbzO2+oiY2krzVKM53YwUBJjMP4vfMB5Zk6FEyVXLIRYjRRgBLGkJkVIzJGV1l lNAwOi9rjXGB8xlQTXSdR9mfQ1sLysb5i4YwI4jCMOuUOeznyeOZEPhMiNPdrcVsOBKMnzg1Qm3S5 O+6N1wrgRz+WeDqoYrRGHn6jBMSvN1izGj1/jCfjLqxLzsJ5ZX9H6zJcITUXgR+vQnvdKHvfdnc71 mi2M62rz013w1dWkJIDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWhA-00000005zDz-2fvv; Sat, 27 Jan 2024 00:37:16 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWh1-00000005zB5-2yi2 for linux-arm-kernel@lists.infradead.org; Sat, 27 Jan 2024 00:37:08 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40e86a9fc4bso17069385e9.2 for ; Fri, 26 Jan 2024 16:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315825; x=1706920625; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RTtyOoMvI5/Gh43pPNKlry47E9NXmSJ8tqA/H0tsxRY=; b=dhvloHFN2fi7vO/PDowIGRmYOqOHL3gZ7vm206c0mBC34I8VyYI++hLSyJ8EM7Fn5a WT41x2zVYAX59C+bESoYSDPN5q2p8A8uPSw4VCjDGBtYBdhV36NA8Z/qJhX9EzHlRro1 NSocc7yvEs+7wCmYlcxfYoLpo7vgruUJE831GAgxj1fsCZkV/549nsaKUMZG7y2tF/cf vK/RwAknmVlrf+2YRBs8zXUe2L0PJNi/3tXS0LSSWkFadCLRphHxd1AFb3IlIUARuGk7 MuP+Dp+eiKMWN/RLqAFq1c9uhBDLEPHrthwMsW1PnCu+SjZLuFO+v93vp5VvDUeY8v0z NEzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315825; x=1706920625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RTtyOoMvI5/Gh43pPNKlry47E9NXmSJ8tqA/H0tsxRY=; b=MfbK4mv7WVef+5xmA1vToDCCVUo/rlaK0Gxgx2+RjOLKulP+eo2m5oQ7YPiwmI5bWT 9tR6NKWTReWOXL46dRaSIPJLOWFtTrzv1j3fYHkSbUSoJW7Tystf5/ilTXEOUxWjVdtP 7HhbJpU7o8zUC2eIIdxNJiaLDKEBibjH1w8LbqpS+ofIoAPMFjWQqoJD1FvTTFJQfgWP kwbQztke8daQQJfvEY6aZdT2WI8Y7c2qS0JVkSDcdtnrrf6bW90NX6qPKZstkutkNhZg LTXWHcee+v5vK+an67tYtacNJsXfssABqjrFVH1KQyYvPwzuRd6fDFOSWzH7MGlOTNCG s6gQ== X-Gm-Message-State: AOJu0YyOCNyOr+75hNPtT1AXeq7s/xW+WM+1Ys0tylOVSFKjsmtvjcFJ TgchwvXb4dTBvZ2lPlvYzyOAB49Vx9LMxa+ddGdei0U2zlekQtwnmj6P9Ecxh34= X-Google-Smtp-Source: AGHT+IEqhBCkPxBNM5yN/bsGN5bmEvcY2rByUECx6W6OGKyFKLAR68SPfXkpZIRtnmsO6KTR1r2mtA== X-Received: by 2002:a05:600c:a03:b0:40e:b107:9e16 with SMTP id z3-20020a05600c0a0300b0040eb1079e16mr394989wmp.230.1706315825219; Fri, 26 Jan 2024 16:37:05 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:04 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 1/5] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on Date: Sat, 27 Jan 2024 00:35:50 +0000 Message-ID: <20240127003607.501086-2-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_163707_800527_E1578B63 X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This pclk clock is required any time we access the pinctrl registers of this block. Since pinctrl-samsung doesn't support a clock at the moment, we just keep the kernel from disabling it at boot, until we have an update for pinctrl-samsung to handle this required clock, at which point we'll be able to drop the flag again. Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Reviewed-by: Peter Griffin --- drivers/clk/samsung/clk-gs101.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c index 4a0520e825b6..61bb0dcf84ee 100644 --- a/drivers/clk/samsung/clk-gs101.c +++ b/drivers/clk/samsung/clk-gs101.c @@ -2848,7 +2848,7 @@ static const struct samsung_gate_clock peric0_gate_clks[] __initconst = { GATE(CLK_GOUT_PERIC0_GPIO_PERIC0_PCLK, "gout_peric0_gpio_peric0_pclk", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_GPIO_PERIC0_IPCLKPORT_PCLK, - 21, 0, 0), + 21, CLK_IGNORE_UNUSED, 0), /* Disabling this clock makes the system hang. Mark the clock as critical. */ GATE(CLK_GOUT_PERIC0_LHM_AXI_P_PERIC0_I_CLK, "gout_peric0_lhm_axi_p_peric0_i_clk", "mout_peric0_bus_user", From patchwork Sat Jan 27 00:35:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13533845 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17528C47422 for ; Sat, 27 Jan 2024 00:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/u6GW74Z2w9DJWUp1bro43V7w6puS+onuNYG6kCrrHo=; b=JCoQa2oqHPrBJI uldTsEDBbTbrmTK0ztJCksu11Zfh7TndlSXUgxHEfrW83Of0nnCvX5eLkALWVg8rB3/mpwlL959bt FfaC7O+TRAyOnqWoDVJ6k21OTibgMKLOgAh1x9UCn3JNFA9qNZKyf4Trv3WNVssQi9PGAu17Of52f 4i4KuSkoIYjAdNUQAhc+5dUjgFfshhppuQR38oJw1QRZwya8Sj5vQgHxBsJg21PAVa6/Ze9pxgZWk 03sMd/wExruu+G1b6x76rJk1o3uPhS3dBn64RGiJUiJSgMrCQ55sV3Xv9bNTJ9ojLoheovYP2B6ZV EWcQiFQ17Hm45S0p6vyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWhB-00000005zEX-1enO; Sat, 27 Jan 2024 00:37:17 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWh2-00000005zB6-0R5p for linux-arm-kernel@lists.infradead.org; Sat, 27 Jan 2024 00:37:09 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40e9101b5f9so15764655e9.3 for ; Fri, 26 Jan 2024 16:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315825; x=1706920625; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sm+b1B1zFt2eVB9+ThV9mqMVXPNNXKvJvmEo2SUwft8=; b=wQpH5vy2BLtpaTkZoDSJmIVAc7od4KZencjbhsvNrDFB4A3t0zyUXQUdT3LAvs6SYO lvq7xv5jIBK/HlziKeq5uKFUME+He/nLOxIu5vFB1Ue8SOj2bCz/B4eyrFCIVOFfVElM wQ1ciD3pDJRur9u3BUiwumDtO919elVPFiNe0N/V14kgWwG/v0Uxxzk/qO2l5q/sL5fx JsDvj5exoG1rwhQZzeB7dzkXWn7p/WMB+shIUdc/ayKv8U53O82yxiuBQAg0XDC0zpwM 2p+j9VLCyILXBjmjZOiZKiX0MLWPo8iE2VXYyWGmAOXhRT1T7qSE04HAXIlbMuavqXsr jmcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315825; x=1706920625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sm+b1B1zFt2eVB9+ThV9mqMVXPNNXKvJvmEo2SUwft8=; b=XtDcWhG/kZ2qeOeBZQFVuit/yOFc+M3fnCW/NWLjl+xtiWnvhnDgiRWedypVA+A+UQ bftNGadlR6GA9UmdR+Sjuj8HNS2YkD7JcU4S2IJIyVY3mx1hGpaROGwdPYPzdF79g5jg KdeV4BXI5f3axGU/49zjb0/v5IxscxgXcf4zs1fnkzBrnh4XoALROgLtYTFEYxWUerpn v9/bJKA4GAICTuQMF6WwFQ3jvJdOa8AQbilCyit6VToAFxcnOgZB6zZtSuRVvysHOySL MdWsD6E+EPgTXVumuercMM7P6SWTfGLIcv+St6m6GFC+wmcTa+B9y3g73QMhKuvmROKl i+iw== X-Gm-Message-State: AOJu0Yxt0UEc62whQlQmZ7HJsH+OPOrGhdBAjh+8xX1IVkv7B1QRNTPz E1KJ0IZwSa0hpbkaEUUrQAspuWO9sz5A4WZAywohTyQTbJLy3M8uj9EHr2IwXX4= X-Google-Smtp-Source: AGHT+IGeFh5Dj5LZw+UG+J/Z91OUe5JueC+Wd93apWSOWisW8wFE95eSjirZGUDRp0E34HcX4tKyGQ== X-Received: by 2002:a05:600c:5123:b0:40d:484e:935 with SMTP id o35-20020a05600c512300b0040d484e0935mr455010wms.12.1706315825706; Fri, 26 Jan 2024 16:37:05 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:05 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 2/5] arm64: dts: exynos: gs101: fix usi8 default mode Date: Sat, 27 Jan 2024 00:35:51 +0000 Message-ID: <20240127003607.501086-3-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_163708_173424_60E5B4B3 X-CRM114-Status: GOOD ( 11.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org While commit 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") states that the USI8 CONFIG is 0 at reset, the boot loader has configured it by the time Linux runs and it has a different value at this stage. Since we want board DTS files to explicitly select the mode, we should set it to none here so as to ensure things don't work by accident and to make it clear that board DTS actually need to set the mode based on the configuration. Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Reviewed-by: Peter Griffin --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index aaac04df5e65..bc251e565be6 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -384,6 +384,7 @@ usi8: usi@109700c0 { <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x101c>; + samsung,mode = ; status = "disabled"; hsi2c_8: i2c@10970000 { From patchwork Sat Jan 27 00:35:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13533844 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48F51C47DA9 for ; Sat, 27 Jan 2024 00:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KlYFNnoxJo884SLr9x1lhm/DByXKuqUkmEcQ8NT6RZc=; b=sjUhh8XmQBlM2o Wqg+05vYbqnRSj+WiRj64NqFZ6MpT/4BOa7e5BSbpDmWpqBTNS/ngeQ1bWJAmlSPcgV17Cpug/gau e4Cc1XoaJqlkCLWjwAQYekDKrSyTtt+UCILOrrPOu51oAr8S5JbvxUczNPMVnIQFqMklfa20ZQYrQ 6JkK0W1l0z7ytxxv0nb/xWmMK8LBr53O0cIXSOqzW8LKhljk8lLfSR9XOPJyQHQgDm8R5nXLxpkFd O/oh9eug1KDP+evpGtxs+JeGCqMzCXJ59+zu1cXbE/wKyZPZMBSRkN/190uwiliH3OFCnduRLPkIA gymO1+7Znb/W0kvoaukQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWh9-00000005zDg-3mgT; Sat, 27 Jan 2024 00:37:15 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWh1-00000005zBI-1wv3 for linux-arm-kernel@lists.infradead.org; Sat, 27 Jan 2024 00:37:08 +0000 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a3122b70439so132569466b.3 for ; Fri, 26 Jan 2024 16:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315826; x=1706920626; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FJ73thBf2vHveKg87OgpLBqSvGw1l2TtG/ztHfLjlvM=; b=crziiSMVKP7VSN5MTrYCgb70iApYxc7HANpwGxLkkqw5ON1YpdBnetM2AYnXWvelRC prBCH1vatKWPCvu4J/iBtfq5lqobklVTXQHTI1bIlC8wtYrNw3Gtr59DvdzfSZjuOrZG 5FNRYRQS9yQApVF5gzRdiBCtii39TMDt/irn5iptHjpkqgRjJWJn8kPrei2gTv19qrnt 0yHiTiGgdiMLrJOMu3GhwPc69QRN7Oj1+g9/Wn7StHSuw9i4t8IX2h7sBpohrvHCYpw6 5lR+VV9CNFTEs1LpGBDNFVwjVNz7p/ZmZm+sZz+geYXEmUaB+gTaLIptUQKc/2rnh6yo Xo0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315826; x=1706920626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FJ73thBf2vHveKg87OgpLBqSvGw1l2TtG/ztHfLjlvM=; b=oSficnC8mrQBjTbbf4IIQViZbKsSM2eLZkJu6VCVZvLn99vEvvQCzb4abhIRQTGkk2 BsPfVamxsz+sVnVUUhC2LavGo4Irmu/CQFLMK/ai3pSBxXIIezAcRo4oT3eJGyRoqVYJ FS7X5td9ny15uiqHKlIH3ooYevNBJfYoGA8e8VVR2q75ARUIPydlNdWIetn78lTxeXlM +Yar7b27lcohxMyAj48pQeOVLkZO19AlAoqEns2dg1LeuqJi1Cmjo8svv5y8jBJ0ta38 GlJ96TDfLtZf7caNb+9RJ+4SceGZLGiNc7YChDavYevKthMI6Y8/ds1pOY7L0DMDsJ8i gkeQ== X-Gm-Message-State: AOJu0YztEu3SOIE2xcIiPQ6OD0DtVQ0MZw0MoXf70lRyPzwnBJhzxu0H a1yMBOHaBPkZl4PS5TqMkX2+97vpoCFvIMaf4ckd76g31UxJWhB5ByivPbCeJ4E= X-Google-Smtp-Source: AGHT+IF62xxAOQKXenjs9SveeU52YIbIa7O0bn1bom9ZOgfi70BpL/1L08c0EOj83Fz3C5giIBjR4w== X-Received: by 2002:a17:906:8308:b0:a31:3745:33fb with SMTP id j8-20020a170906830800b00a31374533fbmr530874ejx.51.1706315826128; Fri, 26 Jan 2024 16:37:06 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:05 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 3/5] arm64: dts: exynos: gs101: use correct clocks for usi8 Date: Sat, 27 Jan 2024 00:35:52 +0000 Message-ID: <20240127003607.501086-4-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_163707_533849_0F33D285 X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wrong pclk clocks have been used in this usi8 instance here. For USI and I2C, we need the ipclk and pclk, where pclk is the bus clock. Without it, nothing can work. It is unclear what exactly is using USI8_USI_CLK, but it is not required for the IP to be operational at this stage, while pclk is. This also brings the DT in line with the clock names expected by the usi and i2c drivers. Update the DTSI accordingly. Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Tested-by: Tudor Ambarus --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index bc251e565be6..e5b665be2d62 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -380,7 +380,7 @@ usi8: usi@109700c0 { ranges; #address-cells = <1>; #size-cells = <1>; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x101c>; @@ -397,7 +397,7 @@ hsi2c_8: i2c@10970000 { pinctrl-names = "default"; pinctrl-0 = <&hsi2c8_bus>; clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>, - <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>; + <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>; clock-names = "hsi2c", "hsi2c_pclk"; status = "disabled"; }; From patchwork Sat Jan 27 00:35:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13533848 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0FA3C47422 for ; Sat, 27 Jan 2024 00:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jV4S/d5XmryuPj6qtVxoCKez3p6mMVdcI+3jF6E6fNo=; b=jV4B4aMh4c/oyk wCHl4AAzqCfO4xvXdLjqIFOP566GPoUkkAth+LSCI+F3M6Pj5XOUhl0c+hU4QqT/yUEQY8XMxJkfJ ftoVE17PpvCmpNlhObjBC2WvuBOf2Zk3x810CHl4LdDWYNpIqRZct9rhFqR3D85BkqdF9d/6TAEpp 3nk1fjy1Nk3A6XXV45OeZoM06DpZMRN2x1EgM2+0N1vSI1/y+w91us3lDlj8dC9V52x+SKxIjL5gb zgAg82pFuHRJvIlFiCGZN2Fr7jstoYmMIa76ddaW/0ZLMj4anTORUcU0MrGQNvQBK1PKug66ds8X3 RI3mYGqslg8D0EUxkD+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWhC-00000005zF7-0gFK; Sat, 27 Jan 2024 00:37:18 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWh3-00000005zBK-07O7 for linux-arm-kernel@lists.infradead.org; Sat, 27 Jan 2024 00:37:10 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40ed3101ce3so20034045e9.2 for ; Fri, 26 Jan 2024 16:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315826; x=1706920626; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SHiTLNqXAy/ffui/0jj45ErOQ8cZX/p93S1sxrZ6DNI=; b=u57OosoQ0tja+LACoTuc4Fz1jYcPehLlfh4OY1B+PrhqKglei8Vrh0klitBm8gkUnG tkOVfzogLv3CA0JIN87O7+/hWW4YHn8k7eMjEnxtuMe5HgI4l1KWO0gaXgthUWPfJvKa 6tHtGuSPrdWqCUynJO0yenM26ZnfB0pbZeGdDP7PNTqi3SBwAxkhOgJr9syFe+71JSSQ 0jk98WPBMnCzLs3P48mVOk1dZKGQ7tcEvTp7EuD6vqi+Lu89ad0nmKUYXp0t8JlnKdTn TLDr7aZbVE2rz/l7c2uTlPpXRXdNZprouQ5RgH6k7rNfT+GHAdCRg2W7xExPMeygpvKi kc3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315826; x=1706920626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SHiTLNqXAy/ffui/0jj45ErOQ8cZX/p93S1sxrZ6DNI=; b=WFjn8eM6zAwydwQpcg8mi7kujtrUPoiLrQRwoPenJmpF3uiazJzcRvLHwMSbbUnjOB dOGIF8NNypHKB1fsKcmD1Lg3EIelCp5JTYUwDkFXUfKtNY3GhFsQT7otSQIuhK1I4fBC 4HH6ZIoRObtJdbihQdR8veNqgpM/mgOF4r6+64IhFKHGQBaGP63eWtwNqV7BwGEcTdPn fNnHBldM2hZDyFzoRkzxVV0kKNy2EaqCIBaowmzf0x9ED8MLUV6tjeS5/JT4EcmjpRJs fdPyew2x4yV0Y4RwpRMvRud5sINRpekyOltAzZBJUP7XCfO/RfVc+ySasRjYDGb0fHd1 AbKw== X-Gm-Message-State: AOJu0Yw7yHXnEFkn61mbfHFwROKQ9GJJrLBqH6gHuhXMOixSiU5hshrp XjpgHk+R+5WkJONuHpEoqCspquBHVYP6bIuhcGdTTGsihC3kEkSYNYMUFf0J6UU= X-Google-Smtp-Source: AGHT+IGorEDbWQE6VfxFvlvSCPqIp6nl1sPSWqI+VAkqF7VgEu3yF8ZBjC3O57a4HzCVQzahFOXsXA== X-Received: by 2002:a05:6000:1370:b0:337:bb78:8b3e with SMTP id q16-20020a056000137000b00337bb788b3emr210753wrz.197.1706315826560; Fri, 26 Jan 2024 16:37:06 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:06 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 4/5] arm64: dts: exynos: gs101: use correct clocks for usi_uart Date: Sat, 27 Jan 2024 00:35:53 +0000 Message-ID: <20240127003607.501086-5-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_163709_167859_AA49C2C6 X-CRM114-Status: GOOD ( 13.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wrong pclk clocks have been used in this usi8 instance here. For USI and UART, we need the ipclk and pclk, where pclk is the bus clock. Without it, nothing can work. It is unclear what exactly is using USI0_UART_CLK, but it is not required for the IP to be operational at this stage, while pclk is. This also brings the DT in line with the clock names expected by the usi and uart drivers. Update the DTSI accordingly. Fixes: d97b6c902a40 ("arm64: dts: exynos: gs101: update USI UART to use peric0 clocks") Signed-off-by: André Draszik Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus Tested-by: Tudor Ambarus --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index e5b665be2d62..f93e937d2726 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -410,7 +410,7 @@ usi_uart: usi@10a000c0 { ranges; #address-cells = <1>; #size-cells = <1>; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x1020>; @@ -422,7 +422,7 @@ serial_0: serial@10a00000 { reg = <0x10a00000 0xc0>; interrupts = ; - clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK>, + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0>, <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0>; clock-names = "uart", "clk_uart_baud0"; samsung,uart-fifosize = <256>; From patchwork Sat Jan 27 00:35:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13533847 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBE57C48286 for ; Sat, 27 Jan 2024 00:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dLrs+ywT4qY1MaB9FdsSCr2xtsCQYsh+SvI3hz5EQNQ=; b=yo6Vrn14dQTraE wSkEY95Tp3yljbpOhT8J+JaSxKL/5w3q8Dipc/UrLy4cFIl4TB2yVjWie34Dblzca060vxQGHeL6w bSlac2oKwAqo5OjsO4+7G7KWthOWWCuyPTkuaoENJan2EUbqdp9dILaIYV74ZFPR+Zq72rEuX8lP0 qBilaI/q0qOklKWMx5vcZ395O6RO4lcHbLYIp+chvjnXjjEmnKlFLeqfPCHyGpYX9B5kWs38YVmVS 2u+82M1L8+Yphuh3gCFSkiz+wTiH9WVKeL/fdJTyQ+CCAyPxN3oTkMMl2dkJzaBHxFeMxj3K8cxJf 0f/W7d5Ydy+xHOKPnvXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWhC-00000005zFY-43Wg; Sat, 27 Jan 2024 00:37:18 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTWh3-00000005zBa-2eET for linux-arm-kernel@lists.infradead.org; Sat, 27 Jan 2024 00:37:10 +0000 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a26fa294e56so99260466b.0 for ; Fri, 26 Jan 2024 16:37:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706315827; x=1706920627; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3UWKLkucSe2Xo64gIFBssH+CIGBcy5ZlP0k7ni0x+YY=; b=n8TFt15ysCnomFHGk0LSrbmPBR2tXK5Vf44g87b2AAHvHAxpkxrXIEysO88vkxBBB2 /igVzixpUb6YElaOxNkNL7Z5OAdcbHYUwyf/dFhF5AQ67pD674fIkHPXhKPf4fTqpV/+ 5zak9sutyrierTnM53WMHMVQYxguDe0KYBoQhHm4+3e6XLXnUhuQJaAeqUiAsxa6LzQv x49pVogQUo9BAinYIHAV5LuhQ5w8iQK+RP51GO/1xdAF06kRlkYGLY3496hQKuM8Nt3c /eVPCZ+5VDOTBL2DSgMlTwHpDfsItJB2KHya3Yee8YDSg8qWOMZ1YfIm7nTrvGP+Q+bu jucQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706315827; x=1706920627; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3UWKLkucSe2Xo64gIFBssH+CIGBcy5ZlP0k7ni0x+YY=; b=Dx2pwdxLN5Oghi5FjPM+5b0a6HFeKbwZ0/UTwImibBchS1Ha5CGaV+hd3hvwYqimBo hgRAzsND1ojDWa6+ZhUzVqwTcN+rim5716tvZPYEBxKafXGsqOPOXZDGNyO5l02akrr0 X3c5ZjVHNFpaY3FjWyfL6AUhlJyyJ9vvzITh+xCZpORs9ihFsggTWxRzP+aiRX/iSEp0 6HASgfVM5llq+2zywCnbIyrSgyTJ0nOXK1IIbb6/0SeYxeEtEaGP38emd279c8SjjcmL O1VtmAWbPDyTtpFxu8ela1KRTqPk5mYG2GFM9mM3crwJbf70DEQQ1vhbAkCXQJQ4085p T6wA== X-Gm-Message-State: AOJu0YwmvOhyfVRiR/Kns9NXHt3zultFmEgrvDVfFt/6yPbPOjgg/Fwm meYD2HAsbrpzgRCuILVgVnarMJ86Oy02VAJFxnBwsHxGUVdnfuhAc1PdRLq9jAA= X-Google-Smtp-Source: AGHT+IHrJvGINoouX99TOJLFVbc2X2mducvsgZcrMKi5L3PaChxPSsCgcCZPPJqp5nR9OF0/geaoMQ== X-Received: by 2002:a17:907:1006:b0:a35:2841:2ab7 with SMTP id ox6-20020a170907100600b00a3528412ab7mr227213ejb.39.1706315827009; Fri, 26 Jan 2024 16:37:07 -0800 (PST) Received: from puffmais.c.googlers.com.com (229.112.91.34.bc.googleusercontent.com. [34.91.112.229]) by smtp.gmail.com with ESMTPSA id vi1-20020a170907d40100b00a2f48a43c3esm1152235ejc.7.2024.01.26.16.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 16:37:06 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= To: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, willmcvicker@google.com, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 5/5] clk: samsung: gs101: don't mark non-essential clocks as critical Date: Sat, 27 Jan 2024 00:35:54 +0000 Message-ID: <20240127003607.501086-6-andre.draszik@linaro.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org> References: <20240127003607.501086-1-andre.draszik@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240126_163709_706901_8C6AD41E X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The peric0_top1_ipclk_0 and peric0_top1_pclk_0 are the clocks going to peric0/uart_usi, with pclk being the bus clock. Without pclk running, any bus access will hang. Unfortunately, in commit d97b6c902a40 ("arm64: dts: exynos: gs101: update USI UART to use peric0 clocks") the gs101 DT ended up specifying an incorrect pclkk in the respective node and instead the two clocks here were marked as critical. We have fixed the gs101 DT and can therefore drop this incorrect work-around here, the uart driver will claim these clocks as needed. Note that this commit has the side-effect of causing earlycon to stop to work sometime into the boot for two reasons: * peric0_top1_ipclk_0 requires its parent gout_cmu_peric0_ip to be running, but because earlycon doesn't deal with clocks that parent will be disabled when none of the other drivers that actually deal with clocks correctly require it to be running and the real serial driver (which does deal with clocks) hasn't taken over yet * hand-over between earlycon and serial driver appears to be fragile and clocks get enabled and disabled a few times, which also causes register access to hang while earlycon is still active Nonetheless we shouldn't keep these clocks running unconditionally just for earlycon. Clocks should be disabled where possible. If earlycon is required in the future, e.g. for debug, this commit can simply be reverted (locally!). Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0") Signed-off-by: André Draszik Reviewed-by: Tudor Ambarus Reviewed-by: Sam Protsenko --- drivers/clk/samsung/clk-gs101.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c index 61bb0dcf84ee..5c338ac9231c 100644 --- a/drivers/clk/samsung/clk-gs101.c +++ b/drivers/clk/samsung/clk-gs101.c @@ -2982,20 +2982,18 @@ static const struct samsung_gate_clock peric0_gate_clks[] __initconst = { "gout_peric0_peric0_top0_pclk_9", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP0_IPCLKPORT_PCLK_9, 21, 0, 0), - /* Disabling this clock makes the system hang. Mark the clock as critical. */ GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0, "gout_peric0_peric0_top1_ipclk_0", "dout_peric0_usi0_uart", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_IPCLK_0, - 21, CLK_IS_CRITICAL, 0), + 21, 0, 0), GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_2, "gout_peric0_peric0_top1_ipclk_2", "dout_peric0_usi14_usi", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_IPCLK_2, 21, 0, 0), - /* Disabling this clock makes the system hang. Mark the clock as critical. */ GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0, "gout_peric0_peric0_top1_pclk_0", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_PCLK_0, - 21, CLK_IS_CRITICAL, 0), + 21, 0, 0), GATE(CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_2, "gout_peric0_peric0_top1_pclk_2", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_PERIC0_TOP1_IPCLKPORT_PCLK_2,