From patchwork Mon Jan 29 21:08:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Rub=C3=A9n_Justo?= X-Patchwork-Id: 13536402 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D6D7153BD6 for ; Mon, 29 Jan 2024 21:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706562508; cv=none; b=TwkHCNWQJ7Xu8wbPQ2Y8DdG+qvu5DhfVKr+C+1OsAoFgtGOmz1GGtj/muV0aEavAS9hADAEaSJYPZDgubpIYajyP094aikgQYeceoBuWrD2wkeIcb9IxGnRtOmI2VPFfRk4d5vU3/ZVHl7KSQK1hzju7r30v1ZCNdowil2LEJX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706562508; c=relaxed/simple; bh=poNRftosEG1bX9/5oRKwO+fHOoX+rSTSqGjXMNrmD6o=; h=Message-ID:Date:MIME-Version:Subject:From:To:References: In-Reply-To:Content-Type; b=OIXh8fuQB16kFcIXpNBr8/rcUfzRA9FO96dj4v54VRlA5grj2yh/YLmQnRGGPBerwDlYUSi25wUEV2ZYg8vhOXx7qy3b5XfDgWbu+ekRIkeQBl+Kl1pSxNPinEgu/+3tos1TTIR3ximw4KoGGzDEJgZ+g+CWnqNs9EGraYlN0bc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=erZ37C1h; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="erZ37C1h" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-40ef6442d60so12468745e9.1 for ; Mon, 29 Jan 2024 13:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706562505; x=1707167305; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BZeOKSGXOQj4PpRlS8Ug5lD+TauIktOS0BFSdXBGJgo=; b=erZ37C1hB8o2BHOn60LvTiqpoY2iSQS7SkSuO7kIfbHmkdzNCjqefxweYe7sCiEdAF 9ukmfktJvFHLSUnunrjJDfVpnYK/CzDRiL9dUeC4hHHlCwSypZzKgXRpBKAC/VZ7sSo8 w2EwkSvhRYK8VpUtXKeqNtHloGvRInxu/vhr/oyjQrlUMy+jzPX2u9pOhE9JuenSF+AG 8bBGtzbrEMRi55AyU8dSZDutsyEbyPgSazC2QGS+/JeOJMHVlxUxGEMUN009/ATt9oi8 crBaeB9AgujvBFsCQ5UXngIZpSQlGzaBj7Hqu4QuQRiuBs8qqcgiE0V9V63A/zxtS4QB P/7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706562505; x=1707167305; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BZeOKSGXOQj4PpRlS8Ug5lD+TauIktOS0BFSdXBGJgo=; b=H8IaNkdx+VaNucuuhgwUZq1khvjPM2HjZADMgElqyA6N3b97wVfciamqVb5MDzEznj 74MzjYq4xdJrTYfulMUcAoVZD5RpSN9r6CTT//DAoWfTidJN5dJOoGyjmtfbzERvr4Vy kzCwsx3JEh8rpyky77p4MA7OKi22kSBYXedER/Za3ybPdn8/aISAoQ092Um2P50VBSz1 Rqr9p8te7+MSECu1PrtK+c0a0FuaDhVKfK9DGZKkONPBc2gHrfJt4guSb8CF65kzcnmU WN+x0jc6Gic+8STeGJabjq5wb9rUUwEQCXvdUSlTiVwDJntjpLqGT+HJZLioIPxbSk5b Koow== X-Gm-Message-State: AOJu0Yx0bpo+fnyyfYpHVIMja4cB9Oz4v0c09u0YbpSvcP5Lf1A0YiSH Lp6mtlb7ap92Ke/5W7UpUJEvzN5pGz2cElTMW+bOD99dZurklN09qn7FSwHF X-Google-Smtp-Source: AGHT+IGTtxjtUomRpR0U8RMAx91jFXT6QUFXjw775WL1VxpFSSpA9m7Z40Z3tQF7aNPTaMUp1/PWAA== X-Received: by 2002:a05:600c:444c:b0:40e:f157:e765 with SMTP id v12-20020a05600c444c00b0040ef157e765mr4619104wmn.0.1706562504582; Mon, 29 Jan 2024 13:08:24 -0800 (PST) Received: from gmail.com (77.red-88-14-198.dynamicip.rima-tde.net. [88.14.198.77]) by smtp.gmail.com with ESMTPSA id p37-20020a05600c1da500b0040eee4931c9sm7928192wms.48.2024.01.29.13.08.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 13:08:24 -0800 (PST) Message-ID: <4adfcba4-0f2b-44f5-a312-97f00f979435@gmail.com> Date: Mon, 29 Jan 2024 22:08:23 +0100 Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/4] t0080: mark as leak-free Content-Language: en-US From: =?utf-8?q?Rub=C3=A9n_Justo?= To: Git List References: <45eb0748-6415-4e52-a54f-8d4e5ad57dde@gmail.com> In-Reply-To: <45eb0748-6415-4e52-a54f-8d4e5ad57dde@gmail.com> This test is leak-free since it was added in e137fe3b29 (unit tests: add TAP unit test framework, 2023-11-09) Let's mark it as leak-free to make sure it stays that way (and to reduce noise when looking for other leak-free scripts after we fix some leaks). Signed-off-by: Rubén Justo --- t/t0080-unit-test-output.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/t0080-unit-test-output.sh b/t/t0080-unit-test-output.sh index 961b54b06c..6657c114a3 100755 --- a/t/t0080-unit-test-output.sh +++ b/t/t0080-unit-test-output.sh @@ -2,6 +2,7 @@ test_description='Test the output of the unit test framework' +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh test_expect_success 'TAP output from unit tests' ' From patchwork Mon Jan 29 21:08:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Rub=C3=A9n_Justo?= X-Patchwork-Id: 13536403 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91EFE153BD6 for ; Mon, 29 Jan 2024 21:08:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706562512; cv=none; b=CwteHM9N3t8sVo8vGPkBJcDdB0bd6nah7rHrLSvOHOIOCBLN2aROUa0ISUOceAKkE1jgpZWUB5j6DS6arP4TvfzIFXNa4Y8wkPBXtMzqQ9TKJNc23wXEDV7U3rlMT4bUMhisM4wK+evzmA98rAyXZbQCqL+t8Zz29/wW9Skxi/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706562512; c=relaxed/simple; bh=P138CkIR7IQl5pjzihTJRVUmbbu3owgB2lVhaRIli0w=; h=Message-ID:Date:MIME-Version:Subject:From:To:References: In-Reply-To:Content-Type; b=fy+k1zOHeWIMRACIFdeOhuErubvz6cqLVR6R9HseqH1kOSTz3CEKzz99rV6dL32xryc9wnZmJ72AvzoO1zinBgVTIM838DmaU4ZT1NUTkXXTiAhlItugVzHj2JhfCFFrkF/S3fxCMDzTciWtaXqlXV3cmJdv/s6ooWzi8yWJJFI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gg9yCJSR; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gg9yCJSR" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40e80046246so17657375e9.1 for ; Mon, 29 Jan 2024 13:08:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706562509; x=1707167309; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1he35j0iHkkDz2QiI1sEXGjam7vSE7oNWnUdcAwWemw=; b=Gg9yCJSRzw5Um/NjbtNa1BP41J6zWFcwSHFhYVxAa9eL8q3MZDklctdBJddVtn8wcX kuVWu6EB2jp7vNxpFrpWoEGZNeODch88OYNM6JfzRbQQk4pveXtWliym2uloRkjlnLSS B7uN5gO/WY1aNXDQQhrug0l1y1OeAS/L9FtIRXg1VswCwpQxDOV//cKggFgn1wy4drXu x4YD9IUk1rBMTRjKdn4mKx34gL+4rbS/pJaEN7XzqOfbjsGn9edmYRvNSFk5AMe5HaYl 3Vu5BpF2KEuv544iY+WF7Rl9YOuKuXFKfc6pOHkpIKtzGYwSUaUy7nIOLIo59E7JM9rh 8GaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706562509; x=1707167309; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1he35j0iHkkDz2QiI1sEXGjam7vSE7oNWnUdcAwWemw=; b=SjIeIxgUkVsfn+M4gqeX485Uawl2ueDMn6Euh2Q7u94ALNJVN5sXNSyFsWn7vLZugf GwPzEmea/sIJ2AcMGjMppCedxSh2o5Gug1EUcxO6DmUIjGBBk1IxBMKCr572HCdAF8ZY UEJZgceraZkE2j4BYqaDO4bxS5jTUq9Ceo2BXPjArdqWgWGALYATdL3ItU9AS3y8EfZS WcszeOpbkXdzp686oCr4kkbod7u8rO4wXuI0I++rpkmL4bHsMMFkkH6k1QMHW8IUZzcP 6613HOmhhqBj9kt2oeg7ekTm753V6QzXk890XM6FD3hu/5Uj+E2r6jvvDowSMl6MFtrG SA3Q== X-Gm-Message-State: AOJu0YxDPHPGNX2yVj/qMOaezvurklxqdZEvzsWQAi9DbhPl/U9HI40T SIPld8k4aEAjv6ZIZ5yabWRQKWjNhisBcQU36MN31MUOLSb0ehV53PvLHXLW X-Google-Smtp-Source: AGHT+IGhxIJkQiNulLMZGFO9eOZFc9DDV+IdUCzuXCy7duufGNddlXsGwiGv38Wvxs6wSIdcUWPfLw== X-Received: by 2002:a05:600c:3b92:b0:40e:f972:9901 with SMTP id n18-20020a05600c3b9200b0040ef9729901mr2621015wms.4.1706562508828; Mon, 29 Jan 2024 13:08:28 -0800 (PST) Received: from gmail.com (77.red-88-14-198.dynamicip.rima-tde.net. [88.14.198.77]) by smtp.gmail.com with ESMTPSA id p37-20020a05600c1da500b0040eee4931c9sm7928192wms.48.2024.01.29.13.08.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 13:08:28 -0800 (PST) Message-ID: Date: Mon, 29 Jan 2024 22:08:27 +0100 Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/4] t5332: mark as leak-free Content-Language: en-US From: =?utf-8?q?Rub=C3=A9n_Justo?= To: Git List References: <45eb0748-6415-4e52-a54f-8d4e5ad57dde@gmail.com> In-Reply-To: <45eb0748-6415-4e52-a54f-8d4e5ad57dde@gmail.com> This test is leak-free since it was added in af626ac0e0 (pack-bitmap: enable reuse from all bitmapped packs, 2023-12-14). Let's mark it as leak-free to make sure it stays that way (and to reduce noise when looking for other leak-free scripts after we fix some leaks). Signed-off-by: Rubén Justo --- t/t5332-multi-pack-reuse.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/t5332-multi-pack-reuse.sh b/t/t5332-multi-pack-reuse.sh index 2ba788b042..99145327a6 100755 --- a/t/t5332-multi-pack-reuse.sh +++ b/t/t5332-multi-pack-reuse.sh @@ -2,6 +2,7 @@ test_description='pack-objects multi-pack reuse' +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh . "$TEST_DIRECTORY"/lib-bitmap.sh From patchwork Mon Jan 29 21:08:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Rub=C3=A9n_Justo?= X-Patchwork-Id: 13536423 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0679157E72 for ; Mon, 29 Jan 2024 21:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706562518; cv=none; b=JZkRs1WcBBRnYN+1hqwKiDkDJ2Aukj8lfnAloU5A8xYXwEii6doD+rkMxr61KRIX+IH8d6snugCTguXpgsPrbR4/QWeIcrILQLfnukMvCFffa5heaubo9gFNFmOdgUXhPwkVuEuh8wsL75/NFDty7NfrJzknz/SbuR2JKcN1DAM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706562518; c=relaxed/simple; bh=fxNDPOkqNw3PVqKg53u0K/eLN3soeFhs1YHr+shk9mU=; h=Message-ID:Date:MIME-Version:Subject:From:To:References: In-Reply-To:Content-Type; b=DHFy7RaDf8MbQUP+GTdRAXtXqLEEAOU+9dE42HVTi/EizrNtcRej9ea3qHmjAn9jbafzDKRn4NDxOCws8UV7XtJCkG/3Fbf8qoY0NKNEfCrBtJldEMtrgwdXqv5fWYbqKtoJEj9Vp59TINyBTNBqvoXsa+Y3ZgbPwqoe6StkJTk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c03+k+Yc; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c03+k+Yc" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-40eec4984acso25552925e9.2 for ; Mon, 29 Jan 2024 13:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706562515; x=1707167315; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sjNb/0U1GW8AfEhJ/HJ0Yg/Di8d9jKHHq8wRoOIOEeg=; b=c03+k+Yc10zh5Qce623P+RMZti/XC01SLuy2d+DLoByCh7+pr8kox0y/m1QkTkR59g EbS0NMv936UTe/ra7cm/CD4H+sSFv3KpbO6RTlBjnLzdtrz1tQ3/bWkx8/pzktuJta+U KzfoYOETRaoAQ3Fv9A/lTo+IEmJ3A5hg4lE4RxyLhDFHT/oZUrCO4AqwH2CgqEsGkR4A LNOXEwMVkiq4OS38iOXwSTNqegW71Nlb9AaeDhu4jMtFExTeW/gy+A3+DolMz6TBa+GO MPyjbhLY+hCu1lT1UUcXcL/SWDAvhWORpwOqy6LSM9On77w+Ms0beiANSoiGtnm3WyUs 6Mlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706562515; x=1707167315; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sjNb/0U1GW8AfEhJ/HJ0Yg/Di8d9jKHHq8wRoOIOEeg=; b=WalqhnWTbFpEbuKJsiRuoQpBiiS82Qw8qA4KglIukU3ZjSUH+kST1sBOdk8Doh9y1N DM/wr+ySYlw5mCj0qNr/tteaQweR+hq5CyQRuBMUw1sQYGSvd6UHrHEi7Y6ANnXFpjqB 9QWRKVbJpiCAONExn57SXy/hevaghuTPTkRzK1uU7/MC1qiQJJgqcgkWuIZIDpPw9LKB V4kgMh9k9hpM0MkrMaAQ1l61SnJMx5pv+La5+4bfMTtECF+xzHLAsVY/nJ6zN6uKrNha 1tDeB1GQmMN94YTGrO4lscBin+HkGA0Mk7YQyIy9EssUN/uYP3PrMU4kgg+EUC8YrVWR I9fQ== X-Gm-Message-State: AOJu0YzTFA19pO0Ltyjgr1zY52/AATlgAxM+xKRMf7gvT0AFpzoyFbYx vA/zjbUwBZ+7gwS2bxQh+a5F+vg7LeQUV9lKn3nBVAQeAicxNf7MTBez6rDY X-Google-Smtp-Source: AGHT+IEVO5mqIDapybdpbQEZ/L/d7hfTQsUbBpgi9A/6inZ6auAbDwoDlPk0YQJM30+MovNEZkEswg== X-Received: by 2002:a05:600c:3b28:b0:40e:e2eb:bea8 with SMTP id m40-20020a05600c3b2800b0040ee2ebbea8mr5828550wms.0.1706562515246; Mon, 29 Jan 2024 13:08:35 -0800 (PST) Received: from gmail.com (77.red-88-14-198.dynamicip.rima-tde.net. [88.14.198.77]) by smtp.gmail.com with ESMTPSA id p37-20020a05600c1da500b0040eee4931c9sm7928192wms.48.2024.01.29.13.08.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 13:08:34 -0800 (PST) Message-ID: Date: Mon, 29 Jan 2024 22:08:34 +0100 Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/4] t6113: mark as leak-free Content-Language: en-US From: =?utf-8?q?Rub=C3=A9n_Justo?= To: Git List References: <45eb0748-6415-4e52-a54f-8d4e5ad57dde@gmail.com> In-Reply-To: <45eb0748-6415-4e52-a54f-8d4e5ad57dde@gmail.com> This test does not leak since a96015a517 (pack-bitmap: plug leak in find_objects(), 2023-12-14) when the annotation TEST_PASSES_SANITIZE_LEAK=true was also added. Unfortunately it was added after test-lib.sh is sourced, which makes GIT_TEST_PASSING_SANITIZE_LEAK=check error: $ make SANITIZE=leak GIT_TEST_PASSING_SANITIZE_LEAK=check test T=t6113-rev-list-bitmap-filters.sh ... make[2]: Entering directory '/tmp/git/git/t' *** t6113-rev-list-bitmap-filters.sh *** in GIT_TEST_PASSING_SANITIZE_LEAK=check mode, setting --invert-exit-code for TEST_PASSES_SANITIZE_LEAK != true ok 1 - set up bitmapped repo ok 2 - filters fallback to non-bitmap traversal ok 3 - blob:none filter ok 4 - blob:none filter with specified blob ok 5 - blob:limit filter ok 6 - blob:limit filter with specified blob ok 7 - tree:0 filter ok 8 - tree:0 filter with specified blob, tree ok 9 - tree:1 filter ok 10 - object:type filter ok 11 - object:type filter with --filter-provided-objects ok 12 - combine filter ok 13 - combine filter with --filter-provided-objects ok 14 - bitmap traversal with --unpacked # passed all 14 test(s) 1..14 # faking up non-zero exit with --invert-exit-code make[2]: *** [Makefile:68: t6113-rev-list-bitmap-filters.sh] Error 1 make[2]: Leaving directory '/tmp/git/git/t' make[1]: *** [Makefile:55: test] Error 2 make[1]: Leaving directory '/tmp/git/git/t' make: *** [Makefile:3212: test] Error 2 Let's move the annotation before sourcing test-lib.sh, to make GIT_TEST_PASSING_SANITIZE_LEAK=check happy. Signed-off-by: Rubén Justo --- t/t6113-rev-list-bitmap-filters.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/t6113-rev-list-bitmap-filters.sh b/t/t6113-rev-list-bitmap-filters.sh index 459f0d7412..a9656a1ec8 100755 --- a/t/t6113-rev-list-bitmap-filters.sh +++ b/t/t6113-rev-list-bitmap-filters.sh @@ -1,10 +1,11 @@ #!/bin/sh test_description='rev-list combining bitmaps and filters' + +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh . "$TEST_DIRECTORY"/lib-bitmap.sh -TEST_PASSES_SANITIZE_LEAK=true test_expect_success 'set up bitmapped repo' ' # one commit will have bitmaps, the other will not From patchwork Mon Jan 29 21:08:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Rub=C3=A9n_Justo?= X-Patchwork-Id: 13536424 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E21CA15956A for ; Mon, 29 Jan 2024 21:08:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706562522; cv=none; b=ewdNpHHKRQDqW/Mc7HLNtvmc2q9VpsNYA56PU3FehNtXdo1Wej0J5Vj6ZPJll/J3Wu9KJ3dTKUWlAnILFcDyB8slmN1YLKbgb1aspo1Sl1+GE7BOBBaCZaQI107kDKu1VtXAEiGPHrhFoJhDOe6fSF01MntF/m6RztXhsg97mmc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706562522; c=relaxed/simple; bh=flYupNXkICOTCaWjBpW7TFVL+ypPOSdE66aB1he64c4=; h=Message-ID:Date:MIME-Version:Subject:From:To:References: In-Reply-To:Content-Type; b=oxfw0GxSFsZC6O7zDJD/fkqkGYQGulYeF2pie+QlboBMr2ziXiSsBwOh4bR4kndE3/X7A5XU7EvXPac3TExoITBuAYxF1Z4KCfJllx/MKdNU3c510+wPS8oDwX28x++XX2K7wr/PSZk7GLh4RVqj2T+c8WRLeEOYK6VSMombwRk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LLLEMUz4; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LLLEMUz4" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-40ef6f10b56so10434265e9.2 for ; Mon, 29 Jan 2024 13:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706562519; x=1707167319; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DGapvugrdFC3AYkG1KKrI/EoxGDcMBO6mIPlTKZykxI=; b=LLLEMUz4StVpFcYGzY3IgQ3eCxXabdoiN7Y6RZl4GvvVh6eY4Cmwd8tjTfcmUeJN1k SwM/mESNHMhdzU740ix+XOeEnIgKoytKpmlYP22ctH9todz5MOKHOXTKYgX/bssIhc+J HezQGMGR9Ihc4IoO/YoWlbJfLQxhVZsS1ENhOb0DenCWRXAuOfrT8aOncwfOLvBG5Gf9 KehSNTrMBXFqPQtuwl9uouDqKaIJ0CdMigvwlRWOdfQePl40+a7Kuv1QxwoQIi0b+Thh WxzfpcVAkvRNxc2ToYjwVFlCRKzxJPrQEWN+7ybBJY4/z5lQcLMQybPTlZufMPEpMmzV WOCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706562519; x=1707167319; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DGapvugrdFC3AYkG1KKrI/EoxGDcMBO6mIPlTKZykxI=; b=SfwNaRIeJ43nmt1VLErYleJITPR4aliR973oiKaB3nMm6YGsRz0HX/qZIuXlNsDLp2 WbsKcjPZUlNiTCMpkqWFmJQjCtWY5F7itm3a0XOG/xoVNl6fSfjjePXbV9DbwxAls5YQ +gjTfD1oBSz5XGXiEj9vwJzmQAICGQSa7DSAjlCZZQxxAtnNlPmG8MGGLa1hStJNOfnA 6m+5PUSWslszlHXi2ZbD3J9kLlJf3ACXNaZsnPD1hIRJdrbAwGkFMwM48tyzsprKscQh YnWDd7hXBCNzIZzoTlsSOd9egdpqLkQO8Qk98t+CxEw6b6riZmPYi/nvs4+WtlnzCFbL ybRw== X-Gm-Message-State: AOJu0Yw/Qf4cxXVwELWFS7r3rHMkh25D3JeT4DBxTcQqXw0Db64Qf2qM qVxGnFzVLyT5Y8CAQc6PbIxg4MYHQWJ7xKsZiVzbo6kr6MG4kq2pTIo7kwf3 X-Google-Smtp-Source: AGHT+IEb4jTQeRDzJo0J2kEeS45IbSk77IbZd7vTTJQr0FXR3JDwvb2LhoyKqBQfkdAKhQITwNYKFA== X-Received: by 2002:a05:600c:1c26:b0:40e:6d00:375 with SMTP id j38-20020a05600c1c2600b0040e6d000375mr5562914wms.0.1706562519090; Mon, 29 Jan 2024 13:08:39 -0800 (PST) Received: from gmail.com (77.red-88-14-198.dynamicip.rima-tde.net. [88.14.198.77]) by smtp.gmail.com with ESMTPSA id p37-20020a05600c1da500b0040eee4931c9sm7928192wms.48.2024.01.29.13.08.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 13:08:38 -0800 (PST) Message-ID: <6447b11b-f916-4079-8936-8d4f6c480f57@gmail.com> Date: Mon, 29 Jan 2024 22:08:38 +0100 Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 4/4] test-lib: check for TEST_PASSES_SANITIZE_LEAK Content-Language: en-US From: =?utf-8?q?Rub=C3=A9n_Justo?= To: Git List References: <45eb0748-6415-4e52-a54f-8d4e5ad57dde@gmail.com> In-Reply-To: <45eb0748-6415-4e52-a54f-8d4e5ad57dde@gmail.com> TEST_PASSES_SANITIZE_LEAK must be set before sourcing test-lib.sh, as we say in t/README: GIT_TEST_PASSING_SANITIZE_LEAK=true skips those tests that haven't declared themselves as leak-free by setting "TEST_PASSES_SANITIZE_LEAK=true" before sourcing "test-lib.sh". This test mode is used by the "linux-leaks" CI target. GIT_TEST_PASSING_SANITIZE_LEAK=check checks that our "TEST_PASSES_SANITIZE_LEAK=true" markings are current. Rather than skipping those tests that haven't set "TEST_PASSES_SANITIZE_LEAK=true" before sourcing "test-lib.sh" this mode runs them with "--invert-exit-code". This is used to check that there's a one-to-one mapping between "TEST_PASSES_SANITIZE_LEAK=true" and those tests that pass under "SANITIZE=leak". This is especially useful when testing a series that fixes various memory leaks with "git rebase -x". In a recent commit we fixed a test where it was set after sourcing test-lib.sh, leading to confusing results. To prevent future oversights, let's add a simple check to ensure the value for TEST_PASSES_SANITIZE_LEAK remains unchanged at test_done(). Signed-off-by: Rubén Justo --- t/test-lib.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/t/test-lib.sh b/t/test-lib.sh index fc93aa57e6..042f557a6f 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -1297,6 +1297,11 @@ test_done () { EOF fi + if test -z "$passes_sanitize_leak" && test_bool_env TEST_PASSES_SANITIZE_LEAK false + then + BAIL_OUT "Please, set TEST_PASSES_SANITIZE_LEAK before sourcing test-lib.sh" + fi + if test "$test_fixed" != 0 then say_color error "# $test_fixed known breakage(s) vanished; please update test(s)"