From patchwork Tue Feb 19 14:00:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10819939 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 998CC6CB for ; Tue, 19 Feb 2019 14:00:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 87A172C11C for ; Tue, 19 Feb 2019 14:00:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 85EC82C120; Tue, 19 Feb 2019 14:00:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B7772C126 for ; Tue, 19 Feb 2019 14:00:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbfBSOAf (ORCPT ); Tue, 19 Feb 2019 09:00:35 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:44700 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725845AbfBSOAf (ORCPT ); Tue, 19 Feb 2019 09:00:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vwq2scBDjjb1loUwXCZHMjh0PpFfmoQEs2SA+VHxJGM=; b=avW+kJVVEwvN8QrSDP7cyUPii F8jh+Z+5ATLZBGsfhVRI9QbLGyKHz5ubL8PDLBTbZUNWXasNLElI78t7/MS0fYVQ/P0+hoZvS0tRt uq8njFsihcVFQbGuDT2V0ghmv9IVz4oGlAxat4pzKq50S9/sgUn0wi/rO2UJTFOKPaEssBehGAAyj 2gmPIX24i8lyrrkDgTp9BKDHOlTRP5BLdX2cPX09nl86kmKOh/LkPc8yFBcTfs1qddvU9AbU+jfdX qdWDrHFHFvT2C550u/oswQWZf9aplzyYN3hBbcIAIDrJnJsY1FwmSl5/gXsTb9uzjTH1mNpGUavBX MBKRIaKLg==; Received: from 177.96.194.24.dynamic.adsl.gvt.net.br ([177.96.194.24] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gw5wo-0004zI-So; Tue, 19 Feb 2019 14:00:34 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.91) (envelope-from ) id 1gw5wl-000AbC-Ix; Tue, 19 Feb 2019 09:00:31 -0500 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , devel@driverdev.osuosl.org Subject: [PATCH 1/2] media: ipu3: shut up warnings produced with W=1 Date: Tue, 19 Feb 2019 09:00:29 -0500 Message-Id: <0bdfc56c13c0ffe003f28395fcde2cd9b5ea0622.1550584828.git.mchehab+samsung@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There are lots of warnings produced by this driver. It is not as much as atomisp, but it is still a lot. So, use the same solution to hide most of them. Those need to be fixed before promoting it out of staging, so add it at the TODO list. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/ipu3/Makefile | 6 ++++++ drivers/staging/media/ipu3/TODO | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/staging/media/ipu3/Makefile b/drivers/staging/media/ipu3/Makefile index fb146d178bd4..fa7fa3372bcb 100644 --- a/drivers/staging/media/ipu3/Makefile +++ b/drivers/staging/media/ipu3/Makefile @@ -9,3 +9,9 @@ ipu3-imgu-objs += \ ipu3-css.o ipu3-v4l2.o ipu3.o obj-$(CONFIG_VIDEO_IPU3_IMGU) += ipu3-imgu.o + +# HACK! While this driver is in bad shape, don't enable several warnings +# that would be otherwise enabled with W=1 +ccflags-y += $(call cc-disable-warning, packed-not-aligned) +ccflags-y += $(call cc-disable-warning, type-limits) +ccflags-y += $(call cc-disable-warning, unused-const-variable) diff --git a/drivers/staging/media/ipu3/TODO b/drivers/staging/media/ipu3/TODO index 8b95e74e43a0..5e55baeaea1a 100644 --- a/drivers/staging/media/ipu3/TODO +++ b/drivers/staging/media/ipu3/TODO @@ -27,3 +27,5 @@ staging directory. - Document different operation modes, and which buffer queues are relevant in each mode. To process an image, which queues require a buffer an in which ones is it optional? + +- Make sure it builds fine with no warnings with W=1 From patchwork Tue Feb 19 14:00:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10819937 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5166E139A for ; Tue, 19 Feb 2019 14:00:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E57B2C0E9 for ; Tue, 19 Feb 2019 14:00:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3CC152C113; Tue, 19 Feb 2019 14:00:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DDF402C0E9 for ; Tue, 19 Feb 2019 14:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726289AbfBSOAf (ORCPT ); Tue, 19 Feb 2019 09:00:35 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:44696 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725803AbfBSOAf (ORCPT ); Tue, 19 Feb 2019 09:00:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xv1FtqEtFrd+YgCl0FGr2jk/tp3yOCMzWez/ZJKJcXM=; b=Kl75s3uEVlI5Z/dHXrfsVTq2Ov Ov8HQjMS1QiFmB2+c/3IgQma3iDt6DNfNacp9r32rq9sKoapIqaueGVl+lM1Kvjrv/dcY94YqvNlX FOUf3otipMrKU1ahInQKpo8GG6fJ8wTLgv1STLoCHz6Xd4e4t7LEtZ8psOp3pNe0onmMlxecTjF9V tr1z4R7H7Ys5p1OOqF6864n+De4vUkcdBYGhmGjMRPbL3mh4fixteitIphHzbriqi4HnfQJ7y1w5M obJMmm3U+GLdg2C13Wk+x+yGAC+IL41FcVBNNQl+GJsYEIqHNKicBOP7IYe+CS5Bvn9dkiZwyh8Wg kyNH7eOQ==; Received: from 177.96.194.24.dynamic.adsl.gvt.net.br ([177.96.194.24] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gw5wo-0004zJ-U4; Tue, 19 Feb 2019 14:00:34 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.91) (envelope-from ) id 1gw5wl-000AbF-Jz; Tue, 19 Feb 2019 09:00:31 -0500 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , devel@driverdev.osuosl.org Subject: [PATCH 2/2] ipu3-mmu: fix some kernel-doc macros Date: Tue, 19 Feb 2019 09:00:30 -0500 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: <0bdfc56c13c0ffe003f28395fcde2cd9b5ea0622.1550584828.git.mchehab+samsung@kernel.org> References: <0bdfc56c13c0ffe003f28395fcde2cd9b5ea0622.1550584828.git.mchehab+samsung@kernel.org> MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some kernel-doc markups are wrong. fix them. Signed-off-by: Mauro Carvalho Chehab Acked-by: Sakari Ailus --- drivers/staging/media/ipu3/ipu3-mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/ipu3/ipu3-mmu.c b/drivers/staging/media/ipu3/ipu3-mmu.c index cd2038b22b55..cfc2bdfb14b3 100644 --- a/drivers/staging/media/ipu3/ipu3-mmu.c +++ b/drivers/staging/media/ipu3/ipu3-mmu.c @@ -238,7 +238,7 @@ static int __imgu_mmu_map(struct imgu_mmu *mmu, unsigned long iova, return 0; } -/** +/* * The following four functions are implemented based on iommu.c * drivers/iommu/iommu.c/iommu_pgsize(). */ @@ -444,6 +444,7 @@ size_t imgu_mmu_unmap(struct imgu_mmu_info *info, unsigned long iova, /** * imgu_mmu_init() - initialize IPU3 MMU block + * @parent: struct device parent * @base: IOMEM base of hardware registers. * * Return: Pointer to IPU3 MMU private data pointer or ERR_PTR() on error. @@ -522,7 +523,7 @@ struct imgu_mmu_info *imgu_mmu_init(struct device *parent, void __iomem *base) /** * imgu_mmu_exit() - clean up IPU3 MMU block - * @mmu: IPU3 MMU private data + * @info: IPU3 MMU private data */ void imgu_mmu_exit(struct imgu_mmu_info *info) {