From patchwork Mon Feb 5 13:34:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 13545576 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 263E528E0D; Mon, 5 Feb 2024 13:35:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707140112; cv=none; b=L4TGJlp5q+DAMFcFaGkW0ffwB3sY43Mm9RWEjeRbzskJtOUs+suRnqXRbgLJc6xNrEhKQ2Bl0g+Dku4JLQXDyR1PKzzApocTJt9vI1NkE1Rqz+Ao+K6K7Z30Fd5jwRh0m0k4qOD8U6hL3SFMHD+4KZ9rlzYwY0kMI5uYNMWL+jg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707140112; c=relaxed/simple; bh=X2Muz8pkoRwEhUvH9ti0eknrxae4vqD1PWSyx9/gso0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=ZTbDEUT6ipbyUtKKeRS9r+nim7KLhBcZFzjGDWuMWYvWYJ1daY+effDB4GLAbryLaNzajaFtbQPjKWAya+itfMC3bBjJWBf+pglPzizGM4Qsjnd/LiBda3YgYG/BQfDAbQqsaBMlzoPeox4QE0UtdMDYLAI9/dE9K3Jbi++/JFE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=UBGvnKcM; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UBGvnKcM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707140111; x=1738676111; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=X2Muz8pkoRwEhUvH9ti0eknrxae4vqD1PWSyx9/gso0=; b=UBGvnKcMsGdbbJKLJjzHHHrCDQTkaaOfFnSj2p9Adk1HyVerbVSyCXJb zGEEMgKVvKYRmsXWdj1s5DBx3ln8xX4TjJ2a9sbxEGs61UjqknN8pSpFk XKqOK0Eq4VbUyCdJ8RptV/yo3uU+DKekXqV2ZFslnB0TlZq7eUMSTEOaG 5y9dYgicI6IwmAygqQsoKNNcVQODYFHTjm1cDRHFYx1YhegNQTVTGL66g HJgrP321qNf785Rkzy6OUHok2xHdNl4rZiEKBozXZzogwlZlDuW2E8HmQ OE0To3oqOSLw1JM56isFRg97OFTndlGvZUdYJEp5KOB/7bntjT3h1BEkW Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10974"; a="11167269" X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="11167269" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 05:35:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="5329233" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.246.35.237]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 05:35:08 -0800 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: Thomas Bogendoerfer , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 1/4] MIPS: lantiq: Remove unused function pointer variables Date: Mon, 5 Feb 2024 15:34:47 +0200 Message-Id: <20240205133450.5222-2-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240205133450.5222-1-ilpo.jarvinen@linux.intel.com> References: <20240205133450.5222-1-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Ever since introduction in the commit e47d488935ed ("MIPS: Lantiq: Add PCI controller support.") ltqpci_plat_dev_init has been unused. In 57c8cb8f2429 ("MIPS: pci: convert lantiq driver to OF") also ltq_pci_plat_arch_init was introduced. With those commit being more than 10 years ago, it seem neither is going to get used anytime soon. Thus, remove both unused function pointer variables. Signed-off-by: Ilpo Järvinen --- arch/mips/pci/fixup-lantiq.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/arch/mips/pci/fixup-lantiq.c b/arch/mips/pci/fixup-lantiq.c index 13009666204f..8bcc136976dc 100644 --- a/arch/mips/pci/fixup-lantiq.c +++ b/arch/mips/pci/fixup-lantiq.c @@ -7,17 +7,8 @@ #include #include -int (*ltq_pci_plat_arch_init)(struct pci_dev *dev) = NULL; -int (*ltq_pci_plat_dev_init)(struct pci_dev *dev) = NULL; - int pcibios_plat_dev_init(struct pci_dev *dev) { - if (ltq_pci_plat_arch_init) - return ltq_pci_plat_arch_init(dev); - - if (ltq_pci_plat_dev_init) - return ltq_pci_plat_dev_init(dev); - return 0; } From patchwork Mon Feb 5 13:34:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 13545577 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 145372C1BA; Mon, 5 Feb 2024 13:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707140119; cv=none; b=X2CMXt+UV99a8zWqRNShlcHc1ykO0/H77HvmymO1nJm0vsSpg5LnNHWLbIC/augHk3KXIniy1W6O+u1ZvsPwKhl6HZGI4oDp5PKPoNTXHjHBOsN+fRFmD1/ZPbpEWCRoN+xcy042nQKBXS+PFHk4fdb5O92525s+ZhMQr4cVsPE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707140119; c=relaxed/simple; bh=JPdk+Lb9y/P3Nc1X0LzlAL+t7jsIt4F4AidZQorL+eU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=sbzmdGXmY3nLlMGUPnch950+TVAlEDWvC7lSXiW8bOU68cMbvnlYU0+xH5NvNysz+RULBmRoNI3l+JuGoVkwMkkzPh9u4GcCiHxIBMo4U/t58W9MZfIMesQn34oRqBsLkKZQzaII8yg+YNHo19e7TpaQzIhJJO5fgXESa9OYkOI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WiDeMxQC; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WiDeMxQC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707140119; x=1738676119; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JPdk+Lb9y/P3Nc1X0LzlAL+t7jsIt4F4AidZQorL+eU=; b=WiDeMxQCxNFU6bVzFUr1v7ALuo5q5NsI6vOZ/a/s23OmLGBg62kNgAgB VFtcya12OImy3qgVOZ649BGVevEtkmeARsBE9K63lDRAoGz60I6HALPVd U1Dj+QkAX2KoaIueh7qofi0iobB9EjOT0Q+WuLD3+0tpGFWymBTENHc5W 8WT60f1m3PJyD3FGSFfQ28IlxB5XxtZJ/y+AWZtvO0ImKvX/UOQXojBrA XcYVJDorwGNdx3WtF9lm3KWAQwOgQt7SFvRc7RO3iHmigFykcQVlmRvVt zv0czQXQfyjGcFO5w2NsVcPxYtAZ7dZckor8QXeqBzyVAIjm4zi6Znwhh g==; X-IronPort-AV: E=McAfee;i="6600,9927,10974"; a="690053" X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="690053" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 05:35:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="923228" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.246.35.237]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 05:35:15 -0800 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: Thomas Bogendoerfer , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 2/4] MIPS: ath79: Don't return PCIBIOS_* code from pcibios_enable_device() Date: Mon, 5 Feb 2024 15:34:48 +0200 Message-Id: <20240205133450.5222-3-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240205133450.5222-1-ilpo.jarvinen@linux.intel.com> References: <20240205133450.5222-1-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 pcibios_plat_dev_init() is called from pcibios_enable_device() that should return normal errnos, not PCIBIOS return codes. In this case the impact is only cosmetic because PCIBIOS_SUCCESSFUL equals 0 that is success code with errnos as well. Nonetheless, remove the inconsistency by replacing the PCIBIOS_SUCCESSFUL with 0. Signed-off-by: Ilpo Järvinen --- arch/mips/pci/fixup-ath79.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/pci/fixup-ath79.c b/arch/mips/pci/fixup-ath79.c index 09a4ce53424f..6a6c4f58f7f4 100644 --- a/arch/mips/pci/fixup-ath79.c +++ b/arch/mips/pci/fixup-ath79.c @@ -9,7 +9,7 @@ int pcibios_plat_dev_init(struct pci_dev *dev) { - return PCIBIOS_SUCCESSFUL; + return 0; } int pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin) From patchwork Mon Feb 5 13:34:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 13545578 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA4022260A; Mon, 5 Feb 2024 13:35:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707140129; cv=none; b=Fz2C6BcTUfEeKrBqN2DOkyU3On4g3eeGzHagTLVoAv1pst5nPCSud+a3C8XvXgXUoL30COiAOfboMNxuKQmhDO4bPY9+bEQ33frv0dTvjY0pw1EyrK0vhQ6QG2e8LYwyrEnpvak9gnWx3MKShpie0vOF83DI7VqwpB444HZCW7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707140129; c=relaxed/simple; bh=Q3+800fhd/fwWAp0F7nWO/Ih5K1cq1Tqdf0ZT226Bzg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=VbwOxQRJ2+zi7NvXDdxPfDQNSx4GbyGd0aHUMsSxzWU5WQcDhOklomCRcPlvwrjtdUA7vF82KUZDlDmz9foXyipSjNE8HNc4bVmiC5XfQ8ur+I+NUCBJauyQprksXj4CB43J4RGV7cFwuhEq96pEDV4UW1eI35xVEimyKeKmY4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RcUITd3Q; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RcUITd3Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707140128; x=1738676128; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Q3+800fhd/fwWAp0F7nWO/Ih5K1cq1Tqdf0ZT226Bzg=; b=RcUITd3QMEvhfE9bwSJwnvNIVikJeqzeg6S0BGkUEuXmM0I3+vJgOGGY /zKgfrSPlZ2adJel2Lhxt/n5w/Ins7HkMr7k0mL/THR+q48IniqVfzHgP eu38ospjuK791rZwodxB2dkhhgZM2ryDKfqS5O1lGCMMGRdAgQyh8YpeQ 8cUNjjIwTsL2EJvNHKq3KGs3c2JPfFgKpPW85cl/Rp8tqmXUU7hpvgAcT T99xRZ3jFfAgsaBkOtr6wSnP02GrhpJfmvK5Coe+/VYJ6wjWPut7gq5JP 5gAZiTijsiBfbdeMlAgdv3ByiKydRu+m1UHxIJCbPKHl3w0mV8SwDB7ZG g==; X-IronPort-AV: E=McAfee;i="6600,9927,10974"; a="690079" X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="690079" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 05:35:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="923292" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.246.35.237]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 05:35:23 -0800 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: Thomas Bogendoerfer , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 3/4] MIPS: PCI: Return PCIBIOS_* from tx4927_pci_config_read/write() Date: Mon, 5 Feb 2024 15:34:49 +0200 Message-Id: <20240205133450.5222-4-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240205133450.5222-1-ilpo.jarvinen@linux.intel.com> References: <20240205133450.5222-1-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 pci_ops .read/.write must return PCIBIOS_* codes but tx4927_pci_config_read/write() return -1 when mkaddr() cannot find devfn from the root bus. Return PCIBIOS_DEVICE_NOT_FOUND instead and pass that onward in the call chain instead of overwriting the return value. Signed-off-by: Ilpo Järvinen Reviewed-by: Sergio Paracuellos --- arch/mips/pci/ops-tx4927.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/arch/mips/pci/ops-tx4927.c b/arch/mips/pci/ops-tx4927.c index f7802f100401..4dd8b93985fb 100644 --- a/arch/mips/pci/ops-tx4927.c +++ b/arch/mips/pci/ops-tx4927.c @@ -60,7 +60,7 @@ static int mkaddr(struct pci_bus *bus, unsigned int devfn, int where, { if (bus->parent == NULL && devfn >= PCI_DEVFN(TX4927_PCIC_MAX_DEVNU, 0)) - return -1; + return PCIBIOS_DEVICE_NOT_FOUND; __raw_writel(((bus->number & 0xff) << 0x10) | ((devfn & 0xff) << 0x08) | (where & 0xfc) | (bus->parent ? 1 : 0), @@ -140,10 +140,12 @@ static int tx4927_pci_config_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val) { struct tx4927_pcic_reg __iomem *pcicptr = pci_bus_to_pcicptr(bus); + int ret; - if (mkaddr(bus, devfn, where, pcicptr)) { + ret = mkaddr(bus, devfn, where, pcicptr); + if (ret != PCIBIOS_SUCCESSFUL) { *val = 0xffffffff; - return -1; + return ret; } switch (size) { case 1: @@ -162,9 +164,11 @@ static int tx4927_pci_config_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val) { struct tx4927_pcic_reg __iomem *pcicptr = pci_bus_to_pcicptr(bus); + int ret; - if (mkaddr(bus, devfn, where, pcicptr)) - return -1; + ret = mkaddr(bus, devfn, where, pcicptr); + if (ret != PCIBIOS_SUCCESSFUL) + return ret; switch (size) { case 1: icd_writeb(val, where & 3, pcicptr); From patchwork Mon Feb 5 13:34:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 13545579 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65B4D28E1B; Mon, 5 Feb 2024 13:35:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707140137; cv=none; b=Hj1f2f1LCZPRPRZk8lzZsXN3ZV3zA+JslzCVPzsuQdwjE+eQy8DgJIoR1HvgwHVa1FauB6UhJhv5CV4/Ua7y0wb8Nbmo3YDnaoa+Fx2r8WkFEKSQbjThFcUhTyiyaAgmdBtmQBlqCemFDEQsQEhBRVJki8P9hdW/jzHz6WoCuOU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707140137; c=relaxed/simple; bh=w3ZRuyQJPqlcygfflqUwjB5dmA/ao32uXeZE76jR82g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=o05OHy10fhW+wrCYiuIMh5VVkNDb591WRKtT8miEgKmAbW5iboLx5dJyJztAN1HRKFbwX7QmbqxytjwDTWbCp8EplZ2iDGu+XoMiLvopHMV61wKMnCk5MuosH8dCNy017lwT60eZKLWB4OZTXgdlEqUyyZJen/4VDSvjXDrq538= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=k1g2MzPJ; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="k1g2MzPJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707140136; x=1738676136; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=w3ZRuyQJPqlcygfflqUwjB5dmA/ao32uXeZE76jR82g=; b=k1g2MzPJgPT9UN6EmG5QeXVFGb8i3M94xCGmAHBDHlcdLXHiTScYxEqw YA7fBe3GC8OSUiuepnwNTritQ9YtCHkYz96lXXgWJ/7RuFNA10lSHycZH qiHLYlH8ZPctzFK+5+je03WKOVc3qxYBbUE+BSqGkMR35W9+bbYe+Sigx r/99gV4vil9JzVMDLfCFMSP4S5VdN0R3I2cs/2zienY51LQzJBeGpE8L3 ykSH3qQIDgs3fgT2Qt9ErcE948h5ulAHzuspZpjgHMkzhE5/9xw2bNpOi e5dqII+lmQ0hOmPLK3DbkmKbcCnPb77klvHiHkZ5/i9/GvL2oMLCQpJDV g==; X-IronPort-AV: E=McAfee;i="6600,9927,10974"; a="670979" X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="670979" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 05:35:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10974"; a="933155273" X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="933155273" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.246.35.237]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 05:35:30 -0800 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: Thomas Bogendoerfer , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 4/4] MIPS: TXx9: Use PCI_SET_ERROR_RESPONSE() Date: Mon, 5 Feb 2024 15:34:50 +0200 Message-Id: <20240205133450.5222-5-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240205133450.5222-1-ilpo.jarvinen@linux.intel.com> References: <20240205133450.5222-1-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Instead of literal, PCI error value should be set with PCI_SET_ERROR_RESPONSE(). Use it in tx4927_pci_config_read(). Signed-off-by: Ilpo Järvinen --- arch/mips/pci/ops-tx4927.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/pci/ops-tx4927.c b/arch/mips/pci/ops-tx4927.c index 4dd8b93985fb..2db4938d3c75 100644 --- a/arch/mips/pci/ops-tx4927.c +++ b/arch/mips/pci/ops-tx4927.c @@ -144,7 +144,7 @@ static int tx4927_pci_config_read(struct pci_bus *bus, unsigned int devfn, ret = mkaddr(bus, devfn, where, pcicptr); if (ret != PCIBIOS_SUCCESSFUL) { - *val = 0xffffffff; + PCI_SET_ERROR_RESPONSE(val); return ret; } switch (size) {