From patchwork Tue Feb 6 18:43:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547714 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8295A13FF5 for ; Tue, 6 Feb 2024 18:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245024; cv=none; b=ndDLkYLDxaY68q6PP26BynEsxwnHnlPmp47Q28v3JzL93iiI+P3oaFk7Ski7FtOSjVaAkR6Nj50pzHv9qs5ora6FmuqEVFCqFecvL7ow42sJwnrLpdMlnhg9jaZZyF+Y1WoZidlTergONlUb5LozFctXJdVIjtU7fVrqv8oBS18= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245024; c=relaxed/simple; bh=JX51EYp5JFQZ08l/6cPLk6AJNuyWClVT+Ndq0orY4H0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=e3xB2hCu3Wy/bbzlI8n00fvfufqO7AJ7KUxZXlU6IN+iRH9KSdCKAlqr/pqtq7jm2SApGRgXQBXUzofgfxleNuyj0T9qYeDbktlp3aB1fVD3kMbDezJssf0dJi8rTilsLO/ggQABFpYcLmmOB6yaZvXMX3xPwXCEEPg+YWKSmFk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JDcZZaPl; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JDcZZaPl" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a37721e42feso388697266b.2 for ; Tue, 06 Feb 2024 10:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245021; x=1707849821; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=blk0TwokTQ2HtT8cgpJRO0PrfE8+QaeuA8KuyhDefVY=; b=JDcZZaPlQUjLlzr8/Nw4yL3SRuUFA+6ry6FGxPR4rQxnnAPNM1LfAiFtAsyjajO1Wt AxY+gQzwm5DGF/Bs+3R471zOxrRvV2SMYKumGynttydSboIBTGRJV6SJqTPzQAcFnTvR YXpdmoOyh7RLvfomxkRsF6gH1iOeL10WOjTlkTnJxW11k7LbB8iPTNFbdbu6zsDIJcVt gOxqLbWFk28GoDHyIgpTEZ2Ln0KfnkKvl9vQIuzu+qcdWplmHJj8Hy6P7VDp9pxc4JOO ZFLknmhI73GNUttMf/JbWbNqKW4ci4tuQMNUSIfVGRWPgsH2C8o+wrLrDAjwZQEZAGPk 4oKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245021; x=1707849821; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=blk0TwokTQ2HtT8cgpJRO0PrfE8+QaeuA8KuyhDefVY=; b=RDrpyZURIrtA0dERPIF+ypP3rCqoVV/ueDVtQEd4Mfg0RNFanV3WWHlFEbdoin7xiE htQysh3/hEAmr/G7V1M858X0KhuJnixlTuh+/+GtATt4IiP88C87+WraDYyNYwXXk8n9 6+rTXTRyTuZkGv0pg7YwOURfBGIk/oRorFQ1A/6MszEm4Pw0cWqP7Mo5fWluxDyFCfKw WBsoVe5SNlFxM6bXsePcCFGTLEPaCrge8jILBwIeomxeVrMzYPwp5GMatupcv9jYnzy3 ZcszlskpXNnMXbpuvNg1YCNAC31osNrZCiZar6AdDVU6sd5CKjMXxyG+m8MQpKa8EWgy cweA== X-Gm-Message-State: AOJu0YxQr5DgOdXIjBk/CkdO7ZvJolqrow5l/nDkGpgjsYcV2vEJyTfl eRAASqOzSD/h2Ha+mLhfO+egFjARb+Xzpg5eSQROUeBEDH/DgY79W293L9sAaN0= X-Google-Smtp-Source: AGHT+IEr82lAacnBfHt8DRfg9966ZPB9/VZ880Oe3p92rouzBTCWOB2Wi761RUCK6+EumG0D0uKuBA== X-Received: by 2002:a17:906:a38b:b0:a35:80f1:2ad2 with SMTP id k11-20020a170906a38b00b00a3580f12ad2mr2572332ejz.57.1707245020870; Tue, 06 Feb 2024 10:43:40 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUJg3LkowpnDdk5wwkdLC12A3iAU0UQTFwHAS1GfzgF3sgrKSsi4VAJKEH16+kmjcBb4EVmr0prx6/arJRLLczSq0sRwgTLtcPw7sCb11JXnZDci6mh30BEa+g+ACCwvDHeNBCpe5luurHDPGp0GJ9IKjbc4sIiWaO+cpn+qDkslbniyuIsTXXq4+KF5xH7AwD5OU+djP5iR3W9eS8HpOmOBOhUa3/13og7LR1JKXVnKhv7VA5G9GC2EvOPBVFMsImjjKIypsWKNef8TD5LiKyZQwqyvU2/pTJkjL1sBvXjigotJHFK3bkPo75FdW022zrHsT4t9p5UkIsyVmN7sMN+sioVANhNBsLnyG9rP0e2XGhP1YwK+GqLdiHzA8/Wcv99TQW64YEZNvF6lD3NrnnAECuJT94H9vv6087yzgftDMUo3Iq6Y4nBvS4kVBViEGZcbFL4WfOl Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:40 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:34 +0100 Subject: [PATCH v2 01/18] clk: qcom: reset: Increase max reset delay Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-1-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=566; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=JX51EYp5JFQZ08l/6cPLk6AJNuyWClVT+Ndq0orY4H0=; b=6+OEJKDDzZm/iZUobMp4jbZAc54oYJ1CoK3iwFokuzcx4v8X5vWLaxpMdP3du43t3h0ci3XgM MH4LiFNU4e9CxIKpsFuxWufYshNfVrKcILJgI5cRcn9Z3cGRtK9tX0N X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= u8 limits us to 255 microseconds of delay. Promote the delay variable to u16 to hold bigger values. Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/reset.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/reset.h b/drivers/clk/qcom/reset.h index 9a47c838d9b1..fe0561bf53d4 100644 --- a/drivers/clk/qcom/reset.h +++ b/drivers/clk/qcom/reset.h @@ -11,7 +11,7 @@ struct qcom_reset_map { unsigned int reg; u8 bit; - u8 udelay; + u16 udelay; u32 bitmask; }; From patchwork Tue Feb 6 18:43:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547715 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85A3A134C8 for ; Tue, 6 Feb 2024 18:43:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245025; cv=none; b=HXPauwLfQ2dtHpK2DTTj/8ifksD8ZxK3CA7HfBcFloh7gljAQkxguT2NC3UNy+mVzKRzgpc4F7ntLHqmYtlJB8SN6E0+ntf1/j/5/4UbnStTasyelxPlGF2l/DYprZOdDDJ+Xn8NnDjf2vwkzsJ7NTH1qov5i5ctcU4aE+qoa+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245025; c=relaxed/simple; bh=eVTHPrT2Om77CguELWV9DheT0YsZYlvmQpUZDIbQJew=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VktMhGO8WFbZad85x4qIHFlibxvA2VmFn/CPONCOCiRkLohou8hjbLahLYLyV4UGvV47E5a0N46cpwj4cBvfjKyxgF5OOlFRadl/s5uX+tmeqG22r1SltsOyccyBC+5ZbfSluR0ZExG8O8ae6aseJvsbtZfz/QciG/ajqnXvuOo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=d1nr+2Yw; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="d1nr+2Yw" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a385259f0a5so57460866b.1 for ; Tue, 06 Feb 2024 10:43:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245022; x=1707849822; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xM2C1iHMDXw9CwZlcSXjRB1uc7rC+T3sEjwlxMY+VkA=; b=d1nr+2YwHnbjAZxbYIACIvrQa3Hushxw16qK24cdSyo37se8svev5SnHHjW1tNz5Ml o9bdSNiF4+9uGPSsc0BOyzsiiHrQ5sitdPAkKmQPCKKFem6B7zYP8vLKM4T87TnrwXCK 0o0tkMn5hMKpb0l7OOZfa1K8tDk1iaNvpLsJrFQMIn/6VGhrEKfJnuqK1ke9pDSb+jB5 qrHeStwNV+LHm8uhm84WluNMJNRWEMb6Cb9RWIB7wshBtHgkHnHaVqOajNuV0TeKaU/7 kY+739UO1UDPVIOTooqO8kEHeMzuvoLRXsWduMFeVvIexuZbdcAEon7zbnhrDRmB8Vlu mbKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245022; x=1707849822; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xM2C1iHMDXw9CwZlcSXjRB1uc7rC+T3sEjwlxMY+VkA=; b=i0PX1nDqAAVG9x5EfKDmjDEU3wKetBYF9UIty2MU5HCxtZLWFuro1HbSq6vF5oYnyG oqNUrZDpRYGDuBqEH1YpFgNhruAmOCtG7LszFjhN5+UcYK3GPjnVUb0KHovI+G0vbJLr 7L9CqnMz3cuFBbUwNMsCl6wBx5Qmz/d+vjHSy3FJyEn/9uCMXf+RMaPjTkZklyUWj70o i/Tbx+YpYM74mL3+QuM/lTtbqRVztSel9u/piGJBKihHO+7gI8Uq0ysIDsIswg3p3kmT jy+6/lSmp/D9oLKADl4AmTow69qmxZQI2k7pTY6jvhbE+DQpykppa3vTjjkJkaMtxnlS ByJQ== X-Gm-Message-State: AOJu0YyhLak+JKtfswJQ7iPQkD991Gjo8vC8w1ijIJiMPbqERnr2UQkl QAoBYDKZKSDYonwbYOaUTS7IzGy79Qyc9WXga4OV17sgVmqAUq+Ne8+Ap/zVTqQ= X-Google-Smtp-Source: AGHT+IH2iK/Y23icXwXCpnp6cD01kvobMXN3oGi4oEp+g7RX4ln5paAS4U3jlHLpu42XaCc5V9Wzkw== X-Received: by 2002:a17:906:4e8b:b0:a37:687:275c with SMTP id v11-20020a1709064e8b00b00a370687275cmr3895405eju.20.1707245022012; Tue, 06 Feb 2024 10:43:42 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWM+GgllHBWJ2Etigt3pjbEE3yQWss9rZmqNix9IDfjo96W69+gFfgzX+EoOyxHGK9XyfhotbgkKC/2xK0Rs3ENtxKyU9Rv6N29Q6+UzFrih3srAH//Lf/RoSThaXYcb9SX+7Oj++/Yae6fy5u6ZrpertCdAMcBDia7qcSLrEubBjVSXU3FhCsssN0p6lKBF1fMp1xCZmZhyfG8FoK3FXgHrdBf7vJ7X5G2DxfxbkERILWbIrM84Qkumq1tEx4QcMjIkOVNpKjWBjPoZEUEgQpVmO/ineA+S0p7F7MH/55feTOJpKahEPD3b2OIlT1dlbuyPnC3Tj1hquwYfEYHjPawp6nkr9i6h04jiuswwfBBSu+I1GpZtmb/DoXy5npAupQjn27HGRIKhcnx+liyK6Lk4T/8HshXfewb/2sTER1D/ARMUMDbhLeKQqe/aIREZ8sQ4OadVyDJ Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:41 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:35 +0100 Subject: [PATCH v2 02/18] clk: qcom: reset: Commonize the de/assert functions Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-2-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1957; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=eVTHPrT2Om77CguELWV9DheT0YsZYlvmQpUZDIbQJew=; b=BZQy6EUUZshJ+QDMMiLJvwCLm5SPTPfLO63fDw/6rPwVOSyeW8TZ1Eh0LDNn95U8eLZ0YsW3m AZQz+o8uwqQAtJZdCTKk4N2E5PrOw3bN7o3Qtzw6VTv2nXKOAtbYi7K X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= They do the same thing, except the last argument of the last function call differs. Commonize them. Reviewed-by: Bryan O'Donoghue Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/reset.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/clk/qcom/reset.c b/drivers/clk/qcom/reset.c index e45e32804d2c..20d1d35aaf22 100644 --- a/drivers/clk/qcom/reset.c +++ b/drivers/clk/qcom/reset.c @@ -22,8 +22,8 @@ static int qcom_reset(struct reset_controller_dev *rcdev, unsigned long id) return 0; } -static int -qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id) +static int qcom_reset_set_assert(struct reset_controller_dev *rcdev, + unsigned long id, bool assert) { struct qcom_reset_controller *rst; const struct qcom_reset_map *map; @@ -33,21 +33,17 @@ qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id) map = &rst->reset_map[id]; mask = map->bitmask ? map->bitmask : BIT(map->bit); - return regmap_update_bits(rst->regmap, map->reg, mask, mask); + return regmap_update_bits(rst->regmap, map->reg, mask, assert ? mask : 0); } -static int -qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id) +static int qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id) { - struct qcom_reset_controller *rst; - const struct qcom_reset_map *map; - u32 mask; - - rst = to_qcom_reset_controller(rcdev); - map = &rst->reset_map[id]; - mask = map->bitmask ? map->bitmask : BIT(map->bit); + return qcom_reset_set_assert(rcdev, id, true); +} - return regmap_update_bits(rst->regmap, map->reg, mask, 0); +static int qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id) +{ + return qcom_reset_set_assert(rcdev, id, false); } const struct reset_control_ops qcom_reset_ops = { From patchwork Tue Feb 6 18:43:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547716 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22B9113FE4 for ; Tue, 6 Feb 2024 18:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245027; cv=none; b=JAr1GLi+psrKU7dDcjh0GPGvnusVMuX3ZgrsOdcgcfKYYHHuXPaaEEEzLqwi60S4ejc6i2jteMtB6MM6CGpO6knuoGX524t0ggA7bl/xT6HXjiEIrL/1qwJqBiNwjm5OCOCbFa60az/ObwORYzB8tdJxR0VofUIbKl+Ye3DdO9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245027; c=relaxed/simple; bh=XwCgSZpLR0e1PPyOXyw9iz+BwYBf4ZHexOSsfIVdxQU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Opo4wf17SF185my+N/NaANUv6izLc4qVyE+1evXLneIdEumrYqFMG/vqcFRHxU1a5CKg4cikPljCDMT/jo9pmw7Fin53ziNP47r2JNrsJscIB70SOi1lq5oWrX0Uve4XPdkfB87UEXRbYaxR4b468hBSopf7JLfc94xNT+Kc61A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n88zmfA1; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n88zmfA1" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a2f79e79f0cso172256966b.2 for ; Tue, 06 Feb 2024 10:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245023; x=1707849823; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hvL5qVc53pRM2ItjtrWEvKCgIea1KTM6jFEXiD2pTIk=; b=n88zmfA16tac3dTriWwFjbFeppDs3QCehS3dS9zYc6ISdsqi/+N7kYa8RVdk7PrG3V JHVd+fGdNvr8dYF/b3lZ2LuAvAn6vQ+ISxAHLRd3Td3dIzJCa4/JkqRtftbwRLg93Ja7 ZdS0iL/SaqjeHZcUVj73ubTEbWbev/8mPkFjJjJYDZZgwTOUS8/CzRIjCWEuE1bnBsvG HhJ1G8HZwFmObUd7znj6gCCXlBLzp1qdJijj8flCbLkXXIkTTart4jOJX2RJo9Il2atq ETVk+QWMQ6MzEJp6ZKJg6bhzjoejLap/VGQuG8QSPHKKh6R7C6P/q2fupy8BTqbVHnPN tFgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245023; x=1707849823; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hvL5qVc53pRM2ItjtrWEvKCgIea1KTM6jFEXiD2pTIk=; b=QliSCMlumWUehtq2yOTpqhGCWwri8U1Q9b1MQynq5GCRJOcOHDHn1sbDmgDQmAWMVp ZGBVnfBLvvACCNxeeG2Jaew3e2LbKg+cAU3JCf07LCjDXhPLnU0hPvg4owfTl0tO6bYh 4OwsSDRP5eex+d/9Sm+4r4neA62WG98Ea9APtubwQpLxzPYeEgeycBhqFAYa6LbqPt+X 0hRgVwFddav8Znf9/BmpT899TW52rEjZoPwH4cRNEN6swPoOHW5WDlNFctBjntvhdXt9 59uR0uej4Pa3sDozAUz33wwzlfrHASZiO0ndmNPpm5+MsX4JK+sD8sIKsMqdUe1Mxjg5 wwhA== X-Gm-Message-State: AOJu0YyHE8kMU5FDBzpj9L13VH1Iq893QuuEWyl9kk3Yd7ENmBbtXaXc EntSMjgVwknfkWvkuISJavutRiJbtARLoRKcG0iw6ih/vsXdmMqXQBnaEKBQBdE= X-Google-Smtp-Source: AGHT+IEwcGzkit3UG7RgaJhKZBhIWNsb1zukExW6YjVWP6FLguEvzUDQXDK8pJXm4ibakI9xGX20fA== X-Received: by 2002:a17:906:5290:b0:a31:83a2:463c with SMTP id c16-20020a170906529000b00a3183a2463cmr2821529ejm.34.1707245023306; Tue, 06 Feb 2024 10:43:43 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWzBwgE40NoQJNzoN6JSw4Wjez8/Ag0DcojFpjommyB40AgMlUE/2XqAEx8GzyqQRu0n+Gf6BPPBtw0GJk5JHQhpqnm9wTanHLkqAFGNEu9StIqpimJ3LQ/bh/choLxc9xYvIslXMUyNrY61oIAjPhXTck3pQDC3OFqGLXAFx/TIN6rxWNRnLl80REIXNm+H3LWvFfoHxYHliZ1b9Cd6Z8qWIxWNz28bbjp874R4NzcK4HaJPXy8u14SqljSDsQrMCSy9WfeYwae54IR4lpNeZcjYCgKl0toBqdAzeEWdi5p6i08NE4A/IeL2gwgUisfg5IsdlgXA4KSzvf1vmfsL4BBtBTJbSf5KNssuSrsYrfPg3umt1i6MAG8r11TtQZdMAC35PIbJJgHuTLP0vc/N+7NYdxkR5syNN31BkE+v98az+z1IISEBMTlSD9hRllymVU34Asv/su Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:43 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:36 +0100 Subject: [PATCH v2 03/18] clk: qcom: reset: Ensure write completion on reset de/assertion Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-3-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1253; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=XwCgSZpLR0e1PPyOXyw9iz+BwYBf4ZHexOSsfIVdxQU=; b=Tq60ALVlciDLkdivYsIcmrQF748EJR+pUE1IufXNafFGsZuOAbb9f/rPSAB0nnwQSqzg3qqQb 6l7lLfFExgEDOXPfLnpXb/GSuu3ptYAHeuizJ30cBnCMswdh1J1/Bz5 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Trying to toggle the resets in a rapid fashion can lead to the changes not actually arriving at the clock controller block when we expect them to. This was observed at least on SM8250. Read back the value after regmap_update_bits to ensure write completion. Fixes: db1029814f1f ("clk: qcom: reset: Ensure write completion on reset de/assertion") Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/reset.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/clk/qcom/reset.c b/drivers/clk/qcom/reset.c index 20d1d35aaf22..d96c96a9089f 100644 --- a/drivers/clk/qcom/reset.c +++ b/drivers/clk/qcom/reset.c @@ -33,7 +33,12 @@ static int qcom_reset_set_assert(struct reset_controller_dev *rcdev, map = &rst->reset_map[id]; mask = map->bitmask ? map->bitmask : BIT(map->bit); - return regmap_update_bits(rst->regmap, map->reg, mask, assert ? mask : 0); + regmap_update_bits(rst->regmap, map->reg, mask, assert ? mask : 0); + + /* Read back the register to ensure write completion, ignore the value */ + regmap_read(rst->regmap, map->reg, &mask); + + return 0; } static int qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id) From patchwork Tue Feb 6 18:43:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547717 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 969711429A for ; Tue, 6 Feb 2024 18:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245028; cv=none; b=UdnFp6O6sb6rIHRNzPgPq5fdsI89HlmW4gY9Gw88DFQ7mMPGIetZ6D1RA7LGhJVXkk76b/x/Kjis7D5UQUIPIxnLBpAKlF+KK/oZPA721DQGijcp44YdYmuC8B2L4Czs3/oDHKXiSOzNOLe4xGi3/e9kdC3mH9KODqhu+vl0y3s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245028; c=relaxed/simple; bh=2ewvjxYTFuXfl1Lk2jvUqETAlBjYpSBzSi9qQsmkHxk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=F9M0GONAi39GWkbyXNR6GNY21c/e5Om0LqZ1nYynJu9TOrZeHNTVoh/tGars96w+xmXl0eTyj8OplJj34ZZrlt2r5FB4camSulYbxZY6m0geRzWZzp5jjnpFHmp2BluXhRDsQvJh9jg5ynUEuzVS3KZF0/8nVIaHctrswq1Ubjo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=End6W+xh; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="End6W+xh" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a29c4bbb2f4so722620266b.1 for ; Tue, 06 Feb 2024 10:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245025; x=1707849825; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dRc/E0OawVy3KfCwkARwDXGHPJlfd3wz1+hpXwWRbNA=; b=End6W+xhX+zx39ngK8pw2qUApKR87qcgEyIZPB75a5yPbh0JB5QXSrzzdC2jUCr50T 3cCnhTX3bWRHR/DVFGDw5vgjUcPgutk8hyvz6NYz7f4mET/o4MXM0XJFNjoixZnrLG+9 4A+utrNWyctwkOjzBbdKp+PV25sF/2HV+d+HBhxDWfIOchnUbyy/5dHGv7wgt9x0SAe2 Ev6l2GSMD4YaXpSZJKWIuUeo7DEPCEcv478+lc+lXBkZZ7VdyUYSd41uvwe0+nNc5YXp HkGtpWDmbz47Zg98dLXAcfD/sOt2eR7nTDaa/y0n2gKgPoXHCXgyXYx3J+5bXuh1/k/1 V7Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245025; x=1707849825; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dRc/E0OawVy3KfCwkARwDXGHPJlfd3wz1+hpXwWRbNA=; b=CLpiRL80awaveiXL7V89OFUG/Vzo8V7ql6f5gLmD2QsrqJOz206jDkGCBin5BNBn/2 hqhUad2NlBPFvrYUrC2VOTRfOpo9k7lD/9U67JSPhmG6OC4TRebygxfeQlWAcoFT/c2x uXlF09qzDzNWvyz7iEbQSzEQIEeoN3DaX7Ib/hZDT/uxFdcK1c1BpZPGgtNOQmO7agzB lEoPOxbp1i4bdJcHCu1yk1AEUIvVqK96WSW2iU1olgtzTwOKI2Yev5oxOHtEj5DIZxwp +kvU7FRXFub+3fr2qBwRJSqH1VUGXAX4dA3/eY/xTiFiEKxx0Q3Hd9432eOI1YKis3WP +WmQ== X-Gm-Message-State: AOJu0YxGtZp2Qf5SxakzAa3ude8plUsg5R4CZYB7CZ/8Z3fVs6tZKTLY aEyGp/fWeoSpLWMuehC8edw/39TCMiJCXfHAXtuboSCwsmkqiicb/+bQ3nczlrM= X-Google-Smtp-Source: AGHT+IEuh/uUEPdWaT2fIuS+vpCG1uskuLnlNHg7EXttq5ew2eUrcb2WVhzyOPtQaX4We1zaIyIh8A== X-Received: by 2002:a17:906:2406:b0:a35:db4d:2ca9 with SMTP id z6-20020a170906240600b00a35db4d2ca9mr2471868eja.31.1707245024772; Tue, 06 Feb 2024 10:43:44 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWHt/dJgv5sbPXb9J6mG/1MeMQMplcgRfmAdpw8nwakHXqNLySlCcH81Dqz/4/dogrLyEvgORqLM2wi2HO7YiH2dzk3SuFZJeHZuqgrNdn4ADuSjd7qZgB5Seou3er0TylcmUrwA2PlN1IDwxRcbt+ppMw/w3thsfXwWx2SZa/kfShVIEJLqj439bVMKkQNUDAibiIKE/DjJn1fWOqjyW+UaILLUQJu7QHBHpxercLtrIt6NfFI1+ieXmlTzDkA8z/JcwX1mD0noiLpHvA9R3EftAfypdm2FvFukD+8vEbrbZdRrchnYVQQHGeFPvN4qGWBL+tgYyaoOpRGTOPQSoqr61H4Ry3xJ4etDGvnThhRmEX4C/ReY2kYH0kl44HEMdCVvkgYeRInMrRa37i4QpFmMoLrKhsN4cN/q7joN3mgYjY0VIyqvYV+B8T4Lw31mjlHcKaRvFuy Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:44 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:37 +0100 Subject: [PATCH v2 04/18] clk: qcom: gcc-sa8775p: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-4-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1260; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=2ewvjxYTFuXfl1Lk2jvUqETAlBjYpSBzSi9qQsmkHxk=; b=VbGIar/lFUsTjvxoVehzAI4eFVsChuq7EXlEbINw1h434cIzmQKmAg/btzj43o7pVDOBsC9gF zxk5PY27uN3B4kD++FhXbv/oR36QzECTS99e2XgpyqvXhuKiMI8f6EM X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value was obtained on a best-guess basis: msm-5.4 being the base kernel for this SoC and 8775 being generally close to 8350 which is known to require a higher delay [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/commit/dfe241edf23daf3c1ccbb79b02798965123fad98 Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sa8775p.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sa8775p.c b/drivers/clk/qcom/gcc-sa8775p.c index 8171d23c96e6..c2b403cb6301 100644 --- a/drivers/clk/qcom/gcc-sa8775p.c +++ b/drivers/clk/qcom/gcc-sa8775p.c @@ -4662,8 +4662,8 @@ static const struct qcom_reset_map gcc_sa8775p_resets[] = { [GCC_USB3UNIPHY_PHY_MP0_BCR] = { 0x5c020 }, [GCC_USB3UNIPHY_PHY_MP1_BCR] = { 0x5c024 }, [GCC_USB_PHY_CFG_AHB2PHY_BCR] = { 0x76000 }, - [GCC_VIDEO_AXI0_CLK_ARES] = { 0x34014, 2 }, - [GCC_VIDEO_AXI1_CLK_ARES] = { 0x3401c, 2 }, + [GCC_VIDEO_AXI0_CLK_ARES] = { .reg = 0x34014, .bit = 2, .udelay = 400 }, + [GCC_VIDEO_AXI1_CLK_ARES] = { .reg = 0x3401c, .bit = 2, .udelay = 400 }, [GCC_VIDEO_BCR] = { 0x34000 }, }; From patchwork Tue Feb 6 18:43:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547718 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA59314F64 for ; Tue, 6 Feb 2024 18:43:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245029; cv=none; b=eCgm0Ctsl0Lkqc03/uiNboF7iT0Ejh1jpWiNBzJvLv54teq+lJi0w113t7DOLC6TwIFNTJbAOTPWn3X6Aoq8u8kKQMIsxvTXt0P0zM/z5vcfyZsrXIOqsheTMegZFKqZyFMd226onLYl+TU0VuajeAurKYjx4idIrpQDWrNlWG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245029; c=relaxed/simple; bh=xI8Pz/GiLYIx99t2tjsSwt/3C03sZIdZzmRztviEUeI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wd+YXCCi/XDjN41DP7C4uLAXvcxPiz3N1PYpPUqsClhSXduVE2b+cWLNJl1kdRtl/EXsZLa2ACO6TzRDdd+Fb41Hjv2oj0FLE2KwlPrEcRtjnut2SWzw5Q1vn2IbRRKr6DctQt9WRApxwnLQ8hrfUcajYaYyZOac0ah2Z8peKq4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Kr6FWYwV; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Kr6FWYwV" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a38291dbe65so104886966b.3 for ; Tue, 06 Feb 2024 10:43:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245026; x=1707849826; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dAa8E9ANX6Nu3efVaQVeq8bdKbITl5R3NB9pzT3L0B4=; b=Kr6FWYwVs5sqK4a8s7pXdKeguyAmPS1LoroSGHC2SQFsBhV0Tg+npVlcyb8uzS6b/I pvBWfjzZ4lHKTn4ATbTg8PVOq2UM2ghEqSnnNNmjoOC6BJbPN5iFfFR6ud7RQzmgHZ3E IU32uSYfT8Nds81/7JPeGdvpbgwPUHoAU66Wgb4YWr7BCUyJkKNsXOKvB9tqSW16+JgW i+41m775RFu8JDs8Hex6i17872QSGaExNbcGvNIhMxKQgSQ74CG4KKHy5OHLCd7ACJdS v9C9rslISjyEwHV5F031J5OU3aJwZ9d5RNz6wAjgRGISYZ0zTSzBlRebdzpjkOl1+mUy DhUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245026; x=1707849826; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dAa8E9ANX6Nu3efVaQVeq8bdKbITl5R3NB9pzT3L0B4=; b=nfS3LmiR51ly3aavVvXHie/rxOdC66noeJoJqIgE0MRCxDZt/cGCDiL+TqI5bDHlhG sNrXztoMBqRA1QGhhYV0QrpaE+RmjfUvKsl22Hjv44V5DIaP4/T5PXXHHhNFVRyRz5Ai mhg5b6k1zN8YhKGBgQka3JgTeMfmfqHDh81ftyT9lL0oKm/KZkd0r+Q2H1SHZpuDfaG5 SK7T/oO/Y3EXiRYIEPVTsCo0SvuiOUyuzKIQP0U26ulh6/89PCOe2xIdMn0Drt5+YdvN XsOJ2Xrd+6smBjf+oqvHkJ4t2WE6JfkfRokRHRLYwK8lNt+cQE0x0JO/XL4ZU+kvKjBk cV4w== X-Gm-Message-State: AOJu0Yz1GPHpQK5L7HIcvafdQfg9COCStQhBr8O+WwhMdmuuJDk1waok NT3H8AAdXZnISgj3WoEBS0jAtfBKzF2ULyhnJMLSFZ72KteYw37rOKbj743/Qcw= X-Google-Smtp-Source: AGHT+IHFPjKbAz5P4i4tT0GMpAj5TQXxO8zp22PMieudmKvyJB0rPn0WlcyQcFE0y30rsoOB57vrCg== X-Received: by 2002:a17:906:5a49:b0:a37:78f1:1302 with SMTP id my9-20020a1709065a4900b00a3778f11302mr2015332ejc.70.1707245026190; Tue, 06 Feb 2024 10:43:46 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVtQhPkko9kgb74rZc6QzMcRvtf8zXA8mdt+YXjWJCnvKVadM8Oj1izAu++D0nXjyNZxY6zCPuM30srknTZFOiIcU5YdtHxGRwKmgP8OtRjwRHlVmqOvZHN69LHnPcHR+yTZMTx5KPqrpRauO2g05QH/SSGmBtIXlmYFmJC6iWBbLQjOqDQ9WUbC5w/QA3VmXoFImO1p0f5LycoJLczspAhhpQ9xZFoE73qOm67OiI4f3TdXXNDZQqoJ+7lX5uvLbO/t29GytAfgZ6RWb5VFlzW4uVLvLL5zhBbnVla2qkaaC/rD9YBxcqHAFIubs0SLsExq1eD1CQ0Dju0HUhOX3rOcnEeT7HYLm9WA1/6TfMHwCvpF1XqtUIvfsoiUpZtlyAoStvpTiDCU/N3PoqvZMzxxzESIY9VZozNzRQBTCs2m4w4ikV+Jraw0LoRsM23nufgv1UIYfMc Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:45 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:38 +0100 Subject: [PATCH v2 05/18] clk: qcom: gcc-sc8180x: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-5-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1320; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=xI8Pz/GiLYIx99t2tjsSwt/3C03sZIdZzmRztviEUeI=; b=BvYvh8VMtDO2ojSwG6EKKNmDTPNM3CZ//jLbMYVFrd3SBxGrYeb/ueF4t1pd5ecykCt8iau/5 9hisTvNIiAxDNbTWDlWASMXLvySnJwy3jHdwAkpruTaQCgqRVqYWI17 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value was obtained by referencing the msm-4.19 driver, which uses a single value for all platforms [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/blob/LA.UM.9.15.c26/msm/vidc/hfi_common.c?ref_type=heads#L3662-3663 Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sc8180x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc8180x.c b/drivers/clk/qcom/gcc-sc8180x.c index ae2147381559..1351c52bcacb 100644 --- a/drivers/clk/qcom/gcc-sc8180x.c +++ b/drivers/clk/qcom/gcc-sc8180x.c @@ -4528,9 +4528,9 @@ static const struct qcom_reset_map gcc_sc8180x_resets[] = { [GCC_USB30_PRIM_BCR] = { 0xf000 }, [GCC_USB30_SEC_BCR] = { 0x10000 }, [GCC_USB_PHY_CFG_AHB2PHY_BCR] = { 0x6a000 }, - [GCC_VIDEO_AXIC_CLK_BCR] = { 0xb02c, 2 }, - [GCC_VIDEO_AXI0_CLK_BCR] = { 0xb024, 2 }, - [GCC_VIDEO_AXI1_CLK_BCR] = { 0xb028, 2 }, + [GCC_VIDEO_AXIC_CLK_BCR] = { .reg = 0xb02c, .bit = 2, .udelay = 150 }, + [GCC_VIDEO_AXI0_CLK_BCR] = { .reg = 0xb024, .bit = 2, .udelay = 150 }, + [GCC_VIDEO_AXI1_CLK_BCR] = { .reg = 0xb028, .bit = 2, .udelay = 150 }, }; static struct gdsc *gcc_sc8180x_gdscs[] = { From patchwork Tue Feb 6 18:43:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547719 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 840B7175AE for ; Tue, 6 Feb 2024 18:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245031; cv=none; b=UqTWQi5wOEM/blPVx7m7/rM8s1U+uw/CozcUoMKX4gVem9ZmPYyfVC8g0O0/qo7cpEGrV6wAVeJdoz8Lc+jKpAZwgvM7YN1e7ek/1gqR6tghtM0PcMRXG6U1ymbTYWSUN+TBfzTB+39vTiITKs0czlodDADrSMTzDYN0C/UoVS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245031; c=relaxed/simple; bh=cYbItYW2hueTIMDZ5ErUB7KsJqgkLUBYpnYuLwK48bo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TO2Q/HCpzcObn/NFaEggUdqK6eE5R1sCLdeAvZYzQDeq70hinXXhQC1EQu6L9P4C55uPPBG7ZYw4RoGiA4H49gHdnvCHzgxYS8N/JZ3QNfb1smb0suD2Cscu84nsSB62uiLEsuIDxHxZ1ZCTY4Dh1UPBWhsoP/rmEPWRXQhSN0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xX9qjImQ; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xX9qjImQ" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-51025cafb51so8849958e87.2 for ; Tue, 06 Feb 2024 10:43:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245027; x=1707849827; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lJKRPokuZG9Shr1HCLUQ2NfmjznI2k78hzHx2xJmuZY=; b=xX9qjImQhpe8/9E60DMD14VQwWWr16qkOy38owYEaJQ8MyVsHSkCiiucC1+6/Q3DgP lb5iKrV7j9F2bfsOH5zF2GWaDbCgEXOa/KG78U2/1JhLrR7FBe+rxIrnJncTNlxf9yu0 uW/d5eUcQPElTGPeHtzfplbArTC145olVm8Xl0KRJiXK6rU3rWianplmM0TnzI31ghr5 vzcHvg9xCeysM421hgZhVf6Y9COmzIhDO2jBMgF725Uu4BPdFAylAQywp15iPtDX0e/x msHawMBA6iqx4r6JWU1bnCXmDzQmyLSCh0RKCaOvhKBKj2GyhMHRhVoIafp6O42NxSxU BOGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245027; x=1707849827; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lJKRPokuZG9Shr1HCLUQ2NfmjznI2k78hzHx2xJmuZY=; b=vBE0mYusFyywLw2HeE9i57adAuQsbURWKpPVhm9dPuZNSQHGkxsGTYZ292us00KPud MVtG8ct6ZRImD9WXyCJXLHX4/h+nwzJVcrHOfVzx+L90Ur/lQ3wVT+5p2oQwtjAlG/3i H8H4/oA2+Z6ReKwNM1PBfUtY1UABh43lnChNUWFh7paBu9Ku6aeLAZvNh4x7pUDdR1HQ /Iwl4d9tHOaHhP1MRNFGTo+LPbkcYo1m/RrGlbcDibA4nAOAWn1YAaazu+1KpN7lBmuT TzT9YwCpO95RJIG0P8H3AMbW3WHwiPCmS1HAIR2UlAwibi9+nCteHMeswWQG3teYNsL7 WK7A== X-Gm-Message-State: AOJu0YxZeqsJ/85Fcba32W24CTsToFveolvRq/kqB+kuObiVvva3TY7F 1BVYmdQRJP1UySCjDkzMvdjAKlTHcmFPbC3Op/OK9/2JfO4zuS5sLlc41spoBzI= X-Google-Smtp-Source: AGHT+IGIFUIRo+PA7YF57GnuCMh0z4jEYdINS8CLn+9cxEIJBnfRs4FcndJeS1BGByLuS1+qncg+Hw== X-Received: by 2002:a05:6512:e89:b0:511:3ef3:cbc8 with SMTP id bi9-20020a0565120e8900b005113ef3cbc8mr2719942lfb.42.1707245027586; Tue, 06 Feb 2024 10:43:47 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVpdOisAfJ33Wxu+kdkaTbQq7mSdvuw1kPTzMAJqP0SZzPBGoAivXtdVkEGmok5eGaKGlkymgMH+8RmB5xaeAWTYt+afaw2CpcO5Ql18X4HGZDdB3N7fv1RzPa1hpWErlyKAK7ftoBQVGGphkPoAGYQBSxVrd0nYQrbIGC+Oel20s8dZr7B4jT2McFrt8cKI+b8e1Y5LN9Ap/IWBRg9WlvpKV+tPWY1SI3K43xCFytfMU7lm28iOgj/v57y7aAUzTZoK3tIBe6DoWk4C1l7Y1Bc9BKo8aQVro1+Cknd4DtpMwlJOkAhj1veizrdBq60wqtCbxIAOprZP/MWeMKRNm8qbA0xlbHaXdIb/1eF+ulgBefiV4KaK4L4eubR5mbyVU/rhys0zga5Zu6jLz9hUI0HWlObRjXHfmElLJGkE5Cz8HkjN0RoElc6OHPm4FVDjzH/VT6lLjEd Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:47 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:39 +0100 Subject: [PATCH v2 06/18] clk: qcom: gcc-sc8280xp: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-6-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1264; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=cYbItYW2hueTIMDZ5ErUB7KsJqgkLUBYpnYuLwK48bo=; b=9wxflDm24MJVJvHCAenQNJMU7vt8sE50cxRtDntg30mLNIvc3fQjxlQ8h52Ml/4aRIMhCSRjR mVvL7NXaRc/Bfyb2cmfGNs7XhTkSilxhKjxir1CyKLalI31hwTBt24k X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value was obtained on a best-guess basis: msm-5.4 being the base kernel for this SoC and 8280 being generally close to 8350 which is known to require a higher delay [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/commit/dfe241edf23daf3c1ccbb79b02798965123fad98 Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sc8280xp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c index bfb77931e868..9f4db815688c 100644 --- a/drivers/clk/qcom/gcc-sc8280xp.c +++ b/drivers/clk/qcom/gcc-sc8280xp.c @@ -7448,8 +7448,8 @@ static const struct qcom_reset_map gcc_sc8280xp_resets[] = { [GCC_USB4PHY_PHY_PRIM_BCR] = { 0x4a004 }, [GCC_USB_PHY_CFG_AHB2PHY_BCR] = { 0x6a000 }, [GCC_VIDEO_BCR] = { 0x28000 }, - [GCC_VIDEO_AXI0_CLK_ARES] = { 0x28010, 2 }, - [GCC_VIDEO_AXI1_CLK_ARES] = { 0x28018, 2 }, + [GCC_VIDEO_AXI0_CLK_ARES] = { .reg = 0x28010, .bit = 2, .udelay = 400 }, + [GCC_VIDEO_AXI1_CLK_ARES] = { .reg = 0x28018, .bit = 2, .udelay = 400 }, }; static struct gdsc *gcc_sc8280xp_gdscs[] = { From patchwork Tue Feb 6 18:43:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547720 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 238F1179BE for ; Tue, 6 Feb 2024 18:43:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245032; cv=none; b=D1pJb9ez565tiMlh11JVX1IXdo9rgtyJWdK1cN/tta/dKW2Hy3wPzW+nyUeFub1OgCj8rfigiBcwlJ0HdqG1BkxAodEWrt7T5F1T+jc9VbY+Bdo/CYJcLMwT/ZrzgTZc0TQlV1iEIGviqyRmvKp8InX7QuhqYBP/P62/++kIAZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245032; c=relaxed/simple; bh=hNpPMHDWoOMTbeDBm7it/X/QFrunF620Ewnj+Kcxsr8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hICdGUPb6it/mjLJJXwyzU7nJgfHInuo3LZ35xagFvQ4OU1Ok3w0ThJOmhODRkDlJTar8Ji69Etv3+2cUo2009ssXIUM37v9DpwuYOmd5wvKh/nYAXd1SXzvnHJU4rmjQWzIchShlITRJJi97j/MeXpfKISnyyKfoE4l/1JfFEY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VBF1Oxfs; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VBF1Oxfs" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a381df83113so104500466b.3 for ; Tue, 06 Feb 2024 10:43:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245029; x=1707849829; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hFLeZhpqcgOrxTzkmGltLeTXQrsN6KbONLIWDW0T9iY=; b=VBF1OxfsTAZ7I6JwNsA5G0KGrEGF/ZjPGh+u9ofkYg48jaHkeOjm4ZT6mY/dAJu3Ne igJXx6zY9FLhcB9IAKEHDow8HdeHPniVU4F2Bm5y5cNYCoK5eo7qaknl7KWnIXuZzs+3 R2whsdfivPGPEeGW78OWQ6BEtLu7c+Gpicda2ZP8Di78c0zxxgSk82ua4suahVJBcAyW uTJHbEb1z/7HiF1XSu3cUHWMzuXATaCX2Mv8+iS6EyWR4wiEB0eX6tyZJf7S5Odr6HUO wLbVYZBeXWC1zPJZN3nGIh66/n8ZA74ZtJSjvZQdBsuUqDre+Y7fxfy860XJhXJgHM0z UhPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245029; x=1707849829; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hFLeZhpqcgOrxTzkmGltLeTXQrsN6KbONLIWDW0T9iY=; b=EpoYg0lJLbOJm5Pic+5DUbblUlVl0J+cTOwpBrqF53kiD66YN+0BM7/HOEUqBTqRh/ /kXMhcxhFHshdH1/1oeffegYl2w2uCz1Ltc7VyjTnwIAbbllrkvS12Fbu3s9Oa6ODwaY Qj9Xpoxvq+Rc75R7Nftwa1EvdS4SHoksD87AOXDC1EsKkWJsALDYwOpzAzL+ePZj+/A7 qE0ZbVlLESQRX785/KqpFxacA38QWgA3p0jqWv34xTtQ8kgvr6csSWVTUFV9H7ezn8/s hbKjvWXOA3t3i89d1BuNdv3lKlv0Q69fPgeVAHHjGwANPf/tFjiw8UCHtjaeZOiseHeX /v/Q== X-Gm-Message-State: AOJu0YyFHV8nIlrVk4TbXM87BS1LaYI2ovHi/3neUgvT2eEGh4Ta0sgH nsLeACrJl+GGj0OKK94rfkOtVHzNfbfwsox9rmyzr4Sbtv7YDVt5o3V2YF9i02g= X-Google-Smtp-Source: AGHT+IF8EUkiN6qPS1bLyCZevmsZyN3xOU7aEzLiG6w+ePDJ86YOkZa5vMlvYh2u9l1VfKYCWCoSMw== X-Received: by 2002:a17:907:7f17:b0:a37:7fb9:ea27 with SMTP id qf23-20020a1709077f1700b00a377fb9ea27mr3179350ejc.48.1707245029517; Tue, 06 Feb 2024 10:43:49 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCW0n4Idf82KqAzmo0iSS++sV2ROsgmaZfsqrWdGdQk9b2xQ+KNJt4Me0nbSIf+EaEBIlFiSxezbLEojrXI58VIG/Y74yez+aVr84ErxAVJaHJExcwbnZPXpHu1HVC8V1Wi6yG1h5BwCUg7ktuVo4SjQ3kB+xX71jAzHfjjCbydWjLgTIaXUbP2cAxziPqmOqjahxqNBzJD4KzvvgzzTEOYcOpjBmmmlS7tUYhNFHBdI66dTdVBteTE1mgwKxWeAziTz/XP/UrUXSY2mNBEZJxr5/L/LsWS6FNmMEDy2ZO4+ClPY6OqPqc2Eje7DBYlxe9pEARk2srG69aO3T56kP3eGgml3VE4A4k809TZyYentAxjLLZnABwxXsJ0sKyeBHvzmwhDaQsvECxIv8YkNgSKTd5mH9YyAgxF5j4t5A0OJYuvrNddcQBtvlp0Km+XCoMQf03QX5tT0 Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:49 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:40 +0100 Subject: [PATCH v2 07/18] clk: qcom: gcc-sm4450: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-7-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1261; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=hNpPMHDWoOMTbeDBm7it/X/QFrunF620Ewnj+Kcxsr8=; b=f80sDBRtJTlp1b8hWBFK0RU641PLMr6/l0nYv4kIqYmXYXY/Ih5z96kTOSuNVwy0TeNwqWR4Y wKfAWeK3ETFCYzaP10y2a7Xyuby63Ix93i6/cFDuCx1GtLfJ4K3pHN2 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value was obtained on a best-guess basis: msm-5.4 being the base kernel for this SoC and 4450 being somewhat close to 8350 which is known to require a higher delay [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/commit/dfe241edf23daf3c1ccbb79b02798965123fad98 Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm4450.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm4450.c b/drivers/clk/qcom/gcc-sm4450.c index 31abe2775fc8..ab8fb77d15a2 100644 --- a/drivers/clk/qcom/gcc-sm4450.c +++ b/drivers/clk/qcom/gcc-sm4450.c @@ -2791,8 +2791,8 @@ static const struct qcom_reset_map gcc_sm4450_resets[] = { [GCC_VENUS_BCR] = { 0xb601c }, [GCC_VIDEO_BCR] = { 0x42000 }, [GCC_VIDEO_VENUS_BCR] = { 0xb6000 }, - [GCC_VENUS_CTL_AXI_CLK_ARES] = { 0x4201c, 2 }, - [GCC_VIDEO_VENUS_CTL_CLK_ARES] = { 0xb6038, 2 }, + [GCC_VENUS_CTL_AXI_CLK_ARES] = { .reg = 0x4201c, .bit = 2, .udelay = 400 }, + [GCC_VIDEO_VENUS_CTL_CLK_ARES] = { .reg = 0xb6038, .bit = 2, .udelay = 400 }, }; static const struct clk_rcg_dfs_data gcc_dfs_clocks[] = { From patchwork Tue Feb 6 18:43:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547721 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7E6F18641 for ; Tue, 6 Feb 2024 18:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245034; cv=none; b=EMeg/gBvUvOOpyQBfJExcF0Fyh05NSJDowNm4PCpQ6dmJprZEBCkpThnXjVKaRUrqCHd+LeeYRF/isUuGUvCUKVefHaywQmGU9dnBvSv5WCfy1Tg2SkKLYbmhMUQYQyq1GyWgfqdX9ngba7aXWwfxM3pX2p3Geisj4A+4hmQ4MU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245034; c=relaxed/simple; bh=EXwKkMgBsd8MhiHSlPwnGXPooFCi9B6+ZF9m99buTKM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=guK0yz0U/vQwzMbcIadv8Eynh81DRvvyb+Oqq6sw9Yc2+seJfJZXzl7rtiX2gIOo/Z0csPnuWrKThLn3sdBk8DRdRutNmhf+2PTTLJciObY1XQhqaaiscPHTfbKkIkqxL88IW/EhaMhhKhjuiqJiZdRqzj7O0uv6Y0UIxsj2BB4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zcED3LfK; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zcED3LfK" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a3566c0309fso729925166b.1 for ; Tue, 06 Feb 2024 10:43:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245031; x=1707849831; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Rt7VV0Ge1sC3yLt62kaXgrxl4JcnOpSTrN15pKlZhq4=; b=zcED3LfKRNHgGI+xAuGGM/Rj52WvA4O9WC7K4+HYfPUbjg51eM3smZBuVD4JRY3vDM AWCGNwgtigG9YTcElv9ShdtwiF8DK7mPLi12TjRlyeIDxIRpIFVYgkzW6rfRriqiXs1x CQV5NNDIrg9Jmq3pob9YNOSK5jRJnYujKDQmaNHMcILCrYhQQnX5kvMXX6+v3Iqr9L9c Ce87c0/gyov013hOaHI3iaJafLuuRY/CjJhbWQFTtuyz3hQ30jU0gHg7qg0KzLPnmIy6 9ScJfzBhUvuyAFHxcSxjBNc/rcf0WgA7f70RyLv7nVO37L5bqOHCjhwW2p1zezIkmrST y1XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245031; x=1707849831; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rt7VV0Ge1sC3yLt62kaXgrxl4JcnOpSTrN15pKlZhq4=; b=KtQLEFH7+AZoOIUyIyE5HOy93u4ttaz/dWlFjzgK9PPW6cw83lK/L7oM8yEuJfjBZT VGOxN3/1cearZTWmsBKFlnYGSfeaow2LiKMLF4gf+rfKY1giaGVAjF2J8uvAZn+K1swH Fhz/qFIaGIvWyMcq0fMiJ0dZE7JxrGhNgjuoUedOEdPo28MtJhbfY7GY8c2nkQgHRwXJ y/E6nOt5fkbGcTpYqcbn9OHlz4KbtZB/drKYD8o88eSanJ9ywGH5N+OvBcbGOV1OA+Z3 7KLIwuzc8k8iVuZeGPoNiR4QpNKV6VyMvQD4l0axYYs3C2ePvsS7FoPkPeVBi3MT9YSi 4qog== X-Gm-Message-State: AOJu0Ywj7xnJfZoB4oOh24I7lP6GMrBkNSpSvPSsxou/H/vrPGEGh9W/ cfhgKgUmMujVyVN+P2mdws7+l23XiYfQyu3C2VsauQO30ihckCcBNUPZeRRorso= X-Google-Smtp-Source: AGHT+IGLfPHIcth7V1P8PHbajyViGTDYG4qmty2wAY9eOATHRzTNHZtvs1iVdBf+F24UxgSsQgLcxg== X-Received: by 2002:a17:906:191:b0:a38:53df:4c5d with SMTP id 17-20020a170906019100b00a3853df4c5dmr556223ejb.34.1707245031242; Tue, 06 Feb 2024 10:43:51 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVHrf5Y2GiDBabUY+/8vt4kdCuTVp1aDu+19FnW5BYlpFBCOQEcJdG9Ji5bo2AXr7jcBJYiBt3NNLv4roYU2UTqkXfgnZyiDIdlM62GxPp+gesRznRiJg5x5loFV3tkulS4hMb/UP6zMhwmDeXakAibCSsI1FMt2VPJJqo+h7foAZdUB0Qa/mAopZEFSh1SrXz2EtkMy325uRh79nvNMCIyRhnacAa8W2wZ1+n+QcHdVkeLm40ITmRtUQU9dxLWZot4d52YcH8GWJdSAzmrm9pONdyBIxlNKLdjV4UDZm+HKvt121wXxe4pCad1pUZCDSzXzm3m+EUnmtoX8jT/ZykkXMiiGZm0p6SoyvK/EDWBYBxjV2ziF4WrEILR21IWFf+oh9WXRNqPKmLzjHYgKBVOLYfgB/LX2BmAGnIeY4NnzUbdpZ+wxZIgrcZqRPtWaThYixyRX6U8 Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:50 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:41 +0100 Subject: [PATCH v2 08/18] clk: qcom: gcc-sm7150: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-8-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1091; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=EXwKkMgBsd8MhiHSlPwnGXPooFCi9B6+ZF9m99buTKM=; b=5v2USoyqmz+31QwL5rklkv0hk80+UpMpJDRSY6WqLzqv1L+b6x6kof5JtwD1gvITaGLk1Q1Bn UF2KxonNmu3DCGXVaEhn5mnHhFxkmTUBqcgxevSC2cboEDLKEmDAwDO X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value was obtained by referencing the msm-4.14/19 driver, which uses a single value for all platforms [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/blob/LA.UM.9.15.c26/msm/vidc/hfi_common.c?ref_type=heads#L3662-3663 Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm7150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-sm7150.c b/drivers/clk/qcom/gcc-sm7150.c index d9983bb27475..7c5596331c30 100644 --- a/drivers/clk/qcom/gcc-sm7150.c +++ b/drivers/clk/qcom/gcc-sm7150.c @@ -2918,7 +2918,7 @@ static const struct qcom_reset_map gcc_sm7150_resets[] = { [GCC_USB3_PHY_PRIM_BCR] = { 0x50000 }, [GCC_USB3_PHY_SEC_BCR] = { 0x5000c }, [GCC_QUSB2PHY_PRIM_BCR] = { 0x26000 }, - [GCC_VIDEO_AXI_CLK_BCR] = { 0xb01c, 2 }, + [GCC_VIDEO_AXI_CLK_BCR] = { .reg = 0xb01c, .bit = 2, .udelay = 150 }, }; static const struct clk_rcg_dfs_data gcc_sm7150_dfs_desc[] = { From patchwork Tue Feb 6 18:43:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547722 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2CC517BA0 for ; Tue, 6 Feb 2024 18:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245036; cv=none; b=pV1RvbHfw5wc/3YWDlWTWi49GxbKR/xEt/kVuYXKzaj53yNsxYKIRgdKfq1PJJ8mAzYiubdj1SnZYB1NSWxkZPHhl62qLQMfRa3Yebr2HTxGLSnj9SmUW6QdGeiBEpQeBtmxpLuEAFo2PLEfNSdyicwAfFkmU6f7d69nNdTSug4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245036; c=relaxed/simple; bh=Um3XHTCPqPzKjXY4QlaL0lzOw9Adn3IKIs6tquKWAGg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LdMk+VLCTpIJVyg+YDGp7+/yRUPMfCp3GHXC3h7IURB881ZgU83UwhmlA3qOC20cFDtfnVQxPqfu3H9W1NwG/3vkuT8E5WFGFdm514JTSqRGwVmx/kd+b5aVxqtHTOgTlQC5fUh84Z1MPhe2HXfXkfhcAq0qq791FM9niu0YYdc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HMZonAVv; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HMZonAVv" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a380a1fa56fso171158866b.0 for ; Tue, 06 Feb 2024 10:43:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245033; x=1707849833; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sx2jWOy3+mcft3g2k461xAsra2Zzmr6pjNDzJKoJgMQ=; b=HMZonAVvSxziRwXXY2E77c9gtJKwpXLP48NaGhCN7hA0onOURTAN/QeNJm7l1ddRgD 6Clj3GNKFBkxJVmCZ7HX0biBdWQmstEgCSrF6WM84OT+1Tt5WyyGqmcEeVApUUbDJ+je rBMAj0qjSkS1xD3WJZKhudwGKtI35Y6in1TlRonDyMj7VZt5HXhMSGbSsOotsrzKDpdX OOucltMXx5/qy6cmSw6UX98kzU4XXWfTnuzD0fX/bTMtKIZf0sJmAHstNjfSyCNMLsjM zRGXruXzhMuW7pb55yCuGzOzDXnlunghr/q1eURriMdkGKDuNnutJx0PJx5sAgtO6H/4 Xx2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245033; x=1707849833; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sx2jWOy3+mcft3g2k461xAsra2Zzmr6pjNDzJKoJgMQ=; b=NL4MOIz0HOThuTMItA7McIXRIMk/0GtSX5t9hVHpBGxqVPv4q+ZoFvuzmnD9QzNt5H 4WfdkWQWPIc61QDilYgJrnUjaViLvsdzKiRzjJRV89BJL91+yt8wSVix8Q8ZXrTXtfvq RD6Og8hTGcry/aNJvJlGACAg+oVDsBR4i9hA5fUbmAlpmWLs/fjTGytRzgOnlaXbS9kV iO+qLNNPd5fZ27eGg3lofBCsD/yZq3ZiSC9qCLf0PoXKc1GOLhpEz8xvJcMf2kGzINM2 UOUhDj8Xy0zveOLKpApguj6hVKFJNH8y2cvkmDPKu7s/vnCgAyhHicHZjGC0zNE9Aq2j YwBg== X-Gm-Message-State: AOJu0YxJmhC4aBfkys09MY4MHCppLJZPSHxhbRE1nMGvN7yTsNEN0JCi fZGGVop+ZIVCI7cu4sBVm4DCzLLmJ5ZLcUYLVwT9RuJJThcj2vRPhEtPEDONDDc= X-Google-Smtp-Source: AGHT+IHdgIMDLE+qw3jwrHAaomcUMXOC4b2jvJ1Pc5h7C6eE7EE+S7xI2quLCslWdMEmJbGAs3+Usg== X-Received: by 2002:a17:906:4e8b:b0:a37:687:275c with SMTP id v11-20020a1709064e8b00b00a370687275cmr3895790eju.20.1707245033098; Tue, 06 Feb 2024 10:43:53 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWf0xsvKto8gDTOhhkvQRLi+YvCUaDUUyZbwlbZTXzQ8pksP0S6iOjf7HSmedSdJerkcvnapbXfIgNEQD2dzCLKV3Q1IjjCemsiuN5p56++qSGgNmQEjffa4dNgdP4ACUDSTG+jm8g87jmkHTNy9qYiJHn9/FNgXvXQVr8/rx3L3Jfd/o0sgzur5xLR0mfmNeV9NdLSWaGXSU1FKbLBJoyn2Ekk9jpYgRfgWZDOj2O4tfrDOt9nTwCG6VjcHZl9OXe7DFeQirdiji2YSGJc1gIsgGBYfwWmc8jSnoUWU80RD6EfQppGNXUEaPK1A1tMJksq9tNYK8R4yrel8uEY+POcoZcUmVCv/BNUEIEhPCHFVemqS+M1LRdeoem8CuK2xIfPF94WTc3sByFGNDcfM8/SUmt2xOxxImStOsFbG7uLEFo0fF7gXKzPrXj8gB3XbXbP1yLHeL8M Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:52 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:42 +0100 Subject: [PATCH v2 09/18] clk: qcom: gcc-sm8250: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-9-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1210; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Um3XHTCPqPzKjXY4QlaL0lzOw9Adn3IKIs6tquKWAGg=; b=V/zN5DGxKHRNUqW9xIcpmoQbVyk8TUrsM4Bgad0H4xzD6h7GzxAQn+4hIs0phzgj6rlmWZ0lo PAG4qSv/eiqBe/BhYdE93BqftCEUl87uipHK2YVu2f+fyyqH44SPhlT X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value was obtained by referencing the msm-4.19 driver, which uses a single value for all platforms [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/blob/LA.UM.9.15.c26/msm/vidc/hfi_common.c?ref_type=heads#L3662-3663 Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8250.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c index c6c5261264f1..61d01d4c379b 100644 --- a/drivers/clk/qcom/gcc-sm8250.c +++ b/drivers/clk/qcom/gcc-sm8250.c @@ -3576,8 +3576,8 @@ static const struct qcom_reset_map gcc_sm8250_resets[] = { [GCC_USB3PHY_PHY_PRIM_BCR] = { 0x50004 }, [GCC_USB3PHY_PHY_SEC_BCR] = { 0x50010 }, [GCC_USB_PHY_CFG_AHB2PHY_BCR] = { 0x6a000 }, - [GCC_VIDEO_AXI0_CLK_ARES] = { 0xb024, 2 }, - [GCC_VIDEO_AXI1_CLK_ARES] = { 0xb028, 2 }, + [GCC_VIDEO_AXI0_CLK_ARES] = { 0xb024, .bit = 2, .udelay = 150 }, + [GCC_VIDEO_AXI1_CLK_ARES] = { 0xb028, .bit = 2, .udelay = 150 }, }; static const struct clk_rcg_dfs_data gcc_dfs_clocks[] = { From patchwork Tue Feb 6 18:43:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547723 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B4251B806 for ; Tue, 6 Feb 2024 18:43:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245037; cv=none; b=PfiMeohrmwBcxMIB33yscnXq33Na9QP7h3VJpHtoXk2EIYs+25fd/cVl+2Ab/xdhhl8PqO3TopvVQ6yPZt/KQbWwXxTAWDEaFS4qcwGX7X5hRGNRhXY7VBxy8c863A0nJBXOsPLar6u+/RwUh0/znTCb5NdpqHxX9kz37xFERDU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245037; c=relaxed/simple; bh=7ZxBeTpI7rU3/jGQrGYsBGxNSFTwMdNCV6VkV77JbJc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Hs7XXTlvg90AcMxfnbySc03+SOYPK2twuFYvfJ8uKg7EAcLGQhHX9umR3HlRZNIuEAd1OvWoWxxAcuGEFkxUp3If5rNpBd675679eCml2GLrDwpSlnD72lNCCQrxB3r1OQsrVV6wO3YOaIOKYXOiX0SMD7a+5CchDdn94ZdlY+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=U8YB1/Sb; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U8YB1/Sb" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-560c696ccffso407151a12.1 for ; Tue, 06 Feb 2024 10:43:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245034; x=1707849834; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6JFIAAu62FuQn/HSZ5tKqmYhrMc0VqNnJVz9VNDCrjM=; b=U8YB1/SbcajaNo6MtJJPaP7bx7DCjn0g02KnCGkLTRlmLFQHGLcWP2BRhMXZfH2Tnw TG66AM7XS9/oxglXwdq2uyM714U5w3OmMoGsO2938GynQeUBPFFdTjkybPy3yfO+s8Bs UbSXSAW/OFkO5cuUl6chYgoteaBmCFKFK7Oog5ik5w/OwZ5F5hl5pSMswmShMyuCFCqo mu9T/JJqvf2V/xd0FUCX4HmNTwE+nICu1YugobOn6RUiBremDZDh6oflwcprncmeHBBG QfVbtUGKY+csQe7jhEBiuwONOHoW7RHJKEs1Tz9gFHmo65Mf2s9YNNkSlu4MQvVhpMHH ZxpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245034; x=1707849834; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6JFIAAu62FuQn/HSZ5tKqmYhrMc0VqNnJVz9VNDCrjM=; b=hahUUTB6f8ALTaqC9+SyCAYoZa1MfbdvKO6zaIiRCKJU0lCIMOzmyLhwxhSEmvdZK1 893+2E+2aaWuHou++e4ROTQk3GhRGKoBEMzXBveBktro1yyUIzhdedJbMwc1Xq0g75ea PW3DX7xg3MG799nBfWEAuCnnD5TEn4CAiTypM1lOoqyqH3px5qqCHIWORfAZX7m4qR3a RLROOl1s6j+HCKs3fisIpMM0m8kcFUY56UDBGhxlcYUQGDN4DnpldkvMJmtj1NaNo62b b5ksm6JO2U1a6BpezSFPFfzgzh0Y/XYFHDlD89H1t/fWKDlNbcoj8uoregeKW2toetkC DnVw== X-Gm-Message-State: AOJu0YzMgPdPb1d611ty78JpsWqkp/quxqr+IvCQi87rTmhIbOZoh+E4 lfLN4zceqpr7QFrhqJM6IwjGjwNeeDNxfsLFrlMVlnRt4reVEtadbtN8LVYk06s= X-Google-Smtp-Source: AGHT+IFRnU7S9WuINV3NhaAKT2gjDWTwPGpFeNX4WG2QF1077VknapVFzp8zFOquS5VGWgaguqZCwg== X-Received: by 2002:a17:906:3297:b0:a35:b59c:fc04 with SMTP id 23-20020a170906329700b00a35b59cfc04mr3562614ejw.25.1707245034391; Tue, 06 Feb 2024 10:43:54 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCU3GW7DesvZfeZqzLXJ9bmcXbGuiNMy3LJq+VOD/cMGEPUlLtDY/ddOTJAliMHrcBDDAz2a6vd0Iij1ilRqUNdnK4nToxkPvOM2ID/b67mvZbZvKnSObM7cwpHAvnAUX2QwJ6AVvoV4q4PNRXNqD3ZAbpBWrCzoc9uhCY9uuzufzopIF7Pwri/sIspnjvVXd0Fmc2I0pfIgeYj0Jv22+T+oFO9p03oqvCLgpJ5LRLOIU+pvv15CuSAqna0R87VuBdR7R21jlXfGHAdbXEbeEfVh/9b61KoQjNHA33HhjYBkSXBPlZEMATZ7Nt+jSnD/V7vsH0sNLCBRLVVtlS3w9pdh6tJKLrEuEExVL4rftP3DQqIgdlP88q9AdPoxmSX6pB5FcF3jdCRRHSh8kAx4+MHEWn93+DiQKqI5NbFn9FUHGTMWPlIDHtQQ6Cq4BQwik+5GlUJRVcew Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:54 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:43 +0100 Subject: [PATCH v2 10/18] clk: qcom: gcc-sm8350: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-10-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1113; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=7ZxBeTpI7rU3/jGQrGYsBGxNSFTwMdNCV6VkV77JbJc=; b=IjZM3jN5XHZrj5wc5iXTiZuKe8lstZqNruPJ13n3kYfjb61cQtY0BWSyA+c4+SNxU5Z59zsEl FFlmLMVgijVBk9qV7fgkaVVVDBpl/9tfRtod4o1RKlRwx1jwkHM0HHx X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value is known for SM8350, see [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/commit/dfe241edf23daf3c1ccbb79b02798965123fad98 Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8350.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8350.c b/drivers/clk/qcom/gcc-sm8350.c index 1385a98eb3bb..df4842588a24 100644 --- a/drivers/clk/qcom/gcc-sm8350.c +++ b/drivers/clk/qcom/gcc-sm8350.c @@ -3743,8 +3743,8 @@ static const struct qcom_reset_map gcc_sm8350_resets[] = { [GCC_USB3PHY_PHY_PRIM_BCR] = { 0x50004 }, [GCC_USB3PHY_PHY_SEC_BCR] = { 0x50010 }, [GCC_USB_PHY_CFG_AHB2PHY_BCR] = { 0x6a000 }, - [GCC_VIDEO_AXI0_CLK_ARES] = { 0x28010, 2 }, - [GCC_VIDEO_AXI1_CLK_ARES] = { 0x28018, 2 }, + [GCC_VIDEO_AXI0_CLK_ARES] = { .reg = 0x28010, .bit = 2, .udelay = 400 }, + [GCC_VIDEO_AXI1_CLK_ARES] = { .reg = 0x28018, .bit = 2, .udelay = 400 }, [GCC_VIDEO_BCR] = { 0x28000 }, }; From patchwork Tue Feb 6 18:43:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547724 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3DD1B945 for ; Tue, 6 Feb 2024 18:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245039; cv=none; b=qhEm2SgcH8cO6KpqLVIV19wtUpmgcCTXErYw4ily0+DS1fYeH5wgX8KF85yG2KtHZMc9ffb+kjest/93eLxoB8VyJwpgt5g9AT5je0NovQEVdg55bOD7Krm4m100uUp/ug1c7BjBwcxUVLxNLySXeSHGOSyxesnD5tNI+pZSYxs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245039; c=relaxed/simple; bh=MVwKMyl639pfSSp12W8ZsSkDXB3e+0oIGZYQAcJEWn4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sBwtdMRIazGeETI9dlnFoE0iXe+JHovzz4JAjF66y40VtgMqtSfWZ1tBEg+Pwg8FIhj9Rv54+LSTq4BkuENJ9rPcEHdu5d1ZyU7FxMKSOpPVrmUx31D2gg/6FvN9XAvUDpYpk9qJ+9IddVVtJQGRduw+BlmSKPNuCibEtCqcZtM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=euIvd72z; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="euIvd72z" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a38392b9917so104697466b.1 for ; Tue, 06 Feb 2024 10:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245035; x=1707849835; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B1iY3/5e1vVwTp9GAkTk6iF085CLAD1vcMZhFA07ufA=; b=euIvd72z37mvmr7a2/GiUUpDaQ9nvm6BKImV/VSX/V4h5tHIxf6vFgBqhIeKOi3JLW WDHZH4MjORqjEUEz8XjGkLcQ0m6ZL+q/73kx8JbxkoeZDwHUzVK5oMEHcF8Pg95tad+J /f0y/Fm5vRQtuROxH0QqvGJxxdGbf3SGuchvvpFKYIafQKPY/z2o2dZWQPkdz8t1jx4V B89Ri6oZMnIXA4yUvLIuMXBUyNQYZ9E085dLKAEN4uoWbkyAEwvRbJId9I8179r37L1F 3Ea+kF7/q4ivfX7c2W9/XJCt4utVBq5P/TVFcWXh8jZ84RZtvkQi9ZqAjy5VkI+2+gaM GK5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245035; x=1707849835; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B1iY3/5e1vVwTp9GAkTk6iF085CLAD1vcMZhFA07ufA=; b=Ft6BO8TMK3fnNatHIynoQbOZ+N6CZCzxAcxHQPCR4dfA6UThP4xUbeDlwp33GKH1dU SKFtuZgUWp9PUDdgbUNuzES3275xiYK7KdcvnJISeMjPpoMcR9b/zNEHfVbcQZ97IL6U GH9egO/xaqG9qW+xvomOYPrwr7BOiqKs+EEDTQF4zjBpOiG7cxLTgo3rnI9q8ib492pA g7fvm3KF6gzBhE7zmZV72Qfqz1LDWm/TKpvFr2UadwwN6jm5pjPtPzHun9ayS3H8PG2m c4hniG6F3WCSPoTMsDu12LxvsaFi4UZjyU1uN9mFiu//VIPEVEg7oFpEvZ/gGaZB59vH Ikrw== X-Gm-Message-State: AOJu0YxSJYyAPZl9JVdd1Hn2W66KSHChUZhdH3MKYH5b15bNVEf1zEUN +BGItk6lvc4P/uyKa5be5l9m+CbV6TVDm1kTHgoEh2Ahi3i85IQZs3fLOzOZ+uc= X-Google-Smtp-Source: AGHT+IFXZnNdvjQhBhhzhvuBB7qAUVEaTm2wSqzeYCTFnPSXWnZYiFNDajN85a53sow3DUCPDc6nGw== X-Received: by 2002:a17:906:5ad4:b0:a37:b795:264d with SMTP id x20-20020a1709065ad400b00a37b795264dmr2605624ejs.57.1707245035596; Tue, 06 Feb 2024 10:43:55 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWMjlpNtix6mgvC3tfpf/8y/JqEIom7qxcpy55JwHa4+w4vvKy2LExr5+HSHQlm/nxjrAdoWIX135smiu6gYZVJigacTT/0S8yp7xSMspA2Bi7RjjSnIvcR6uw5Z4ynP27YM7RNhgjBDN98vXjygJW61PcX7MqbHfct2W4Mb4BUJzJFMOfWvZ5gf7OTrDmJesx69f78MDgou9fS39CeowLJvQJIO9SRokW083rA6J4DGtwI7Hm5jYlthgPJ1jwptHUyX7eIeGlo/+3NOMdW2Z6AV47R5V7xorYnuwzUEZ8pqNpMk+qH65ZMk0iMqs6yFm4zDXCdO/PsE4qusQri7Y4Lo/q9IlRjZsj4KETuMWBkcZuXp+lwSS7ihea7Xp7kxpXfFeySjWSyUD2+3Xk92zYD6Fc/nT2IekKyJWYoby5/21XWSlhySdxc40Retexm/uJHyTWiPwLg Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:55 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:44 +0100 Subject: [PATCH v2 11/18] clk: qcom: gcc-sm8450: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-11-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1115; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=MVwKMyl639pfSSp12W8ZsSkDXB3e+0oIGZYQAcJEWn4=; b=WzApI+i5HPCSE0QP9FS1c4W2SGt6W8PgU1ss9ttY5Ud4sBM4SP+FzyQ+ZJnXqTpM3AZyRIN7e aQQNJissTeNASVyp8/0xSbNXuTmCUQi8VVR6PhVlJREXkKx962v1QBC X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value is known for SM8450, see [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/commit/d0730ea5867264ee50b793f6700eb6a376ddcbbb Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8450.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c index 563542982551..1825b3456dd0 100644 --- a/drivers/clk/qcom/gcc-sm8450.c +++ b/drivers/clk/qcom/gcc-sm8450.c @@ -3202,8 +3202,8 @@ static const struct qcom_reset_map gcc_sm8450_resets[] = { [GCC_USB3PHY_PHY_PRIM_BCR] = { 0x60004 }, [GCC_USB3PHY_PHY_SEC_BCR] = { 0x60010 }, [GCC_USB_PHY_CFG_AHB2PHY_BCR] = { 0x7a000 }, - [GCC_VIDEO_AXI0_CLK_ARES] = { 0x42018, 2 }, - [GCC_VIDEO_AXI1_CLK_ARES] = { 0x42020, 2 }, + [GCC_VIDEO_AXI0_CLK_ARES] = { .reg = 0x42018, .bit = 2, .udelay = 1000 }, + [GCC_VIDEO_AXI1_CLK_ARES] = { .reg = 0x42020, .bit = 2, .udelay = 1000 }, [GCC_VIDEO_BCR] = { 0x42000 }, }; From patchwork Tue Feb 6 18:43:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547725 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77EBA1B963 for ; Tue, 6 Feb 2024 18:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245041; cv=none; b=K6tVqORPQoSyv/Jktd5mCNAFfN+4MKGGKb2FU+LZBJp6G3P6FutSLGgHnZUcBkS065fG0ZHHQr5MHxxJzu/dBlQL43W6KYTSbqgMd5t93W69s1xcVv3Di48x0GlZiK5NW3Fi+l0DD6fSv0gxbt/oYntPkV0ix9OQn/yfg4vxfMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245041; c=relaxed/simple; bh=Wzt1u2nUXpu17TbhBAtUYSKbvWX7vxBCCMtjsfpido0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kaygn0towAHMO+OG05M+VBiNRdNL/BOaVO/2ZzUpEVGCcj35lXJoUrIavCzCvzkAhLLP1gW9ePnX+j+mBB6ipH47hNmHfC1s/glJgdiFhCwAUdxJ7dWWAevo7cDvpPIDRtvrp1kkJ+k0Dw5flypIWTOb29j7AWZaEXK1/7vCIgw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pGFSScWQ; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pGFSScWQ" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a37878ac4f4so349913166b.2 for ; Tue, 06 Feb 2024 10:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245037; x=1707849837; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JeqI4K6XpkMUVEuF0Qf5K9m4XIcii/fSlxfZsb36s+Q=; b=pGFSScWQsTUKJdYa+KHIZKth++r9izSrK876oy6C1iZkDjXkIW/DUL8ISm2F01Uz+7 hCQ7EX9+JSHMf0GRBEbX7Z7pfxoEqu9r3lxvwoWnG3jRmqMzu20pReQ9eWlnCDbZnqmg wY9zjWQ7D5bcnWZPKdPW1WN/a9GzQeOLGR6LBgS3WwqqtBILH6Ot5SbG8EM5dBMHSPzp xmPYZYc8h+baJgW0Peh8Pp62ccLEb0btRLjG0hcobNyq2wQhHochNzK46Q4Pl24WwQ/6 vzxyKtnRbfSY0/aZyl8dFp54BQH4DYIKBMHQpyjqx5PYZMI1nAzE+abewHcViV2tbqB8 t16A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245037; x=1707849837; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JeqI4K6XpkMUVEuF0Qf5K9m4XIcii/fSlxfZsb36s+Q=; b=PB/nTQBT3QJnvZRukHn67T5GoIGlH1tlKXT0DWjLyNwcbi32NYFM9Zm/k25Yx/qdFk xXBncQwhJmxglkRykhykbFTHM9qiEZLca4BTUJgnKTasSPTRp4yVIVUURd7dbgPMaTTJ yswdSe+yu/rdN19tHRopGX3IVcePiI0J+G/SQXia6Ix9EoVsK0o/+BVcx+Qb8t5RHsRx zpGT14yTkQb4mPvO3mhZWeKK+j/OxAJw9i2rsRko3L5UX5ezpinxZsBnPVMUS+jFBCUr 8IzsDmwqqpvecpInnu70dAln7u7v0o/iQfMsDPR5nn5qczICGleY+f+VTPxdhY6j91qi fiTQ== X-Gm-Message-State: AOJu0Yx0TdmrAOD8ToWqhMe6t7Fjbh0utRYbIxz0IMCag+xdx0FyuBQX 9G3x+ZajUHK+/VRfBda8Yvnsimjt16e1Q4P71UHKFKYgCESSomz+pfYSrvu/6+w= X-Google-Smtp-Source: AGHT+IE0Bcbl4ouGIaXw6lKWZbbmLrV6tznq5JI5cVJtPSd87CRzvk4Xxe/3TXXMAHSmP4E5058j9g== X-Received: by 2002:a17:906:e2da:b0:a37:3922:8838 with SMTP id gr26-20020a170906e2da00b00a3739228838mr2607142ejb.70.1707245036907; Tue, 06 Feb 2024 10:43:56 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWC3CrpRdnOTKl6LZR3TO+z2rNAi33UNYzq1ERwr1E+mbAMT6IehWKF4IEyvQIMeAiAh4WYKdgnIvJbdotgTZYi8iWdksvaoCHkvvh1c+WWfcgc6/0K7r0Ie9G69G4GRvPcu8IjW60+gPwQNIHvbcoJB5edBjNN7hOlNHmbniw8X/KUgQyM+aKyXxGhJK9EmetSufi5DVWjeCDuoT0UUo13DRq9Bi72ZxVctwMzi0Yivje2k+Iault+gFAVM//eJQLhT//udlWXP7fswIVqPVzb2+zB55nsJ6LxPzaiJE+rfBBYu8RG59PBpU/J0HykFjneT0s9tOYOWJn6BPTSTj7J82mwzwU9/WtUmIWpztlcjAOg6V+dc0royuHqZ1laROdzR9+nszzUBA1zeyYVh0wLeqFwQOUut20SGKUTJihe6wkDQvkkln7kpk/QlX2xKHx/fD44Gf89 Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:56 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:45 +0100 Subject: [PATCH v2 12/18] clk: qcom: gcc-sm8550: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-12-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1016; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Wzt1u2nUXpu17TbhBAtUYSKbvWX7vxBCCMtjsfpido0=; b=DcjLxfc2Cefhlse0tnRH627Hek7w2VYLS5W5OTY42IWK6t0FXg4QEljQv5cx8usNri2oN4Lv0 3lWhm18CbCxBHx8445DKFDmvq4sppy1LA9N/b6BLwI4eabVQtfAv8VS X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value for SM8550 is known and extracted from the msm-5.15 driver. Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8550.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8550.c b/drivers/clk/qcom/gcc-sm8550.c index b883dffe5f7a..4cbc728f5c72 100644 --- a/drivers/clk/qcom/gcc-sm8550.c +++ b/drivers/clk/qcom/gcc-sm8550.c @@ -3276,8 +3276,8 @@ static const struct qcom_reset_map gcc_sm8550_resets[] = { [GCC_USB3PHY_PHY_PRIM_BCR] = { 0x50004 }, [GCC_USB3PHY_PHY_SEC_BCR] = { 0x50010 }, [GCC_USB_PHY_CFG_AHB2PHY_BCR] = { 0x6a000 }, - [GCC_VIDEO_AXI0_CLK_ARES] = { 0x32018, 2 }, - [GCC_VIDEO_AXI1_CLK_ARES] = { 0x32024, 2 }, + [GCC_VIDEO_AXI0_CLK_ARES] = { .reg = 0x32018, .bit = 2, .udelay = 1000 }, + [GCC_VIDEO_AXI1_CLK_ARES] = { .reg = 0x32024, .bit = 2, .udelay = 1000 }, [GCC_VIDEO_BCR] = { 0x32000 }, }; From patchwork Tue Feb 6 18:43:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547726 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EED021BDED for ; Tue, 6 Feb 2024 18:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245041; cv=none; b=blTbFoHxQ9ktPQ2SuHppEruxjT9eLiXuem3gAdguxUUT+PmcuYDTdxJ6YAkT1TtCigudpaXhYMFtFeMOQ/qe/0Bfg0eKuAhovkbGLzJbo7KpxMfVLjrVBnkxdI6E9OX+wIZaThg/dTCY2LuUMcBV6WuOfWoj4dRdwzSUbRDIxf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245041; c=relaxed/simple; bh=8KOUxxHlTkggQTw7pN3WXloq1WdTnUWQp8JLscQ7fqE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jR0yUMV7F+ZR+MIba5H/ioIyhod9xxpU2JOPfWU7iF9ljh3SUT4ToPp3jOWUqUEfB0hk3ti1yl2OyisrfQgCdUPpF5QbNhLnyzwzNKZznhYjPY8lIJWA4JIvoAbA1osKygcL3IDsxt2gqKsApogFqz93PnQLAEI/SZWHNRFOqkA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BDvSG3ht; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BDvSG3ht" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a380c98e824so164343166b.2 for ; Tue, 06 Feb 2024 10:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245038; x=1707849838; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NKzZAHgHTdg4BbNqiHqVVtnjbyCumYhOTEucfxgTrIw=; b=BDvSG3htV++/trWPPvgIPCvOpvquduoUWmpWZZjvevEw4/Q9dlGofCPWF0zU105y2N S1QNbmqbSboYeU3x0SKUZZg5nHhCY4qiii/MsWsvnDqntQ0jwR++jw4g6uFyS2R159fk 73H2uiqQ7AnvmKcprGgq7Z9vTGdPR0n+JJ4HaW07J/nBGqDq16qqIleltqQt4wbqNsXZ EjLWSc5HP6ichJqvZDYnyb61I3aF4bEMkh0WpgH/nVec97R1M+zj4wvDl5r+KPze3rMC YFj44hvtThJZHG7nM7D+uwI7/qE2arZd5SmWUQBD3TLDs1+qtyJBpm/aKi5h4kCYHZMd 6MIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245038; x=1707849838; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NKzZAHgHTdg4BbNqiHqVVtnjbyCumYhOTEucfxgTrIw=; b=ZRNV9jZd2Nkc4JirORI1kaG44G4Uq5HGnH0g/z2OSfm2GEZjjqn7ypsRzEtI1M/Rok Cwhe0SB/7oBoOVlKu2fGwUfR+5H8hhPOP0w+P7VTXL60o65M409BYqvmbAFN07CQvNyD MGhdZ1USlpWKwiFN485s2E3IutSUz5n8pOy8u7sBR2y4bc///8OD4xgcS6MkaHHoG677 tQkvmzgRn5N0j8LCba/g2xWbDkzwU3azTgobl5ho0XlyPOFWn9N14xCURA+HgwVgW2M7 is3bvnyb4ltaMxcaoONaIHaTt1+xCdOntZ/XE4ObsZS+93vHr6lfi8VkfdYwRLXAj+70 Z6IQ== X-Gm-Message-State: AOJu0Yw9Tcn+yZMfojQXa38NH1N1EU068f4zaZdw2w30bEYmgDnpmOKp fKD/8ICQBZtyHvjEWvN5w8gkmeOoTqG5TVZYdEamo8pDIYMC4TtwVJGeOB+iSm0= X-Google-Smtp-Source: AGHT+IEpxaqbXk/sCzajWJj1TSeZlTVEf+GgKyUNCFgxhTbHZQMVybKGhSkVSF50B6HQQh9UUw/G5w== X-Received: by 2002:a17:906:6acf:b0:a36:c353:952e with SMTP id q15-20020a1709066acf00b00a36c353952emr2677030ejs.41.1707245038414; Tue, 06 Feb 2024 10:43:58 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXNXsO2PoV0ZOcB7JTVIQvy680ITZXlBp7AmI9t5ymHnrrKMbUlXoqwCaNG0kQgk3RjxPJTgqoV5tRcCDwRRxQJBiLgBwvKo8VmdfoIBRP0Fp/5sVtAy06KldUaGyeEGELtSB95e1cVTMmYa521RO6u7uTXxPZapPCSKPaokxVJF84odL3XLAMCYLnM7siXsAs0M68Qf3evIG9D3F3Fr9VOo9Mr1STvixzR7YJLyQX9RXEZkF//Mao99kDUsYlq9C9xLV2DWWubZzYzpkQqDA4Vf7EbysNDWPmS95CMCDEBIxlVBhmN9y1baDRSnA1bJlfSi5Lykbh46WbJQPy5IcStjhGEMfSlT2aj96phzfDfBQNcKhb8WgrMEpL/H/6M7BqfBBG16jelpW4x0rJOebUWHriVVhH97+wVm7JBGOvBxUXg6z2JGoTRZQkMCP8GS5pIqFpZmVfA Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:58 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:46 +0100 Subject: [PATCH v2 13/18] clk: qcom: gcc-sm8650: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-13-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1017; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=8KOUxxHlTkggQTw7pN3WXloq1WdTnUWQp8JLscQ7fqE=; b=y9cwir5KB6HgBFeoRBqgqFEwRDH0tpnirUD7O5WzDrrGFcovKkl6Ndal6mmD10FwERgIQAyvR 12wa8gOU6loCmR5UvcOT5Bz8D3paNH3ZrNaQMM7EnCvt+AP7Ts9U+n3 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The Venus hw on 8650 is similar to the one on 8550, follow its requirements. Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8650.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8650.c b/drivers/clk/qcom/gcc-sm8650.c index 9174dd82308c..63becb03cd90 100644 --- a/drivers/clk/qcom/gcc-sm8650.c +++ b/drivers/clk/qcom/gcc-sm8650.c @@ -3734,8 +3734,8 @@ static const struct qcom_reset_map gcc_sm8650_resets[] = { [GCC_USB3_PHY_SEC_BCR] = { 0x5000c }, [GCC_USB3PHY_PHY_PRIM_BCR] = { 0x50004 }, [GCC_USB3PHY_PHY_SEC_BCR] = { 0x50010 }, - [GCC_VIDEO_AXI0_CLK_ARES] = { 0x32018, 2 }, - [GCC_VIDEO_AXI1_CLK_ARES] = { 0x32024, 2 }, + [GCC_VIDEO_AXI0_CLK_ARES] = { .reg = 0x32018, .bit = 2, .udelay = 1000 }, + [GCC_VIDEO_AXI1_CLK_ARES] = { .reg = 0x32024, .bit = 2, .udelay = 1000 }, [GCC_VIDEO_BCR] = { 0x32000 }, }; From patchwork Tue Feb 6 18:43:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547727 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1CB11C2A1 for ; Tue, 6 Feb 2024 18:44:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245043; cv=none; b=cfltAJaxFMi+3E6ysfx67bkravI2GXCtDgNKrb8WY3bY9+poNuyaZM3MdMcmwTpK7n+l7dSkF3SAwdkQBwbTSncG1Z3u3OsuKUJK0Z8joYa+wAL2do5rx+8kgUpRHDZlNq51EnsmFXwsEIudDitf4kZqWUDlisgWgPBI0eGg8IQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245043; c=relaxed/simple; bh=z0UvCR3eA/Pj02vuX/VE6kFABcANNusSJTpXlxREtE4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WqCkZ7EbdQvjxFRITS78/0fRTAAyj6ccfaKZL2q/CthHPVex4+nGd7QlS4ZJ3bZ9FlE3DIFPnaH6sn15Nv7sSxR0QCWISTpoMIWFezfB6+obrbTT3VIbCMp96FpkMKoXq38eAJZTepDiXWjRkapSX3ha3dkaB8qf18WgtcdGQiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kSNUn91d; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kSNUn91d" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a380a1fa56fso171176766b.0 for ; Tue, 06 Feb 2024 10:44:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245040; x=1707849840; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LTXMySSjM+TB9gHsIW2sZkrPWRgmdi9eib/Lrz67hao=; b=kSNUn91dCfpEHeuLWtzAYRP5N8N8b+NAYs3JHKfhb39UtLfNuoMDWm1untJxj4NW1x XLxZP9wv7I7FVfmgyvGOrOZcT5LqMenORW/YH9Lwfe2PGSUXkMZBqeU3WpESAaexhBSv dbbt0m7wXqrM3vZOp9JSgF4NHNmzG77RDXMbJuonlUH7UejWO2B/Pabate51LyNKCX0u SltzUj8tEZCt/00fc8mbnhxH9BMaXDVs+3QzSBt2Nc4C/iFF0jKlarksVsLneL/PY352 rUbd2l2iJZgt6ICegjRdO9naF/rMvbG1VGc3VzdXzLRVJcpZYZWBoSk+wvqxWM8ctcWn UKMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245040; x=1707849840; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LTXMySSjM+TB9gHsIW2sZkrPWRgmdi9eib/Lrz67hao=; b=HVFjykgQahKEbRA6W7RDdAvNJL6OhcmXZExhSNqrO+jL4qOpFiemEYpxofui2Ohh+s K3h+8j+5BWi7kVEuh9l/WeB4MOc7tzpcuj849j0pzbPR25Gtx/hJ6Nhz0qk/6ktDLwLG pMFwPmy3jLQa5ze+Kq8bfKuy1H5Dj38giN8dKL5HEMqD9fKp7w5cpqWrsfiXyGwgnXBe ZPwPEGBoAhLT46cXAS0nrsgpASdYRDD1IfwBWaW363/w6SGcVgyLENEcKYL2sNjBBzhn iirPh24vYvZxTLFC1LfF7seabWkxf1mXNr0FEkyfVnjk+S+tusp0tlBjLkojpP6boiGb wRAA== X-Gm-Message-State: AOJu0YzibrJLzp0lMTugWFXoz4YLcmrSxSZ8f9qv7TkddTXNilmSBg/q 26lUQwENszcPnk+OavTwTrOgsGwUcw8d4uSOmrbtxHm4tgG+oVKl2RIXJpO/7dQ= X-Google-Smtp-Source: AGHT+IG5uMZMjX6h98nWMSRbSnIRSsKQ1Wi2SXVTsg+zAzkQdsMS+ErVE14TEWkjRXRbhkktBGBIrA== X-Received: by 2002:a17:906:c102:b0:a38:32bc:bd24 with SMTP id do2-20020a170906c10200b00a3832bcbd24mr2260583ejc.36.1707245039950; Tue, 06 Feb 2024 10:43:59 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXhJSLgRrI+1tJO3R6fUdpSrGmCCIZjRlWz0bKqd1nMxD0oU17TOtxCG2zSkg1xGhZXlOZZTY/pHtkj89aemRURa4JINJndaRyzFAk3Iz8CKv/HwC6pMM8jqgDFpqn7+SS08a6mDmjymWE2uAlySAs8FwFMZzNNDsZkJemMydczdJNORe+U/aOKuuyak+rPW/FZVCCE+D8Kd7T5v6lTijQI9JbYZ4ziSJrhoH5t35VLbJuIkChisoOUt1O4dMMyw+ByzLXHgp1L4GiMelP7BgoYSKJ735TA+tUXPxEW+cNoqTbhaLxkGI9cweCAVy+zhgpnJl6MOKkD20CDaR8z3eqyrt0fx2Xv8IhlEslL8nfoOWjoW4uT9eEuFOIylUeK3zHrSAz7KXK0xW57Z/WqHzLyUv2Pmf4raAyI9KNQJE0HTgZrvnK70rnRAlSp3TwZSvHqIq+bOYTd Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.43.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:43:59 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:47 +0100 Subject: [PATCH v2 14/18] clk: qcom: videocc-sm8150: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-14-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1115; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=z0UvCR3eA/Pj02vuX/VE6kFABcANNusSJTpXlxREtE4=; b=uwAcFMJiU9sa8CMjznz4S5ue15VbSRNhDDSuo3SKtpqPYbgs3tcYdBzNoRVm31F1Yprjuf7Kj pVU8qTsf3boC4aeZeNpffu5UHI33LrIK+c+GTrxq3Lb3JieCOC5auPj X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value was obtained by referencing the msm-4.14/19 driver, which uses a single value for all platforms [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/blob/LA.UM.9.15.c26/msm/vidc/hfi_common.c?ref_type=heads#L3662-3663 Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/videocc-sm8150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/videocc-sm8150.c b/drivers/clk/qcom/videocc-sm8150.c index f1456eaa87c4..bead5186a5d6 100644 --- a/drivers/clk/qcom/videocc-sm8150.c +++ b/drivers/clk/qcom/videocc-sm8150.c @@ -215,7 +215,7 @@ static const struct regmap_config video_cc_sm8150_regmap_config = { }; static const struct qcom_reset_map video_cc_sm8150_resets[] = { - [VIDEO_CC_MVSC_CORE_CLK_BCR] = { 0x850, 2 }, + [VIDEO_CC_MVSC_CORE_CLK_BCR] = { .reg = 0x850, .bit = 2, .udelay = 150 }, [VIDEO_CC_INTERFACE_BCR] = { 0x8f0 }, [VIDEO_CC_MVS0_BCR] = { 0x870 }, [VIDEO_CC_MVS1_BCR] = { 0x8b0 }, From patchwork Tue Feb 6 18:43:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547728 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 363E01CA9C for ; Tue, 6 Feb 2024 18:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245044; cv=none; b=J0dQM7HVbRpx9aYx9CKkMjBADUT+KmR8J3GIVIW1vzwfsSafXk6vsucieVY8shaZO09kmO9hw+Rnj2frKOTI1pyQ4xYAjoZkWRut2m0H/SsOuItPllDTzT3PSsiPL0LtOC9I5d4EcISusCR/NB0IsS9ZVj4H3Fn5TPMiRZdCNFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245044; c=relaxed/simple; bh=5OdGYFu9CqmWBKnDDTkTc56GjeP6hdEjM7fvhmV7Ho4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dCJ3Wv8oS0/gDXBs8d/3cWe6YXau11ld9sUQpun6deRj9D1E9kQLR23L87L7U48DZ4soDRYuETxt53gyNf0IS+3vhLvWW+FphPsVaWRmaXBCP9t6+6w09kKntY6/PzxANw/RwvjESddVYicyl9MeRh7/6y+tGdXVWQqeEJL7nmI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uEzQL6Jt; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uEzQL6Jt" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a37721e42feso388750666b.2 for ; Tue, 06 Feb 2024 10:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245041; x=1707849841; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nkL4G+TELyncGb5qKRgsxW2VVdhetXIx83/bDt+aWkA=; b=uEzQL6Jt1cTfrVVEqnXQrgrqs2HQYkPZdfIxbytoGDAJ7P6tfmPn47JU+HRmIbGkWU Lgz8H2YFWBmSSwdmzqvX3EitJyBy/QA8m+SMo8Mp85De7EUBt4USC9NsXgAgNzltrYOe 6dqMv1TDDR8RhVp2Q3fo0fVRMQWTuA4hxlMDb5ajPGiLy8jAaxMwhk0phAA+02ZBHiVa GW682EOm8BL7Al0mhpMFqmgaFQv+YF+wC32mxwfwX+MV1VaDPJc/ZCrAETK+XyZmD2ld N4rFYrIZp1yLOFIuyprmn4uRGogHtO/9/nY6a4ZCYBdGka4kNjeGJwYfysbhwnuQaWU6 GAsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245041; x=1707849841; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nkL4G+TELyncGb5qKRgsxW2VVdhetXIx83/bDt+aWkA=; b=OmHKkTtMCqACCPormZ7S7Ve68jQkc2SVnSeTOnxTwScthyJr9HaLaaiGsVLSDvBjVE Ao79c6Kxpo604itqwlmtmO8jX3LhU2lDoZuNJPz4hA/1o260A2eicqsDJdHekmrUgzfW vlS8vEdpS2KCpst7P3IYz+YMJQgUVf771K+uN2K2wSiWcC+sOXF3z8PZ/+8TNTDR5HGq lWQRg7n1KD1wRiC+9Zmy2zeoOl4tHl4KKmbTeOEXL9q6sU34hzHBA6PYJjD7xt4/HSpG IokV1h6/zoLDdWFD7zsVMl1XwJQhFVHrFlAkMCXuSFkvWI0GXj/ARpL2WYU0uMofrjqP xD1w== X-Gm-Message-State: AOJu0Yw/txICG5bDFQk70Vg9VuYpqs/lbOphdYuLO18vKeywiCBjzqyb A5kelAEN4bYCO/DmSwp4/lCP6XHNR4ILy0ckgnzC5KbkIHD2TepRTfq+LEkG/Ws= X-Google-Smtp-Source: AGHT+IF3+6x9EWDEi80vngu+NibETsGvkeFscD0yLYQOCHiOeAUseU4Oo/47I7n4+OlsWWQjyXGLbA== X-Received: by 2002:a17:906:260c:b0:a36:7dd8:637f with SMTP id h12-20020a170906260c00b00a367dd8637fmr2390327ejc.23.1707245041489; Tue, 06 Feb 2024 10:44:01 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVHE4S4/aDVtRTbyfhFkZrFGTxPiH0/3Cjowf/HMxaokpAR8BkydBzS2e7PmWOW0eE8NIo9k6ePMIELH5UTRvvCn1RIOrU/lHSCm7xNYt5eDZC9HZ6Wb03xGxwewDlyhOZZA9jXXBB8z3R1FM5ojOMpmkJ4ZX+fy45tmvLaHs4yUIBqt8XagTu9hTeEdv2LI1Uhfy6XtHQ7wMkBnAln/mr6nlsatp3hiXsUzyFsYYc/PF201XGGn61wMuIAu8rtH30T/pH5k9/Tbww57cLX5Iq66eqb2Eac3yd9BD0Biph8FLZrhowyUeIPT+dRHBW4Gw30lXj4GNagq5k24OqqpCJx268M+cXItePwhgsDWvYWyqRqSx4lW/hQ9C16zoFzMykzFUQlF25iFyLpGWE8J5Bn6Rr88Sn5IzqmoNB6lS3TBzIROHoEg5AJvfKXjWNZ1BIW6RlEF105 Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:44:01 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:48 +0100 Subject: [PATCH v2 15/18] clk: qcom: videocc-sm8250: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-15-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1301; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=5OdGYFu9CqmWBKnDDTkTc56GjeP6hdEjM7fvhmV7Ho4=; b=jmYLm7iAFHYpGT/g1wACgWml5VM9+ceT2qb4R/8XEbKDni90cfTj+edzFhXM0MppSiBX/UxOn GALbHV3xLYDCAOFytpUnj8oPG5IG+FFf3p7rtoJ0UzEsY/M+Ypzvf1w X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value was obtained by referencing the msm-4.14/19 driver, which uses a single value for all platforms [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/blob/LA.UM.9.15.c26/msm/vidc/hfi_common.c?ref_type=heads#L3662-3663 Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/videocc-sm8250.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm8250.c b/drivers/clk/qcom/videocc-sm8250.c index ad46c4014a40..51b9816ec458 100644 --- a/drivers/clk/qcom/videocc-sm8250.c +++ b/drivers/clk/qcom/videocc-sm8250.c @@ -323,10 +323,10 @@ static struct clk_regmap *video_cc_sm8250_clocks[] = { static const struct qcom_reset_map video_cc_sm8250_resets[] = { [VIDEO_CC_CVP_INTERFACE_BCR] = { 0xe54 }, [VIDEO_CC_CVP_MVS0_BCR] = { 0xd14 }, - [VIDEO_CC_MVS0C_CLK_ARES] = { 0xc34, 2 }, + [VIDEO_CC_MVS0C_CLK_ARES] = { 0xc34, .bit = 2, .udelay = 150 }, [VIDEO_CC_CVP_MVS0C_BCR] = { 0xbf4 }, [VIDEO_CC_CVP_MVS1_BCR] = { 0xd94 }, - [VIDEO_CC_MVS1C_CLK_ARES] = { 0xcd4, 2 }, + [VIDEO_CC_MVS1C_CLK_ARES] = { 0xcd4, .bit = 2, .udelay = 150 }, [VIDEO_CC_CVP_MVS1C_BCR] = { 0xc94 }, }; From patchwork Tue Feb 6 18:43:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547729 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3C121CD2F for ; Tue, 6 Feb 2024 18:44:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245046; cv=none; b=Qlv33dU8hPmpZ//mVeBNiHZREmABmnLIE8CUQjM6IQ64CB4upL7b+tXgVgCUZ7zIqgWC+KU7fnrZvlnKSqemh5/ZYJFtvMS7MLu4ghJYDTAJFo1PEDtU70H0CmoiiGjvHTPNzkspW1Rw7PINcEbj64StD9+cD8fqs0DxXvK8M/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245046; c=relaxed/simple; bh=Y7Ggulm32WM6/RAQVocHOsRN4fBmgKhsAW4zx43ZHnw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FsPLeaO9t1FTO8yeEY0bXYKQAank6m1v6UHUZ+T/VKH4iL5iT97+H2lidkaLKQkFMVS8kmJP49YSZIMvhfQPmOHnSl9vh2qXJD8McNBEXxQGv3RUPEipQgdu9+YnrSen0eGECg7rQcBln/ZVpJLO15HEe1x2gsDzSBesfrSzuoE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V/99DOJL; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V/99DOJL" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a34c5ca2537so815672166b.0 for ; Tue, 06 Feb 2024 10:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245043; x=1707849843; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=isVYwPY6ofdkrPg4X2oYZpRBZGZUPttUGJohkW2kvxI=; b=V/99DOJLQJ6tJE7E7UyXPiq61AcIkRz2/n9tFHcGRgD+Ui8d3y8FiHClrH3NbTF5ii ZkMbg4wQKFZP+61Ie1VYPgiqvDdDiJd3KAEJfX7snYar72NPbYeZE5gjiJmiVRkiyde3 d4ArfsrQRIJb4SLjcL6QcjZSHe1TxQafTIGXCfR/jqr9mXDpdzKlH/Ekq5qLUgPcSv9J oCNRAEXVG8fbD0C8ECuKyxnlJSSGDJShbzghh13poe7qD6NNxvU9rnamMaVETlTMRNI0 tpfiFeNxSlJiHUhcR2Et8nlBtsg4g3/blrew+wkakGBHQUwv+Ww0pwydzVv52SM24gZs xklA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245043; x=1707849843; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=isVYwPY6ofdkrPg4X2oYZpRBZGZUPttUGJohkW2kvxI=; b=WwnERLZU+tsRq3OD6v5bXO4EiFTtoUURmJFBzop+W8I1paxSwqBwU3q3sa2s5acxyV v9GtvgS0MDLb9wuZOL/E/21wOMl0P7LvR3iTQ+Tp43K3bNx5Go1P5FjbeUo1N5XUKPb9 1XbsOfWcQ+LmiGFENMGEeDsxNYjS6GdIr8UxkXFNLPgWv4INtlhbLPRqPIoTtzomWB5b 2Lw1Jzrkl++b7+DJ8ihXIKxfvYLqi4TmxLWzfAc4BGAoC+WNgNfOAjKG2+KuWkQ7REOE bCzDUVN5L7IHxMLPdxn0LnmPuJyLs+l73/BrAB3BafGk3GFj13zJhHqG74l/OO7LTkEF hyRg== X-Gm-Message-State: AOJu0Yx/8/EEAopx56R5+YJYN5P0Fy/kESXQCkF2dl5yW6PV8im9AAhN SH+nC4QF5UF8aTT5mjMy8jjGkS6nrICr0nP55vZZ3ka+8D2VKeFa7YwaZYmLufw= X-Google-Smtp-Source: AGHT+IEGDzYnSZ0kqdSVkgFHv5O2mtFy9VYJ1S7QGal0lAihMkpjZ4JaqcIQJnJKuV7bAlu0DJTNgQ== X-Received: by 2002:a17:907:7710:b0:a38:9ff:5711 with SMTP id kw16-20020a170907771000b00a3809ff5711mr2492169ejc.51.1707245043218; Tue, 06 Feb 2024 10:44:03 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVCEuPRSNphr/lrCNEQgaplXOouJICClOqTHCkZ0QwrWXba7Wvy3sHFnfKnmAD8wLlVYv2Q4/bmT2M/S27soAQ7ruY8n8uwcQPftk7qc2zvPFCkQ9ceNqI8ONnqPd45DpmfdJE5V8DEFOZaJpZBo0PdsRcS3gvnDiI4LTqfis5KkSc2Wx1PvrSGgJo91iRhgRiwUXn6eoho+Ss/IgT0lEe8nS3P2lgBhY10Rk36qOn6L9ZOYD3v+EoxMeEjbCSx7UfpLsTBtMRtwRWLRlEk5JzE31DAhpGosUNKCZ0q0qwvRsjnqaHClaNzS9TQ/yM2iQPxeKXVoBOZOkunF9sZo60uRY/NmTYxug9nzEymkxn7KwHsxWyvVNQ25JxJVonk+Rwb62v76BdZ0G3ZMQWhyoid3sD+E1+I6f4uQWLYXFzDG5Xbc1a78P4FPRAIXPVWP0xP6KLIJTlR Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:44:02 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:49 +0100 Subject: [PATCH v2 16/18] clk: qcom: videocc-sm8350: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-16-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1223; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Y7Ggulm32WM6/RAQVocHOsRN4fBmgKhsAW4zx43ZHnw=; b=+zg3ql5xeaQtsYwzLD5OeLyA/UT3wxi+MNWyvdMP2mGfUDA5EH5HlLCL3b0D79zdaSA6kZGd8 1hQdTOOGi3AAhPoThaHiyCxx6+NWX3VA+XBmBBHY5s5L2A8MM/sxAPA X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value is known for SM8350, see [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/commit/dfe241edf23daf3c1ccbb79b02798965123fad98 Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/videocc-sm8350.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm8350.c b/drivers/clk/qcom/videocc-sm8350.c index 7246f3c99492..8db2bb995558 100644 --- a/drivers/clk/qcom/videocc-sm8350.c +++ b/drivers/clk/qcom/videocc-sm8350.c @@ -488,10 +488,10 @@ static struct clk_regmap *video_cc_sm8350_clocks[] = { static const struct qcom_reset_map video_cc_sm8350_resets[] = { [VIDEO_CC_CVP_INTERFACE_BCR] = { 0xe54 }, [VIDEO_CC_CVP_MVS0_BCR] = { 0xd14 }, - [VIDEO_CC_MVS0C_CLK_ARES] = { 0xc34, 2 }, + [VIDEO_CC_MVS0C_CLK_ARES] = { .reg = 0xc34, .bit = 2, .udelay = 400 }, [VIDEO_CC_CVP_MVS0C_BCR] = { 0xbf4 }, [VIDEO_CC_CVP_MVS1_BCR] = { 0xd94 }, - [VIDEO_CC_MVS1C_CLK_ARES] = { 0xcd4, 2 }, + [VIDEO_CC_MVS1C_CLK_ARES] = { .reg = 0xcd4, .bit = 2, .udelay = 400 }, [VIDEO_CC_CVP_MVS1C_BCR] = { 0xc94 }, }; From patchwork Tue Feb 6 18:43:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547730 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 676661CF9A for ; Tue, 6 Feb 2024 18:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245048; cv=none; b=G84qA5Cyw1CDPWMl3881Ne355fexymTLS6eaLKspStO/Hf2LwvZi8l6miw7vsAXzI01vMTQ77ZutQ2QojbcsT05AvqcRYOhNkrBlhblWLOkh3hDlCyKtBNa2BQDxHPxs4K49U0tuMnbotUDWeAkZmfMsmeKVHjI3ZRO9/xCfrZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245048; c=relaxed/simple; bh=zaeCrdSIZdnQrOpfJSqYQ9Ck7vw9+mDCXs61VSh8KsU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PzWaRtmvBOpcgjWoDhwp6VfxKJAPFcUGkgixlugmkVFM7+p4XYIIRZsp3JMZ3wOnhluhB1fFalQ5yLKOcNI41BYfWgriq9d5MKWSMem/IjPUZ97g6KjCM0i6v08vr+0Pz+rQ/aPzhaOAQhtuSBt5VVQw+rS0y0jyNro+KpdsKhE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Appa5qAa; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Appa5qAa" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a383016f428so103270466b.2 for ; Tue, 06 Feb 2024 10:44:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245045; x=1707849845; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4KEnAB/est+J1SeDFEencX7BVcJohlePYLBUnIFqHdQ=; b=Appa5qAaG6JjR/Dm1x+cH64nGklznSiLH9J6+EexMEB4/6vpPn/SYcoq+8XGLQmJO2 KnNFzA9K/iUaLMyy11c6Lr0d7b3RJGu1KiODzLyebdIwtXlC/pmmEmJ9MGl2ouwA23pN cawSrOIJn9p+k8mwt/YohjTjyynh/JJLTM5SXRdqvTuMskq/KTTMgxEjK6DXv3Uz3R2R l5ahFG4TV8jih+72r6J0F5sO96w1+9top+iiUSDonElGOmVkdFggFAKFooqV/NU2FpoH jh5iqTQpTT8ZXP0Ec7GjjFBIBq9e7Kl5CvY8kw9ppPZ9yFd1RR/8Pzn21aO/uUF9oqTU pisA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245045; x=1707849845; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4KEnAB/est+J1SeDFEencX7BVcJohlePYLBUnIFqHdQ=; b=RTDW8zr/r1d2mlwyx4coiDF7j4VXW3/xud12fbf4jyYWzlvcKkX3NtTFimR1TfUNHN ZjwvK1Q3cHHFaxMyraoU0K925MKIRYNY5V0H0QpNtzpYxwO6ToOb3InYYZqaBwU07DeF KJCXYQ7Sr5BVCqF74Ji1jMGupIiBeD0WrtSGoQZmBM4jD7MVaSlMHPllZfmBlTe0aA51 S2v0E3tDVvkns8Jkb8xkvpPpUbAkIxnDFcpzH/dhLrma/Ojp9oqkZUOgeskNHfjXCUjB Dju3buKU0+uO+2eurTrJQYP4HqYQwkmYjinnk6jyyX/qFgBHZx5FeZiaDE01PPTI8BZJ pSaQ== X-Gm-Message-State: AOJu0YzgvKMT88XRtR6ph6q/nPZxkMiv6ONAJ3CAe7BpR22M2FiiikDD iIig4/63XqtL8J/Co1jQviJmVoigZX06xVXcy75Rs/KL0Z+MmaclHI4ITZ588C4= X-Google-Smtp-Source: AGHT+IEwSDm6nuBUElg3xGBgKVwVcWEiOWHkBVITRzKTgjxLIhYvCsU0/ng/Iax0Q8vQt60UZcLlDQ== X-Received: by 2002:a17:906:704a:b0:a37:22a5:50d5 with SMTP id r10-20020a170906704a00b00a3722a550d5mr2476690ejj.54.1707245044858; Tue, 06 Feb 2024 10:44:04 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXb+lVRLzyZP76/IktTGnMRqeUucGJP8JxDl9gdo+QqnwoJ/JXSL9aOXKGw3BZPqSMGqX2fSPt8VK0wCj5wHQwrIIunNAX43yQuc/cDyRh+NPJNe+QslArFff81Hadoomba/4af3M1IY6iGDqNxByKzg69MqbEminGfLNhoxBkdDjjoeEEYaLm+wtjBY82gXqOI6US4t8NlsYXky8UckFYq+L0fXqSC/t+nQYcBR7vD7H6UcgyhET5gu/aHFzvJaAmrOwgQUoGzninGh/tUq3C+S2I+bMbu8zevdClTD3ARGKmpgjSY8ok6aovYWvgksMbWMCPCY4DRkGOS7mtHkwdE9kRHT4mftiJ+ZUyceccZWWzGKW7obEh0HlK/WeqD/WFMkNROVk+7VCKNqGZSTSNH4g50TbxMuZKquYfTE3SE4rOXunt+uEK0VJS1La9YMl9zOao8RAHP Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:44:04 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:50 +0100 Subject: [PATCH v2 17/18] clk: qcom: videocc-sm8450: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-17-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1158; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=zaeCrdSIZdnQrOpfJSqYQ9Ck7vw9+mDCXs61VSh8KsU=; b=gAjYN4kZvcLr/Jv2d1Ru1N8PYvkeDBd1lv8wL36Fm8wIxdb5F/6CFQKx+SJAI+jQjzqqSJPKn K9LFK1EAOleDa6zshRxR50X2VJYvve/1+D2EdEHxnFwyUdQbu8kFanZ X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value is known for SM8450, see [1]. [1] https://git.codelinaro.org/clo/la/platform/vendor/opensource/video-driver/-/commit/d0730ea5867264ee50b793f6700eb6a376ddcbbb Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/videocc-sm8450.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm8450.c b/drivers/clk/qcom/videocc-sm8450.c index 16a61146e619..67ca302a0737 100644 --- a/drivers/clk/qcom/videocc-sm8450.c +++ b/drivers/clk/qcom/videocc-sm8450.c @@ -373,8 +373,8 @@ static const struct qcom_reset_map video_cc_sm8450_resets[] = { [CVP_VIDEO_CC_MVS0C_BCR] = { 0x8048 }, [CVP_VIDEO_CC_MVS1_BCR] = { 0x80bc }, [CVP_VIDEO_CC_MVS1C_BCR] = { 0x8070 }, - [VIDEO_CC_MVS0C_CLK_ARES] = { 0x8064, 2 }, - [VIDEO_CC_MVS1C_CLK_ARES] = { 0x808c, 2 }, + [VIDEO_CC_MVS0C_CLK_ARES] = { .reg = 0x8064, .bit = 2, .udelay = 1000 }, + [VIDEO_CC_MVS1C_CLK_ARES] = { .reg = 0x808c, .bit = 2, .udelay = 1000 }, }; static const struct regmap_config video_cc_sm8450_regmap_config = { From patchwork Tue Feb 6 18:43:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13547731 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17A241D539 for ; Tue, 6 Feb 2024 18:44:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245049; cv=none; b=RasE+1fm+GrqytsTRVvnROC8yU2Spyh62DALuFIDeKAjm/+aF7hm80iyMOGJ2mYnu66TIFbSXtEPGSN6i2m2DNkDEg1Sb5AT8Ylq96VnUAwFamBsiGs2incpQ+b0vZkVA2D4LcbDjEfMXDXJngAWJiSooPYtQ6bjb3RKSdmpX04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707245049; c=relaxed/simple; bh=2S463+CzMDGi1rLOIQTPuNUpuMASFzJ+jxXDDyz8//Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q2Og4+Yvm5qG7tWob/MaWziJc5AY3x8LaJoKUDn+N0JpUzVKnxBoJDGpIi8wLtDjK36/zL4A/48TWMtTlCXuWeS/Ux+bu0Suokt5Ibi2orNN2UWGiZ5ZYOcxZe9epMDKbQOTyQ5HUCBMApD06Os2OqFpii+9scRyHjTd7C9XHEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mUT5mvbg; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mUT5mvbg" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d073b54359so76676411fa.0 for ; Tue, 06 Feb 2024 10:44:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707245046; x=1707849846; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1FWDxrvCgCbA9bRUaJGRlYCcz0F0+PB8LWtXBkaTaps=; b=mUT5mvbgHGDXea3HhlkrDiC6fZZfkH2d5F7PwBr6P3CCMETgzFpDKg7P8cdzJsclXh RahIK9xdywobyr3f8yI5U3B62VKcChjogIljWLbjwvwREC8wgbUDRETHeUmypGmxhhGM eFEBaiHDch8hLIIsF9r3DtHuIRE9KdbaeBBl8d6KE3RCF8xGuBgb8V32OGidArvKggmJ 4Kjjz8N9Q9H5MGPl+SbvM+O1+CuHlTf+Pm59F2hflpEEdslAwHmQ73WsmnZsdrCCRqc9 FoB+iryXYxtSdRkUS0yyRyna4w9RmJs6cXpTfR8xEa0vdv1BhtdY4kbsf+L4DiD0d58a ORdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707245046; x=1707849846; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1FWDxrvCgCbA9bRUaJGRlYCcz0F0+PB8LWtXBkaTaps=; b=JNdQD/MW7M+wLwwyPrt7nps0bCAtGxJZgJd1wIugfrMCGf1t2yxQYwlUFXFMMoF0nn DyVGYNr5WfLddfUeEQ5LtSSsEn0/A+OkrTKQeH+4Io+4FCrVjS/GX/IHe+CTxFXl8DKp gmWiVlAORwPfYVWUQbgAUVIisYtHLl8RJ0ajuCp7MNqXgLWCxwZ6RoMNNfymxYXR/3dA YdMeSdoVMuiDeoaVwcVz2/mfwO3Uk0WBWLLX9fYRFh3W8bSloQ8firBLCWN+fJxyq8if nfziA1ox+XfnfQtcTiFYUAGfcXwRr9gkEVmpmhhpBd4+DZPy5gWY0bxPdnww7dueeFFj bCxA== X-Gm-Message-State: AOJu0Yz2O6sQaurJuHtVFMeltuK5cEP6DN6vnV+w3ryyiBFZiXx0sZ6e SidOZz6/qYSiLKrIcgyX4eJ/miHK8QOx13VIzj2v2HWODacaqSI5x8U1Aepmk5U= X-Google-Smtp-Source: AGHT+IGGBKFsyt5zrjZScDXyPO3BCFXTskqE4t6XXzVKivuiP8AJ1yhmWjWzJDtFBd12pKeTmwTOlA== X-Received: by 2002:ac2:562d:0:b0:511:4dac:f1ad with SMTP id b13-20020ac2562d000000b005114dacf1admr2218225lff.27.1707245046079; Tue, 06 Feb 2024 10:44:06 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCW1J9vOUZA9QcZquhv1h6rFUybIMyzOPWWAadU1ThYGN9vrqTSlsGZV0U/gIsFFomwydN2RDJ86QdKFCvWBExpMJuJKBcdQ1EycfvM3UJL14WPJhLBxq4mkf+OWshKm5OSN8smNZW8XVWtaQLhTuLvW+uS20lUQiQX0MXDgIpq/VLPX1uUPU3wj84Kh37dg6M1R6FwhagxhPZ7VjQdLeBo7LJciju4Plg/spetatd2nsl8fYE8va8hxSSn7z9JGIen/pn+/X4ZoHBisWdgmf1GVWZw9f22B0AjvWj2pMlxDVv+mXI/aozOlZ1btpgPrfd+rsnSg7YfZHT5ZH2rKvy/L7KTH9gokncih+lKrwj8jIC9ALFq5SRaC8fvV96G0dPlvEi3jXwqF2EKmfCI7RZltivOvBP6yyFUcH+pl/7cwFmomJQuO60nZyvAN7uS/oV7sD5cpjMEK Received: from [10.167.154.1] (037008245233.garwolin.vectranet.pl. [37.8.245.233]) by smtp.gmail.com with ESMTPSA id un9-20020a170907cb8900b00a384365e3b9sm562305ejc.195.2024.02.06.10.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:44:05 -0800 (PST) From: Konrad Dybcio Date: Tue, 06 Feb 2024 19:43:51 +0100 Subject: [PATCH v2 18/18] clk: qcom: videocc-sm8550: Set delay for Venus CLK resets Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-topic-venus_reset-v2-18-c37eba13b5ce@linaro.org> References: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> In-Reply-To: <20240105-topic-venus_reset-v2-0-c37eba13b5ce@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Manivannan Sadhasivam , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707245017; l=1059; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=2S463+CzMDGi1rLOIQTPuNUpuMASFzJ+jxXDDyz8//Y=; b=JtB6YmGeACZ5ppxwuHnTrt7f/4pkjhJ0YGo1eDbaSeJw1S4VNh2TJJtc1y6unKQzQ5E9eFWNo SqlzIc204aAAvMWFLB5Z4LyITGz1kNJuuhU8XvdM+Qen7hM/JFxjL+i X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Some Venus resets may require more time when toggling. Describe that. The value for SM8550 is known and extracted from the msm-5.15 driver. Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/videocc-sm8550.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm8550.c b/drivers/clk/qcom/videocc-sm8550.c index f3c9dfaee968..e3f146347da7 100644 --- a/drivers/clk/qcom/videocc-sm8550.c +++ b/drivers/clk/qcom/videocc-sm8550.c @@ -378,8 +378,8 @@ static const struct qcom_reset_map video_cc_sm8550_resets[] = { [CVP_VIDEO_CC_MVS0C_BCR] = { 0x8048 }, [CVP_VIDEO_CC_MVS1_BCR] = { 0x80c8 }, [CVP_VIDEO_CC_MVS1C_BCR] = { 0x8074 }, - [VIDEO_CC_MVS0C_CLK_ARES] = { 0x8064, 2 }, - [VIDEO_CC_MVS1C_CLK_ARES] = { 0x8090, 2 }, + [VIDEO_CC_MVS0C_CLK_ARES] = { .reg = 0x8064, .bit = 2, .udelay = 1000 }, + [VIDEO_CC_MVS1C_CLK_ARES] = { .reg = 0x8090, .bit = 2, .udelay = 1000 }, }; static const struct regmap_config video_cc_sm8550_regmap_config = {