From patchwork Wed Feb 7 18:36:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Abeni X-Patchwork-Id: 13548932 X-Patchwork-Delegate: kuba@kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9842239856 for ; Wed, 7 Feb 2024 18:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707331027; cv=none; b=TWCMB6zFOgFdWWrGDR2W5j75wPLT7g7+gddZF8iCQycMpwlTR8vdqAHvSJEW8KCXAPcJYQkU5L/mMqgQAKoPAGZAJVdL2etqmE/7Or7F3bCGS4t67E8XPDnCnl6+tgfPd2RIErq3VLeTGOf1q6EEqeom/J1l54O7Etg6IBV2Q38= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707331027; c=relaxed/simple; bh=m/i5sMPBt1+3JO6Q2iXN1WvpBHVaWfpDYedxyd/lIQo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pRCWiyIhDRsi2TX7CEKpZvaHARdEqbbyYVy76HGqOt5vlhY3+IL0jHqVQYP26IV9nebR/fh8rTy9WjrqrH5/Hb7/sZaj7AWdZqGmCAmhEH765q8pvX0bmQuIc4RCUxLL1nod/ceoEzr89nmHm1cuEUaQno40P50KE7jsPllqd6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AXS2BmtS; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AXS2BmtS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707331024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zLIjr/OYq0QQZi5Oxih3797SDEnIF4gpI6RRxiaId+U=; b=AXS2BmtSSr2QVG2kvWBMJNh8K1f7+UaZTStdAMF/DHMhlP6aSWsCGezVFjKApqnD49E+vS r6l+GyfhGCAJE8kbGUspNkZRQ91W8pd0EtluVY8TubVh6sVQnaPTSNMgKfjYM3NL1sWIdB 6Fi8z94IGbrHGb2haGK58sGi8RWarcY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-AwZNPHxVPoyxbuoumUO-tA-1; Wed, 07 Feb 2024 13:37:02 -0500 X-MC-Unique: AwZNPHxVPoyxbuoumUO-tA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3C0D28D1380; Wed, 7 Feb 2024 18:37:02 +0000 (UTC) Received: from gerbillo.redhat.com (unknown [10.45.224.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7EB1F1C05E0F; Wed, 7 Feb 2024 18:37:00 +0000 (UTC) From: Paolo Abeni To: netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Shuah Khan , Willem de Bruijn , Coco Li , linux-kselftest@vger.kernel.org, Matthieu Baerts Subject: [PATCH net v2] selftests: net: cope with slow env in gro.sh test Date: Wed, 7 Feb 2024 19:36:46 +0100 Message-ID: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Patchwork-Delegate: kuba@kernel.org The gro self-tests sends the packets to be aggregated with multiple write operations. When running is slow environment, it's hard to guarantee that the GRO engine will wait for the last packet in an intended train. The above causes almost deterministic failures in our CI for the 'large' test-case. Address the issue explicitly ignoring failures for such case in slow environments (KSFT_MACHINE_SLOW==true). Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test") Reviewed-by: Willem de Bruijn Signed-off-by: Paolo Abeni Reviewed-by: Matthieu Baerts (NGI0) --- v1 -> v2: - replace the '-a' operator with '&&' - Mattbe Note that the fixes tag is there mainly to justify targeting the net tree, and this is aiming at net to hopefully make the test more stable ASAP for both trees. I experimented with a largish refactory replacing the multiple writes with a single GSO packet, but exhausted by time budget before reaching any good result. --- tools/testing/selftests/net/gro.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/net/gro.sh b/tools/testing/selftests/net/gro.sh index 19352f106c1d..3190b41e8bfc 100755 --- a/tools/testing/selftests/net/gro.sh +++ b/tools/testing/selftests/net/gro.sh @@ -31,6 +31,10 @@ run_test() { 1>>log.txt wait "${server_pid}" exit_code=$? + if [[ ${test} == "large" && -n "${KSFT_MACHINE_SLOW}" ]]; then + echo "Ignoring errors due to slow environment" 1>&2 + exit_code=0 + fi if [[ "${exit_code}" -eq 0 ]]; then break; fi