From patchwork Mon Feb 12 09:39:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Abeni X-Patchwork-Id: 13552855 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72D98101C2 for ; Mon, 12 Feb 2024 09:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707730800; cv=none; b=q/QglYWVjYG29ornnHicgbWm+M9qg92KD2+Rn1b+eZMQX2L4DRaXfzyugqllCBp5xE3bVO27MdW+ILMxEsoHRhxjaYIUJ1kZ2MXw0k3lIxDaRKSVeQdcZlyjmQ3iuEpgeqDNvA1LMiUqtmpcf5lovI3uJWGk296EU7s8EGaxzVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707730800; c=relaxed/simple; bh=Sn6j7uRbtr+Zs52T1g5H45u38VnSWLoP+0PrQjRQ9cA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hecgAokeh99Kw0CnlAxSGbG/iKijzzADb8CSlg5s1OO1Z8up+D6/LS/C5mY+O244+zuJ/wJs1MoHRju0HvUX0OYuZ3nspjG3Jqsy4hkktoazwREuh3BqAjVcnpNfw/CWgef/Hd2pYV3mivzhdSGGi6uHMnF2RMZ0JLgVc+ljMv8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GIunKyAC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GIunKyAC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707730796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=+1llvXaFfVdkLMBqpMg4IJmT7opjM+I2i8bbnTsk+qE=; b=GIunKyACCLj6baIu3FfFK+fCe98gZ3EUtPsGLqnuoMVix5S2/ph3apVfrhILm8McGUxhtV mi+Zcj/2ogNwk5QnA+6O0wd8PnL77WV5eQ0jP5q6i/KnLTwOTKrA0Bk2zKEZoUTVk/1LfN a1EAsRFTr7mWdg7cZlvqEw1vUBASR+M= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-JLYJC3UgOc2U2kzlv_1qAQ-1; Mon, 12 Feb 2024 04:39:52 -0500 X-MC-Unique: JLYJC3UgOc2U2kzlv_1qAQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7AB6C3814E90; Mon, 12 Feb 2024 09:39:51 +0000 (UTC) Received: from gerbillo.redhat.com (unknown [10.45.224.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id EFE621227939; Mon, 12 Feb 2024 09:39:49 +0000 (UTC) From: Paolo Abeni To: netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Shuah Khan , Willem de Bruijn , Coco Li , linux-kselftest@vger.kernel.org Subject: [PATCH v3 net] selftests: net: cope with slow env in gro.sh test Date: Mon, 12 Feb 2024 10:39:41 +0100 Message-ID: <97d3ba83f5a2bfeb36f6bc0fb76724eb3dafb608.1707729403.git.pabeni@redhat.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 The gro self-tests sends the packets to be aggregated with multiple write operations. When running is slow environment, it's hard to guarantee that the GRO engine will wait for the last packet in an intended train. The above causes almost deterministic failures in our CI for the 'large' test-case. Address the issue explicitly ignoring failures for such case in slow environments (KSFT_MACHINE_SLOW==true). Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test") Reviewed-by: Willem de Bruijn Signed-off-by: Paolo Abeni --- v2 -> v3: - dump the error suppression message only on actual errors (Jakub) v1 -> v2: - replace the '-a' operator with '&&' - Mattbe Note that the fixes tag is there mainly to justify targeting the net tree, and this is aiming at net to hopefully make the test more stable ASAP for both trees. --- tools/testing/selftests/net/gro.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/net/gro.sh b/tools/testing/selftests/net/gro.sh index 19352f106c1d..02c21ff4ca81 100755 --- a/tools/testing/selftests/net/gro.sh +++ b/tools/testing/selftests/net/gro.sh @@ -31,6 +31,11 @@ run_test() { 1>>log.txt wait "${server_pid}" exit_code=$? + if [[ ${test} == "large" && -n "${KSFT_MACHINE_SLOW}" && \ + ${exit_code} -ne 0 ]]; then + echo "Ignoring errors due to slow environment" 1>&2 + exit_code=0 + fi if [[ "${exit_code}" -eq 0 ]]; then break; fi