From patchwork Thu Feb 15 21:59:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13559170 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 453EEC48BC4 for ; Thu, 15 Feb 2024 21:58:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 866F38D0014; Thu, 15 Feb 2024 16:58:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EF6A8D0001; Thu, 15 Feb 2024 16:58:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F31D8D0014; Thu, 15 Feb 2024 16:58:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 49AF68D0001 for ; Thu, 15 Feb 2024 16:58:06 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D3D4B140852 for ; Thu, 15 Feb 2024 21:58:05 +0000 (UTC) X-FDA: 81795401730.01.A1AF831 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id 1EF811C0019 for ; Thu, 15 Feb 2024 21:58:01 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BIeS8ey8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jDZk1p8j; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BIeS8ey8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jDZk1p8j; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708034282; a=rsa-sha256; cv=none; b=xiYVTBXW47xuuz2yTURvXbRzJQ7bl5CjQYvwLywvBknUiyMNe2w55fkfL9x4CykHdVvvty IaDP60XCcbi6UijBKOPlOPOA7YH2fsJEFjbSEJjyawX4mp+vmkUN1YzOfzTV3fDD4tt8zk y7qivviBIt2DUMd+yS7D88D9ilE57jM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BIeS8ey8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jDZk1p8j; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BIeS8ey8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jDZk1p8j; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708034282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dokaDBSPVaBXieZJW0HGUzN4swvmh9yT+sqR2X4jBMw=; b=l35V+Yixu/dM2BSi3dMtY2yhRxTuBAIQTx4I65w5p8A2PxbWG5sod9WeOxZbiDlrQO29op RNK5LKbaVVtuBptL+oEJc88hofCPXfvdLRgpOTQdNaY7p5Ddf06bUPiB/aXT6X6peGHdy7 2I88mAXPbCnhBB5isrVpI9JyoaHepMk= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 355F722216; Thu, 15 Feb 2024 21:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dokaDBSPVaBXieZJW0HGUzN4swvmh9yT+sqR2X4jBMw=; b=BIeS8ey8s0J4V2b54NhN6Z6gNxsesWqq8anGuqv6gfTwgfcfgP/eMqYcCFr+t9fqdbO7KL /2TRlCl9AMjAXSgahUTzydYxT/XfehM+xzfaVWAZaKJ4uDWTp9LUsY1SlfqL3f4uzxf0tD MmReXnT6el1g2Sxq4mzhHsya7W36coY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dokaDBSPVaBXieZJW0HGUzN4swvmh9yT+sqR2X4jBMw=; b=jDZk1p8juHpSTbEvbUl6/ZP2gzkG1u3u2N6mL6NXnzKG+UePPbn7Eo+Mu8OREiCJ8vopUl wWEtkgywZoevpnBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dokaDBSPVaBXieZJW0HGUzN4swvmh9yT+sqR2X4jBMw=; b=BIeS8ey8s0J4V2b54NhN6Z6gNxsesWqq8anGuqv6gfTwgfcfgP/eMqYcCFr+t9fqdbO7KL /2TRlCl9AMjAXSgahUTzydYxT/XfehM+xzfaVWAZaKJ4uDWTp9LUsY1SlfqL3f4uzxf0tD MmReXnT6el1g2Sxq4mzhHsya7W36coY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dokaDBSPVaBXieZJW0HGUzN4swvmh9yT+sqR2X4jBMw=; b=jDZk1p8juHpSTbEvbUl6/ZP2gzkG1u3u2N6mL6NXnzKG+UePPbn7Eo+Mu8OREiCJ8vopUl wWEtkgywZoevpnBg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id A5CFB1346A; Thu, 15 Feb 2024 21:57:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id IEDFJeeIzmXPAQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 21:57:59 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v10 1/7] lib/stackdepot: Fix first entry having a 0-handle Date: Thu, 15 Feb 2024 22:59:01 +0100 Message-ID: <20240215215907.20121-2-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215215907.20121-1-osalvador@suse.de> References: <20240215215907.20121-1-osalvador@suse.de> MIME-Version: 1.0 X-Spamd-Bar: / X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1EF811C0019 X-Stat-Signature: mricorj5uj7ow7ramc4t9gsiuutauuse X-HE-Tag: 1708034281-877312 X-HE-Meta: U2FsdGVkX19sfzwng5yeUM8dwxasc7X2Ve6j2/o/N59P+i4Po5Bwgo32lCOfDgXpXuioB1U7CK9io+b+MISEomIw0mJUb9EorsVqsMEGMCK5m8GCLZ2pDJez2aa8XTlkgZEbmg7vLYxPoKacjpoT2GyzANJ7J6XNeKam8VCutRDIuOlZsHuR5Cx0IM7ovlKMK9Cx9AG6Q8fZOLAdI+EiMtpmE1kgB6sqkOjlcpiLvrHgvA5GzKrq74jqIXAEEeynJmFlStzXCrkqQ1k5xn+uF/tosS0IKD19PwyzYIEFUVmG2UrBDfByuMMC1V2LzxLK7eNzHeWb/yxLIvVwZdxn8v94SyjrZjs3+2h5Qz7TATOo2RmWAmi9Cn3mezjKRi4hKnVADiXumxHJQm//u1Y56vz+QlXqkKFVyfQxUzzFxNVRlnkBdV4NmVzycT+MK7tNoxmVhBEI5r8ux//cOgh4CmORVeK+e5rfpCyt9klFM4v5t0eIdkI5j1H+9NsJw7i0qrqf6SC8fHKTRuhH7K9jRsrU/ah1s9pdyiFclf4sEh8XyfyoLTWVvVwFi04csPuy4Hjd6nsueqKWYf4TBqf0N2BskoIhl3jhF2o8GQu/zWi7XJ5mp501hCtuQjLjTmRP/bFy/LXCfVWq1I2kvCn1RBFlrQ6xpSK1nvl5lnnQRZkcBX1C0rrZdoPzv8ofhCVjbS7LHvt94qBHY8UTHmC4+GgBHfbPDlHk8PTAs5P0H9q3NXFUs4A2IOy/pQOoTUPmd0CFPfCYqlVmcUh3fAK5F8zK1XSHweqPTX5OyNqs1+jS0arNqfZ51UfPxh+HFtuKTPuTX3fLZju7R12qX8uVLZIZCvSIb4U1Y+TSOhbQFRNjDSnQovM599VEKeTrGacRxlVzBYrfSxJLksv9k2K+k7Jme89EukVp6aKQw11X0F1hVyoZ+a7CI7WHw9PUYSO/QOMKo8/VOqSKJRIc0TD Y+H/hki4 buKmxEXIhKU42tMDTYIZQurnqSndg7RUCJdahgx9IlDHDiqrs/yx3ZaD4Q6WvyL0PGEFnUsQZztKBkjPK5FDa6lQy2DUxfzBP9UU93/uz0rdykChxhjWgytHhOcONgU5q77Vf2+qxqfNduZoSga72zPFOyRCGWWkbDT/+2rEXVx5hXl9sknW9x0b6w83uu42ke91KIEUSLe9/9aimZ5LEkh+s+j/bYJYCzuWq9t8dGapLuDvt27RZbhEn5f4ViL0BZfcO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The very first entry of stack_record gets a handle of 0, but this is wrong because stackdepot treats a 0-handle as a non-valid one. E.g: See the check in stack_depot_fetch() Fix this by adding and offset of 1. This bug has been lurking since the very beginning of stackdepot, but no one really cared as it seems. Because of that I am not adding a Fixes tag. Co-developed-by: Marco Elver Signed-off-by: Marco Elver Signed-off-by: Oscar Salvador Acked-by: Vlastimil Babka Reviewed-by: Andrey Konovalov --- lib/stackdepot.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 4a7055a63d9f..c043a4186bc5 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -45,15 +45,16 @@ #define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \ STACK_DEPOT_EXTRA_BITS) #define DEPOT_POOLS_CAP 8192 +/* The pool_index is offset by 1 so the first record does not have a 0 handle. */ #define DEPOT_MAX_POOLS \ - (((1LL << (DEPOT_POOL_INDEX_BITS)) < DEPOT_POOLS_CAP) ? \ - (1LL << (DEPOT_POOL_INDEX_BITS)) : DEPOT_POOLS_CAP) + (((1LL << (DEPOT_POOL_INDEX_BITS)) - 1 < DEPOT_POOLS_CAP) ? \ + (1LL << (DEPOT_POOL_INDEX_BITS)) - 1 : DEPOT_POOLS_CAP) /* Compact structure that stores a reference to a stack. */ union handle_parts { depot_stack_handle_t handle; struct { - u32 pool_index : DEPOT_POOL_INDEX_BITS; + u32 pool_index : DEPOT_POOL_INDEX_BITS; /* pool_index is offset by 1 */ u32 offset : DEPOT_OFFSET_BITS; u32 extra : STACK_DEPOT_EXTRA_BITS; }; @@ -372,7 +373,7 @@ static struct stack_record *depot_pop_free_pool(void **prealloc, size_t size) stack = current_pool + pool_offset; /* Pre-initialize handle once. */ - stack->handle.pool_index = pool_index; + stack->handle.pool_index = pool_index + 1; stack->handle.offset = pool_offset >> DEPOT_STACK_ALIGN; stack->handle.extra = 0; INIT_LIST_HEAD(&stack->hash_list); @@ -483,18 +484,19 @@ static struct stack_record *depot_fetch_stack(depot_stack_handle_t handle) const int pools_num_cached = READ_ONCE(pools_num); union handle_parts parts = { .handle = handle }; void *pool; + u32 pool_index = parts.pool_index - 1; size_t offset = parts.offset << DEPOT_STACK_ALIGN; struct stack_record *stack; lockdep_assert_not_held(&pool_lock); - if (parts.pool_index > pools_num_cached) { + if (pool_index > pools_num_cached) { WARN(1, "pool index %d out of bounds (%d) for stack id %08x\n", - parts.pool_index, pools_num_cached, handle); + pool_index, pools_num_cached, handle); return NULL; } - pool = stack_pools[parts.pool_index]; + pool = stack_pools[pool_index]; if (WARN_ON(!pool)) return NULL; From patchwork Thu Feb 15 21:59:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13559171 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BEFC4829E for ; Thu, 15 Feb 2024 21:58:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC6788D0001; Thu, 15 Feb 2024 16:58:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4E008D0017; Thu, 15 Feb 2024 16:58:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9A088D0001; Thu, 15 Feb 2024 16:58:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 95FED8D0017 for ; Thu, 15 Feb 2024 16:58:06 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 70680A0835 for ; Thu, 15 Feb 2024 21:58:06 +0000 (UTC) X-FDA: 81795401772.24.8D3F6C9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 30BA94000F for ; Thu, 15 Feb 2024 21:58:03 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sDIUhMWx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OtqQfKBg; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sDIUhMWx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OtqQfKBg; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708034284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KIFuhxtUimaTB1oGyts61MXj7SFhTQEDfGLXLyf0SXA=; b=dCQawTuujreqxSVXKPL8uuoeS/P1BuwAiD0Ml74Qpr9BI5rRIIPMgnx+BxQe6zKDtOIEqe MrcTSpoVuLWMEAMlq8SHQdnGRGV42lr1nXYRqBMIje23MJirubgexCHTorI5JGEKLirxVs 7QxLahovXA6lnhvp5QPceWqT8Lbvesk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sDIUhMWx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OtqQfKBg; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sDIUhMWx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=OtqQfKBg; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708034284; a=rsa-sha256; cv=none; b=5pG0GOqp//XbSNFYJg7TaAUirPe6PhMIwAgDOmrT1EAGmTusGVNRucwRrpiuPXmRGiqT+Q VitvFMreGY4uKkZfS4MhTtjz+0KrWlUkguXJWObv/eibNy4B0N3AjI3k/fZDzDndEV5UXa 4D9hg9iIp4FOVKWuSUUhq2VFwsKad24= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B7440220D6; Thu, 15 Feb 2024 21:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KIFuhxtUimaTB1oGyts61MXj7SFhTQEDfGLXLyf0SXA=; b=sDIUhMWxQNqioKstlKsyntTXD4/nZuU7AQ/MJmtBx1nNpvQXfTteQsqntN6z+FqQ+8boS8 5GdXNmtZ9XK4fuC8hLx9vkaTfn+9AdwUYBS++5FXDmYsQy6SH6med4vL3abc4VNF37+GfN oIpF1Lsous6wkOPdOMfoXdy0j6BkDQY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KIFuhxtUimaTB1oGyts61MXj7SFhTQEDfGLXLyf0SXA=; b=OtqQfKBgL/dfkEFMjon07KDicDuBnypyUM3a+kD80udyLzUBb0lFFtHTyzWZGMLzUyRYYO KabHKm3Z3YGcZEDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KIFuhxtUimaTB1oGyts61MXj7SFhTQEDfGLXLyf0SXA=; b=sDIUhMWxQNqioKstlKsyntTXD4/nZuU7AQ/MJmtBx1nNpvQXfTteQsqntN6z+FqQ+8boS8 5GdXNmtZ9XK4fuC8hLx9vkaTfn+9AdwUYBS++5FXDmYsQy6SH6med4vL3abc4VNF37+GfN oIpF1Lsous6wkOPdOMfoXdy0j6BkDQY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KIFuhxtUimaTB1oGyts61MXj7SFhTQEDfGLXLyf0SXA=; b=OtqQfKBgL/dfkEFMjon07KDicDuBnypyUM3a+kD80udyLzUBb0lFFtHTyzWZGMLzUyRYYO KabHKm3Z3YGcZEDA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 35FB71346A; Thu, 15 Feb 2024 21:58:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id eMxvCuqIzmXPAQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 21:58:02 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v10 2/7] lib/stackdepot: Move stack_record struct definition into the header Date: Thu, 15 Feb 2024 22:59:02 +0100 Message-ID: <20240215215907.20121-3-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215215907.20121-1-osalvador@suse.de> References: <20240215215907.20121-1-osalvador@suse.de> MIME-Version: 1.0 X-Spamd-Bar: / X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 30BA94000F X-Stat-Signature: wtzi3k4ga4anyu36mgqd3fjxe9wt51xc X-HE-Tag: 1708034283-591211 X-HE-Meta: U2FsdGVkX19YQddkfs7qgxKwQbStWkq4uS3EbQr3O4agloPzguqSrerRh3rd/69GFvjEOK2U5ZHwBJGqL/rDuen+2EqPGfIB5TCvNA+zdpSVWDcZ78zBKHpW3F1UAKHVkDcP95thk33PDSDvKojX2TygS/y0p7yzCrfM/KUJSdJyOjIGofwJDN+Zq9y42YmiRBklG+hKizaTzgzqKU13o7xzpEB1mgAI3xgX527USfptHa3tpAXNqkaiFJslZAIhE90CpmUAHu8amCpki4lMQmQVOcvmOmwB7vbaZUPsLV1UDoUFF6YbEFLrNYMC9FvhKYbfI+d/xPVmG2FCgZHcGRbIl3J0FS16yed4QJXJMOAB4x4t2Ov8Jtu7MH16uBBlHlANuXg1BTsx9Hgbz2UPcBFBNxfN9ieMPbPnaEmlIFmYXSD6Cq1Dyumc4M3GEYvPVE5DdzNZFBPfnje4Urg5+DTAb0xp8O066xhKZb8PmTrEDKnINIBs1hIc4qJfTb8ziiukU1SwpkR/603SCmKrDPZplbg9d8VuUa3WCGABBorsQlfxixEjyGm+99gA6FOvrb/I6cfryeSEyZWClSVRU8MplMhL+VzXFqFY2T7oqGRMEUAqCjBPScbXkL7gb/+40dw0A/gt0WIPSEToEaR1zpV3vHhhxD7/vfOv5AV9+2/dEepBU/siWGiS60u5IQVUwd03fpiOFsYY9nO53SmAG4ruFPEaA+T2En5qlRHsWxggiAuh81dzMGDXb8UGFnL6GYWvvMzBFWxUzNGDRDm8CaMHIlHcmk4OOUMNR0r6mlg0eoIaJadBbo++PHEnvi9EbSn8b0k3QT8gBtZdSCZl2Nmdth5Uf+IBiDARmtoSwcSjOgB4Ta1X3Z0X8hJqrQVAktxTMR8vvH9u4T2fNVCiYwSfYL9YtiDvDCHLhxGqALgG0Udy0MnES+IrrrHYrNPYlCn2Bwwyl+bTY9j1SSp saSVonLu wzApUbIsVEepjtJBV1YqM1eTFZ7RdzaQoZRYS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In order to move the heavy lifting into page_owner code, this one needs to have access to the stack_record structure, which right now sits in lib/stackdepot.c. Move it to the stackdepot.h header so page_owner can access stack_record's struct fields. Signed-off-by: Oscar Salvador Reviewed-by: Marco Elver Reviewed-by: Vlastimil Babka --- include/linux/stackdepot.h | 47 ++++++++++++++++++++++++++++++++++++++ lib/stackdepot.c | 43 ---------------------------------- 2 files changed, 47 insertions(+), 43 deletions(-) diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h index adcbb8f23600..c4b5ad57c066 100644 --- a/include/linux/stackdepot.h +++ b/include/linux/stackdepot.h @@ -30,6 +30,53 @@ typedef u32 depot_stack_handle_t; */ #define STACK_DEPOT_EXTRA_BITS 5 +#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) + +#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */ +#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER)) +#define DEPOT_STACK_ALIGN 4 +#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN) +#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \ + STACK_DEPOT_EXTRA_BITS) + +#ifdef CONFIG_STACKDEPOT +/* Compact structure that stores a reference to a stack. */ +union handle_parts { + depot_stack_handle_t handle; + struct { + /* pool_index is offset by 1 */ + u32 pool_index : DEPOT_POOL_INDEX_BITS; + u32 offset : DEPOT_OFFSET_BITS; + u32 extra : STACK_DEPOT_EXTRA_BITS; + }; +}; + +struct stack_record { + struct list_head hash_list; /* Links in the hash table */ + u32 hash; /* Hash in hash table */ + u32 size; /* Number of stored frames */ + union handle_parts handle; /* Constant after initialization */ + refcount_t count; + union { + unsigned long entries[CONFIG_STACKDEPOT_MAX_FRAMES]; /* Frames */ + struct { + /* + * An important invariant of the implementation is to + * only place a stack record onto the freelist iff its + * refcount is zero. Because stack records with a zero + * refcount are never considered as valid, it is safe to + * union @entries and freelist management state below. + * Conversely, as soon as an entry is off the freelist + * and its refcount becomes non-zero, the below must not + * be accessed until being placed back on the freelist. + */ + struct list_head free_list; /* Links in the freelist */ + unsigned long rcu_state; /* RCU cookie */ + }; + }; +}; +#endif + typedef u32 depot_flags_t; /* diff --git a/lib/stackdepot.c b/lib/stackdepot.c index c043a4186bc5..514b8d40ff57 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -36,55 +36,12 @@ #include #include -#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) - -#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */ -#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER)) -#define DEPOT_STACK_ALIGN 4 -#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN) -#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \ - STACK_DEPOT_EXTRA_BITS) #define DEPOT_POOLS_CAP 8192 /* The pool_index is offset by 1 so the first record does not have a 0 handle. */ #define DEPOT_MAX_POOLS \ (((1LL << (DEPOT_POOL_INDEX_BITS)) - 1 < DEPOT_POOLS_CAP) ? \ (1LL << (DEPOT_POOL_INDEX_BITS)) - 1 : DEPOT_POOLS_CAP) -/* Compact structure that stores a reference to a stack. */ -union handle_parts { - depot_stack_handle_t handle; - struct { - u32 pool_index : DEPOT_POOL_INDEX_BITS; /* pool_index is offset by 1 */ - u32 offset : DEPOT_OFFSET_BITS; - u32 extra : STACK_DEPOT_EXTRA_BITS; - }; -}; - -struct stack_record { - struct list_head hash_list; /* Links in the hash table */ - u32 hash; /* Hash in hash table */ - u32 size; /* Number of stored frames */ - union handle_parts handle; /* Constant after initialization */ - refcount_t count; - union { - unsigned long entries[CONFIG_STACKDEPOT_MAX_FRAMES]; /* Frames */ - struct { - /* - * An important invariant of the implementation is to - * only place a stack record onto the freelist iff its - * refcount is zero. Because stack records with a zero - * refcount are never considered as valid, it is safe to - * union @entries and freelist management state below. - * Conversely, as soon as an entry is off the freelist - * and its refcount becomes non-zero, the below must not - * be accessed until being placed back on the freelist. - */ - struct list_head free_list; /* Links in the freelist */ - unsigned long rcu_state; /* RCU cookie */ - }; - }; -}; - static bool stack_depot_disabled; static bool __stack_depot_early_init_requested __initdata = IS_ENABLED(CONFIG_STACKDEPOT_ALWAYS_INIT); static bool __stack_depot_early_init_passed __initdata; From patchwork Thu Feb 15 21:59:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13559172 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E6D1C48BEC for ; Thu, 15 Feb 2024 21:58:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A468A8D0019; Thu, 15 Feb 2024 16:58:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C6D78D0017; Thu, 15 Feb 2024 16:58:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77CB48D0019; Thu, 15 Feb 2024 16:58:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 617958D0017 for ; Thu, 15 Feb 2024 16:58:08 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 327E6120141 for ; Thu, 15 Feb 2024 21:58:08 +0000 (UTC) X-FDA: 81795401856.13.5943FF8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 039C840002 for ; Thu, 15 Feb 2024 21:58:05 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OdZe2HVT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nmku8TLu; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OdZe2HVT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nmku8TLu; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708034286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pcxp99FnLp1RnVVp7F0RPZtIZa/+vMDeTxogq7yX6CE=; b=Hu5gi0nb0RR2/uj3QP37lJVvxdfmICEIiLB9J3q6r56axnPwFUR7N/t85K2vWK1rbwD5IA IriWam6+aQqesSRXeIg60orLF6m3ZCOMGuLoTEarVKBvEIQ6g2KsIrIqQayIhRz6BodGl3 RAvASE9eyPj9aIsswQePiCtFgZHxiw4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OdZe2HVT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nmku8TLu; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OdZe2HVT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Nmku8TLu; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708034286; a=rsa-sha256; cv=none; b=QbU+oqLzSE/vLtsihG05tTke7ucEMt3eNpy0ltdKHfLFCiiSs9O0u+Ow40/MvIXSFSWtFy WCm4V8MtlHtkZC34LnPimv58lmrATq57VaNumI4ZnZFO8jS11/5rKXwQZSXtJvTyk/yDob p2rVthT8CxJVuNtS13R6wcceaNUfzgc= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 09430220A6; Thu, 15 Feb 2024 21:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pcxp99FnLp1RnVVp7F0RPZtIZa/+vMDeTxogq7yX6CE=; b=OdZe2HVToKR+dXod4mHXxxhQTyYmVE8e7iPBXbqfOUzVljTJpGs5Ga/r/LStLFWk2J7mPa 1sTa/uWN++cLaozklVYWtu1zJCOX+GVAlFVB3XEFsWLBKiEAptEJzMae/h5Ln+0lxFSISK BA4DYYqmjAPMrkAX4JTW2lh3xKsVfE8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pcxp99FnLp1RnVVp7F0RPZtIZa/+vMDeTxogq7yX6CE=; b=Nmku8TLuOVciMQqnVySHUqlbN4Yj+dlteZY+KFFJIRTwfSVWGNKbHU89jXYC10ZWs3n3Vi x2zhcwY5hjJikZBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pcxp99FnLp1RnVVp7F0RPZtIZa/+vMDeTxogq7yX6CE=; b=OdZe2HVToKR+dXod4mHXxxhQTyYmVE8e7iPBXbqfOUzVljTJpGs5Ga/r/LStLFWk2J7mPa 1sTa/uWN++cLaozklVYWtu1zJCOX+GVAlFVB3XEFsWLBKiEAptEJzMae/h5Ln+0lxFSISK BA4DYYqmjAPMrkAX4JTW2lh3xKsVfE8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pcxp99FnLp1RnVVp7F0RPZtIZa/+vMDeTxogq7yX6CE=; b=Nmku8TLuOVciMQqnVySHUqlbN4Yj+dlteZY+KFFJIRTwfSVWGNKbHU89jXYC10ZWs3n3Vi x2zhcwY5hjJikZBQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 7AAD51346A; Thu, 15 Feb 2024 21:58:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id GIBCG+uIzmXPAQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 21:58:03 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v10 3/7] mm,page_owner: Maintain own list of stack_records structs Date: Thu, 15 Feb 2024 22:59:03 +0100 Message-ID: <20240215215907.20121-4-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215215907.20121-1-osalvador@suse.de> References: <20240215215907.20121-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Queue-Id: 039C840002 X-Rspam-User: X-Stat-Signature: w6xhjqfdjdsjbbzf141m81cw6nmrgffn X-Rspamd-Server: rspam01 X-HE-Tag: 1708034285-842497 X-HE-Meta: U2FsdGVkX1++iuVN0TyGQ1deyyKFzY4uU8DaL9g7FITGUQwEBz3IRvn2oi5pE/npQ5gQZsG5Qoqd8nbOdrcPNo+5Nbl6vIyaW7+HyKWpsY2sXdhH2hLYtzeeCvXVOHQbdcsyh1l3+FDwpxWKp1aFCHAH+CjaPy6xipU6yh5slFUxpover/cY8ZGQXhCQpvueFcllrseH6p9tJl3sxubn5rt+3delZrr1brw5rnY8hbhjP40pwocvnF3TZp+UmQp19dyCFz4rafPJsbACAyLbe5Rw44Af2EHuQDnPWU0IF8NLtwHOAAP+P//GznyU3aSL+VptVj1zxMeevmoq46BljIkP7JCR9GEDB5xGuHi8o0OaGTUXW2barQ2Nd65kVB4Mjln/uhjGwHYv8TSZ6SCmW3sNGWWZ0dz7DgwH/kgz6+lXCRhX/Nuallj12GzXqN08proUJUlbjfhqG5Zx9aBHk3WdsY9Jeci/n3+gb4YStXyhnRmOh5yxITkoofRlTne2aSRX+cpGY+eAtekLOvXZPJKAthw9oETnZsdyJ0yNpKaqwgndRV/lkA0k5E2aoddb3xFvzswEkTe3A78ZO0bngH2TWyGyhFgSOFSWpwGDW+dLCQ13Jzk8O4v/TL87aQ4fdKpNcW0DwxU6/2/eMwrUNT0alhhZybNEhWem4O5k3FVASmhHWX4E1HKxmuqDSyCMLXQWB7oVIiWYDL7ZJECDYVgYz0ZXHWItKuacL+TBANplfAPpJBHLT6wYMHiWi1FjuAeSrOOx3uoF2XoDr1hZSy8yegyH5iTE+LjZwUOWExdE4UdIViUuh+1Ax8syRhwmpY9l5gSJGiqGEF6tBGe6eY8rXZPgBEfW/PKhLd8/Jeg1c86iv1mXUQQH4mKxKzOx4kvhOMlcyfMUdPywgscfJfEWoqpj0EzmqdVjapZ3ktvXnANpTwts72HYPQqvhlYMEriDcg5BKNA/hvmKmo8 +jsY1SNq aU3gBZPsEktzwFUcMJSH0O7zdyQPNzRNAMjCXwtCQjqQbaj9bamdrlwrt4gUlfLeHnjQ0yyr20MNdfTiHnuMoOSwvFIjyUSw3BLd+wPssDbGIH2K/s7QNzgEAe0Rga4WJQhhlbOlgykW2mLDzHEHKmiLRfXin9MPBNK44i6IJdrBvH5KCoXen+dF6Sj1ZxwnTm/f9JB72EFutjtPPmjILUvTcmPsvSlCUUq/zN8t/rE57tArffCOXqBbEWTfDBlAHz8wqISlizmwPVvB2OsgSQPaTaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: page_owner needs to increment a stack_record refcount when a new allocation occurs, and decrement it on a free operation. In order to do that, we need to have a way to get a stack_record from a handle. Implement __stack_depot_get_stack_record() which just does that, and make it public so page_owner can use it. Also, traversing all stackdepot buckets comes with its own complexity, plus we would have to implement a way to mark only those stack_records that were originated from page_owner, as those are the ones we are interested in. For that reason, page_owner maintains its own list of stack_records, because traversing that list is faster than traversing all buckets while keeping at the same time a low complexity. For now, add to stack_list only the stack_records of dummy_handle and failure_handle, and set their refcount of 1. Further patches will add code to increment or decrement stack_records count on allocation and free operation. Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka Reviewed-by: Marco Elver --- include/linux/stackdepot.h | 11 +++++++++++ lib/stackdepot.c | 8 ++++++++ mm/page_owner.c | 15 +++++++++++++++ 3 files changed, 34 insertions(+) diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h index c4b5ad57c066..3c6caa5abc7c 100644 --- a/include/linux/stackdepot.h +++ b/include/linux/stackdepot.h @@ -178,6 +178,17 @@ depot_stack_handle_t stack_depot_save_flags(unsigned long *entries, depot_stack_handle_t stack_depot_save(unsigned long *entries, unsigned int nr_entries, gfp_t gfp_flags); +/** + * __stack_depot_get_stack_record - Get a pointer to a stack_record struct + * + * @handle: Stack depot handle + * + * This function is only for internal purposes. + * + * Return: Returns a pointer to a stack_record struct + */ +struct stack_record *__stack_depot_get_stack_record(depot_stack_handle_t handle); + /** * stack_depot_fetch - Fetch a stack trace from stack depot * diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 514b8d40ff57..8c795bb20afb 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -687,6 +687,14 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries, } EXPORT_SYMBOL_GPL(stack_depot_save); +struct stack_record *__stack_depot_get_stack_record(depot_stack_handle_t handle) +{ + if (!handle) + return NULL; + + return depot_fetch_stack(handle); +} + unsigned int stack_depot_fetch(depot_stack_handle_t handle, unsigned long **entries) { diff --git a/mm/page_owner.c b/mm/page_owner.c index 5634e5d890f8..33e342b15d9b 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -36,6 +36,14 @@ struct page_owner { pid_t free_tgid; }; +struct stack { + struct stack_record *stack_record; + struct stack *next; +}; +static struct stack dummy_stack; +static struct stack failure_stack; +static struct stack *stack_list; + static bool page_owner_enabled __initdata; DEFINE_STATIC_KEY_FALSE(page_owner_inited); @@ -95,6 +103,13 @@ static __init void init_page_owner(void) register_early_stack(); static_branch_enable(&page_owner_inited); init_early_allocated_pages(); + /* Initialize dummy and failure stacks and link them to stack_list */ + dummy_stack.stack_record = __stack_depot_get_stack_record(dummy_handle); + failure_stack.stack_record = __stack_depot_get_stack_record(failure_handle); + refcount_set(&dummy_stack.stack_record->count, 1); + refcount_set(&failure_stack.stack_record->count, 1); + dummy_stack.next = &failure_stack; + stack_list = &dummy_stack; } struct page_ext_operations page_owner_ops = { From patchwork Thu Feb 15 21:59:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13559173 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F511C4829E for ; Thu, 15 Feb 2024 21:58:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F8998D001A; Thu, 15 Feb 2024 16:58:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 381468D0017; Thu, 15 Feb 2024 16:58:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 185418D001A; Thu, 15 Feb 2024 16:58:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EBDE58D0017 for ; Thu, 15 Feb 2024 16:58:08 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C798A140244 for ; Thu, 15 Feb 2024 21:58:08 +0000 (UTC) X-FDA: 81795401856.09.00AF53C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf06.hostedemail.com (Postfix) with ESMTP id C646C180012 for ; Thu, 15 Feb 2024 21:58:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EZ3PpDLz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pQlxj99O; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EZ3PpDLz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pQlxj99O; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708034287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UU5PIcSFlnhz6cXk2ilb785BgTp12PKW8ZT88F+31qU=; b=5Rl77FAl5V24ui2xJFrO+Vt7+c0J/d+KZj/7MNzPd7GX6BbJ6A2PMZu0nEEj5vShS3NF1p wtGP0Srjh66TIRmoCbjGiO3KZhKkURoVbUAYq33vQZpBbl1HwuXG7nIzqRnjed3ZwEYr6h BRlkxarLHH6K2HHus02ma04LquLsjOM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EZ3PpDLz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pQlxj99O; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EZ3PpDLz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pQlxj99O; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708034287; a=rsa-sha256; cv=none; b=nj0x5PxOntlu3U9ndyzOAPicAKQAcEpAWDG5DTAMOwtaqTQH/4QrWzmw4lYk5niPZls2SP NViqrYLIH6I+iQciMkl19o0JNSmfMXWVNvgWrngHqzcgM+UYZBJPzd6WlFyIwxMgFWX0kc UWinBwyYhGWSIwdo6m67IdnllHTCd9I= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 517541FB3E; Thu, 15 Feb 2024 21:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UU5PIcSFlnhz6cXk2ilb785BgTp12PKW8ZT88F+31qU=; b=EZ3PpDLzHqfRdouWrKvhiFgV/d57rIlBfkzEFeyn9bI4p0XEkUp6LGfHGT0d8U+HH0O+I+ UUFbv1XVGoHYvll7SY9AhBI1H4NXVxXclUOqSsAtlbJAkajRrm1qu4OsNEfCR2nf/YAUzo Uc+WfSXpdLQYwD19g60MvSZv9tGnQS8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UU5PIcSFlnhz6cXk2ilb785BgTp12PKW8ZT88F+31qU=; b=pQlxj99OEdxWMiTXrTx3SJlkXKfOYL+DB+G6s8TOPjqB+C6eeoZrfgF0Ow6P6DmFq934iG IYkyn+3KmGWoCnBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UU5PIcSFlnhz6cXk2ilb785BgTp12PKW8ZT88F+31qU=; b=EZ3PpDLzHqfRdouWrKvhiFgV/d57rIlBfkzEFeyn9bI4p0XEkUp6LGfHGT0d8U+HH0O+I+ UUFbv1XVGoHYvll7SY9AhBI1H4NXVxXclUOqSsAtlbJAkajRrm1qu4OsNEfCR2nf/YAUzo Uc+WfSXpdLQYwD19g60MvSZv9tGnQS8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UU5PIcSFlnhz6cXk2ilb785BgTp12PKW8ZT88F+31qU=; b=pQlxj99OEdxWMiTXrTx3SJlkXKfOYL+DB+G6s8TOPjqB+C6eeoZrfgF0Ow6P6DmFq934iG IYkyn+3KmGWoCnBg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id C264B1346A; Thu, 15 Feb 2024 21:58:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id SN7FLOyIzmXPAQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 21:58:04 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v10 4/7] mm,page_owner: Implement the tracking of the stacks count Date: Thu, 15 Feb 2024 22:59:04 +0100 Message-ID: <20240215215907.20121-5-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215215907.20121-1-osalvador@suse.de> References: <20240215215907.20121-1-osalvador@suse.de> MIME-Version: 1.0 X-Spamd-Bar: + X-Rspamd-Queue-Id: C646C180012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: bgzbwhdo7byhsd7rcxw7ez7z1e14393d X-HE-Tag: 1708034286-987764 X-HE-Meta: U2FsdGVkX19tRK4RJIG3hv9bEqMkHsq8V8vLtFvLWdLeR2OxEGfZXDbp04ORd4kB1rfpXz8la2bts1g7bV7xSGakTU0nUPCku3sWsdXAVx0EkrBorLf9NfocIVcin6kxdanzmtrT2wtRJbTZU5HPVH3032QG84AaxjUPU3uty5T6wxD+mlthh7+oMs67G9VFp1uru87YTOuFJAcOsZpfBgyCHVEtVjLZLy06Mv7X0VUEmCNt8yKukaI/LOB6R95S8MAedJQloXzFlaYl7oTNCQvmRd185zbYPGvCgdb47ZoWLHFMuU+oDDvk0emNdLALg0QhUjpJ9gNfm9EFCGBE/fRfqkoNPuINIKCnBDnf1BuL92QUMxrX2p5C6uyxFyKgCuc4vegOFEQEbrFm8YeQCiE3XtK+2ioroKOOmZSKmNYr8tMgpV5Bn4XrItZXZdarAZrfvktW+KauTNp9AcppsbuwD8K+HnIpsx0HPgIo1rni432SsE/6j5Qvbldo+zIprhsMlzVpv5e6c4Lm5OXzl0u3SahbreC94xGNxZSG+KzWcXCyhkYmvaov+8Dd+ky0EgzUk4/2T5YrRNyPkAnFceAD6Eu8Ir3eEQdtgTW34g9gSJ53iQRGHZwjGh1q6WauqmIxP7hu2FJUSWvcLLsUK5DXuMDLozTZfPTRSK/WrQE5esjXBcyOgrtiSB0og4kcoiU/JACH7ACAVH2o5yrDebeYooX3cu9iFxJ4iH42tBTXLflvfKQ2DN+H48aI/CTdayZVf7XMiRqy5DXWJHkeiLBLWSbbYKh9027AjK/AxoqZ9Dqsqe27EcF61B79DwGxk/aziUNP+78j4kuxyAk4P1BZ2XPFh/+Yn6M/HF0gTXWv+PxUTq9COeSRfCYtBd0PKeFSwcjwVR6R7/6XKLyiAMNFlhsaEsQu5q+QVyjLbhpVuC2KnSdSGdQd9dpWw7x0L73AhUNFj8FW09R0Hp8 mPBsW6+w CFOkaHv138oRuNyqH9o+BQIpx7RUJPhBQlymr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Implement {inc,dec}_stack_record_count() which increments or decrements on respective allocation and free operations, via __reset_page_owner() (free operation) and __set_page_owner() (alloc operation). Newly allocated stack_record structs will be added to the list stack_list via add_stack_record_to_list(). Modifications on the list are protected via a spinlock with irqs disabled, since this code can also be reached from IRQ context. Signed-off-by: Oscar Salvador Reviewed-by: Marco Elver Reviewed-by: Vlastimil Babka --- mm/page_owner.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index 33e342b15d9b..df6a923af5de 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -43,6 +43,7 @@ struct stack { static struct stack dummy_stack; static struct stack failure_stack; static struct stack *stack_list; +static DEFINE_SPINLOCK(stack_list_lock); static bool page_owner_enabled __initdata; DEFINE_STATIC_KEY_FALSE(page_owner_inited); @@ -150,11 +151,68 @@ static noinline depot_stack_handle_t save_stack(gfp_t flags) return handle; } +static void add_stack_record_to_list(struct stack_record *stack_record, + gfp_t gfp_mask) +{ + unsigned long flags; + struct stack *stack; + + /* Filter gfp_mask the same way stackdepot does, for consistency */ + gfp_mask &= ~GFP_ZONEMASK; + gfp_mask &= (GFP_ATOMIC | GFP_KERNEL); + gfp_mask |= __GFP_NOWARN; + + stack = kmalloc(sizeof(*stack), gfp_mask); + if (!stack) + return; + + stack->stack_record = stack_record; + stack->next = NULL; + + spin_lock_irqsave(&stack_list_lock, flags); + stack->next = stack_list; + stack_list = stack; + spin_unlock_irqrestore(&stack_list_lock, flags); +} + +static void inc_stack_record_count(depot_stack_handle_t handle, gfp_t gfp_mask) +{ + struct stack_record *stack_record = __stack_depot_get_stack_record(handle); + + if (!stack_record) + return; + + /* + * New stack_record's that do not use STACK_DEPOT_FLAG_GET start + * with REFCOUNT_SATURATED to catch spurious increments of their + * refcount. + * Since we do not use STACK_DEPOT_FLAG_GET API, let us + * set a refcount of 1 ourselves. + */ + if (refcount_read(&stack_record->count) == REFCOUNT_SATURATED) { + int old = REFCOUNT_SATURATED; + + if (atomic_try_cmpxchg_relaxed(&stack_record->count.refs, &old, 1)) + /* Add the new stack_record to our list */ + add_stack_record_to_list(stack_record, gfp_mask); + } + refcount_inc(&stack_record->count); +} + +static void dec_stack_record_count(depot_stack_handle_t handle) +{ + struct stack_record *stack_record = __stack_depot_get_stack_record(handle); + + if (stack_record) + refcount_dec(&stack_record->count); +} + void __reset_page_owner(struct page *page, unsigned short order) { int i; struct page_ext *page_ext; depot_stack_handle_t handle; + depot_stack_handle_t alloc_handle; struct page_owner *page_owner; u64 free_ts_nsec = local_clock(); @@ -162,17 +220,29 @@ void __reset_page_owner(struct page *page, unsigned short order) if (unlikely(!page_ext)) return; + page_owner = get_page_owner(page_ext); + alloc_handle = page_owner->handle; + handle = save_stack(GFP_NOWAIT | __GFP_NOWARN); for (i = 0; i < (1 << order); i++) { __clear_bit(PAGE_EXT_OWNER_ALLOCATED, &page_ext->flags); - page_owner = get_page_owner(page_ext); page_owner->free_handle = handle; page_owner->free_ts_nsec = free_ts_nsec; page_owner->free_pid = current->pid; page_owner->free_tgid = current->tgid; page_ext = page_ext_next(page_ext); + page_owner = get_page_owner(page_ext); } page_ext_put(page_ext); + if (alloc_handle != early_handle) + /* + * early_handle is being set as a handle for all those + * early allocated pages. See init_pages_in_zone(). + * Since their refcount is not being incremented because + * the machinery is not ready yet, we cannot decrement + * their refcount either. + */ + dec_stack_record_count(alloc_handle); } static inline void __set_page_owner_handle(struct page_ext *page_ext, @@ -214,6 +284,7 @@ noinline void __set_page_owner(struct page *page, unsigned short order, return; __set_page_owner_handle(page_ext, handle, order, gfp_mask); page_ext_put(page_ext); + inc_stack_record_count(handle, gfp_mask); } void __set_page_owner_migrate_reason(struct page *page, int reason) From patchwork Thu Feb 15 21:59:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13559174 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2459EC48BC4 for ; Thu, 15 Feb 2024 21:58:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66E1D8D001B; Thu, 15 Feb 2024 16:58:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F15C8D0017; Thu, 15 Feb 2024 16:58:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F6E78D001B; Thu, 15 Feb 2024 16:58:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 28A068D0017 for ; Thu, 15 Feb 2024 16:58:10 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 00CEE16071E for ; Thu, 15 Feb 2024 21:58:09 +0000 (UTC) X-FDA: 81795401940.02.10A9D51 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id E7119C0013 for ; Thu, 15 Feb 2024 21:58:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Lq1CI18k; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=j2jTR4Fa; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Lq1CI18k; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=j2jTR4Fa; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708034288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SgcBd7sH7Nb1byG5FyFq1szLLWX/BwNgi8qAPvNM0FU=; b=MVqCi/4md1QdzTI78rFilDCxbrXm0fetYqA/sT65qa07LaWrChB0nYFdwKZ5shsOVaxaUX fvzZaxTiALurCcg2Ck8WwaDpn/KqOETUns29kbJRVUwZe7KzN5at786m+1anly9acHTNyU j0qwYBLOdjz/rg+a/HBiKPojNZfbWkA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Lq1CI18k; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=j2jTR4Fa; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Lq1CI18k; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=j2jTR4Fa; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708034288; a=rsa-sha256; cv=none; b=LcKIt5F5pGPi5X7v8AcRnWowGo2CcaM9w7OzOn5ffMmMzSnRkzhZ+3wiK+CkkFqzhk4F+U 5jdxYK5Vu/UIroRI4jTxTjNXYwu2j0nZUnbeabtUp55YdFrsta2e8HgTMdpuyeWhNz20hX u79f5QEZAm0bIOt7TP3eOoiDv1v1W6g= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7E948220D6; Thu, 15 Feb 2024 21:58:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SgcBd7sH7Nb1byG5FyFq1szLLWX/BwNgi8qAPvNM0FU=; b=Lq1CI18k0Hlj84sJ6RGhkACsx+tVYQwKlKFcvoo+QvOizDFbET+y9Ru43hskhgx0Kor8mP jNRe0QFTA/E/wFVq/UZ69Nlqs/04LPD/EvFjdc8TmbedPYcuuptm/Pq56gk3nrx8Ky2Pen dd9jpObJx8kK4xra/4GWYZXQDzuQfXI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SgcBd7sH7Nb1byG5FyFq1szLLWX/BwNgi8qAPvNM0FU=; b=j2jTR4Fas0JFvwlYlzbtAxn3+b1OmQMTIE1FhifzQU/inbnZgVuPjzeb9E6zFUApxFuH8E SnYk16tt0hMQIXCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SgcBd7sH7Nb1byG5FyFq1szLLWX/BwNgi8qAPvNM0FU=; b=Lq1CI18k0Hlj84sJ6RGhkACsx+tVYQwKlKFcvoo+QvOizDFbET+y9Ru43hskhgx0Kor8mP jNRe0QFTA/E/wFVq/UZ69Nlqs/04LPD/EvFjdc8TmbedPYcuuptm/Pq56gk3nrx8Ky2Pen dd9jpObJx8kK4xra/4GWYZXQDzuQfXI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SgcBd7sH7Nb1byG5FyFq1szLLWX/BwNgi8qAPvNM0FU=; b=j2jTR4Fas0JFvwlYlzbtAxn3+b1OmQMTIE1FhifzQU/inbnZgVuPjzeb9E6zFUApxFuH8E SnYk16tt0hMQIXCw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id EF6891346A; Thu, 15 Feb 2024 21:58:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id eFbCN+2IzmXPAQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 21:58:05 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v10 5/7] mm,page_owner: Display all stacks and their count Date: Thu, 15 Feb 2024 22:59:05 +0100 Message-ID: <20240215215907.20121-6-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215215907.20121-1-osalvador@suse.de> References: <20240215215907.20121-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Queue-Id: E7119C0013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wm9xiz9c5c74fu3jubf3oudxc7dnzzx5 X-HE-Tag: 1708034287-845001 X-HE-Meta: U2FsdGVkX184GjAbtpUSmWIIqRFvTNtKvlnHcSIQEMhM0J8P6j4hGWb85M/2VHbBU1Syn6JvhPik4xP3xpK9HrSYb6zu7S2Xwx5Uc/lpSxEdySUkRm3b5OF9gFkny/BMwsc1s8Bu4wkm/sNus3gh3JAhQfKrfYPKmDdvlKJgLPg0m3swgPwbR0i3DOAtYBagW2/Ux2n1ft6lYQ5xkrofMGF8/M85MPBiD0qGkTQFhhys6xOZT7rmMkDS4SPsAVOSGROP4ldgxJfLwrPQlD+TFx11uruvwJuGr7qtWtvKOgjiBaxYnI5CtqdeEdEVf6Q8tROBywxaS4kNKX6+PKvrGv9XS3CsZywI32ccKFwFnlodOWRKSq1xTPEzkWi7jVJpGqaFNdR0Nk7qFvD925tnFdDtspneFkvnPhyLZGGfN5qBCapB7KnoTFQPGszCIlcP35Nd1QP1gaztTlgmmNDhqjtvTYy2YK1VpDr+6Oe8JiagRKMSyL2edhvSD1tUx0my1bEOO+xCh7NY4iboDkJxfsTh0Sf5jcV8/bM9kgQIdsW2+tn5hq/5g0pP6yt9B06qKq0HjE6XcC3FP5lC9Mloz6ZGsYmP4L4OrpVQPQeRtMifwt2rJFCpCwVnA3sbhiEl/dW1cvAjyXk0AvYo384foU9S1nC3HJpgRh5RIyZSmUeg3RftKhWAMzwVAh1VF7wnLucPpaAIk22v2Dz0ENUY+gei3zdT7zcThxVAWE7puu/BQrhK/fXWxJhtyBJnU3cfawXaRs2K7LJ77NYUbFkrr3YVNdJB7RnDOzvM/6mxbX+tnX45viK/eRxW5k2boILGgVr1+rQ5GI8xCQNKOxkn/KyJkDAw7pVwh69oxFwOwpchuTo4ggpwJsdGte5oFfhFkWAi1YiPx5XD0aZgqhRrAzVXFdWvB5YgCJTFuZRrWgItmxBAECa50PBnsltNjeFrKgWSWmvclg+5RGgxOTD 8QFgiKDu j9frt7CuThHo2woo3Pkfy4rQ0DubctJuHOprx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch adds a new directory called 'page_owner_stacks' under /sys/kernel/debug/, with a file called 'show_stacks' in it. Reading from that file will show all stacks that were added by page_owner followed by their counting, giving us a clear overview of stack <-> count relationship. E.g: prep_new_page+0xa9/0x120 get_page_from_freelist+0x801/0x2210 __alloc_pages+0x18b/0x350 alloc_pages_mpol+0x91/0x1f0 folio_alloc+0x14/0x50 filemap_alloc_folio+0xb2/0x100 __filemap_get_folio+0x14a/0x490 ext4_write_begin+0xbd/0x4b0 [ext4] generic_perform_write+0xc1/0x1e0 ext4_buffered_write_iter+0x68/0xe0 [ext4] ext4_file_write_iter+0x70/0x740 [ext4] vfs_write+0x33d/0x420 ksys_write+0xa5/0xe0 do_syscall_64+0x80/0x160 entry_SYSCALL_64_after_hwframe+0x6e/0x76 stack_count: 4578 The seq stack_{start,next} functions will iterate through the list stack_list in order to print all stacks. Signed-off-by: Oscar Salvador Acked-by: Marco Elver Reviewed-by: Vlastimil Babka --- mm/page_owner.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 92 insertions(+), 1 deletion(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index df6a923af5de..e99fbf822dd6 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -171,7 +171,13 @@ static void add_stack_record_to_list(struct stack_record *stack_record, spin_lock_irqsave(&stack_list_lock, flags); stack->next = stack_list; - stack_list = stack; + /* + * This pairs with smp_load_acquire() from function + * stack_start(). This guarantees that stack_start() + * will see an updated stack_list before starting to + * traverse the list. + */ + smp_store_release(&stack_list, stack); spin_unlock_irqrestore(&stack_list_lock, flags); } @@ -805,8 +811,90 @@ static const struct file_operations proc_page_owner_operations = { .llseek = lseek_page_owner, }; +static void *stack_start(struct seq_file *m, loff_t *ppos) +{ + struct stack *stack; + + if (*ppos == -1UL) + return NULL; + + if (!*ppos) { + /* + * This pairs with smp_store_release() from function + * add_stack_record_to_list(), so we get a consistent + * value of stack_list. + */ + stack = smp_load_acquire(&stack_list); + } else { + stack = m->private; + stack = stack->next; + } + + m->private = stack; + + return stack; +} + +static void *stack_next(struct seq_file *m, void *v, loff_t *ppos) +{ + struct stack *stack = v; + + stack = stack->next; + *ppos = stack ? *ppos + 1 : -1UL; + m->private = stack; + + return stack; +} + +static int stack_print(struct seq_file *m, void *v) +{ + int i, stack_count; + struct stack *stack = v; + unsigned long *entries; + unsigned long nr_entries; + struct stack_record *stack_record = stack->stack_record; + + nr_entries = stack_record->size; + entries = stack_record->entries; + stack_count = refcount_read(&stack_record->count) - 1; + + if (!nr_entries || nr_entries < 0 || stack_count < 1) + return 0; + + for (i = 0; i < nr_entries; i++) + seq_printf(m, " %pS\n", (void *)entries[i]); + seq_printf(m, "stack_count: %d\n\n", stack_count); + + return 0; +} + +static void stack_stop(struct seq_file *m, void *v) +{ +} + +static const struct seq_operations page_owner_stack_op = { + .start = stack_start, + .next = stack_next, + .stop = stack_stop, + .show = stack_print +}; + +static int page_owner_stack_open(struct inode *inode, struct file *file) +{ + return seq_open_private(file, &page_owner_stack_op, 0); +} + +static const struct file_operations page_owner_stack_operations = { + .open = page_owner_stack_open, + .read = seq_read, + .llseek = seq_lseek, + .release = seq_release, +}; + static int __init pageowner_init(void) { + struct dentry *dir; + if (!static_branch_unlikely(&page_owner_inited)) { pr_info("page_owner is disabled\n"); return 0; @@ -814,6 +902,9 @@ static int __init pageowner_init(void) debugfs_create_file("page_owner", 0400, NULL, NULL, &proc_page_owner_operations); + dir = debugfs_create_dir("page_owner_stacks", NULL); + debugfs_create_file("show_stacks", 0400, dir, NULL, + &page_owner_stack_operations); return 0; } From patchwork Thu Feb 15 21:59:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13559175 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1FFEC4829E for ; Thu, 15 Feb 2024 21:58:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DD178D001C; Thu, 15 Feb 2024 16:58:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 868C88D0017; Thu, 15 Feb 2024 16:58:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 668778D001C; Thu, 15 Feb 2024 16:58:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4D2CE8D0017 for ; Thu, 15 Feb 2024 16:58:12 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0F3D6A0EF9 for ; Thu, 15 Feb 2024 21:58:12 +0000 (UTC) X-FDA: 81795402024.18.4EFF201 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf22.hostedemail.com (Postfix) with ESMTP id CF37BC001B for ; Thu, 15 Feb 2024 21:58:09 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xKXjuvM6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ISzZj3yO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xKXjuvM6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ISzZj3yO; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708034290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TdFOtzOx20tmIdKDlysiVW3d7kQDyZIV9s1KqsDHXqU=; b=eC+S25xuOUxE/uE7P+8XMc0vnX2gmVFtrrzZH12h8yemfN3smsbv9nblZ3UgbvyIbnK0c6 8BDgfScL63aRzvISNmjci1TMpTDqdIQoN6sa3OiQdu32QkdgLvqaqTMsQq4SWOVXy/9nap DqFDxSdOUPhX0RI9w66iNDhNX785d+0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xKXjuvM6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ISzZj3yO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xKXjuvM6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ISzZj3yO; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708034290; a=rsa-sha256; cv=none; b=CaIq9LIANyvEmZgfG+bO2HD1ZGG/nUBkNtUKs4hrUYqlaJdD8kZSBxARy32YfZa7UCSOhe U1CLZ7n3kYuMBy3B+zJlV/u67gTY16inNDYeIAK4MGhKGPU6sZb6zKUAeTAz0igQE1FUBc gCQWFsMipYQsvPXevFdIWTcDCPz5saY= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 665111FB3D; Thu, 15 Feb 2024 21:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034288; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TdFOtzOx20tmIdKDlysiVW3d7kQDyZIV9s1KqsDHXqU=; b=xKXjuvM64ri4D1udjo/jUaR0xlKobKbyI/1DWsmWrRQm/ske/AndH267ENTEACSWoGiQ1K 8ETMBUYzKYV88SALUr1/KlcDe9zw0MBnWkpPXHLr+t3RP2R8ClJjBVnuFxArFufQl0yTxX bB767jlMSLQELB/TO3vVfQ0u8To9zAU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034288; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TdFOtzOx20tmIdKDlysiVW3d7kQDyZIV9s1KqsDHXqU=; b=ISzZj3yOabo2ChHLC1ocsTD4f+4ly25Gzqxmli5CBnhIYpISGnqIWI18xzqAUpZyD0OWNq YrATsok0rfl/DIAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034288; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TdFOtzOx20tmIdKDlysiVW3d7kQDyZIV9s1KqsDHXqU=; b=xKXjuvM64ri4D1udjo/jUaR0xlKobKbyI/1DWsmWrRQm/ske/AndH267ENTEACSWoGiQ1K 8ETMBUYzKYV88SALUr1/KlcDe9zw0MBnWkpPXHLr+t3RP2R8ClJjBVnuFxArFufQl0yTxX bB767jlMSLQELB/TO3vVfQ0u8To9zAU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034288; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TdFOtzOx20tmIdKDlysiVW3d7kQDyZIV9s1KqsDHXqU=; b=ISzZj3yOabo2ChHLC1ocsTD4f+4ly25Gzqxmli5CBnhIYpISGnqIWI18xzqAUpZyD0OWNq YrATsok0rfl/DIAA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 40B301346A; Thu, 15 Feb 2024 21:58:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id SM9hCe+IzmXPAQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 21:58:07 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v10 6/7] mm,page_owner: Filter out stacks by a threshold Date: Thu, 15 Feb 2024 22:59:06 +0100 Message-ID: <20240215215907.20121-7-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215215907.20121-1-osalvador@suse.de> References: <20240215215907.20121-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Queue-Id: CF37BC001B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: c5qiqbqph1yk8gd5r7pxgemhj6kiq4ac X-HE-Tag: 1708034289-809899 X-HE-Meta: U2FsdGVkX1+u13HqvcMVBhqq15DKnE5MwH9dPSETk1eQriK1JG8Ng6kv43ISyKEaAjxhLf4+gii4VTLPSlog6Cfsu9AAbcvAGjq+8xNmBh1wrptxkdLo4TdbRU4ar8AlfI585x6xvh+AOlK1u+Zu0E7GAC2jCvYctdfziwkJpUCK5KKfEl19OOeviida+JfLtJhceVbZUh6IMXRy/x7g75Qj6ktMp5ZoJ/x8fqPO2JAiuPo2xTXud5c1Ei8Iw2CYYO5In8J0N8Fm3g+K5KmeYvA4zVbrulddZ3elsc1gLmGJIUJCv9Z9xw2VZZmb+D4f+L//JsNCUyYieCXlSzb8Qgqx0NQ1mzHM4IoVMN7GZzzVVLUKGV/yYQUs2vCNJ8qqo5nUDkJH1b08GedcEgCMqEMfr3b9G5ffnoFMTB6M0LNgDS50eAYjwh3VL7AsGCTm/PrL28Z/BGeKOdDnePDOQ+gBvJt2T4pX6aBfIixAV5TSfclGU8iT4k62NHeHOGzo10OpLDoHNoREo8Ptj7IBj8pm6kLuac2ePHBCzfkLX5iK2N+joBgwvE0J5LbSc/a5x16wbW2wucuqSQvPj/5DkUaae8V7qWM5ul3x8CGTaaEvkkTtqpgR7wTCUOj/6rwwesvt1wbjwDZA8aWdlY5tjhijqeM+USFG+0duynop/cwjiQ+4hASQzD29QIKCXzx4zhgI7ObL+7eOLiKpBsMRv9hbft0X/H2DtdUtE8avjBUAbM2lxsPQ1Z+/htn6BAXPlge5bOrtTwjMzekK4kIQCyOV/J9uNShijimiANY1OhOdeC33NBsmeGJq6au57HBC0OWdnhlL++LjWcnWa6F97jDj1IhdcjrHPsO5cKK0i+1K15b1+J+Ol2LCTo5wPuEHvkTGhrsBVLKNycZa9zp3cx9LnXnjDHNBHi/NE8XBBLr2isLd6drAAWWib8fTrc/zweZ3txLqOx+8XR30rke iFTsx5E2 I8zyDp1scnMhM+iwaephD4C4kBfGQxlp8yY6FLtJXK7ztzmb6N6f4qpaAoVFmRRg6tASgKbgzho+HElsjjXj3DtLJHkMT3BaCzw6davlL4lcJ2QuS00Mnb73BwyT8tvBhlKbrUSmYK91wJKXR/u/EjlB86LfJY6IoRhochg791gYocNqgoMItzALMiK1p3YmbwWH0ikGjtiswBSajcW3bw5l8/PaLpBiOfg53UC/Wa0FSoGGGUZOPHL9gs2dYlSHQBKgM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We want to be able to filter out the stacks based on a threshold we can can tune. By writing to 'count_threshold' file, we can adjust the threshold value. Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka --- mm/page_owner.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index e99fbf822dd6..e56c1e92eccf 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -846,6 +846,8 @@ static void *stack_next(struct seq_file *m, void *v, loff_t *ppos) return stack; } +static unsigned long page_owner_stack_threshold; + static int stack_print(struct seq_file *m, void *v) { int i, stack_count; @@ -858,7 +860,8 @@ static int stack_print(struct seq_file *m, void *v) entries = stack_record->entries; stack_count = refcount_read(&stack_record->count) - 1; - if (!nr_entries || nr_entries < 0 || stack_count < 1) + if (!nr_entries || nr_entries < 0 || stack_count < 1 || + stack_count < page_owner_stack_threshold) return 0; for (i = 0; i < nr_entries; i++) @@ -891,6 +894,22 @@ static const struct file_operations page_owner_stack_operations = { .release = seq_release, }; +static int page_owner_threshold_get(void *data, u64 *val) +{ + *val = READ_ONCE(page_owner_stack_threshold); + return 0; +} + +static int page_owner_threshold_set(void *data, u64 val) +{ + WRITE_ONCE(page_owner_stack_threshold, val); + return 0; +} + +DEFINE_SIMPLE_ATTRIBUTE(proc_page_owner_threshold, &page_owner_threshold_get, + &page_owner_threshold_set, "%llu"); + + static int __init pageowner_init(void) { struct dentry *dir; @@ -905,6 +924,8 @@ static int __init pageowner_init(void) dir = debugfs_create_dir("page_owner_stacks", NULL); debugfs_create_file("show_stacks", 0400, dir, NULL, &page_owner_stack_operations); + debugfs_create_file("count_threshold", 0600, dir, NULL, + &proc_page_owner_threshold); return 0; } From patchwork Thu Feb 15 21:59:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13559176 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADCFDC4829E for ; Thu, 15 Feb 2024 21:58:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E1A08D001D; Thu, 15 Feb 2024 16:58:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F5FA8D0017; Thu, 15 Feb 2024 16:58:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F7C18D001D; Thu, 15 Feb 2024 16:58:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 27B3B8D0017 for ; Thu, 15 Feb 2024 16:58:16 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EE8C61C1A54 for ; Thu, 15 Feb 2024 21:58:15 +0000 (UTC) X-FDA: 81795402150.17.172612C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id B0BEE1C0019 for ; Thu, 15 Feb 2024 21:58:13 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LJB6aK5O; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=yjRw1o2a; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LJB6aK5O; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=yjRw1o2a; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708034294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=45ycMV23TmrOoOgGTYCtcczz/iV5aW1RGHy4jThaFhM=; b=mpH+VufE94OiKEdS0oxi1ql1tEmL5OWm3RRdEANfemyKhcHQAKDdF9SYXWnjZ78yeJ8hnN W9pPjd6hXHRRCeezAziLoUhVBuZvoAccERC4hHpaz1OvmSyCbT49XXZNvH+NIbxONqIQJ4 FOorya1eSEiJR4NzXbSn36pCvYlbOAo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708034294; a=rsa-sha256; cv=none; b=Pyhlbpsb1SHT1C6N9U0XhluXZk5cYOxA/taKxGCU2j+5fjxrORtEa+g6klqWrdKyQymv0z vJPNsJ8UFkIsfYAYX6vxlFP7d7TslcpdTNige4EIO4Qa/L6OVYCX1Wlw9KRbDH3nVAHJ8Q wJuxZ3h6Ho4VGQwAlW8vkOnmHKhCilE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LJB6aK5O; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=yjRw1o2a; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LJB6aK5O; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=yjRw1o2a; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 43E60220A6; Thu, 15 Feb 2024 21:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=45ycMV23TmrOoOgGTYCtcczz/iV5aW1RGHy4jThaFhM=; b=LJB6aK5OjyTaCsvR/Y/MYtJhQBBo677GYHNToIlp0BrUevFN/3pIcfZe3+64Sf7R+SkLlC 1sDXYhcKZW5Mv+LDQhc1WB5vnajZeF3sHR30b6d7CWWXYFs43wDicC8BiLt7A25Tu/7ers MmYc5Aysfb+HRQPW+AX8BtKFCOpObL0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=45ycMV23TmrOoOgGTYCtcczz/iV5aW1RGHy4jThaFhM=; b=yjRw1o2arAmOwuH6tTsX4slhZ4kvqiJ9bnKXfwy1k8W4FziPhlqX4a8OC35C3jV+ZpcEIX UB7FIoWfnHXvuCCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708034292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=45ycMV23TmrOoOgGTYCtcczz/iV5aW1RGHy4jThaFhM=; b=LJB6aK5OjyTaCsvR/Y/MYtJhQBBo677GYHNToIlp0BrUevFN/3pIcfZe3+64Sf7R+SkLlC 1sDXYhcKZW5Mv+LDQhc1WB5vnajZeF3sHR30b6d7CWWXYFs43wDicC8BiLt7A25Tu/7ers MmYc5Aysfb+HRQPW+AX8BtKFCOpObL0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708034292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=45ycMV23TmrOoOgGTYCtcczz/iV5aW1RGHy4jThaFhM=; b=yjRw1o2arAmOwuH6tTsX4slhZ4kvqiJ9bnKXfwy1k8W4FziPhlqX4a8OC35C3jV+ZpcEIX UB7FIoWfnHXvuCCQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id DD8561346A; Thu, 15 Feb 2024 21:58:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id QE89M/GIzmXPAQAAn2gu4w (envelope-from ); Thu, 15 Feb 2024 21:58:09 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v10 7/7] mm,page_owner: Update Documentation regarding page_owner_stacks Date: Thu, 15 Feb 2024 22:59:07 +0100 Message-ID: <20240215215907.20121-8-osalvador@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215215907.20121-1-osalvador@suse.de> References: <20240215215907.20121-1-osalvador@suse.de> MIME-Version: 1.0 X-Spamd-Bar: ++++ X-Stat-Signature: k9411qzmghrnahxp83747ibinootqp7c X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B0BEE1C0019 X-Rspam-User: X-HE-Tag: 1708034293-310934 X-HE-Meta: U2FsdGVkX1/JihRlA3cio4yq+1opox9PTL7EICdPTw0Lsr51Zl/r+ewWrSzeV+MgLX59zKWsT+B9trG0nTCCdZtx5VOoAtribgwV81blAFSpI1JvyvmJYS/g+4Vn39lF4M6rfzVEivh5MBSN80Uw6/atUvoV70fNr/HTg4i59uuNKEVPK4/N5XaFcy+wnXqlBSTptYDp6RIz1M5IkEkQ9RvHAafXnGHvq49MVmsRQHn35XOnmKUOpzf3F4h2+2UgaUC0QOW0CKyZVtwzKiJZBGvYPcMGVrrJnyibnxpkVWgmwe5dkgG91dgnHesG1NX7AsXGkI8y4XgfCdSnwsqHo+Lv5XwLZwtvytsmextdm9vKfUajBF4+Qj5Nu+CnPKf1l7jtKq++gOP7lsiSyhdU/oxWj6IOlwLdNwgWsP0UVYEJ+qYTMh+dZE8c17y5WKLyI+eIzJwYjvlfGT6aLW1bXFY7cCbETEuR0AMNl2xB7mO8+E6NOov5/Tqt1I1G2xsz0oSeaKuYgFRsWrzjUymzlU6jBjGN1aA6SXk10UF2s7tojb5LRyvUWOcrbh/Fz5C0CkpeT/4DCuLsdbYGEGeu15kGSP2eJf1EATCycRji/m167dxxGMHq8+I8FwHP27bKFFiaucwbY91+7NfKsfsuN3rS92ZqYy4pzrA27+nQWyiLOzUeCreTaLSItfAfthk+OmDLsUCDb4y3wM0PRqa0MGpXX3AqRVfRrSYdHkFPgZN0hvYUhv576rAuAc6OtjtLFtum19obevKpHIqYsObSl3gRLqRj9hVSt3EWGUT+K2A+Hcx0j4cwaRDs2xiIMrkQz2QPSK8Jx9Ch2LxPNXkli09KJedfLGShfLGktNfVUP3FBQxsZlD6ApZjNMGBKO6vwtpbgx2wtYSkUebhiIo4aR65oGMoC1JDKR0tq4sGoN1DzXA1Xxz6h7FVdZukIxtyy0uRKAoKIv+AhZV/xGf 8ZLFqSYj M0E2zgbSXp3CkLLBGppYcm/YkT+9/FoMyaTfRtwrlCnWGmUzLcBatnpo8602JbV7j//mFB30jkY90KPWfjzi9Co8rE5D3ye5toHlEHGw8ORSr6E3ojcLxBXOEIPQJ3JEQYLGs1uzqsBvZJ6m9v5wfYTPfX14fRZUdtztldlY1ez3HpAgpEKCD8x92juO9DUwRdyhw3Ak0EmULKmW9KMP2mlJ+WhzATLRGmE5EE74J6ZeYavUyNDTJsreP2isFeAC2kr6J3nf5rnEKAo+JUOeWV+j86HflcHuKWCYYeIjdd0Ape5DBH6/Wh08QJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Update page_owner documentation including the new page_owner_stacks feature to show how it can be used. Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka Reviewed-by: Marco Elver --- Documentation/mm/page_owner.rst | 45 +++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst index 62e3f7ab23cc..0d0334cd5179 100644 --- a/Documentation/mm/page_owner.rst +++ b/Documentation/mm/page_owner.rst @@ -24,6 +24,11 @@ fragmentation statistics can be obtained through gfp flag information of each page. It is already implemented and activated if page owner is enabled. Other usages are more than welcome. +It can also be used to show all the stacks and their outstanding +allocations, which gives us a quick overview of where the memory is going +without the need to screen through all the pages and match the allocation +and free operation. + page owner is disabled by default. So, if you'd like to use it, you need to add "page_owner=on" to your boot cmdline. If the kernel is built with page owner and page owner is disabled in runtime due to not enabling @@ -68,6 +73,46 @@ Usage 4) Analyze information from page owner:: + cat /sys/kernel/debug/page_owner_stacks/show_stacks > stacks.txt + cat stacks.txt + prep_new_page+0xa9/0x120 + get_page_from_freelist+0x7e6/0x2140 + __alloc_pages+0x18a/0x370 + new_slab+0xc8/0x580 + ___slab_alloc+0x1f2/0xaf0 + __slab_alloc.isra.86+0x22/0x40 + kmem_cache_alloc+0x31b/0x350 + __khugepaged_enter+0x39/0x100 + dup_mmap+0x1c7/0x5ce + copy_process+0x1afe/0x1c90 + kernel_clone+0x9a/0x3c0 + __do_sys_clone+0x66/0x90 + do_syscall_64+0x7f/0x160 + entry_SYSCALL_64_after_hwframe+0x6c/0x74 + stack_count: 234 + ... + ... + echo 7000 > /sys/kernel/debug/page_owner_stacks/count_threshold + cat /sys/kernel/debug/page_owner_stacks/show_stacks> stacks_7000.txt + cat stacks_7000.txt + prep_new_page+0xa9/0x120 + get_page_from_freelist+0x7e6/0x2140 + __alloc_pages+0x18a/0x370 + alloc_pages_mpol+0xdf/0x1e0 + folio_alloc+0x14/0x50 + filemap_alloc_folio+0xb0/0x100 + page_cache_ra_unbounded+0x97/0x180 + filemap_fault+0x4b4/0x1200 + __do_fault+0x2d/0x110 + do_pte_missing+0x4b0/0xa30 + __handle_mm_fault+0x7fa/0xb70 + handle_mm_fault+0x125/0x300 + do_user_addr_fault+0x3c9/0x840 + exc_page_fault+0x68/0x150 + asm_exc_page_fault+0x22/0x30 + stack_count: 8248 + ... + cat /sys/kernel/debug/page_owner > page_owner_full.txt ./page_owner_sort page_owner_full.txt sorted_page_owner.txt