From patchwork Fri Feb 16 06:53:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559587 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE6BAC48260 for ; Fri, 16 Feb 2024 06:53:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DDD210E350; Fri, 16 Feb 2024 06:53:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="W6rw1uNd"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0CB7210E350 for ; Fri, 16 Feb 2024 06:53:36 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7038B61EFF; Fri, 16 Feb 2024 06:53:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6C93C43390; Fri, 16 Feb 2024 06:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066415; bh=S4KYIAgS4mvLQSOwp8dAYCk+tnxgKRZCI0XPqNFrrhs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W6rw1uNdI2qWadebU+FZ6zBEiJarygA8OEobGVeQkQxUePa25tpohVS4Yh7qOF7jm QKlWeEUAAqX63u7U4OTFKOQvqEAr/CqKLiZIdyHflQk7meZpfAqw1HdvrUWPHONJmA 943Iuu9VBxclR6A1xNs/H3IJGfsprJrAeylDbmtfCx6ZaYOBqlo0CwxLYYZA/je7nw W/oESRD+0BCAHMxtta6RdXxl5WK0shyOFj1N7f9jlCgUc6P+78zTYb2KY8KXPgh8rR NG/WjZaVKRWSNQ4syOmwIqGR2MZNDTHcfFzdJj5vghS6n2NlUYVFQ2LBWW8svk59pz TVtcWD3fspCKw== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 01/21] drm/i915: remove unused intel_dvo_dev_ops hooks Date: Fri, 16 Feb 2024 07:53:06 +0100 Message-ID: <20240216065326.6910-2-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" struct intel_dvo_dev_ops's ::create_resources(), ::prepare(), ::commit::, and get_modes() are all unused since their addition in 79e539453b34 (DRM: i915: add mode setting support). Drop all of them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/display/intel_dvo_dev.h | 25 -------------------- 1 file changed, 25 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h index f7e98e1c6470..af7b04539b93 100644 --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h @@ -53,12 +53,6 @@ struct intel_dvo_dev_ops { bool (*init)(struct intel_dvo_device *dvo, struct i2c_adapter *i2cbus); - /* - * Called to allow the output a chance to create properties after the - * RandR objects have been created. - */ - void (*create_resources)(struct intel_dvo_device *dvo); - /* * Turn on/off output. * @@ -79,16 +73,6 @@ struct intel_dvo_dev_ops { enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo, struct drm_display_mode *mode); - /* - * Callback for preparing mode changes on an output - */ - void (*prepare)(struct intel_dvo_device *dvo); - - /* - * Callback for committing mode changes on an output - */ - void (*commit)(struct intel_dvo_device *dvo); - /* * Callback for setting up a video mode after fixups have been made. * @@ -111,15 +95,6 @@ struct intel_dvo_dev_ops { */ bool (*get_hw_state)(struct intel_dvo_device *dev); - /** - * Query the device for the modes it provides. - * - * This function may also update MonInfo, mm_width, and mm_height. - * - * \return singly-linked list of modes or NULL if no modes found. - */ - struct drm_display_mode *(*get_modes)(struct intel_dvo_device *dvo); - /** * Clean up driver-specific bits of the output */ From patchwork Fri Feb 16 06:53:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559588 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01252C48BEC for ; Fri, 16 Feb 2024 06:53:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CAD810E374; Fri, 16 Feb 2024 06:53:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Y0o9/HY5"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6C86A10E374 for ; Fri, 16 Feb 2024 06:53:39 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CE75061EF8; Fri, 16 Feb 2024 06:53:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07D32C433C7; Fri, 16 Feb 2024 06:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066418; bh=pXw6+3BPDvBumd0PwA+aAJatufGvT44a+p6B8ZAqPXg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y0o9/HY5F2PEyFbtUd5uHnUb/4bjqoiE6DU767MASXwLFxpanMtU0lFrsZqH5Gcd4 bl31pIfTFA1GIkCS+R14e6FV07Q1o+mxoAJks1TRO/5lzULPAcdP2eyTcaj+sM/zdL N4DUmtOI535iN6br5CyWlxIWHauPYOu15R1JkWglfRgQURsD92lxkH0yjA0ukxa40x fjTvpX6mtC2IHEWFnt+Az3SDHBtGC4+q+hidXBhZcrL/ZtRo5+6Nzds08IkoYDmjKr Q/RR2v8rYegAQ8VsJ1k8b0BYpittp5xJW9yvbgiehpOARow5a90hLFVe4r413/KnAM HKTww1cbxWHRw== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 02/21] drm/i915: remove structs intel_vgpu_pipe_format and intel_vgpu_fb_format Date: Fri, 16 Feb 2024 07:53:07 +0100 Message-ID: <20240216065326.6910-3-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Both struct intel_vgpu_pipe_format and intel_vgpu_fb_format were never used since its addition in commit 9f31d1063b43 (drm/i915/gvt: Add framebuffer decoder support). Drop them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/fb_decoder.h | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/fb_decoder.h b/drivers/gpu/drm/i915/gvt/fb_decoder.h index 4eff44194439..fa6503900c84 100644 --- a/drivers/gpu/drm/i915/gvt/fb_decoder.h +++ b/drivers/gpu/drm/i915/gvt/fb_decoder.h @@ -152,17 +152,6 @@ struct intel_vgpu_cursor_plane_format { u32 y_hot; /* in pixels */ }; -struct intel_vgpu_pipe_format { - struct intel_vgpu_primary_plane_format primary; - struct intel_vgpu_sprite_plane_format sprite; - struct intel_vgpu_cursor_plane_format cursor; - enum DDI_PORT ddi_port; /* the DDI port that pipe is connected to */ -}; - -struct intel_vgpu_fb_format { - struct intel_vgpu_pipe_format pipes[I915_MAX_PIPES]; -}; - int intel_vgpu_decode_primary_plane(struct intel_vgpu *vgpu, struct intel_vgpu_primary_plane_format *plane); int intel_vgpu_decode_cursor_plane(struct intel_vgpu *vgpu, From patchwork Fri Feb 16 06:53:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E716C48260 for ; Fri, 16 Feb 2024 06:53:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A315B10E38F; Fri, 16 Feb 2024 06:53:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="mLD6gqCd"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id A0C1010E38F for ; Fri, 16 Feb 2024 06:53:42 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1449061EFE; Fri, 16 Feb 2024 06:53:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BF4EC43390; Fri, 16 Feb 2024 06:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066421; bh=amudruWj9HLCey00JO7KSVlxOakx7qFxQBUB40Y74us=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mLD6gqCd+4bBf7thLiyk9DVfkCA8lRghiFBtNXzuEQ2h1aaq0lwuSuqaVrzZ9L4lw XWDIHc0l7tRFoASez4k/goMJyHoNQNMi7l6m70P8Hq+AAOQaD9QFZasMxiT0Vmxw4C aQHgZVvrnfHtLMLfXkht+oTJSGfrF2+UbkMSt8IZoQxq1xpMQz5ca+sNGsqNCtzfxA P6fO2HgYcv4oC/So+Gqxg6oWWXnp+nwBXMjx0FLDG4H84S/4oa2ab+ryhDsmdVC5aT 7tU4WNDeciASWvRQRXWYv0sSOEJXWVY0QfzfAPpFl4UbyjYDcy2C5P1aNJPkLR42d8 9xNhKMtdF4FpA== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 03/21] drm/i915: remove intel_dsi::{port_bits,hs} Date: Fri, 16 Feb 2024 07:53:08 +0100 Message-ID: <20240216065326.6910-4-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_dsi::port_bits is unused since commit 369602d370fa (drm/i915: Add support for port enable/disable for dual link configuration) and ::hs is unused likely since commit 063c86f60ad4 (drm/i915/dsi: remove intel_dsi_cmd.c and the unused functions therein). Drop them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/display/intel_dsi.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dsi.h b/drivers/gpu/drm/i915/display/intel_dsi.h index 083390e5e442..e99c94edfaae 100644 --- a/drivers/gpu/drm/i915/display/intel_dsi.h +++ b/drivers/gpu/drm/i915/display/intel_dsi.h @@ -57,9 +57,6 @@ struct intel_dsi { u16 phys; /* ICL DSI */ }; - /* if true, use HS mode, otherwise LP */ - bool hs; - /* virtual channel */ int channel; @@ -93,7 +90,6 @@ struct intel_dsi { bool bgr_enabled; u8 pixel_overlap; - u32 port_bits; u32 bw_timer; u32 dphy_reg; From patchwork Fri Feb 16 06:53:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559590 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E148C48BEC for ; Fri, 16 Feb 2024 06:53:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 341BA10E1A7; Fri, 16 Feb 2024 06:53:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="AZfOy8AS"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4248610E3DB for ; Fri, 16 Feb 2024 06:53:46 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9933C61EFF; Fri, 16 Feb 2024 06:53:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 932E8C433C7; Fri, 16 Feb 2024 06:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066425; bh=sH0FzSylb4GHpKMjELKxOSqoIZwIATsF0+uo2uRnxfE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AZfOy8AS1VK794BqL6EDv6yN4/raYXNT5U7KlgAdOJiZS4GPNDzMCLba4+68d/6CH fQweIQd5bMxXv8H33HHDsDkqEnikj528gOFmAc3ypAnDT2qYip7vOoZOqlYZuRGorc xeiSKoxWi7pPX0S3hJF9YETECd9RujLyhyKZqqV/lcAQOClVYwOFp9EnO39LsUSKG1 aFFlIuiXlycxCnHFJ26ihTzCPz7pfYIiERAKyExjotKbiIzg9VuxrVuoFvvaac2nFj 0M07qcJK7luruzbR+Ai8jXgBVZcXkYWynqFyfjqq4KEm4LqbG8gpdPvoIp/BxqfDug RfX7JfabFHc0A== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 04/21] drm/i915: remove intel_gvt_gtt::{mm_alloc_page_table, mm_free_page_table} Date: Fri, 16 Feb 2024 07:53:09 +0100 Message-ID: <20240216065326.6910-5-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_gvt_gtt::{mm_alloc_page_table,mm_free_page_table} are not used since commit ede9d0cfcb78 (drm/i915/gvt: Rework shadow graphic memory management code). Drop them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/gtt.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/gtt.h b/drivers/gpu/drm/i915/gvt/gtt.h index 4cb183e06e95..fb96ea454fd1 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.h +++ b/drivers/gpu/drm/i915/gvt/gtt.h @@ -93,8 +93,6 @@ struct intel_gvt_gtt_gma_ops { struct intel_gvt_gtt { const struct intel_gvt_gtt_pte_ops *pte_ops; const struct intel_gvt_gtt_gma_ops *gma_ops; - int (*mm_alloc_page_table)(struct intel_vgpu_mm *mm); - void (*mm_free_page_table)(struct intel_vgpu_mm *mm); struct list_head oos_page_use_list_head; struct list_head oos_page_free_list_head; struct mutex ppgtt_mm_lock; From patchwork Fri Feb 16 06:53:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69C4DC48260 for ; Fri, 16 Feb 2024 06:53:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE1E810E3DB; Fri, 16 Feb 2024 06:53:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="u7Qk1Sx4"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4072C10E3DB for ; Fri, 16 Feb 2024 06:53:49 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B2BBE61F09; Fri, 16 Feb 2024 06:53:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F02DC433A6; Fri, 16 Feb 2024 06:53:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066428; bh=qkEq3E8Km4jpaGRnx1Vm2eeB5z7Na+ns2sz54n6h9uI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u7Qk1Sx4GA+PGmFjQyCFB2rBOZ8P5QWLyc9Jh5KlH9OocfGntKGl75SuUz2Bi+9J4 3I5IfLJuVP+ogCoPL4n9b8H/U3Kr9ev+t5BHRElOVCFHW9FERbXvNH/eVG0iuhqURy Z+OMoy66+JIxkK9LzplSveGRMzqKLuPd4L3SwrGP46ODY1hm71WVuRIspzO50219nx N/DizssclSDGn1Sup9OZ4A0csADlHybg9vVfZ60a018fmhWDovvO8GvF71UcODibIu 6FBKW9V5mCgdrU19Lzl0/nnqd/D90L6uytIClTUUfNpDReTZSpSDuGpO5Zgzqh5+Gn EMDkYkElKaqqw== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 05/21] drm/i915: remove intel_gvt_mmio_info::{device, addr_range} Date: Fri, 16 Feb 2024 07:53:10 +0100 Message-ID: <20240216065326.6910-6-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_gvt_mmio_info::device is not used since commit e0f74ed4634d (i915/gvt: Separate the MMIO tracking table from GVT-g) and ::addr_range was never used since its addition in commit 12d14cc43b34 (drm/i915/gvt: Introduce a framework for tracking HW registers.). Drop them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/mmio.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/mmio.h b/drivers/gpu/drm/i915/gvt/mmio.h index bba154e38705..32ebacb078e8 100644 --- a/drivers/gpu/drm/i915/gvt/mmio.h +++ b/drivers/gpu/drm/i915/gvt/mmio.h @@ -62,10 +62,8 @@ typedef int (*gvt_mmio_func)(struct intel_vgpu *, unsigned int, void *, struct intel_gvt_mmio_info { u32 offset; u64 ro_mask; - u32 device; gvt_mmio_func read; gvt_mmio_func write; - u32 addr_range; struct hlist_node node; }; From patchwork Fri Feb 16 06:53:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559592 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE300C48260 for ; Fri, 16 Feb 2024 06:53:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DE8410E42D; Fri, 16 Feb 2024 06:53:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="gRSpAaUC"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBBF210E432 for ; Fri, 16 Feb 2024 06:53:51 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5E5B761EB1; Fri, 16 Feb 2024 06:53:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A57AC433C7; Fri, 16 Feb 2024 06:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066431; bh=eet1vEI7EGs4P/wMxc9m6gOO4iuk9u8MjHggPAsGzEc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gRSpAaUCq7sEC/LdG4M3Prfc0JaS8gfE/ZNfbr3xXAa+cwpwcDl0zfq9KRfMRwunE aHcasZ3/yonQzNLzyHiKFokR5zQLwEFmz09UtPTvTA6EHbgwoxRfP6x9+QRmKiMWLp eb9q0U0C54U5xO41R0JDA8qHjM3CNOrK5qJ6kfnBILsh3qHGe8z19tZOP9bA1Cf2VC 3zSma9BWhPEotfmdH+P2JQlG1fsMRTBltcDKbRAIisxZCc7TPD3Pgcm5BjXd78B+H8 tqBf+civB8pKDnVAZvqVu3UPWKMVNrkl89yjMvFOIa0EqiblkauoZBCEA4c7kRpqkN qIav2T3ztQW8w== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 06/21] drm/i915: remove intel_vgpu_workload::{ring_context, restore_inhibit} Date: Fri, 16 Feb 2024 07:53:11 +0100 Message-ID: <20240216065326.6910-7-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_vgpu_workload::ring_context was never used since its addition in commit 28c4c6ca7f79 (drm/i915/gvt: vGPU workload submission) and ::restore_inhibit since its addition in commit e473405783c0 (drm/i915/gvt: vGPU workload scheduler). Drop them. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/scheduler.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/scheduler.h b/drivers/gpu/drm/i915/gvt/scheduler.h index 1f391b3da2cc..cd94993278b6 100644 --- a/drivers/gpu/drm/i915/gvt/scheduler.h +++ b/drivers/gpu/drm/i915/gvt/scheduler.h @@ -104,10 +104,8 @@ struct intel_vgpu_workload { /* execlist context information */ struct execlist_ctx_descriptor_format ctx_desc; - struct execlist_ring_context *ring_context; unsigned long rb_head, rb_tail, rb_ctl, rb_start, rb_len; unsigned long guest_rb_head; - bool restore_inhibit; struct intel_vgpu_elsp_dwords elsp_dwords; bool emulate_schedule_in; atomic_t shadow_ctx_active; From patchwork Fri Feb 16 06:53:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559593 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15A60C48260 for ; Fri, 16 Feb 2024 06:53:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A1E110E432; Fri, 16 Feb 2024 06:53:56 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="M/L6YYR8"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30BB610E432 for ; Fri, 16 Feb 2024 06:53:55 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9986061F0C; Fri, 16 Feb 2024 06:53:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1638AC433C7; Fri, 16 Feb 2024 06:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066434; bh=OMwiUGzZhHIC9yKcus+0Ro/4xBOBkZGCI2WykwcHxec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M/L6YYR8D3lmY2K9Pmpzprip1CG/noGquvl9fgyT0V71zUn97O8v6rljtSk+IB6+U I6MTnvOhmBybARhB1manPvdvX8CtCUXLKkouXx/66VqqGWwKhofjSM4HmVxm0SASjK 0o/AbW2l+iWAo1n1e1s1qUp5WqKnjl7mFUQG787geHYKWyyFp7T8xYgDSNjBDZKS34 rCyGoBCD6K2FeRfef2OBdrTBvhEJOdy+nhwxClQUssTqziUTPx6gmGXiW+WRXpMkIo URd4BsUqbJsoKZstUGmrXFEwBHvS8LDAMe91AO2SQeRsMo2LyLC1b+uBhFe9/Nq4o/ 79nI9WRxWH2fQ== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 07/21] drm/i915: remove intel_vbt_panel_data::edp::initialized Date: Fri, 16 Feb 2024 07:53:12 +0100 Message-ID: <20240216065326.6910-8-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_vbt_panel_data::edp::initialized is not used since commit 9f0e7ff4b366 (drm/i915: fetch eDP configuration data from the VBT). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h index 01eb6e4e6049..e0d291dd7d2d 100644 --- a/drivers/gpu/drm/i915/display/intel_display_types.h +++ b/drivers/gpu/drm/i915/display/intel_display_types.h @@ -327,7 +327,6 @@ struct intel_vbt_panel_data { struct edp_power_seq pps; u8 drrs_msa_timing_delay; bool low_vswing; - bool initialized; bool hobl; } edp; From patchwork Fri Feb 16 06:53:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559594 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D764C48BEC for ; Fri, 16 Feb 2024 06:54:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D17FD10EA9B; Fri, 16 Feb 2024 06:53:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="X7EaO9HR"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id D324C10E433 for ; Fri, 16 Feb 2024 06:53:58 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 47C3261EF4; Fri, 16 Feb 2024 06:53:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1FF7C433C7; Fri, 16 Feb 2024 06:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066438; bh=xAhGbARzs83EneUXBDZflPwViGnccMXkpjIP1CYeQhA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X7EaO9HRGWuJT9OQFFjFHOAEGCSPJNOQSEQW0OotFJMCh7gKgYIKkMgYhYMzAWg9v qfpU8ExWaTf2OiwDh6c53Ac7/1HYTXPhh8A4fkDq/nCoduEvxlSW5EwGNsEq5J8nZx 2qpItkKEWsQ+JyzTFRXoPRNjaX061QSbmI4gQ7YKSR6YwV0Ex3jI3HNSIyEmJuFnL+ B+mbyNcy95vWmTcsE140ztEKmi/9iquKXznkR58v1/wo+m7TpRalI4f/dqHyYkdMwk P8jXM54QskG/ecIOS/wDcQFhiw2xjKEM7sC2BYuIdwyRGOg02R29XGzsgOGMKQag2p 8pfD4dIju9SlA== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 08/21] drm/i915: remove intel_guc::ads_engine_usage_size Date: Fri, 16 Feb 2024 07:53:13 +0100 Message-ID: <20240216065326.6910-9-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_guc::ads_engine_usage_size was never used since its addition in commit 77cdd054dd2c (drm/i915/pmu: Connect engine busyness stats from GuC to pmu). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h index 813cc888e6fa..be70c46604b4 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h @@ -206,8 +206,6 @@ struct intel_guc { u32 ads_golden_ctxt_size; /** @ads_capture_size: size of register lists in the ADS used for error capture */ u32 ads_capture_size; - /** @ads_engine_usage_size: size of engine usage in the ADS */ - u32 ads_engine_usage_size; /** @lrc_desc_pool_v69: object allocated to hold the GuC LRC descriptor pool */ struct i915_vma *lrc_desc_pool_v69; From patchwork Fri Feb 16 06:53:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559595 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F144C48BEC for ; Fri, 16 Feb 2024 06:54:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B704610EA9E; Fri, 16 Feb 2024 06:54:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="MYhfAahz"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4759610E433 for ; Fri, 16 Feb 2024 06:54:01 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AEB9B61EF6; Fri, 16 Feb 2024 06:54:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 873C8C43390; Fri, 16 Feb 2024 06:53:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066440; bh=e3JLcK2Zorv6NzoLDXNqOtoctfvRfUkVpj0zHb6Uma0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MYhfAahznJHHc68nDGRIoxA2wQ6gIDbhrKn+7x4NtBDivZwEl1JX6AcMoyyufiVcp AXtdHNVVfwW/c7PEUNYyy3OCjLq/uonp9U+Y5zx0v0R7H3b9QyFhKfKrjVfw25bgNC vRDgrr78LIDkkkqOTS9LV4DbW0LllabFa+IrTGrx0n8P7YMuvQl6LCCNjFzMtIQMrF YnIFg25kvKFlZndJGBmmcJFm6ayZIWAIem3QMmRN0ydO0++zMkRbFz0xQYkXQ1B+5F JINaZHCT7vopkXJvrkhhRO/ejiy/1W9JMmUTK0JGKwJfalNn7vExyRzv9vnzl7Ft8T PrrAqqQz2GcAw== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 09/21] drm/i915: remove i915_drm_client::id Date: Fri, 16 Feb 2024 07:53:14 +0100 Message-ID: <20240216065326.6910-10-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" i915_drm_client::id is not used since commit e894b724c316 (drm/i915: Use the fdinfo helper). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/i915_drm_client.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drm_client.h b/drivers/gpu/drm/i915/i915_drm_client.h index a439dd789936..2e7a50d16a88 100644 --- a/drivers/gpu/drm/i915/i915_drm_client.h +++ b/drivers/gpu/drm/i915/i915_drm_client.h @@ -24,8 +24,6 @@ struct drm_printer; struct i915_drm_client { struct kref kref; - unsigned int id; - spinlock_t ctx_lock; /* For add/remove from ctx_list. */ struct list_head ctx_list; /* List of contexts belonging to client. */ From patchwork Fri Feb 16 06:53:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559596 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF20DC48BEC for ; Fri, 16 Feb 2024 06:54:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 544F610E433; Fri, 16 Feb 2024 06:54:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="aDyJ4V/b"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id AF3CB10E433 for ; Fri, 16 Feb 2024 06:54:03 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 323AB61EF8; Fri, 16 Feb 2024 06:54:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1EE4C433C7; Fri, 16 Feb 2024 06:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066443; bh=YgYjxfvUqDqcc0kdOcmV9/pe6rLivB5Hnys3gp0apvU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aDyJ4V/bLN4EkcMd8v47X1GZjrkbl4ceRUkFCXyjR/WHxHtMAmW8xc4cPK1n/BSCo fIqVQrxaOyozPq9h7b1vzKQQNuzbvdTG/id6nXhT1vKErrtpsVvEKjYXDbf6VDNn59 OUGefLN2cjl1iN4ua9iqNJRgS3HobVWSRtRjrptOwzu+x2vuqmy1q/GRh4Atk9NWv0 k0/BprtQj2kLdq/6ZlLApcfoUL2yO296nyzeV6sh0ZxRc2fU3sFg9MdVcjeO7zZFxt HVsj9AYDjTopKUxsbUHn34LtHeJkLAN2t1F7Gd0sF09/b6MfOPH0WrZPdJ7QxTRiqr 1rLk1LQoXhfbg== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 10/21] drm/i915: remove i915_perf_stream::size_exponent Date: Fri, 16 Feb 2024 07:53:15 +0100 Message-ID: <20240216065326.6910-11-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" i915_perf_stream::size_exponent was never used since its addition in commit a37f08a882b0 (drm/i915/perf: Refactor oa object to better manage resources). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/i915_perf_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_perf_types.h b/drivers/gpu/drm/i915/i915_perf_types.h index 46445248d193..39fb6ce4a7ef 100644 --- a/drivers/gpu/drm/i915/i915_perf_types.h +++ b/drivers/gpu/drm/i915/i915_perf_types.h @@ -288,7 +288,6 @@ struct i915_perf_stream { struct i915_vma *vma; u8 *vaddr; u32 last_ctx_id; - int size_exponent; /** * @oa_buffer.ptr_lock: Locks reads and writes to all From patchwork Fri Feb 16 06:53:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE497C48BEC for ; Fri, 16 Feb 2024 06:54:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3708C10EAA0; Fri, 16 Feb 2024 06:54:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="bcPOWQoE"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A3AA10EAA0 for ; Fri, 16 Feb 2024 06:54:07 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AD37261EF7; Fri, 16 Feb 2024 06:54:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2D78C433F1; Fri, 16 Feb 2024 06:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066446; bh=D1UVKTUwrumNB4hwYMCCqn17XRjRd4Butj96fqO0Ms8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bcPOWQoEz23Zw9RUcbqEyl8B6I+N8c2+TNF+litP20oTavcBUp4OMcqgSikxs9hIy GBUv8uCuIGafuExHqqNKSGSexCkHq2tZl+4NTqRLuUSAQlAquRvyKfMh9ZEaDuWvYi 7Hwo0cJmbybLTXpfvhEU97F+owLSUn0nfuVr44SNOC4FBO5CBz3XdlAS87pPXo73RY YiUpVcKDF0HlR+Bii/IWPxg6+qMa7l4kjVr+djNQCMxDkEYj0v1QAnshCedXfLqx5M N68b3v8f0aCn+Hu6mL/eovXey2vuAviuiC0HezrAYj6ivjaPf2ow46KWtVaYYTAJRK uRSTpcFUqEYNA== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 11/21] drm/i915: remove intel_vgpu_gtt::active_ppgtt_mm_bitmap Date: Fri, 16 Feb 2024 07:53:16 +0100 Message-ID: <20240216065326.6910-12-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_vgpu_gtt::active_ppgtt_mm_bitmap was never used since its addition in commit 2707e4446688 (drm/i915/gvt: vGPU graphics memory virtualization). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/gtt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gtt.h b/drivers/gpu/drm/i915/gvt/gtt.h index fb96ea454fd1..cb50700e6cc9 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.h +++ b/drivers/gpu/drm/i915/gvt/gtt.h @@ -208,7 +208,6 @@ struct intel_vgpu_scratch_pt { struct intel_vgpu_gtt { struct intel_vgpu_mm *ggtt_mm; - unsigned long active_ppgtt_mm_bitmap; struct list_head ppgtt_mm_list_head; struct radix_tree_root spt_tree; struct list_head oos_page_list_head; From patchwork Fri Feb 16 06:53:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559598 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95F55C48BEC for ; Fri, 16 Feb 2024 06:54:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05B3F10E3CF; Fri, 16 Feb 2024 06:54:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="KDfx5flm"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4562210E3CF for ; Fri, 16 Feb 2024 06:54:16 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5ACBECE1A97; Fri, 16 Feb 2024 06:54:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1434FC433C7; Fri, 16 Feb 2024 06:54:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066449; bh=8o0wvfgtp9sQfzOgFfW8t1yUu/RnxbOaOuDmpI5A5qk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KDfx5flmsaTtfTYf4Irng/CnPwsgJzJ+dCaPmXn2In2KJowAOIDfk3S4a8EZN8Wci BNHEy6+fHdkUEo33XX5p8tlaEut0C49KaVhNLaHht/oPG2DVLypJecnoYueC81JbXi V0HMdYliYRfKvpOuoGFohYyUEurgXau3BOqP80MA+a6fFF2OrIEUmbWa6oaOlOC/I9 l6Py+6hUpe5SiWWTWl///JzRTnAmmSkRN2KvUepgwDllHeTf1tMrfqLy5uFFpg1g6y H+/gIlTcFRsYy4ZdCjDqRfIxjzk/y2rYHqBZoql1212DKkabX918XDQfNWKRkEzMzb xNGpHrnT1crUQ== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 12/21] drm/i915: remove intel_vgpu_fence::base Date: Fri, 16 Feb 2024 07:53:17 +0100 Message-ID: <20240216065326.6910-13-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_vgpu_fence::base was never used since its addition in commit 28a60dee2ce6 (drm/i915/gvt: vGPU HW resource management). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/gvt.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h index c57aba09091f..b6fe17f1a16f 100644 --- a/drivers/gpu/drm/i915/gvt/gvt.h +++ b/drivers/gpu/drm/i915/gvt/gvt.h @@ -89,7 +89,6 @@ struct intel_vgpu_gm { /* Fences owned by a vGPU */ struct intel_vgpu_fence { struct i915_fence_reg *regs[INTEL_GVT_MAX_NUM_FENCES]; - u32 base; u32 size; }; @@ -444,7 +443,6 @@ int intel_gvt_load_firmware(struct intel_gvt *gvt); #define vgpu_hidden_gmadr_end(vgpu) \ (vgpu_hidden_gmadr_base(vgpu) + vgpu_hidden_sz(vgpu) - 1) -#define vgpu_fence_base(vgpu) (vgpu->fence.base) #define vgpu_fence_sz(vgpu) (vgpu->fence.size) /* ring context size i.e. the first 0x50 dwords*/ From patchwork Fri Feb 16 06:53:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559599 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00ECEC48260 for ; Fri, 16 Feb 2024 06:54:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 765A210EAA2; Fri, 16 Feb 2024 06:54:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="FNZN1U+W"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E29F10EAA2 for ; Fri, 16 Feb 2024 06:54:16 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B9DD6CE29FD; Fri, 16 Feb 2024 06:54:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 665B7C43399; Fri, 16 Feb 2024 06:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066453; bh=TktpFXRJz/ldFZumo7iwlZkQPrtoXAs7MIXqQ9AMx+A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FNZN1U+WIzhHHPi5oj6KocxGGyE+DAW/vy1cSJoV03TW0rpM7j68r9Y0/KAC/GZHL Cc7oh1TJ29x8OBhQwOJt5brlWQ/o6m2uVrxXMyq42QtrwEfReN/C7DWGa1sN5k2A/p weXkEzT8r55DVqJyD9izVzNfObcpkZ6qQSXmxOrM+6HDtO8D+J1FLoo5iG5FY4eBy1 kZXa9mlRuLSAwi81J12G2RmwQe5PCi2CCqtJuUYF84b4pewjVi1ahvyTQAZrJehH4U nWqh5wRFZ1ND/RTTd+kXNm8ZpcDC24td26oInNolWGYhN/uupW6kmehBSbWhM+47YW rBX2+8omIIPHw== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 13/21] drm/i915: remove intel_vgpu_opregion::mapped Date: Fri, 16 Feb 2024 07:53:18 +0100 Message-ID: <20240216065326.6910-14-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_vgpu_opregion::mapped is not used since commit 367748066eeb (drm/i915/gvt: remove enum hypervisor_type). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/gvt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h index b6fe17f1a16f..8e5d696fc79c 100644 --- a/drivers/gpu/drm/i915/gvt/gvt.h +++ b/drivers/gpu/drm/i915/gvt/gvt.h @@ -118,7 +118,6 @@ struct intel_vgpu_irq { }; struct intel_vgpu_opregion { - bool mapped; void *va; u32 gfn[INTEL_GVT_OPREGION_PAGES]; }; From patchwork Fri Feb 16 06:53:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559600 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F18AC48260 for ; Fri, 16 Feb 2024 06:54:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B361A10EAA3; Fri, 16 Feb 2024 06:54:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ID/5JZuI"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3F4010EAA3 for ; Fri, 16 Feb 2024 06:54:18 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 19272CE1A97; Fri, 16 Feb 2024 06:54:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2631C433F1; Fri, 16 Feb 2024 06:54:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066456; bh=SXyIHpFd6ET8iufV6ZRXcOFvDY4mmrBUfCieGBadR0I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ID/5JZuIbZ7qR1aXjg2e0yERBM7vDBtiMaOKDAbabO1Cz1Sqt7sMoMOR+AZLRcshz KkpjdY7DmWTACjfEIrMqmLPmj82z/2aToB1WKxmewUwew8c8scMtgIhCX6olwQU+CY uXrphMLBWfGRsiB7m2y3U1qPgVZiU31qxJutPxz3dHx8YG0Rli7Q+5S/0z+APoqq9k Ak0PWXsjVwt0wqvttbAY1bFcDhRafgqlO3ILJlUQk3fkZCqsAKSVuyBqEH+JOSnLj6 cI8IXozf1s30jEkneAMJBPzzNCgaAiz0oAFEaFXySEv340/YXVnqJTXGYAcX/mkYAN lGBIgQ2vH3fOw== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 14/21] drm/i915: remove intel_vgpu::intx_trigger Date: Fri, 16 Feb 2024 07:53:19 +0100 Message-ID: <20240216065326.6910-15-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_vgpu::intx_trigger was never used since its addition in commit f30437c5e7bf (drm/i915/gvt: add KVMGT support). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/gvt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h index 8e5d696fc79c..b8b8ffe4d566 100644 --- a/drivers/gpu/drm/i915/gvt/gvt.h +++ b/drivers/gpu/drm/i915/gvt/gvt.h @@ -221,7 +221,6 @@ struct intel_vgpu { struct vfio_region *region; int num_regions; - struct eventfd_ctx *intx_trigger; struct eventfd_ctx *msi_trigger; /* From patchwork Fri Feb 16 06:53:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559601 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 028E5C48260 for ; Fri, 16 Feb 2024 06:54:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7103210EAA4; Fri, 16 Feb 2024 06:54:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="OZYa6F4s"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id EBCD910EAA4 for ; Fri, 16 Feb 2024 06:54:21 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4DEFACE2A00; Fri, 16 Feb 2024 06:54:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4DD1C433C7; Fri, 16 Feb 2024 06:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066459; bh=BXImqGWAPuqO33Ld3ZnMdqeekf4kcUYdKg21p7D7eN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OZYa6F4sJIbOHW1A/nf05Cx7UXrlVbKnctd7m6e53k5qk8qOzli1waB1ESFi+U2kM P2n7o+9xU4Ntq4h0Cenr6KVAOohzzzX7qwCJK+WI3IuxC5cSB34oywUqoOSyhRuvKb aLKc44lOuKkKl66wsvAS9WJ7J8ioRM2/cjBSJJ8LMfhqiRA/TRDj5nNHO28jkT6H4N t3wKvbTA+xDlpXRf3E/OfJ/TayYEbOW0ZTu/bJDW2ZbLWxajekbTh0wPJ1FJ+oP0ga lkSC+uUbjxdLM6E3hn5kJ68nOcZqtknkriN1Nv3taD8LPYcq7WmzzZO0msKpQG1zm/ 2VxP9q4/ufFlg== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 15/21] drm/i915: remove gvt_mmio_block::device Date: Fri, 16 Feb 2024 07:53:20 +0100 Message-ID: <20240216065326.6910-16-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" gvt_mmio_block::device is not used since commit e0f74ed4634d (i915/gvt: Separate the MMIO tracking table from GVT-g). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/gvt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h index b8b8ffe4d566..2c95aeef4e41 100644 --- a/drivers/gpu/drm/i915/gvt/gvt.h +++ b/drivers/gpu/drm/i915/gvt/gvt.h @@ -253,7 +253,6 @@ struct intel_gvt_fence { /* Special MMIO blocks. */ struct gvt_mmio_block { - unsigned int device; i915_reg_t offset; unsigned int size; gvt_mmio_func read; From patchwork Fri Feb 16 06:53:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559602 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 519D7C48BEC for ; Fri, 16 Feb 2024 06:54:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C8A0810EAA5; Fri, 16 Feb 2024 06:54:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="sTepzBhp"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 22E1710EAA5 for ; Fri, 16 Feb 2024 06:54:25 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6F8FDCE2A00; Fri, 16 Feb 2024 06:54:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 477CEC43394; Fri, 16 Feb 2024 06:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066462; bh=76rc2RXrSGYrSj0C5tpAcUBDgwB+L+6GnchV2Cb1TXk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sTepzBhpub0N6GDHAWQ92fg6hamVDAWFkhi1H3OtEdwVXR6BNgFJkIPVRVIhczNtY ONzylcaA0wElfNFJcdsPuk0mkKJNZDECU+nYLVaAlA4GAyU6pQbIaIXE6ClA0wSeR5 oC/eBD0nRHX5kZ3wPgWaVZqYwtLBaa4z6OrnVatq7GWMoN84XmAupCV/BadcabFxVV D662aciGIIKh06bobhx5cHhSObz3FGi3TC6b0Cm5z2SV7asXpY4IFYWoeI5y/OkhA7 bEiwXCwZnbh+F2O4Lg9k6m/BfLwyF+I+eMm97cAh1nrU2UBbLHoLnd9hI0XzuEJ4lo AVYPt998gh00A== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 16/21] drm/i915: remove intel_gvt_irq_info::warned Date: Fri, 16 Feb 2024 07:53:21 +0100 Message-ID: <20240216065326.6910-17-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_gvt_irq_info::warned was never used since its addition in commit c8fe6a6811a7 (drm/i915/gvt: vGPU interrupt virtualization.). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/interrupt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c b/drivers/gpu/drm/i915/gvt/interrupt.c index c8e7dfc9f791..336d079c4207 100644 --- a/drivers/gpu/drm/i915/gvt/interrupt.c +++ b/drivers/gpu/drm/i915/gvt/interrupt.c @@ -40,7 +40,6 @@ struct intel_gvt_irq_info { char *name; i915_reg_t reg_base; enum intel_gvt_event_type bit_to_event[INTEL_GVT_IRQ_BITWIDTH]; - unsigned long warned; int group; DECLARE_BITMAP(downstream_irq_bitmap, INTEL_GVT_IRQ_BITWIDTH); bool has_upstream_irq; From patchwork Fri Feb 16 06:53:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559603 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAB3BC48BEC for ; Fri, 16 Feb 2024 06:54:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 49F2110EAA6; Fri, 16 Feb 2024 06:54:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="CD9yVN3+"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 056AC10EAA6 for ; Fri, 16 Feb 2024 06:54:28 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4DFCECE1A97; Fri, 16 Feb 2024 06:54:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CF8CC433C7; Fri, 16 Feb 2024 06:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066465; bh=guZaFSqSf3MqQt8V36466MzszKjuXHWltT0kqFLvhWY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CD9yVN3+t6Oxc4Su6jO9CPZk5HJwbk1hnn9GS0N9rM148G0KprQN5AW+JnV49jYzM Vy1se9Y35OI1KnxNf8NkYYyTMb1AP7/PAEe0d8Wt186IepDpbl2ApTLK4CXigB3mTe 5QJDpTfy6FvqP/w7B+wbF/I+v2b50yEclWqyQ1T2L1Dpo59qQu7k7jlI+XRU9br8X3 pco+MMsyC+qsoDJtNAp+Z2Ni5C/FOEqLgZZeB5JC3nuJ80Scwa7ig5Z3fGG1dOrPVb LHHjT4UoQWO4CxvjoIo6pT1s22I+pGeB/OWDTbqqYM46jxc8cUxRm+LfWLj3Ycs+rG d6XkQFoG5UK4A== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 17/21] drm/i915: remove intel_gvt_event_info::policy Date: Fri, 16 Feb 2024 07:53:22 +0100 Message-ID: <20240216065326.6910-18-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_gvt_event_info::policy was never used since its addition in commit c8fe6a6811a7 (drm/i915/gvt: vGPU interrupt virtualization.). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/interrupt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/interrupt.h b/drivers/gpu/drm/i915/gvt/interrupt.h index e60ad476fe60..b1fd6ed4e34a 100644 --- a/drivers/gpu/drm/i915/gvt/interrupt.h +++ b/drivers/gpu/drm/i915/gvt/interrupt.h @@ -177,7 +177,6 @@ enum intel_gvt_irq_type { /* per-event information */ struct intel_gvt_event_info { int bit; /* map to register bit */ - int policy; /* forwarding policy */ struct intel_gvt_irq_info *info; /* register info */ gvt_event_virt_handler_t v_handler; /* for v_event */ }; From patchwork Fri Feb 16 06:53:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559604 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FA9FC48260 for ; Fri, 16 Feb 2024 06:54:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 198D710EAA9; Fri, 16 Feb 2024 06:54:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="CJqCV8/y"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5EDE010EAA9 for ; Fri, 16 Feb 2024 06:54:29 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D10C660FC9; Fri, 16 Feb 2024 06:54:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39BF0C43390; Fri, 16 Feb 2024 06:54:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066468; bh=FdrONz3jqnEbBJVqtq1ykjLmdW7prwTBxhfQ4GglgTs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CJqCV8/yNzOiPeXngxMZCidOZ2fEeSBe7MNvGGeKcUAZcvCE9A7SQK+hJG4s9kfjw vXE2Uu77p1raT/HW+nbRV6hkej2H7N6zAg/8ZrC4Sr5o0SmceBZC+XJ46r7StE3KEl o6x6NeyQnKKBz3pCA/p8VXxhY0h1NeMQaSCF+EAbouvlthpTMewOWOvJSyKRJn/Eor typPJkEulN5DS6e3TeD/PgzkF0HgWDVUMwZSgSrCVIGg022tGWmbxmLsDqTzuD2rMb ATAlZwiezvB5qOdZivlJWHAyhb570/hY1KpCUnYsvGhb6ZgQFNCww1uqIAhtzN2ko9 BJG76DnQun4/Q== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 18/21] drm/i915: remove intel_gvt_irq::pending_events Date: Fri, 16 Feb 2024 07:53:23 +0100 Message-ID: <20240216065326.6910-19-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_gvt_irq::pending_events was never used since its addition in commit c8fe6a6811a7 (drm/i915/gvt: vGPU interrupt virtualization.). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gvt/interrupt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/interrupt.h b/drivers/gpu/drm/i915/gvt/interrupt.h index b1fd6ed4e34a..cd214be98668 100644 --- a/drivers/gpu/drm/i915/gvt/interrupt.h +++ b/drivers/gpu/drm/i915/gvt/interrupt.h @@ -187,7 +187,6 @@ struct intel_gvt_irq { struct intel_gvt_irq_info *info[INTEL_GVT_IRQ_INFO_MAX]; DECLARE_BITMAP(irq_info_bitmap, INTEL_GVT_IRQ_INFO_MAX); struct intel_gvt_event_info events[INTEL_GVT_EVENT_MAX]; - DECLARE_BITMAP(pending_events, INTEL_GVT_EVENT_MAX); struct intel_gvt_irq_map *irq_map; }; From patchwork Fri Feb 16 06:53:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559605 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B7DBC48260 for ; Fri, 16 Feb 2024 06:54:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD3FE10EAAA; Fri, 16 Feb 2024 06:54:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="pvmJQd1o"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A5C510EAAA for ; Fri, 16 Feb 2024 06:54:34 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9DF20CE27EC; Fri, 16 Feb 2024 06:54:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B58AC433F1; Fri, 16 Feb 2024 06:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066471; bh=vDCO89h9ED/qo4wLWevCKElHpB2BcZotTCPZ1w3i9Jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pvmJQd1o5CPP9qPttQiY8V031wAlyPP80QwLnSBoz7mapvpDVmB0wq9pCsvT88IrX Iuta+sHkqfu1xh25oWlE98lwYiv6ag5ntxnwyRNEvLwru12wKB0SJUlIzc+dQCvtsy p9TyfWuQKHnJj756zzSkg7Tqv6NYshRSJ22ABSL3L98kvQlwW2Usnm0BJnp3WjBnrz nGPIXkqWsjtkR0TyHn5IyVseq9XEN3h7IrZ7YvurSZ6awet7/7Y9Jlb0xb6lAxvrX4 Dcigyiv139H7vp8DNQG7K5OwwaXijp+kQV1A/+ruD8H9e0q98RA+qk+NyC4ABkBNGm uugYm5JdvTBOw== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 19/21] drm/i915: remove execute_cb::signal Date: Fri, 16 Feb 2024 07:53:24 +0100 Message-ID: <20240216065326.6910-20-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" execute_cb::signal is not used since commit 5ac545b8b014 (drm/i915/request: Remove the hook from await_execution). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/i915_request.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index f59081066a19..519e096c607c 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -52,7 +52,6 @@ struct execute_cb { struct irq_work work; struct i915_sw_fence *fence; - struct i915_request *signal; }; static struct kmem_cache *slab_requests; From patchwork Fri Feb 16 06:53:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559606 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BC07C48BEF for ; Fri, 16 Feb 2024 06:54:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EDF9A10EAAB; Fri, 16 Feb 2024 06:54:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="bvbK5G7W"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C53810EAAB for ; Fri, 16 Feb 2024 06:54:36 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D2DC261EF4; Fri, 16 Feb 2024 06:54:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0B28C43390; Fri, 16 Feb 2024 06:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066475; bh=xZUGSW7pkokV4zLjCnd/mTKR/eQZWFNFZ3+e+td1jik=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bvbK5G7WtJpIv0+P1LBfllzinl78UnS7HDCkgrkAygGGKuAR/29I82hegp9YHjajH Cv8tWzg5QpvUoZnq320Qk1pz2MrsXgsvoJ6I/Nfb3jIhVUdhbHuAyU0rYcZVokHmUU bsrcuCtwJbUabfZDKwDbYAgHHcBciD58mAuwUrhP8ZefsvoBmecQzDzFP4YY+pUlmo kNHUDzI4my+B9ziMkXSVZB/xu5UJ9g9w+omKiX7cqFuy4EKX5iuMu3DKTMg1x3dMBe SV0Qxg64gnQKK0SqxBKXQg26s3ZetKrwOMWRHEeQCrpvyNHYAg8EHb6fFaTQ3G1lmb pG3wpv4WdY1rw== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 20/21] drm/i915: remove i915_vma::obj_hash Date: Fri, 16 Feb 2024 07:53:25 +0100 Message-ID: <20240216065326.6910-21-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" i915_vma::obj_hash was never used since its addition in commit 4ff4b44cbb70 (drm/i915: Store a direct lookup from object handle to vma). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/i915_vma_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma_types.h b/drivers/gpu/drm/i915/i915_vma_types.h index 64472b7f0e77..559de74d0b11 100644 --- a/drivers/gpu/drm/i915/i915_vma_types.h +++ b/drivers/gpu/drm/i915/i915_vma_types.h @@ -290,7 +290,6 @@ struct i915_vma { struct list_head obj_link; /* Link in the object's VMA list */ struct rb_node obj_node; - struct hlist_node obj_hash; /** This vma's place in the eviction list */ struct list_head evict_link; From patchwork Fri Feb 16 06:53:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 13559607 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81B00C48BEC for ; Fri, 16 Feb 2024 06:54:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D901610EAAF; Fri, 16 Feb 2024 06:54:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="KkCk/EdX"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 117F610EAAE for ; Fri, 16 Feb 2024 06:54:40 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8657861EF8; Fri, 16 Feb 2024 06:54:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57635C433F1; Fri, 16 Feb 2024 06:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708066479; bh=Jq2+MsKda76OUscmqQ543pe72ImY+6RM/tfDpkyIMK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KkCk/EdXUalSl8XNMQmbSKUjLRJjlybaY/6DisldmRz2BqNd/KYBYSArzer+GxFYD gNFrHIYOIOhy6Gut4k1WJb7w0/8JVT8GsaoTmyF2Whf7YgHTxpsDuamgEwPaiEWNYj pfpbk5AF/DejlPXJWyYzgw+lt0kqZkb1gIhAx2Kp+CBF7wmSLZbSAnmAMyqcdHhHRy QK5Fwg0R+6vuD/uj+IoEvpJ9ZdsO/MRaUmNVQ63cE1V6O43+DQ7/93WqbppPszqVdf +PQbtvX9kacjomPPNYXau7JpYJ03BnzzfaZSVg4tP9sf4UyIbmOWn50SFraGbN8aXQ D5KLtC6WYJ4Aw== From: "Jiri Slaby (SUSE)" To: jani.nikula@linux.intel.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Subject: [PATCH 21/21] drm/i915: remove intel_memory_region_ops::flags Date: Fri, 16 Feb 2024 07:53:26 +0100 Message-ID: <20240216065326.6910-22-jirislaby@kernel.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org> References: <20240216065326.6910-1-jirislaby@kernel.org> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" intel_memory_region_ops::flags was never used since its addition in commit 232a6ebae419 (drm/i915: introduce intel_memory_region). Drop it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/intel_memory_region.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_memory_region.h b/drivers/gpu/drm/i915/intel_memory_region.h index 40810cfb3fd9..8c927e303c4a 100644 --- a/drivers/gpu/drm/i915/intel_memory_region.h +++ b/drivers/gpu/drm/i915/intel_memory_region.h @@ -50,8 +50,6 @@ enum intel_region_id { for_each_if((mr) = (i915)->mm.regions[id]) struct intel_memory_region_ops { - unsigned int flags; - int (*init)(struct intel_memory_region *mem); int (*release)(struct intel_memory_region *mem);