From patchwork Sun Feb 18 09:43:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mao Jinlong X-Patchwork-Id: 13561771 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D51821CF98; Sun, 18 Feb 2024 09:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708249441; cv=none; b=BWdGJaMsBp0B8if8k5FSbz8IGvNpfWqPjQi43tXyVytCo8mfMx8kkCc7tti/VmTfbeaZtYRQn686JVXkpfYTwEs+MZYANq22wIFEtTCyfx4uBrUi+Gu+yz21prccRjyZSeeXc4Pi/phNOyCMxRSgJlkeWzO2ynb/zQIK2vgXzIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708249441; c=relaxed/simple; bh=aSSYAKXiNZ3B9g+7NCAreTP0gRzqX/zcTJJrTQGiG24=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hqJF4xs2VblUmsBGdSvjWwmo4rWgBR0bmwZ1+diAlqHuX2hPzMiRLUY2UaIaT9NOGn/H+Vb3pBJ/08VL6Ma3xvPlw1b2j6Bt8x7n/73WherVXBw5zAY/caVAprSSOppTgFjko5ODJIlaaWsdHMsR9085OLLVtQ7eBWvaOmmXdL4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=GqUch005; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="GqUch005" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41I9ehfF013317; Sun, 18 Feb 2024 09:43:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= qcppdkim1; bh=I6FhMe2svHVVjnm5YbUsg2AnSWJOzTgHFtU1/uId9f0=; b=Gq Uch0050zvS52uXzHME4nFmOxgN0GS/GBUBW1aFYkZkXXP+c+HEnKB/uqepovJ7Ua 0ceYl+S8ODLyMhiurp4HbdOJcYUIW6E8h+O7s2PDgiq4SPg42C1CEIndaWZjVvhC IzYYFS+DrQjUrH34E27idTk7blvhXjt9EPg0y1AbCPB4I2X5Y4xSObNARAGhGiCl +1HtiBRUxYZ79zm3oK5cwDQxsrwlh29BrcIug4cXX7rIGUDFS663RfLrYtTvA+vs 04ru/kWcROOJ1PQdOxxGQrdZU9zDqKW82bCGdbEKBHkGy71+wmlIGdRw41o9ukss QNJnT1xUc1q6I/E4WSeg== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3waktcsp2h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 18 Feb 2024 09:43:48 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41I9hk9W022450 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 18 Feb 2024 09:43:46 GMT Received: from hu-jinlmao-lv.qualcomm.com (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sun, 18 Feb 2024 01:43:46 -0800 From: Mao Jinlong To: Suzuki K Poulose , Mike Leach , James Clark , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Mao Jinlong" , Tao Zhang , Alexander Shishkin CC: , , , , Subject: [PATCH v3 1/2] dt-bindings: arm: qcom,coresight-tpdm: Rename qcom,dsb-element-size Date: Sun, 18 Feb 2024 01:43:19 -0800 Message-ID: <20240218094322.22470-2-quic_jinlmao@quicinc.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240218094322.22470-1-quic_jinlmao@quicinc.com> References: <20240218094322.22470-1-quic_jinlmao@quicinc.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: xlUXZiqKJrL5z87HpcIp1MVdpiXfESS5 X-Proofpoint-ORIG-GUID: xlUXZiqKJrL5z87HpcIp1MVdpiXfESS5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-18_07,2024-02-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 mlxlogscore=984 lowpriorityscore=0 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402180073 Change qcom,dsb-element-size to qcom,dsb-element-bits as the unit is bit. There is no tpdm node in any DT as of now. Make this change before any tpdm node is added to DT. Fixes: 2a8d9b371566 ("dt-bindings: arm: Add support for DSB element size") Signed-off-by: Mao Jinlong Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml index d0647ffaed71..8eec07d9d454 100644 --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml @@ -44,12 +44,11 @@ properties: minItems: 1 maxItems: 2 - qcom,dsb-element-size: + qcom,dsb-element-bits: description: Specifies the DSB(Discrete Single Bit) element size supported by the monitor. The associated aggregator will read this size before it is enabled. DSB element size currently only supports 32-bit and 64-bit. - $ref: /schemas/types.yaml#/definitions/uint8 enum: [32, 64] qcom,cmb-element-bits: @@ -111,7 +110,7 @@ examples: compatible = "qcom,coresight-tpdm", "arm,primecell"; reg = <0x0684c000 0x1000>; - qcom,dsb-element-size = /bits/ 8 <32>; + qcom,dsb-element-bits = <32>; qcom,dsb-msrs-num = <16>; clocks = <&aoss_qmp>; From patchwork Sun Feb 18 09:43:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mao Jinlong X-Patchwork-Id: 13561770 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAE4F1CF81; Sun, 18 Feb 2024 09:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708249439; cv=none; b=NLbkma4CDACjSltrzvfJ1aRyamRPfxH/oQCKTHWZv6QK4ZCVDaQ112/xKxkZHY3Fx5B7OZfQkecKX2P/Y7fmxmBU68Wtji8fsiSfXAfTeYatWvrYvDkv/z/Ui+D8efopEA4jwPzbbync0vdUDMfntrhSCZXFuGskUUyGUTMbvbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708249439; c=relaxed/simple; bh=Gi/exkqkuNLSlzGPvDv0MkpDTsni9qUMHtNAHCPhiN4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XUCBRyo4RJ0q+onCcJ3mK2fZX5GqqtpcB16mAYoR+s3EcbYOuOLjcGCbNXi7q9BLZj+LjrY39HHObtCrsFuzQuh4IW9T4Epnim58FZlkwuC3DiwGzgKXnaq1r/kC5BatRHQQxMvKuy6/rQdyTUGqD1/oXkugBtzsdFSa10+1tJc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=hVZMYuGS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="hVZMYuGS" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41I9N53P016845; Sun, 18 Feb 2024 09:43:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= qcppdkim1; bh=bCpEG/iEJ6alJLg25zF1reZRTz9l9hb9cAwuGjH46hE=; b=hV ZMYuGSoxYIHKWVwRnmxFgdtU/yRVIgbpusFwv47knJtelosx4jlRF/fqCpNDiZfJ TheF/fyEZ8DyA/4Ip6IqWlOEYfF/VNmJUs44IbGgFtJDYpxU5V5oY4l4NFIGd9b7 ZtipZ6hM7DPi7U4AAYan0KSbnEE+/oF7bKs2simfoA6EOZnCOwj72UtF9RR0LhYm LW9eGXSRyw2Z0ZQ5Io7CP+gCamnntVX7fG5j8uHy+MVsiIeZakznUbSuwksChzOM tzSsX8Qx/XcouOBpMArTyoz+0q1MryNFQwsALl6jtZpLWGDgb4feyNOLHQbQmEgi dUJOiHrC0F4aCifRF0FA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wajgk9ruf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 18 Feb 2024 09:43:48 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41I9hl5J024628 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 18 Feb 2024 09:43:47 GMT Received: from hu-jinlmao-lv.qualcomm.com (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sun, 18 Feb 2024 01:43:46 -0800 From: Mao Jinlong To: Suzuki K Poulose , Mike Leach , James Clark , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Mao Jinlong" , Tao Zhang , Alexander Shishkin CC: , , , , Subject: [PATCH v3 2/2] coresight-tpda: Change qcom,dsb-element-size to qcom,dsb-elem-bits Date: Sun, 18 Feb 2024 01:43:20 -0800 Message-ID: <20240218094322.22470-3-quic_jinlmao@quicinc.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240218094322.22470-1-quic_jinlmao@quicinc.com> References: <20240218094322.22470-1-quic_jinlmao@quicinc.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: GaCgWnGxqf4R4NEJflGjsFzsadNEpYBN X-Proofpoint-ORIG-GUID: GaCgWnGxqf4R4NEJflGjsFzsadNEpYBN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-18_07,2024-02-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 mlxlogscore=999 spamscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 mlxscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402180073 Change qcom,dsb-element-size to qcom,dsb-elem-bits as the unit is bit. When use "-bits" suffix, the type of the property is u32 from property-units.yaml, so use fwnode_property_read_u32 to read the property. Fixes: 57e7235aa1d1 ("coresight-tpda: Add DSB dataset support") Signed-off-by: Mao Jinlong --- drivers/hwtracing/coresight/coresight-tpda.c | 4 ++-- drivers/hwtracing/coresight/coresight-tpda.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/hwtracing/coresight/coresight-tpda.c index 6863afe7ca94..7739bc7adc44 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.c +++ b/drivers/hwtracing/coresight/coresight-tpda.c @@ -69,8 +69,8 @@ static int tpdm_read_element_size(struct tpda_drvdata *drvdata, struct tpdm_drvdata *tpdm_data = dev_get_drvdata(csdev->dev.parent); if (tpdm_has_dsb_dataset(tpdm_data)) { - rc = fwnode_property_read_u8(dev_fwnode(csdev->dev.parent), - "qcom,dsb-element-size", &drvdata->dsb_esize); + rc = fwnode_property_read_u32(dev_fwnode(csdev->dev.parent), + "qcom,dsb-element-bits", &drvdata->dsb_esize); } if (tpdm_has_cmb_dataset(tpdm_data)) { rc = fwnode_property_read_u32(dev_fwnode(csdev->dev.parent), diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/hwtracing/coresight/coresight-tpda.h index 19af64120fcf..c6af3d2da3ef 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.h +++ b/drivers/hwtracing/coresight/coresight-tpda.h @@ -36,7 +36,7 @@ struct tpda_drvdata { struct coresight_device *csdev; spinlock_t spinlock; u8 atid; - u8 dsb_esize; + u32 dsb_esize; u32 cmb_esize; };