From patchwork Tue Feb 20 08:22:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kurt Kanzenbach X-Patchwork-Id: 13563575 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1F00C48BC3 for ; Tue, 20 Feb 2024 08:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id:MIME-Version:Subject: Date:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=jti2eQBIpT2VUpM4MJ2AhSOd285MNPTM78DOWGlmGQo=; b=URCEr7Ue04hogX aObJhUYrmOkIUiLZvv3rEOrJNIYjognSDAYnAXqDjrrzUFxP827KL006DI/pmfcPbVsfSRl/qId9A haH5iO8uK9V3Vtfnun1qlrFMp1Zkp1IxcENfHm5gPhsA6lnrmfa+wscTIYU0VDYTeZd7OMYLVnezl YN/+v8ZdgtNiXflIkVcyn2E9LSX/0fzH/BV0MzCXVCWOTfBKK28vR/fOwVnszlX41bPkzMhHf9WFJ /rZLmkjpu6EG/2IANPmBrYfQ79JfPinXur0AkGnFRxBt4SoX5xdpEtck8kDUncWZg5i7eEXC9IxqW 6kXPtKAjbvjdQRdYpc2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcLP0-0000000DfpZ-2v6p; Tue, 20 Feb 2024 08:22:58 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcLOw-0000000DfmR-0NyA for linux-arm-kernel@lists.infradead.org; Tue, 20 Feb 2024 08:22:57 +0000 From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1708417368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o7FhDKCpVRzBZVqcVUK+TCqEXZxgC5mnVj+4kjWa4Gw=; b=qrAlfbQI84Pv+3qnK1/qX/0zfxmbMmNvjoPYwyuYCI0nlRjPvy9bC8/XFD8ITbXVCKXM4a S7ZMLJBXLNMdaQ1+GLe6WjSxDCOOJplgjhBmzVIv41DTFwHPOWgPFCQgA7GNCAOb7EMUGD zdF9i/9n3GTNb/qsnYEFn+QAcgzYkWyhIvpDzuoI8SM1IJkxgGv8zXYjOl66kha+mtU9Yn NMyYIAI9bbUM5zhCMjPVY/mFZcrVKgWWOuB4zptuFqcU1SQAG//hOJOIUiu7lV8yWcOpzK sL00Rhk76aChGibk9f4Luk+ijz8kCM/G7urHY6y2/StezjZQmzZJi1GHgNJxfQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1708417368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o7FhDKCpVRzBZVqcVUK+TCqEXZxgC5mnVj+4kjWa4Gw=; b=Ow0xOJexYEoL0IjzIbFbM2bawK4aWJLbJG2ZEnJk9ugeBswYY2wK8om2pucK0X49uccSwk caIeir4NJkhMfADQ== Date: Tue, 20 Feb 2024 09:22:46 +0100 Subject: [PATCH net] net: stmmac: Fix EST offset for dwmac 5.10 MIME-Version: 1.0 Message-Id: <20240220-stmmac_est-v1-1-c41f9ae2e7b7@linutronix.de> X-B4-Tracking: v=1; b=H4sIAFVh1GUC/x2NwQrCMBAFf6Xs2UCMRaq/IiKb9NXuIVF2QxFK/ 920x2EYZiWDCozu3UqKRUw+pcH51FGaubzhZGxMwYfeh+Cd1Zw5vWDVga/D0E+3yJdELYhscFG 5pHlPMluF7uKrmOR3XB5UUOm5bX96smAZegAAAA== To: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Andy Shevchenko , Rohan G Thomas Cc: Sebastian Andrzej Siewior , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Kurt Kanzenbach X-Developer-Signature: v=1; a=openpgp-sha256; l=1436; i=kurt@linutronix.de; h=from:subject:message-id; bh=VtSbRYpW3xF4C41G3ex623iXQjdzDj88U4DQFDFPBXA=; b=owEBbQKS/ZANAwAKAcGT0fKqRnOCAcsmYgBl1GFX6qPgFG7he/qqzxgpfnWgTU2YcF03X2yM/ NoH2jMuOjCJAjMEAAEKAB0WIQS8ub+yyMN909/bWZLBk9HyqkZzggUCZdRhVwAKCRDBk9HyqkZz gur9EACitYR7rS+jg6FDa7PC9TDwFeID84CDFl3pTZmtMXggcm64U8mhgFVOoH+cMjqirqiro44 fvFJUvS5ajdy1NjTYarTnRXXFfCmsBMavgycpFMJ38YwjiMp/gvbzGihQUW7jJQgVZdEeAEV2EL IQqUeZmga9rAOxk5wxPzIJTLZe8xaa5iY2giuMM9I3WuoUmb7v2wUXh7rgK8NaPedgj9KotBDuT 0Ekg5+YPEWfwyLTnhOJv5+Vj6MCkKIhEwEcC8n2evR5Fral+E2CfqZjLXS3JJl3OrAAMqt3r830 JqLYkFIL0o5ZePCh88iPusVFpMZHgPk357PU7VZDjmOBJxawieSWOh9CbGUbXDSZI+oXvlN0+FK MjNemptzgvcRuGTV1ClwXFm9fyUfr3DInBlJm8Tuq3IN5i0VF0aMELFIzXFYStQy3QIfMkKujvi Us7T2/q8aXgx9Fy6rJx+GEriK8Wa4hwfYVvf8HxuyKryXVXP223TdhN6IyeJbbrKBGWkr1IKuiM ADBqVC2QXXNNKEhj9yggHFsTG0b6MGIgVX48G3Djz01v+bI6tCsItugg1bzroA3Ny78tORY4YWi QBZUFOAo5yCx2dp+YqKrW7sMddKDVmLSOHJQyyLGGKhzBaQ6SkntpnlW+ZOL3+y1s7Hc4rJ+MKl CMmFMPSlTzYfmNQ== X-Developer-Key: i=kurt@linutronix.de; a=openpgp; fpr=BCB9BFB2C8C37DD3DFDB5992C193D1F2AA467382 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_002254_304847_F3950306 X-CRM114-Status: GOOD ( 10.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix EST offset for dwmac 5.10. Currently configuring Qbv doesn't work as expected. The schedule is configured, but never confirmed: |[ 128.250219] imx-dwmac 428a0000.ethernet eth1: configured EST The reason seems to be the refactoring of the EST code which set the wrong EST offset for the dwmac 5.10. After fixing this it works as before: |[ 106.359577] imx-dwmac 428a0000.ethernet eth1: configured EST |[ 128.430715] imx-dwmac 428a0000.ethernet eth1: EST: SWOL has been switched Tested on imx93. Fixes: c3f3b97238f6 ("net: stmmac: Refactor EST implementation") Signed-off-by: Kurt Kanzenbach Reviewed-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/hwif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 40b9385dd8e6a0515e1c9cd06a277483556b7286 change-id: 20240220-stmmac_est-ea6884f9ba3c Best regards, diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c index 1bd34b2a47e8..29367105df54 100644 --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c @@ -224,7 +224,7 @@ static const struct stmmac_hwif_entry { .regs = { .ptp_off = PTP_GMAC4_OFFSET, .mmc_off = MMC_GMAC4_OFFSET, - .est_off = EST_XGMAC_OFFSET, + .est_off = EST_GMAC4_OFFSET, }, .desc = &dwmac4_desc_ops, .dma = &dwmac410_dma_ops,