From patchwork Fri Feb 23 12:59:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13569061 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F35AC54798 for ; Fri, 23 Feb 2024 13:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jMDryzS6LGNJS1Hd2FPXEqwGJY6664P6EuYtU6i9PxM=; b=qPA70zT1Ay+Ttd T1kVvEz+f3GcWnxak8veRTzGFJoANnpNmGJXMcsVcR6h/jfbRE4cP4q9YoH9uRcl2KuhDRrhWEpcU W/s8+d5v7pVikw1kI3RTWTJ+vE4pexgYr5QF0Jp/aY01Ph8cDmNFmeNT5lD7vZD01IUmi7k8lUO90 /thxAhR2FxNJxQ8He4DYZWHD0EHyQYyHbLgjYXqSTwQ0DiK6EI2lfFUR7j2URW186ePhprQu4tBe9 oKniDXq6rt2DkGtP31upIVBjUPE5U0hp2BvunPkKrEurNsaiM7on7GxsEmCRgNmIv5kbPDGuNVA4n 8bFFs3h0PznQm6/WiLBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdVAT-00000009Rkp-2ItF; Fri, 23 Feb 2024 13:00:45 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdV9Q-00000009RWH-0WaS for linux-arm-kernel@bombadil.infradead.org; Fri, 23 Feb 2024 12:59:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=rBx1blh4xuCB+VFBP4Wh1rtc18mYoCINFRD9SP1tiA8=; b=FNm3cnk2bo+Cezugq+4TOrEUF4 xU3YgthXzy1cumOwuktcwOpp0MqGDC+TnJGunTVWWK7n4kVVdm3wtvzk26uHXKq8R349l2z4hEHGd 06FSzWpiespLNuKqbdLg+/is2tEmpyTuP1YbexdUUnVidDGTXtfzq9C4P5RoMdzKIRZVGUDjmSF9A GBy2pl2q5Df3JTqXg0QihRVlnQuMpcUvoT83+HYxJM2PejFMt9Q718mJuJjz6Ty/VGusd5TYiGatc aa9bmE0r20SMVfDSvGQqb/31sjSnj7HqcGHhO5Bm62ONPoQKdUnz3uHr/N+edhjMcmF/GbdLvQTuw bP9WOeEw==; Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdV9N-000000075bo-0AaG for linux-arm-kernel@lists.infradead.org; Fri, 23 Feb 2024 12:59:39 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdV9C-0005W8-EW; Fri, 23 Feb 2024 13:59:26 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rdV9C-002QaQ-0O; Fri, 23 Feb 2024 13:59:26 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rdV9B-00AKBn-2y; Fri, 23 Feb 2024 13:59:25 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mauro Carvalho Chehab Cc: Laurent Pinchart , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 3/5] media: nxp: imx8-isi: Convert to platform remove callback returning void Date: Fri, 23 Feb 2024 13:59:06 +0100 Message-ID: <2ccfcae7bab286651fcf6deff988e23c5113ac22.1708692946.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1977; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=E7ixt9bejmqPsEXF4Y9G6SEIQ5e1STE67Lq1/1c+n9A=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl2JagJXkMm7LYwx9xfCGyElXFSriLLDC9+0UiQ R8bb/PmHw6JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZdiWoAAKCRCPgPtYfRL+ TlB8CACQRNTrGnOtSKYPjUtNma55r8JlzQGu/zJ1VT74MAlqgbvfH43L7qoa5zw6oZho7NHfOAI ue1iFMv62rvfp8cLD2NAk4ZSzqAhY+svBCGz+nMJZlNmTSvAU4EcHoxcf1ZkV4UuhYyQtemehkt jHR5+9yCjhVq9PGt82UmLjP6BsEIp0aIxHHLu2ulBnajBU4VaMMrkRuPR0K4MmAcVpjoNMzUAYa ajIgWVTZxcNnjSE/cbvIaOag8uX8uqku6IrbxfuzfxpniP3k2tNhxjQgyx0g7K+Uco8VrF1EIwD WxsiMfZvfjRGkx2ZqE71o5DGq94wZrweTEbFLa3WIAX385iK X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240223_125937_081264_C3421B6E X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart --- drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c index f73facb97dc5..c2013995049c 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c @@ -506,7 +506,7 @@ static int mxc_isi_probe(struct platform_device *pdev) return ret; } -static int mxc_isi_remove(struct platform_device *pdev) +static void mxc_isi_remove(struct platform_device *pdev) { struct mxc_isi_dev *isi = platform_get_drvdata(pdev); unsigned int i; @@ -523,8 +523,6 @@ static int mxc_isi_remove(struct platform_device *pdev) mxc_isi_v4l2_cleanup(isi); pm_runtime_disable(isi->dev); - - return 0; } static const struct of_device_id mxc_isi_of_match[] = { @@ -537,7 +535,7 @@ MODULE_DEVICE_TABLE(of, mxc_isi_of_match); static struct platform_driver mxc_isi_driver = { .probe = mxc_isi_probe, - .remove = mxc_isi_remove, + .remove_new = mxc_isi_remove, .driver = { .of_match_table = mxc_isi_of_match, .name = MXC_ISI_DRIVER_NAME, From patchwork Fri Feb 23 12:59:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13569060 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1F24C54798 for ; Fri, 23 Feb 2024 13:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WVpkgsz/mhB1KyFuKVgpDGNwZvAyc0JlQRjg0UQcprM=; b=RZGadE9z+7dW17 2NDH8O+gB2IIbbigN5KPnFu72ScVuJdzXJ9UvNUr00IEmYOzboHCjZVos5q+ETKkVtk9n9l6bIbdZ Ii+eKQSKHaioS/p9aX+2CiI2OfJuTlLcLqrIiy9m6aO6p+TpLRuivxAE2ASAygQfR4si1tb2YTmgS EAByi2Ob4Kse1ZpjIEwPPr1NivVU05c4+jipWCXMqZhH5+owkUJiLdADtUxUKD4b591OS30eD5rKk TK2K/aJvlsdSRSDN9uWtJN/TDi2r3qHJY4ycMmAK4Gp1DRIqWpp/4oP+VXNomn/DkXr82Wly7PzvB WrOAbWN7uemMyI78Ne0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdVAR-00000009Rjj-051K; Fri, 23 Feb 2024 13:00:43 +0000 Received: from metis.whiteo.stw.pengutronix.de ([185.203.201.7]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdV9K-00000009RU6-2MWE for linux-arm-kernel@lists.infradead.org; Fri, 23 Feb 2024 12:59:38 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdV9D-0005WK-4S; Fri, 23 Feb 2024 13:59:27 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rdV9C-002QaT-6U; Fri, 23 Feb 2024 13:59:26 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rdV9C-00AKBw-0M; Fri, 23 Feb 2024 13:59:26 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mauro Carvalho Chehab Cc: Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 4/5] media: stm32-dcmipp: Convert to platform remove callback returning void Date: Fri, 23 Feb 2024 13:59:07 +0100 Message-ID: <7e85adb3c2f11fc10e5a18bb341c5af8b35c4d88.1708692946.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2028; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=cGnrBxqGxCmEtDuWxONLei27GY0x+yDrPiamFnG8NHg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl2JahwqaMRF1CPxbj1EwCu77uTj4TmU1PEFAv0 XDuPOLeA6mJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZdiWoQAKCRCPgPtYfRL+ TvIEB/wO/V5+nBYCIwEezMcTGrxF/tGJ/B8e/Tpc+wD+9fdC08TczkaX3SjLpKbKXnUBz1gFtSF eSgmgjBxElnAHO8nk9zwJ36R+tTm3zouqkIPCJ9x5oOVZFTqHXWl2hkqZJ/eOBSLZ7O76LQdicn 7pJXhibFTOEsnBgJhYP5225xLWw99rc0uxtq2RV7ycJ3KqlbbSoxbuc06Dxy2yg8YJkJuYvWLat 8mB8DZ6OHnK2nY3DBQUgnPfNu6zdBlWqRGTgTSMKPzOh91wSSNgxttjlXhPA0TJwf+IAyrs5tTO 4yAdjF6oXbhvr8pgTbOMcOXlVabbFgqgVOkVUJ0h6ebidEfK X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240223_045934_796400_9F6AD58A X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Alain Volmat --- drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c index 32c6619be9a2..bce821eb71ce 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c @@ -517,7 +517,7 @@ static int dcmipp_probe(struct platform_device *pdev) return 0; } -static int dcmipp_remove(struct platform_device *pdev) +static void dcmipp_remove(struct platform_device *pdev) { struct dcmipp_device *dcmipp = platform_get_drvdata(pdev); unsigned int i; @@ -534,8 +534,6 @@ static int dcmipp_remove(struct platform_device *pdev) media_device_cleanup(&dcmipp->mdev); v4l2_device_unregister(&dcmipp->v4l2_dev); - - return 0; } static int dcmipp_runtime_suspend(struct device *dev) @@ -588,7 +586,7 @@ static const struct dev_pm_ops dcmipp_pm_ops = { static struct platform_driver dcmipp_pdrv = { .probe = dcmipp_probe, - .remove = dcmipp_remove, + .remove_new = dcmipp_remove, .driver = { .name = DCMIPP_PDEV_NAME, .of_match_table = dcmipp_of_match,