From patchwork Sat Feb 24 15:05:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ankit Agrawal X-Patchwork-Id: 13570514 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7386C48BF6 for ; Sat, 24 Feb 2024 15:06:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C88B6B0087; Sat, 24 Feb 2024 10:06:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 551E06B0088; Sat, 24 Feb 2024 10:06:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CB216B0089; Sat, 24 Feb 2024 10:06:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2AA3B6B0087 for ; Sat, 24 Feb 2024 10:06:48 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 029191C0B1D for ; Sat, 24 Feb 2024 15:06:47 +0000 (UTC) X-FDA: 81827024496.02.4628A16 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by imf18.hostedemail.com (Postfix) with ESMTP id 1620C1C0023 for ; Sat, 24 Feb 2024 15:06:44 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=SXgkrcyg; spf=pass (imf18.hostedemail.com: domain of ankita@nvidia.com designates 40.107.236.41 as permitted sender) smtp.mailfrom=ankita@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708787205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h+ywp5UkykNQ3aMvxMGYYpq4jSVqAUBUPb6JArHzsYQ=; b=3jMPSUVqsslnuHFFUUxUcbnybmLy/03Zq7DwWcprchFNAlpQnzJkUXgQe3NXTIRpNzSMWi pofh/VI4V1jjR9qrF6+yU1lq0H/3G6mKqqg+V6IGOEpouiWjUwHkoYM+rf/ScbGnWnaVWh XJfMtLAZk6lkIGKskYO0nrqSCxIJVQo= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=SXgkrcyg; spf=pass (imf18.hostedemail.com: domain of ankita@nvidia.com designates 40.107.236.41 as permitted sender) smtp.mailfrom=ankita@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1708787205; a=rsa-sha256; cv=pass; b=oQhARiRTrekLat1BdNPsdFUayTsUe7Z1GeCwET9daxeKlALBTNe7nlhvilEr6S+EPWHCDt ogMEA7DJ/rN8YE+8QEo7H3lkq6wV98mLyLJJjdyDTK+mipmCDXqd90Dypy1Ps3sqvx6biy bS29+vyDinAuFHVEpjAiqneGKSwK0q8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=drlMwsPgMfPZfLwtt8UTVsNDEbJP0+HNrYED83tXrc+yHCoK8Da0AcPxDUZwMILLZ80IedscILEb1cvsjAZMzW2yjiCzkGWaltOHcJ8Xlv9OAttB8V/eBYpJ8ZpFPAAI72+GMCPPiKfQJvtxZu0V++Bf9U1XYTKSLT2vDDxFnwKbVbJSQOjNouu3yYWqZcQsUHzNH8KcrCEFGjqfLnOd8evn2MGecuoEnMQTULevhAxuWcCLqGa1vRj84ibaYnaQpsD5Dr1stlcFquFYc2S1f3M+nCV7XrnbK8R4eeO1zrLI8s/6vwq6xJ/Z/HnR8cDijLJ5uEmQqYtn63ljwPETGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h+ywp5UkykNQ3aMvxMGYYpq4jSVqAUBUPb6JArHzsYQ=; b=iN/MOTlYwwEDYhe9VkMh+gi2EZylXBETaoOz9okFLYTioopFJ2t4kXbg6WyeWybMVigEEcR1hPoB7WAUUUjwRxl/GofD4I1scvwrvkJ8dMSfgnfUi0/i360Bv2CJnSm3VoXDVG0VdsamEg1YMsJ6yOOKCJl7oxn1YyayANAnuJVUMQ20FTQAsI7r4t3zDIYtGzH7Aj/6wZ9g+SruEuXQMwFeUVne48ZzA+2GecYaP5VB4gpVbcoSqcmeWN6xJb8u0LgfZQ1IN/oVBYAg/lhG3/bG3H9oSmeADn4LBORz8bENUcIvH8XE0/8rW0LWoyg8zCgFxmr5HVnkmq6js2xkDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h+ywp5UkykNQ3aMvxMGYYpq4jSVqAUBUPb6JArHzsYQ=; b=SXgkrcygcSTHP8wbjQ7+oBvd/hdvVS6iW88wK0z+SrrHjSXX8AOKkvlqsjEpU+kwSAjuaollMjGTENEcXy6/3QPZCpisyLYjweDRYLoBmh19+xffQQbHqm1tQtHCq7jIPKrD+o9QyJwuqvY6p7BPQciizTDwLggBi1jKU9BtrbtxNm6whkMWCFBkJuZ8xiz9oCsd/NJddPkMVT+VgNGaiND/1p9LZCj9r8GySJWoRBnwdvGuFOWZJxOW9R08hCPw46XtRZi2yYs4lDsjrhB1W9rMW6y1yamDyG0x+SUwQ5wWPqVi6eAR8ZheqMDhim2ti0aa+Z2PY/ErvtpflsdSpA== Received: from CH2PR07CA0014.namprd07.prod.outlook.com (2603:10b6:610:20::27) by DM8PR12MB5446.namprd12.prod.outlook.com (2603:10b6:8:3c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.27; Sat, 24 Feb 2024 15:06:41 +0000 Received: from DS3PEPF000099D4.namprd04.prod.outlook.com (2603:10b6:610:20:cafe::2) by CH2PR07CA0014.outlook.office365.com (2603:10b6:610:20::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.48 via Frontend Transport; Sat, 24 Feb 2024 15:06:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS3PEPF000099D4.mail.protection.outlook.com (10.167.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Sat, 24 Feb 2024 15:06:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 24 Feb 2024 07:06:24 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 24 Feb 2024 07:06:13 -0800 Received: from sgarnayak-dt.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Sat, 24 Feb 2024 07:06:01 -0800 From: To: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , , , Subject: [PATCH v9 1/4] KVM: arm64: Introduce new flag for non-cacheable IO memory Date: Sat, 24 Feb 2024 20:35:43 +0530 Message-ID: <20240224150546.368-2-ankita@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240224150546.368-1-ankita@nvidia.com> References: <20240224150546.368-1-ankita@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099D4:EE_|DM8PR12MB5446:EE_ X-MS-Office365-Filtering-Correlation-Id: 08e102a7-c499-4a76-2f5b-08dc354a3502 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hJcFBXTXVG92cGb3AUrTD742IXiqCbacmyRbv9T786km35QxkxujHhp5rdWJsyf+3L+vONSO4ZBkuZu4J8GbABY+URnkgbx2BXWtwuBIBIcR5q9VqsgRVzGGrd09aNycB+/VDT8KoCdlGvN7jQLA1+urEBtl/Q52A30k5wXdLbnx2PWotd1G/VRL43/jMY1GzytyxOx9pNUT7pMFwzWQxiWsuheh1JsZu0hwE9OXP14+WFCXRidy6ZftObZ03uKqs/lNR78XvbMwlfHrg2kaAl1ntcMbEpJz3dZ/r8gWY8yFJJUN+lfqECDt4l0u/Ggora0aOOQwXJ0uKzxHAC5fTnNCwWp5FjerEb/mZEwsvoOGJluX0HiLp5lCw+yIt3l9UuRBGMGvgsY9HwskjTffvi70mu4P1JJmaAGEicFIT7vH8+4LObQsOcXgiLstfXBrRCPiiMvP5f6R685wDaiUpdNRKrbpzFHQthnPqvjad6B4zFtZGmAFQdOAbvedinhE05NMa5vnhfaArP1aMDUiXX6BuNKA3ecyyESpdRY2fYBijtpDiO3POFWa1kQO0PtVLM/vX3PaWfyyEixMB0xZyQDDrWIPEf5sQrIw55nCmh7ujbpmkm+sLomN3Mbgt+LEyfaypeKbCrSmuDF/+lJRu4IpuRDf658PipSz37IoeMnGKfEjxWT9demrYxIi5n6VQjZpEIwc9i4gjcglad8vvA== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230031)(36860700004)(40470700004)(46966006)(921011);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2024 15:06:41.0611 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08e102a7-c499-4a76-2f5b-08dc354a3502 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099D4.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5446 X-Rspamd-Queue-Id: 1620C1C0023 X-Rspam-User: X-Stat-Signature: d3jf3hfpou97utbpcq6nzhzkmiqntg85 X-Rspamd-Server: rspam01 X-HE-Tag: 1708787204-25086 X-HE-Meta: U2FsdGVkX1/G+c2pJbcnJ1Bv+/W2nr+Kwfjf7o9BHc2ZZ1tPtSDc3FhUylN+F1tmuEN1mGzUzrBc4UVdRBctulwgKxCWH+/CXu6h/BQFF6IWpsCxWsQuklaEogK7eX0RCi9sZs6UPRivc5F28phKS7EFHNs1BEtFOq9p2NvoFPgAUjG2pCbVHRPO0Jv6mxlypIEw7NArzpIfyXMvR+0kJCJGDnNtV2eMn3C4wJp4qyIbhUCKD7DryWoUdiFrLq2P50/FGWQgNA1T9QpWOzICL9Ww0WZPUjz8bN0isXIfSN9Fzdlj8YqHo2Jzd+uniVDrwXNFKJu7Sg3WjT7RoJJSTMwsU4rA8/b70/uQiOB5wDnPsx62Wt03frEi3BgeNyIEEhsWr/iMWtLGPbdHIWbk2k/8Z90Ad21cn9QBz3DM0gpk4RtTczdmOmKY/QRKlAcYL8cb9DKpVQetfASMk7CO2lm1r6EjXG6DY2nafp+KLwsFOZUX72ozoNeiVze2xB506lXuEzNJuwR/tunEt29KaD2xDgPNMa5R+lu54gJYj719KxQwlGc0jV9uw13p4gRoeU4Idh1yef9VKkkWlqadcs0mmLGfAeDWCAt7jSt+3PCcBGMZAsNFVTa91qU+YYXlEWYAULuV8scCRvYgdY/byzqg+LkWmwyoHH4t2FeEvL7XMz77ebZQKTRAGyWkBeDXaKapPDL6lTrKt3hwL495YQwnAvTeDF/3ei/8/Z72uX0H5R04e7rplWtPn7QKOAvHFRtkYc69NYF3yV5EHeS9LY493+kYcloBOndPLIkizlHTv0/7MpmiCNCzuA7sZjI7lIEhKXwQIY4BLyN7KKkD65+0dkqJdSJnN1GzKUdS8HfCz4gEjDX4fYCykF5qnO2aemGfCxZZZS1y8owvKPKPoEwgOks+E/McaESTx1aYUOCrCLBuB1mQmJ2uCktfBJjVOVAJ14XGk+dEd7SnZyp lmThb86I YaFp8jgw33d+CiKriQxrVV2jZ0PyT2udpyOz5oOq1EUn2RhHlEFT3NbFIdcA7P34FP+klvYIQySwL/H8d8W4Tau3WrYhOeZXB9vokUiLGSqDnX0Uip/NVaIi6FjXDprt4bTK9TyPjv3A4D7MhM6ycqiOGwzR+/BYKsQ+b6ZV8GBJNHHDaxlkRk+cL0O/1HnX26WtIp/3QPg8it6nxSypJoo3YYGmoOWZECpAvi3+UNHKZtg+7H01YXe2NnYbo2YC8m/W5lxnng4WeSyfZ/xNZin/CwzrCmyCBdjxRONcqjpUhC73caxvHFK4ZjA+ONhVIdyT6sHA+BrCYvG0rBpDLTHrIsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ankit Agrawal Currently, KVM for ARM64 maps at stage 2 memory that is considered device (i.e. it is not RAM) with DEVICE_nGnRE memory attributes; this setting overrides (as per the ARM architecture [1]) any device MMIO mapping present at stage 1, resulting in a set-up whereby a guest operating system cannot determine device MMIO mapping memory attributes on its own but it is always overridden by the KVM stage 2 default. This set-up does not allow guest operating systems to select device memory attributes independently from KVM stage-2 mappings (refer to [1], "Combining stage 1 and stage 2 memory type attributes"), which turns out to be an issue in that guest operating systems (e.g. Linux) may request to map devices MMIO regions with memory attributes that guarantee better performance (e.g. gathering attribute - that for some devices can generate larger PCIe memory writes TLPs) and specific operations (e.g. unaligned transactions) such as the NormalNC memory type. The default device stage 2 mapping was chosen in KVM for ARM64 since it was considered safer (i.e. it would not allow guests to trigger uncontained failures ultimately crashing the machine) but this turned out to be asynchronous (SError) defeating the purpose. Failures containability is a property of the platform and is independent from the memory type used for MMIO device memory mappings. Actually, DEVICE_nGnRE memory type is even more problematic than Normal-NC memory type in terms of faults containability in that e.g. aborts triggered on DEVICE_nGnRE loads cannot be made, architecturally, synchronous (i.e. that would imply that the processor should issue at most 1 load transaction at a time - it cannot pipeline them - otherwise the synchronous abort semantics would break the no-speculation attribute attached to DEVICE_XXX memory). This means that regardless of the combined stage1+stage2 mappings a platform is safe if and only if device transactions cannot trigger uncontained failures and that in turn relies on platform capabilities and the device type being assigned (i.e. PCIe AER/DPC error containment and RAS architecture[3]); therefore the default KVM device stage 2 memory attributes play no role in making device assignment safer for a given platform (if the platform design adheres to design guidelines outlined in [3]) and therefore can be relaxed. For all these reasons, relax the KVM stage 2 device memory attributes from DEVICE_nGnRE to Normal-NC. The NormalNC was chosen over a different Normal memory type default at stage-2 (e.g. Normal Write-through) to avoid cache allocation/snooping. Relaxing S2 KVM device MMIO mappings to Normal-NC is not expected to trigger any issue on guest device reclaim use cases either (i.e. device MMIO unmap followed by a device reset) at least for PCIe devices, in that in PCIe a device reset is architected and carried out through PCI config space transactions that are naturally ordered with respect to MMIO transactions according to the PCI ordering rules. Having Normal-NC S2 default puts guests in control (thanks to stage1+stage2 combined memory attributes rules [1]) of device MMIO regions memory mappings, according to the rules described in [1] and summarized here ([(S1) - stage1], [(S2) - stage 2]): S1 | S2 | Result NORMAL-WB | NORMAL-NC | NORMAL-NC NORMAL-WT | NORMAL-NC | NORMAL-NC NORMAL-NC | NORMAL-NC | NORMAL-NC DEVICE | NORMAL-NC | DEVICE It is worth noting that currently, to map devices MMIO space to user space in a device pass-through use case the VFIO framework applies memory attributes derived from pgprot_noncached() settings applied to VMAs, which result in device-nGnRnE memory attributes for the stage-1 VMM mappings. This means that a userspace mapping for device MMIO space carried out with the current VFIO framework and a guest OS mapping for the same MMIO space may result in a mismatched alias as described in [2]. Defaulting KVM device stage-2 mappings to Normal-NC attributes does not change anything in this respect, in that the mismatched aliases would only affect (refer to [2] for a detailed explanation) ordering between the userspace and GuestOS mappings resulting stream of transactions (i.e. it does not cause loss of property for either stream of transactions on its own), which is harmless given that the userspace and GuestOS access to the device is carried out through independent transactions streams. A Normal-NC flag is not present today. So add a new kvm_pgtable_prot (KVM_PGTABLE_PROT_NORMAL_NC) flag for it, along with its corresponding PTE value 0x5 (0b101) determined from [1]. Lastly, adapt the stage2 PTE property setter function (stage2_set_prot_attr) to handle the NormalNC attribute. The entire discussion leading to this patch series may be followed through the following links. Link: https://lore.kernel.org/all/20230907181459.18145-3-ankita@nvidia.com Link: https://lore.kernel.org/r/20231205033015.10044-1-ankita@nvidia.com [1] section D8.5.5 - DDI0487J_a_a-profile_architecture_reference_manual.pdf [2] section B2.8 - DDI0487J_a_a-profile_architecture_reference_manual.pdf [3] sections 1.7.7.3/1.8.5.2/appendix C - DEN0029H_SBSA_7.1.pdf Suggested-by: Jason Gunthorpe Acked-by: Catalin Marinas Acked-by: Will Deacon Reviewed-by: Marc Zyngier Signed-off-by: Ankit Agrawal --- arch/arm64/include/asm/kvm_pgtable.h | 2 ++ arch/arm64/include/asm/memory.h | 2 ++ arch/arm64/kvm/hyp/pgtable.c | 24 +++++++++++++++++++----- 3 files changed, 23 insertions(+), 5 deletions(-) diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h index cfdf40f734b1..19278dfe7978 100644 --- a/arch/arm64/include/asm/kvm_pgtable.h +++ b/arch/arm64/include/asm/kvm_pgtable.h @@ -197,6 +197,7 @@ enum kvm_pgtable_stage2_flags { * @KVM_PGTABLE_PROT_W: Write permission. * @KVM_PGTABLE_PROT_R: Read permission. * @KVM_PGTABLE_PROT_DEVICE: Device attributes. + * @KVM_PGTABLE_PROT_NORMAL_NC: Normal noncacheable attributes. * @KVM_PGTABLE_PROT_SW0: Software bit 0. * @KVM_PGTABLE_PROT_SW1: Software bit 1. * @KVM_PGTABLE_PROT_SW2: Software bit 2. @@ -208,6 +209,7 @@ enum kvm_pgtable_prot { KVM_PGTABLE_PROT_R = BIT(2), KVM_PGTABLE_PROT_DEVICE = BIT(3), + KVM_PGTABLE_PROT_NORMAL_NC = BIT(4), KVM_PGTABLE_PROT_SW0 = BIT(55), KVM_PGTABLE_PROT_SW1 = BIT(56), diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h index d82305ab420f..449ca2ff1df6 100644 --- a/arch/arm64/include/asm/memory.h +++ b/arch/arm64/include/asm/memory.h @@ -173,6 +173,7 @@ * Memory types for Stage-2 translation */ #define MT_S2_NORMAL 0xf +#define MT_S2_NORMAL_NC 0x5 #define MT_S2_DEVICE_nGnRE 0x1 /* @@ -180,6 +181,7 @@ * Stage-2 enforces Normal-WB and Device-nGnRE */ #define MT_S2_FWB_NORMAL 6 +#define MT_S2_FWB_NORMAL_NC 5 #define MT_S2_FWB_DEVICE_nGnRE 1 #ifdef CONFIG_ARM64_4K_PAGES diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c index ab9d05fcf98b..3fae5830f8d2 100644 --- a/arch/arm64/kvm/hyp/pgtable.c +++ b/arch/arm64/kvm/hyp/pgtable.c @@ -717,15 +717,29 @@ void kvm_tlb_flush_vmid_range(struct kvm_s2_mmu *mmu, static int stage2_set_prot_attr(struct kvm_pgtable *pgt, enum kvm_pgtable_prot prot, kvm_pte_t *ptep) { - bool device = prot & KVM_PGTABLE_PROT_DEVICE; - kvm_pte_t attr = device ? KVM_S2_MEMATTR(pgt, DEVICE_nGnRE) : - KVM_S2_MEMATTR(pgt, NORMAL); + kvm_pte_t attr; u32 sh = KVM_PTE_LEAF_ATTR_LO_S2_SH_IS; + switch (prot & (KVM_PGTABLE_PROT_DEVICE | + KVM_PGTABLE_PROT_NORMAL_NC)) { + case KVM_PGTABLE_PROT_DEVICE | KVM_PGTABLE_PROT_NORMAL_NC: + return -EINVAL; + case KVM_PGTABLE_PROT_DEVICE: + if (prot & KVM_PGTABLE_PROT_X) + return -EINVAL; + attr = KVM_S2_MEMATTR(pgt, DEVICE_nGnRE); + break; + case KVM_PGTABLE_PROT_NORMAL_NC: + if (prot & KVM_PGTABLE_PROT_X) + return -EINVAL; + attr = KVM_S2_MEMATTR(pgt, NORMAL_NC); + break; + default: + attr = KVM_S2_MEMATTR(pgt, NORMAL); + } + if (!(prot & KVM_PGTABLE_PROT_X)) attr |= KVM_PTE_LEAF_ATTR_HI_S2_XN; - else if (device) - return -EINVAL; if (prot & KVM_PGTABLE_PROT_R) attr |= KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R; From patchwork Sat Feb 24 15:05:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ankit Agrawal X-Patchwork-Id: 13570515 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0D6BC54E49 for ; Sat, 24 Feb 2024 15:06:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F9BD6B0089; Sat, 24 Feb 2024 10:06:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CF036B008A; Sat, 24 Feb 2024 10:06:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEF5A6B008C; Sat, 24 Feb 2024 10:06:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DBF456B0089 for ; Sat, 24 Feb 2024 10:06:49 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 977B5A036E for ; Sat, 24 Feb 2024 15:06:49 +0000 (UTC) X-FDA: 81827024538.07.4C0783A Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2041.outbound.protection.outlook.com [40.107.96.41]) by imf01.hostedemail.com (Postfix) with ESMTP id D5F494001E for ; Sat, 24 Feb 2024 15:06:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=KWIgJFKA; spf=pass (imf01.hostedemail.com: domain of ankita@nvidia.com designates 40.107.96.41 as permitted sender) smtp.mailfrom=ankita@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708787206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TRcaF52CMEO0QVAE1H8FtXam0Yy4RMg+DZcetOMVhQ8=; b=ovbK1AA0ab3BxlULihSvsYWXBQ0CoMsF9twNAa1oLNHBxhXcrnfHV/a2dg/J5TjzcewRsP 4O3pGBYQLPqXHz7AQXIWfA5drxtlfJPt4o0g2m/ALSayK7UqjPvBK7zahd2+Q0cVVmI7F8 vA+zswUID9zjlWgHbMFUQypk3a/wjBI= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1708787206; a=rsa-sha256; cv=pass; b=l4xjkZ843f/PhOLiORZrT0h+wudms145AkImyoAR68z/eV87Yjt6QM0XBg5RRMSI5/2van hm9pJWI3ku0DMx7taeXgSQiFKPOOKCbRHRsf1amok8DMvD8HPfNtGgoSiYuSh7UbW/BTl+ DQ514CaOK85dPGydI5h6qXj0OmBny9M= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=KWIgJFKA; spf=pass (imf01.hostedemail.com: domain of ankita@nvidia.com designates 40.107.96.41 as permitted sender) smtp.mailfrom=ankita@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NDf4fv7T1lBTifRrEkxcE9lFwwsVWk/VxSSJoTn/CSyRPJiGM9bCfSc+8oPkaI8ADDwG4gphbqX1L45LAF1z6tWjxAuf3a5DkREnMdTnDMondMdPwogj2WTEipeC9X6XuVPl0gqUrL60D2wQ0LDwlk+HeOrLw/UQD4Jez5CuSb/v7BKDuZAspZewFUAmJDM38vp7F/jD04aBQ9LdeopAXej2DsgH5afoJsxQ7h9xQr6YnEf1BPO+k98qmMHNWIVvY5PAJXXr5QiGzRpJyp5hhSQ3fCxzRB+TeBf1YHfTAJlmunF6mCseH1zRHF944fBhv3erBFpyJXeaPiOkyDkSGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TRcaF52CMEO0QVAE1H8FtXam0Yy4RMg+DZcetOMVhQ8=; b=AcEN9N4YgN9T5qBSJ+XHE76bfjdsteSDNwPWHMPb4KaB/Eez2pXCbFG7+F7lFr5AZgLyN58hZL7NFSUWHa4alnam6KQ3RfxzZPQ+6nR4ba0qDNF5gt5BvW/DdNrrSXm6oIqZPj56q5nHgXFm1JcVE1UZTTdSD1g3Rv7Sg/7vMSspK2jFe6OV0azxbyBv7LY6sCxYj/Qd5YskVwOkgIYh2UMxnlHlgqsQxKz9I4WEUul8DW5gPRUY+RR717+N/JH47LAAplReQ4utOvXyMFKvPkNY2FXqB5i8u23hrx2KRHckfv0IOocLTNxO1JequSf7Pev1BEBT8f0TnbG+KJV3yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TRcaF52CMEO0QVAE1H8FtXam0Yy4RMg+DZcetOMVhQ8=; b=KWIgJFKAjq4YPghbcHaSgnZJJjRCDw7gJ8zeBl/xNF+mXimwTgqlMeRl4LR9VfhFI3GiEswvn+FMOwPzgxiyzTi9KSeHAuytOU+SH7M6BhpRDpFv/gqXhWE82Qlo+fGUpZkiRVRr+6PQovoSkGR1hC+pEajdk0J+dwA4xy7DTYfrht68BhvCXHHTLye29174P0UHdFF0IGZNJG9+0LxE5RxaJZFAJ417EjPj1pkn4QyCTyqVm+Nh78CyDEBVcZ+QYrotoLIyv9kbaYWzk5OjUjdAabD9F+yPd6rsRS4WvFc9ihZJZ5ass3j+jXTWrWEhcX1xIUoFIFbGXNw4wL1eOw== Received: from CH2PR19CA0003.namprd19.prod.outlook.com (2603:10b6:610:4d::13) by DM6PR12MB4894.namprd12.prod.outlook.com (2603:10b6:5:209::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.24; Sat, 24 Feb 2024 15:06:43 +0000 Received: from DS3PEPF000099D7.namprd04.prod.outlook.com (2603:10b6:610:4d:cafe::99) by CH2PR19CA0003.outlook.office365.com (2603:10b6:610:4d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.48 via Frontend Transport; Sat, 24 Feb 2024 15:06:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS3PEPF000099D7.mail.protection.outlook.com (10.167.17.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Sat, 24 Feb 2024 15:06:43 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 24 Feb 2024 07:06:26 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 24 Feb 2024 07:06:25 -0800 Received: from sgarnayak-dt.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Sat, 24 Feb 2024 07:06:14 -0800 From: To: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , , , Subject: [PATCH v9 2/4] mm: Introduce new flag to indicate wc safe Date: Sat, 24 Feb 2024 20:35:44 +0530 Message-ID: <20240224150546.368-3-ankita@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240224150546.368-1-ankita@nvidia.com> References: <20240224150546.368-1-ankita@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099D7:EE_|DM6PR12MB4894:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a6cb5b3-b8d0-4c8f-13d7-08dc354a3645 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nVrX1apBYdo/a+4PsEVLutRl/RKwgEa/DqzhLB8gwRjIFSeGeZSqMWG+l5LBjyCv5uCMM5Yrf5jJrikHd4W1iiT5gOWFwsOaNS64rlBLoLxKJBdIlrYflrqZ5O5t0THqvWjl79ehf6buiQvYONplBdhwg0gUBe9GqmnAzKsORGO2VEhIt4M4ARz2Dmp8JHB9BMUqNAmnJ1cXoql0Rj7fhiQgbgKnlD5BtTWe8f3f5+oI5rLXRk9d0PrV8STWr1paRjaWGrdKHi6UTwwZYH3Q+6I8Nd7Jorr6wpcqcbNM5MpGB0UnI4IRgu5Tkrcmd2RPzfwxaZFqi6YD+NVCZ/S3Z0s3ZwtVBSbOkagnxAffo8DefNuEbraKPqOFQpSOJxDXKcEjh77GcDMAzEBeKMtGI3F+igtd0D6qv3/yQjjl289mlZM0Bo47hVRLjfdfymE/rr7oQT5s/09MN1hJiGQDyaCEKLp1Pys/TWnAHE/0XUaRPHxi9ymCwuNL3MCbLaKCifiBfIDojuFEoDvpU7fIdoaz/VsWkR4eBec/i1xtPXzOKFT7rGiWIelYG91am0eCwVPx9ScbFKYsYLZuMqAPfAqheBFfjYIMBPrxFt8zICReux2eHC9GnlVhMJ6Qro3/y2fVXShUFHPH05qcXo+jGrPyzCAGrVKu6Ju6YH5UVgw= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230031)(36860700004)(40470700004)(46966006)(921011);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2024 15:06:43.0054 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a6cb5b3-b8d0-4c8f-13d7-08dc354a3645 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099D7.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4894 X-Rspamd-Queue-Id: D5F494001E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: miganhr5uhgujh7j58mpk5x67d6fpeih X-HE-Tag: 1708787206-28433 X-HE-Meta: U2FsdGVkX19JOi4+OXdN43iia4XjWkWEuiSHLUY7cTY9o1PxpKStXN4YIH5jEnUJYxv3I/vH387tZLqIs8CVmcampeDYbzM0i1dFByUVdaIZ4VibxG3KH/Mo8nmdXCom61/AFutSb+IZvLhJUJeiV9PX6NcviCL4eLiETLCz7a0H3dFoaFs+sdbW1Qg6DJ+5meEWwRlwPx6Ccc1reaBu8AmgAzItNJe+pFyF1TNteNvgRdMKMrnVshIEYSCrwR4dTQsu+HXRTJiCc3G6VruUcUkF3xOR6HhZhuK3aojLhpXZpc1u0p7+jf6QhCarkqsRzJonN5tJltwAKWG/PPkMnB5sSKHCmODRPGQun2K0/igd+v5jfk0h0TJ3H2cNkEMEFcwFjVRZPqzPnPNTQIWESrB/RY7+a/zSrwdiNdLKCCbM5qrp97/DXKXaVr3mOtoFmKMHx8AFQqs3cgmyQycqLLj4TDyBIxlfRgd998W/I7Pf0b3+5sR2s5ku/cEz7+3wpwTvrqavC0Ir83qv8AlQ6HHJwNp07ZUIdTeYAbxMvogeVaAbXyNmxStUToYoRFmCHSzQAKOZvHhGYUaxfO8B7qhs+KXXWU2n+3QI7RM8J0WoZhAlJ9iW60Q16wwKghN5a2vTWjeUXlQ7E6LfTzm6XnOeyRLjdtg9TF5//2ftZYTgpPypu/l9KhQ8mxTweAFkfUG6XoZelTBdKuGg8tE1QzNLiBYhYEl56+BilCUfDrDi1XyAOalE4fVDLOsvvPwOIRIkubOwqTM6DX/clPWa83Lb7/OXWv5e7hrSKJpSs69gitOcB5IbKM9R0a9e8TiVGps6TE8PH+t5TcckeAOQUbToMLc1fDoGLZDwzoblCjC6OJdkQYxfbI28OQz1QkXGWxGjAWJEvU/QuXXxrxyrSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ankit Agrawal The VM_ALLOW_ANY_UNCACHED flag is implemented for ARM64, allowing KVM stage 2 device mapping attributes to use NormalNC rather than DEVICE_nGnRE, which allows guest mappings supporting write-combining attributes (WC). ARM does not architecturally guarantee this is safe, and indeed some MMIO regions like the GICv2 VCPU interface can trigger uncontained faults if NormalNC is used. Even worse, the expectation is that there are platforms where even DEVICE_nGnRE can allow uncontained faults in corner cases. Unfortunately existing ARM IP requires platform integration to take responsibility to prevent this. To safely use VFIO in KVM the platform must guarantee full safety in the guest where no action taken against a MMIO mapping can trigger an uncontained failure. The assumption is that most VFIO PCI platforms support this for both mapping types, at least in common flows, based on some expectations of how PCI IP is integrated. This can be enabled more broadly, for instance into vfio-platform drivers, but only after the platform vendor completes auditing for safety. The VMA flag VM_ALLOW_ANY_UNCACHED was found to be the simplest and cleanest way to communicate the information from VFIO to KVM that mapping the region in S2 as NormalNC is safe. KVM consumes it to activate the code that does the S2 mapping as NormalNC. Suggested-by: Catalin Marinas Reviewed-by: Jason Gunthorpe Reviewed-by: Marc Zyngier Acked-by: David Hildenbrand Signed-off-by: Ankit Agrawal --- include/linux/mm.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index f5a97dec5169..59576e56c58b 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -391,6 +391,20 @@ extern unsigned int kobjsize(const void *objp); # define VM_UFFD_MINOR VM_NONE #endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */ +/* + * This flag is used to connect VFIO to arch specific KVM code. It + * indicates that the memory under this VMA is safe for use with any + * non-cachable memory type inside KVM. Some VFIO devices, on some + * platforms, are thought to be unsafe and can cause machine crashes + * if KVM does not lock down the memory type. + */ +#ifdef CONFIG_64BIT +#define VM_ALLOW_ANY_UNCACHED_BIT 39 +#define VM_ALLOW_ANY_UNCACHED BIT(VM_ALLOW_ANY_UNCACHED_BIT) +#else +#define VM_ALLOW_ANY_UNCACHED VM_NONE +#endif + /* Bits set in the VMA until the stack is in its final location */ #define VM_STACK_INCOMPLETE_SETUP (VM_RAND_READ | VM_SEQ_READ | VM_STACK_EARLY) From patchwork Sat Feb 24 15:05:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ankit Agrawal X-Patchwork-Id: 13570516 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC671C48BF6 for ; Sat, 24 Feb 2024 15:07:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DEC66B008C; Sat, 24 Feb 2024 10:07:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B59E6B0092; Sat, 24 Feb 2024 10:07:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 308166B0093; Sat, 24 Feb 2024 10:07:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1CAA26B008C for ; Sat, 24 Feb 2024 10:07:01 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F4090A1336 for ; Sat, 24 Feb 2024 15:07:00 +0000 (UTC) X-FDA: 81827025000.11.ED82AA1 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2078.outbound.protection.outlook.com [40.107.96.78]) by imf15.hostedemail.com (Postfix) with ESMTP id 2CAF9A000C for ; Sat, 24 Feb 2024 15:06:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=TNiRMXRA; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf15.hostedemail.com: domain of ankita@nvidia.com designates 40.107.96.78 as permitted sender) smtp.mailfrom=ankita@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708787218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=38sjOfDPntBETQKkswWgEcSo54FMUnu5XGVPfsldrSI=; b=KZxZXD4nQzAJ9kV5qhaVNVgBkoQBqn8tceg10eoj6I7FDVdcmLkdus/1o0mE/MIo8f8sg7 O22z8kiBxqQsnU+fI30F/zJle9cYoWxn+OVPUDTeVqwCl8c8Sf10arz3fD6GPh8DeePfBE /7HeUQffjKTta5hMh3frf2YBO5WFZwA= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=TNiRMXRA; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf15.hostedemail.com: domain of ankita@nvidia.com designates 40.107.96.78 as permitted sender) smtp.mailfrom=ankita@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1708787218; a=rsa-sha256; cv=pass; b=04JrwHl5cUEe3PO0cLWwSFNkCuEAUuLb6lGJ8P7TgWmLMnrzd2IfFFRbbZizWwlJMnhVU2 08FJVS6DIyLhoKui2mQpmMUWhA7Jhy2x5pasQdePinbZfPN2Ziuz5njouZkFs+mSFinNwt WlF/YMJIVSw242fC8OPbfoyQVC1VkgI= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iVK0cGu5AHYQzOIG5CqN20lOKmV/xjbxSytF+soKbCVvzMiRjh6RdMqIQUpz3FMK2I52odqvjqc0mibf7jP1FJigvXSbfYywxXDeLjTClyUaYpyq/t5Q2pjPaqAoVDkp3r5b4+3GOSDplqRH0c5uwEtsVLnNoI79CoueZgWRFJ+o0lznGqSuCPuJiKHv9JYHN+k3X9nRdtOrpynSJzYf9AQh014kF4RtUnomuNES8pKm7j8i/Sv6XPsI5Ad7wF/jB+5nuUKeMNr5c7h3TLiyxQ8RY0vjHJZLvEdR3jV5FGn8X53YxUhLrL9V3AirRHFVN3w9zQvJHv+BS7bM8BOfNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=38sjOfDPntBETQKkswWgEcSo54FMUnu5XGVPfsldrSI=; b=WmvW+6NXll5gtsyx1SHhD0GBWwXcqDT5LyphXfdISP9NRkLKPum4Wu0AXn035CHCSh8Mgyf9BQqn22dCXAT8HF48dHUN8MHxbnKJU9HJz7OzaQm7LCs2wC+mbgDxwNRcnzxr8Re0BWVx2ZXJIF+5y/MANxuyQ0xCaRcu8x9X7/580yr5Kc+X3TBblGgEhYLF+Hc7FQqm+OREwxQjYRY7rA1V/ACFjV9ZqFESvfI3AHtPzeXAgmi1ZK5BUlsSPGtV+mMjusg3QIevR0E+r8WXSj07YuuEsdYrAaU69CiLmHqKK5hdQgNCjM8DHgsGeMkw1HoUAULNeIkDSucNOfUgVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=38sjOfDPntBETQKkswWgEcSo54FMUnu5XGVPfsldrSI=; b=TNiRMXRA9pRJy1r5DiCE6GcB21XKZL/8C9fbYIUvfbh6/hn03mYNSjkXLqtoc9OpyD5+/Es/Hm5zaYV8ReSPh6NMHFj9+tA4snYQ01+J1L2s6faxYqwOBNoKkVA5UDYY/USLv5oVIFi1awfsS3Qm4dK8GLtVzvyjJxjY6Yu2QJEnMX7Vy7a+yktIXMQNmFAiUV0RaoXJcR4kmtQxgACAhJlXq/8JV/E9tLSHEC6qRaP/qCAOTWmyQBzt6B/dFgfuqeNTpGuEqki/DNjbzl8ZXfQfMVDseNgRtsC5DldV+zL/3tKMzctNgDa17K7Phdfk7GXIH2CBMA7L+SCURe9p+Q== Received: from CH2PR19CA0011.namprd19.prod.outlook.com (2603:10b6:610:4d::21) by DS0PR12MB7678.namprd12.prod.outlook.com (2603:10b6:8:135::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.24; Sat, 24 Feb 2024 15:06:52 +0000 Received: from DS3PEPF000099D7.namprd04.prod.outlook.com (2603:10b6:610:4d:cafe::d5) by CH2PR19CA0011.outlook.office365.com (2603:10b6:610:4d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.48 via Frontend Transport; Sat, 24 Feb 2024 15:06:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS3PEPF000099D7.mail.protection.outlook.com (10.167.17.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Sat, 24 Feb 2024 15:06:52 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 24 Feb 2024 07:06:39 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 24 Feb 2024 07:06:38 -0800 Received: from sgarnayak-dt.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Sat, 24 Feb 2024 07:06:26 -0800 From: To: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , , , Subject: [PATCH v9 3/4] KVM: arm64: Set io memory s2 pte as normalnc for vfio pci device Date: Sat, 24 Feb 2024 20:35:45 +0530 Message-ID: <20240224150546.368-4-ankita@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240224150546.368-1-ankita@nvidia.com> References: <20240224150546.368-1-ankita@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099D7:EE_|DS0PR12MB7678:EE_ X-MS-Office365-Filtering-Correlation-Id: a20538a6-580a-4022-9a6b-08dc354a3bbc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hC4hhayOtUyn4ffNXgDelGD9b4kuU8rkx2Zk+kuSiRA6qt6A6GVWHvEnuvbA0PdW0bkE6rCPtzu/K/FYsnRQ6BoxppPYZaKxtmeHGYxGlvzpKKGjoCVbgwKAgV4neYhozCyvl9RrZ7cO7FrWKFbke7QBt/dAbs97b0qTshqwNxh0fTuiEVc/QBbT8RwCPG9agpDz50vPxodgNGgPYpZ8miUmgwARYVdmybHHChcOo3uwk25oRpePbkIdc0QOhBqSL9YdVsVEZxq1jxwv+7SxFIxEbe0iZz3xEj9L4mylXDWav8Q78BHCaQNl5bbJvcHzJvrlGxfhg3T4LxEuCDbyj2PNzDd+1/DiTsgsWoYyaVVK878Ff6opm+pwikR6oS2QbncRU7IowTuf6UeDh2cb5gN6UA6GHsU7tN7WeJH9Gr2WFtvmM8SNMaaECj/nOHb5cEaIqz9FAaozLi0I84I3233SeYHEVrIfFHV0PRdTIBLJA56BAAN5LPYH474+/28FERNJhrnphDoXFwSLTyLOrtf9YAez2+EYDWG+vdh++tXqCRGV3nqYD/JsU85HRosohh/XdBz1NNrC02DVpMxAlbDy9IVD99K0wc8Xjns51qLS8M1uUMM+Ca7gkzPQgRBilGk9ukt6DjRn3i14rtb8ZvL87tLKu7dZSu5zheqnU6Y= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230031)(36860700004)(40470700004)(46966006)(921011);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2024 15:06:52.3179 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a20538a6-580a-4022-9a6b-08dc354a3bbc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099D7.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7678 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2CAF9A000C X-Stat-Signature: 5z5ucr8zia74y6ci43g7httt9zssm5cw X-HE-Tag: 1708787217-104233 X-HE-Meta: U2FsdGVkX1+i488rlEUNjuqgd4rOL2yNi+8ym9G9IcGdmW/UiBe6IUL4eYTHb5mcaThxCrQsFXovLhQyADl8RdzaGPxTYXq1/t6UkyzXARQuyt4FbkWt7lZR/Re/1iAUmYo2Xswp1qI/iHvwmY7hXqyppuCIv7uLldC6irChtIDuc6j/ts2SFj+tmaNFR7SpMkP8M2+xourmdHBjOy2g0PIy/BxhrWqEVUWYvHOJLLHLI5M3J9xsjNKjaL0AdBBgQFVumPYFYYq8WY/JO9HS5zogP0eXfQJiExgIi4SHmEliuoWC+BKSFkBvYK7f12uSWm1e5YVf0uF+Jwj8wSQeP7IdeSvkVOR5+VYHJN4Cid93BVB0uLbvguO+dnwdd4HjKzYxqBahLYMlccjhPKmAYP1G1z6Xj4aGFSfIMlCDDdTRmtg6nepQ5axueqx7gTqflWBP0BKCETeH2zIUZRv4fu0QMQUMoM4LNG3GDOFCceekvlvSQh7AudWnTPoVkEVu30NK1OpZzu/fV+ubg9Guq0qN35WfWfsnMkHCYF8EW5vRT6NpYRqUHVPskcEi3tznKBOYf4hPFxlHUSNyOfOMW+huX9zJMHFYm4He8fclQ+G5LOUmDP9hgvY8v5qcZFwc3zsqnF+vlaO7rQZeFT65hRZnhSKpwnqPbcn884S2CclMIrGyRZZJNFBCV0GmPaz6g46ssJPSN7fBOezxs7LGJjcUr26eAUe6/1rQgTpGltnoNkMKP8rqNaYKcrF+d1gFSTmJmzAFoHPwrRBQpFSl0ZJWpf6NLagSJIQ+kMYMz0aSayhKLre86TrMT2fOB5h2Su70aNfNdcMEs/unRvi6YtfUx/AMiG99bf210FCSneRO6WD1a2TpwVM7vhzrcAx/JyUkxIy/EHHHiPKkp0CP+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ankit Agrawal To provide VM with the ability to get device IO memory with NormalNC property, map device MMIO in KVM for ARM64 at stage2 as NormalNC. Having NormalNC S2 default puts guests in control (based on [1], "Combining stage 1 and stage 2 memory type attributes") of device MMIO regions memory mappings. The rules are summarized below: ([(S1) - stage1], [(S2) - stage 2]) S1 | S2 | Result NORMAL-WB | NORMAL-NC | NORMAL-NC NORMAL-WT | NORMAL-NC | NORMAL-NC NORMAL-NC | NORMAL-NC | NORMAL-NC DEVICE | NORMAL-NC | DEVICE Still this cannot be generalized to non PCI devices such as GICv2. There is insufficient information and uncertainity in the behavior of non PCI driver. A driver must indicate support using the new flag VM_ALLOW_ANY_UNCACHED. Adapt KVM to make use of the flag VM_ALLOW_ANY_UNCACHED as indicator to activate the S2 setting to NormalNc. [1] section D8.5.5 of DDI0487J_a_a-profile_architecture_reference_manual.pdf Suggested-by: Catalin Marinas Acked-by: Jason Gunthorpe Reviewed-by: Catalin Marinas Reviewed-by: Marc Zyngier Signed-off-by: Ankit Agrawal --- arch/arm64/kvm/mmu.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c index d14504821b79..1742fdccb432 100644 --- a/arch/arm64/kvm/mmu.c +++ b/arch/arm64/kvm/mmu.c @@ -1381,7 +1381,7 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, int ret = 0; bool write_fault, writable, force_pte = false; bool exec_fault, mte_allowed; - bool device = false; + bool device = false, vfio_allow_any_uc = false; unsigned long mmu_seq; struct kvm *kvm = vcpu->kvm; struct kvm_mmu_memory_cache *memcache = &vcpu->arch.mmu_page_cache; @@ -1472,6 +1472,8 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, gfn = fault_ipa >> PAGE_SHIFT; mte_allowed = kvm_vma_mte_allowed(vma); + vfio_allow_any_uc = vma->vm_flags & VM_ALLOW_ANY_UNCACHED; + /* Don't use the VMA after the unlock -- it may have vanished */ vma = NULL; @@ -1557,10 +1559,14 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, if (exec_fault) prot |= KVM_PGTABLE_PROT_X; - if (device) - prot |= KVM_PGTABLE_PROT_DEVICE; - else if (cpus_have_final_cap(ARM64_HAS_CACHE_DIC)) + if (device) { + if (vfio_allow_any_uc) + prot |= KVM_PGTABLE_PROT_NORMAL_NC; + else + prot |= KVM_PGTABLE_PROT_DEVICE; + } else if (cpus_have_final_cap(ARM64_HAS_CACHE_DIC)) { prot |= KVM_PGTABLE_PROT_X; + } /* * Under the premise of getting a FSC_PERM fault, we just need to relax From patchwork Sat Feb 24 15:05:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ankit Agrawal X-Patchwork-Id: 13570517 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06EB5C5478C for ; Sat, 24 Feb 2024 15:07:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FD016B0093; Sat, 24 Feb 2024 10:07:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ADFC6B0095; Sat, 24 Feb 2024 10:07:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 727136B0096; Sat, 24 Feb 2024 10:07:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5CEC66B0093 for ; Sat, 24 Feb 2024 10:07:13 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3A5A3C0369 for ; Sat, 24 Feb 2024 15:07:13 +0000 (UTC) X-FDA: 81827025546.19.19B5E59 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2065.outbound.protection.outlook.com [40.107.95.65]) by imf02.hostedemail.com (Postfix) with ESMTP id 52F3880008 for ; Sat, 24 Feb 2024 15:07:10 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=k8Z5dSS1; spf=pass (imf02.hostedemail.com: domain of ankita@nvidia.com designates 40.107.95.65 as permitted sender) smtp.mailfrom=ankita@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708787230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vrVed4bH4ZNo5+WAlGpRDDR5GnNw8bBIVXunyFMfGm8=; b=f2VFi9G/GZR/lnTER1jauSX/E2hDfAIc3ylt31KqWOKhEkEoWZahfUh63cJrkaRzyjwkLa yI98fzOmrfp0EjlZAtv8sQIsWPG7toyS5SpQj2ZDEPfRbF2Mrr9AQCxvFyOs0+P6NRsVaN D6biyoQzEPZ2c0w8X2Z4EzcA+64BR9k= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1708787230; a=rsa-sha256; cv=pass; b=w2ULBj3OuTJl5/2Ce77Zd8RpQoCcDl8Bqzyu4GCzUFhA4Cki5bioG08aOlFbXbFyfbiiyy ItS8yd1Ifb8v4u1sutvhgrPp6c0fUstTbzWO8IFAj47u2MvWnWTdjpM/dSvZ9vpry5vn17 R2k4e2VbuLGJOteQrxLFWuQ2NqC/9H0= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=k8Z5dSS1; spf=pass (imf02.hostedemail.com: domain of ankita@nvidia.com designates 40.107.95.65 as permitted sender) smtp.mailfrom=ankita@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OcnfSWyOFQggSiPTsES65PhBheOmwfvj3zgWuTC9GWHqsJ2j2mjY4ZwNU4SJUwhc9x53l1C6biFXWtziQw+WxYDOpWWnrbUjItzDBD1qLLs1+qt5I/FYjojRZmqkBbWNeSP3GebSLtthUIt6fMEGQuv2XuoHLDYl5bztSPdR0p07cciaTEaMvlsIcqUGPRzqf9SHjgZOqDG2ph5IJvqINHVfwYwLG+zMpWW1pu/8nPX8wqe6X0Mc3mUkMJSOVIcBd41zIycC4Dp410PSG9loxEx08tWvvgIOhDb9wk09hEqj0Y9OTmv+0Pda7VgDDmLjZmEu/1Tr4+NVc0swjTgRwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vrVed4bH4ZNo5+WAlGpRDDR5GnNw8bBIVXunyFMfGm8=; b=imUB0lDCeJbrMEpP74471V1uwXeC6zSjztnlULNvXgyu0dv3ZBz5AKFRnmvIbvzmYKO4kokxcRkX3vtJY9M1eLn54YsvQ3HNr4qUfKV8zwsMG9SlFd3LUqhokzJ4HmZpc4cpI83shk39unNjyXFjFFD4OygZJKHv3+ji6S2n9qKnYeK0QoNx/xZrTnsP4tCURd1GJ39WkVciDPEP2CNlSb5DeRLOl1fxoO9CNaUl1W6mw1kM/Qq7AAvLdD+JMmEcJ6R9AelNZhpNc0E4tQyRrjqt8tynH7EmxphT0QJE3U7oFi8P1uXlzlViBXb2MlaCjwFm66aktIEcKpyznax8CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vrVed4bH4ZNo5+WAlGpRDDR5GnNw8bBIVXunyFMfGm8=; b=k8Z5dSS1+XZWFfeyb7JtGwpF6xBbsOykuKYdSiI4lG1DjI2pLyD//987TA9VAmaEbOW4OqO7/nuY/0+wLeYfUe9mH7PqW6E9Ndo4XEI5Ycv4naE+HCJyn26NiadmBQZYr0cehi8skRdt2O9W4E+IhZp3sgMmCgu2qjOy748G/qGnEg4iOjTRiF9Z+F5kUUjUqB7oJG95Ow6JasVtqYxlKXRwyL946X4dBBBFPgHl8b30BS+1ZPCRo5MA3NmcgdHB4PmuPJ6eee0pUWyL/7zBuXeGpakWYlI7dtfN8z+lVw2CbkK7sKGkd2p+Eit51cjIaxuyKXh3cI232QcVzrtlDw== Received: from DM5PR08CA0052.namprd08.prod.outlook.com (2603:10b6:4:60::41) by BY5PR12MB5511.namprd12.prod.outlook.com (2603:10b6:a03:1d8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.33; Sat, 24 Feb 2024 15:07:04 +0000 Received: from DS3PEPF000099D3.namprd04.prod.outlook.com (2603:10b6:4:60:cafe::71) by DM5PR08CA0052.outlook.office365.com (2603:10b6:4:60::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.48 via Frontend Transport; Sat, 24 Feb 2024 15:07:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS3PEPF000099D3.mail.protection.outlook.com (10.167.17.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Sat, 24 Feb 2024 15:07:04 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 24 Feb 2024 07:06:52 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 24 Feb 2024 07:06:50 -0800 Received: from sgarnayak-dt.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend Transport; Sat, 24 Feb 2024 07:06:38 -0800 From: To: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , , , Subject: [PATCH v9 4/4] vfio: Convey kvm that the vfio-pci device is wc safe Date: Sat, 24 Feb 2024 20:35:46 +0530 Message-ID: <20240224150546.368-5-ankita@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240224150546.368-1-ankita@nvidia.com> References: <20240224150546.368-1-ankita@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099D3:EE_|BY5PR12MB5511:EE_ X-MS-Office365-Filtering-Correlation-Id: a1b01687-e8ad-4423-fd11-08dc354a4307 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GxjN7Bwq1Hwv/A/mtDSKWWm4FjbCfLkQvpJEyuKbzX9Y6HdylNrePnfdtgf55bu9XhhbP6bLnOFqWF9i6xaIvdW7BvhuCWgdvoxhyq43q5a7orbA/0bSt95gkrspg2sPSGRrQuzL5mCEwyzmBYEgtTHmsSEm2yH4jU+N+H+Pjfb9EgWy/wHIHVRrvCxzQDccTcqD4WfTgWGZ7b5g38jcfd/asoc8kboPe1C/BMJTk/n8DCAwHf0xjRhCAD09b1KrNMA0zc9kmK5PnNvMmIOa7Vqbbad+RwMFuZDbDYjMg1c2bmomp7ZacCqQquXLOuinEn3dLlssscL0qF6deYGQOwyTIjNFDuib/i7Ld1xpwPEtIczzLZ3ab/KFz3/o8xb5C+5SU7ttaTD93P/ggwca9IGPRjSxe9eFv8JpCZVyzPI6KOoFc5N7KwTJvGunhtl/5QjGRPfMMENd6K4s+dYtIUfPo1ynL2fcxG+v4lMwFRaO/82ttdnhFvM/1JBG+wnMc9JxzTtJqSTtZU+fjzEzIxiOB0jrZEB3lE1XS28DR/fhn/1+MAN4k9ZRLRWUKaQ2yvtvU0QoU/J4u7xe9HnxmV2Q95zJgJbXPfbSbi/7bdKFH6Tlwwc9kS+nhkfk/mmdsaS8elePZESo6uhoynwlMKv7pHgt6TVbfCObTclF/JA= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230031)(36860700004)(40470700004)(46966006)(921011);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2024 15:07:04.6499 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a1b01687-e8ad-4423-fd11-08dc354a4307 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099D3.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB5511 X-Rspamd-Queue-Id: 52F3880008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: h5ohrzkqa19bz8e41p7khm657uc8h9iu X-HE-Tag: 1708787230-580362 X-HE-Meta: U2FsdGVkX1/4e8ANIjS/8qfUaksJObdPD3C/ro1c+2ja9mv3T9emeDuvwdpyYYrrbAKKkzUZz9f990rScxV6aQ30iMnMnyFxzOLUsNqO/9JhTeHorofROK7qd9Yul/hM9LADR7TAGXHIIjQFTVY0I7lAOCab89dXB9EZkhI1iV36/POP592JAthjMTOWiChoxPHWPKrkWJQ/lgKzjovlU7Oj/Krv+CAd2APrw6niva5YoOEKWRF9P+eli5hXxvAb0w4h76/f2x+6N3J1dqBilBFNBSetTu5r+uoOxOV6Ad+hvbhGGVnLaI3qj625uRmvXdnQv4CjCaCj+32Y3mFQcpq0H9zsdK0RVxc1WHw4YeKfVdQqyAG3WrGLJ/A7C6MZDNaRId5JtktikzRFk6h3akOaOsLuu0qfJeCy2/KNFqFyopt3CohYLWU3ZRIp2T5E59Cl1PKv+BPYpOqShHWg7HaVBT+OnMMx83PESD1pvKDm4wuVQmXEhOgBpdm1PP3dPxCTLNGhHhQgYUEXhe3eu3tKsJ43wS8NGqqRT8RG2j+cW5VMTcgLAo2np75Zh+Ydrd7FXErAoL/4q/sNYNQVe06YspDXH0NVLlPKUeYG7PATuLJQ0JesKh8mk7C+rqc6uC+kiFdwLOJjovKgjOToJ1Fu/Z2dMu4LYenzV2n3QxBYknS68qr0g7ByU/aEYwlkysvPF8pcY/0qKwJoBpjXvxecsavdVkfBaf5S8sxed9k99KoBObaq7JZ2eJfKOHl4FGWvi6qUoe4a/SYASkCfgygSXm8F38Wh7iZjXvI1lZ/+4Q4xOunSUd+ToTHfqxPnNMdf8O1MXEv+RUX+Gx19qF8VqZUaX7ejgyzYegQvsiNn1QeBdcVNgvCH0bgXrhgK8K/8sD2FaPDnyt/Vs5yD6gEdV+B70l6C8BQsX7cm1dy+DHlIIFTdJJDgdZNs9pv/1LdsiTrrtImi4E/UsbG 2FjU/RhM +f3SdyBhkUkBoJgi0zYaYOdfwAgSqwHd7djMRNcNNrSOalpAIqsGtVZ+LW3I8wsXCWpsOA6M9Oi1eodXp42AhmGK+4Ht9Mm2JwpGqreWy0ArurBLIbfdf7WvLACHXVuxaiomziOZvTrnjjYrCuK8xJPT0Ps68rJ647bnx6pvzAGxiZgpSmSxta5AMWtONV5E32FZesTGI0gqVYMu+cRYY+GraUDLBjmt5nKogv/0Oy1kQ/6U9c7ZqY1IgtDJOQoyw/RTQpSHQQ5N1pM8lXVWRZJ1p1etq/GIxU9UGecB98ocSv1mf8CidPuWG3mXia6zo6zQGaBlXiTInS3ikvO1iQB+Tk+iGDZvmUtv2q34D1CMUGeQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ankit Agrawal The VM_ALLOW_ANY_UNCACHED flag is implemented for ARM64, allowing KVM stage 2 device mapping attributes to use Normal-NC rather than DEVICE_nGnRE, which allows guest mappings supporting write-combining attributes (WC). ARM does not architecturally guarantee this is safe, and indeed some MMIO regions like the GICv2 VCPU interface can trigger uncontained faults if Normal-NC is used. To safely use VFIO in KVM the platform must guarantee full safety in the guest where no action taken against a MMIO mapping can trigger an uncontained failure. The expectation is that most VFIO PCI platforms support this for both mapping types, at least in common flows, based on some expectations of how PCI IP is integrated. So make vfio-pci set the VM_ALLOW_ANY_UNCACHED flag. Suggested-by: Catalin Marinas Acked-by: Jason Gunthorpe Acked-by: Catalin Marinas Acked-by: Alex Williamson Reviewed-by: David Hildenbrand Reviewed-by: Marc Zyngier Signed-off-by: Ankit Agrawal --- drivers/vfio/pci/vfio_pci_core.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c index 1cbc990d42e0..df6f99bdf70d 100644 --- a/drivers/vfio/pci/vfio_pci_core.c +++ b/drivers/vfio/pci/vfio_pci_core.c @@ -1862,8 +1862,25 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma /* * See remap_pfn_range(), called from vfio_pci_fault() but we can't * change vm_flags within the fault handler. Set them now. + * + * VM_ALLOW_ANY_UNCACHED: The VMA flag is implemented for ARM64, + * allowing KVM stage 2 device mapping attributes to use Normal-NC + * rather than DEVICE_nGnRE, which allows guest mappings + * supporting write-combining attributes (WC). ARM does not + * architecturally guarantee this is safe, and indeed some MMIO + * regions like the GICv2 VCPU interface can trigger uncontained + * faults if Normal-NC is used. + * + * To safely use VFIO in KVM the platform must guarantee full + * safety in the guest where no action taken against a MMIO + * mapping can trigger an uncontained failure. The assumption is + * that most VFIO PCI platforms support this for both mapping types, + * at least in common flows, based on some expectations of how + * PCI IP is integrated. Hence VM_ALLOW_ANY_UNCACHED is set in + * the VMA flags. */ - vm_flags_set(vma, VM_IO | VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); + vm_flags_set(vma, VM_ALLOW_ANY_UNCACHED | VM_IO | VM_PFNMAP | + VM_DONTEXPAND | VM_DONTDUMP); vma->vm_ops = &vfio_pci_mmap_ops; return 0;