From patchwork Mon Feb 26 21:37:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 13572938 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A08A9C48BF6 for ; Mon, 26 Feb 2024 21:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Yxov3Eot8lPn0AWPMRc0823B8hWKQS5xO5qnDYHEdz0=; b=EeiHHrXxb206xb NXwFJrOP0lhoHfs+zJyY+SJ9l7oVXbo4Q6pLjLn/Nab5dfd7sVt69IccRvbdQosafAyvNGuuCrSoi Cr6JPFaKBWDTu9XMrzcddNTD89u0FfmPNu4tvLZu3WqyN4oCflFRD6/VPZhziyJ6ZJjgkXakLErZP CJkMN9UIJA/RdXuOcYzb5zzDlaJxysxsyxntUEgVT1otKmrHvfRb/T8vLQ0yaqpAOkJ0OW2bVgdOf DLiqqKGGNhAcdDJZGB1feoi7hK/fwtt/puqMe360hgi+fAqW03qeDk7U9VvAXQfQdYl/5NsS8Svjo uh3FBlIEdaHuZiYWIQJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reiff-00000002jSb-1BNY; Mon, 26 Feb 2024 21:37:59 +0000 Received: from smtp-30.smtpout.orange.fr ([80.12.242.30] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1reifa-00000002jRk-3mV8 for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 21:37:57 +0000 Received: from fedora.home ([92.140.202.140]) by smtp.orange.fr with ESMTPA id eifMrgtXR2yuveifMrNhV5; Mon, 26 Feb 2024 22:37:44 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1708983464; bh=tmMG+U7Q36q6vKuwv+d+vvsnLJBFXkQVcXONSgONuqI=; h=From:To:Cc:Subject:Date; b=EbHd1cNxsqDB/7L7O3dFeESKpvfjpaziXl8cs2mYfQDbXQtoSYlkc22Wfa9TC+qde VDI271L0tQe7rDZyDsTSjP+Ph2VjZW3/KXToNCR9LpfUmzBBqPQRvRoILYspKKuXDU lh5HYbXGmnzqD36rGX30QVRAL9tGr5DjXJcVX0lVJfIjIbVOUJ1wCsbL0oMFiE9VUo y02tan8z+AgeYwvAs7/0k0lKaaNb/YNXvzQJVIp7q9MtxC+0YzCpwkEWt8sia/ereP krz6UXoVbwY5bZBaCYxESI0o4CSzfS1WfB5caVDfrNpGDRE16JnfY6DheVYoTiyPcQ xdiytd6XxcL6g== X-ME-Helo: fedora.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 26 Feb 2024 22:37:44 +0100 X-ME-IP: 92.140.202.140 From: Christophe JAILLET To: ulf.hansson@linaro.org, cjb@laptop.org Cc: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] mmc: wmt-sdmmc: remove an incorrect release_mem_region() call in the .remove function Date: Mon, 26 Feb 2024 22:37:39 +0100 Message-ID: X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_133755_372864_BD517436 X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This looks strange to call release_mem_region() in a remove function without any request_mem_region() in the probe or "struct resource" somewhere. So remove the corresponding code. Fixes: 3a96dff0f828 ("mmc: SD/MMC Host Controller for Wondermedia WM8505/WM8650") Signed-off-by: Christophe JAILLET --- This patch is speculative. Review with care. Compile tested only. --- drivers/mmc/host/wmt-sdmmc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c index 77d5f1d24489..860380931b6c 100644 --- a/drivers/mmc/host/wmt-sdmmc.c +++ b/drivers/mmc/host/wmt-sdmmc.c @@ -883,7 +883,6 @@ static void wmt_mci_remove(struct platform_device *pdev) { struct mmc_host *mmc; struct wmt_mci_priv *priv; - struct resource *res; u32 reg_tmp; mmc = platform_get_drvdata(pdev); @@ -911,9 +910,6 @@ static void wmt_mci_remove(struct platform_device *pdev) clk_disable_unprepare(priv->clk_sdmmc); clk_put(priv->clk_sdmmc); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(res->start, resource_size(res)); - mmc_free_host(mmc); dev_info(&pdev->dev, "WMT MCI device removed\n");