From patchwork Fri Mar 1 04:26:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Sakai X-Patchwork-Id: 13577987 X-Patchwork-Delegate: snitzer@redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACE213FE54 for ; Fri, 1 Mar 2024 04:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; cv=none; b=BtGV6JOCyW7OZJxERT3qtGmP9OgNtJi5dBcPyL1oni0kZ9zBKQadIBnW+GBtXJZLNBvwZr922qTriKnwq+I8lQK9DUUeWueeEWPmvde82bpe1xdBBUocRyCjWnkeALZfsN+N4n/KK87t7jXuIpkQ8nr1kZlF3DtH2PLbbT6AVb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; c=relaxed/simple; bh=1bqxSgEpBJCIl5GKT66u9dmjPUGrfqnmFaEw/wkyTqs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dQWBLwjX7cTGfpTREYcVboJX0+R58wlsaDkYYQc32S32TjiaDDcQGsrjgO4DI+HdWGlVMD3eSHPzSKHs1DEnmOl1eQfQCcCn0k10ahdrf6SD7zIr4O55n1fiwqR/uXWwbxabPiBs2AUoTleoyaVAxw9yY5ijRqz2fUYFYaiPolA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UF0x2ejh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UF0x2ejh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709267191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jkdnC//96V0kYtA+850a/JsUcKumW63KLUAnXfLbZO0=; b=UF0x2ejhqnhIOJkGM91b9MXf9nrMDTw7I6t261SpLVgXUtUfMoJWvs4Eb1Sz40ulXdK7OU yIHN+gojEXlHKEo1bhIMwhUXHb74wH6nDlaYZe1nINTEO9S7UAV3oBnzV6s54YJOP/hTCW 7kfAZdJaRwiG2U2Sxkze2DLP8QTFtNg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-zR1ysKfZNhOBj6TdlJ4eEw-1; Thu, 29 Feb 2024 23:26:30 -0500 X-MC-Unique: zR1ysKfZNhOBj6TdlJ4eEw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1261A185A783; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: from vdo-builder-msakai.permabit.com (vdo-builder-msakai.permabit.lab.eng.bos.redhat.com [10.0.103.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D2631121312; Fri, 1 Mar 2024 04:26:29 +0000 (UTC) Received: by vdo-builder-msakai.permabit.com (Postfix, from userid 1138) id C762AA15CB; Thu, 29 Feb 2024 23:26:29 -0500 (EST) From: Matthew Sakai To: dm-devel@lists.linux.dev Cc: Jiapeng Chong , Matthew Sakai Subject: [PATCH 01/11] dm vdo: Modify mismatched function name Date: Thu, 29 Feb 2024 23:26:19 -0500 Message-ID: <4dc27b1fe3b8520914b08ffe98f9ff7dcefa7f6d.1709266694.git.msakai@redhat.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Jiapeng Chong No functional modification involved. src/c++/vdo/base/vdo.c:276: warning: expecting prototype for vdo_read_geometry_block(). Prototype was for read_geometry_block() instead. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Matthew Sakai --- drivers/md/dm-vdo/vdo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-vdo/vdo.c b/drivers/md/dm-vdo/vdo.c index a40f059d39b3..c161dffeb91a 100644 --- a/drivers/md/dm-vdo/vdo.c +++ b/drivers/md/dm-vdo/vdo.c @@ -267,8 +267,8 @@ static int __must_check initialize_thread_config(struct thread_count_config coun } /** - * vdo_read_geometry_block() - Synchronously read the geometry block from a vdo's underlying block - * device. + * read_geometry_block() - Synchronously read the geometry block from a vdo's underlying block + * device. * @vdo: The vdo whose geometry is to be read. * * Return: VDO_SUCCESS or an error code. From patchwork Fri Mar 1 04:26:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Sakai X-Patchwork-Id: 13577995 X-Patchwork-Delegate: snitzer@redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C5194F60D for ; Fri, 1 Mar 2024 04:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267196; cv=none; b=gNxe9ioHmM6hjB5saZfx6EpGshf+1TXnQTDsSkufnjdAXNKnt0CHrofp76+0n6y2V+IMeMcpPfbvuyNKsQcID8KZfeAnY3+pUIA2M6h0kkD8nV4Kk7qZvCENmSCYZr/B/cuOSpFv4LcyOE19kX8KQNoa//Kl1bk5oeOyetOJW0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267196; c=relaxed/simple; bh=LAt8lN/RTEIA0z6ubzi3HI3GsC+yPgC7svXd0fUAxFo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZrAlSJKSU7iykgxsdMink/LTbQa8Wruct1gYfZIW1HPxxGX/rPKI33BnyRWTffYBU5u/ToXMapGMFbfUWOQjhI6pVYeBXgbeitA3Q8tHZ31I14L+oGoJTxOwEnCF0SJ8rFyv0knK38yCJa/iZDtufE5Py+rY0M0eLvtfQWrKf8A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f+J+JTki; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f+J+JTki" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709267194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iLnkFJVKOOVD+xdiuI3jAoqfcZOjRFFObJH/QxUgYLw=; b=f+J+JTkil4gnJzbiwPLDOY/pJV1R0CI0FDDs8ybveNyH4+n75QlaUFHOuu1GVTS7BHU6jt MUJaV+JFkUMJDBoA1wpajtFQliWO9JWRHjhrH80EspyB2FzCKQ4g7OArTlx+Fmnuma9jBw z0jCeCXwQtL6YD4ORkCoHFnsXDtTR7g= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-ANBFClkwPAG1qgjeNDKVZQ-1; Thu, 29 Feb 2024 23:26:30 -0500 X-MC-Unique: ANBFClkwPAG1qgjeNDKVZQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1238985A589; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: from vdo-builder-msakai.permabit.com (vdo-builder-msakai.permabit.lab.eng.bos.redhat.com [10.0.103.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D3A41C060AF; Fri, 1 Mar 2024 04:26:29 +0000 (UTC) Received: by vdo-builder-msakai.permabit.com (Postfix, from userid 1138) id CC922A15CD; Thu, 29 Feb 2024 23:26:29 -0500 (EST) From: Matthew Sakai To: dm-devel@lists.linux.dev Cc: Jiapeng Chong , Matthew Sakai Subject: [PATCH 02/11] dm vdo slab-depot: Modify mismatched function name Date: Thu, 29 Feb 2024 23:26:20 -0500 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Jiapeng Chong No functional modification involved. src/c++/vdo/base/slab-depot.c:2042: warning: expecting prototype for vdo_find_free_block(). Prototype was for find_free_block() instead. src/c++/vdo/base/slab-depot.c:5036: warning: expecting prototype for get_depot_slab_journal_statistics(). Prototype was for get_slab_journal_statistics() instead. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Matthew Sakai --- drivers/md/dm-vdo/slab-depot.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-vdo/slab-depot.c b/drivers/md/dm-vdo/slab-depot.c index e10c3db8e665..8c6376e79a23 100644 --- a/drivers/md/dm-vdo/slab-depot.c +++ b/drivers/md/dm-vdo/slab-depot.c @@ -2035,8 +2035,8 @@ static inline slab_block_number find_zero_byte_in_word(const u8 *word_ptr, } /** - * vdo_find_free_block() - Find the first block with a reference count of zero in the specified - * range of reference counter indexes. + * find_free_block() - Find the first block with a reference count of zero in the specified + * range of reference counter indexes. * @slab: The slab counters to scan. * @index_ptr: A pointer to hold the array index of the free block. * @@ -5032,7 +5032,7 @@ get_ref_counts_statistics(const struct slab_depot *depot) } /** - * get_depot_slab_journal_statistics() - Get the aggregated slab journal statistics for the depot. + * get_slab_journal_statistics() - Get the aggregated slab journal statistics for the depot. * @depot: The slab depot. * * Return: The aggregated statistics for all slab journals in the depot. From patchwork Fri Mar 1 04:26:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Sakai X-Patchwork-Id: 13577988 X-Patchwork-Delegate: snitzer@redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACED04642B for ; Fri, 1 Mar 2024 04:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; cv=none; b=hMDTB0KnxMNKSWqqNmQY1kpR/GLqHmxwrB4v7S03eIYCTI2/1jtrsK9kUoyqH8unos4UVk4F1fr1ifgt/f2JEt0bBaKxmRBq5wHx23sRC/X/X4JASqmjXB0YWQe2eaa4+aFd3OxAajgA8rCcor8t8LE7KARoaXhlzkq6hixztKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; c=relaxed/simple; bh=UpJEdaJfk3VusO/aIg6FuETf7yr8c+KqlS+MZ5cAbzE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pSVb4a3HxIAMqjH0MqME7o+UOLqi6+c+LhXKWREUMUTXKCgw72bGWTy48wGG5p5VdcT7ZjCYD+6kIZLWXlCT8B7f689OcqRMMBLDA0K8KzUwj+zasM7k5DwWxwBFs5wBioxXxXVQW4c7dHho7R5rvCzv8zrwlOFGKejzsJeNJyU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YKPyNCrR; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YKPyNCrR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709267191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WF51N8rH/YEY9adeK3o5MwE1bi6cY+GO435vZTWAvQ0=; b=YKPyNCrRIDlhQBx7RzNXCfb2ZAclJChUXfxGlU+Y5LbGTnWnWP9yxb7lRdXYdsuMqomi1/ BVRZUD7w9xlUewNiw/B2nqkIKePcNt8ZnSJ/X0tHeeetGZiWrV333vJSs5dfRlpYq0NRXZ ALdJ5S/7eOhbjhAcv8gFe7UmXC5nByY= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-dfBoLNLvPnuQfSEC6aK3xQ-1; Thu, 29 Feb 2024 23:26:30 -0500 X-MC-Unique: dfBoLNLvPnuQfSEC6aK3xQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1604A3C0ED57; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: from vdo-builder-msakai.permabit.com (vdo-builder-msakai.permabit.lab.eng.bos.redhat.com [10.0.103.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D4592166B33; Fri, 1 Mar 2024 04:26:29 +0000 (UTC) Received: by vdo-builder-msakai.permabit.com (Postfix, from userid 1138) id D204CA15CF; Thu, 29 Feb 2024 23:26:29 -0500 (EST) From: Matthew Sakai To: dm-devel@lists.linux.dev Cc: Jiapeng Chong , Matthew Sakai Subject: [PATCH 03/11] dm vdo: Modify mismatched function name Date: Thu, 29 Feb 2024 23:26:21 -0500 Message-ID: <380c24cb4518a72b310ecf4901eef368b6f753e4.1709266694.git.msakai@redhat.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Jiapeng Chong No functional modification involved. src/c++/vdo/base/physical-zone.c:268: warning: expecting prototype for vdo_free_pbn_lock_pool(). Prototype was for free_pbn_lock_pool() instead. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Matthew Sakai --- drivers/md/dm-vdo/physical-zone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/physical-zone.c b/drivers/md/dm-vdo/physical-zone.c index 3bcf6f1ba77f..a9380966b56f 100644 --- a/drivers/md/dm-vdo/physical-zone.c +++ b/drivers/md/dm-vdo/physical-zone.c @@ -258,7 +258,7 @@ static int make_pbn_lock_pool(size_t capacity, struct pbn_lock_pool **pool_ptr) } /** - * vdo_free_pbn_lock_pool() - Free a PBN lock pool. + * free_pbn_lock_pool() - Free a PBN lock pool. * @pool: The lock pool to free. * * This also frees all the PBN locks it allocated, so the caller must ensure that all locks have From patchwork Fri Mar 1 04:26:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Sakai X-Patchwork-Id: 13577986 X-Patchwork-Delegate: snitzer@redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 918982B9D6 for ; Fri, 1 Mar 2024 04:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; cv=none; b=L+BXglyI2NvcbiqLpCoSvTaevJz0SY8U6rgtRK1FQ0QH8Xlo50Cd42uJedtJZGZ8LTqnzYD80UfHMhY22x1tT7UKAIzjDEsiERTlUMH5njtCmTkMzeR/PNH0KADyBtY6INfM4FcHwDVXKNavRZR06yNEm1a2nBXNNVQ92RB7juw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; c=relaxed/simple; bh=z+yUqq2Scl0eyHHe7drnorGYUHyI6cTx1UzabltLTUk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=h6/zOvIrusuiXvCV9jdz8BVzL4i1Gp/QeYwhw48qd19eDaoawaFVKqFrwZe+ie1jrzLL/vTq76RiXsv0/QL4/wzx0Sk7d40lteTgA2z6X4uMK4rUYV3QIHi0uLr/hdidYvqCPQWuobRGB5rqOYGXC91ZdUeND+zisfaD1Wg/2ac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SZodH5/m; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SZodH5/m" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709267191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z+ZEx7DvIZTufWG0rGf55AKY8P2K+Rp6hi1bF4S37/Q=; b=SZodH5/mumNqhf2GwucM9eeHDFGm71lcVTPv05sgZ4njRpYtUGDnm9OuC+aXQ1Wc9Kn2FD nxAL2Z60GVEB7Micmz1+8gpVlNM0UV8I5fwxip/Ft7KIaKpJEmiYLnsJqHnKlFE3zTOdHY 8x1Noln7MkAQywPK1vgQbIbhz258eNY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-fYP0EcTMMy6iYzsQzVkwsA-1; Thu, 29 Feb 2024 23:26:30 -0500 X-MC-Unique: fYP0EcTMMy6iYzsQzVkwsA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 12A3085A58B; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: from vdo-builder-msakai.permabit.com (vdo-builder-msakai.permabit.lab.eng.bos.redhat.com [10.0.103.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D303AC11; Fri, 1 Mar 2024 04:26:29 +0000 (UTC) Received: by vdo-builder-msakai.permabit.com (Postfix, from userid 1138) id D6C75A15D1; Thu, 29 Feb 2024 23:26:29 -0500 (EST) From: Matthew Sakai To: dm-devel@lists.linux.dev Cc: Jiapeng Chong , Matthew Sakai Subject: [PATCH 04/11] dm vdo: Modify mismatched function name Date: Thu, 29 Feb 2024 23:26:22 -0500 Message-ID: <12b629369d07e907ca5b73bb1ee049f12ee4d3e6.1709266694.git.msakai@redhat.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Jiapeng Chong No functional modification involved. src/c++/vdo/base/logical-zone.c:303: warning: expecting prototype for void attempt_generation_complete_notification()(). Prototype was for attempt_generation_complete_notification() instead. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Matthew Sakai --- drivers/md/dm-vdo/logical-zone.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-vdo/logical-zone.c b/drivers/md/dm-vdo/logical-zone.c index cfbf1701ca84..e11f9c859349 100644 --- a/drivers/md/dm-vdo/logical-zone.c +++ b/drivers/md/dm-vdo/logical-zone.c @@ -295,8 +295,8 @@ static void notify_flusher(struct vdo_completion *completion) } /** - * void attempt_generation_complete_notification() - Notify the flusher if some generation no - * longer has active VIOs. + * attempt_generation_complete_notification() - Notify the flusher if some generation no + * longer has active VIOs. * @completion: The zone completion. */ static void attempt_generation_complete_notification(struct vdo_completion *completion) From patchwork Fri Mar 1 04:26:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Sakai X-Patchwork-Id: 13577993 X-Patchwork-Delegate: snitzer@redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22DE5481CE for ; Fri, 1 Mar 2024 04:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; cv=none; b=rxzNjVwodOS+RjzoeU5uEl53qzg7usKy7n4YKuYDwVtxpupTI5k3oaI8ZeJLCmgjVyDzjy3kPTSydRqlydX8We/1OW8vUp17qBysuDYgQip7PLqk4lJ+C7ve41ZtquUomy4I0UUSjJ0NAmX3bp1fEGlaQ8ONEwVc38oweOms6bg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; c=relaxed/simple; bh=B95ymkq+G2grjPNy94Z6A7DWGxYwkuQelkLZC8Pt3NY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uz54qVgyKVgi7n0fTltCJrH1ix2MIVofFPuQQZ2altCVT8VqgFhyWOwy7U3vUBTpANdOkSN1DTip7Bpu2tgtTxvXK2Holm+yMe93qDrMSE46Wg/eSISJ02kHYEZE7CC+kfk2a6NbshIeoQOmXbJ+b0GZNfrE+S8tbiAoS422k5s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OY9klrQY; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OY9klrQY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709267192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F8BG+UkK+t/qd9HLuJAHAbhlvO1VsbWTBRQSai7V58Y=; b=OY9klrQYXzsaAVI0z5WsBOiVSks9kVgSYqa7dWZ53+Y9U5SNC9d0+m7Db27uqy5a8mAqMf 4waAOuziL3oBkjT44Mjc37NVX4c3+codjtlo10oxWcPFdsaMCJlal72FdUzvh3iX4zJzMf 9kYQgRWAvuWEtwtf8kd9b2YM6QgZWZ4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-HZDmyjoiNIq3CVEu9qKLZA-1; Thu, 29 Feb 2024 23:26:30 -0500 X-MC-Unique: HZDmyjoiNIq3CVEu9qKLZA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1408D3806289; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: from vdo-builder-msakai.permabit.com (vdo-builder-msakai.permabit.lab.eng.bos.redhat.com [10.0.103.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D4DA8CED; Fri, 1 Mar 2024 04:26:29 +0000 (UTC) Received: by vdo-builder-msakai.permabit.com (Postfix, from userid 1138) id DBAB6A15D3; Thu, 29 Feb 2024 23:26:29 -0500 (EST) From: Matthew Sakai To: dm-devel@lists.linux.dev Cc: Jiapeng Chong , Matthew Sakai Subject: [PATCH 05/11] dm vdo: Modify mismatched function name Date: Thu, 29 Feb 2024 23:26:23 -0500 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Jiapeng Chong No functional modification involved. src/c++/vdo/base/encodings.c:1178: warning: expecting prototype for vdo_decode_component(). Prototype was for decode_vdo_component() instead. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Matthew Sakai --- drivers/md/dm-vdo/encodings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/encodings.c b/drivers/md/dm-vdo/encodings.c index 9e45411fe816..5012042b26af 100644 --- a/drivers/md/dm-vdo/encodings.c +++ b/drivers/md/dm-vdo/encodings.c @@ -1172,7 +1172,7 @@ static struct vdo_component unpack_vdo_component_41_0(struct packed_vdo_componen } /** - * vdo_decode_component() - Decode the component data for the vdo itself out of the super block. + * decode_vdo_component() - Decode the component data for the vdo itself out of the super block. * * Return: VDO_SUCCESS or an error. */ From patchwork Fri Mar 1 04:26:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Sakai X-Patchwork-Id: 13577989 X-Patchwork-Delegate: snitzer@redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C370F4645B for ; Fri, 1 Mar 2024 04:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; cv=none; b=WX4GjONHtm6TsAbwzRnEbkPlDz2xKuiORRBkYWtGqw/cDtFcumt9Fn6y+wpf8O3Bz/ZbIylA2bWLJn/lqihOdtRBml6n21+ksVHo9NwzgEnu98w6L+WXbFwGVKHEmVL90MuO1eTJrXDbRvw1AeIrgSPXyhpxZhybanqRWl/+zJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; c=relaxed/simple; bh=t0EsVEoVBXL8N0cOMCZvvwmBVNeOFgO0PJdtxr9TOEQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Gnj8VJWResWZNsBNiiPEbnqz7kUkcfGhZSMRnyuheGQ4HCJ/+vk7IcHecV0oL0NbTDF/dBFw2hs4WbcUWBHHTphbO+LZBzD85Xx4Qf5MU6Ne6+20UZEBetHgvIv/DBWDkb2L9iTrAZow9Dfrmi3tHYokv7sj0BCqbq2o2nbXN/E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=D5GcnR9V; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="D5GcnR9V" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709267191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N81vUnE3X1Mdbge0DdnWb/3IxUXkbPiUMgCtx/2Nsvk=; b=D5GcnR9V9PAp2ap9nkvVx0YUkUW5S1CVxEhLR/XKlZB52DhS2+Ni5V3PT3obunDj81WMcJ ZMIoV/3BFbGV1aLFyfq8gtIVbXNBsFhgfGc22YtHrAGwb2FgaNsnTOAl9DFVKLisApX1LL 4j0Deqa8/EB6J1TVsL796+q5Uh32VYI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-o-Hh3LcDMRus1S_JKfSDbQ-1; Thu, 29 Feb 2024 23:26:30 -0500 X-MC-Unique: o-Hh3LcDMRus1S_JKfSDbQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 14435800074; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: from vdo-builder-msakai.permabit.com (vdo-builder-msakai.permabit.lab.eng.bos.redhat.com [10.0.103.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D4AE1BDB1; Fri, 1 Mar 2024 04:26:29 +0000 (UTC) Received: by vdo-builder-msakai.permabit.com (Postfix, from userid 1138) id E0D34A15D5; Thu, 29 Feb 2024 23:26:29 -0500 (EST) From: Matthew Sakai To: dm-devel@lists.linux.dev Cc: Jiapeng Chong , Matthew Sakai Subject: [PATCH 06/11] dm vdo: Modify mismatched function name Date: Thu, 29 Feb 2024 23:26:24 -0500 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Jiapeng Chong No functional modification involved. src/c++/vdo/base/flush.c:97: warning: expecting prototype for waiter_as_flush(). Prototype was for vdo_waiter_as_flush() instead. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Matthew Sakai --- drivers/md/dm-vdo/flush.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/flush.c b/drivers/md/dm-vdo/flush.c index 391b6203efc6..1bc13470a608 100644 --- a/drivers/md/dm-vdo/flush.c +++ b/drivers/md/dm-vdo/flush.c @@ -88,7 +88,7 @@ static inline struct vdo_flush *completion_as_vdo_flush(struct vdo_completion *c } /** - * waiter_as_flush() - Convert a vdo_flush's generic wait queue entry back to the vdo_flush. + * vdo_waiter_as_flush() - Convert a vdo_flush's generic wait queue entry back to the vdo_flush. * @waiter: The wait queue entry to convert. * * Return: The wait queue entry as a vdo_flush. From patchwork Fri Mar 1 04:26:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Sakai X-Patchwork-Id: 13577992 X-Patchwork-Delegate: snitzer@redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 061E5481A3 for ; Fri, 1 Mar 2024 04:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; cv=none; b=R2sfmuPTMOwvDH9NxJp7xZAdcX5fPxtkmAKGGFq1tHXsNyW5VbO2dsiZ0MixBiEqQ/DoCVVhsTISpxfL6ZelzTLInpJ2ITGCWVqeG/RUSQqDwPI4ksnQSCSL2m32PycE9TBQhvnDSvDoc6OXdPWZ0Ltk0l9TMC2g3uBTOvoiecQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; c=relaxed/simple; bh=NtlM49eOQQaP81fngprRo4fb8GLBWo1oB+5m3stOY3Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=okm3afsDPsKfmyOA3VtqnpFfCdlNAtYo6uI5r6KSqXmCotYAQGbGI4fxoUzKiQVUa7/xq6Djjk95ITdzYXzovRHIPvH2zCENpgBSME/FNDdIHHLJ8NAijaP0w5ezJ1Ec8gYNCW3u7TprA+KP6zFrekREUY9XXqkzxhC/If5MobI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WzMFnWXu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WzMFnWXu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709267192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ga/LcAKvnWP6xfyB4vnhcZ8+HaUteQZPJfWL4cp46Ec=; b=WzMFnWXuxlLk8ZV8CSAXGEmprvGr7oSqgFgoCyRXfkfdZwHj3bY2+XvgB1kif7aux0VHvD 3Gpe65zr7BuT/0gj+TTUEnUOEZ3OW/egPXVu7CY5nHup4D3IGoRfdyG0zyaB1KaalCH15y JPBbZuDIOxuQY1I4WfRHH+7X2WQm8Pk= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-J9uS6Ms5NsOfE8Y2k-SjuQ-1; Thu, 29 Feb 2024 23:26:30 -0500 X-MC-Unique: J9uS6Ms5NsOfE8Y2k-SjuQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 17F1D3C0ED64; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: from vdo-builder-msakai.permabit.com (vdo-builder-msakai.permabit.lab.eng.bos.redhat.com [10.0.103.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 10EFF2166B5D; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: by vdo-builder-msakai.permabit.com (Postfix, from userid 1138) id E63D2A15D7; Thu, 29 Feb 2024 23:26:29 -0500 (EST) From: Matthew Sakai To: dm-devel@lists.linux.dev Cc: Jiapeng Chong , Matthew Sakai Subject: [PATCH 07/11] dm vdo dedupe: Modify mismatched function name Date: Thu, 29 Feb 2024 23:26:25 -0500 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Jiapeng Chong No functional modification involved. src/c++/vdo/base/dedupe.c:2792: warning: expecting prototype for vdo_dump_hash_zone(). Prototype was for dump_hash_zone() instead. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Matthew Sakai --- drivers/md/dm-vdo/dedupe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c index 9468d7fad443..c8018c5799bd 100644 --- a/drivers/md/dm-vdo/dedupe.c +++ b/drivers/md/dm-vdo/dedupe.c @@ -2839,7 +2839,7 @@ static const char *index_state_to_string(struct hash_zones *zones, } /** - * vdo_dump_hash_zone() - Dump information about a hash zone to the log for debugging. + * dump_hash_zone() - Dump information about a hash zone to the log for debugging. * @zone: The zone to dump. */ static void dump_hash_zone(const struct hash_zone *zone) From patchwork Fri Mar 1 04:26:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Sakai X-Patchwork-Id: 13577996 X-Patchwork-Delegate: snitzer@redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C51550271 for ; Fri, 1 Mar 2024 04:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267200; cv=none; b=lFQjgU90rjxwWg7V4/HdIvOo2iiwAnRqZY89LPaOzF95ubrF9vrR0bPIqbc2Roq/ocdBd8sAezzDyA6h3QIhqZankEujc6n4hYpMjFH35Lkl9XPIZzpy4tLnA51h3JhjNwyMQ4L7AsuRd7QZxTShHbUOkbEDEGeJbA91I5f3GlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267200; c=relaxed/simple; bh=4eRwPqkKswj4+hdupjfu2MVC3eRbTTuLB3y4/m8hdMQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Xvq4y/ldQWmZpX2i+9ig3VJPWgBQpWGHlF0H/4y5EzNdgqvntJdCmf2qu9/K5hSqR0UqrPNaW81KY61Aci/wry9wK0fALUIVe6WT1p3Y9dSzq5VfP+zQaIKpiYOK1dG/Y0sgOCNJci+FTwSvis9e055tblTOW296HNylGAoeghs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=h6HXB1cd; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h6HXB1cd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709267198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zw3HT7peDBkQGEUtAI7s+3KPRVlcIXBvJaulPzPGKmE=; b=h6HXB1cd4Fx4KJ/hSBAbAGws4gskSmDLO17+W/LC28TP2iF96KPQuNuieYgc911us/QmD5 YHomUW8xUGYv+aIkci42sq4hIlvhteao5AgkKsA+JenNpd2CW8ZGgcv02DFUeUXu8UsTGH 4lUGSojoT16Zd/fxDcLvN4NN1LL8AaA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-teipEVkbP0OpvNJW8-es4Q-1; Thu, 29 Feb 2024 23:26:31 -0500 X-MC-Unique: teipEVkbP0OpvNJW8-es4Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1748C85A58C; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: from vdo-builder-msakai.permabit.com (vdo-builder-msakai.permabit.lab.eng.bos.redhat.com [10.0.103.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1125AAC16; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: by vdo-builder-msakai.permabit.com (Postfix, from userid 1138) id EB108A15D9; Thu, 29 Feb 2024 23:26:29 -0500 (EST) From: Matthew Sakai To: dm-devel@lists.linux.dev Cc: Jiapeng Chong , Matthew Sakai Subject: [PATCH 08/11] dm vdo: Modify mismatched function name Date: Thu, 29 Feb 2024 23:26:26 -0500 Message-ID: <48d8767a2fd9a3577fa26e809dd52cf96d96eb48.1709266694.git.msakai@redhat.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com From: Jiapeng Chong No functional modification involved. src/c++/vdo/base/admin-state.c:310: warning: expecting prototype for vdo_drain_operation(). Prototype was for assert_vdo_drain_operation() instead. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Matthew Sakai --- drivers/md/dm-vdo/admin-state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-vdo/admin-state.c b/drivers/md/dm-vdo/admin-state.c index 94533a802edb..1423f4cebb8a 100644 --- a/drivers/md/dm-vdo/admin-state.c +++ b/drivers/md/dm-vdo/admin-state.c @@ -300,7 +300,7 @@ static bool check_code(bool valid, const struct admin_state_code *code, const ch } /** - * vdo_drain_operation() - Check that an operation is a drain. + * assert_vdo_drain_operation() - Check that an operation is a drain. * @waiter The completion to finish with an error if the operation is not a drain. * * Return: true if the specified operation is a drain. From patchwork Fri Mar 1 04:26:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Sakai X-Patchwork-Id: 13577994 X-Patchwork-Delegate: snitzer@redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACE514176D for ; Fri, 1 Mar 2024 04:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267195; cv=none; b=P9zoFVNIjiDBbPpjxuapa/OhTuj1x89j7cLC9EKpCojNls2jfdtrDI3o1NkacqoYGzabpWEeXhlIQPFs96AYcwxNyYlLDu0/o4PjwBRHniy9Zs1fjJUBo8APts+fG4JrQqed1pH5fJDXCoOitqlQAXiJNpYIydkX/1cactCd2TI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267195; c=relaxed/simple; bh=fM/l6EwmWRq9z3W6f4a/H3Mly9Ol6Fm9oav5n1xPj+8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aTbQc20QjGCfrNpvSsHboQgPVvsM0pRyGA9f3IuKuZRgQAE7Mm/Z4LIB68HPPdh3LBfzoMdvUUv3iofzLf6Ycl8T/kD/VG6Oy9B2+tsmTNq9RiRmpZRFjBul1XGUVH9vhHGEjn3Bac0Dcc5vN9i4tTeNSlUdEkOg3ZUchSWmC+s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=J6XWAJ+f; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="J6XWAJ+f" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709267191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XNlppo7VlH+01AuyUjW0dRg/x3HxHl+cA5k+RHDw750=; b=J6XWAJ+fLUs1tlCvq8tmM4O8hRp2jE0V1JF0agUsDWlCBql3QAi3gGjYSDmJqUVXUuXjwt 1K72mj0H3d8DTivJZ/1PHIdCTtkm4vEFf/0VPObCv540MX506IhM34AwDKfTNqvgzt+Pbb 7OagcHPCWfNbucWtJo8gj78nZQl98DM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-ASSHcK2_PF-DJEgODaNzyQ-1; Thu, 29 Feb 2024 23:26:30 -0500 X-MC-Unique: ASSHcK2_PF-DJEgODaNzyQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1A2E1859B81 for ; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: from vdo-builder-msakai.permabit.com (vdo-builder-msakai.permabit.lab.eng.bos.redhat.com [10.0.103.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1259DC185C0; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: by vdo-builder-msakai.permabit.com (Postfix, from userid 1138) id F0399A15DB; Thu, 29 Feb 2024 23:26:29 -0500 (EST) From: Matthew Sakai To: dm-devel@lists.linux.dev Cc: Matthew Sakai Subject: [PATCH 09/11] dm vdo indexer delta-index: fix typos in comments Date: Thu, 29 Feb 2024 23:26:27 -0500 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Signed-off-by: Matthew Sakai --- drivers/md/dm-vdo/indexer/delta-index.c | 2 +- drivers/md/dm-vdo/indexer/delta-index.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-vdo/indexer/delta-index.c b/drivers/md/dm-vdo/indexer/delta-index.c index 4aace707545a..6a85f93bbcb1 100644 --- a/drivers/md/dm-vdo/indexer/delta-index.c +++ b/drivers/md/dm-vdo/indexer/delta-index.c @@ -35,7 +35,7 @@ * * Each delta list is stored as a bit stream. Within the delta list encoding, bits and bytes are * numbered in little endian order. Within a byte, bit 0 is the least significant bit (0x1), and - * bit 7 is the most significant bit (0x80). Within a bit stream, bit 7 is the most signficant bit + * bit 7 is the most significant bit (0x80). Within a bit stream, bit 7 is the most significant bit * of byte 0, and bit 8 is the least significant bit of byte 1. Within a byte array, a byte's * number corresponds to its index in the array. * diff --git a/drivers/md/dm-vdo/indexer/delta-index.h b/drivers/md/dm-vdo/indexer/delta-index.h index 3d2ea19aef61..53f6c6ac0bc7 100644 --- a/drivers/md/dm-vdo/indexer/delta-index.h +++ b/drivers/md/dm-vdo/indexer/delta-index.h @@ -141,7 +141,7 @@ struct delta_index_page { * record at the end of the list. * * (5) If at_end is false and is_collision is true, the delta_list entry fields refer to a - * collision entry in the list, and the delta_list entry can be used a a reference to this + * collision entry in the list, and the delta_list entry can be used as a reference to this * entry. * * (6) If at_end is false and is_collision is false, the delta_list entry fields refer to a From patchwork Fri Mar 1 04:26:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Sakai X-Patchwork-Id: 13577990 X-Patchwork-Delegate: snitzer@redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C539D47F73 for ; Fri, 1 Mar 2024 04:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; cv=none; b=XjCZMJXDU9xlYWtoR3xzp4tPI7o436Zj/dXTCukJYis8JVi5+BzZrFfqrVybdmyKZUynr1pHyx9wi5aGZQeyWBfwQHovoOBZst7hJIWQ7tHQPYHd5/rVmsZLZbPLr04yqcVRH90X9yKAuIdc9rJrlda3fkuXOEnr0nNNY3nmXMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267194; c=relaxed/simple; bh=tA2XtGRCxOadpkZnlVD2KjRwwSc3AP+DtSQvfHBbEtw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=B6ic6z/boCwqstjhS8LY6aozJ9XdDWTiw6H7ZZeIAJ/67yJQH8N35WWKJqhDN8igJREBG5hRP7onsEJSF8cV/AiUMewnyYkrL1jD5xZwPL/+ogY4d6jR+uwFa1bOAuj4Jh7m3Kf+D9SwnERFLfWq6/DRWw7VYbCwMi5R87QGrYs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IV+r5wEw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IV+r5wEw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709267191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IZ9lJymOn1ivSv/jTVm/qE8Z31HN9Y693I79hhU9YJ8=; b=IV+r5wEw/0IDPjNRqXvfnke4+zO5+3Ge1XwG1TAOU69xWRwdvJzvGSf2uangg9pAmGIVc0 ssW+s2iSIIV11w1x76h9StRVUM+RBxd42l+l1zbCO1gLFKWwTu6riMFG/U7KGbQVvOjSIr Dc6J2f1qV3uzhdsWVvh5l9VJKuKK7fc= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-TeKRbHHTPdqbX02Iy6opiA-1; Thu, 29 Feb 2024 23:26:30 -0500 X-MC-Unique: TeKRbHHTPdqbX02Iy6opiA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 18C223C0ED68 for ; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: from vdo-builder-msakai.permabit.com (vdo-builder-msakai.permabit.lab.eng.bos.redhat.com [10.0.103.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 125911C060B1; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: by vdo-builder-msakai.permabit.com (Postfix, from userid 1138) id 00BF2A15DD; Thu, 29 Feb 2024 23:26:29 -0500 (EST) From: Matthew Sakai To: dm-devel@lists.linux.dev Cc: Matthew Sakai Subject: [PATCH 10/11] dm vdo: update module comments Date: Thu, 29 Feb 2024 23:26:28 -0500 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Update outdated comments referring to separate VDO and UDS modules. Signed-off-by: Matthew Sakai --- drivers/md/dm-vdo/dm-vdo-target.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/md/dm-vdo/dm-vdo-target.c b/drivers/md/dm-vdo/dm-vdo-target.c index 0114fa4d48a2..429a285cbc4a 100644 --- a/drivers/md/dm-vdo/dm-vdo-target.c +++ b/drivers/md/dm-vdo/dm-vdo-target.c @@ -2907,9 +2907,7 @@ static int __init vdo_init(void) { int result = 0; - /* - * UDS module level initialization must be done first, as VDO initialization depends on it - */ + /* Memory tracking must be initialized first for accurate accounting. */ uds_memory_init(); uds_init_sysfs(); @@ -2917,7 +2915,7 @@ static int __init vdo_init(void) vdo_initialize_device_registry_once(); uds_log_info("loaded version %s", CURRENT_VERSION); - /* Add VDO errors to the already existing set of errors in UDS. */ + /* Add VDO errors to the set of errors registered by the indexer. */ result = vdo_register_status_codes(); if (result != UDS_SUCCESS) { uds_log_error("vdo_register_status_codes failed %d", result); @@ -2939,11 +2937,8 @@ static int __init vdo_init(void) static void __exit vdo_exit(void) { vdo_module_destroy(); - /* - * UDS module level exit processing must be done after all VDO module exit processing is - * complete. - */ uds_put_sysfs(); + /* Memory tracking cleanup must be done last. */ uds_memory_exit(); } From patchwork Fri Mar 1 04:26:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Sakai X-Patchwork-Id: 13577997 X-Patchwork-Delegate: snitzer@redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8803E50279 for ; Fri, 1 Mar 2024 04:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267201; cv=none; b=ahogvLDbg2tiUaj3lVbhImsDnbBaT1Ec+iBSMFTMRajE6Z7VXybqEBpIQP7eBJTUYvnpJvOlCphBeNWL2+4rthcuGz7/RYhwKK9Yg1DOOSHcrYlcoIHtcQImrA6RvHfkzdlhPq2bpDM9lwRReB48TipLCadNiWzJv7tDv7cfT6Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709267201; c=relaxed/simple; bh=kXeWTO9kl8V45zBW8h8LVitlA8bnuDKp85yiLAOUXV4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IyMT+LzuklP8cNWri01GIWboQyNBkVzcFgIIdBQiBCLYWqpsaN7/ov1AsyeTmbdPhWHennf38XLxT3BM46c1959H+WHWcSodTOA0Wb4ddtlPWCE3yg797cmk1zaAExWsHuRBgDPnQdWa897cx3giwv4qbmBrwI6j1Mv5PLzBpRc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KoqIVyfh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KoqIVyfh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709267198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OaAo6W6KRzKQfawWJPTLa2iK841UotbrwdOxJNY5s0Y=; b=KoqIVyfhVPo8Ycpg/s8IdHey1I51w2KZx9tch3z4XB6qnjwMacYvVQYQeJiUGQPBiMNB3m Zs13Ieeb4Wyr5jDeO1y5WmYGekyyRcTUcVPvhix2rDZHMt7WKVR21jEXQVKFyHnRx1QCKK HDeYSQbaS5kjXsjg3gt7E49aMIbp1pE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-VVBYmoNgMDyiGdYEC2TZCg-1; Thu, 29 Feb 2024 23:26:31 -0500 X-MC-Unique: VVBYmoNgMDyiGdYEC2TZCg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1663A832BCE for ; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: from vdo-builder-msakai.permabit.com (vdo-builder-msakai.permabit.lab.eng.bos.redhat.com [10.0.103.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 119DC10793; Fri, 1 Mar 2024 04:26:30 +0000 (UTC) Received: by vdo-builder-msakai.permabit.com (Postfix, from userid 1138) id 054EBA15DF; Thu, 29 Feb 2024 23:26:30 -0500 (EST) From: Matthew Sakai To: dm-devel@lists.linux.dev Cc: Matthew Sakai Subject: [PATCH 11/11] dm vdo: remove outdated pointer_map reference Date: Thu, 29 Feb 2024 23:26:29 -0500 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Signed-off-by: Matthew Sakai --- drivers/md/dm-vdo/vdo.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/md/dm-vdo/vdo.c b/drivers/md/dm-vdo/vdo.c index c161dffeb91a..d16404588881 100644 --- a/drivers/md/dm-vdo/vdo.c +++ b/drivers/md/dm-vdo/vdo.c @@ -67,10 +67,7 @@ struct sync_completion { struct completion completion; }; -/* - * We don't expect this set to ever get really large, so a linked list is adequate. We can use a - * pointer_map if we need to later. - */ +/* A linked list is adequate for the small number of entries we expect. */ struct device_registry { struct list_head links; /* TODO: Convert to rcu per kernel recommendation. */