From patchwork Mon Mar 4 21:28:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13581295 X-Patchwork-Delegate: cw00.choi@samsung.com Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E21D1200A9 for ; Mon, 4 Mar 2024 21:29:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587749; cv=none; b=ZsUx4RUQLBUPvi24lJJ3NLnsGphXwCyb6d9kPs79kc6CwC068JbggiFLIe/lxw5A7lV8v0SiyvJq/l+1ciWCPXlubKFolUXp/ejb6jIIrmczA25rYOUGTFZAAN30aWv2X5jfQOpYqPxeNte7Sk1M9c6QhBhrVFY8u6JpGosPzZY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587749; c=relaxed/simple; bh=0GTgiI9XNwKLwdfdM0l4i/fGODkeH75DZ0pc7W7YrQ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZHRAONrX4OMhpxo+17zBnEBR/cI7d27s50gUCdz84YcDAKrRoE7hkFIIFF8PlFNkO661eb4I3RRuWf7sMTo1i+pVUKiUIbdCzr8Q/4eO0blfhAHC+YXUKz8tgf9gn8JAgFdeJbRoeSJJWZc8tM5uXT2coAOTod0yaZiJ67GCUpo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhFrl-0002hb-4Q; Mon, 04 Mar 2024 22:28:57 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhFrk-004QhM-2A; Mon, 04 Mar 2024 22:28:56 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rhFrj-00H4uF-3A; Mon, 04 Mar 2024 22:28:55 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Chanwoo Choi , MyungJoo Ham , Kyungmin Park Cc: Krzysztof Kozlowski , Alim Akhtar , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 1/5] PM / devfreq: exynos-nocp: Convert to platform remove callback returning void Date: Mon, 4 Mar 2024 22:28:39 +0100 Message-ID: <8385454855ae5899a4db7655e7a57629855157d8.1709587301.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1674; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=0GTgiI9XNwKLwdfdM0l4i/fGODkeH75DZ0pc7W7YrQ8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl5j0IAzLtKlpzTiHhWfwGAM2RoJHs3l7fVAgvJ 3RuwWqj5UKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZeY9CAAKCRCPgPtYfRL+ TpoKB/93Yq8l627M/Q1v+xnPyLEA3as2YGI1ineGJcEWTWPQbYY031YgDzhZsGULV10dpNbF0xU LxsY1kSWt2tKBqxkq0JtjdYuBkc/2yc5DMx6uoRSFbsF5IvShjv4v8BRFqq647mVVJsAoFpo3gs E15REVIFsTsxvR8IK6md3OPDuq5yDTBSglXbL06zbbBMe4sEX7CWUQgP0ABWE8Mkjd0zHGiKu+f ew72rMZrvjtzyYhdO6XdYAdPpA9ll9IqZa+Mnrz1H38rg7xdp/NupLiozyTMVr1uoxhn4i6wdoi ajKGup2aDg/yzE4YI/Tsa55qhpqazRAkwsezFHOznnK0xJ0E X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/devfreq/event/exynos-nocp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c index c1cc23bcb995..5edc522f715c 100644 --- a/drivers/devfreq/event/exynos-nocp.c +++ b/drivers/devfreq/event/exynos-nocp.c @@ -275,18 +275,16 @@ static int exynos_nocp_probe(struct platform_device *pdev) return 0; } -static int exynos_nocp_remove(struct platform_device *pdev) +static void exynos_nocp_remove(struct platform_device *pdev) { struct exynos_nocp *nocp = platform_get_drvdata(pdev); clk_disable_unprepare(nocp->clk); - - return 0; } static struct platform_driver exynos_nocp_driver = { .probe = exynos_nocp_probe, - .remove = exynos_nocp_remove, + .remove_new = exynos_nocp_remove, .driver = { .name = "exynos-nocp", .of_match_table = exynos_nocp_id_match, From patchwork Mon Mar 4 21:28:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13581292 X-Patchwork-Delegate: cw00.choi@samsung.com Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E63F200CD for ; Mon, 4 Mar 2024 21:29:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587748; cv=none; b=ImvQWe4m7VdRujvlEERDf/VrM/3X49MAsYSVS5WebO9JaJxWWAwg7ErR9b99Yzw3Z1IY7dkZdtNiitOO5KvUnNChLH7ttnqcaD/0soKPI5JYDTy/SETFqPVrny7MKnd8lJgHdnhf5CrXFUfSY2VnJctv9QRn5inJbAjZiz8RUH8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587748; c=relaxed/simple; bh=WkAMU1jS5gkMcXbruT0u3SkkBeEdVbI821m1pxNR9Wc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O3zj+6Rg/OJB5tydtp9xgeUoBMon4n0iebR+xCym9NP7EPhQTx8zha4N35yiBxqgw5zDwHFEFf+/xJZFtdLP/NcuX0gqRRqcSVpfJ1+oWR7fRATysmOm4Bvb99rA5lnuwr+njVN63cAXZ1q6cNlkv5t9MW05HHeatfx2b/47zfo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhFrl-0002hc-4Q; Mon, 04 Mar 2024 22:28:57 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhFrk-004QhP-8m; Mon, 04 Mar 2024 22:28:56 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rhFrk-00H4uJ-0a; Mon, 04 Mar 2024 22:28:56 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Chanwoo Choi , MyungJoo Ham , Kyungmin Park Cc: Krzysztof Kozlowski , Alim Akhtar , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 2/5] PM / devfreq: exynos-ppmu: Convert to platform remove callback returning void Date: Mon, 4 Mar 2024 22:28:40 +0100 Message-ID: <028822439693e7d6a74f33385a3f634bdd7143dd.1709587301.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1679; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=WkAMU1jS5gkMcXbruT0u3SkkBeEdVbI821m1pxNR9Wc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl5j0Jb0TQlki/z6X9KXH7N4rgac6Lp9lbuNz7h gP4vNA6OdGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZeY9CQAKCRCPgPtYfRL+ TqTrB/wIv8LL0R1fUF2/7b5G90138vYJMxUul0GE2smFvfiKra8cp1Xn8D02oQ7FM5eUOH4Ie09 reB94nWjr04NeYD0rFQqYOzhA9Fdawt5QTumuVVW1US2C35npQziC6GN18RLKRjJPJJfRblmJtE ucMb26BdgJrTguBbD+PwzEt8ZmVLZkIZlJ5S8xn2Dyb4eJadbp2bxxoWW4jQwI/AOWxYl5GR+/4 PO1jJ7U4lySywt/EhhGDrtAf163QHJtM07Vgd95zOoqy+ecFdzqxSyR+BJgzWvZOITTjCgP0Hrr hjCwK0Crq06txUdyHo4eRIbROwoJDCidajzEf3I4sQnahtwo X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/devfreq/event/exynos-ppmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c index 56bac4702006..7002df20a49e 100644 --- a/drivers/devfreq/event/exynos-ppmu.c +++ b/drivers/devfreq/event/exynos-ppmu.c @@ -692,18 +692,16 @@ static int exynos_ppmu_probe(struct platform_device *pdev) return 0; } -static int exynos_ppmu_remove(struct platform_device *pdev) +static void exynos_ppmu_remove(struct platform_device *pdev) { struct exynos_ppmu *info = platform_get_drvdata(pdev); clk_disable_unprepare(info->ppmu.clk); - - return 0; } static struct platform_driver exynos_ppmu_driver = { .probe = exynos_ppmu_probe, - .remove = exynos_ppmu_remove, + .remove_new = exynos_ppmu_remove, .driver = { .name = "exynos-ppmu", .of_match_table = exynos_ppmu_id_match, From patchwork Mon Mar 4 21:28:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13581293 X-Patchwork-Delegate: cw00.choi@samsung.com Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E22142C689 for ; Mon, 4 Mar 2024 21:29:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587748; cv=none; b=WJFtoK+clnvkB4MQjSbV21r/PuG7X8Fa3ArxNVUJuVqjnTCo2j+TtLxwigZZyNofuyTFgQ8RvT5w5R/2+TXscLjUgCYSn5Izy2zAlbgwwRT5s39GWlYN5CLGaXNXN8XMpaKWSLXKUM6Tgxg2br8n0QAY0gI08kOsPXvEYvwkbW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587748; c=relaxed/simple; bh=R9sXnYv3VfRGcrZ5/KZOGdZaFSWQmEEW5PecCI0UwYU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZKi4zOgkxygtyomryVc9Zg3lI2NQE7w2lYoAhQb0CXj+PzGUiZTJyoXemPElcsWt636e1yJOvabDiH7rEnp98hxRdiDL0n6fqrmgC4LIK1KgCaKUidnHDW9Vi+o1GF7iwjo3yF1/e0C/GmoQSMupNP/Qq/4fUo9rw/f2tYnvLmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhFrl-0002hd-8k; Mon, 04 Mar 2024 22:28:57 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhFrk-004QhS-GL; Mon, 04 Mar 2024 22:28:56 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rhFrk-00H4uN-1L; Mon, 04 Mar 2024 22:28:56 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: MyungJoo Ham , Kyungmin Park , Chanwoo Choi Cc: Matthias Brugger , AngeloGioacchino Del Regno , linux-pm@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH 3/5] PM / devfreq: mtk-cci: Convert to platform remove callback returning void Date: Mon, 4 Mar 2024 22:28:41 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1957; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=R9sXnYv3VfRGcrZ5/KZOGdZaFSWQmEEW5PecCI0UwYU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl5j0KB0prRkwFiMOZlnfNuNGvP6+/rMnxv/n7N Rmyl6mVSe6JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZeY9CgAKCRCPgPtYfRL+ TjNaB/9VL/XniiKx+uwHc1n1ORgvJTG3GMwQkthaAmp6NBA7F9+JeNaXgtRvl59DQZC8L7KrFyz P5xxfmwd9/SrqLwyOjlYWVp7VTiWVwIUil+TSfKbclPOoJtue895UU9sTr9MzG8H5WXFmEflXxU Q1uQCZ/tsrq9oiJW8wlESgE5ftBzjo37qa5yFSCqC/Oj2TIN+m4xGUJlLmpnzvops+1CpFfdsck IWWx+YFUUDtp0jJf/In7RhQMkwXbTLWppXoUfY4JWifAMEBHYKyfA0F7euWxvPJh5Prk2ZCK5nQ Ionn2GSnLV5jqXltxa6FI2/q72Zc/IDm7wIUSVt2oaG8ZucS X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/devfreq/mtk-cci-devfreq.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/devfreq/mtk-cci-devfreq.c b/drivers/devfreq/mtk-cci-devfreq.c index 11bc3d03494c..7ad5225b0381 100644 --- a/drivers/devfreq/mtk-cci-devfreq.c +++ b/drivers/devfreq/mtk-cci-devfreq.c @@ -392,7 +392,7 @@ static int mtk_ccifreq_probe(struct platform_device *pdev) return ret; } -static int mtk_ccifreq_remove(struct platform_device *pdev) +static void mtk_ccifreq_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct mtk_ccifreq_drv *drv; @@ -405,8 +405,6 @@ static int mtk_ccifreq_remove(struct platform_device *pdev) regulator_disable(drv->proc_reg); if (drv->sram_reg) regulator_disable(drv->sram_reg); - - return 0; } static const struct mtk_ccifreq_platform_data mt8183_platform_data = { @@ -432,7 +430,7 @@ MODULE_DEVICE_TABLE(of, mtk_ccifreq_machines); static struct platform_driver mtk_ccifreq_platdrv = { .probe = mtk_ccifreq_probe, - .remove = mtk_ccifreq_remove, + .remove_new = mtk_ccifreq_remove, .driver = { .name = "mtk-ccifreq", .of_match_table = mtk_ccifreq_machines, From patchwork Mon Mar 4 21:28:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13581291 X-Patchwork-Delegate: cw00.choi@samsung.com Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1299610A1F for ; Mon, 4 Mar 2024 21:29:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587747; cv=none; b=gIFeEGkIIfoHb4vguu8csvZFmdN4xMC1AoSh26G1CKan8tv3lC03BwQL3ZBnpFHC9erAfga9ZYraVkr3S0lPLD3qcn/u/YM63OPiZSLDOvNMeB+ANq5dtMCjyfifaECGHC2xrPwNlgfE6x30YiI3V1XCbZL9fft/FpZq/EbZ0Sk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587747; c=relaxed/simple; bh=6CAzFt3bd4MLuvqqWDKQBJQf14/nfYSjEqdN94WNtZw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=isdksGhBM2h1oyvNEUXxc1i6oyGsHGWgLxK/WXctqyRJwwkLJ8whZTDq8fnNV5zHYlCOGnaHwT24Qw04c6SR7HSGAmzxzG13RFAnEl2hvzhNMHAFYsGlLa6L5hD+QI0Y0H3DeYNVJQ1CAtQdpb/x86dtyajqKV3X7E4BvL5PHHU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhFrl-0002he-4I; Mon, 04 Mar 2024 22:28:57 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhFrk-004QhV-Ni; Mon, 04 Mar 2024 22:28:56 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rhFrk-00H4uR-26; Mon, 04 Mar 2024 22:28:56 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: MyungJoo Ham , Kyungmin Park , Chanwoo Choi Cc: linux-pm@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 4/5] PM / devfreq: rk3399_dmc: Convert to platform remove callback returning void Date: Mon, 4 Mar 2024 22:28:42 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1813; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=6CAzFt3bd4MLuvqqWDKQBJQf14/nfYSjEqdN94WNtZw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl5j0MxSdzyfEutO18odO0QQ6S9wEZk/C2ahR4o TIdt9QPTROJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZeY9DAAKCRCPgPtYfRL+ TspzB/46m4CTpbS5esetYFAy7BV6n5oAucyWXewdLq9ubthm8n3zsFhSXS7IhXsMrrB6jSzqY6g 8vix1AXz4nLEGIe6WsmWQNo/QtvFMl9iQ/gbz6klDs0w+KP8u1jgMjGlKnRrwxsGsmPnrJ76wf7 AfQU7aRJA0mRRDekCCEnez+y31gOyQZWRy65iRiH430DlwR+O4M4fu8/ELrzMeCutMDCwSW472p gi27vLj7IPfSPW5Pf/xty++KSsrr/Lmefpo24TeGNf0sj5/Of7Fr0iZ+iph4Tv8cPEx/BVsDl2P S1v12NC4IKOrg/P/qWOGVZtNoQbB22+gBheCZQR9rMG5Gyys X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/devfreq/rk3399_dmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index fd2c5ffedf41..d405cee92c25 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -459,13 +459,11 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) return ret; } -static int rk3399_dmcfreq_remove(struct platform_device *pdev) +static void rk3399_dmcfreq_remove(struct platform_device *pdev) { struct rk3399_dmcfreq *dmcfreq = dev_get_drvdata(&pdev->dev); devfreq_event_disable_edev(dmcfreq->edev); - - return 0; } static const struct of_device_id rk3399dmc_devfreq_of_match[] = { @@ -476,7 +474,7 @@ MODULE_DEVICE_TABLE(of, rk3399dmc_devfreq_of_match); static struct platform_driver rk3399_dmcfreq_driver = { .probe = rk3399_dmcfreq_probe, - .remove = rk3399_dmcfreq_remove, + .remove_new = rk3399_dmcfreq_remove, .driver = { .name = "rk3399-dmc-freq", .pm = &rk3399_dmcfreq_pm, From patchwork Mon Mar 4 21:28:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13581294 X-Patchwork-Delegate: cw00.choi@samsung.com Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 748A4482DA for ; Mon, 4 Mar 2024 21:29:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587748; cv=none; b=TajP8UzkGii6qUZF5mff3Z4si/Kh5+1nrfgicXsjBVopKZp+yJH0S9sWdh2if6tmMMWx9bEDDVZRKgn33R2aW3NnThjwnHptH1JyX/lX9V6LvYfV8TD9xOJQpk7rVm14EaHSZmm3uJ3CIxXEM/yt5+QDQElFyTJ2KiF12gfW9uE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587748; c=relaxed/simple; bh=PBrEihezR5AA0ClQxijXvIVfy7IrlYrl4T4cYnc+AtQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pZ8dwBgxvGOh3l0s/x/SExCPXrjXUwRqlZZ1dB5ANScF7Ggv7FYQCkJV1zRYI6kRff0RQ0Fe6AnmwIhyZ40BpjijSN4HMxfO1BzfilXnOmltCNmheUU1r5AgKP4kbX2Y/owLtMtR8cSabVLpJVQvanGCbRmhmCSLiR6Bf5lf8gc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhFrm-0002hx-4i; Mon, 04 Mar 2024 22:28:58 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhFrk-004QhY-W6; Mon, 04 Mar 2024 22:28:57 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rhFrk-00H4uV-2u; Mon, 04 Mar 2024 22:28:56 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: MyungJoo Ham , Kyungmin Park , Chanwoo Choi Cc: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: [PATCH 5/5] PM / devfreq: sun8i-a33-mbus: Convert to platform remove callback returning void Date: Mon, 4 Mar 2024 22:28:43 +0100 Message-ID: <0ca3f35bdf9549ccda7c6c10a476f28350d987df.1709587301.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2083; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=PBrEihezR5AA0ClQxijXvIVfy7IrlYrl4T4cYnc+AtQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl5j0Nd/4vLbyJrlXlBYNLAsGnaqFmZKtQd7jX+ srJRfHCOFqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZeY9DQAKCRCPgPtYfRL+ TlM6CACbzzNWmx8B9+BCzK0no3gbBhtyaxUgC5dVdB5//xc7v2zhLurgFAbxXxysS/W3uJaFJ20 uDPXWRhb0pck20FRdiFPTu2laILpgow/u97a76d8Qch1dZUeLLgG3X61Y59PhP67Yb2eizO/92M vsV2a7bGLIK7g6+HXU0DhLbRYjemnmX2Wem8Ob6e1MXcVW05E25E3b7mvC8CHjlkIrduImVWYth X9ic/6CeF/54+KUL2LYdSLYH0UV3nPNpHBEwjMZhfdz/r0hkoOW29227mwb3GBTOM4O0vBC9pfT E73seSaecZz8dKy5CFKqs8hwHHseEra4F4MYorwHXI/o6j7D X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Jernej Skrabec --- drivers/devfreq/sun8i-a33-mbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/devfreq/sun8i-a33-mbus.c b/drivers/devfreq/sun8i-a33-mbus.c index 13d32213139f..bcf654f4ff96 100644 --- a/drivers/devfreq/sun8i-a33-mbus.c +++ b/drivers/devfreq/sun8i-a33-mbus.c @@ -458,7 +458,7 @@ static int sun8i_a33_mbus_probe(struct platform_device *pdev) return dev_err_probe(dev, ret, err); } -static int sun8i_a33_mbus_remove(struct platform_device *pdev) +static void sun8i_a33_mbus_remove(struct platform_device *pdev) { struct sun8i_a33_mbus *priv = platform_get_drvdata(pdev); unsigned long initial_freq = priv->profile.initial_freq; @@ -475,8 +475,6 @@ static int sun8i_a33_mbus_remove(struct platform_device *pdev) clk_rate_exclusive_put(priv->clk_mbus); clk_rate_exclusive_put(priv->clk_dram); clk_disable_unprepare(priv->clk_bus); - - return 0; } static const struct sun8i_a33_mbus_variant sun50i_a64_mbus = { @@ -497,7 +495,7 @@ static SIMPLE_DEV_PM_OPS(sun8i_a33_mbus_pm_ops, static struct platform_driver sun8i_a33_mbus_driver = { .probe = sun8i_a33_mbus_probe, - .remove = sun8i_a33_mbus_remove, + .remove_new = sun8i_a33_mbus_remove, .driver = { .name = "sun8i-a33-mbus", .of_match_table = sun8i_a33_mbus_of_match,