From patchwork Tue Mar 5 16:27:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13582706 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B88D4C54798 for ; Tue, 5 Mar 2024 16:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xCzHqSsHQgn21pw1Ky3GWxloNuOPh/oC+hGVf7qQXgk=; b=EJul36feAnczXd 8LTrv/6YScptfAXD8EIctVNHYzlywjtjrmk1Ae001zNkmrzraeSF0Px/5a1LvxOkga3CT14SjsQdy mApJF36GFFC1lKG/f5hqLZutsiI/j19VPWo/A4E+ahKUVu61+UgYUL2Rmifh6gfs2FEBZ2b6FYQCF i5+THyWKahOnXyjRzpFQzzv7kBHpIrY1clkLMPl+kjZloXqiDf24CHW7UmwuW4Ilt5Uhjh1n33G/r JQ/RRMvLr+5aEIruXcnuapY1gWyAOfuRKRhUhrVAM9MZJxVHItEqa5fWd1YeEimXp0BFZ5iboRkQS eps4hGsCo2SNlNPRMIaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhXdz-0000000ETlD-0fLD; Tue, 05 Mar 2024 16:27:55 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhXdv-0000000ETic-0IVb for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2024 16:27:53 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhXde-0003Tc-DX; Tue, 05 Mar 2024 17:27:34 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhXdc-004aQM-4U; Tue, 05 Mar 2024 17:27:32 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rhXdc-000BLn-0A; Tue, 05 Mar 2024 17:27:32 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Corey Minyard , Joel Stanley Cc: Andrew Jeffery , openipmi-developer@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, kernel@pengutronix.de Subject: [PATCH 5/6] ipmi: kcs_bmc_aspeed: Convert to platform remove callback returning void Date: Tue, 5 Mar 2024 17:27:02 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1952; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=cQSTkvN0Jy5VD1YUAtbSWuP1fWTL3JuKHCTDHuLZJJg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl50fXPuLKdTXmE+BXOgA9dIA30b5KFjtiIciDx b+i5br1uiSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZedH1wAKCRCPgPtYfRL+ Ts6bB/9txuPhZrGm/DMvNwP0Qx1oMm+pFrBAHixgtqY+mImxKJZ+IlyxuFi6OXvc0bnE9Y4aj1I C0dGPLQKsyemV7eL9A5P9bEdaTYGGNSd8NXp+RM3XtwOEo5nlqlPAM8LO3nnJIbiwbtFF4sxCcB gw7wD4fORaKLivqujGWHShxZJQOtT0AiqPwd9M4SNbsmKfdGF0d5SIgrVTCmKci5exR0OqWe6f7 OUyL9Eya0lk5ZrTZ/GsbMA6stjeCr3iEoUa9A0bLTddKQb7sXy9RQb6LFfNvLTJAwn83RefooK7 wt4ro9o5G8d5sbCdH04Tds5EkI/ncAymD+MKMpXMdcirftg1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240305_082751_133430_E9532C43 X-CRM114-Status: GOOD ( 15.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Andrew Jeffery --- drivers/char/ipmi/kcs_bmc_aspeed.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c index 72640da55380..227bf06c7ca4 100644 --- a/drivers/char/ipmi/kcs_bmc_aspeed.c +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c @@ -641,7 +641,7 @@ static int aspeed_kcs_probe(struct platform_device *pdev) return 0; } -static int aspeed_kcs_remove(struct platform_device *pdev) +static void aspeed_kcs_remove(struct platform_device *pdev) { struct aspeed_kcs_bmc *priv = platform_get_drvdata(pdev); struct kcs_bmc_device *kcs_bmc = &priv->kcs_bmc; @@ -656,8 +656,6 @@ static int aspeed_kcs_remove(struct platform_device *pdev) priv->obe.remove = true; spin_unlock_irq(&priv->obe.lock); del_timer_sync(&priv->obe.timer); - - return 0; } static const struct of_device_id ast_kcs_bmc_match[] = { @@ -674,7 +672,7 @@ static struct platform_driver ast_kcs_bmc_driver = { .of_match_table = ast_kcs_bmc_match, }, .probe = aspeed_kcs_probe, - .remove = aspeed_kcs_remove, + .remove_new = aspeed_kcs_remove, }; module_platform_driver(ast_kcs_bmc_driver);