From patchwork Thu Mar 7 16:07:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13585995 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0137C54E49 for ; Thu, 7 Mar 2024 16:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nU442OnB8Zrxxj+hP0kH5zq6W+q401U/MGatNOtRYuE=; b=rr7PvDKwflg8BY 5RBHr7VtkVXInin9Nc5/w6CwRot0Gv8DN33RaMkUcBBmeukBZh5Ky3s8/nWG/lksh7I7RvecUPepy LyivtrfiDhTUclvIBtHHPGlsmCKgn9ka267nvXN5EhMn6aYb6gOCoapiHf1wlK9PP6WbJem2/SIhK jSHdtO9YT/T2qWPBXg8fDsyDIrHbz0AMYAkWkF0RSoHzUP9pkastfRa1mQQKogak6MLBnSDaF/wBS 6OOPxiMFqktCtxB7HA9/KS9UAidbRlnVLVE04lkwg/tn5njP49BXkKpQ8Ihejfilq5wt39NgyExLf JiBQduWaw5yjHcnaGjbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riGIZ-00000005Psf-1JBx; Thu, 07 Mar 2024 16:08:47 +0000 Received: from mgamail.intel.com ([192.198.163.9]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riGIV-00000005Pr7-1oiU for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2024 16:08:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709827723; x=1741363723; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=b54sMnveccHBtra98fGbKYy1sRxG2doqPjrqZUCNqmE=; b=nozKRrfOXZ1oQhdOkaGpGaucKp4GQqaSzuPmaxTpjqR+8nnk+0zRzpSh 4Nn1acWG70lW9oUnGWzLj3RAyFd+secjYOXAhA2K5/N2jhqAhQoc7votd ZZwSpR2sWMkdtLvfTiHrK2pLkZvkN5NNTs+jO/sTdp/j044/UlBxOTL7V LiB2YM5qhIQ5gdqCBw+nMgRIZOd2bx03GP7RKIsXta+C3sSQym1atCTy0 Lx8Ei/+LbVg96+Byl07Efxr6X6QP5NTfomusjCsFZu94LC/UwYfkUisml H45MTvRJlG7gwqgECddNXijF9F+YgiqHwvCkhxnPkfS1PVwG5WJuSoNSd Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="15227311" X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="15227311" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 08:08:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="937046346" X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="937046346" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 07 Mar 2024 08:08:25 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 73696193; Thu, 7 Mar 2024 18:08:24 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Mark Brown Subject: [PATCH v1 1/2] spi: pxa2xx: Kill pxa2xx_set_spi_info() Date: Thu, 7 Mar 2024 18:07:38 +0200 Message-ID: <20240307160823.3800932-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240307160823.3800932-1-andriy.shevchenko@linux.intel.com> References: <20240307160823.3800932-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_080843_697647_C71FDD70 X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is the only one user of the pxa2xx_set_spi_info(). Unexport it and inline to the actual user. Signed-off-by: Andy Shevchenko --- arch/arm/mach-pxa/devices.c | 18 ------------------ arch/arm/mach-pxa/spitz.c | 13 ++++++++++++- include/linux/spi/pxa2xx_spi.h | 8 -------- 3 files changed, 12 insertions(+), 27 deletions(-) diff --git a/arch/arm/mach-pxa/devices.c b/arch/arm/mach-pxa/devices.c index 661b3fc43275..1e4cd502340e 100644 --- a/arch/arm/mach-pxa/devices.c +++ b/arch/arm/mach-pxa/devices.c @@ -7,7 +7,6 @@ #include #include #include -#include #include #include @@ -665,23 +664,6 @@ struct platform_device pxa27x_device_gpio = { .resource = pxa_resource_gpio, }; -/* pxa2xx-spi platform-device ID equals respective SSP platform-device ID + 1. - * See comment in arch/arm/mach-pxa/ssp.c::ssp_probe() */ -void __init pxa2xx_set_spi_info(unsigned id, struct pxa2xx_spi_controller *info) -{ - struct platform_device *pd; - - pd = platform_device_alloc("pxa2xx-spi", id); - if (pd == NULL) { - printk(KERN_ERR "pxa2xx-spi: failed to allocate device id %d\n", - id); - return; - } - - pd->dev.platform_data = info; - platform_device_add(pd); -} - static struct resource pxa_dma_resource[] = { [0] = { .start = 0x40000000, diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c index cc691b199429..70e4623907fa 100644 --- a/arch/arm/mach-pxa/spitz.c +++ b/arch/arm/mach-pxa/spitz.c @@ -585,6 +585,9 @@ static struct gpiod_lookup_table spitz_spi_gpio_table = { static void __init spitz_spi_init(void) { + struct platform_device *pd; + int id = 2; + if (machine_is_akita()) gpiod_add_lookup_table(&akita_lcdcon_gpio_table); else @@ -592,7 +595,15 @@ static void __init spitz_spi_init(void) gpiod_add_lookup_table(&spitz_ads7846_gpio_table); gpiod_add_lookup_table(&spitz_spi_gpio_table); - pxa2xx_set_spi_info(2, &spitz_spi_info); + + pd = platform_device_alloc("pxa2xx-spi", id); + if (pd == NULL) { + pr_err("pxa2xx-spi: failed to allocate device id %d\n", id); + } else { + pd->dev.platform_data = info; + platform_device_add(pd); + } + spi_register_board_info(ARRAY_AND_SIZE(spitz_spi_devices)); } #else diff --git a/include/linux/spi/pxa2xx_spi.h b/include/linux/spi/pxa2xx_spi.h index ca2cd4e30ead..56aba2f737b1 100644 --- a/include/linux/spi/pxa2xx_spi.h +++ b/include/linux/spi/pxa2xx_spi.h @@ -45,12 +45,4 @@ struct pxa2xx_spi_chip { u32 timeout; }; -#if defined(CONFIG_ARCH_PXA) || defined(CONFIG_ARCH_MMP) - -#include - -extern void pxa2xx_set_spi_info(unsigned id, struct pxa2xx_spi_controller *info); - -#endif - #endif /* __LINUX_SPI_PXA2XX_SPI_H */ From patchwork Thu Mar 7 16:07:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13585994 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C422C54798 for ; Thu, 7 Mar 2024 16:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0ipjifzV/RV4qkKixLP2xAyMY7eqXQS20r9F12r72yQ=; b=UeULmentTm/kLm JJjqRTr7Hdi05LsDhRKFSyqd7vL+LWS8j7YoXVFgcLFolrZ3DHdE+4aJ2/sGVhWlxi/QUUgRRpHGg NZJn7Nu7RmZmXop21lRwHRtTUitpXk95wGN0xEAYlKO2PHodifoTzOTsLNVGHqvdAxGVsSgJ/9xFC tM3kmRFNeBu+CtVDdFwZ+4617IKQKSWfD7NCJdTGANwWDMfHkH/detYMZ2lCpw1dsXQC2TkUUQymO 6L3Tw1zFEtcz+sOcswiiJ8HIE8zO2X05ttPKDu3xFXF/ItBF4/mw3qwPjlvZBTkSFo/1QCSWqYwc+ WfRUDULqbvIpj4YMmG2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riGIe-00000005Pu0-1HvU; Thu, 07 Mar 2024 16:08:52 +0000 Received: from mgamail.intel.com ([192.198.163.9]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riGIW-00000005Pqn-2yfG for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2024 16:08:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709827725; x=1741363725; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=F1OHiv4WucxkGAgCSYrb8qP+gH5ZMgabEBIad4Z4yrg=; b=LKAlxvR6JgA9lyy0h0ypp70uPjM+fssM3j4FOSAF/eaQHQ5ap1mOdSnG ZSW40WSdzYCWxPB5ctHQH2UVTY+PuoESmm0C7rqgbXxQ+UilFLzr7Pt8S XIdrhoKmiutGZEe/vldh5zsqz4mATpa6/JCR6IFXCzPg1Lh8wXQbNgNIO cB6qq/wzM+DgtCO6jgdaRqFmtf06gEaSL8aLNVj8ONl5OgnkrQ1ycwKvl TWmRHqrINmEeFhV6GT+enURuyTUA/XOoAplAt/CerAn20mWIc5+668GLm phYnyZjoPRxp9pZT0cMXsInJ6pBK0yL7/aWSrBFi1i9h89E4ENzbJOsQS w==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="15227303" X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="15227303" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 08:08:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="937046345" X-IronPort-AV: E=Sophos;i="6.07,211,1708416000"; d="scan'208";a="937046345" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 07 Mar 2024 08:08:25 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 797B83F1; Thu, 7 Mar 2024 18:08:24 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Mark Brown Subject: [PATCH v1 2/2] spi: pxa2xx: Make num_chipselect 8-bit in the struct pxa2xx_spi_controller Date: Thu, 7 Mar 2024 18:07:39 +0200 Message-ID: <20240307160823.3800932-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240307160823.3800932-1-andriy.shevchenko@linux.intel.com> References: <20240307160823.3800932-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_080844_819085_C42E4647 X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is no use for whole 16-bit for the number of chip select pins. Drop it to 8 bits. Signed-off-by: Andy Shevchenko Acked-by: Arnd Bergmann --- include/linux/spi/pxa2xx_spi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/spi/pxa2xx_spi.h b/include/linux/spi/pxa2xx_spi.h index 56aba2f737b1..e5a4a045fb67 100644 --- a/include/linux/spi/pxa2xx_spi.h +++ b/include/linux/spi/pxa2xx_spi.h @@ -17,7 +17,7 @@ struct dma_chan; * (resides in device.platform_data). */ struct pxa2xx_spi_controller { - u16 num_chipselect; + u8 num_chipselect; u8 enable_dma; u8 dma_burst_size; bool is_target;