From patchwork Fri Mar 8 16:27:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13587058 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6060C54E4A for ; Fri, 8 Mar 2024 16:29:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eh3J29xtdX+vcxPkfxaZ+VcknAq1TcGAUXaU8EVSTbo=; b=FThXXXi9OxFumt 6EVdyAbqoTWS39SezAsxO0x5B5kGPMlv/fq1pIhIN+ABMpae4bfR0qAN8M1UR2QFNoV+IPDQyPRAD BKeGKqZ2K3efjph6IlaO5ONAJW+1C/AxnICsZDaGXvKWK6GW8JHsWiUx6jK6HUy2A6DBaIHJHT4R+ iiRCyNzpUkUxU7HuX5fIBfsfVF5/WvmBT7YbSPFC2OysJ4fTq4n7DnChQTOpzs5eebMD3Wt+u90VI eS4IJOLMaRDI62R/OtRKQqSD6/WDUsom4Pi8kol8MIb/FHL4S0E6pFUeuOYNKoJ+cu4tDHwbElLvd C/8BuEwS9qFxXEO2PeSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rid6F-0000000ABOA-3ABU; Fri, 08 Mar 2024 16:29:35 +0000 Received: from mgamail.intel.com ([192.198.163.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rid6A-0000000ABL9-3gjT for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 16:29:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709915371; x=1741451371; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fIeQk5Wp5I84wTiwz4DvoHCEPwiTAvPIYfShGQ0P904=; b=RAuATo9YtCVYV4cmukEtmV3LLfl/3YPpmbMOVCsg6O0Q/97X7l/vULQU tjPdPviI+NDkv9TxpcGvEo9Ju9XFCdbMwreaS8KpQof3+quLh53+comlv Dpilkv15STQbq++2o8AG/mZT5EIulRPKRR6n0zIghiiY19PagmhNbk32b 858eZFQ0PonIrFJeDv4Q1Y1321+D17JsxFsGy/C/tFwFlrNQZAm9pcQPx gjS5t9UA/FZmMjY0/qCMZA+molIlRscoZFDaVIb/ZjmP9YYCRZW2OIev+ BRreFUq4zAsF/ccUHrFSrHfmJbcCA953fTDzCnIJLqRQsSS43PeVn4HIb Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11007"; a="4806758" X-IronPort-AV: E=Sophos;i="6.07,110,1708416000"; d="scan'208";a="4806758" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 08:29:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11007"; a="937047684" X-IronPort-AV: E=Sophos;i="6.07,110,1708416000"; d="scan'208";a="937047684" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 08 Mar 2024 08:29:26 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id AE67C86; Fri, 8 Mar 2024 18:29:25 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Mark Brown , Michal Simek Subject: [PATCH v2 1/3] spi: xilinx: Fix kernel documentation in the xilinx_spi.h Date: Fri, 8 Mar 2024 18:27:46 +0200 Message-ID: <20240308162920.46816-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240308162920.46816-1-andriy.shevchenko@linux.intel.com> References: <20240308162920.46816-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_082930_965616_191037B4 X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org While updating the data structure layout the kernel documentation became outdated. Synchronize kernel documentation with the actual data structure layout. Fixes: 1dd46599f83a ("spi: xilinx: add force_irq for QSPI mode") Fixes: 082339bc63cc ("spi: spi-xilinx: Add run run-time endian detection") Reviewed-by: Michal Simek Signed-off-by: Andy Shevchenko --- include/linux/spi/xilinx_spi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h index 3934ce789d87..fd6add419e94 100644 --- a/include/linux/spi/xilinx_spi.h +++ b/include/linux/spi/xilinx_spi.h @@ -5,10 +5,10 @@ /** * struct xspi_platform_data - Platform data of the Xilinx SPI driver * @num_chipselect: Number of chip select by the IP. - * @little_endian: If registers should be accessed little endian or not. * @bits_per_word: Number of bits per word. * @devices: Devices to add when the driver is probed. * @num_devices: Number of devices in the devices array. + * @force_irq: If set, forces QSPI transaction requirements. */ struct xspi_platform_data { u16 num_chipselect; From patchwork Fri Mar 8 16:27:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13587057 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29953C54E58 for ; Fri, 8 Mar 2024 16:29:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LCK7DDu5RfwoD7ZxtufRu6ST0gl3XbOqYWCQ1GGm3Ko=; b=zzYmTOkFQ3WZyp nCenZxfSeUZxf5D+uEqGCm2nIqp3J0L2KKgBlfKD1BY/ci1JRyWPokcVehaOR1u4HBfv0arj8WS/k Tc8ZA4fKF7ZkaP/96/VltCRuTHA00uemdX8a8XL64LGd2vVGCFSetPkQYFPyEcQ1mVRScwHSxYQ4E jpcBVmDlXXi7+T2bsngaNlUZ0VAppBcLUB7HU3jAn8sglDc2wkx7oUGfsBhCblqN+yrWujAxiYo7I 6OwEcrn/u0BeyeP7BuaTzLVAzYn5vX74PbHz6wWkpJf8woRIxVEWAg6lmjqAKiuvPjkdEn3x+MmDG Xq/n9lCzySt+2K7rQuCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rid6G-0000000ABOq-2YZg; Fri, 08 Mar 2024 16:29:36 +0000 Received: from mgamail.intel.com ([192.198.163.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rid6C-0000000ABJr-0V3m for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 16:29:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709915372; x=1741451372; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XXvje3DsPXFomNyXuJGV+9j2nWWkci2XhBpIRqsHwDM=; b=P2UQZDkWDwC4bVAEhHdoV52rCb+jP7B6x7v0xMi79KQ4g/oua+jvbbaE Gt5bKKMC7DNOLRhyguXHrY0LaSnkS0/d2yJ8t6WUu8zySvNnGrr4YZTVL k44u6+u8/YSLS/+iK3R20DyXqNruovl3Ve6NBsIEkiTrC/cljzw6EdFMk OEeDTh14tUde4UUWJZR3f7CL35vfEztxbIfVi5m0F/Bm+euJ+UM+AcP0j M0mwn6uTHHTwJpBTvIKk8NBDbCQj5J3Ygh/laElYXiFsjy5d0ce93qpuC vb3ET8l+HMiSRZBp1MMmvAIXCOdpfXPnSItQWaaStNjSqFTOgbZHzdFb4 A==; X-IronPort-AV: E=McAfee;i="6600,9927,11007"; a="4806762" X-IronPort-AV: E=Sophos;i="6.07,110,1708416000"; d="scan'208";a="4806762" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 08:29:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11007"; a="937047685" X-IronPort-AV: E=Sophos;i="6.07,110,1708416000"; d="scan'208";a="937047685" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 08 Mar 2024 08:29:26 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id B631921A; Fri, 8 Mar 2024 18:29:25 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Mark Brown , Michal Simek Subject: [PATCH v2 2/3] spi: xilinx: Add necessary inclusion and forward declaration Date: Fri, 8 Mar 2024 18:27:47 +0200 Message-ID: <20240308162920.46816-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240308162920.46816-1-andriy.shevchenko@linux.intel.com> References: <20240308162920.46816-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_082932_315757_3E98CD0D X-CRM114-Status: GOOD ( 10.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org xilinx_spi.h is mnissing inclusion and forward declaration, add them. Signed-off-by: Andy Shevchenko Acked-by: Michal Simek --- include/linux/spi/xilinx_spi.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h index fd6add419e94..4ba8f53ce570 100644 --- a/include/linux/spi/xilinx_spi.h +++ b/include/linux/spi/xilinx_spi.h @@ -2,6 +2,10 @@ #ifndef __LINUX_SPI_XILINX_SPI_H #define __LINUX_SPI_XILINX_SPI_H +#include + +struct spi_board_info; + /** * struct xspi_platform_data - Platform data of the Xilinx SPI driver * @num_chipselect: Number of chip select by the IP. From patchwork Fri Mar 8 16:27:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13587055 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73E44C54E4A for ; Fri, 8 Mar 2024 16:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0iymJfUz1jrX7AYphXv8WiUB2dEJS8dyjUmCMor/wGY=; b=3pLCenU3l0+tKw SUhiSCnzyGGx+u970X9BBi6Wd1TaLNMLfUyj6ch+AOwLkeaFSTOx4LzUgj1Jmm2sxy/eksGk1LFqz c0qi6VnqGB555DawGhm+bStmL7SxhAsjtwcD44Rwm4G5GIQ8LU4WTNvufyz6TT/88/sKdfrCB0FfU ssYFr89jOgEJHIlWeTQYjsM6ZDmiyVIDdnM/nNu5ZL4CilxheLrTw3LrSjuea9+AJhgpVhUtioYBY ZwWfrHvI6xsa+CrV7jiIQey6Qp0IQh30eEH784Lp5mxc0M30QqpozUpX6CaCjjPKM+XA77ugRIj/K oDEaptUyLbPWPTIe1wig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rid6B-0000000ABLy-3VSO; Fri, 08 Mar 2024 16:29:31 +0000 Received: from mgamail.intel.com ([192.198.163.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rid69-0000000ABJr-1B4N for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 16:29:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709915369; x=1741451369; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5/XZC3z+eM8wwJ1lF4j9tR0kE6krkAhcW+WKtsojmIg=; b=keBxc00kXFkSaIPtgylZUkmnnGuAMG0o4crQUNuKYhx+9YaH71DpU6LM NjO7jCJOhsTD2Yk+1/6hB31MF8FgqVw2O8lDbkPpXOw8uSU4VVwPeK32a It3YYEI7TCjjlfqtdwdurkZ61vO7V8MvviuEYKYDiLIOE6mTUHMydxM6L eq4HPq7jKccR2IW1SDb87e3AzM0YdlaqNW8c5occPezL1mwPAmFB9Z7t8 YGH+QuCKUJYAOe6L6KHfdwWinof/PCr1raHGBI/gMijzuDqO0CKChQEzv cvnYa193uCY74UI1golO5qND6LNYyWHrwgr+swafa2n8Ipvy/M3jsVubQ w==; X-IronPort-AV: E=McAfee;i="6600,9927,11007"; a="4806751" X-IronPort-AV: E=Sophos;i="6.07,110,1708416000"; d="scan'208";a="4806751" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 08:29:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11007"; a="937047682" X-IronPort-AV: E=Sophos;i="6.07,110,1708416000"; d="scan'208";a="937047682" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 08 Mar 2024 08:29:26 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id C7F7D369; Fri, 8 Mar 2024 18:29:25 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Mark Brown , Michal Simek Subject: [PATCH v2 3/3] spi: xilinx: Make num_chipselect 8-bit in the struct xspi_platform_data Date: Fri, 8 Mar 2024 18:27:48 +0200 Message-ID: <20240308162920.46816-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240308162920.46816-1-andriy.shevchenko@linux.intel.com> References: <20240308162920.46816-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_082929_358108_9BBA6372 X-CRM114-Status: GOOD ( 14.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is no use for whole 16-bit for the number of chip select pins. Drop it to 8 bits and reshuffle the data structure layout to avoid unnecessary paddings. Signed-off-by: Andy Shevchenko Reviewed-by: Michal Simek --- include/linux/spi/xilinx_spi.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h index 4ba8f53ce570..1b8d984668b6 100644 --- a/include/linux/spi/xilinx_spi.h +++ b/include/linux/spi/xilinx_spi.h @@ -8,17 +8,17 @@ struct spi_board_info; /** * struct xspi_platform_data - Platform data of the Xilinx SPI driver - * @num_chipselect: Number of chip select by the IP. - * @bits_per_word: Number of bits per word. * @devices: Devices to add when the driver is probed. * @num_devices: Number of devices in the devices array. + * @num_chipselect: Number of chip select by the IP. + * @bits_per_word: Number of bits per word. * @force_irq: If set, forces QSPI transaction requirements. */ struct xspi_platform_data { - u16 num_chipselect; - u8 bits_per_word; struct spi_board_info *devices; u8 num_devices; + u8 num_chipselect; + u8 bits_per_word; bool force_irq; };