From patchwork Mon Mar 11 14:11:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 13588795 X-Patchwork-Delegate: geert@linux-m68k.org Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4CE73FE3D for ; Mon, 11 Mar 2024 14:12:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710166354; cv=none; b=KxdprpbcUT6NmW6dTqrMpWY6vAWKAA8Ct9aNumZ3ztPi6p43bYtPM704nEAqhGSv1la85cHCe8VEp0x0oixnDwQWSjL5cepaOVTO4Gp8cKL2ifyTgcVZDBVmFza2eXDQ4ep0ZCf9UO5sZUxtq8eeTLx0umDCKrZVkCyz58HEXrs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710166354; c=relaxed/simple; bh=/HGzTB5SZdVO3xOHO21xQHKVoBA4t5yAIwbItVhKxeE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UIWjy6DPjmV7NSutM63UPxzHKSoZkvG3m18Lc1mZhb0J4JSOYKBZTY8oX5Ux3EaBgdocFAk2JO2H7MsP8nMcBnwdXCDPwemfAWeCmeo2Piq1oT+MERuAOdL1k4MoObzxVakqpOyfINDD7B20urNS9x6ZbSlqToPl4+aQ0VqYZmg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=Yy9Ijr4b; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="Yy9Ijr4b" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a450615d1c4so754422666b.0 for ; Mon, 11 Mar 2024 07:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; s=google; t=1710166350; x=1710771150; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yBanA23QROE3/+jLFGt6yRe0SQoJ2oxKoX4eGPxFzrw=; b=Yy9Ijr4bZImVsPWjUXnztvNB/wqKf7ZtGMd6DlRUuxmxn9FpChWfGR5HWJwSRBoPJX U3N8uNFrXNl8nX/j8YT8vbYe3l4icX7f3pJZgFilMdor9B/gm9QaGnFS68zAV6XQryVf vU9UlMkn6yQN9B+lL83EIOvTgV3XkQ0qHWTeO/Ha4uz0ACIqyIb3BEky3X5J5fCHz9qb EMm8Q68WvJA83kTWrfojb2PDQgajuUWnMKUby+3K5rPZE02lS1gh7HrqLINcGQCf690x fcaiMb4QWGVPRc5iLVj/p8gUg3FEG9hlKpxgrMgEQj1VNJjXZkCBL/4iEAhi7u0qE0DB 13ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710166350; x=1710771150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yBanA23QROE3/+jLFGt6yRe0SQoJ2oxKoX4eGPxFzrw=; b=eoylLxz+Gh6sRoKIpsRFeWQe2hu7D/5q8KJlQYYOsnLhRrWAAxgCUPLEJ6FhbeWHbv tpwH/jaAo8rauG6z0+W11VxNkVaBDFb18MifItzX12FrvOX9dIEK1ZLL6Mf6qAUPSq0q oc3a79NiUVJcj+FDAkNz/YI2HhBC8hSW6916sCQn1c/Y8sG0Xmw+GbPosMxPTmnIlhcu JzWJUDIYq0ydibsMQI5bHfShh7SJCUeJyeWCdMSmKGBUVBdFJ2gVnFyDlP3+3hTHVI6C eTeaiUvh7BVCIkR9K7UMChZvRnIJXM95khbT8Ssl2ZEaiRSv2Jf2ytoH/z1PJ5VoykbD uGBQ== X-Gm-Message-State: AOJu0Yxua0cgsgKQM9C7mXNanwQ6SCMmnvKCohfwmOqXBDjy8WB3VO6f 6Zf1UEH0wgFQL/nAa7wW2Y8MXNDJp1O5FAJZ6WRN12XN3lILp0IvimHeigro8KI= X-Google-Smtp-Source: AGHT+IFpaFYHZPUC59+vr6YEUbUDIfvHm0t6MBKRtc2HkOlRmTHV+gZO+re4EWKsdiZyVhlhk5GFtg== X-Received: by 2002:a17:906:6cc:b0:a46:2a8a:63fb with SMTP id v12-20020a17090606cc00b00a462a8a63fbmr2167752ejb.26.1710166349926; Mon, 11 Mar 2024 07:12:29 -0700 (PDT) Received: from sleipner.berto.se (p4fcc8c6a.dip0.t-ipconnect.de. [79.204.140.106]) by smtp.googlemail.com with ESMTPSA id kn11-20020a170906aa4b00b00a45efdfdd1esm2863154ejb.40.2024.03.11.07.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 07:12:29 -0700 (PDT) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: Sergey Shtylyov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Claudiu Beznea , Yoshihiro Shimoda , Biju Das , netdev@vger.kernel.org, devicetree@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, =?utf-8?q?Niklas_S=C3=B6derlund?= Subject: [net-next,v3 1/2] dt-bindings: net: renesas,etheravb: Add optional MDIO bus node Date: Mon, 11 Mar 2024 15:11:05 +0100 Message-ID: <20240311141106.3200743-2-niklas.soderlund+renesas@ragnatech.se> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240311141106.3200743-1-niklas.soderlund+renesas@ragnatech.se> References: <20240311141106.3200743-1-niklas.soderlund+renesas@ragnatech.se> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The Renesas Ethernet AVB bindings do not allow the MDIO bus to be described. This has not been needed as only a single PHY is supported and no MDIO bus properties have been needed. Add an optional mdio node to the binding which allows the MDIO bus to be described and allow bus properties to be set. Signed-off-by: Niklas Söderlund Reviewed-by: Sergey Shtylyov Reviewed-by: Rob Herring --- * Changes since v2 - Mark the PHY pattern as deprecated and add a comment that new bindings should describe the PHY inside the MDIO node. --- .../devicetree/bindings/net/renesas,etheravb.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml index de7ba7f345a9..8bfd4fb5f834 100644 --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml @@ -93,6 +93,10 @@ properties: description: Number of size cells on the MDIO bus. const: 0 + mdio: + $ref: /schemas/net/mdio.yaml# + unevaluatedProperties: false + renesas,no-ether-link: type: boolean description: @@ -110,9 +114,13 @@ properties: tx-internal-delay-ps: enum: [0, 2000] +# In older bindings there where no mdio child-node to describe the MDIO bus +# and the PHY. To not fail older bindings accept any node with an address. New +# users should describe the PHY inside the mdio child-node. patternProperties: "@[0-9a-f]$": type: object + deprecated: true required: - compatible From patchwork Mon Mar 11 14:11:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 13588796 X-Patchwork-Delegate: geert@linux-m68k.org Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C7F83FE23 for ; Mon, 11 Mar 2024 14:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710166354; cv=none; b=afa83nKsX6R8oZ1HN56CRiLEe4pIpWc8ejgaRat2aYx4Bo0W8OCJ5vODeehl10pUVRxwcJX2QfppAYlSgZ3P7iK2j+IKeXTUVyn6xis1vLmpXcKmO6HoBA/bzkPVlwv8csYSY0CTV85VedIV+IX2LIFA0mGMwnLD6qVM/VpHz9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710166354; c=relaxed/simple; bh=rVZOsO2PWk9L7eDbDTFt/a8pYc9EpOZUtY86t0+O3oE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lkgFGBSat6pQL+OFwK/cRzOsK9xcAPFMbY2RP1e/rHI4BVwXBqC2O31C/7WAdvCJ61m5DCiG/FbmDmGmXKelf3EuEtyswnnlHhNfwNiFPOz3W4/f76mJpsEimF6Tu0UJ3bFAVQ3A8InM7OOH74QNPme0Low2zBgO6ijhr3S5e7k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=b4izc26p; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="b4izc26p" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5683247fd0fso4264215a12.3 for ; Mon, 11 Mar 2024 07:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; s=google; t=1710166351; x=1710771151; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tGqfMLj68zV4QYB0uesNdYqp81X62zcg2nmph+fkNLQ=; b=b4izc26puqsPYrGND3iwWeujcwm/X9ZjhJ1OCZWqGDTmCXVwFLhD4J3+gze9LbWhZc iBN+ZtDpTQTPQ1TyoVt3fzxI9wDzAmGB29b5VKRRHwaBep9ohRqBxwODmKN+99VZackE FHRVEedMP1onuQhz9UseIufl4ATsaX+4edrF4Qp4KDfU4NW6j70bRxXQADV7uOoY9n8N nd27ooAC9a+5dkU7Fa42T8t86RCQ4UGFBRCwWF6lFDHyuOOP1YrwQBQ1Og95WHOBMK+C JnNyaVIQU6zCE7Sz2B/QbnELLlkkZsT7MAlW27TUYsqIuw9nSuryD1+kK/ymRIC8nO4I oegQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710166351; x=1710771151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tGqfMLj68zV4QYB0uesNdYqp81X62zcg2nmph+fkNLQ=; b=CVOgE2Wde11nbzxgRrR1htmtJoyOJrjaVDrc3VK+SnpEnPlYi+SpuVrkVURdYFp9ev pNiYz2Y5czNVuKOSRCfjMv9f4Gc3S4VSORQw854o3D7esbP3i2fhtW6QjVGY91rKB6vV Tkb9PK3TpjZHoFXXbNX0DYgo9nH/LdDqAaAZ5LUYcm2cAzcbHw+tLRG04uSMZ4rghBAK HSSf0lNB8bKmSvDqmljtLkGf6DXL8JlPZfKWwH89EnA47bNopvKmXYTa4i9+p4WC07G2 wj/3Bkq7q73dCf8JrUdOmHTkndGwz20viCsuMVGvpvTx9nHnsDcYrsjNlvEgYkZ9zW8A fkUQ== X-Gm-Message-State: AOJu0YzecH7hce+u2vNXYEeecNPGYLfNyP2zGJzQZhXEMirZ9qIAM3FN dvmr/oJcPIFUu8Lof2gb9rKdAUC4gRzINtfE7IN9NeQW4o+iDcLnGzzr6kqePFY= X-Google-Smtp-Source: AGHT+IGv/UO+y536rcu5Pt1opdzuMvWULQFbRmxnXvsT/KYgcNTaWIUMZPJHXoYy8ixzjKVsCLJOEw== X-Received: by 2002:a17:907:d40d:b0:a46:17dd:33da with SMTP id vi13-20020a170907d40d00b00a4617dd33damr3853059ejc.29.1710166350938; Mon, 11 Mar 2024 07:12:30 -0700 (PDT) Received: from sleipner.berto.se (p4fcc8c6a.dip0.t-ipconnect.de. [79.204.140.106]) by smtp.googlemail.com with ESMTPSA id kn11-20020a170906aa4b00b00a45efdfdd1esm2863154ejb.40.2024.03.11.07.12.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 07:12:30 -0700 (PDT) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: Sergey Shtylyov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Claudiu Beznea , Yoshihiro Shimoda , Biju Das , netdev@vger.kernel.org, devicetree@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, =?utf-8?q?Niklas_S=C3=B6derlund?= Subject: [net-next,v3 2/2] ravb: Add support for an optional MDIO mode Date: Mon, 11 Mar 2024 15:11:06 +0100 Message-ID: <20240311141106.3200743-3-niklas.soderlund+renesas@ragnatech.se> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240311141106.3200743-1-niklas.soderlund+renesas@ragnatech.se> References: <20240311141106.3200743-1-niklas.soderlund+renesas@ragnatech.se> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The driver used the DT node of the device itself when registering the MDIO bus. While this works, it creates a problem: it forces any MDIO bus properties to also be set on the devices DT node. This mixes the properties of two distinctly different things and is confusing. This change adds support for an optional mdio node to be defined as a child to the device DT node. The child node can then be used to describe MDIO bus properties that the MDIO core can act on when registering the bus. If no mdio child node is found the driver fallback to the old behavior and register the MDIO bus using the device DT node. This change is backward compatible with old bindings in use. Signed-off-by: Niklas Söderlund Reviewed-by: Sergey Shtylyov Reviewed-by: Andrew Lunn --- * Changes since v2 - Use DT node instead of OF ode in commit message. - Update punctuation in commit message. - Simplify the node selection in the driver. --- drivers/net/ethernet/renesas/ravb_main.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index fa48ff4aba2d..b6adf608ebfa 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -2564,6 +2564,7 @@ static int ravb_mdio_init(struct ravb_private *priv) { struct platform_device *pdev = priv->pdev; struct device *dev = &pdev->dev; + struct device_node *mdio_node; struct phy_device *phydev; struct device_node *pn; int error; @@ -2583,7 +2584,13 @@ static int ravb_mdio_init(struct ravb_private *priv) pdev->name, pdev->id); /* Register MDIO bus */ - error = of_mdiobus_register(priv->mii_bus, dev->of_node); + mdio_node = of_get_child_by_name(dev->of_node, "mdio"); + if (!mdio_node) { + /* backwards compatibility for DT lacking mdio subnode */ + mdio_node = of_node_get(dev->of_node); + } + error = of_mdiobus_register(priv->mii_bus, mdio_node); + of_node_put(mdio_node); if (error) goto out_free_bus;