From patchwork Tue Mar 12 05:50:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13589524 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CE0D10A12 for ; Tue, 12 Mar 2024 05:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222973; cv=none; b=m+MmhJwEpd57a/7U8VngJrXZ+HoJk/NsfPc9e0wn/paLOtEnz1MGpFx4xDv4gEUAQWtg9XobBFDcK+VXX9qnoN6QQn5u9YOT7OzNFh8ZpF9HBzB8RHIlb4u4+ca2WnqmZh4goL941T7adN7Ci925aDKptb7vsR0eqqtL7YTZ0rY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222973; c=relaxed/simple; bh=AeMCnQrcghrbfUiausLzdPueuydkmOOocRBBjL/GjSY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=T0wfuroMd/yN/xgibsKd59DnfrlsKRgg0/vNiwekvANfAlhdoJWdJPqS/zPvMUoy3gSDyhmSR8YcHdGcFEznH0jfMEqFn60sqjMSAof5RbqLxoktc6u+1ImAzMm9tJOGEEcCkgSHRWzpbz8BXsUqcw9lLjXBukPz0m1/5KcIoTA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M/SXkd69; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M/SXkd69" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6e6a9fafacdso30133b3a.2 for ; Mon, 11 Mar 2024 22:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710222971; x=1710827771; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+As1I23Fk0wt6wYR+3fekI8diQCK3+5aZIPQ4oN2LPM=; b=M/SXkd69Wr9mfOzPKYsOas5RQfAXsBpoThkmCb7IMGI5Gs55Ii8ICCfbdXec8smNeo bFiSlh7iYVq8ey7k3vVzTQ5zzNGA92MBQshZlIvVPKQaXwEJgXhR9rWsyAv2lw3sRJvL T9rPDIkZX+CTOXU2Xk/gEX8pLK4rRPTiGEbHF/NmVahXx/AFOHWUV+WO1t56HMbMYbe+ T/M1BCP85ZtGu1LtiouqpoWVoUk7N2jm3f85nEfizdaa6pR6uwCq98/qWheTRLzU7Rdr iZ7uJfHkVALJjGQmBqPhy3WSiCutsj6LZMBdyG+iEXWnL7pBiYGmp9uMCQC9UZTbk22K a7jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710222971; x=1710827771; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+As1I23Fk0wt6wYR+3fekI8diQCK3+5aZIPQ4oN2LPM=; b=Ec64eDibLF4asv9vwtKoSoklxMlBQwBetSPpUWRWh6JyLU46YQvYk1O52d6AS1takC naBfVkdJbUgJu+eie/qPWYIxhjO4IVGnZhDPm5uuzLGBsuD1usv5UMnxD3Jp+oVhJqrk kIP0LFQOgXe0eNuMjJccpbJ0Xs4sf7UuAKUyxn9c29yaPmj20LKTRZ+az/aFd4SFQEb4 CArxNsUZm6ABHLH9H6ObsV2dycM/FasfQNQcYJsxgCOqdh1rK10osRxNkueNKhUfJ8kQ ym2Mp+cjs+cTfSX3CnoHJzVCCDhQvf8aPa3al0UGU/wZncwy49zMk3bF7lf2ROIqTrI2 aLQA== X-Forwarded-Encrypted: i=1; AJvYcCWV7Z7vUq0ypW8Dc+8cipaPwnGmVLKTjqt6hHHpc7SEBWJQoJyGl4YMvbEmjHU73y3cDtJhEqWkugLAb3Gx/JQE+NWjdzSa5yJy X-Gm-Message-State: AOJu0Yxw+zuWLCZOOrmjSjdRRTWeG/b5/IyDN32HnornRcJPfWl6C86q swtvLouQO/HdxLXsKlvdC/n642y/QOAQY/YHMj49qzOnYR+E0X7h X-Google-Smtp-Source: AGHT+IH5q+U4aeI8acoozFuVn90Z/1xRn18QFi1lRYlXsImbFabgnwQwDiyTBVGNE92gA1JyoX96gA== X-Received: by 2002:a05:6a00:2da2:b0:6e6:5012:8b38 with SMTP id fb34-20020a056a002da200b006e650128b38mr10481346pfb.25.1710222971451; Mon, 11 Mar 2024 22:56:11 -0700 (PDT) Received: from petra.lan ([2607:fa18:9ffd::d95]) by smtp.gmail.com with ESMTPSA id k30-20020aa79d1e000000b006e65720e892sm5448898pfp.94.2024.03.11.22.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 22:56:11 -0700 (PDT) From: Alex Henrie To: linux-parport@lists.infradead.org, linux-usb@vger.kernel.org, sudipm.mukherjee@gmail.com, johan@kernel.org, daniel@gimpelevich.san-francisco.ca.us, hkzlabnet@gmail.com, reboots@g-cipher.net, mike@trausch.us Cc: Alex Henrie Subject: [PATCH 1/7] docs: driver-api: parport-lowlevel: clarify purpose of PARPORT_MODE_PCSPP Date: Mon, 11 Mar 2024 23:50:26 -0600 Message-ID: <20240312055350.205878-1-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Link: http://lists.infradead.org/pipermail/linux-parport/2024-February/001237.html Signed-off-by: Alex Henrie --- Documentation/driver-api/parport-lowlevel.rst | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Documentation/driver-api/parport-lowlevel.rst b/Documentation/driver-api/parport-lowlevel.rst index 0633d70ffda7..aaf02cf62363 100644 --- a/Documentation/driver-api/parport-lowlevel.rst +++ b/Documentation/driver-api/parport-lowlevel.rst @@ -155,10 +155,11 @@ hardware. It consists of flags which may be bitwise-ored together: ============================= =============================================== PARPORT_MODE_PCSPP IBM PC registers are available, - i.e. functions that act on data, - control and status registers are - probably writing directly to the - hardware. + i.e. ``base`` (and ``base_hi`` if ECP) + in ``struct parport`` is valid. + Functions that act on data, control + and status registers are probably + writing directly to the hardware. PARPORT_MODE_TRISTATE The data drivers may be turned off. This allows the data lines to be used for reverse (peripheral to host) From patchwork Tue Mar 12 05:50:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13589525 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45FDC111AC for ; Tue, 12 Mar 2024 05:56:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222974; cv=none; b=j3r8OBnkH7/0J17O7OHpODdXGfl93vMR/LQG/AnnIaBlnG4qafbpFQpsAycIU696XT+5P3qt2wHsI2ApXFt44x7pCexWQKMcDKzSlX1O6daXHfFaUhO4FJW4h5q/NMKPNUc8GmHlEWFwaCujRwRTu1tiKetxdJsyhtqWha3kDCY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222974; c=relaxed/simple; bh=HA6xzbXEFgmNW5aXJev88R3ywTWxmsWWBzThqVQsfL4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iS16M4zQl6V2fXDpYSMBAnNXcnPiOXDdYABKmTxUFiMwsDvyhwbx2RE2bLVkej6kGmaOIMGntrX7fLhb9OMaFIPdqV0pXny4Qz5e2GlLUTVjbUBs34wVAZCSB3BLBUp9qiAYRoGH2UV82ocKIqvkIicSV55/2T6l0iq4EHpdakM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WOjWh0ha; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WOjWh0ha" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6e64a9df6c3so4217977b3a.3 for ; Mon, 11 Mar 2024 22:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710222972; x=1710827772; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LzkITiBLhyrNfsAY55+TA7J2AEudtQ83y3uuGgzmOGc=; b=WOjWh0haWyKx980JwDUO7iQxDPy9OnOdqYw203CvNp6NU4eK1aTfuZEJ/TiERBCp6b zf8786h2cSiFMkCo8Za0DYVxEs5AHvRNwDjpULOJN0kTEwcw0svD6/drxlsluye4jcrO DV0rIH89R79/pPDUbaSjrBm/ZC+I3WFr9gQ+yB30inTX4snRI1/1J57WA6ss3+owK9mo ejHDGoEn003EQqgkw1H+4z/29wb776uijG7h6WZsBTS5VDM6IyMjU1+wtUNcdZwItm/8 0u0ATjsgMkR05wEIVg6U1aQhlQHbXHt2KV68h9XDp+bXtScE9wHS48VRIyeJxpncFASM redg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710222972; x=1710827772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LzkITiBLhyrNfsAY55+TA7J2AEudtQ83y3uuGgzmOGc=; b=PDrOBotDjVAYWygrAV98xgrbBzYytbzsq3L5DfaLysjl5KkTNEHFBNpOA9jReQox2n KXHZrLPKQBlXH3wTJ8gHd+7GHq7WJnSi8pSNBp1+di1AP1Y3nFFPdxmVe005K8EtuauM 4w6ew/IfGMszWvqlu54fWU3vr80giObNHcVb8xjdjnSVQUU6Jt/WN6ASEO3ynAdnTtBG +4pGPlsLezLsFfiOt+TYyDOEE9+jkcAD1GBw/KD97NQJTg9zknOyGN7PAXoBeEgerOeZ tl3aqQZgKDyRGv45CJpwQ8UDW+xuwIu0E5THHi0Wkqz31juHZM+GBzcnMdXNL2RsBOxM Iodw== X-Forwarded-Encrypted: i=1; AJvYcCXHj+wJkBKcfpGn0gGrkJdjQ2orEd41MNcS9mkuBRLUf5p59FweF/VSbOAGnk77lxN/lPzREUPpMuw4H3bvAXQRg9eaxFgOIYv+ X-Gm-Message-State: AOJu0YwHbqV7QZ2XTwvVgj272x1cgSvQx1+0GgInxdhkaM/MiXVQ04wt fmFpNFTkSOx9bF5K33CzcnXCrq3hsVrUcV9DXJyjHBnQQHOXhmQv X-Google-Smtp-Source: AGHT+IF1ofl+elb2wqUDPQOI2c520WhDD/HLlfM2OyJJVmet6pZaRK1HuwUU6XZr8gQmrXA1b/wzcQ== X-Received: by 2002:a05:6a00:1913:b0:6e5:d3b9:2d06 with SMTP id y19-20020a056a00191300b006e5d3b92d06mr10649541pfi.21.1710222972485; Mon, 11 Mar 2024 22:56:12 -0700 (PDT) Received: from petra.lan ([2607:fa18:9ffd::d95]) by smtp.gmail.com with ESMTPSA id k30-20020aa79d1e000000b006e65720e892sm5448898pfp.94.2024.03.11.22.56.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 22:56:12 -0700 (PDT) From: Alex Henrie To: linux-parport@lists.infradead.org, linux-usb@vger.kernel.org, sudipm.mukherjee@gmail.com, johan@kernel.org, daniel@gimpelevich.san-francisco.ca.us, hkzlabnet@gmail.com, reboots@g-cipher.net, mike@trausch.us Cc: Alex Henrie Subject: [PATCH 2/7] usb: serial: mos7720: don't advertise PARPORT_MODE_PCSPP Date: Mon, 11 Mar 2024 23:50:27 -0600 Message-ID: <20240312055350.205878-2-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240312055350.205878-1-alexhenrie24@gmail.com> References: <20240312055350.205878-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Signed-off-by: Alex Henrie --- drivers/usb/serial/mos7720.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c index 23544074eb1c..0e97def80e19 100644 --- a/drivers/usb/serial/mos7720.c +++ b/drivers/usb/serial/mos7720.c @@ -589,7 +589,7 @@ static int mos7715_parport_init(struct usb_serial *serial) return -EIO; } mos_parport->pp->private_data = mos_parport; - mos_parport->pp->modes = PARPORT_MODE_COMPAT | PARPORT_MODE_PCSPP; + mos_parport->pp->modes = PARPORT_MODE_COMPAT; mos_parport->pp->dev = &serial->interface->dev; parport_announce_port(mos_parport->pp); From patchwork Tue Mar 12 05:50:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13589526 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A7C610A12 for ; Tue, 12 Mar 2024 05:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222976; cv=none; b=S1T7GHwD70+o7zea4mt65ldmQwiuXn7jysvHHkQqepKDgxHd7ChAsZFxyYjA2lI2KJ+IMDUxinRC0JZOjYL+WxtDKZ9eWNQL/Feb1kZvPyZ7Ictol/NhotaLFCeX5uvO6zFI9OUYryp/bKmm/CUNGBCKTguSdBnzyTKGJ9APVGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222976; c=relaxed/simple; bh=Qmd829tBEpAWVSKXwD/N3AiyesDW51QaiorU9m2nPpc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l2OEBbQiFTcDPjQz/FfqqLkvt+RO2279CQHBN3ZA7+TKMl7dUM67IFO/ydFwxjkNYT5Uuhjc+4AJis1WYAf/PmkYWWoyU8fQcmVWaMKYiPw7aoGdn/iH9IQx88J+5UgbX3IIfYTyaLBWU/7ek1kyYwU4bNaORLu/YUkosb/UX/4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nhf0KhAA; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nhf0KhAA" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5a207059927so677480eaf.0 for ; Mon, 11 Mar 2024 22:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710222973; x=1710827773; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XtEhjSgd58gdyLY2mZzSMHyzfy6VzyXbW9WqggfSxOM=; b=Nhf0KhAAYWg0XNdsyWslUFwWG/jK8OCI14HApr699Od2YlvJUpkspaa3mbeVwKP46V 1DgCw3S5dd0y6zet2F0PJNd7YOCSM22UpviJ7KCrnu7UpH1SZr6180p0YDssNr3bvtFF VA68VsWy95vosnw4AwxeO4oGyGwQdb6HsDdMcGT/rSMkRH5nOTuvcwFWIzpTtChc2nk6 2xWXIEQU7qfaNKRJ+sDD6/QEYBAVfm/ZkY5RLHu5jjMHgDofbLm63HzL2hEoRJeS4uNp /HdFsOET0AI+F9bVOHLAA0M6NjzTwaLqdlUZEOpiY46VfoJQAiw3wajbI4uVBfdFc3mf 851w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710222973; x=1710827773; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XtEhjSgd58gdyLY2mZzSMHyzfy6VzyXbW9WqggfSxOM=; b=aeFi1X6M81c3PV4nxhYfaW9wxeoC1Rw1ONSocf0nPpUYM3dK6O6CW+noTAEJZZuhs/ xhLA0qyLcLPL86zKZxs8a9D6Y9B7vK5qo1OXBTm5MS+5bbA45hCmq01Zlrqqi0EoLtt3 crKAbrNnhymxlZsPRB7jmDg+xzUocXUItimieXwnasIBLOavlTn28Lyj3Wj9UdYLAOzw +tlaSieFsjrJOeFZmK9Lis4npwHNUG8vm8r0BcPaPvbQqH9uVGXoVu/C1CV6iibnxi0I uFqLwDmTF6vyhtsnjIB4dRbW1gkJ4qOKJ0gTnjRm+aTmIcn6abjPDQBnWLrhnc2U415b wYsQ== X-Forwarded-Encrypted: i=1; AJvYcCWlSYawnC21SlU+n0Jwiaa/ZnIlXnR+iJ9OBiPAec5GgOIzUSjTDKSbhIxZNYycb4N3bez7Ucc+E4TsfDYLRYRVwft0D3PL9Lz+ X-Gm-Message-State: AOJu0YwBL85uDjYNDXE5T6DyhZUdCCz+E0+mZ7tFSFFBNGIc3btkN6yU YRxd/dCHOPud04epQWbqdzHTfIDPgVB0DtDpIssPvCoGl+M6/GQf X-Google-Smtp-Source: AGHT+IEUmwiSrEXAm/3lCpf1rRd8/7HcVvqa18ri3GCjgdoXgpuI+GA3zK7AdrtxbwoZlK4opyxv5g== X-Received: by 2002:a05:6871:520a:b0:21e:6669:c3b4 with SMTP id ht10-20020a056871520a00b0021e6669c3b4mr9917783oac.35.1710222973482; Mon, 11 Mar 2024 22:56:13 -0700 (PDT) Received: from petra.lan ([2607:fa18:9ffd::d95]) by smtp.gmail.com with ESMTPSA id k30-20020aa79d1e000000b006e65720e892sm5448898pfp.94.2024.03.11.22.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 22:56:13 -0700 (PDT) From: Alex Henrie To: linux-parport@lists.infradead.org, linux-usb@vger.kernel.org, sudipm.mukherjee@gmail.com, johan@kernel.org, daniel@gimpelevich.san-francisco.ca.us, hkzlabnet@gmail.com, reboots@g-cipher.net, mike@trausch.us Cc: Alex Henrie Subject: [PATCH 3/7] usb: misc: uss720: don't advertise PARPORT_MODE_PCSPP Date: Mon, 11 Mar 2024 23:50:28 -0600 Message-ID: <20240312055350.205878-3-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240312055350.205878-1-alexhenrie24@gmail.com> References: <20240312055350.205878-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Signed-off-by: Alex Henrie --- drivers/usb/misc/uss720.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index b00d92db5dfd..fadceb7ab34d 100644 --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -719,7 +719,7 @@ static int uss720_probe(struct usb_interface *intf, priv->pp = pp; pp->private_data = priv; - pp->modes = PARPORT_MODE_PCSPP | PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP | PARPORT_MODE_ECP | PARPORT_MODE_COMPAT; + pp->modes = PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP | PARPORT_MODE_ECP | PARPORT_MODE_COMPAT; /* set the USS720 control register to manual mode, no ECP compression, enable all ints */ set_1284_register(pp, 7, 0x00, GFP_KERNEL); From patchwork Tue Mar 12 05:50:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13589527 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 266F22DF84 for ; Tue, 12 Mar 2024 05:56:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222976; cv=none; b=Yrrt3yyLWtTuOOGYJWxK24A/N9YhgJqK3+bqujEZc5tP/Zi8l1bScvx1kkVHlEfEQLwBWpywb0Oy7JW2Kd3123jBiYwMy84a8catHYq+w+LKmctuFylQJhqGIOnWJdQepJosgyBHLX6hQvqQAirwtqF4EKdlX5VK7gMgQ8X2ntg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222976; c=relaxed/simple; bh=jvySCg8KzME4AwDmlR1Ld67nFxe5EkiMe5MIIk+sHws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T+losNwY8Yx+ueOtHG5N1QSKKLc77oy24QQSz0OcqSXw4bToXUgtIHrX3Nhl1CWOWoUzhL0KhIbq4AjxodZ1FhmT9ORMHhKBgR4WoCfAKEZIoc26QqAU02Fb7TlKAKItFaqOaLOpsDqxCQg6CsmpTT+bhSlF0JMxFLZDq3IIsuQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hF/OPg7g; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hF/OPg7g" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6e5c0be115aso3352194b3a.3 for ; Mon, 11 Mar 2024 22:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710222974; x=1710827774; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5maZ1JX1BnhIFhkLqq8OYrtHrSjOUVxGgN6MCqRapwA=; b=hF/OPg7gYhhsFomq//jTc7DoAgYnajRZgucYnTUSSZg5RlvckeWG+TvNQX/y59B28a gtXsm9EQm/2sjoZkqZjAA+ipmA0Q592ZcneBalmrAVMUUJn+WOMNj/tJZOpMERnFkr7K Z7CbquUnQ4bBy9/tUYlxMsC1FpBjV7T8+6Ax9cgm9oSN0JVOoOhZ3sqkII6tOxRVig06 /npBCRcJy49UxsDkDnKk2PfTdRKE9IXqyyE3zgLdXDBNUUfpD0GlgVfTYz8XO5q1dwyQ 9awyHVmPA2oRSqlkMOPkti6WHvy/7t82Q7q+QaW6C9cWlYWGCkm6qQsR75J7Uy5GOUoZ Rj6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710222974; x=1710827774; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5maZ1JX1BnhIFhkLqq8OYrtHrSjOUVxGgN6MCqRapwA=; b=E0PqD2VZL3bU0Pnnc7UmDSi9n9u/7qxRVI0wv+tv3W3tx2DErejH5q5oO0tAgL18y3 hwXbJ1IoZN6RdOnHkMXkfrmxRur+kUEQVd2EKW33FNZEwyEGlcaHcFCERFfO2YR3bbPl wycFrAl1MiF2xN4/c8r73/kl9zWCdYFXtbLsqLHQH8Vtajxtu19I1CO+8HiLuUxOhcqP NqXnaZzUd/ZXJC73UbaDmN7IHMLgOOoTLu4NJDJsT6SRDEEIEdfbDt/2msGMu/tzXMNK IWwnroAnw9q+gBLsh9kRANSw3oq2fvauvpVk9TdZWcwC4TxOYpVA/Gk364hC+MTab6Dd ESZw== X-Forwarded-Encrypted: i=1; AJvYcCUXeeL9GYPe0ITeLEWN8ZbdzJy8NDEznxMApvNNrM3KmU/7GmzAxVa2Lnh9WKElnz/4kqrSFEXAiAyS/maD1h7hJGgmY5S4jWR2 X-Gm-Message-State: AOJu0Yzf4+DVyx8aDCrmPpv13WVfs3Zd3NyNuMCQ5t0/Czmm0fjO8sYV vPWRgQkw8RkDe2rrgBfIrkvKWgJAiVZFklCmdxZBt38sdDDGbQbQ X-Google-Smtp-Source: AGHT+IFeixIj/6ZApVN7QghFofefeV2nTX75kgv7UVu6seIP6knRYZGe+R6oGfsTbMkffLD63D8WGw== X-Received: by 2002:a05:6a00:130e:b0:6e6:270a:9303 with SMTP id j14-20020a056a00130e00b006e6270a9303mr7983048pfu.32.1710222974446; Mon, 11 Mar 2024 22:56:14 -0700 (PDT) Received: from petra.lan ([2607:fa18:9ffd::d95]) by smtp.gmail.com with ESMTPSA id k30-20020aa79d1e000000b006e65720e892sm5448898pfp.94.2024.03.11.22.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 22:56:14 -0700 (PDT) From: Alex Henrie To: linux-parport@lists.infradead.org, linux-usb@vger.kernel.org, sudipm.mukherjee@gmail.com, johan@kernel.org, daniel@gimpelevich.san-francisco.ca.us, hkzlabnet@gmail.com, reboots@g-cipher.net, mike@trausch.us Cc: Alex Henrie Subject: [PATCH 4/7] usb: misc: uss720: point pp->dev to usbdev->dev Date: Mon, 11 Mar 2024 23:50:29 -0600 Message-ID: <20240312055350.205878-4-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240312055350.205878-1-alexhenrie24@gmail.com> References: <20240312055350.205878-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This avoids a "fix this legacy no-device port driver" warning. Signed-off-by: Alex Henrie --- drivers/usb/misc/uss720.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index fadceb7ab34d..be7d3fa4c150 100644 --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -720,6 +720,7 @@ static int uss720_probe(struct usb_interface *intf, priv->pp = pp; pp->private_data = priv; pp->modes = PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP | PARPORT_MODE_ECP | PARPORT_MODE_COMPAT; + pp->dev = &usbdev->dev; /* set the USS720 control register to manual mode, no ECP compression, enable all ints */ set_1284_register(pp, 7, 0x00, GFP_KERNEL); From patchwork Tue Mar 12 05:50:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13589528 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A34603984D for ; Tue, 12 Mar 2024 05:56:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222978; cv=none; b=k1meBBMwkamuSlEHaSkIc8F8wBNCQrM8cSo7ST4o2t5uPGwyvwVwdlzaLVGETUKCjrYc10R0fTShrefyr+CYjiki+Hjn9AV/k1lDwS4yQMYMjh9GNaj24w30pdSnUa4lzwO+7ywzwnyuEmwBBsnAfur+ki/3crUURR2+MCDr9yw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222978; c=relaxed/simple; bh=NfwcbhR5aa39GTFpbvoYtRIeiLvtfmSJKvhlGGDL/wE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HfuzxJc/kQBY+U9hDI/iiHKI/DxugZncAhPsDywZp2xEIiJcZ49FQxTe7cTZLB+n5RX515GG3pML8BhR7QxXo9dulNuHyk9fR29MTzaJbyBE/7adm6fOfL6fX63EedMC25e/+S9HKMz7cefXk++adTJ5mnkjEuGYNStFXv9jTXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=etubsTLo; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="etubsTLo" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-6e0f43074edso3529204a34.1 for ; Mon, 11 Mar 2024 22:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710222976; x=1710827776; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/bipMtOGV/gTPSxHYeSqPV+LKKjbQyn34/0Nkf0Hyhc=; b=etubsTLooNEMdOfiEgHoAUeUY9UU3MQT8Ghvv9m8HFowgbJabawTLhvUIILLH5m1nY e3CnTehTtf6ZP/tg261MwyezvMKdPYVlaC86zNtSrhVACNuuz1RfQachef4Nn7ZE79Db K2DOi/8W4LioTpDgG9aWwRJIOjPk6IY/fSgpRa/VAV1X+YsM0B5jqfD7kaiS9+HFrLfH +nHkiOZk58KjER9GxVrwqzT0No4XNRK9XHgSNqtjsbXGTuMferUzkosQXguadedub7+R po8FWiCN29DuSQDgxnsYNFRfz6XqNfsXIYXOqQO41bqLk/taC6Q8HCDtKc7d8ddbwcJV 2RFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710222976; x=1710827776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/bipMtOGV/gTPSxHYeSqPV+LKKjbQyn34/0Nkf0Hyhc=; b=d35CioVYLxt+chgkVo5SaYL1gN/DYDCGVijSMTTPTJPooZCdBGFGisltVTu/y93NjT HGAWJ/2BfhcBDtFdvGxtItmFVLg8t4JU9paLAhnfpW0aJwYR+Bo4xYi2KktNsA6Mx6oa NPRWHL3BM2EEOfrA0k9bW5OCR3tGQK/Rb2vMA4uMXnCKnoNw/Nzys1NLzJXx15LgClPr jSKhovkV7npx2QlWpg+5laujM+C24Q1OuBq3LHSPB/ENQwzsO4tgUFWZQ6PEcA/JZ+mH XfMK4IiDg14+e1tm1D0q5mWONMPG6o35lyuNuuSB/fmYC9zxRo9n0rCfC6SXHFcOiA7w z4hw== X-Forwarded-Encrypted: i=1; AJvYcCVjlvqWYFpLcPGNt4bPp6j0RUE6ahZaJcq2vH6qSJBepLZBoiCohx6vk6yErXWykWXLImNlvIFjZBl2j7/MxKIGa64o1WqzPgss X-Gm-Message-State: AOJu0YzuRjdruWal4+sFieRWjgeEhnkCs3w31K53QViYYtzLCaA0u72q CuDUo5m0wgoom9DdwdjAGRYPtoN0j2VYnSo/50zAjoedkbJq9AyM X-Google-Smtp-Source: AGHT+IEEPBR0WadFpkeHeRyELxle/6vAx1+ttD0XNfRRI7+hZIvsIVceYuaZLrN1plY2c1h7n10ZEA== X-Received: by 2002:a05:6870:96ac:b0:21e:80ee:523b with SMTP id o44-20020a05687096ac00b0021e80ee523bmr7297638oaq.34.1710222975622; Mon, 11 Mar 2024 22:56:15 -0700 (PDT) Received: from petra.lan ([2607:fa18:9ffd::d95]) by smtp.gmail.com with ESMTPSA id k30-20020aa79d1e000000b006e65720e892sm5448898pfp.94.2024.03.11.22.56.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 22:56:15 -0700 (PDT) From: Alex Henrie To: linux-parport@lists.infradead.org, linux-usb@vger.kernel.org, sudipm.mukherjee@gmail.com, johan@kernel.org, daniel@gimpelevich.san-francisco.ca.us, hkzlabnet@gmail.com, reboots@g-cipher.net, mike@trausch.us Cc: Alex Henrie Subject: [PATCH 5/7] usb: misc: uss720: document the names of the compatible devices Date: Mon, 11 Mar 2024 23:50:30 -0600 Message-ID: <20240312055350.205878-5-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240312055350.205878-1-alexhenrie24@gmail.com> References: <20240312055350.205878-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Information about 04b8:0002 and 05ab:0002 is from commit e3cb7bde9a6a ("USB: misc: uss720: more vendor/product ID's", 2018-03-20). The rest are from . Signed-off-by: Alex Henrie --- drivers/usb/misc/uss720.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index be7d3fa4c150..15cafc7dfd22 100644 --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -767,14 +767,14 @@ static void uss720_disconnect(struct usb_interface *intf) /* table of cables that work through this driver */ static const struct usb_device_id uss720_table[] = { - { USB_DEVICE(0x047e, 0x1001) }, - { USB_DEVICE(0x04b8, 0x0002) }, - { USB_DEVICE(0x04b8, 0x0003) }, + { USB_DEVICE(0x047e, 0x1001) }, /* Infowave 901-0030 */ + { USB_DEVICE(0x04b8, 0x0002) }, /* Epson CAEUL0002 ISD-103 */ + { USB_DEVICE(0x04b8, 0x0003) }, /* Epson ISD-101 */ { USB_DEVICE(0x050d, 0x0002) }, - { USB_DEVICE(0x050d, 0x1202) }, + { USB_DEVICE(0x050d, 0x1202) }, /* Belkin F5U120-PC */ { USB_DEVICE(0x0557, 0x2001) }, - { USB_DEVICE(0x05ab, 0x0002) }, - { USB_DEVICE(0x06c6, 0x0100) }, + { USB_DEVICE(0x05ab, 0x0002) }, /* Belkin F5U002 ISD-101 */ + { USB_DEVICE(0x06c6, 0x0100) }, /* Infowave ISD-103 */ { USB_DEVICE(0x0729, 0x1284) }, { USB_DEVICE(0x1293, 0x0002) }, { } /* Terminating entry */ From patchwork Tue Mar 12 05:50:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13589529 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7583A3FB38 for ; Tue, 12 Mar 2024 05:56:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222978; cv=none; b=Ht//DD72GffoOoEA0bXK9Xa4/KJ3J5uJg2kwlD0wsGpGsRVUTb1XrYvHJpjbNGgWlKCa2711IciDE5e8gI7BvxAuQZIUQW446+1OGDz0vT+2WvG49TxYPBToTx1aadlNF/TR5WaeicyogJGAYnzKOWww8tA7EYfg0AXEoZtNs2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222978; c=relaxed/simple; bh=5RTWz3uzbMnHpZbNqSMq0dzU0ZakS0d5QH3HmuxpD30=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nBwhf96Zsi1wnUU1DTjioF9Si+XMAR6HAXpSotHM3XlwR3I4H7Jo1ekDCLcuhYP8HwiNTm6WPmNwyvX/Tge20Shu+Epw4lLzwtYxUM0iQHNSypOUPlpPkT4w785MUX7VruHPVmiSBHtUeTktjXjW3mEXdVSitPPEFH6r5ssF4HM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kmDo2jFn; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kmDo2jFn" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-221ffba5c8bso918688fac.1 for ; Mon, 11 Mar 2024 22:56:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710222976; x=1710827776; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2b9ehj94EjdhIf37gyeIKW8wdt259vcVkC4Jo5u5QkE=; b=kmDo2jFnQIrLqemdEfn4Og3gf5ahPkZgyOIkklI9hYAefDxHYU7eQ9eSxVZ6vruZMY JxlnQd4VDnNUpfQ2yWK5mshLTsrmlWtajyh3uMORrIdukGlcu2wGrLtQ3+g3AZN9kmWf PltzIydth8Uostgmp7HzMjAa6fxNLhUt/4f7dMG3pVhj4QlvumqWZ58C4mKGoVFn0lqz 5qiOO6klJkDWDuRJpRNccCzNKX4cUVmmGQSFWbE39BWYoeeX1y9G43zirQhb11PQYIO5 +lAo/QnSJQUOcjlsY8Poy5JQA0Bx11++IIUVoSbFOiMd/5+0LKBtrnnHRmDrocqVxDIk uxtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710222976; x=1710827776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2b9ehj94EjdhIf37gyeIKW8wdt259vcVkC4Jo5u5QkE=; b=kt173l0yNc6S0GAzbI2haPG16jcCXOsRLsMGKL3jBRRtFTBji/lV160rToZ9FPBGUZ u941sZqsHkH8iDoBd/0Ut0yOjSJ2Zd//hamrXTgSFHN0ouGVGdEX6uo02kPimUHFOr8X YOvDa4gR2aokzyTkOXVqdGYOs0iqh9l1lzY84WmRM1eJXEayseVEPYnrql50TcY+j1K2 CIalPYlejnStFunrD7chgXTThjnOhRuEdwzWiAl4TS5LDSddhbzVmoQNXIznzfWYhVBJ MFR8TfxbYYRZW8pLgiJdK173eCY6e8fcpFDmenQZbE5NhDuI5TYgg15tdPlB4/sAMPXM VFvQ== X-Forwarded-Encrypted: i=1; AJvYcCXS8kD+3TSsxFK06yx35kAdPLzU8cEG5Ov8epGU4u6wtaNDNcI1tC5U1+tJm5GR8M7AgQvihciW5kkxtL+cezqJrgBuL+jYP9Ls X-Gm-Message-State: AOJu0Yx3GjavrwyQaEP4dgg+JHbUBfHZzwegaDlqaBURPu9D19H2i2Nb 5alvgEi95BNLM2TIRxzWOO5PCKxfUVLEMQcJnv5xX//7ChDFBHsT X-Google-Smtp-Source: AGHT+IFTNUeHdXYPj8pbD7YU1afPd4KdInabkTeJfTJBkzW6hlV74ZuuqnjWeSkhkwDRPzi4i8o2Vg== X-Received: by 2002:a05:6870:1685:b0:220:b839:4bb0 with SMTP id j5-20020a056870168500b00220b8394bb0mr9729874oae.19.1710222976671; Mon, 11 Mar 2024 22:56:16 -0700 (PDT) Received: from petra.lan ([2607:fa18:9ffd::d95]) by smtp.gmail.com with ESMTPSA id k30-20020aa79d1e000000b006e65720e892sm5448898pfp.94.2024.03.11.22.56.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 22:56:16 -0700 (PDT) From: Alex Henrie To: linux-parport@lists.infradead.org, linux-usb@vger.kernel.org, sudipm.mukherjee@gmail.com, johan@kernel.org, daniel@gimpelevich.san-francisco.ca.us, hkzlabnet@gmail.com, reboots@g-cipher.net, mike@trausch.us Cc: Alex Henrie Subject: [PATCH 6/7] usb: misc: uss720: add support for another variant of the Belkin F5U002 Date: Mon, 11 Mar 2024 23:50:31 -0600 Message-ID: <20240312055350.205878-6-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240312055350.205878-1-alexhenrie24@gmail.com> References: <20240312055350.205878-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This device is a gray USB parallel port adapter with "F5U002" imprinted on the plastic and a sticker that says both "F5U002" and "P80453-A". It's identified in lsusb as "05ab:1001 In-System Design BAYI Printer Class Support". It's subtly different from the other gray cable I have that has "F5U002 Rev 2" and "P80453-B" on its sticker and device ID 050d:0002. The uss720 driver appears to work flawlessly with this device, although the device evidently does not support ECP. Signed-off-by: Alex Henrie --- drivers/usb/misc/uss720.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index 15cafc7dfd22..5803919d7cc4 100644 --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -693,7 +693,7 @@ static int uss720_probe(struct usb_interface *intf, interface = intf->cur_altsetting; - if (interface->desc.bNumEndpoints < 3) { + if (interface->desc.bNumEndpoints < 2) { usb_put_dev(usbdev); return -ENODEV; } @@ -719,7 +719,9 @@ static int uss720_probe(struct usb_interface *intf, priv->pp = pp; pp->private_data = priv; - pp->modes = PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP | PARPORT_MODE_ECP | PARPORT_MODE_COMPAT; + pp->modes = PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP | PARPORT_MODE_COMPAT; + if (interface->desc.bNumEndpoints >= 3) + pp->modes |= PARPORT_MODE_ECP; pp->dev = &usbdev->dev; /* set the USS720 control register to manual mode, no ECP compression, enable all ints */ @@ -774,6 +776,7 @@ static const struct usb_device_id uss720_table[] = { { USB_DEVICE(0x050d, 0x1202) }, /* Belkin F5U120-PC */ { USB_DEVICE(0x0557, 0x2001) }, { USB_DEVICE(0x05ab, 0x0002) }, /* Belkin F5U002 ISD-101 */ + { USB_DEVICE(0x05ab, 0x1001) }, /* Belkin F5U002 P80453-A */ { USB_DEVICE(0x06c6, 0x0100) }, /* Infowave ISD-103 */ { USB_DEVICE(0x0729, 0x1284) }, { USB_DEVICE(0x1293, 0x0002) }, From patchwork Tue Mar 12 05:50:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13589530 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 661843FB87 for ; Tue, 12 Mar 2024 05:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222979; cv=none; b=NuOBJAEhlej8TU6w7tv/rxT64ISWtMXo/ig7avunmsK6eSHAdlVjdBoL7HBsuPd/ZrStn4rBCg+Ut2obIQApsSIq2ZfWpgVPtVFE952SglhTjRq7E5DDveUY2sNh9Hdf2VnyhaTNm17gmwQmcbIKwPOwrX9+L+NVS2dxv3qg7HE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710222979; c=relaxed/simple; bh=GcGEJYsPsh3uR61ceoiYbkA8Pkb4fKfxwPxjposDJNw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t5o9eJa09NR39cNYqe1tYW4uhsnQrS/SnNFCotu3rulze5kDqGC+0rVITHb4Nxke3C86vLhohnWQJi1Xmw/8H6lq4/sOZPy9O7RjRwQA6JsndwMmiCOQGnprZZSkmHNIjLKQCyBkmDqQRQlWNWhNJ1civq6xdQd9nHo4mk8P+Fw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D9JOr7xf; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D9JOr7xf" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6e6aaa2f02cso25777b3a.2 for ; Mon, 11 Mar 2024 22:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710222978; x=1710827778; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jLZv7VCenyNKQ2C9zwf/Bi1epoam6M6xNx1Z1DBfiM0=; b=D9JOr7xfZK+aWLUba3Dqx8dT9whUCGSOUXS/86OQI4lco4/ZvqZSlXbAWEbubgpgKP kvNPSpWwTc9Xdc7wbsNExJNbrovUUmWUDcqLx3qKOwzW3/XY4GBxIW9EONxijWxYW14E f9NwsFM1XWxEYSJoCqi90J4XWyaB3E/W/sGErJld37RsOAN0E3KNaEs0VdlmfnR5x3hg mGDxpBGn6FSjXS6xLnOl20BQvvkq6lnsnbbLDNZt9CdTVOQoCj3CgPCrBMa+RJsUzlXz aZlpPOO+vE51V9pO1GWHlF8PqweNeXrrqC0jkoElnrBknl8WVl0VsTQYPFYXz0CNP8DH xQrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710222978; x=1710827778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jLZv7VCenyNKQ2C9zwf/Bi1epoam6M6xNx1Z1DBfiM0=; b=KbUBA1y6VULEgiZpi3+NN90NyNxmcO4l9VVHtAj2NZ2RlFxkcH9tO2hthaMclWwg9W LgKQpNn1EiVnhygTYohvy8pMIBdVxFIKQEsNBZGQD/6A0MDUjqKdpDuETqtUy/EZKl79 psZVXBYlgf+itf71WFJbrhvmVnUmJ7lm5WrzW8RDm7p3VCoFsumA5lI/HYHEZG9PIVB4 2RWMQxD+JdQlSROmZ9GAjiuiJ2gIYUS1WDrGcDeB7pW42BwIIKU7MQaSK2u70m6WL8Qh BUud3qZCQckj1i87IM91YOysUqNCJ9LWAfkFeRUj3AEBtUg/sb+yGRNskxKgVNsEWbGi JVTg== X-Forwarded-Encrypted: i=1; AJvYcCUdnre3JwH2nSteRkOKtnX4X0okGETDArWlhsnPqgLbn5FW6WPidpflXhE9ZKZoBsN2Kv/oG3BsBJvyPmUi/qQNU1pruDZ0VMQJ X-Gm-Message-State: AOJu0Yz21BkDkSXFPtDe+mbm3rqLnhq0es7YuIUrWA+1Op7O1xcMFQ6u RXp2ZQ/kyDseddg4d3NOJHr7HaoJ+c2sQQzdFb95Uv7C3SUJ7k2W X-Google-Smtp-Source: AGHT+IHkWbaDI2E6x3C5rP5FbpAv0qrTyRf4uYYyX7KjmKb//KoCNhTf41tTtcJ7kA81bVUndvFypQ== X-Received: by 2002:a62:5347:0:b0:6e6:8b59:1bad with SMTP id h68-20020a625347000000b006e68b591badmr5731778pfb.25.1710222977585; Mon, 11 Mar 2024 22:56:17 -0700 (PDT) Received: from petra.lan ([2607:fa18:9ffd::d95]) by smtp.gmail.com with ESMTPSA id k30-20020aa79d1e000000b006e65720e892sm5448898pfp.94.2024.03.11.22.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 22:56:17 -0700 (PDT) From: Alex Henrie To: linux-parport@lists.infradead.org, linux-usb@vger.kernel.org, sudipm.mukherjee@gmail.com, johan@kernel.org, daniel@gimpelevich.san-francisco.ca.us, hkzlabnet@gmail.com, reboots@g-cipher.net, mike@trausch.us Cc: Alex Henrie Subject: [PATCH 7/7] usb: misc: uss720: check for incompatible versions of the Belkin F5U002 Date: Mon, 11 Mar 2024 23:50:32 -0600 Message-ID: <20240312055350.205878-7-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240312055350.205878-1-alexhenrie24@gmail.com> References: <20240312055350.205878-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The incompatible device in my possession has a sticker that says "F5U002 Rev 2" and "P80453-B", and lsusb identifies it as "050d:0002 Belkin Components IEEE-1284 Controller". There is a bug report from 2007 from Michael Trausch who was seeing the exact same errors that I saw in 2024 trying to use this cable. Link: https://lore.kernel.org/all/46DE5830.9060401@trausch.us/ Signed-off-by: Alex Henrie --- drivers/usb/misc/uss720.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index 5803919d7cc4..0ad2bfc6af78 100644 --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -677,7 +677,7 @@ static int uss720_probe(struct usb_interface *intf, struct parport_uss720_private *priv; struct parport *pp; unsigned char reg; - int i; + int ret; dev_dbg(&intf->dev, "probe: vendor id 0x%x, device id 0x%x\n", le16_to_cpu(usbdev->descriptor.idVendor), @@ -688,8 +688,8 @@ static int uss720_probe(struct usb_interface *intf, usb_put_dev(usbdev); return -ENODEV; } - i = usb_set_interface(usbdev, intf->altsetting->desc.bInterfaceNumber, 2); - dev_dbg(&intf->dev, "set interface result %d\n", i); + ret = usb_set_interface(usbdev, intf->altsetting->desc.bInterfaceNumber, 2); + dev_dbg(&intf->dev, "set interface result %d\n", ret); interface = intf->cur_altsetting; @@ -728,12 +728,18 @@ static int uss720_probe(struct usb_interface *intf, set_1284_register(pp, 7, 0x00, GFP_KERNEL); set_1284_register(pp, 6, 0x30, GFP_KERNEL); /* PS/2 mode */ set_1284_register(pp, 2, 0x0c, GFP_KERNEL); - /* debugging */ - get_1284_register(pp, 0, ®, GFP_KERNEL); + + /* The Belkin F5U002 Rev 2 P80453-B USB parallel port adapter shares the + * device ID 050d:0002 with some other device that works with this + * driver, but it itself does not. Detect and handle the bad cable + * here. */ + ret = get_1284_register(pp, 0, ®, GFP_KERNEL); dev_dbg(&intf->dev, "reg: %7ph\n", priv->reg); + if (ret < 0) + return ret; - i = usb_find_last_int_in_endpoint(interface, &epd); - if (!i) { + ret = usb_find_last_int_in_endpoint(interface, &epd); + if (!ret) { dev_dbg(&intf->dev, "epaddr %d interval %d\n", epd->bEndpointAddress, epd->bInterval); }