From patchwork Thu Feb 21 17:29:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 10824429 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 91E12922 for ; Thu, 21 Feb 2019 17:30:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7AF6631FFB for ; Thu, 21 Feb 2019 17:30:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7870531F08; Thu, 21 Feb 2019 17:30:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1184431F9B for ; Thu, 21 Feb 2019 17:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I+Ux23FNKXUduG3Av217JN1LavBB59KRBRDvqzX1Up8=; b=XSyO7xGJGzfrlF DiD9hW7cOA8nhw+Lon16T/QgivoBLG2vRn21XGFv/fPkSWm+B6Zw/S+2k6fqe+8IeGo1OWCsd1R4k gwN8i8s6iLLC5ZsgFUffUXCmRGZsyY167tCG6HqxFKjfvcchBzTvbya+q7hIIlU6AWC1zVkwXvdHx iUtJhjrHblTRXJq8PB2VPp/kbUSKqZ1TB/YbJky1ntcl8g8oP7Yhk2FDGrMf/wLEgsJukIufRlwmr q9XsVG+elRD9RuSvldWs95ZPWRuo5rK2mCk6EhzgAzGvipi0Fd1yVaFDbhTK3PxMRGeBuZ781O22P VgoaN+g0UB6aLAabX56g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwsAz-0004Vv-VK; Thu, 21 Feb 2019 17:30:25 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwsAw-0004VJ-Hl for ath10k@lists.infradead.org; Thu, 21 Feb 2019 17:30:24 +0000 Received: by mail-ed1-f65.google.com with SMTP id j89so14434841edb.9 for ; Thu, 21 Feb 2019 09:30:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KQS74oJ+S455vNozkBMijYenWjVSejJHEX8dpzVy3n0=; b=Ejpz51nrs8/kMd1EDNWiTToN3yIwTiV8hOkTjOfmHsbJRYMx1wBbuzpyd6U5mLfpaP Zn0rJf9y7xg/5+iMaaPzJkSs49eYKQNhZVVIw6Uu4Efy3R6sGueUfmRCbSh4Uf/8KYp9 xZ+duUF+3ewV/ZGfsb/7QcRCT1EmRnblaacQsRgn4soEgxhn9hS681BVHckEsQeK7AQk C6F9Agjhy7sGvbkqgOzxACFuo7dvR0wVeFDcvJktTHPqtjT/fl2JXQ+TYFgQjov1YTV4 cYqfyO3CJSaMhy1RjCV4S3YFrrR6PyFS05zh7L0JTOe7ZO/Qqblpj1Zv8eooBv47AWtP +gkQ== X-Gm-Message-State: AHQUAuZNPcLiIikLh/iITVY2hw8IhujxxogoT5QRZIPiggg5jcQo2UiM ZzskwIZIxmLjfQE5c2vMRGwn7Q== X-Google-Smtp-Source: AHgI3Iby8nV7qPfhZJpa6ZfGC9KB70vdWejUcyXS2QF/B9AiYvl7xoZrph7QXVs08jDfQXpLSCaoHg== X-Received: by 2002:a50:d55a:: with SMTP id f26mr16507907edj.292.1550770220646; Thu, 21 Feb 2019 09:30:20 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id ay21sm3413366ejb.0.2019.02.21.09.30.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 09:30:19 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 7E49B1803B8; Thu, 21 Feb 2019 18:30:19 +0100 (CET) From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: linux-wireless@vger.kernel.org Subject: [PATCH] mac80211: Change default tx_sk_pacing_shift to 7 Date: Thu, 21 Feb 2019 18:29:36 +0100 Message-Id: <20190221172936.21816-1-toke@redhat.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87d0nlhxl9.fsf@toke.dk> References: <87d0nlhxl9.fsf@toke.dk> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190221_093022_583105_27B4233A X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kan Yan , wgong@qti.qualcomm.com, =?utf-8?q?Toke_H?= =?utf-8?q?=C3=B8iland-J=C3=B8rgensen?= , ath10k@lists.infradead.org, Grant Grundler , wgong@codeaurora.org, Ben Greear , Johannes Berg , Kalle Valo Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When we did the original tests for the optimal value of sk_pacing_shift, we came up with 6 ms of buffering as the default. Sadly, 6 is not a power of two, so when picking the shift value I erred on the size of less buffering and picked 4 ms instead of 8. This was probably wrong; those 2 ms of extra buffering makes a larger difference than I thought. So, change the default pacing shift to 7, which corresponds to 8 ms of buffering. The point of diminishing returns really kicks in after 8 ms, and so having this as a default should cut down on the need for extensive per-device testing and overrides needed in the drivers. Signed-off-by: Toke Høiland-Jørgensen --- net/mac80211/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/mac80211/main.c b/net/mac80211/main.c index 5055aeba5c5a..800e67615e2a 100644 --- a/net/mac80211/main.c +++ b/net/mac80211/main.c @@ -617,13 +617,13 @@ struct ieee80211_hw *ieee80211_alloc_hw_nm(size_t priv_data_len, * We need a bit of data queued to build aggregates properly, so * instruct the TCP stack to allow more than a single ms of data * to be queued in the stack. The value is a bit-shift of 1 - * second, so 8 is ~4ms of queued data. Only affects local TCP + * second, so 7 is ~8ms of queued data. Only affects local TCP * sockets. * This is the default, anyhow - drivers may need to override it * for local reasons (longer buffers, longer completion time, or * similar). */ - local->hw.tx_sk_pacing_shift = 8; + local->hw.tx_sk_pacing_shift = 7; /* set up some defaults */ local->hw.queues = 1;