From patchwork Sun Mar 17 00:39:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 13594490 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB345C54E68 for ; Sun, 17 Mar 2024 00:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=b8bRVVmb5XluzyAA+JgEIDloEyheOpntKOm+7p3K4mA=; b=3w9EcNrHVJklOO SanloQ5TGhsadpxxSy1XDx3A27QMKX2vxUnLs4VPcgvgCZH/bsf1VuqtOuOMCL7/mmRK/c7GLvO0t 4UQ8y6W/ZABU/Z5R7RYi+M/dNyMrzb5+trHVOrv6ilr5PrRlevx9MObIGTEtZfN2oEDgJYDa/zM/l WwjkXqhW71h9ID3aFeGxZZJw+NNplNO5bilq2kOTVNIDO6Td/vvyLKhlRj+wzBxD/VVezHbsTVdU1 CdVKtv4f6+7rGr3yuWR5mqPTNnl7flMIAQ7NQGjGMkdqicsufDW6JIDu9Qzv4JVfX39NvcfpUnIP6 TX36YpVMupsMSDyo4sbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rleb4-000000048rE-02fu; Sun, 17 Mar 2024 00:41:54 +0000 Received: from a.peacevolution.org ([206.189.193.133]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rleb0-000000048qB-3DF6 for linux-arm-kernel@lists.infradead.org; Sun, 17 Mar 2024 00:41:52 +0000 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id 85B1D47565; Sun, 17 Mar 2024 00:41:44 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Pavel Machek , devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, Jernej Skrabec , Miles Alan , Samuel Holland , linux-arm-kernel@lists.infradead.org, Ondrej Jirman , Aren Moynihan Subject: [PATCH v3 1/2] arm64: dts: allwinner: pinephone: Retain LEDs state in suspend Date: Sat, 16 Mar 2024 20:39:28 -0400 Message-ID: <20240317004116.1473967-1-aren@peacevolution.org> MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spamd-Bar: ++++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1710636105; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding; bh=F3bSG+mqyiDBJJBU+WfFQefVpoTTbxWAEd15u4S7jEo=; b=NYDKb5fVA5FZXLWv6gQh/vg6NQD63TxJURhfsrCpIO40V5kxA8VEHm15bryWhGXxFahRcG 5fNTu82ePrqrlEvFUalZwmJ3A5pv9UvgjOjsCDL20Te/jq1AAaUCe5pNGYxviKojtAsG+3 bmBVnjKdCuNQ8ilEZ4fBR13ZfF7s2cY= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240316_174151_055469_5C28C3DA X-CRM114-Status: UNSURE ( 7.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Miles Alan Allows user to set a LED before entering suspend to know that the phone is still on (or could be used for notifications etc). Signed-off-by: Miles Alan Signed-off-by: Ondrej Jirman Signed-off-by: Aren Moynihan Reviewed-by: Jernej Skrabec --- The previous revision can be found at: https://lore.kernel.org/lkml/20240206185400.596979-1-aren@peacevolution.org/ (no changes since v1) arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index 87847116ab6d..ad2476ee01e4 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -43,18 +43,21 @@ led-0 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ + retain-state-suspended; }; led-1 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ + retain-state-suspended; }; led-2 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ + retain-state-suspended; }; }; From patchwork Sun Mar 17 00:39:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aren X-Patchwork-Id: 13594489 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 097D1C54E68 for ; Sun, 17 Mar 2024 00:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F+IpWyNc3Q3u6Kvvn2i94U8nv3peVhbMDYgPi0XvVOc=; b=HzbXkDQ9C7as8o DBqMztt0LGoWovesHIAlNjvltusZY0TzrRRCV74O2ZTDD0acpwdZHKZuAYnEP/xZXgnZxONb93UXB 4zdQLLun4ytoMwgMHh3p4GYZnPOFa2EwKFXGiuvAFVAh024Ps7O6tCdYghJdAet6Vl7JO+JWyocMP MlLbu/lD1bVANDXHkOmRv/3EaZUSaz6XTNXbPAyqyoOZb72lhEd0nz697QEzD2/a4IMxw/VKCFLE9 wIqYQNUUC9iWGg+sxXFO/l3Dx78BHdQnMYqL9SUqX3yWH6qeuorgzTKP9pRjdyvarC9LXBzaDSUAV VJD+0wwK0G1f78x4X6Fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rleb9-000000048sA-1Op9; Sun, 17 Mar 2024 00:41:59 +0000 Received: from a.peacevolution.org ([206.189.193.133]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rleb1-000000048qj-3lNe for linux-arm-kernel@lists.infradead.org; Sun, 17 Mar 2024 00:41:53 +0000 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id 1B236476D2; Sun, 17 Mar 2024 00:41:50 +0000 (UTC) From: Aren Moynihan To: linux-kernel@vger.kernel.org Cc: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Pavel Machek , devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, Jernej Skrabec , Miles Alan , Samuel Holland , linux-arm-kernel@lists.infradead.org, Ondrej Jirman , Aren Moynihan Subject: [PATCH v3 2/2] arm64: dts: allwinner: pinephone: add multicolor LED node Date: Sat, 16 Mar 2024 20:39:29 -0400 Message-ID: <20240317004116.1473967-2-aren@peacevolution.org> In-Reply-To: <20240317004116.1473967-1-aren@peacevolution.org> References: <20240317004116.1473967-1-aren@peacevolution.org> MIME-Version: 1.0 Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org X-Spamd-Bar: ++ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1710636110; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding:in-reply-to:references; bh=xSOAE2dp6I0YHMlx6m2sMD8XK0nU8r7fXdBHcrqXIZg=; b=U1SmSei6V/eleikJbTa48p9hT9eUF/zGGwo+Nx07oMdsUjkVsF70VRl5zN9TpJgxxRh/lR QyMf9fmyxC5ywlw2CwTUY/1o2+MlfJS0zKDlYspqNiDVfg+MPlqprjs9EaLtqn78cNGBAV 13g2uP6W0FzatNR/y7IEgQM/DkjGASg= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240316_174152_059660_615C0B6C X-CRM114-Status: UNSURE ( 9.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The red, green, and blue LEDs currently in the device tree represent a single RGB LED on the front of the PinePhone. Signed-off-by: Aren Moynihan Acked-by: Jernej Skrabec --- Changes in v3: - add function property back to individual LED nodes to minimize breaking changes Changes in v2: - remove function property from individual LED nodes .../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index ad2476ee01e4..6eab61a12cd8 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi @@ -39,21 +39,21 @@ chosen { leds { compatible = "gpio-leds"; - led-0 { + led0: led-0 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ retain-state-suspended; }; - led-1 { + led1: led-1 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ retain-state-suspended; }; - led-2 { + led2: led-2 { function = LED_FUNCTION_INDICATOR; color = ; gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ @@ -61,6 +61,13 @@ led-2 { }; }; + multi-led { + compatible = "leds-group-multicolor"; + color = ; + function = LED_FUNCTION_INDICATOR; + leds = <&led0>, <&led1>, <&led2>; + }; + reg_ps: ps-regulator { compatible = "regulator-fixed"; regulator-name = "ps";