From patchwork Mon Mar 18 09:48:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13595167 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2075.outbound.protection.outlook.com [40.107.237.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 854B82D602; Mon, 18 Mar 2024 09:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755339; cv=fail; b=ZBAihyFEq2RU8dyyOIA7m20/RBJcT811KKwA72E8Mf88LaSYg/aiN7xg3t5TWzOwYkz/vqCCr/LbRYQGmWBnCfzDaWjIhobxafk+4/RsgXqF1i6lLBbFXb9Bh1NpIOHkLzycsfjfHhE5GV90qrOomqeiGzzHX+MmEw9RWPoejX0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755339; c=relaxed/simple; bh=xY6iItlNZSZwjBPo++PcdILljkhv1E1HSvYll/18NBc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pk8g0OT2XndaHvherD0n3ByxvqIEFZYT2cpq8AsR6sntRaGlwg0+6MCtsQwQgXyhOlGEZg/HjNBYAlVzFGf/9DMhTyHhpgnoAE/xkUuVe/piCukKLHgiQF5o726TsxAFzZOt3tiI6FmA2X4SYhQGokCFTrkZ0n9xOcEdYO70/6s= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=pgxvIJIX; arc=fail smtp.client-ip=40.107.237.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="pgxvIJIX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ANeGlfktCOykY1k4hi4y4G4LY9QQpMe8GHQhYgL4tt8LAAlsDoJAyxLTgrDa2h5uZsttwzxpYERGtuZaQGdWKfmFfQ0fMl5EZgSEmjTu+TaWWCkzNrCjzkvV+eGtpYuOPfvs4Pe7/PObLSrntLuNRVRMPftYQyrDpNESX4XLyeO8gEKAoVlf/zqdDFEeN+O2vrpv+nvtY+fB4Laf1xraRgYm11ptd0e8QNX4DZ9N6oS37vzvEEVv7PXi9LVM0se9XVOZ84krUDBiYqaEF5hE6TeoVvAEnQ3uvwCE2V1PI3+VoyuVh3w7QDRwLmHCHKrZaJmJeT46Zp4Y82gO2KavOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R/PGnTtqjWsCA7SmW4CIaekSpMtRb7qW9NwgjPgDWws=; b=fe3TMKJFXbdataCZgi/n5Os1jt+eBaucinXlcPd0GllmG/pykobaRyFcNn1hBdxxfp0n3AkPcOs8gzuxmCO8iOttzcziRPSitj2GwOD2F9Lj8wyveEDeOCP5klbAMrKeJtJVOsEZoaJ02J+Iws1D3yIuO2c6B6Z2cmQbZKgIxILU9NUDO1i4Eq+wPlIO95SwGLNZKpKpUK11nxBTGMrkkpJYBKzkQvP3HCHCCQuIWWDSgMNyvvB6a0MT7A5srvPq3/h9kbY1RNlC6WXV+vX3RP5uaeqizvXM0UG2/TVVOKuW6ljjScrRcbFpirXD8fwXUS5iTZ+GLx/+8hBhFTux7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R/PGnTtqjWsCA7SmW4CIaekSpMtRb7qW9NwgjPgDWws=; b=pgxvIJIXYHvP29rU0lVDzD/dcmZjeCR5D6B4ePhFn4I7vbl9yU7tFt/yoOtgAnPPskFPxgc2+JLBcJTSIatvdND9jOQfYSLrMfwVs1qQONep+/ah0WXSPq4avxw6hrhpFKZRTB8FF63JRJ6owTEgKmqSDpXalHCBOns9bNk+qqc= Received: from SN6PR05CA0005.namprd05.prod.outlook.com (2603:10b6:805:de::18) by DM6PR12MB4298.namprd12.prod.outlook.com (2603:10b6:5:21e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26; Mon, 18 Mar 2024 09:48:54 +0000 Received: from SA2PEPF0000150B.namprd04.prod.outlook.com (2603:10b6:805:de:cafe::22) by SN6PR05CA0005.outlook.office365.com (2603:10b6:805:de::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.12 via Frontend Transport; Mon, 18 Mar 2024 09:48:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF0000150B.mail.protection.outlook.com (10.167.242.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Mon, 18 Mar 2024 09:48:54 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Mar 2024 04:48:51 -0500 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v8 1/8] cpufreq: amd-pstate: Document *_limit_* fields in struct amd_cpudata Date: Mon, 18 Mar 2024 17:48:20 +0800 Message-ID: <0988fb808bf358c98f6ae8ad8f65cb0c7e1129b3.1710754409.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF0000150B:EE_|DM6PR12MB4298:EE_ X-MS-Office365-Filtering-Correlation-Id: 32430c6f-0a8e-433c-839b-08dc47309fc9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AhwKV2IYD8ciJ5ZwJmI3bowXI/C48uyg4WMIu7oC/dahMcw5AO6YtHP9zDWmkJEJd8lBNE7d45qU9SBxMdr68td3m482wec66WHQSeXFfIHI2ZmBcoOJsebGGonJ5a/5GEjH0BRlMDXnhmjTeGcTXc0ogazgwVCLKv4Z9fN5TL0NupqkhJ9WBvHrjjLVpwZX8cRGJ9zlB/HwA3TuQQcl5E1xq1/IGsk0pL0b+5GJyFhubWNQCyO/rwnKfcUWrbHsvhcfnihODWhHIXXg3NJuAd4lVK7LdriGpGhjHfI33orpreP4BZnBjrDwe8puikHRFRcD/luuAQZRGWNDb8BVR+rKpqAoLz1T6LMbDXKTf0K4G+GprHt1U0WsFzYsBYn95H7JZWtC5l1QEAIn7zve4Bos0vo7M3yfU0RJfNmqSmBX7QKomZpm6x20nKe8K1lMHII0b5FHaazlIkmsu75rsyZt2LdNR3agf/tg5kwoXWW5BX4ECPmGcDvBy1dnUKVIEenBIagJAP1LKHDaUI6+HP2vaHdZf3biC6gY8lT6ehWkLE5NVpwrJ4dDmRy11x/tEE7KRYh+bLZKfAuDOYnxcWD5p4Zv2A2usDmwA0MooZMUa1Q9XElknPhGDH+MuWY6eqJy3RKrk7Kg74+fZo8Fck27xJD6k7oLw0N7X++IiFOxd65uxM2tkL/2vMCjoC5fkSuGy+waY+XCgW+ZdYcbJGD/uFk4z3f30ts7Jr3tb6FLKPYoU2CSTun70BxuBUDo X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(1800799015)(376005)(82310400014)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 09:48:54.3928 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 32430c6f-0a8e-433c-839b-08dc47309fc9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF0000150B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4298 From: "Gautham R. Shenoy" Signed-off-by: Gautham R. Shenoy --- include/linux/amd-pstate.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index d21838835abd..212f377d615b 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -49,6 +49,10 @@ struct amd_aperf_mperf { * @lowest_perf: the absolute lowest performance level of the processor * @prefcore_ranking: the preferred core ranking, the higher value indicates a higher * priority. + * @min_limit_perf: Cached value of the perf corresponding to policy->min + * @max_limit_perf: Cached value of the perf corresponding to policy->max + * @min_limit_freq: Cached value of policy->min + * @max_limit_freq: Cached value of policy->max * @max_freq: the frequency that mapped to highest_perf * @min_freq: the frequency that mapped to lowest_perf * @nominal_freq: the frequency that mapped to nominal_perf From patchwork Mon Mar 18 09:48:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13595168 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2046.outbound.protection.outlook.com [40.107.102.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2226D2D022; Mon, 18 Mar 2024 09:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.102.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755344; cv=fail; b=rJTiju3mGqXulQUcYjmvKcrNq2bl0kph93UskQ3StPUOt+fvVmVvWwc/I49c5gphId78RMHNmhwRogOHTlbpvV6CIObbmujr7qjY+NrH6/huqvhSyo1fygnDNYkobIyTQ+FXg4vBiL8kuiqY4kkGfQQrvzbFuQ7fJ8yrlWru/cc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755344; c=relaxed/simple; bh=U+K/qwnVOCrghpyem5JUVBbl9CjG8kDY+HdY/Y8+yjQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=A17i80y5SZadaOyD3ZWaaer4UfaMIiCJNGWzAc0BQzjNwQTqkwktxvy23Rp1gZWy0Ug4U7J5BZgL44hMVAF9rwqfE0KmAnCr7w75z8qbghzIQ2JjZPDgUzkbSkgov/zeKaqpJA75ztJETqyGoixmo9p4ohStL/OsNT2AW5JJsBM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=fZyWplBr; arc=fail smtp.client-ip=40.107.102.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="fZyWplBr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Urq+9OsgziYK5xCMGCe3KqmXXAuTi0Et38ltekQDpZnePuCGRri75Kf+Shkv4kSe5mHScrxAXvhCiFuTi5XbGB651ub/qy6BOft6FroxR91jYlqKuiKVF1TsrmgfNqrtxwTF4T0hDCrYJJAmNv+CwgTjtl6nx6EAflgL5tNxt+syVaWtRDYm9IBHXdnGQ1oVbNkqB1AFURwKmbihmNf0Vsvq5d2M/JBCf2ayBXkqjG2VWIj1T6SVhcp/i2bl+M5x9dB3RKTRxqwt1PwlnB27VPMP2U4otgdm9YtJ9rSRaWk/iTwY/pQVTnFXJ9hy5Mi3r8BGzHhJxNxQqPM0YNN1Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qCxHw6EK+/fYuVDkckQOZin+iabU1nr2iRwfudvqNww=; b=lFXpaQhINgNeiJm1Ka621g/oEjGDi5m0OAjLlze19ROBwYyA4ymujTZOTd9jZ8jm0do9aZTc0kWBFj0gLeuw1WKzbisREVHP/EHQobAS18IHUIed8Mn6PgzF3ZARmdN798qNQ0ZJWTQPdo7lremBZw5IjNIic06xKnv6dUEOaqXBc7yn4sUrTj8ZVCkPNY0iFXiCauindx2yJXoM7Z/uHx5lVAuWzK0gh9vaO7CnllLWNtw3z+1fyt6Cz1C5OSersNq8P8Q7GBCj0U3AQ+mVCIWEE8wYnGdBFiEF0UPGa/zRCVeU7oWclNgKJKWv3Crzszp9YibVZRvDd/NtzTQDdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qCxHw6EK+/fYuVDkckQOZin+iabU1nr2iRwfudvqNww=; b=fZyWplBrPXTBQxxKz6fHMyonxnqYOGqtLmVvDetS0jk815w+YpuUrpxBe4j09BGLInzFtaQOrC+zmDjIg0TgArtL33w5oYBpkN9PvJr1DMUTqsuU+ZBcoojo5uQKQBZ7bhEyockFNEeTvUOj/kJ5mB8k0Z7E5q+bpie6dBQ0H8E= Received: from SN6PR05CA0017.namprd05.prod.outlook.com (2603:10b6:805:de::30) by IA0PR12MB9048.namprd12.prod.outlook.com (2603:10b6:208:408::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26; Mon, 18 Mar 2024 09:48:57 +0000 Received: from SA2PEPF0000150B.namprd04.prod.outlook.com (2603:10b6:805:de:cafe::d6) by SN6PR05CA0017.outlook.office365.com (2603:10b6:805:de::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.11 via Frontend Transport; Mon, 18 Mar 2024 09:48:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF0000150B.mail.protection.outlook.com (10.167.242.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Mon, 18 Mar 2024 09:48:57 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Mar 2024 04:48:54 -0500 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v8 2/8] cpufreq: amd-pstate: Document the units for freq variables in amd_cpudata Date: Mon, 18 Mar 2024 17:48:21 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF0000150B:EE_|IA0PR12MB9048:EE_ X-MS-Office365-Filtering-Correlation-Id: b31e9d15-f82c-4b2e-94a8-08dc4730a1a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uEgo1EvoscPykm5NRFgF2C0ngI2FQd+Boq3v+6GN9HDFtfq//0Ykb5N+1PN/1LgEIMAfTg67Qd0ih5iD31/yA3M4vbiO4+LD2D/O8yCRAA4F3jSOhRjoQ1X3b/M7ZFRA6lLSjZJJVRMN4X5N6b7lF1EWhXvFum4omOtoRVZgGy6gbw6FX6OnrQ93DTnAFLdDkBZUzeKGmZCEMohO5Bv1IzDIohClOLLoz9wd8wf0vHfjVtrc6lKF+uaLB0al+IlhBd+FMFeFn5tnfMex+4N7uCLrgVmtNOcjawTvS7BcYqLwpCncahe0NLst/Y32XnJR/pLP8uJyDQd6yNMKMm2Uhnv7GLq/DTqjqKk01TsEKqRR1mZFXcD2Qw/raaf880gHBGT+MVtnukoL9k6DwgItKhvzLP2BmZqIauMw2eMdbjX3FcrJOGcOG+GSuiz2SLHrtyWHMc5Q19/YAWh2+cFjOJ7tDLcN6UWco3vgA9YaJ2h8pcC+aNj4mSRCQR0iNGp6uq643nUPzeFXZOrzWa5LhOcuLDyYfJoCo8d7z4+V8EvAGdzvio8EV9dHPBEA25O5h3DfBN2aazKfx0laFDZrYTzZkdUZzvwxVDMgUwavf072eZDzV9IHQV+z6cdrQK6lAFTsSduVjJgPC2Il3noDiqOp9MeSBLNj5k6yNvVK9hdLyw0zePb+fhcjOdnCZJtFb2olgrdx+2ySSP+Jrr9mRCXQRtRt+4VW2QZmY6VK2fHi1t+Xd3h+fNwnVus+FmF7 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(1800799015)(36860700004)(82310400014)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 09:48:57.5022 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b31e9d15-f82c-4b2e-94a8-08dc4730a1a1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF0000150B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB9048 From: "Gautham R. Shenoy" Signed-off-by: Gautham R. Shenoy --- include/linux/amd-pstate.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index 212f377d615b..ab7e82533718 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -51,15 +51,15 @@ struct amd_aperf_mperf { * priority. * @min_limit_perf: Cached value of the perf corresponding to policy->min * @max_limit_perf: Cached value of the perf corresponding to policy->max - * @min_limit_freq: Cached value of policy->min - * @max_limit_freq: Cached value of policy->max - * @max_freq: the frequency that mapped to highest_perf - * @min_freq: the frequency that mapped to lowest_perf - * @nominal_freq: the frequency that mapped to nominal_perf - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf + * @min_limit_freq: Cached value of policy->min (in khz) + * @max_limit_freq: Cached value of policy->max (in khz) + * @max_freq: the frequency (in khz) that mapped to highest_perf + * @min_freq: the frequency (in khz) that mapped to lowest_perf + * @nominal_freq: the frequency (in khz) that mapped to nominal_perf + * @lowest_nonlinear_freq: the frequency (in khz) that mapped to lowest_nonlinear_perf * @cur: Difference of Aperf/Mperf/tsc count between last and current sample * @prev: Last Aperf/Mperf/tsc count value read from register - * @freq: current cpu frequency value + * @freq: current cpu frequency value (in khz) * @boost_supported: check whether the Processor or SBIOS supports boost mode * @hw_prefcore: check whether HW supports preferred core featue. * Only when hw_prefcore and early prefcore param are true, From patchwork Mon Mar 18 09:48:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13595169 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2084.outbound.protection.outlook.com [40.107.237.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5157328DB; Mon, 18 Mar 2024 09:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755345; cv=fail; b=sXEiz7gV7Skn5J+eRT/TZt5CSxVX6dp0ePFJhOzgei9CdwkWyrlSZ+AIjklltITdfUrDNbLvvdeE/CQjWG/pgdk8Hpz277m95dSdTuBY7mbGZcmGWousDmnYtEVz7BUyXAZAjrAHzUfWC97TiFOmSHJ9fnrFvtYBqrlxUZx64a4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755345; c=relaxed/simple; bh=LcRr8DeueLzGoEQunzbWIpPZ8jvhiLnpV//9mgZvbOs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ntj8DfHvOSRnJ1bZElWqo0rXAvz7RHamvSQdKNMHrfBie8d71ho5TRpmaVW1UnjRlWGvx1a0W5Y1M3uOir5vnWssImZgN3w+8sBxKb48r6ZG9Rv+zUAxW8EH7HzjxOw6uf7g9Kocbw6kh+upVjy3Qb4iPze2RDLZN/UpOyMB8G0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=eMcZwmbg; arc=fail smtp.client-ip=40.107.237.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="eMcZwmbg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYecVO16mgTHuY0yme4G8aWp5yuXfG4QGJ/ITiu5wK4+lFWihdAqKvYIshEo446vW4tDcO2SE//tK4h3Jst7StLScumww61jtj36Rhow7Tc+aBC/j3hXdCdbz697lWuHdwuK+bnYJv87/saSsmfalC/eG0xEdqkAcxDJ7782qaQ+nq3LTuVT6AtfMv9gHx5g+I0nAuzwG9sdXST9+GytVdqQuydAf98+LGC0PZM4kcAoIzJJjgj43F9tEhUgjwjBYjLq1/p8j0i4nrMi+VmCLi/DKj2cLwo8iVnxnYYpzQd2XIB9yAh0BE3pAw5C0lggsyae0x8KLnWfyrwkf6nKPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ffIckLzJ0pqOgsKzweNwlnnwjEVsVvO28Yjd1DQCXM8=; b=GGAJrV5LfY0aOUeFRWtns6+rgLG0/PElgEjn4P+t5wgN4Rwd33QVKiC+PnAbq1bOhb7LtsXbBBmQKMxrcy9UVODz9eYruRDc7i8h042RgdR/BBJZelH2/o4Vuqwh9zZfbkwZuLjWjgbIak/6mdu52oUadf9Bru/NMsSqHncW59KB0z6bY7M1+x8OCX3ok0aLb0rSrXPZGjeo9h4L1hDnagxqk/onuV5F2L/nuMplhRn7YQg3dby/9639nxMHcPndMWJBnf/fmDWoyxjjP5xTXlCLz4tWok8mVfwv605Jt2V3R/HKUWO3JhICZic+GmOeHQ6hHhE3CA/v15UcWSw5rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ffIckLzJ0pqOgsKzweNwlnnwjEVsVvO28Yjd1DQCXM8=; b=eMcZwmbg9AwOr6wqQd/3STznm1hgUPPLC+ZU4mYo5g5gPNoIXamEiClI8LnJAvEBPTCUtu1nlv4NSv6zS9o/xPmcvFhw4cd/jj99hEIKVJrQjhawVe5l2jj1A/2TbFaiG2tS53UKTTgi0uYLqw6OBNEfZHSznAJu0dgGPfCAEvA= Received: from SA9PR10CA0022.namprd10.prod.outlook.com (2603:10b6:806:a7::27) by SA0PR12MB4368.namprd12.prod.outlook.com (2603:10b6:806:9f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26; Mon, 18 Mar 2024 09:49:00 +0000 Received: from SA2PEPF00001509.namprd04.prod.outlook.com (2603:10b6:806:a7:cafe::7f) by SA9PR10CA0022.outlook.office365.com (2603:10b6:806:a7::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27 via Frontend Transport; Mon, 18 Mar 2024 09:49:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF00001509.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Mon, 18 Mar 2024 09:49:00 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Mar 2024 04:48:57 -0500 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v8 3/8] cpufreq: amd-pstate: Unify computation of {max,min,nominal,lowest_nonlinear}_freq Date: Mon, 18 Mar 2024 17:48:22 +0800 Message-ID: <9a8da1cf830867d29dfeeb0d0625858c33496f60.1710754409.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001509:EE_|SA0PR12MB4368:EE_ X-MS-Office365-Filtering-Correlation-Id: b4f504b8-6bac-4622-5752-08dc4730a37a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BbBO89SssrE7vz2+K2iF0ZTLg042tE/0Z/UpXZ9DB34R/WKJA9VxQUlgm07kgsS36blQI/RXgexrQ0ZUL2APTbN1qVp4X5OC1kZ1Pf6e46viGOnjUa+SdtZJ0GR5WLCVtFpw5UsE/TBg19mQqT1SBHKHcv6owocHflJePnSefXdxZVU1nsVk7f/ppzd3HwMeWC4dx0c6C3Qrip7MSle8EI9na9V8A22nGVjlf6scPmuloItvuOmt/xJRuHXZU0Q2+elzom2zJ9RoIZFwr+7H00Dpj1ElhxxnfpAAXK6hDQjS+Af264bQvZmNURE5+ifXD4bs7Fjwt46h2dyTX6O+QR9ush6VkOXst9RLwbVR0QarxNbYoXiwslLm5DZI25Iga/Lt0H3zo7W4+kFrDts9axs79ZLW2k8BSa8nHi9i1XFLPgAH2yb1BZ3M9BLW9VcVfdTL5HjeDCYJe0i58Ha46KJpEyi7G+IFGeRREkh+1Qr8iVFck7yz0Os7027BGzHiwwzW1OWMghuy2so1RPSRkBN7HbsVyLhWqZaFiwIlMPvSkRm9shwOwMcne//PTdt/Ut3b6/hNkZgBXIM6vcYzS5gdaKc+YfFCVGrcNgJK4KzwAwmdVrwl+meIRqfPNJZIyvInLDNigwCdZqIJZXFpluZsM9SjPsu4d5oKhgzcL6BBsGScxn0Q5FLSwM5YQQYfHc9M0KugoDHbd32mY7XkPeKMXWe3r2qyv/kRXk4aw/wvR+E7sOs7AlI+qTd29gJ2 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(82310400014)(36860700004)(1800799015)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 09:49:00.5849 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4f504b8-6bac-4622-5752-08dc4730a37a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001509.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4368 Currently the amd_get_{min, max, nominal, lowest_nonlinear}_freq() helpers computes the values of min_freq, max_freq, nominal_freq and lowest_nominal_freq respectively afresh from cppc_get_perf_caps(). This is not necessary as there are fields in cpudata to cache these values. To simplify this, add a single helper function named amd_pstate_init_freq() which computes all these frequencies at once, and caches it in cpudata. Use the cached values everywhere else in the code. Co-developed-by: Gautham R. Shenoy Signed-off-by: Gautham R. Shenoy Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 126 ++++++++++++++++------------------- 1 file changed, 59 insertions(+), 67 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 2015c9fcc3c9..ba1baa6733e6 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -606,74 +606,22 @@ static void amd_pstate_adjust_perf(unsigned int cpu, static int amd_get_min_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - - int ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - /* Switch to khz */ - return cppc_perf.lowest_freq * 1000; + return READ_ONCE(cpudata->min_freq); } static int amd_get_max_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - u32 max_perf, max_freq, nominal_freq, nominal_perf; - u64 boost_ratio; - - int ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - nominal_freq = cppc_perf.nominal_freq; - nominal_perf = READ_ONCE(cpudata->nominal_perf); - max_perf = READ_ONCE(cpudata->highest_perf); - - boost_ratio = div_u64(max_perf << SCHED_CAPACITY_SHIFT, - nominal_perf); - - max_freq = nominal_freq * boost_ratio >> SCHED_CAPACITY_SHIFT; - - /* Switch to khz */ - return max_freq * 1000; + return READ_ONCE(cpudata->max_freq); } static int amd_get_nominal_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - - int ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - /* Switch to khz */ - return cppc_perf.nominal_freq * 1000; + return READ_ONCE(cpudata->nominal_freq); } static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - u32 lowest_nonlinear_freq, lowest_nonlinear_perf, - nominal_freq, nominal_perf; - u64 lowest_nonlinear_ratio; - - int ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - nominal_freq = cppc_perf.nominal_freq; - nominal_perf = READ_ONCE(cpudata->nominal_perf); - - lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf; - - lowest_nonlinear_ratio = div_u64(lowest_nonlinear_perf << SCHED_CAPACITY_SHIFT, - nominal_perf); - - lowest_nonlinear_freq = nominal_freq * lowest_nonlinear_ratio >> SCHED_CAPACITY_SHIFT; - - /* Switch to khz */ - return lowest_nonlinear_freq * 1000; + return READ_ONCE(cpudata->lowest_nonlinear_freq); } static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) @@ -828,6 +776,53 @@ static void amd_pstate_update_limits(unsigned int cpu) mutex_unlock(&amd_pstate_driver_lock); } +/** + * amd_pstate_init_freq: Initialize the max_freq, min_freq, + * nominal_freq and lowest_nonlinear_freq for + * the @cpudata object. + * + * Requires: highest_perf, lowest_perf, nominal_perf and + * lowest_nonlinear_perf members of @cpudata to be + * initialized. + * + * Returns 0 on success, non-zero value on failure. + */ +static int amd_pstate_init_freq(struct amd_cpudata *cpudata) +{ + int ret; + u32 min_freq; + u32 highest_perf, max_freq; + u32 nominal_perf, nominal_freq; + u32 lowest_nonlinear_perf, lowest_nonlinear_freq; + u32 boost_ratio, lowest_nonlinear_ratio; + struct cppc_perf_caps cppc_perf; + + + ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); + if (ret) + return ret; + + min_freq = cppc_perf.lowest_freq * 1000; + nominal_freq = cppc_perf.nominal_freq * 1000; + nominal_perf = READ_ONCE(cpudata->nominal_perf); + + highest_perf = READ_ONCE(cpudata->highest_perf); + boost_ratio = div_u64(highest_perf << SCHED_CAPACITY_SHIFT, nominal_perf); + max_freq = nominal_freq * boost_ratio >> SCHED_CAPACITY_SHIFT; + + lowest_nonlinear_perf = READ_ONCE(cpudata->lowest_nonlinear_perf); + lowest_nonlinear_ratio = div_u64(lowest_nonlinear_perf << SCHED_CAPACITY_SHIFT, + nominal_perf); + lowest_nonlinear_freq = nominal_freq * lowest_nonlinear_ratio >> SCHED_CAPACITY_SHIFT; + + WRITE_ONCE(cpudata->min_freq, min_freq); + WRITE_ONCE(cpudata->lowest_nonlinear_freq, lowest_nonlinear_freq); + WRITE_ONCE(cpudata->nominal_freq, nominal_freq); + WRITE_ONCE(cpudata->max_freq, max_freq); + + return 0; +} + static int amd_pstate_cpu_init(struct cpufreq_policy *policy) { int min_freq, max_freq, nominal_freq, lowest_nonlinear_freq, ret; @@ -855,6 +850,10 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; + ret = amd_pstate_init_freq(cpudata); + if (ret) + goto free_cpudata1; + min_freq = amd_get_min_freq(cpudata); max_freq = amd_get_max_freq(cpudata); nominal_freq = amd_get_nominal_freq(cpudata); @@ -896,13 +895,8 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) goto free_cpudata2; } - /* Initial processor data capability frequencies */ - cpudata->max_freq = max_freq; - cpudata->min_freq = min_freq; cpudata->max_limit_freq = max_freq; cpudata->min_limit_freq = min_freq; - cpudata->nominal_freq = nominal_freq; - cpudata->lowest_nonlinear_freq = lowest_nonlinear_freq; policy->driver_data = cpudata; @@ -1317,6 +1311,10 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; + ret = amd_pstate_init_freq(cpudata); + if (ret) + goto free_cpudata1; + min_freq = amd_get_min_freq(cpudata); max_freq = amd_get_max_freq(cpudata); nominal_freq = amd_get_nominal_freq(cpudata); @@ -1333,12 +1331,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) /* It will be updated by governor */ policy->cur = policy->cpuinfo.min_freq; - /* Initial processor data capability frequencies */ - cpudata->max_freq = max_freq; - cpudata->min_freq = min_freq; - cpudata->nominal_freq = nominal_freq; - cpudata->lowest_nonlinear_freq = lowest_nonlinear_freq; - policy->driver_data = cpudata; cpudata->epp_cached = amd_pstate_get_epp(cpudata, 0); From patchwork Mon Mar 18 09:48:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13595170 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2043.outbound.protection.outlook.com [40.107.244.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35067364AB; Mon, 18 Mar 2024 09:49:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755348; cv=fail; b=lsSVRX++SucmHhnu3JoYmgq7kpQg6iRrxTszMhQu+4oVm1xckkKSqel1VcRidgvQM/sKXmDIwWhcSsKLACs7wLDaw6Wf4plDNbdIaLp/fFlFaVBxOmQwPLUboYO0yiPRmj2ib1agbDOoip/NUyQx6aHO1E2r3+7kgPz0JeHVOjg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755348; c=relaxed/simple; bh=TDAJbCsL57P9fRFTdJTSK/LKTJriCI5VlN+gDwTLAGg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pLsiqAXj6T9RKn3WiMkEdOmk//xSzwpZpGbhc1uqeFw+wKu4roICc/XXljzsNP116e74i/VLX9vZeoc5zTMeMlMtjz3UUkktZRLFGRbWJ+6WGvmvIBrNaCuC2I3zs1B8jUS5rmkIpttepWBmFV3ogTbiwsDpK7JCm5ejmNYMXMQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=T/xwNtQl; arc=fail smtp.client-ip=40.107.244.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="T/xwNtQl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W7OFAwzzVitCffn8/hUfIsNoZeFxU4aDUQs8q3JOl23y0A/guNRCQC6rsJsz3RbIfxUmgXWOlLlnNuNHEXGn5Dii/uHlJE9T/5pr5ih6xix1YLS4Fl5Dxg4PYgy+QLk4f01d+IC+52Zlb1ps6ZdTu5A8JyN9xKpgx6FHzSSIg8+HgnDBWjlsQ1COiia3tAD2khSRbkUn1wlA82Ld9U/T42rI7g8FxHXlixIIL82QvhDzGKZFirwbM+r9qf5isc/8pCrjZiUrnHc4//Kuj45RMqu181/t1u/R6jcq9MmhZyOmGlSHycIEsM01vbqoQCdomvgzsMtG1B4yxenxCVNEWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cHtQBdqlY42oFMXHB4mQbLlmfetVZpy6Pc5nXAGt7GE=; b=Au2bNQLQa6Bd+L1sHe2uQSvQMkACA8Mf+QZ0pzX1mFnkYH0oB4VUvg7L96NxKd5DVtbmSZZCZQHEL80Yk3s5RDlwxfaMZv/oUnmZfx10E979LYy16S7sbTWCOfH9/QRrMEmJP0b7eQI9ygdecKhdy85XqowMrirBQ3vcvMl2Xrulfh8g3kVre/isBSAyjj2OzpUnStOjLkoL2qtfyC8N52N4T7n+S9OagIAaxmAkeAYv8+Q4Q2MhqPZnlzvKuLMz7nMckHBz4VRkWOJCMugfKsN0ku2zirjNpBHKDow3zzRpHELCh1ajydyLPLnKkOhWEN5fsp2fHzkymK67fouZyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cHtQBdqlY42oFMXHB4mQbLlmfetVZpy6Pc5nXAGt7GE=; b=T/xwNtQldgkrSY0n/JKtyyYV5Bu8SsEOoXuWcT5fP0UHTbCeDmoVyzX1hBScP/Yjd0Y4wURtxEyY95pLLtM5R+sEZ/qsAy6EhrDBMCRJ9JfzXMDdWanRasM7bsk0uCugycz/DI8QMZxFGARg64VLD2/uhK6zGLP5ut5uZI+0jzE= Received: from SN1PR12CA0075.namprd12.prod.outlook.com (2603:10b6:802:20::46) by CH0PR12MB8552.namprd12.prod.outlook.com (2603:10b6:610:18e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27; Mon, 18 Mar 2024 09:49:04 +0000 Received: from SA2PEPF00001506.namprd04.prod.outlook.com (2603:10b6:802:20:cafe::cf) by SN1PR12CA0075.outlook.office365.com (2603:10b6:802:20::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26 via Frontend Transport; Mon, 18 Mar 2024 09:49:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF00001506.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Mon, 18 Mar 2024 09:49:03 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Mar 2024 04:49:00 -0500 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v8 4/8] cpufreq: amd-pstate: Remove amd_get_{min,max,nominal,lowest_nonlinear}_freq() Date: Mon, 18 Mar 2024 17:48:23 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001506:EE_|CH0PR12MB8552:EE_ X-MS-Office365-Filtering-Correlation-Id: d99587ea-bbe0-40bd-45a8-08dc4730a550 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UVImm53ahxpUe4noQJF6gFRtyDyKOnpwqb56+5jn1UcVgAf+PlTDeBj6xQLiv8P/N7YSx5pYA0TMSUd5lmyf98WTvtP1YN4eE1dbs4KGiAw+K47aXkP88b1ii+qLOu1XK4u4uUpxvSwjBAJWSs/hp/HJH8GEAY1kiXvpIM73BxqLnGQhcZyD4uDuOyCVXgZVdky9Uny+iobo9sJ1YmjBTNxpjdvr/HuDPE9Hl+oWGintc0GYcmRqrYsdKCW4IajMWUoNLgpUXTdz5Pe6U3ox4lr8s4QdBpNOvCKooNJ8pSTX0b7I1gPVAAHyzECnFUHBVqLjPIWA98nj/tEPU6uFbPXelAFwSbloF3HEJ1xxz/ebnBN5M15svOgzVrmf+lj6uXqJzaBko+FfcdBje4k0NIe5JPso/5Iwa0NpdIlpAOGSwjGsiV9zYbBwu9tmOzfK/zvHo90Z/7/Lls44GDf08HV7dq5pYfUMru735xHNqba3XWVv/5uh/14+535SUwkSiRmrPKoPjYtlUxGLzIUHoF0TIy2k7dsstbnmpN8VThpoIi4tN1EklIq/QdHA4EnRzaLj4P+CYnCOgevXTnc1a2Py/abkWVTmgCzyKePQnKN3fPlenSp4CMZ+uyQsFp/fNkLXU+3blmY0CDeZY3UJ1e1XVTu/vjmDb+PLVZiHTGf5gwWaYdcKTKZLkq4fJpR4McbyY/wzGUd2Hjpwxi3+wO/p+v3X1hQ4KUXdZp6VncAbDdMTASQzWTYZyulKyy+X X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(376005)(36860700004)(82310400014)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 09:49:03.6646 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d99587ea-bbe0-40bd-45a8-08dc4730a550 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001506.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB8552 From: "Gautham R. Shenoy" amd_get_{min,max,nominal,lowest_nonlinear}_freq() functions merely return cpudata->{min,max,nominal,lowest_nonlinear}_freq values. There is no loss in readability in replacing their invocations by accesses to the corresponding members of cpudata. Do so and remove these helper functions. Signed-off-by: Gautham R. Shenoy --- drivers/cpufreq/amd-pstate.c | 40 +++++++++--------------------------- 1 file changed, 10 insertions(+), 30 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index ba1baa6733e6..132330b4942f 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -604,26 +604,6 @@ static void amd_pstate_adjust_perf(unsigned int cpu, cpufreq_cpu_put(policy); } -static int amd_get_min_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->min_freq); -} - -static int amd_get_max_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->max_freq); -} - -static int amd_get_nominal_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->nominal_freq); -} - -static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->lowest_nonlinear_freq); -} - static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) { struct amd_cpudata *cpudata = policy->driver_data; @@ -854,10 +834,10 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; - min_freq = amd_get_min_freq(cpudata); - max_freq = amd_get_max_freq(cpudata); - nominal_freq = amd_get_nominal_freq(cpudata); - lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata); + min_freq = READ_ONCE(cpudata->min_freq); + max_freq = READ_ONCE(cpudata->max_freq); + nominal_freq = READ_ONCE(cpudata->nominal_freq); + lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq); if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", @@ -960,7 +940,7 @@ static ssize_t show_amd_pstate_max_freq(struct cpufreq_policy *policy, int max_freq; struct amd_cpudata *cpudata = policy->driver_data; - max_freq = amd_get_max_freq(cpudata); + max_freq = READ_ONCE(cpudata->max_freq); if (max_freq < 0) return max_freq; @@ -973,7 +953,7 @@ static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *poli int freq; struct amd_cpudata *cpudata = policy->driver_data; - freq = amd_get_lowest_nonlinear_freq(cpudata); + freq = READ_ONCE(cpudata->lowest_nonlinear_freq); if (freq < 0) return freq; @@ -1315,10 +1295,10 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) if (ret) goto free_cpudata1; - min_freq = amd_get_min_freq(cpudata); - max_freq = amd_get_max_freq(cpudata); - nominal_freq = amd_get_nominal_freq(cpudata); - lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata); + min_freq = READ_ONCE(cpudata->min_freq); + max_freq = READ_ONCE(cpudata->max_freq); + nominal_freq = READ_ONCE(cpudata->nominal_freq); + lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq); if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", min_freq, max_freq); From patchwork Mon Mar 18 09:48:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13595171 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2053.outbound.protection.outlook.com [40.107.93.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14C7D381A1; Mon, 18 Mar 2024 09:49:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755354; cv=fail; b=XcVOsfM9dsnbhHMx4ynIooSVWFvJjFoXDM2C7h+fQnfthwK/WGem9fLWN0eVroln6hVQJoY2d9oyEGEbfFjKZnaVeI511daKFDHirqBiV2THWejdsitCd7TPz3xlpA4SkdzAWiVo3DsO5wo66E/ZHUz6Ud6ZVj9Nvq6zOHij6a4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755354; c=relaxed/simple; bh=3H6EIOerWdW7SIzsLkKc3x5YT4eoaZVfOp39Oh/T5tM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ImlGodDTUb9wq2wQhKOhUrtIG3FB+MGCBq1dhHV/8bs5dlDPBKPFO1yMzQYgS//q3DHR8UI6fAouxDpbaVdpeLgiJZ5bpJ/IzHW9KnRbiT5iMXJkwhKxM6aJFxa+pwx7+8C2vTDwJELuTTdXpAK/wH564dpmTugkxNX1hVPy/dY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=UaaAMIxN; arc=fail smtp.client-ip=40.107.93.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="UaaAMIxN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gY2oVNCHAKfVVG08lpxiry99FpN14Pm0frGxvMHft3VHmg54MOebQ+dGKo8iKZhPa43n1PsjN1kiuLLHuIFoTpwMo3q/IAV7pVasl4p/k1Uc1dkmKeH6BY3+E2wl4MORnb2hrpCL4sJXLWl9OrAftyHjgp/Eil5jhKkXe2eBJHDsdLB/pTFE35eiKdpzmb7O1pESts3hAnGAna+g/FrRy6OhKySMvBxlFRrLpRk9ccS3DPQLaYYJcT3tvkxM1lgvWRQK5otSqdXonduBVbWYAmCQgTQ0YdTDOUk5ieSWiFU4ky92Fp5j7PtO0HKDnbzMCWbpO/6A5VucBiF3ze7EaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=akg66VxiKSozXs5N7b4vfJ8+iUO7jA9oCp1+SbotMb4=; b=N5fFDtclvnW1O230DW7xadlIFgrm3TRfNdbfhnRB7RHX2fhN8xMf6m3Yxm2Jn84DSxwAD/2tSvZPS7tJXG2Sk8U1YPEqiCtfHolygZVXM3RSkbsQHxoRaTpZVjYhRiGXA18TgRMmkOnTNs6nh9UCaqL0q04zc1V7QH/6+NYDdjg9+5ADY+HTJPv2zzrXW7+pKxuMe2Ylpx174XaeOHLer9o/V7KF3Z4QHpCwyhdknacf7tdmLr2IsnUXZ7SxExYYxcbz7R/9ylo3d6Wg3HDplN1obNkE4I7QR0qEOHwPiNT/VVttOFj+d6TP70p5hMxSOeSFVBUfXwoLYkygrX3kng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=akg66VxiKSozXs5N7b4vfJ8+iUO7jA9oCp1+SbotMb4=; b=UaaAMIxNVyqRXTEw7ATwx4lHcRN5MsN3bsxzPRFayEsLoDdIkCsvUUGFvJd0VJVQlyZiIkScxYOt0YZnvtfadmd2r+rGxQhqP865S8JpNTyqs12CTGWCJabXiQ0x/WUOCkMNaSJTl5oKjVL0kI5FhQSHX/ltYTmUC4VmDyf3NfE= Received: from SA9PR10CA0003.namprd10.prod.outlook.com (2603:10b6:806:a7::8) by LV8PR12MB9334.namprd12.prod.outlook.com (2603:10b6:408:20b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26; Mon, 18 Mar 2024 09:49:10 +0000 Received: from SA2PEPF00001509.namprd04.prod.outlook.com (2603:10b6:806:a7:cafe::6b) by SA9PR10CA0003.outlook.office365.com (2603:10b6:806:a7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27 via Frontend Transport; Mon, 18 Mar 2024 09:49:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF00001509.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Mon, 18 Mar 2024 09:49:09 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Mar 2024 04:49:03 -0500 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v8 5/8] cpufreq: amd-pstate: Bail out if min/max/nominal_freq is 0 Date: Mon, 18 Mar 2024 17:48:24 +0800 Message-ID: <75c1584f93abc52ba4adc7894ccc7f8f9ca721c2.1710754409.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001509:EE_|LV8PR12MB9334:EE_ X-MS-Office365-Filtering-Correlation-Id: 92a86aa9-6091-4de5-929e-08dc4730a8e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SvEHQstOOxYysuNpfpLrBZ+Ox1+eWGcBrO56ebooHfFbaFsXGgwTgVgH8qELxMdK8leRCGFW+DS/a9s78kT/8l4gNPWWu/u6YR46S9Y1cUup1SBV6bFjCnRH09a8qm1thobrMOlw1NsRanGwxNs3aixxyk0L6xmyQ47ZbdCdOszdJeZOPsLwU63wIq3+s4OvV5lGmE6lSmZq41W8wFyxccOqqp3FCj6KqU75R4bUq5LoBEjv9pEHokyf97DXgBiYIG7mZzEn8QKYckgJiM1F/kxlL/GxrVqxO9fnzL/P1UQ1qbdjBt/Mu4fnRkSZ6tfRu96QTu7Whl0d25EjLf/RB0Zc0SlfUw+eqFp3tVoQ3Ps3f4RqhHM181GC0TymtlDMOHWBkK9YZEQcR1Af48NqWLlIJn/FDab5h+piFnqtkUOpqsR5KpSxSISBw7LbCXtni50ZJQHYBvg8s3taL3KSb2AMYDa11BVXK7D5ZC6gDQBvZD2WfgIr6eRNT0hsGQd9B9eZAaCVq2J8EcHbmZEllLH+K56ImHK3lWlNmstGj9Wgcg6vCaGqFgnmeOHcNK5PT/wFuPvuoSI81khdxA9vlDIFRiSWRDer+eJ4rnqMBf5y4rjGuwci3o6gkHLr2e+oCWv3Yt7Svm+KGep3jTz+yJMdDZrmm5Vzhixnxgm+EUT+QqEQWRBM9BKuUWUOuHZUsGz+eL08VCNjfpdPCMaNRxi3Swd8ecz/GrRA1CK4si8rvCgixOpvA/u+Md/Ql9tl X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(376005)(36860700004)(1800799015)(82310400014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 09:49:09.6631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92a86aa9-6091-4de5-929e-08dc4730a8e3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001509.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9334 The amd-pstate driver cannot work when the min_freq, nominal_freq or the max_freq is zero. When this happens it is prudent to error out early on rather than waiting failing at the time of the governor initialization. Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 132330b4942f..6708c436e1a2 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -839,9 +839,11 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) nominal_freq = READ_ONCE(cpudata->nominal_freq); lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq); - if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { - dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", - min_freq, max_freq); + if (min_freq <= 0 || max_freq <= 0 || + nominal_freq <= 0 || min_freq > max_freq) { + dev_err(dev, + "min_freq(%d) or max_freq(%d) or nominal_freq (%d) value is incorrect\n", + min_freq, max_freq, nominal_freq); ret = -EINVAL; goto free_cpudata1; } @@ -1299,9 +1301,11 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) max_freq = READ_ONCE(cpudata->max_freq); nominal_freq = READ_ONCE(cpudata->nominal_freq); lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq); - if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { - dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", - min_freq, max_freq); + if (min_freq <= 0 || max_freq <= 0 || + nominal_freq <= 0 || min_freq > max_freq) { + dev_err(dev, + "min_freq(%d) or max_freq(%d) or nominal_freq(%d) value is incorrect\n", + min_freq, max_freq, nominal_freq); ret = -EINVAL; goto free_cpudata1; } From patchwork Mon Mar 18 09:48:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13595173 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2083.outbound.protection.outlook.com [40.107.92.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5ACD2D605; Mon, 18 Mar 2024 09:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.83 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755357; cv=fail; b=msvWen9u8ZEUi4zVoJHRQfwqojH6DDyzwbz2grdvZU0W7pUW0nRD/ZKLutrU8/ZEMi9TwWXFoQXxr03hBw6beRoJM8bO5ulrgKX5XfsNg+hWEictdhPQZXAa6C7NdcwUMC84qCi96FaWCL8hAfw90uTpkTlS+qDh1H/F0Tr9oDY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755357; c=relaxed/simple; bh=HxLM1S7chiUDtjTKDjPXsfoeLT5X9ifSO45QSSAeVgo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OdCJDO0BxF3wXCfiMHXk1+hLeCzlluJVmysZOZ/EVSDENm92u2zuU5oBegFQs0wkV7b6unpFDsuE/MHciTxJB09FcRNMOsQW/hdZ3IlSscLmzurKytQhH+fXOISU4nuveGs2AtO7FFs2MpTuHBmBGCJPOruGG4Mqn+KFYScxpiU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=PctefecL; arc=fail smtp.client-ip=40.107.92.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="PctefecL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lRW/QPoP/tMdU0i05ehv8PVbob2WPN0R2tpvdfEWk+Rv/sQC9GoCJwH+/LIpbbdDsLXKYumcJ8renLpljD4VJrGXPyliTdfHe5k7pGc+9A0sB+nOHdwFmdqDWM7tLQIxxD/qZXqJoHa3Qdj66EdJXN/AkkOBSLd1igNe0Nh+PXJUUe7q1xWAQ/cufGJwytZwE7AVJmTWoRQYcStZNOYfjbIgUNPP8EoW+fA98r/zLJenQGUTd/OqrF2OACRvkVrtqHhLNnOUM+m0f/9uOK72QXT6eRrTqlxzpJMh0Wid/oRoE8S0ptfZo3J4++iU6jgKDuTOkAzXUM/oJpLIc+14NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o4AiBn4/w92cQ2LTQGxZyIGJbS8twcjPhgQ1q/aWSzQ=; b=jYQgCIXJ6yBsvQdg+Pm9rg1WIrhLjhTAT6pWy+nvgA05FQeP/cqNx7FivzuaghSnAAUzQQO3is3FzNxdpjMiqWTubIWabOQ85ZJ7Icd0Zj3cWlfN+PW8i7qcgpVslSJIfR8wvXtnnfQP7sU3WMy6ULlAeDuwpvOEcJwdss3b5aebcrjNgBKA5r3EguvFSUjm65sefli/RbdD4aGriayN7fpitgtEE+Hd/Jg2BNgSzvOOEOKaLJIKYE8yc+uI7u3X2a7bzNbB/TTvsO+sVrUTKl48ogo1CmbYem2mPXa0sV0mIs1WEUeaQd41fq7pVqpkkGV5IBpkxugKjVssbDp1/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o4AiBn4/w92cQ2LTQGxZyIGJbS8twcjPhgQ1q/aWSzQ=; b=PctefecLT+HXllJO/8vJLM2kdRw9bYhtyKv5QPTZPBtzNqpxLNVMONk99bTRlYt3eEtjaQ/PQdI0c5SuEF1/pHgf0oEvBmAohbJiLjQetGAkw26u7LRny7b2blSrR2WOvhQRGd7PWKqOTWs0vAiJj5eBxRB1COEpR0S88SVcr8U= Received: from SA9PR10CA0030.namprd10.prod.outlook.com (2603:10b6:806:a7::35) by SJ0PR12MB6990.namprd12.prod.outlook.com (2603:10b6:a03:449::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26; Mon, 18 Mar 2024 09:49:12 +0000 Received: from SA2PEPF00001509.namprd04.prod.outlook.com (2603:10b6:806:a7:cafe::56) by SA9PR10CA0030.outlook.office365.com (2603:10b6:806:a7::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27 via Frontend Transport; Mon, 18 Mar 2024 09:49:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF00001509.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Mon, 18 Mar 2024 09:49:12 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Mar 2024 04:49:06 -0500 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v8 6/8] cpufreq: amd-pstate: get transition delay and latency value from ACPI tables Date: Mon, 18 Mar 2024 17:48:25 +0800 Message-ID: <097b6711995aa16fc55f2688bc5d01fb8e728ce7.1710754409.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001509:EE_|SJ0PR12MB6990:EE_ X-MS-Office365-Filtering-Correlation-Id: bbeeb424-b0cf-4828-e50e-08dc4730aa59 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PrH0oSLvl0ytpQdDmZzGaHgjxOKwMPW95vtkB62QIPGK++J/PzKIHcEnmRdfwVKkmd8IMjIZNcr2GxNZBQuYKYsrNCeynHvZLrf7/UimqFfRXTQ9dx4Ayq7vhm+s65kFsUnCyiSSughuihtyxP0AKLgj7SaC/4kQevNw4FCJj92qXo5dqOdOelLtv9CSsrDqN+5tHTHRyCzdL07AqMG2Wsx6NVRykR8WTjOvq7KZ86uoXYfeb6CygHNlA9t0+hqXH127vwlDTGiaKKSDKXZE7aYe5vaq1nk4I6zVat4cbRIgUrhuSQwaADMJn5byKRIRzCKcoEPPh/wj5EgZToECcA4OV4w11xysu04Ot5M84bBOCCeQY6sqx/hvD0XPz74lv4i7h28gWKjZJRm9XpMCazdlV6CrBLR4Yy++/wAABV4rnP/CMfhJjEOB5uxbUkfLABI02nk8f0vo8a7hGsGP2BtfA0z4q/HGFTFhortsCWdWpVKO9XvTBdKQIUBDJSMl6MPNCnnbpYQ8ff3IGvxuMjCfT46PbA0nhjFsTsk7oXS5Q9w9qF+JWJ9aWy3d4HuTgxwjgSFTwmUdLQ04vnkPu6syIGWhLTTww1Wjw9WCH7co7LO0PtPn/GW8AxMmnmv9ehi7TPLIEYcD2ruJ5D20K50moI+FjVeLydbAZEnSr+vXHLva6lFloDkL4c7kaO2YeWQBRA1/zV6+JlYhxCAChSyyLfOzUVHATuQbRcRg65fvLyVjXe6+wZEerw4SI44E X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(82310400014)(36860700004)(376005)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 09:49:12.1163 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bbeeb424-b0cf-4828-e50e-08dc4730aa59 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001509.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6990 Make pstate driver initially retrieve the P-state transition delay and latency values from the BIOS ACPI tables which has more reasonable delay and latency values according to the platform design and requirements. Previously there values were hardcoded at specific value which may have conflicted with platform and it might not reflect the most accurate or optimized setting for the processor. [054h 0084 8] Preserve Mask : FFFFFFFF00000000 [05Ch 0092 8] Write Mask : 0000000000000001 [064h 0100 4] Command Latency : 00000FA0 [068h 0104 4] Maximum Access Rate : 0000EA60 [06Ch 0108 2] Minimum Turnaround Time : 0000 Reviewed-by: Mario Limonciello Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 6708c436e1a2..ec049b62b366 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -756,6 +756,36 @@ static void amd_pstate_update_limits(unsigned int cpu) mutex_unlock(&amd_pstate_driver_lock); } +/** + * Get pstate transition delay time from ACPI tables that firmware set + * instead of using hardcode value directly. + */ +static u32 amd_pstate_get_transition_delay_us(unsigned int cpu) +{ + u32 transition_delay_ns; + + transition_delay_ns = cppc_get_transition_latency(cpu); + if (transition_delay_ns == CPUFREQ_ETERNAL) + return AMD_PSTATE_TRANSITION_DELAY; + + return transition_delay_ns / NSEC_PER_USEC; +} + +/** + * Get pstate transition latency value from ACPI tables that firmware + * set instead of using hardcode value directly. + */ +static u32 amd_pstate_get_transition_latency(unsigned int cpu) +{ + u32 transition_latency; + + transition_latency = cppc_get_transition_latency(cpu); + if (transition_latency == CPUFREQ_ETERNAL) + return AMD_PSTATE_TRANSITION_LATENCY; + + return transition_latency; +} + /** * amd_pstate_init_freq: Initialize the max_freq, min_freq, * nominal_freq and lowest_nonlinear_freq for @@ -848,8 +878,8 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) goto free_cpudata1; } - policy->cpuinfo.transition_latency = AMD_PSTATE_TRANSITION_LATENCY; - policy->transition_delay_us = AMD_PSTATE_TRANSITION_DELAY; + policy->cpuinfo.transition_latency = amd_pstate_get_transition_latency(policy->cpu); + policy->transition_delay_us = amd_pstate_get_transition_delay_us(policy->cpu); policy->min = min_freq; policy->max = max_freq; From patchwork Mon Mar 18 09:48:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13595172 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2059.outbound.protection.outlook.com [40.107.244.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8101A2D05B; Mon, 18 Mar 2024 09:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755357; cv=fail; b=AURIM1NJYBmnlAdz38S6QJfAQMY6EC4EpUXkItonjuXOiP91rZPFpqxSPPVwvlC3zKRdt74iFZvdVCIm/HwnB670ACHRanbIQ0OfXTbNrCVfaG0V07WZqygty/Tzj6Qx9MDtGxTZ3durS5abiAUlfKSfrn21ua4Ol9DNtGqh/T0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755357; c=relaxed/simple; bh=oUsCTLS81tnEaeLA8CnwR3jnc4v4JZvRlfYO+nGnqrw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nM+poQG8iAUacsoxsfL+0LS9IjdJ2x3G3grQ6KO930cmjdQ1+UfNN4KXFPSG7/MvP8TXCNKvf7o7iaLnfLPUFYawcrQU2g5EhPjHYGCTPJhX4pYT9/8ljvWx3gHBr9TP7J9qzoDqXykkvzy1ewnIJ80DNZKA5arRZXfOL241OCc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=2XYYnl5C; arc=fail smtp.client-ip=40.107.244.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="2XYYnl5C" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J7YPlcJBinOHb7l/FV5gNXPPpAiXJQYPxolRjzzN/uuFCPkasI2ncnxL5MJ9N5Xysnjvk6K2yvxgQnsYnZwgChQuMQVROaeJGpQmg13DSrWZ8Ngg8CcevGvNrOYjP139nKGFCzlMJ58kSst0iaTRujWf7okObVXdkm4euM/pJhgtIR/9uhrjlRvXakKjKokzJolOIrXaDFuUfT8s9NZ+jpHPfS3yVMd8OobScfXA0sibtI8v4FqU9uT8IFzszbBziU8KvnwdCB4D1m/nNXhrzsm4d8gJGpal2QSBLWog9EfZgzWx16c5D+9AeOL0nLWZcCUoPcn5KDS1rBmtVrSP7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CcnNqZN0Q2o5ao0YuIpHgjFGfQ/tZ7BDDZmMPr4XLac=; b=OQIYL62eBuy1m9LS/m8rRicM3R9NUUgsTsX/2bRtvb0BqKztKK8TIbqxUvYSb83YojiLeYrwBHilZwtmecTBEAgG0+QEtm3xNI1KYF5t+ihf1Tn84rwtwFXXlS0Xziq5HaTQPzDrGIyMUha7JEs2r9XCZVDE7V8FifMagDWG0gwuyBuQ9Z5itPWSQ/O6pU8VoS0MzAQNPc52pExgxBUX3IFmieIxHSWuYMwvhutwLlg+jMZEjG7v/15VNi5RAx0kcOLv+80EYXM6ZPYZneE6PbNgGl8vF+uEkbWzbE6q+4cPHjEQhpsttngyzUljdiiabaZTU9WWMLvUK9EX31KCYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CcnNqZN0Q2o5ao0YuIpHgjFGfQ/tZ7BDDZmMPr4XLac=; b=2XYYnl5C48Avri2TWMBVmIiuYvHpzkPZXiNpDJrznWCoBBC2kv2g1FzbZ9M96agNBc8ZYKV4hIFlDs1jdohjvgq31Gim+oP25TSiCAtuP93tFQ+xHUJdnHkNU5XUEdmd+Ut7t5+6O1TD9VTuOJGz1NjnAqWX+oe8emKGmIVPI2c= Received: from SA9PR10CA0024.namprd10.prod.outlook.com (2603:10b6:806:a7::29) by PH7PR12MB9128.namprd12.prod.outlook.com (2603:10b6:510:2f7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27; Mon, 18 Mar 2024 09:49:13 +0000 Received: from SA2PEPF00001509.namprd04.prod.outlook.com (2603:10b6:806:a7:cafe::7d) by SA9PR10CA0024.outlook.office365.com (2603:10b6:806:a7::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26 via Frontend Transport; Mon, 18 Mar 2024 09:49:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF00001509.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Mon, 18 Mar 2024 09:49:13 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Mar 2024 04:49:09 -0500 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v8 7/8] cppc_acpi: print error message if CPPC is unsupported Date: Mon, 18 Mar 2024 17:48:26 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001509:EE_|PH7PR12MB9128:EE_ X-MS-Office365-Filtering-Correlation-Id: 311e2ec4-b580-4e3c-057e-08dc4730aafc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T6PGxSMgAjm+QBaj1nIOhq88NFQk4NFKk58a9aDjSM0KkWpBbN35jVjk8zHnf8JmMgM5Gg08Zk2JRY/hAVI5tS2As9z+0XOK+eUZNK5I460JRE1ycviS9nNUPRE544ZVeR6+pUU4uX0cOp/YDSCE0SlUaD2JyZRB/yVSUkmYaF9F4/ZVEPHy5RxYw5ztaTxFvl5AWApzcZ3LztRQZzHCD66Yny1o86CmqCkMEnfJBp3lNe4R8xkgLDzY0R8TzLY2AnyLNd9GUrjVVbeSc10v662X3ma29SO1vQeLm3Zu+lF5Dx4D7BsfQjbJwAG7agDFgG0GI3wff8QZ7KMzUa0F7pI9Ujbu/dD7lodTVQkKr4ybfLAg2gcpY6nmw1NrASLeUmj0jJS4CWcMUtwtyZl7DIAausUFuOHZh8XfN8rHUaAzJXity5MBOUh4S5lANuEMRPqXw8AkUr1KbhaHpCDFcfZI74Qd4g4XSBl85tufzyGBadUl9XGO+fJqL6D3NLes7NOiT87lfzt5UW6TgMEE7DMU7dGnaQv3QMGlm4u3ORKr3qAAsqS1xLPCpS/MjoSnartER8fzAew9rV0dc/fwOjlwrY/2IN2qbJ9DOcAQjIVspmlCQ5x461U3YnOronvmXfp+XxOEud6WLBNMtbk9zeTz2a0u4V2xvJ33aK/rap3UXdYFEzrN3x8ML3kieHpgWi9tYXWE7rfzmdOQRvZMlT+LwU6x8xrs4vjafdPfxpyomJNJEkSdt4mVZBqmu0py X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(1800799015)(36860700004)(82310400014)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 09:49:13.1788 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 311e2ec4-b580-4e3c-057e-08dc4730aafc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001509.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9128 to be more clear what is wrong with CPPC when pstate driver failed to load which has dependency on the CPPC capabilities. Add one more debug message to notify user if CPPC is not supported by the CPU, then it will be easy to find out what need to fix for pstate driver loading issue. [ 0.477523] amd_pstate: the _CPC object is not present in SBIOS or ACPI disabled Above message is not clear enough to verify whether CPPC is not supported. Reviewed-by: Mario Limonciello Reviewed-by: Gautham R. Shenoy Signed-off-by: Perry Yuan --- drivers/acpi/cppc_acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index 4bfbe55553f4..3134101f31b6 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -686,8 +686,10 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr) if (!osc_sb_cppc2_support_acked) { pr_debug("CPPC v2 _OSC not acked\n"); - if (!cpc_supported_by_cpu()) + if (!cpc_supported_by_cpu()) { + pr_debug("CPPC is not supported by the CPU\n"); return -ENODEV; + } } /* Parse the ACPI _CPC table for this CPU. */ From patchwork Mon Mar 18 09:48:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13595174 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2089.outbound.protection.outlook.com [40.107.102.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD6F2383A3; Mon, 18 Mar 2024 09:49:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.102.89 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755360; cv=fail; b=Kc6ZvtjYdR/S/Y19g1w2m5S7lfXbbO5wJVbVQu7O1lfKHAGAeJF2Q6+mEueU8DoDfvMXFm6wLTiUkzYrJwU60JqfRNcKutCFq6nYsE1Cw4Rlf55iEKoTJ/31Bz0oyo1lNREPQZMIT5xgH/E+pnw/D8nL+2NulbmGcg1OxlbqsCE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710755360; c=relaxed/simple; bh=CfC8Dtdej8Bs2obErQD2thPXyALKckCC+ZpjubXph5k=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mftpQCbx4dI1BycdejebCjYtkK3jEaVXycPeZAkpeJIj/MWkEWwJUiSCKJ21JcnANUZ6JsarwfJwQkj303K2XekSeQuiqrkGlDmcXuiwUqw+0XvBQo7pqZUhkgXUcS6veJSb66UvgucaR3/SVR+QrH6s2KxLixnKYYgyuVVRy90= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=P194mdFU; arc=fail smtp.client-ip=40.107.102.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="P194mdFU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k3xbfMED2D3QOalQx6YzdwduoXcaLzocdTT7Q7TMSxBWMBeTT6Iqr5cMpOTqLQppiGTGWU+lY2rjZv840W+cn8dlm3i8AsOuBXZNnxJrH0RaRT8e/ZW2CbZtxuR8H47sNrBVJcciRHs/UJtUceSSCirqrOAZMPOh3U31YBiHySIwzgiFFEbR31H/J3tksWo/fcpt5jJqbP+0Ml4DxAyE/Uab4tUlv9rESQH7ncPY2RhR8baYDJ2sQSU/cuze54OGzbCAmxnUACINxZeRybvdeTEZa6qAYDvrcEt+BTk8s2ixKZg9X6SD8J3/iN4FzfH3dhr7s4jlSqT4tWkkzwLsdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1dq3+SeUoyG/XIVatEuBb4Cc9u8W4ZcJ68xS0opsXjc=; b=kvbL23WLeVZ1NgqTsCc4i4CtJZnLs/IWSlzYj2AA29/YzG+48KH9KEhMczU/O5bLJaPs+R+hpc8RUi/ju2BvbSy2j908wmXzQYzzkwChEbj9BjVjQ8xHeriz3himwOb1NEjp0acvUXQOCuuYVYUskpn0eum7fc8gapTFynd4SPiBAO9EJX8M28iL9N7eUBj1Y/oUGH7teCFkidmEQ4Lit1S/KZJzB8+skGHxaLS94iroZzJa8ofPthA2HU/VyDLr0PVIFV3j7IgtiOGr5hFo9neSpBU+ixPwP0wOj80OHrQ/FZ8OmU4MRQ1bnYvdqZd8GmgVcldedEkzMLLtmK5R/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1dq3+SeUoyG/XIVatEuBb4Cc9u8W4ZcJ68xS0opsXjc=; b=P194mdFUZc8+xQIViHck7z8CP7Q5PhXOerWjG6u+sLGUcRMqIo9HHiqztXszN23PW3h69gUjy/Twb5vF8Jpb7bqhnVvRqveJF+DZA0RRFqnzRAwQoAheCrEBe/OnQmEjsjd8T2RsPn9nur8Og+x/sJ2dErHetNhfrTRhK/2deUs= Received: from SN1PR12CA0070.namprd12.prod.outlook.com (2603:10b6:802:20::41) by DS7PR12MB6335.namprd12.prod.outlook.com (2603:10b6:8:94::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.27; Mon, 18 Mar 2024 09:49:16 +0000 Received: from SA2PEPF00001506.namprd04.prod.outlook.com (2603:10b6:802:20:cafe::e9) by SN1PR12CA0070.outlook.office365.com (2603:10b6:802:20::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26 via Frontend Transport; Mon, 18 Mar 2024 09:49:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF00001506.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Mon, 18 Mar 2024 09:49:15 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Mar 2024 04:49:13 -0500 From: Perry Yuan To: , , , , , CC: , , , , , Subject: [PATCH v8 8/8] cpufreq: amd-pstate: Add quirk for the pstate CPPC capabilities missing Date: Mon, 18 Mar 2024 17:48:27 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001506:EE_|DS7PR12MB6335:EE_ X-MS-Office365-Filtering-Correlation-Id: bc8e6009-2341-47de-40ac-08dc4730aca2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G6YT1YglgkrqZ7KXhL8AvJCu1eGBi2/tyKiyVhKtNvmrZrMaIslAUC6nmPJGeB3KP38u2vcf4b4aT9MjzBTIsSVg7zv0vP/MB6h5s+E6e8PW8er1O1TzMOaM9CX16UXRou3I8CzB2whPlZlV+lcy11CLaic1iJYos7uUl3cFzGbIqk/KMnKlLghhgWzw4X6yQgyCeTPTz9S3WjZWhHYyzInqGlZhBzRDlxsaJ1iBIp2yoAVBIDnsGj+OVng0BYwsnDPXy9vOyMtXqOur9x4H9q2s81Wy19QZWeUAA8VLYNijKavJIxJbctlpz2ivLnE8CJ691ol6qxt3EIk/JsF969MsOnqU6SuTMG2W4BJUxB3sffuQEWegEnxOJikZnuC/eC19AqMOaHIYmvvFbnPNo9LJa2b6uwnl1ebXUBpJvydFTlqBmRcQTrX0d/71iHBuA/k8ser6Z7U5TnrlZP1lwcdIbQ7esXTUfoGe5OAvmpxEpOtF4xsM+I1Cd8fbLxSLHWkoVCa+Imne7rkdDxYSeW7JEtuN5Q8lpsgAMcQUvjwgjrsYLPTrXoD927UzBfObSL41u6sEazOADjHvq5i0O3e03vHyvR30y1gUvQ2nxlicMkgOfwYyg1yuJYB2eZccWfuuIJmtyhzNOM4ocAOjW5VFhg+nPzgoR1tqaC3HEn1EjIQNUF2Cu6UyR63dIhJmyZ52uMYTQdv/WnVsgRHowZrxFm1oxKzZqdN8EDeZ4VNnTLapzMimBBR/GXKoSjmj X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(36860700004)(376005)(82310400014)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 09:49:15.9459 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc8e6009-2341-47de-40ac-08dc4730aca2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001506.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6335 Add quirks table to get CPPC capabilities issue fixed by providing correct perf or frequency values while driver loading. If CPPC capabilities are not defined in the ACPI tables or wrongly defined by platform firmware, it needs to use quick to get those issues fixed with correct workaround values to make pstate driver can be loaded even though there are CPPC capabilities errors. The workaround will match the broken BIOS which lack of CPPC capabilities nominal_freq and lowest_freq definition in the ACPI table. $ cat /sys/devices/system/cpu/cpu0/acpi_cppc/lowest_freq 0 $ cat /sys/devices/system/cpu/cpu0/acpi_cppc/nominal_freq 0 Reviewed-by: Mario Limonciello Reviewed-by: Gautham R. Shenoy Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 53 ++++++++++++++++++++++++++++++++++-- include/linux/amd-pstate.h | 6 ++++ 2 files changed, 57 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index ec049b62b366..59a2db225d98 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -67,6 +67,7 @@ static struct cpufreq_driver amd_pstate_epp_driver; static int cppc_state = AMD_PSTATE_UNDEFINED; static bool cppc_enabled; static bool amd_pstate_prefcore = true; +static struct quirk_entry *quirks; /* * AMD Energy Preference Performance (EPP) @@ -111,6 +112,41 @@ static unsigned int epp_values[] = { typedef int (*cppc_mode_transition_fn)(int); +static struct quirk_entry quirk_amd_7k62 = { + .nominal_freq = 2600, + .lowest_freq = 550, +}; + +static int __init dmi_matched_7k62_bios_bug(const struct dmi_system_id *dmi) +{ + /** + * match the broken bios for family 17h processor support CPPC V2 + * broken BIOS lack of nominal_freq and lowest_freq capabilities + * definition in ACPI tables + */ + if (boot_cpu_has(X86_FEATURE_ZEN2)) { + quirks = dmi->driver_data; + pr_info("Overriding nominal and lowest frequencies for %s\n", dmi->ident); + return 1; + } + + return 0; +} + +static const struct dmi_system_id amd_pstate_quirks_table[] __initconst = { + { + .callback = dmi_matched_7k62_bios_bug, + .ident = "AMD EPYC 7K62", + .matches = { + DMI_MATCH(DMI_BIOS_VERSION, "5.14"), + DMI_MATCH(DMI_BIOS_RELEASE, "12/12/2019"), + }, + .driver_data = &quirk_amd_7k62, + }, + {} +}; +MODULE_DEVICE_TABLE(dmi, amd_pstate_quirks_table); + static inline int get_mode_idx_from_str(const char *str, size_t size) { int i; @@ -812,8 +848,16 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata) if (ret) return ret; - min_freq = cppc_perf.lowest_freq * 1000; - nominal_freq = cppc_perf.nominal_freq * 1000; + if (quirks && quirks->lowest_freq) + min_freq = quirks->lowest_freq * 1000; + else + min_freq = cppc_perf.lowest_freq * 1000; + + if (quirks && quirks->nominal_freq) + nominal_freq = quirks->nominal_freq * 1000; + else + nominal_freq = cppc_perf.nominal_freq * 1000; + nominal_perf = READ_ONCE(cpudata->nominal_perf); highest_perf = READ_ONCE(cpudata->highest_perf); @@ -1662,6 +1706,11 @@ static int __init amd_pstate_init(void) if (cpufreq_get_current_driver()) return -EEXIST; + quirks = NULL; + + /* check if this machine need CPPC quirks */ + dmi_check_system(amd_pstate_quirks_table); + switch (cppc_state) { case AMD_PSTATE_UNDEFINED: /* Disable on the following configs by default: diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index ab7e82533718..6b832153a126 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -128,4 +128,10 @@ static const char * const amd_pstate_mode_string[] = { [AMD_PSTATE_GUIDED] = "guided", NULL, }; + +struct quirk_entry { + u32 nominal_freq; + u32 lowest_freq; +}; + #endif /* _LINUX_AMD_PSTATE_H */