From patchwork Mon Mar 18 15:49:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13595499 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2481EC54E5D for ; Mon, 18 Mar 2024 15:51:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YpNGT2ID5XM4gq+ILowpX4GoeYU1bV0l+jJX5+0NnOk=; b=rIiWddlW21bQUo A/5nWiouM19xDCtQO4rNWyXxdUPO8aSoSsFfEUx6XPjYl1oWGwAi7f9b1qG6P1KCKgC0gf5hhGHDb skNyZkaFohPc2jKvBvGJQonxsli6g7UkEUoPCMdACery4JrCr+yhlMUfsn95B1WSoI1RivSU26WAG gsV9xQ2NWsPMCQtRimiOL6+6wq3oB5nzuBljSE7VJuVOV22U3ILehgTW9U2bhDYVCCy70Af2mnx1B vHWZ2NI00fzK/DmXFX35vvkQrvEkcXOtSo6p0qT/uf+rmhCzj1AzSBGwlKZVhVQii/caSu6JysIAq tSIxnu/QM2AXCxdAmIXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmFGe-000000096KA-1VZn; Mon, 18 Mar 2024 15:51:16 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmFGY-000000096HZ-3SZu; Mon, 18 Mar 2024 15:51:12 +0000 Received: from [127.0.1.1] (91-154-34-181.elisa-laajakaista.fi [91.154.34.181]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D8BC11B1C; Mon, 18 Mar 2024 16:50:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710777041; bh=vFEF/OGYpnkktObt7GRCXvKVIPiNuH/3wZneowmoO2I=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Z8+NyVtn4em2i8blDUKcsmGRiU2QTA1dCqc9g/+vwZwvB2kX90wnbaFEA8aGp7QD5 1lxa7Z2SJO2sai/M87Xs761h0XkLnO1r3I9u8Hsg+R7nt7kHdDLD5N7sNnDR7Bifu1 rTdXPWHb3O3gL/IV1FDgHuzlVlW0lnFNN1MaOE2g= From: Tomi Valkeinen Date: Mon, 18 Mar 2024 17:49:56 +0200 Subject: [PATCH 1/4] media: uapi: Add meta formats for PiSP FE config and stats MIME-Version: 1.0 Message-Id: <20240318-rp1-cfe-v1-1-ac6d960ff22d@ideasonboard.com> References: <20240318-rp1-cfe-v1-0-ac6d960ff22d@ideasonboard.com> In-Reply-To: <20240318-rp1-cfe-v1-0-ac6d960ff22d@ideasonboard.com> To: Mauro Carvalho Chehab , Raspberry Pi Kernel Maintenance , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naushir Patuck , Laurent Pinchart , Sakari Ailus , Jacopo Mondi , Kieran Bingham , Tomi Valkeinen X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4239; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=vFEF/OGYpnkktObt7GRCXvKVIPiNuH/3wZneowmoO2I=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBl+GLoQiGKkmp9T7eCWGA0g1jd2pCFPuauIw9ss DsaPZybQv2JAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZfhi6AAKCRD6PaqMvJYe 9Tx1D/oCn/zaGnZu1Jl5GazYhG6+m1v2p2UYXJ9gKHErKw3w8Ni1zRRN+PuXU/SLqkApEDY+4ez ww/b87Royxd6h8nQK5CCVef65kVWn0lBMoNKhb/YVNlEYGlDvwez/dowkhzCfQrU1k0RRJVAFl2 EEKIV4g/1EkZEwritusWQ8ST9F9KOf5hCY5F+2/DPd3zaqSJKhbr5nOSxedBjqp+cHtj5tngGqS 92nA9vnnR6i0UbtkPGjFbLzmC0Ap+oKjGISvcSSpXZLuIQh1GKgJtfFzC0NEkHj0YJ3vCd9s0nO c1V/BwZUqqa/4HMBInwvaD1JIcLgFJxIXtOfL8Sk9NwRNAsuyjaUx4f4/GMLkRnpViq8j2H/5b9 qm9kNZm2wzLlrDenS3KWSEd0lJhM04FZCtNw3yUvme4oOq2mRpCYI+8BHdqUZnNZ8HHU6DQUkFF 95IKT8tRkPELM4OVm1nkH7Rzw3w3e2F8NOXPpLDLM50Bi4coWvmLnGraCEWvi0tTO1K/n3nDJZU RkaTFeeBB3h4Unxf5W0p5yHDxzE0Qkw4qkBcYHXVQDHMfwkht21hanbA4ULSHv98Mty9nVzSFUP ndzXIAoB7zUPou9Hjc/Yt0J45o8NVNmWHDBoTWIqRSw5UKBgyLYoaZ+akm79mzl87DHu05PIn0E aBEIVfH1Fgp2mvA== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_085111_048660_02FE114D X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add two meta formats for PiSP FE: V4L2_META_FMT_RPI_FE_CFG and V4L2_META_FMT_RPI_FE_STATS. The former is used to provide configuration for the FE and the latter is used to read the statistics from the FE. Signed-off-by: Tomi Valkeinen --- .../userspace-api/media/v4l/meta-formats.rst | 1 + .../userspace-api/media/v4l/metafmt-pisp-fe.rst | 39 ++++++++++++++++++++++ drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ include/uapi/linux/videodev2.h | 2 ++ 4 files changed, 44 insertions(+) diff --git a/Documentation/userspace-api/media/v4l/meta-formats.rst b/Documentation/userspace-api/media/v4l/meta-formats.rst index d82a5a9cbd2f..19493c579a8c 100644 --- a/Documentation/userspace-api/media/v4l/meta-formats.rst +++ b/Documentation/userspace-api/media/v4l/meta-formats.rst @@ -15,6 +15,7 @@ These formats are used for the :ref:`metadata` interface only. metafmt-d4xx metafmt-intel-ipu3 metafmt-pisp-be + metafmt-pisp-fe metafmt-rkisp1 metafmt-uvc metafmt-vsp1-hgo diff --git a/Documentation/userspace-api/media/v4l/metafmt-pisp-fe.rst b/Documentation/userspace-api/media/v4l/metafmt-pisp-fe.rst new file mode 100644 index 000000000000..fddeada83e4a --- /dev/null +++ b/Documentation/userspace-api/media/v4l/metafmt-pisp-fe.rst @@ -0,0 +1,39 @@ +.. SPDX-License-Identifier: GPL-2.0 + +.. _v4l2-meta-fmt-rpi-fe-cfg: + +************************ +V4L2_META_FMT_RPI_FE_CFG +************************ + +Raspberry Pi PiSP Front End configuration format +================================================ + +The Raspberry Pi PiSP Front End image signal processor is configured by +userspace by providing a buffer of configuration parameters to the +`rp1-cfe-fe-config` output video device node using the +:c:type:`v4l2_meta_format` interface. + +The `Raspberry Pi PiSP technical specification +`_ +provide detailed description of the Front End configuration and programming +model. + +.. _v4l2-meta-fmt-rpi-fe-stats: + +************************** +V4L2_META_FMT_RPI_FE_STATS +************************** + +Raspberry Pi PiSP Front End statistics format +============================================= + +The Raspberry Pi PiSP Front End image signal processor provides statistics data +by writing to a buffer provided via the `rp1-cfe-fe-stats` capture video device +node using the +:c:type:`v4l2_meta_format` interface. + +The `Raspberry Pi PiSP technical specification +`_ +provide detailed description of the Front End configuration and programming +model. diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index 0b4f5372c217..1d44303b7e81 100644 --- a/drivers/media/v4l2-core/v4l2-ioctl.c +++ b/drivers/media/v4l2-core/v4l2-ioctl.c @@ -1465,6 +1465,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) case V4L2_META_FMT_GENERIC_CSI2_20: descr = "8b Generic Meta, 20b CSI-2"; break; case V4L2_META_FMT_GENERIC_CSI2_24: descr = "8b Generic Meta, 24b CSI-2"; break; case V4L2_META_FMT_RPI_BE_CFG: descr = "RPi PiSP BE Config format"; break; + case V4L2_META_FMT_RPI_FE_CFG: descr = "RPi PiSP FE Config format"; break; + case V4L2_META_FMT_RPI_FE_STATS: descr = "RPi PiSP FE Statistics format"; break; default: /* Compressed formats */ diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 1eb60baeb3ea..ad1a519eefe5 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -865,6 +865,8 @@ struct v4l2_pix_format { /* Vendor specific - used for RaspberryPi PiSP */ #define V4L2_META_FMT_RPI_BE_CFG v4l2_fourcc('R', 'P', 'B', 'C') /* PiSP BE configuration */ +#define V4L2_META_FMT_RPI_FE_CFG v4l2_fourcc('R', 'P', 'F', 'C') +#define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S') /* priv field value to indicates that subsequent fields are valid. */ #define V4L2_PIX_FMT_PRIV_MAGIC 0xfeedcafe From patchwork Mon Mar 18 15:49:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13595500 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B656EC54E5D for ; Mon, 18 Mar 2024 15:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kHyCoRFbLti1vkegjpAi2Va+KYT8KeHCWGKN4KuRzFo=; b=aMLvhI9lS7roWi GFJVsBhZyEbcEmIG45T8uv+CtDy1jGRUoNXJp3STWzsgE+rtHekwgjmSlMxYg9ODV7CizlWJer8Oc LuXTPUx8d2hyyVqt16FnclB+T8P6EHmtAHDEk51CRGVVTlW6VttgFcFSwbDzae1edRHIe4OdlkBKa ZF+OQpwAmEHJwFHJQ6pmbIXpuRGNr21Ax0x8YZF2eBRZqEFoIW/R7nPpLHQN2lWvUT5RKMq6uGdoi MZf0ZQvpWBxwi1VvAkIt6qyTV3eA9OVhwjgWeFEI2rasKJUrSYUP01/7MWxKeEeRyLT7/Qzd23Z/r x5LNXnu2HT2ide2Acbgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmFGp-000000096PS-3lc0; Mon, 18 Mar 2024 15:51:27 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmFGZ-000000096He-1CZk; Mon, 18 Mar 2024 15:51:14 +0000 Received: from [127.0.1.1] (91-154-34-181.elisa-laajakaista.fi [91.154.34.181]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D0CCE1BB1; Mon, 18 Mar 2024 16:50:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710777042; bh=9cqGmKwZifEH6rqhzO+wwC/ZEXL/+VH+UB9wjLsmb24=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=LUkqxqdZWyBYeB4UtMmsZxRc0Yh4TKpYQmkzuRWkCNyJmSWDmvsNUyPm5LFsbvtIE 7ot16zP3LlEApvDik6eAw6WE2dmLLy8pUa+CIBhVxCt0bL6P3bSPvPGYMIexJlh/A8 zKmlzLPWxAsf7Q9MuCL40T6Bw8lg8dAJ5evppEZM= From: Tomi Valkeinen Date: Mon, 18 Mar 2024 17:49:57 +0200 Subject: [PATCH 2/4] dt-bindings: media: Add bindings for raspberrypi,rp1-cfe MIME-Version: 1.0 Message-Id: <20240318-rp1-cfe-v1-2-ac6d960ff22d@ideasonboard.com> References: <20240318-rp1-cfe-v1-0-ac6d960ff22d@ideasonboard.com> In-Reply-To: <20240318-rp1-cfe-v1-0-ac6d960ff22d@ideasonboard.com> To: Mauro Carvalho Chehab , Raspberry Pi Kernel Maintenance , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naushir Patuck , Laurent Pinchart , Sakari Ailus , Jacopo Mondi , Kieran Bingham , Tomi Valkeinen X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3190; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=9cqGmKwZifEH6rqhzO+wwC/ZEXL/+VH+UB9wjLsmb24=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBl+GLovjHMleKcyqpNl3qYB2Zl8zJiIsjrJjwcB 623441VsPaJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZfhi6AAKCRD6PaqMvJYe 9daID/9Vk05kVIENDX8siHbb/gXnQQ1MfV1RjpSpU+DEyq1f/tyhNkOHexkLMgZQkyqYgIABF5+ N8GEapnFWM7axkCkpQ1eZSi2if6yiGaVUPu7OwyGQoWuViPsgHh0dK9FMhvr48B77+BnSunZJqE fuUeUiFBPfMpbfRlAYuyeuzMkP9sia1JKCFILy3IDDDuJ08s1j0Dhlggd3wg2ZarwMVtYTTlCn2 4ikl7Y7twLdgJtUlm2jcDgLh9HbYX2IqLcubsEDas11JTV9hIdY2CI0mfFHc7sM8dg8fy4oy1wR FZ8zvYvkDx5DeGhUfR8BwXhH9CMhYrQXWwEsd6R+lSPka9uBM4gN7wk2a0tFoQck9C6DkDwE8vT 97utB/jjk4KICRX1Hble5RslNX0+jFRYKtudJtBOS9Y/xhP0TvMqds8FEFG3XktZvqgTbBqku0f 622c57VZ6scgvXiF4mQZrIfTevNYxjZg4J7ILJjOE6DFVLAd9E/Wet2aaEV9Zy5kDbgUJgWU+9B QbNhnenLWHpp8DHm8Qg/623qSibfCMZkdedjFRVfrrCdRHUA7/1IwfwoRBNRUwnsECaSUerWIZ0 3DPRVsEawg1e0WoOSIe2VqQNx8Gs8cAuS8TIhf6W5ZVfqTPda0WJJto/Fg6lWijGCkdC4rawa8/ RLIUgGCr7jkMdeg== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_085111_575864_F6E2A300 X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add DT bindings for raspberrypi,rp1-cfe. Signed-off-by: Tomi Valkeinen --- .../bindings/media/raspberrypi,rp1-cfe.yaml | 103 +++++++++++++++++++++ 1 file changed, 103 insertions(+) diff --git a/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml b/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml new file mode 100644 index 000000000000..7b2beeaaab0e --- /dev/null +++ b/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml @@ -0,0 +1,103 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/raspberrypi,rp1-cfe.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Raspberry Pi PiSP Camera Front End + +maintainers: + - Tomi Valkeinen + - Raspberry Pi Kernel Maintenance + +description: | + The Raspberry Pi PiSP Camera Front End is a module in Raspberrypi 5's RP1 I/O + controller, that contains: + - MIPI D-PHY + - MIPI CSI-2 receiver + - Simple image processor (called PiSP Front End, or FE) + + The FE documentation is available at: + https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf + + The PHY and CSI-2 receiver part have no public documentation. + +properties: + compatible: + const: raspberrypi,rpi5-rp1-cfe + + reg: + items: + - description: CSI-2 registers + - description: D-PHY registers + - description: MIPI CFG (a simple top-level mux) registers + - description: FE registers + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + description: CSI-2 RX Port + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + minItems: 1 + maxItems: 4 + + clock-lanes: + maxItems: 1 + + clock-noncontinuous: true + + required: + - clock-lanes + - data-lanes + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include + #include + #include + + rpi1 { + #address-cells = <2>; + #size-cells = <2>; + + csi@110000 { + compatible = "raspberrypi,rp1-cfe"; + reg = <0xc0 0x40110000 0x0 0x100>, + <0xc0 0x40114000 0x0 0x100>, + <0xc0 0x40120000 0x0 0x100>, + <0xc0 0x40124000 0x0 0x1000>; + + interrupts = ; + + clocks = <&rp1_clocks RP1_CLK_MIPI0_CFG>; + + port { + csi_ep: endpoint { + remote-endpoint = <&cam_endpoint>; + clock-lanes = <0>; + data-lanes = <1 2>; + }; + }; + }; + }; From patchwork Mon Mar 18 15:49:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13595501 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84BACC54E5D for ; Mon, 18 Mar 2024 15:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mpofdo2QmfsOImO70Grwb4U5owPUVZlwYFuuDUG/uQU=; b=VXXiy/qbVMulzN MIIA6ABAtwAHux2r+RV3fWo75sPsi+wk7FikvcmSYTwGYntpDVnHLzha7XPXK6QupH0vP6JSm7hLm 21vw/SR1WPDxy8S+K0UuPMXqb4ATtusNN/1okC7sMOiN8I3o1qtpxISbXuoD9C8bnV8p8tkvuCiDe 9ctsIFCSCxkuLHNup0cq4IoVSQTe7qFIza0ctN/a5LGk7JBqDyD0FDtK1WqZHksbKc00Rht+teaGz tzdDcmz36mGGnPmG7a5REUxJzFgPzit/O3QrcgVqMwtBUJ47U6stvDoLVS+2yzB0LNQT3Px+I11So lLpfu61JeHbJVnbgsSag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmFGr-000000096QU-1eXn; Mon, 18 Mar 2024 15:51:29 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmFGa-000000096ID-0U71; Mon, 18 Mar 2024 15:51:14 +0000 Received: from [127.0.1.1] (91-154-34-181.elisa-laajakaista.fi [91.154.34.181]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EE9B01FB1; Mon, 18 Mar 2024 16:50:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710777044; bh=jDy2bk5yUpu/wRarNxbYZJ4R4dFghppwsZWkImSP4Mk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dCssnwzV7glXnKwC8s/8Xzai/vVLM/2Tsv4uL+JkvEdgfOGOeInfgGFWoQDAds2HS Stm8xL7yrJRYWClHNuTaYICKqkI6/CoH8h54tBrCQ6SdFGQKKHswukZTVQMDDCJdp2 iNQIC5hL0M0maMoD6jODFwp9JYM0GYYnEAi3+UKM= From: Tomi Valkeinen Date: Mon, 18 Mar 2024 17:49:59 +0200 Subject: [PATCH 4/4] media: admin-guide: Document the Raspberry Pi CFE (rp1-cfe) MIME-Version: 1.0 Message-Id: <20240318-rp1-cfe-v1-4-ac6d960ff22d@ideasonboard.com> References: <20240318-rp1-cfe-v1-0-ac6d960ff22d@ideasonboard.com> In-Reply-To: <20240318-rp1-cfe-v1-0-ac6d960ff22d@ideasonboard.com> To: Mauro Carvalho Chehab , Raspberry Pi Kernel Maintenance , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naushir Patuck , Laurent Pinchart , Sakari Ailus , Jacopo Mondi , Kieran Bingham , Tomi Valkeinen X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=6375; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=jDy2bk5yUpu/wRarNxbYZJ4R4dFghppwsZWkImSP4Mk=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBl+GLpAUkyF4pVVtErxFmbK/rOeY7jLHGp7g2S5 zo9rhAQ3yiJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZfhi6QAKCRD6PaqMvJYe 9TcTD/9fEh4AwaHUQD0ALozBILy86k/3q7VJSNpMxA4P0ErdHqrnpbc8GodPhiM04BkZNNjJUsi hfbWr2qgBp09kjT+17s4xEyVAesqcikRGwrz38JjnuA+m8kbIBbrFbVGMI3r56dPzmCUooZQU7a pJ9K3i513EUKwxCH+1JtCgIs4sC3m1VW7vUODFTOefOoTanQZTunUp50Jdk2o5T32bMrbJ04Y5E tWHjKCb2VC6K/ivdtKj4AxJUyP/lP4aZTBZhT/LYgNJ76QMqbfbAFOJDHALs21+4EIvp9zeYvuc 7nDgTXKDOtNs1Jf8iTLMl/AVcNy55sB05J/IiarjT7EDHgQI7Bunt3TYtGRg3xz91gCg5Nxz8kT Ru8ypSNszjYhYeVu/D24TplR2dHnU4UUp5Afas37y0JdvgltjNCXggksuFPFLGhPZEqwMfdaUGW zUx2pyug//202NXc8Weiri7KSaKwl8x5BTAlcvKPb7smlNuR0Nfmy7ucuh5LzAHUT1Jqn2PrkLD b1R7gLlFiSLdqMewvP24+xkT+i+bTh2YNyVQZhOCRpSLk4t/xmhbB/OSBOKRtwwMQTLAtYUV/3p IyetDWzdfVe0DaGqjRSYkwCqdTT69wE+IUZgSU8KSrQV6r+0O7DQLavzOfHDAuiR9gjzl5Jtk9h 9xjI9Lf9UikNDrg== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_085112_334055_7FA41955 X-CRM114-Status: GOOD ( 16.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add documentation for rp1-cfe driver. Signed-off-by: Tomi Valkeinen --- .../admin-guide/media/raspberrypi-rp1-cfe.dot | 27 ++++++++ .../admin-guide/media/raspberrypi-rp1-cfe.rst | 78 ++++++++++++++++++++++ Documentation/admin-guide/media/v4l-drivers.rst | 1 + 3 files changed, 106 insertions(+) diff --git a/Documentation/admin-guide/media/raspberrypi-rp1-cfe.dot b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.dot new file mode 100644 index 000000000000..7717f2291049 --- /dev/null +++ b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.dot @@ -0,0 +1,27 @@ +digraph board { + rankdir=TB + n00000001 [label="{{ 0} | csi2\n/dev/v4l-subdev0 | { 1 | 2 | 3 | 4}}", shape=Mrecord, style=filled, fillcolor=green] + n00000001:port1 -> n00000011 [style=dashed] + n00000001:port1 -> n00000007:port0 + n00000001:port2 -> n00000015 + n00000001:port2 -> n00000007:port0 [style=dashed] + n00000001:port3 -> n00000019 [style=dashed] + n00000001:port3 -> n00000007:port0 [style=dashed] + n00000001:port4 -> n0000001d [style=dashed] + n00000001:port4 -> n00000007:port0 [style=dashed] + n00000007 [label="{{ 0 | 1} | pisp-fe\n/dev/v4l-subdev1 | { 2 | 3 | 4}}", shape=Mrecord, style=filled, fillcolor=green] + n00000007:port2 -> n00000021 + n00000007:port3 -> n00000025 [style=dashed] + n00000007:port4 -> n00000029 + n0000000d [label="{imx219 6-0010\n/dev/v4l-subdev2 | { 0}}", shape=Mrecord, style=filled, fillcolor=green] + n0000000d:port0 -> n00000001:port0 [style=bold] + n00000011 [label="rp1-cfe-csi2-ch0\n/dev/video0", shape=box, style=filled, fillcolor=yellow] + n00000015 [label="rp1-cfe-csi2-ch1\n/dev/video1", shape=box, style=filled, fillcolor=yellow] + n00000019 [label="rp1-cfe-csi2-ch2\n/dev/video2", shape=box, style=filled, fillcolor=yellow] + n0000001d [label="rp1-cfe-csi2-ch3\n/dev/video3", shape=box, style=filled, fillcolor=yellow] + n00000021 [label="rp1-cfe-fe-image0\n/dev/video4", shape=box, style=filled, fillcolor=yellow] + n00000025 [label="rp1-cfe-fe-image1\n/dev/video5", shape=box, style=filled, fillcolor=yellow] + n00000029 [label="rp1-cfe-fe-stats\n/dev/video6", shape=box, style=filled, fillcolor=yellow] + n0000002d [label="rp1-cfe-fe-config\n/dev/video7", shape=box, style=filled, fillcolor=yellow] + n0000002d -> n00000007:port1 +} diff --git a/Documentation/admin-guide/media/raspberrypi-rp1-cfe.rst b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.rst new file mode 100644 index 000000000000..668d978a9875 --- /dev/null +++ b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.rst @@ -0,0 +1,78 @@ +.. SPDX-License-Identifier: GPL-2.0 + +============================================ +Raspberry Pi PiSP Camera Front End (rp1-cfe) +============================================ + +The PiSP Camera Front End +========================= + +The PiSP Camera Front End (CFE) is a module which combines a CSI-2 receiver with +a simple ISP, called the Front End (FE). + +The CFE has four DMA engines and can write frames from four separate streams +received from the CSI-2 to the memory. One of those streams can also be routed +directly to the FE, which can do minimal image processing, write two versions +(e.g. non-scaled and downscaled versions) of the received frames to memory and +provide statistics of the received frames. + +The FE registers are documented in the `Raspberry Pi Image Signal Processor +(ISP) Specification document +`_, +and example code for FE can be found in `libpisp +`_. + +The rp1-cfe driver +================== + +The Raspberry Pi PiSP Camera Front End (rp1-cfe) driver is located under +drivers/media/platform/raspberrypi/rp1-cfe. It uses the `V4L2 API` to register +a number of video capture and output devices, the `V4L2 subdev API` to register +subdevices for the CSI-2 received and the FE that connects the video devices in +a single media graph realized using the `Media Controller (MC) API`. + +The media topology registered by the `rp1-cfe` driver, in this particular +example connected to an imx219 sensor, is the following one: + +.. _rp1-cfe-topology: + +.. kernel-figure:: raspberrypi-rp1-cfe.dot + :alt: Diagram of an example media pipeline topology + :align: center + +The media graph contains the following video device nodes: + +- rp1-cfe-csi2-ch0: capture device for the first CSI-2 stream +- rp1-cfe-csi2-ch1: capture device for the second CSI-2 stream +- rp1-cfe-csi2-ch2: capture device for the third CSI-2 stream +- rp1-cfe-csi2-ch3: capture device for the fourth CSI-2 stream +- rp1-cfe-fe-image0: capture device for the first FE output +- rp1-cfe-fe-image1: capture device for the second FE output +- rp1-cfe-fe-stats: capture device for the FE statistics +- rp1-cfe-fe-config: output device for FE configuration + +rp1-cfe-csi2-chX +---------------- + +The rp1-cfe-csi2-chX capture devices are normal V4L2 capture devices which +can be used to capture video frames or metadata received from the CSI-2. + +rp1-cfe-fe-image0, rp1-cfe-fe-image1 +------------------------------------ + +The rp1-cfe-fe-image0 and rp1-cfe-fe-image1 capture devices are used to write +the processed frames to memory. + +rp1-cfe-fe-stats +---------------- + +The format of the FE statistics buffer is defined by +:c:type:`pisp_statistics` C structure and the meaning of each parameter is +described in the `PiSP specification` document. + +rp1-cfe-fe-config +----------------- + +The format of the FE configuration buffer is defined by +:c:type:`pisp_fe_config` C structure and the meaning of each parameter is +described in the `PiSP specification` document. diff --git a/Documentation/admin-guide/media/v4l-drivers.rst b/Documentation/admin-guide/media/v4l-drivers.rst index c15a6bb952d9..20be545e866c 100644 --- a/Documentation/admin-guide/media/v4l-drivers.rst +++ b/Documentation/admin-guide/media/v4l-drivers.rst @@ -25,6 +25,7 @@ Video4Linux (V4L) driver-specific documentation raspberrypi-pisp-be rcar-fdp1 rkisp1 + raspberrypi-rp1-cfe saa7134 si470x si4713