From patchwork Tue Mar 26 18:54:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Folker Schwesinger via B4 Relay X-Patchwork-Id: 13604887 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 192B6C54E67 for ; Tue, 26 Mar 2024 18:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References: Message-Id:MIME-Version:Subject:Date:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YRdscBCiyUfqFWbNmvOiN1IlWA5ehHv8vft2wHfVkvM=; b=gwVD39QKXJAvTc QA6hrBX+bLDka2k44/PHA5kx2/6BaU9fOb7AUD3GM3eTPE+akI5fCVOOxyqOmnmQ51HevULPuBv8R LAwf7V7Rg1wsYR0HF7pD02D69N1HtEndxc1UcU9pK9bTthL6SkXUXlMaqhaa0w+FilO/36hEOXVcG JGRbTvWB/u4LRnLdG+Kdzivm0ihjPyps15PLwjr0O8aJQ2tBJLuUx8KN/KQ4YgoGoVPXQdI0RH17U it6HHflxlyOAZII8Pg/sR81dUAioxOgobmW39p4bEIyu3EkR4gp19d0HPdmS/9SFrKW9VzBBIv0w4 JYRnKLh5MPlfXpwMdY5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBzU-0000000624C-0s1o; Tue, 26 Mar 2024 18:57:44 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBzC-000000061uv-2pss; Tue, 26 Mar 2024 18:57:28 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E29C4CE23E1; Tue, 26 Mar 2024 18:57:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id C36E4C43390; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711479443; bh=Gsn3xXI5BKQL/2L//Z3WWmwk7DoW960rhzJRT9Ymakc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=NFkZy5Y9KO2Hxq0mI84mZ9prB6Fytp67o6i5a/E4qS3vwxvFWzhv4AIpeM160GWfp AAmVMtfAXgmahmiyPwYN8nj4zBFY3Yyb+7Y4bIJbrE2u1iNhqZNOAGzurwjF72Rv8w /KsXhV57usRVY+CgK3FCqCGbAvn/v0XQNJpzuteTKJK/lbrh89y7fxabQIulbXB/JA Nf1GxyoCfRttFrH1QcjZdSQR+usSkjZ+OKL69z2gBjilVDX6dcH7rekmOelO6shf2x kjd2otmYtZT0F6WGyEViMFAPXuPlKBhKx0SbtgYA8u9vLzkiIzNCu1QTykOLUtfuux LNau16lWcj5bQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2E1EC6FD1F; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) From: Folker Schwesinger via B4 Relay Date: Tue, 26 Mar 2024 19:54:35 +0100 Subject: [PATCH 1/3] phy: rockchip: emmc: Enable pulldown for strobe line MIME-Version: 1.0 Message-Id: <20240326-rk-default-enable-strobe-pulldown-v1-1-f410c71605c0@folker-schwesinger.de> References: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> In-Reply-To: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Chris Ruehl , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Christopher Obbard , Alban Browaeys , Doug Anderson , Brian Norris , Jensen Huang , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Folker Schwesinger X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2253; i=dev@folker-schwesinger.de; h=from:subject:message-id; bh=vn1WaogVqkovnF++lKXXa6btFkOAZlcxkgTSF4vHKKI=; b=owGbwMvMwCXG5FBoZNu1u5bxtFoSQxqz1ESGm1xxESWPdL0nBP77tEF529PKYs66r0ez70y8w 2eS2Tm5o5SFQYyLQVZMkYU1L2MLc2b5Uuuun69h5rAygQ3h4hSAibCEMfwVOiHs8frNmQnzo1mu GdVGya19sFMoZ+G78y36Xp3W6h5fGRnaD1XFVlhoO08onHh787XvZ+ad11Ko0L/3/tkVv8uFT66 zAQA= X-Developer-Key: i=dev@folker-schwesinger.de; a=openpgp; fpr=056E68B4036977A53B8AF9EB024071323D8ABB7D X-Endpoint-Received: by B4 Relay for dev@folker-schwesinger.de/default with auth_id=144 X-Original-From: Folker Schwesinger X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_115727_123404_9AEA0B3A X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: dev@folker-schwesinger.de Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org From: Folker Schwesinger Restore the behavior of the Rockchip kernel that undconditionally enables the internal strobe pulldown. As the DT property rockchip,enable-strobe-pulldown is obsolete now, replace it with a property to disable the internal pulldown. This fixes I/O errors observed on various Rock Pi 4 and NanoPi4 series boards with some eMMC modules. Other boards may also be affected. An example of these errors is as follows: [ 290.060817] mmc1: running CQE recovery [ 290.061337] blk_update_request: I/O error, dev mmcblk1, sector 1411072 op 0x1:(WRITE) flags 0x800 phys_seg 36 prio class 0 [ 290.061370] EXT4-fs warning (device mmcblk1p1): ext4_end_bio:348: I/O error 10 writing to inode 29547 starting block 176466) [ 290.061484] Buffer I/O error on device mmcblk1p1, logical block 172288 Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts") Signed-off-by: Folker Schwesinger --- drivers/phy/rockchip/phy-rockchip-emmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c index 20023f6eb994..6e637f3e1b19 100644 --- a/drivers/phy/rockchip/phy-rockchip-emmc.c +++ b/drivers/phy/rockchip/phy-rockchip-emmc.c @@ -376,14 +376,14 @@ static int rockchip_emmc_phy_probe(struct platform_device *pdev) rk_phy->reg_offset = reg_offset; rk_phy->reg_base = grf; rk_phy->drive_impedance = PHYCTRL_DR_50OHM; - rk_phy->enable_strobe_pulldown = PHYCTRL_REN_STRB_DISABLE; + rk_phy->enable_strobe_pulldown = PHYCTRL_REN_STRB_ENABLE; rk_phy->output_tapdelay_select = PHYCTRL_OTAPDLYSEL_DEFAULT; if (!of_property_read_u32(dev->of_node, "drive-impedance-ohm", &val)) rk_phy->drive_impedance = convert_drive_impedance_ohm(pdev, val); - if (of_property_read_bool(dev->of_node, "rockchip,enable-strobe-pulldown")) - rk_phy->enable_strobe_pulldown = PHYCTRL_REN_STRB_ENABLE; + if (of_property_read_bool(dev->of_node, "rockchip,disable-strobe-pulldown")) + rk_phy->enable_strobe_pulldown = PHYCTRL_REN_STRB_DISABLE; if (!of_property_read_u32(dev->of_node, "rockchip,output-tapdelay-select", &val)) { if (val <= PHYCTRL_OTAPDLYSEL_MAXVALUE) From patchwork Tue Mar 26 18:54:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Folker Schwesinger via B4 Relay X-Patchwork-Id: 13604885 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDABAC6FD1F for ; Tue, 26 Mar 2024 18:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References: Message-Id:MIME-Version:Subject:Date:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tz9zlG5sAqhNXGfocyZEcMpX+Y2j/eP2/o2R3rOIDNo=; b=1nQcVjD6/rCYd/ RrUH4//oOwzWLFPXOBdM9Lh+d4iBm9NEK+8cfC8ETWb0H8qA299ykOIzZH6EP9fmGljNz9AITNh/9 Rwq5qamo0XgZ9anT4ay8v5IbQa+x8zHaZGt2bVaQSg0GCdS+/cRiqbD98CJ7/+b+v0oFdwcGH1qpY L3DU+ayjOdukezTwWzFGs5yZKHLT2WrK17ID6N+4jsgYbQXfJ72fUsE6VSSGUVlja/IF+ThaDuiXb tYwe7qo6EGezPvoTnnog8knAHKT3yWtOKogY72Ys6RVlBp/hLyjax2HXZYDHcuL95o93gMlFq6rM+ gFW9vkcVQzAKJ9s3Exlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBzH-000000061yv-1Ovu; Tue, 26 Mar 2024 18:57:31 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBzB-000000061up-3PQB; Tue, 26 Mar 2024 18:57:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E143761369; Tue, 26 Mar 2024 18:57:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id DB434C433B2; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711479443; bh=G6mc0QUGBHLFWSqnsGqxmIC8vKxJ1zCnaOScx8J3TQA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=UnQb6l4ori1UnlnKacvSGErLo7U07JRCVt2nPfBNLMm44T/m7r57d0/k0u/sid38R lEBu8yksww/lt7cmBkm/FqLKSnNQHHiZjpLyWFP2PCCwAX55oI4Dn9SvCwc8eDbZks tMtGccHuh2dcIaWD3CNx7FELxVrUOBZJiF3z9WFPTiNPxMoZ0cW38iyNa2NHdF2CYf 288bUFgzLAy7EVmpyhht7M8tIz9Vqa6C2VBSDZNWLpVFTJY4atccQGkgXXWpG1mDi0 Ttv6Sl53VFMqMWxl0rmjxgw8/M3ISM5SW1GT4n1Nhv1F+LrX3GzLQWLCEskDxWSRYF vjNMsFjrJGcIg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C739FC54E67; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) From: Folker Schwesinger via B4 Relay Date: Tue, 26 Mar 2024 19:54:36 +0100 Subject: [PATCH 2/3] devicetree: phy: rockchip-emmc: Document changed strobe-pulldown property MIME-Version: 1.0 Message-Id: <20240326-rk-default-enable-strobe-pulldown-v1-2-f410c71605c0@folker-schwesinger.de> References: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> In-Reply-To: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Chris Ruehl , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Christopher Obbard , Alban Browaeys , Doug Anderson , Brian Norris , Jensen Huang , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Folker Schwesinger X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1613; i=dev@folker-schwesinger.de; h=from:subject:message-id; bh=lYZfvZDtpySgOOqOAfgoLZ9THvZvx3kUJVgOxDEo5RE=; b=owGbwMvMwCXG5FBoZNu1u5bxtFoSQxqz1KSXEXPm32GZ9Ic3tF984fKDer0GAtunykV0cP6yz H7bbzOzo5SFQYyLQVZMkYU1L2MLc2b5Uuuun69h5rAygQxh4OIUgIloiDH8M3MoEvsnn9Sap6p9 m/mcrMz8Y3p7k5le/NnupqBbaKzYzfA/8b/SW42WBQVnEx5bsJ+P/fN+1SF+002WnFemZ19pzyr mAAA= X-Developer-Key: i=dev@folker-schwesinger.de; a=openpgp; fpr=056E68B4036977A53B8AF9EB024071323D8ABB7D X-Endpoint-Received: by B4 Relay for dev@folker-schwesinger.de/default with auth_id=144 X-Original-From: Folker Schwesinger X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_115725_982921_AE09190D X-CRM114-Status: GOOD ( 11.57 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: dev@folker-schwesinger.de Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org From: Folker Schwesinger Document the changes regarding the optional strobe-pulldown property. These changes are necessary as the default behavior of the driver was restored to the Rockchip kernel behavior of enabling the internal pulldown by default. Fixes: f34e43f12382 ("devicetree: phy: rockchip-emmc: pulldown property") Signed-off-by: Folker Schwesinger --- Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt index 57d28c0d5696..10c05437f7ab 100644 --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt @@ -16,8 +16,8 @@ Optional properties: - drive-impedance-ohm: Specifies the drive impedance in Ohm. Possible values are 33, 40, 50, 66 and 100. If not set, the default value of 50 will be applied. - - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe - line. If not set, pull-down is not used. + - rockchip,disable-strobe-pulldown: Disable internal pull-down for the strobe + line. If not set, pull-down is used. - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register. If not set, the register defaults to 0x4. Maximum value 0xf. From patchwork Tue Mar 26 18:54:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Folker Schwesinger via B4 Relay X-Patchwork-Id: 13604888 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36F87C6FD1F for ; Tue, 26 Mar 2024 18:57:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References: Message-Id:MIME-Version:Subject:Date:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qa6s1b/QhUXZvKr0hwlayV2oqFiW8d8xby8QeD6dsDE=; b=efKqJ9VzR1KNw7 IFxGiTMY9WZIgsNS3XWqzCCbS2BBjc73RlJgMwx/nHZyilYMoDNVuTbc2AdswP6idS9S0/P4GHd95 bPeraFYjj3TemCbWbEMQvWSs9hbZZ4mlwzQODJmf0XdaJ7AscrNko1ZoDjIthqeR2qCXoya1iSW2J tegSidos9uu18Y08bNTCbbtXgxCbjcLgbih4Spe5EA4fnPGm2XKukmKKRnEl/upQcDcqWh3zRcnvf zEqMNbW7mDSBNDYiOxRPw6Pf/Bt6eJBOx2WBi6TkG6VXLGSR9IfqQUHl2I4MnGoIm9d3W7oYELFZL xGjhC23rEV98PUjzdWHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBzg-000000062Dk-0YQB; Tue, 26 Mar 2024 18:57:56 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpBzE-000000061vb-3GBw; Tue, 26 Mar 2024 18:57:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 82CABCE23DB; Tue, 26 Mar 2024 18:57:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id E9F70C43330; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711479444; bh=t92rMDfisU2O183WicZRvvThqnLcj0E2zhg0sRyx/uA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=lxQWBkHE48NtOCNCYUMMn4GNtDMNqVx0YIxT9+GwVFAmFk2Jy32/hlFbq96lBba9b vuqJjKTu5OHyzHGWwylh05mfq+xheI8sSFEo0XpOG96PiYoMI6UnMvHidBtTMYj5ym ao1oMynsE/KpI4e78dA8NK0lWqep3aqTPbY6JxDouNhLSOvDB9/LfAPTnod7kCSRxX Nm5N4MYJYjnEZPWzsLHPddIE6dUnnydCU98EQ07dH3lpd1nXw4DhVey5JoVCpK9piB ZXrKBmVZRk5I4CrcDPkwQt9hcfu4CXpbND5w9/vvWTOohNr5X+8N3FWcDaOQf2+ehD XF7l6Q4b7gTnQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF2ECD1284; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) From: Folker Schwesinger via B4 Relay Date: Tue, 26 Mar 2024 19:54:37 +0100 Subject: [PATCH 3/3] arm64: dts: rockchip: Remove enable-strobe-pulldown for NanoPi4 boards MIME-Version: 1.0 Message-Id: <20240326-rk-default-enable-strobe-pulldown-v1-3-f410c71605c0@folker-schwesinger.de> References: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> In-Reply-To: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Chris Ruehl , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Christopher Obbard , Alban Browaeys , Doug Anderson , Brian Norris , Jensen Huang , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Folker Schwesinger X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=724; i=dev@folker-schwesinger.de; h=from:subject:message-id; bh=fmO1sP9nAwWwIfDKXcaV6YI0IH/hcl1UfJExvs0KGtI=; b=owGbwMvMwCXG5FBoZNu1u5bxtFoSQxqz1KSLdfclJe/cdDUz+/2kl+1vlNncrZtWMwXdsI2zz Obt51PvKGVhEONikBVTZGHNy9jCnFm+1Lrr52uYOaxMIEMYuDgFYCJlxowMUxteL/2zjlHg1162 50fY9v/3D+Q+G9j4zG9K5kYTttqjXowMV2buML48c6NI60+fT5tf/Q9o/dhVHZW/LE7hbpPWpuD v7AA= X-Developer-Key: i=dev@folker-schwesinger.de; a=openpgp; fpr=056E68B4036977A53B8AF9EB024071323D8ABB7D X-Endpoint-Received: by B4 Relay for dev@folker-schwesinger.de/default with auth_id=144 X-Original-From: Folker Schwesinger X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_115729_607214_05E8E90A X-CRM114-Status: UNSURE ( 9.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: dev@folker-schwesinger.de Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org From: Folker Schwesinger The Rockchip eMMC PHY driver enables the internal strobe pulldown by default. So, remove the enable-strobe-pulldown property from the NanoPi4 series boards DTS. Signed-off-by: Folker Schwesinger --- arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi index b7f1e47978a6..38af91b9e756 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi @@ -168,7 +168,6 @@ &cpu_l3 { }; &emmc_phy { - rockchip,enable-strobe-pulldown; status = "okay"; };