From patchwork Wed Mar 27 04:44:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kandpal, Suraj" X-Patchwork-Id: 13605571 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F6AEC54E67 for ; Wed, 27 Mar 2024 04:47:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A6F4910F7EE; Wed, 27 Mar 2024 04:47:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="M4mJEu8K"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 31C5A10F7ED for ; Wed, 27 Mar 2024 04:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711514820; x=1743050820; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9PM0sRPZDEK+2TTJknbOw2X+SgI7ZJ8N3Hh3c+P+CTw=; b=M4mJEu8K0i7bs8VyhH8N+iJOETkWJ7diLgC8Z8LDEr07kYXFdPqNz7J7 Ik+lxFCmFlY7qi19bnDGuKADQc5VvlIK7SqaovW0hedbEBtdap2NoVGZN qOrygnNsNhIUnlsbcmoSeUUwQmIe2Mfxl4Dbvyd3WzHxJaQS0r0Q4OO3Z iF8KbyCrVpLio5zjBMl3EZ9FQ9Cv95bgyiclC8vDtIAmvvfZz/laSc8A+ 5Tkz80m/bt0fmhmtxJEr4+fGpoQdmqPCWhSNzWwxipY7kZSdvC+wukQi5 WhOhZLbOpm9X9VnXC1iWJxZMQQevZdXj36A5hQdbKsnXBYkv0HKtYgC+1 Q==; X-CSE-ConnectionGUID: RDUfMgnnTZCKMkx0ewaOBA== X-CSE-MsgGUID: +QBVLdufSEydXTnqIAUNBQ== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="29072756" X-IronPort-AV: E=Sophos;i="6.07,157,1708416000"; d="scan'208";a="29072756" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 21:47:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,157,1708416000"; d="scan'208";a="47363388" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.32]) by fmviesa001.fm.intel.com with ESMTP; 26 Mar 2024 21:46:59 -0700 From: Suraj Kandpal To: intel-gfx@lists.freedesktop.org Cc: chaitanya.kumar.borah@intel.com, Suraj Kandpal Subject: [PATCH 1/2] drm/i915/display: Initialize capability variables Date: Wed, 27 Mar 2024 10:14:22 +0530 Message-ID: <20240327044422.240398-3-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240327044422.240398-2-suraj.kandpal@intel.com> References: <20240327044422.240398-2-suraj.kandpal@intel.com> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Initialize HDCP capability variables to false to avoid UBSAN warning in boolean value. --v2 -Fix Typo [Chaitanya] Signed-off-by: Suraj Kandpal Reviewed-by: Chaitanya Kumar Borah --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c index b99c024b0934..95d14dab089e 100644 --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c @@ -191,7 +191,7 @@ static void intel_hdcp_info(struct seq_file *m, struct intel_connector *intel_connector, bool remote_req) { - bool hdcp_cap, hdcp2_cap; + bool hdcp_cap = false, hdcp2_cap = false; if (!intel_connector->hdcp.shim) { seq_puts(m, "No Connector Support"); From patchwork Wed Mar 27 04:44:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kandpal, Suraj" X-Patchwork-Id: 13605572 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11163C47DD9 for ; Wed, 27 Mar 2024 04:47:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7196510F7F0; Wed, 27 Mar 2024 04:47:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="DQ2ONpao"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8C4710F7EF for ; Wed, 27 Mar 2024 04:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711514821; x=1743050821; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WsGlp5+q5o3EvcaGKryXtPN1VG9yga+OvZA7XdoR4I8=; b=DQ2ONpaoC/OXfzaHAneB42waddpVrFKV3XBmelzVM5HgoOEG2pVc7HNj EH50F+bIsA49jNG/6a0Bsw0k3GGbstSLfMZfz4euoCCTfi+WkocV6J35F JXxXxDAbtr7Xc3IJfQSoA5Xw18CCObcKDcpLc1nHIDjSxyz/+MU0a5M4q tVgbdLD4s11QhTbbh8DwM6LkqTbxKui1iOiqrSV8jFJ4r4uN1bCxiZ0is 01wUTIipdgz61QbSy2ksJFkuomuSFMMwg7KvKMSVebktBZQCWueR9TY2W Kc80KciAjNVTnq9feFD923Vh8g+6yISX6Y0FDebfHBxUqIfDTi7iuN3wF Q==; X-CSE-ConnectionGUID: AcGXo8mJR6CSOfSW9Vr3TA== X-CSE-MsgGUID: rB78ODKiQa2XNPSMv8iufA== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="29072763" X-IronPort-AV: E=Sophos;i="6.07,157,1708416000"; d="scan'208";a="29072763" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 21:47:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,157,1708416000"; d="scan'208";a="47363409" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.32]) by fmviesa001.fm.intel.com with ESMTP; 26 Mar 2024 21:47:00 -0700 From: Suraj Kandpal To: intel-gfx@lists.freedesktop.org Cc: chaitanya.kumar.borah@intel.com, Suraj Kandpal Subject: [PATCH 2/2] drm/i915/hdcp: Fix get remote hdcp capability function Date: Wed, 27 Mar 2024 10:14:23 +0530 Message-ID: <20240327044422.240398-4-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240327044422.240398-2-suraj.kandpal@intel.com> References: <20240327044422.240398-2-suraj.kandpal@intel.com> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" HDCP 1.x capability needs to be checked even if setup is not HDCP 2.x capable. Fixes: 813cca96e4ac ("drm/i915/hdcp: Add new remote capability check shim function") Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c index b98a87883fef..7f52043b0f9f 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c @@ -688,7 +688,7 @@ int intel_dp_hdcp_get_remote_capability(struct intel_connector *connector, { struct drm_i915_private *i915 = to_i915(connector->base.dev); struct drm_dp_aux *aux = &connector->port->aux; - u8 bcaps; + u8 bcaps = 0; int ret; if (!intel_encoder_is_mst(connector->encoder)) @@ -696,15 +696,14 @@ int intel_dp_hdcp_get_remote_capability(struct intel_connector *connector, ret = _intel_dp_hdcp2_get_capability(aux, hdcp2_capable); if (ret) - return ret; + drm_dbg_kms(&i915->drm, + "HDCP2 DPCD capability read failed err: %d\n", ret); ret = intel_dp_hdcp_read_bcaps(aux, i915, &bcaps); - if (ret) - return ret; *hdcp_capable = bcaps & DP_BCAPS_HDCP_CAPABLE; - return 0; + return ret; } static const struct intel_hdcp_shim intel_dp_hdcp_shim = {