From patchwork Wed Mar 27 10:31:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_M=C3=BCllner?= X-Patchwork-Id: 13606153 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EC93CD1283 for ; Wed, 27 Mar 2024 10:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jNvMdiH68j7U9CU8S2h45knqGrJCYb8G2LcFTCNWLsg=; b=TvLIc9pB/eYoLd T4S9u3FCi30d2UqPd05lLp2nvYe62j4OEFT8PNzRyhrNbU/CcBbq2nfEnYkLi+iB9uXVF89YKJt9L E1Oe908Txh1lElXHKG5FviGd/JxZZ9txlu7PbE+tv3Ats5kbW5jy/o10+Bat67VsUO5NYidNOsxg+ DVt0MIpNwbpxvhaNXbo2DtOTr08NTLV4iVxCDEK4zEFpQQ4U9aEx+BeGiBH2ouGkU/yDJ8oplrJl9 OJLWgQFgUvCPShxYKK9NpCdRgU514RcyTSxk+0pHnLTIKeIMzqhB39GW8wx7bye7pcAtScz0mNU3y S7jsB3BpMXCFebOl5HYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpQZT-00000008QJY-400H; Wed, 27 Mar 2024 10:31:51 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpQZO-00000008QEr-0PB1 for linux-riscv@lists.infradead.org; Wed, 27 Mar 2024 10:31:48 +0000 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-56bc8cfc19fso7271239a12.1 for ; Wed, 27 Mar 2024 03:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1711535495; x=1712140295; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qFFjWbcETbPCVovmbM8tpReuGu8aZixvMHFh/xJCQ5U=; b=B+pr8bpDCXazM94BpbGBQz47XcHc3drW9E7Sh1GylG0hsCR6V8WuhvVJRAh20xw4D2 2DlqZ61iiaFhz/ixULpz9UQD4JmjtKRDvKx62b8/Y9hQSuP3vACP0cE4VeN5cX6TAHrk nQxPVyo1xPuBMfzO6xaS+GPSEQYxoO3PqS68o94zJcECGsI4nluJRC4/bgGxKgd/0Zep IRI8RrldCxDk8BHs+UGB4q0rg08UYgrGM10ykPfo2Gnjs7//4fMdv044rerNSqHBcae7 ZlZdjTW31z0t+7U+LHWYSyvgMMmjLypkhg6GF8FhQyI/nc6NatgH+ShCPy3cFSiAU/kb fLnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711535495; x=1712140295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qFFjWbcETbPCVovmbM8tpReuGu8aZixvMHFh/xJCQ5U=; b=eOovJUXFUUeQS4PZX2dTK07ThvYi1/5RJ5btoQL68NJR95YQd46O8WlMIzjm3IvtGt n2DX0I7xvChZJmyLTC+v+oZmDKnUxiS1UYJ1F23cwJ6spJnygCbEXmVpvEfSGYLjXyAk nU6tM4ZpuymuXLFo4RWizQ/dKPtPqCEu7oomUoMhyyKAR/RC0IcQ0N0YrsCGQ9K2xpTq zMLdh7HJqxwCsZHfZcZtGydPSuAfA6lwJsAAZp9V304a/fDcCc6OzWBAmRZhGSX0+kUV zg4nulK6esFEtNW6NiIGAmWrSoX5quECQPkF/93XPDXBBv8aBoNz5mlO3taRSNcs60c/ bBfw== X-Gm-Message-State: AOJu0Yz3+2qdspP0HDFpBEH6dzeTJvjbOWE/w24TKgwo+xnd3vUixZhR 6W0B9Xp0Ehdgxpfu70soROFi51xz+TjFDVrlctK4GhoFxBSaE1yCNXOqg5Op7XC0++6sM3q6vPO RP3w= X-Google-Smtp-Source: AGHT+IFpb/VYghvSGRAZv/KSjYVbhAxxbRz3wD8nc7CPHRDPIyI0sKYTxchYPDN6RU4YBfPXV3vdmA== X-Received: by 2002:a17:906:d7ae:b0:a44:4c9e:8809 with SMTP id pk14-20020a170906d7ae00b00a444c9e8809mr2772060ejb.32.1711535494767; Wed, 27 Mar 2024 03:31:34 -0700 (PDT) Received: from antares.fritz.box (62-178-148-172.cable.dynamic.surfer.at. [62.178.148.172]) by smtp.gmail.com with ESMTPSA id z15-20020a170906270f00b00a46b8cd9b51sm5294078ejc.185.2024.03.27.03.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 03:31:34 -0700 (PDT) From: =?utf-8?q?Christoph_M=C3=BCllner?= To: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , Paul Walmsley , Albert Ou , Philipp Tomsich , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , Daniel Henrique Barboza , Heiko Stuebner , Cooper Qu , Zhiwei Liu , Huang Tao , Alistair Francis , Andrew Jones , Conor Dooley Cc: =?utf-8?q?Christoph_M=C3=BCllner?= Subject: [PATCH 1/2] riscv: thead: Rename T-Head PBMT to MAEE Date: Wed, 27 Mar 2024 11:31:29 +0100 Message-ID: <20240327103130.3651950-2-christoph.muellner@vrull.eu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240327103130.3651950-1-christoph.muellner@vrull.eu> References: <20240327103130.3651950-1-christoph.muellner@vrull.eu> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_033146_169693_BDADA89D X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T-Head's vendor extension to set page attributes has the name MAEE (MMU address attribute extension). Let's rename it, so it is clear what this referes to. See also: https://github.com/T-head-Semi/thead-extension-spec/blob/master/xtheadmaee.adoc Signed-off-by: Christoph Müllner --- arch/riscv/Kconfig.errata | 8 ++++---- arch/riscv/errata/thead/errata.c | 8 ++++---- arch/riscv/include/asm/errata_list.h | 20 ++++++++++---------- 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata index 910ba8837add..2c24bef7e112 100644 --- a/arch/riscv/Kconfig.errata +++ b/arch/riscv/Kconfig.errata @@ -82,14 +82,14 @@ config ERRATA_THEAD Otherwise, please say "N" here to avoid unnecessary overhead. -config ERRATA_THEAD_PBMT - bool "Apply T-Head memory type errata" +config ERRATA_THEAD_MAEE + bool "Apply T-Head's MMU address attribute (MAEE)" depends on ERRATA_THEAD && 64BIT && MMU select RISCV_ALTERNATIVE_EARLY default y help - This will apply the memory type errata to handle the non-standard - memory type bits in page-table-entries on T-Head SoCs. + This will apply the memory type errata to handle T-Head's MMU address + attribute extension (MAEE). If you don't know what to do here, say "Y". diff --git a/arch/riscv/errata/thead/errata.c b/arch/riscv/errata/thead/errata.c index b1c410bbc1ae..8c8a8a4b0421 100644 --- a/arch/riscv/errata/thead/errata.c +++ b/arch/riscv/errata/thead/errata.c @@ -19,10 +19,10 @@ #include #include -static bool errata_probe_pbmt(unsigned int stage, +static bool errata_probe_maee(unsigned int stage, unsigned long arch_id, unsigned long impid) { - if (!IS_ENABLED(CONFIG_ERRATA_THEAD_PBMT)) + if (!IS_ENABLED(CONFIG_ERRATA_THEAD_MAEE)) return false; if (arch_id != 0 || impid != 0) @@ -140,8 +140,8 @@ static u32 thead_errata_probe(unsigned int stage, { u32 cpu_req_errata = 0; - if (errata_probe_pbmt(stage, archid, impid)) - cpu_req_errata |= BIT(ERRATA_THEAD_PBMT); + if (errata_probe_maee(stage, archid, impid)) + cpu_req_errata |= BIT(ERRATA_THEAD_MAEE); errata_probe_cmo(stage, archid, impid); diff --git a/arch/riscv/include/asm/errata_list.h b/arch/riscv/include/asm/errata_list.h index ea33288f8a25..7c377e137b41 100644 --- a/arch/riscv/include/asm/errata_list.h +++ b/arch/riscv/include/asm/errata_list.h @@ -23,7 +23,7 @@ #endif #ifdef CONFIG_ERRATA_THEAD -#define ERRATA_THEAD_PBMT 0 +#define ERRATA_THEAD_MAEE 0 #define ERRATA_THEAD_PMU 1 #define ERRATA_THEAD_NUMBER 2 #endif @@ -53,20 +53,20 @@ asm(ALTERNATIVE("sfence.vma %0", "sfence.vma", SIFIVE_VENDOR_ID, \ * in the default case. */ #define ALT_SVPBMT_SHIFT 61 -#define ALT_THEAD_PBMT_SHIFT 59 +#define ALT_THEAD_MAEE_SHIFT 59 #define ALT_SVPBMT(_val, prot) \ asm(ALTERNATIVE_2("li %0, 0\t\nnop", \ "li %0, %1\t\nslli %0,%0,%3", 0, \ RISCV_ISA_EXT_SVPBMT, CONFIG_RISCV_ISA_SVPBMT, \ "li %0, %2\t\nslli %0,%0,%4", THEAD_VENDOR_ID, \ - ERRATA_THEAD_PBMT, CONFIG_ERRATA_THEAD_PBMT) \ + ERRATA_THEAD_MAEE, CONFIG_ERRATA_THEAD_MAEE) \ : "=r"(_val) \ : "I"(prot##_SVPBMT >> ALT_SVPBMT_SHIFT), \ - "I"(prot##_THEAD >> ALT_THEAD_PBMT_SHIFT), \ + "I"(prot##_THEAD >> ALT_THEAD_MAEE_SHIFT), \ "I"(ALT_SVPBMT_SHIFT), \ - "I"(ALT_THEAD_PBMT_SHIFT)) + "I"(ALT_THEAD_MAEE_SHIFT)) -#ifdef CONFIG_ERRATA_THEAD_PBMT +#ifdef CONFIG_ERRATA_THEAD_MAEE /* * IO/NOCACHE memory types are handled together with svpbmt, * so on T-Head chips, check if no other memory type is set, @@ -83,11 +83,11 @@ asm volatile(ALTERNATIVE( \ "slli t3, t3, %3\n\t" \ "or %0, %0, t3\n\t" \ "2:", THEAD_VENDOR_ID, \ - ERRATA_THEAD_PBMT, CONFIG_ERRATA_THEAD_PBMT) \ + ERRATA_THEAD_MAEE, CONFIG_ERRATA_THEAD_MAEE) \ : "+r"(_val) \ - : "I"(_PAGE_MTMASK_THEAD >> ALT_THEAD_PBMT_SHIFT), \ - "I"(_PAGE_PMA_THEAD >> ALT_THEAD_PBMT_SHIFT), \ - "I"(ALT_THEAD_PBMT_SHIFT) \ + : "I"(_PAGE_MTMASK_THEAD >> ALT_THEAD_MAEE_SHIFT), \ + "I"(_PAGE_PMA_THEAD >> ALT_THEAD_MAEE_SHIFT), \ + "I"(ALT_THEAD_MAEE_SHIFT) \ : "t3") #else #define ALT_THEAD_PMA(_val) From patchwork Wed Mar 27 10:31:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_M=C3=BCllner?= X-Patchwork-Id: 13606151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58E4CC47DD9 for ; Wed, 27 Mar 2024 10:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xMqHUMFc1ELQeAdkP8AIP7zNf5OJnHCP1pvY8BMrHug=; b=oX+OOTsvIR/eU6 lKSBaJHPVzFytaSSZYn/BooXv0vqFLhCW09MAmwjsbes0IH/G35rzBU2bsil1PB0SY+h4t+m6bhOQ PqDH+cU+JdOWme0KKuT9yTIiSrdJ7epETGGE4tP7RNgoV3yReAoGZDmHjGcSzFbJYmdXRgzTNGG6P 2LNCCBbLub1IPCVGoIcnQwRfg6Ow7OZJ4xJvKB/GkaCAG1Cy8MIff4RAREtU18qC6Ztx3cMYmdcvm +LbMQ9J/uE0N3Bbr8xD+mAz3r3mFoiDgHBAW807P8eZgGOUayS5zc7HWAJmXSKAT8cREF8K27tT7L 7v6ojdNMCVC98J3A1PiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpQZT-00000008QJI-0qNf; Wed, 27 Mar 2024 10:31:51 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpQZN-00000008QEx-32Op for linux-riscv@lists.infradead.org; Wed, 27 Mar 2024 10:31:47 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a4751063318so438231566b.0 for ; Wed, 27 Mar 2024 03:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1711535496; x=1712140296; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NSJ+UjWyV6VDqHK474kxHesTXDBqeer09Qi3VieNTqM=; b=HcVSs1THQ5QnhqYRq9dV4xZDn0uwbYejwqyifaQyRtsMwPJHHsiGF14MXg2UktZJPi +AT9CcyuJVcScKn617NT80OHi80ErgDT59a9apQBXNenzhAoCPdsKE+qg2/SUJjiIbwh zVC0eC/a4h3uqi2/JieSYrJFN6T97MLJ3H6qhA/80XHYCaukVOiEZ3aHaoICg7ziu9cp Y2diu1aPvZ5IyEJWXabS7ZLJlzrJtdVHWd7RN/3Eu1iVC90wdm9WeLM346/xxAwQHTtY YWQCtseQh/p287nWNEzQs3p8KTFX8T0e4uVom+GFv0iVDJ3d8DyEUN4nV64mUm0Mf1xU MkaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711535496; x=1712140296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NSJ+UjWyV6VDqHK474kxHesTXDBqeer09Qi3VieNTqM=; b=YPOrD4EFqHXXOIcKjWXswnxZHhwqmbzrii073QQKvP0tHLsGqTTfVnWOU/Bn8LxfLZ L7brDtwdXvk2igEYyNe36VA6HDzQqP3FhYvcUFqNQpttwyp02f9xZUP0ZlpyAICPItY2 28Kxt+DHx0FyS4j8w4Qk7oIuD5SZnpS7sSEM8kEWjSWO62ZPbw+V1KgNm6c5nFLc9MWs ui/kLAzHYv2u0IrJOGNFoOW5EyvJc1gaEUsR2LGZXfkPSbc90QyOMro+cXXfuE1Z7dCt yH+j5dhdmjKPZz6LuYHEVJZkQa2F6nk2/WYuxCaDPEi1PHTm6fu+ZYufm2Vw/0Ctw4yR gDLQ== X-Gm-Message-State: AOJu0YxhYQacYfYrbdB9496bsCJhtfVxkecYu0YjNrtkewFiF3NR3CMB XiLqKIyGZnh1ku7GfBuCW5gM5vJDa9sb+s/bwg+EhSXP7MZNuKS+6C0G4Bdf1z4bK3XQLzJh6nu kqW4= X-Google-Smtp-Source: AGHT+IGVZKrHhMNC1CQHMp/4kkiEfUCOZuadD93YT7eU77ZwO7kZVT2ezcq9jl6faw5E8GtW+3460A== X-Received: by 2002:a17:906:6b8e:b0:a46:e595:f357 with SMTP id l14-20020a1709066b8e00b00a46e595f357mr2781223ejr.9.1711535496207; Wed, 27 Mar 2024 03:31:36 -0700 (PDT) Received: from antares.fritz.box (62-178-148-172.cable.dynamic.surfer.at. [62.178.148.172]) by smtp.gmail.com with ESMTPSA id z15-20020a170906270f00b00a46b8cd9b51sm5294078ejc.185.2024.03.27.03.31.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 03:31:35 -0700 (PDT) From: =?utf-8?q?Christoph_M=C3=BCllner?= To: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , Paul Walmsley , Albert Ou , Philipp Tomsich , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , Daniel Henrique Barboza , Heiko Stuebner , Cooper Qu , Zhiwei Liu , Huang Tao , Alistair Francis , Andrew Jones , Conor Dooley Cc: =?utf-8?q?Christoph_M=C3=BCllner?= Subject: [PATCH 2/2] riscv: T-Head: Test availability bit before enabling MAEE errata Date: Wed, 27 Mar 2024 11:31:30 +0100 Message-ID: <20240327103130.3651950-3-christoph.muellner@vrull.eu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240327103130.3651950-1-christoph.muellner@vrull.eu> References: <20240327103130.3651950-1-christoph.muellner@vrull.eu> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_033145_815585_EC2B04B0 X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T-Head's MAEE mechanism (non-compatible equivalent of RVI's Svpbmt) is currently assumed for all T-Head harts. However, QEMU recently decided to drop acceptance of guests that write reserved bits in PTEs. As MAEE uses reserved bits in PTEs and Linux applies the MAEE errata for all T-Head harts, this broke the Linux startup on QEMU emulations of the C906 emulation. This patch attempts to address this issue by testing the MAEE bit in TH_MXSTATUS CSR. As the TH_MXSTATUS CSR is only accessible in M-mode this patch depends on M-mode firmware that handles this for us transparently. As this patch breaks Linux bootup on all C9xx machines with MAEE, which don't have M-mode firmware that handles the access to the TH_MXSTATUS CSR, this patch is marked as RFC. Signed-off-by: Christoph Müllner --- arch/riscv/errata/thead/errata.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/riscv/errata/thead/errata.c b/arch/riscv/errata/thead/errata.c index 8c8a8a4b0421..dd7bf6c62a35 100644 --- a/arch/riscv/errata/thead/errata.c +++ b/arch/riscv/errata/thead/errata.c @@ -19,6 +19,9 @@ #include #include +#define CSR_TH_MXSTATUS 0x7c0 +#define MXSTATUS_MAEE _AC(0x200000, UL) + static bool errata_probe_maee(unsigned int stage, unsigned long arch_id, unsigned long impid) { @@ -28,11 +31,14 @@ static bool errata_probe_maee(unsigned int stage, if (arch_id != 0 || impid != 0) return false; - if (stage == RISCV_ALTERNATIVES_EARLY_BOOT || - stage == RISCV_ALTERNATIVES_MODULE) - return true; + if (stage != RISCV_ALTERNATIVES_EARLY_BOOT && + stage != RISCV_ALTERNATIVES_MODULE) + return false; - return false; + if (!(csr_read(CSR_TH_MXSTATUS) & MXSTATUS_MAEE)) + return false; + + return true; } /*