From patchwork Fri Mar 29 17:10:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13610839 X-Patchwork-Delegate: kvalo@adurom.com Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E70B4364D8 for ; Fri, 29 Mar 2024 17:10:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732231; cv=none; b=pSi98T8wcM8a3imvGHRc/jL0gb647/vUx4gz1aB4IQ4aWLxTcqTKIsHSPDrZb8iY5bf0vuCAPLjMrz/ocFVQ1dF5fFDvDZbI6t+O1XjmTPnNgf0B6Ju/rz+iEZU6Wg6sIHZZ5a7O8M8F/oEmleIfTBISx5B1x8C20MaesC3Fdec= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732231; c=relaxed/simple; bh=Uau+Vd08xpT0jTfyRy7WJ6vCP5AAkr/VcXUgsWmBkTk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=NrTEmGHsbPSHhoCY00AV4BJZrKCCEN6ff4+pTHfaKL4WkN8VVpqesKB2CUPr6niaNwT2zk69ENeIszdGdeMZp+ygKL/Z/kOdxYlpJHtrBbuvB3kMgB21Ify0BTkm4sqLM7RBhu8r6IbXHHvpq1BHbQ+10pI2O0Mf5RVAakSiFDI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uJ6wQ72T; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uJ6wQ72T" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-341b01dbebbso1823663f8f.0 for ; Fri, 29 Mar 2024 10:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711732228; x=1712337028; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=scJlWaAaKpFFDTYwmXG3k2pA63Nw8VkQF7EI66SPrBk=; b=uJ6wQ72TR/ul5nkgmveVmNK5sAopsS27F+tR64QLWvM0hJtIqGlUdjVGhWAioZFxpU HukQUBplFCRBE16F6EB5iWUVhrUMqFqfY2CxAfjnMp5SzFtMxHJYMZ5mGOvbajC0XmoZ a7DhYk63xKafnjgOKapS1nZs0bHlYqMW78UHL37Y/8noJ1AsRYoIjYieFY4bjnc9AVQC xLEgz3Y29y3z4P/vbstnIGKADSTFvdoGCA04XeQqnyaeMP4Yn5XaU1twD3qwZ/ZjWElY 5YtMfyATHzAApkA2i2m+g3lRCWOjthUUZVFV50/uXAtlJDRGMsuICo/AUzoFWm8D35l7 UjnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711732228; x=1712337028; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=scJlWaAaKpFFDTYwmXG3k2pA63Nw8VkQF7EI66SPrBk=; b=CBBFcjUbmpQY9Xw6qdHwyG97x73M9qfMzULNAwAGeJqsMPlKk5WQZPlyEdLgPpDywf JrPVVi8ytKk5qcq0OXKUwQHmQKIzpqE35oYWZu7+2OUaDlvf07VQlFp5rEsxsYgvUEFc kmfiGgDwlyEj4CvLSWKRukFQ9OKA4xS0Ytxc3SFuW/EmOKQXsszG870J3mgPC/TaICjC Fan2rLR8NnoeWyNRxYo2MAJDVTgRBgzYG+4Y5yg7AdPiUHRcsrpnjkom6m2151RrdxOw 8SLTYMB+/01qJOIJq6A7p2Bo0dvnRWUaxC0uL+UgTzq3EmVSds60d19rxUWkQcjJxPzn 7rpg== X-Forwarded-Encrypted: i=1; AJvYcCW4gztZ1/JiHQONy31lzixQA19Tn/OrLgAnQz7CoKcqIaZVZM94Y3nuz+3d8VtMDJfsretGiUkBAdCYFbr3dR2oa9m54uPUDtYQwNnuCc4= X-Gm-Message-State: AOJu0YxuZNsXlKFLfpZCOU7d50VToYb92iTdkv2SOC7fGboIdLETKYTa atKMhDEVpUI22dckWdaZKdiXfy9aXeXuJ2fSF/BwF5R3xBjbpB6LBZlUXr0PQMo= X-Google-Smtp-Source: AGHT+IGDQp7e0jPhkOMyziKZaKLfPE5T5Kcol2EeQhlM9DkpzIZIjFl5zFSJ3My5eoSqC7Y7mRV5qw== X-Received: by 2002:adf:ee91:0:b0:33d:2474:5aa with SMTP id b17-20020adfee91000000b0033d247405aamr2185921wro.40.1711732228295; Fri, 29 Mar 2024 10:10:28 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id o17-20020a5d6851000000b0033ec9936909sm4577665wrw.39.2024.03.29.10.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 10:10:27 -0700 (PDT) From: Krzysztof Kozlowski To: Kalle Valo , Jeff Johnson , Brian Norris , Ajay Singh , Claudiu Beznea , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization Date: Fri, 29 Mar 2024 18:10:14 +0100 Message-Id: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This driver's initialization functions do not perform any custom code, except printing messages. Printing messages on modules loading/unloading is discouraged because it pollutes the dmesg regardless whether user actually has this device. Core kernel code already gives tools to investigate whether module was loaded or not. Drop the printing messages which allows to replace open-coded module_sdio_driver(). Signed-off-by: Krzysztof Kozlowski Acked-by: Jeff Johnson Acked-by: Kalle Valo --- FYI: I have ongoing patchset touching few lines above this patch chunk (sdio_driver) which might go via different tree. If that patchset is applied via different tree, it might result in a trivial conflict, but there is no dependency. They can go via separate trees (except that trivial conflict). --- drivers/net/wireless/ath/ath10k/sdio.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index 0ab5433f6cf6..1acb9fba9a8e 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -2671,25 +2671,7 @@ static struct sdio_driver ath10k_sdio_driver = { .pm = ATH10K_SDIO_PM_OPS, }, }; - -static int __init ath10k_sdio_init(void) -{ - int ret; - - ret = sdio_register_driver(&ath10k_sdio_driver); - if (ret) - pr_err("sdio driver registration failed: %d\n", ret); - - return ret; -} - -static void __exit ath10k_sdio_exit(void) -{ - sdio_unregister_driver(&ath10k_sdio_driver); -} - -module_init(ath10k_sdio_init); -module_exit(ath10k_sdio_exit); +module_sdio_driver(ath10k_sdio_driver); MODULE_AUTHOR("Qualcomm Atheros"); MODULE_DESCRIPTION("Driver support for Qualcomm Atheros 802.11ac WLAN SDIO devices"); From patchwork Fri Mar 29 17:10:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13610840 X-Patchwork-Delegate: kvalo@adurom.com Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C77328DC0 for ; Fri, 29 Mar 2024 17:10:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732233; cv=none; b=m/n1M8/kqpRC+dWIg+BlGh+eHDY7SuilzITQZ+nZhIjLXi1iHNGY+iH5O+59APWXuhvDlwbHGcEogSZmV/dL4XN+kO6hWKPQ3Y1F0mQWOzJI94nH7bznV3DOXwyEL2XlJ0hETgCRFEjgS4hrl4ANyzmKxJR5kWkWlhETFKwGXa0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732233; c=relaxed/simple; bh=1do6tfNH68DObpEKyzA1h8TA9LOtGeD6ZTJRXrUWXBU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bBCcSrn78ydx/oDV08gdP0Onj/XfYSro10ZNmfdkcHENTn9zqx4oztogGzpk6SXENW4ACiHsw91miZFWGVFf9/brNWwWjDi+uXw9Hf/k2ArotxoDVp8jySgGHawk2FuiF0mSp4Tg4vebx2FSySk4ddJ+XYSqeuT8PDw8hC9j0DQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qTA3rqNe; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qTA3rqNe" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4154471fb59so12214295e9.3 for ; Fri, 29 Mar 2024 10:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711732230; x=1712337030; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yl9e/glL3WN5Ke/EqF6PlMNs4wHLhHYNYdj8lwPraLU=; b=qTA3rqNe3HAuOX8zS3pIZjF07nneZy0VMQVEDGMMX3Ul+Yq1nhz27sqdyA9Dk4tHag dpLMI+HqoJu8ju9RrzFpjjxN+qpkRzSrVMQ9fF0w9AQPwFdMt4RkR0Uw/OfTN/d78TXa 4X18NN0HtAKYACKJFhBka63MH4uWERlReRnTsuRu3nIaXtrdAlkI6pBUQv+Iq2OQ8qEK IDd76XAGRx6TEZewkOs1w5PRRlc6Ms6xWtgDemhXyEV9/vmVrXbWfT+bityzqXymJsTG Xizp3blV4aJWjRDrSGnsKg3EZPvJGphBrmK+MAcpKGT91r8nCjMEg6lIUipJosEm2dRy vZrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711732230; x=1712337030; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yl9e/glL3WN5Ke/EqF6PlMNs4wHLhHYNYdj8lwPraLU=; b=ojQ2J2ZhzAvFFjk1/26p/32oGnmMfcWMooruifhweS5jdS1wN88a1ZmM6ZrZ2seL+r zS18vjRqX3fgf1Vok40r4V0FTMkuY95VLBWEevnJq/b5d4PSTVjDjEux648GZy0hiX0Q 1m/b9bfEfqmKk1sGBSwC9Rw56EVNcn/Gb+Y7ZYyH2ybsHMCEKM3YCMe44hauKcyytZpf LxfrFFIHC/j6YxR4jfFLSJJrXDIqAC+2cU/3BWdNs11Yin5u8m47uhpzKRkIxvyBGYNe mICfqOrKmMqS145zvsUOdyaUQIjfIVC2jZVjzH/hGZ5NUnUQOin6qtRVipGfzWhtlwlm z8cg== X-Forwarded-Encrypted: i=1; AJvYcCU6Hq5J9Pg2M8rzWiBMqpE5lKG79JnDuhKwM4d9nnSW4cyJ5CEuuBqvr9LeJph0nE4P8FghzNweQ5eH1QV5ffOdBgN4LZFeQ+4iiZt62eM= X-Gm-Message-State: AOJu0Yw7nEz0E8T/filcBoT3ep7haG0QU5cD392eQ0DAxsPiVcQQwDX5 38D/r5V3mphpdLzJCDvR3FpD6gAkW1PPCkikOYPd5+VOOPl25O65Wp9ZFzNboiEamejJMlvbJ1t O X-Google-Smtp-Source: AGHT+IGWRmVRru6HhXuMrT26wbmLt8juVtl8/ndRNMn7ZfdtMw/RN4XPuzVFDz8oZ9VNkUeJPKHs3g== X-Received: by 2002:a5d:4750:0:b0:33e:69db:bf8a with SMTP id o16-20020a5d4750000000b0033e69dbbf8amr1582625wrs.59.1711732229769; Fri, 29 Mar 2024 10:10:29 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id o17-20020a5d6851000000b0033ec9936909sm4577665wrw.39.2024.03.29.10.10.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 10:10:29 -0700 (PDT) From: Krzysztof Kozlowski To: Kalle Valo , Jeff Johnson , Brian Norris , Ajay Singh , Claudiu Beznea , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/6] wifi: ath6kl: sdio: simplify module initialization Date: Fri, 29 Mar 2024 18:10:15 +0100 Message-Id: <20240329171019.63836-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> References: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This driver's initialization functions do not perform any custom code, except printing messages. Printing messages on modules loading/unloading is discouraged because it pollutes the dmesg regardless whether user actually has this device. Core kernel code already gives tools to investigate whether module was loaded or not. Drop the printing messages which allows to replace open-coded module_sdio_driver(). Signed-off-by: Krzysztof Kozlowski --- --- drivers/net/wireless/ath/ath6kl/sdio.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c index 8a43c48ec1cf..9ab091044706 100644 --- a/drivers/net/wireless/ath/ath6kl/sdio.c +++ b/drivers/net/wireless/ath/ath6kl/sdio.c @@ -1427,25 +1427,7 @@ static struct sdio_driver ath6kl_sdio_driver = { .remove = ath6kl_sdio_remove, .drv.pm = ATH6KL_SDIO_PM_OPS, }; - -static int __init ath6kl_sdio_init(void) -{ - int ret; - - ret = sdio_register_driver(&ath6kl_sdio_driver); - if (ret) - ath6kl_err("sdio driver registration failed: %d\n", ret); - - return ret; -} - -static void __exit ath6kl_sdio_exit(void) -{ - sdio_unregister_driver(&ath6kl_sdio_driver); -} - -module_init(ath6kl_sdio_init); -module_exit(ath6kl_sdio_exit); +module_sdio_driver(ath6kl_sdio_driver); MODULE_AUTHOR("Atheros Communications, Inc."); MODULE_DESCRIPTION("Driver support for Atheros AR600x SDIO devices"); From patchwork Fri Mar 29 17:10:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13610841 X-Patchwork-Delegate: kvalo@adurom.com Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0ACA1327F5 for ; Fri, 29 Mar 2024 17:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732234; cv=none; b=jfUeb0ajLGpYwuCjaMXvuHjVUcfk6U/H2GF3zlckp3sTFguDo22MWrbDDm8gyjoZbwEyfE1s7o6P6KVgVZuv8jKQIXzLhj1M5xZJWQJoByeLdedcS4TUl2/8HuuBbFi2Pa7aPQLvPvSxS9NuAR/ZkSonqd6I+yJwcdSaF3VAN94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732234; c=relaxed/simple; bh=8PHeUGU+ZRvrLa0WyO7pGv+/fClxC3Ext0tzuOtYQUQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nuL6VHFfulD386nKLVWbdqHvzHy0ELwVrxuI8xjPCcWyep/nZTPlVgjzc7JB+H6v4xA4AV9vjH250+v69AtzePwDpzNTZCtaS6lDhwbe0jHW1Q+HnspBGPHh99hBy139UrX9ffsB9Iymrif6GrmACQPMwdClHaXNORouvnAXMA4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cUmmw78W; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cUmmw78W" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-415446af364so10214265e9.0 for ; Fri, 29 Mar 2024 10:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711732231; x=1712337031; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xXP8LCcnnVa9d+y1k6oL+GlmX9060FPKOT56CxvkCmk=; b=cUmmw78WVNZx/+hCd2kDLwk3hExyp5chDzgNFU59CWAfjgvb9pzWBdsBKdtb3qIqik EeQz2f2R/73UGAofqdr/PqZ/PjKMm6kCJk8jcMTDXwHRZW5XHMlsoQkS0TkysKJ6F8kD 6bO08tCh+VSh5yWG8pk9bShZT+35/yu63F94/DKZZ4FO7jaLXVkHmLTuvMW3DVIEBvMN kx7ceuk4Q/6NRAMGuzcB9UEcJQDEzAApY4UrZfAwy1p09ST743MARw+UikY0cavfxzRy mZPtCY4GElNeWvhL6lLLIoJ4il3Cy08tlbhNLP7zm0U8dUSL4cBx7kAVWcMzU3j0kbHx MJ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711732231; x=1712337031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xXP8LCcnnVa9d+y1k6oL+GlmX9060FPKOT56CxvkCmk=; b=N3CbelgP6WiPvZ+OHYXv3IyeQm7j1lwNRh3ElhFIdhd6GDWA54CSEd1DiIyrjIAekx 90zkTLPrSGtMmLfOBTgXBr/7FTIcdyairIusP9jzXqvMWCxjflfmLKQQDMAawaYbds1p 8ww6qK7JQWAb63twafdpt4bJAEiEokkI9sAFPQJCN/ScNWjhmadIiFh/ozdEdjm1QF2l YOJa9hGd4HBDcYfTtGfGhiDMh2EvxQcO09DhFvwr5pDAWk6PJzhAOk+3cwSCe2oi3FWm G8i78RPskseGqGLQJqv4at6hKtsBbWhAR+2+FuFgST1fcWIDNQ10EOMh1PnSoLBdpPHk x0qg== X-Forwarded-Encrypted: i=1; AJvYcCVer49hwQOtvM7t0Y8taCqm9FmlyQ2/4Izn89phqqbsTXs3mrgMP8yiI4+mOyoN6jHIL2QOTqdDRXeimtY8s9XP2/blJV1zyrF5E4diAp0= X-Gm-Message-State: AOJu0YxIW1R30QAs6wsRfIA8VvxkKWWn4RWTWiS/l0XTBCT348d6iCfd pLlDjC4gQyCPRQZqyu43VfYoCxznWC+tpmXOwtVkzqmplBPZp0sftxhkAAJp5gg= X-Google-Smtp-Source: AGHT+IGESeQn/WY+9sDt6AYXXFEGPsBJDLNgHvdN9tKgNTMhMDCcaxBcRgMFF4AuYYmG6bqCbcDOXw== X-Received: by 2002:a05:600c:4e94:b0:413:fdc2:d9da with SMTP id f20-20020a05600c4e9400b00413fdc2d9damr2587780wmq.12.1711732231217; Fri, 29 Mar 2024 10:10:31 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id o17-20020a5d6851000000b0033ec9936909sm4577665wrw.39.2024.03.29.10.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 10:10:30 -0700 (PDT) From: Krzysztof Kozlowski To: Kalle Valo , Jeff Johnson , Brian Norris , Ajay Singh , Claudiu Beznea , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 3/6] wifi: rsi: sdio: simplify module initialization Date: Fri, 29 Mar 2024 18:10:16 +0100 Message-Id: <20240329171019.63836-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> References: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This driver's initialization functions do not perform any custom code, except printing messages. Printing messages on modules loading/unloading is discouraged because it pollutes the dmesg regardless whether user actually has this device. Core kernel code already gives tools to investigate whether module was loaded or not. Drop the printing messages which allows to replace open-coded module_sdio_driver(). Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 31 +------------------------ 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c index 8e7b757475d2..1e578533e473 100644 --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c @@ -1519,36 +1519,7 @@ static struct sdio_driver rsi_driver = { } #endif }; - -/** - * rsi_module_init() - This function registers the sdio module. - * @void: Void. - * - * Return: 0 on success. - */ -static int rsi_module_init(void) -{ - int ret; - - ret = sdio_register_driver(&rsi_driver); - rsi_dbg(INIT_ZONE, "%s: Registering driver\n", __func__); - return ret; -} - -/** - * rsi_module_exit() - This function unregisters the sdio module. - * @void: Void. - * - * Return: None. - */ -static void rsi_module_exit(void) -{ - sdio_unregister_driver(&rsi_driver); - rsi_dbg(INFO_ZONE, "%s: Unregistering driver\n", __func__); -} - -module_init(rsi_module_init); -module_exit(rsi_module_exit); +module_sdio_driver(rsi_driver); MODULE_AUTHOR("Redpine Signals Inc"); MODULE_DESCRIPTION("Common SDIO layer for RSI drivers"); From patchwork Fri Mar 29 17:10:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13610842 X-Patchwork-Delegate: kvalo@adurom.com Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03F0D1369A7 for ; Fri, 29 Mar 2024 17:10:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732235; cv=none; b=TczLmcp8gXa1eSFdEQuSxYG8XoCL8Rj8dzZj33oDediT3NovEjzaIBy3bp8tNdQK4xtNR6bi2lYZMhmRfvZcBQrslVddGH2nf8WZedLIqJtkonrRx6Q9kUHt3VLFBKsS5Pgp8i1z/vPThTKU6n2h5E6fBAczSUCObU03KW92dbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732235; c=relaxed/simple; bh=j8245kNmaqBdGD54O9qpNwjQ/vWPCZt5nPTvELzjL/g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UDr1HPkM9c3Z4Q0iSUZ3HiGv5BWwiVgG4ZEYBikeEZr9/puYK++14soHAZ+s17e9pip9vIKyTH/dmBQ39Vh3YwlnIlVBeOSf+1NDOyCEqmBD+FrhRE57/LOu00s95El68efOAtE6NoI/STrYbZrJLekFqflbVjzmR6YL3CoinSY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tLpFC7Yt; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tLpFC7Yt" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-341d381d056so1342435f8f.0 for ; Fri, 29 Mar 2024 10:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711732232; x=1712337032; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9JyWn95xLCs1iHXcpGVAjRQMK08lG3ym0K6wct33L3E=; b=tLpFC7YtKxuP4E9ehr4QyL4D8irBYg6EMy5hBtoyHwJtj2jBU+mK8bFcZn9M81ylVY RQWZbtqakPbm0KxA90bxDnDsJvu1v93hI+na4k8oAkUJP0fO/Kcl93wFpOWye6szD33l fl7yItegzx+gBTlPfHarzlUJMtqZ2aPAuCoAv1DTNacJFz25iyX7IYOyVlMt2yLgyMca CmUsc7m27Qgrg5JMMk1qmMX+3DdKz1zIgyKpCB9hkOmWVjYWfyP5ps23ewXHepVOAR62 lsyndx67fugh7e7pfLdqHPFqe9Td21FBoqTnbCi6ToLOaiM4QO/Vr0kprwqL/xC/UsfN c9PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711732232; x=1712337032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9JyWn95xLCs1iHXcpGVAjRQMK08lG3ym0K6wct33L3E=; b=Ah739HQOXh9WyLHdDdwynDO9OvGYt/cxKUc1FETV66v/eXjxT5aKv0Nv6IbXs5hjCB u3x99PfzvOwwPk5GCNPNrAE6qvZiibvLInwxTkLxPEB3Q+r3SqCc3ggpLLz5gBWfgK6i AovWuZX7XXs2AcVAqbbJewCegZJ6XqKGmm8Ud+0MhqKFuZ9V3wX3xgQ+hvjgYrfiSbfy nsWPhXP19v4eaAjNW+XFB5EuEUm+wYoMDJe9Wlj0K+wTju+SnX+2UFooeQB5mHX1cJoO inyd5LRnGDDIuoi9Iwi9R8/s3B/NQlUh3UXPTD6KaxobVzhOfcqVGa14mLIGb1cG5bfb 6/pw== X-Forwarded-Encrypted: i=1; AJvYcCXpDMSY5s3LUURn+/g19r1WV/pzRfQjCfm3XFSG/Ard+/wcHIr8k1vrdlgsBFEwjzvUCv2JWb+BRNfUTqjnlwk6kguOU9g0/yJWSAhAKYY= X-Gm-Message-State: AOJu0Yz4G2331n7vTNM+btE/p90GERB/Lch0+4yeXLX/Xncp+GxYElRW 9mg9aLSxwOg2kW6E/OgwOeMko4zh7uzUOmFy8oxjdsYNPm1Gng9kh5jHHhAlCxc= X-Google-Smtp-Source: AGHT+IFW9DruHBuveqwhg+ktCb+5HkBVxgytJ4thp6p1EHASXSQYVUlK+ranP095Y2tSt5loVpZ6xQ== X-Received: by 2002:adf:f306:0:b0:33d:269e:132a with SMTP id i6-20020adff306000000b0033d269e132amr1766876wro.15.1711732232518; Fri, 29 Mar 2024 10:10:32 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id o17-20020a5d6851000000b0033ec9936909sm4577665wrw.39.2024.03.29.10.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 10:10:32 -0700 (PDT) From: Krzysztof Kozlowski To: Kalle Valo , Jeff Johnson , Brian Norris , Ajay Singh , Claudiu Beznea , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 4/6] wifi: ti: wl1251: simplify module initialization Date: Fri, 29 Mar 2024 18:10:17 +0100 Message-Id: <20240329171019.63836-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> References: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This driver's initialization functions do not perform any custom code, except printing messages. Printing messages on modules loading/unloading is discouraged because it pollutes the dmesg regardless whether user actually has this device. Core kernel code already gives tools to investigate whether module was loaded or not. Drop the printing messages which allows to replace open-coded module_sdio_driver(). Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/ti/wl1251/sdio.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/net/wireless/ti/wl1251/sdio.c b/drivers/net/wireless/ti/wl1251/sdio.c index 4e5b351f80f0..c705081249d6 100644 --- a/drivers/net/wireless/ti/wl1251/sdio.c +++ b/drivers/net/wireless/ti/wl1251/sdio.c @@ -323,25 +323,7 @@ static struct sdio_driver wl1251_sdio_driver = { .remove = wl1251_sdio_remove, .drv.pm = &wl1251_sdio_pm_ops, }; - -static int __init wl1251_sdio_init(void) -{ - int err; - - err = sdio_register_driver(&wl1251_sdio_driver); - if (err) - wl1251_error("failed to register sdio driver: %d", err); - return err; -} - -static void __exit wl1251_sdio_exit(void) -{ - sdio_unregister_driver(&wl1251_sdio_driver); - wl1251_notice("unloaded"); -} - -module_init(wl1251_sdio_init); -module_exit(wl1251_sdio_exit); +module_sdio_driver(wl1251_sdio_driver); MODULE_DESCRIPTION("TI WL1251 SDIO helpers"); MODULE_LICENSE("GPL"); From patchwork Fri Mar 29 17:10:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13610843 X-Patchwork-Delegate: kvalo@adurom.com Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1628139578 for ; Fri, 29 Mar 2024 17:10:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732237; cv=none; b=dT1Pj3uifQOoVwi7D5K0CJTMQ0ZElkSWGKXzppycXI7eZl6mLui5wAPSe3WBdO+BofZfacPh5Mr+PfM84mjWtgn4Ib//N+LVLL6F2x/fXZVTsTpnXWzbIzFKXLhT0FFX6k50hl0UaUcjici057XiByhXO2KyllfSs/fl6a7WTXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732237; c=relaxed/simple; bh=8V77xah4yhNVMN2cCcfaNNY+lDG7A6fibNbEMab70Q0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NoxtcYjokpHb4pXZ2SQUuk2cVvNI6ar9f3vuho08SYBc83d7FPTT3Xq5iJgEhi/WfpNWw3s+3sfKthnJoIZHIZxriFhEZwbAyQiNfB8/C5nHy3YNR6jMiYQrbZ4z6UneuXwMEwTP4jz9RfTFbm4Yyx+l3f+vqJMswzWBj3uAIls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=W/2r5L+5; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W/2r5L+5" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-341ccef5058so1455770f8f.2 for ; Fri, 29 Mar 2024 10:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711732234; x=1712337034; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LDPoBwJ5bVbQZyn7Kt2KFjIml91twnnq9PMjrREMHA0=; b=W/2r5L+5TloDmWztMjhTRmzXMgjPXFXs/uBOBjfKg0K/e8NN4DAD8GAUgprpmoqzqu YO1sB/WAfhGshDO7IxXyvqQxWpUm0r5ftNvLLHV60wr5GSRZ9TRchHPGh9zVa19ywC2O Mb4KaqsEAAjPeOb0gxJQ/squyxvUabzWn814NWPSIHyMkarFhPVtEKLM7WpXmp2x0vcw Aqj8Ch+yPsKkTFmyHtgJtGEP2pUlYe1EYy7mSL74MDzzSZo69RF2Ujw3oIRgpIp9M7s6 FCuRYninOD8lsT/eMRLCXGpk5Jv9b/6QJZiPA/Gm2i2VpkFVFd0omR2WP8V9ILIZfcTZ im5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711732234; x=1712337034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LDPoBwJ5bVbQZyn7Kt2KFjIml91twnnq9PMjrREMHA0=; b=FBwEa1jv/oUxHqI3gF2muUYz+CHQniouaK4Xd5zJT27PtvL+2/GsUJC1lkYgpqNQke TPWtL+O1UE5YB1Xxc40Uf4sz4uyt81rIxGd6LL6IgcBbp/wWhsFyYkG6K7Z7M4TDROGY ycDM333XCtJ74+uB0oxJnh8ApgiRUHJnvsWClKhdFEfz67aOzO2ZZIm8KTSrXzIImcwe U70nG/d/2zle5Ao5vCN/5l9JA8RZtHA4e7y36HEgBs2YmGGm1/b38ELcDXP8dQIh7gBI wxKxdFReMb64dYzrqb9pNR/IT/DJnsMv+ElZ3OEdLkimqADqMOe1j6knyAJLiaP3EWEd 2PCw== X-Forwarded-Encrypted: i=1; AJvYcCVLJ3DwtYPTlXJ4QyjHnFCThao9yVXvkr3vmRYLXogSfK6ijDbKB2RUzLBeQtl6EOSuc0AyyCEyMr5hQjgJ4wLKuN7oUhlBcM0dIL6sh04= X-Gm-Message-State: AOJu0Yx/or8zH0FzIg7yYnhrqp+8Xr8Cc82EWDubT+cgaLdf9Qn7foPi b1esdArJArySZUuuqgcaTk/cPV+mlRC82Mxs+kWeUwnVAHvuTQUDzgOHZgbdx08= X-Google-Smtp-Source: AGHT+IGHKEJmqmT8lE9uFbvmdQZUSZGau59d/kr0LCpA6rDvXpAZdTZRaCDa1JV/UgtVfEhdvK61uQ== X-Received: by 2002:a05:6000:1d82:b0:33d:a70d:a9b2 with SMTP id bk2-20020a0560001d8200b0033da70da9b2mr2096293wrb.5.1711732234082; Fri, 29 Mar 2024 10:10:34 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id o17-20020a5d6851000000b0033ec9936909sm4577665wrw.39.2024.03.29.10.10.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 10:10:33 -0700 (PDT) From: Krzysztof Kozlowski To: Kalle Valo , Jeff Johnson , Brian Norris , Ajay Singh , Claudiu Beznea , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 5/6] wifi: microchip: wilc1000: replace open-coded module_sdio_driver() Date: Fri, 29 Mar 2024 18:10:18 +0100 Message-Id: <20240329171019.63836-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> References: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Use module_sdio_driver() instead of open-coding it. No functional difference. Signed-off-by: Krzysztof Kozlowski --- drivers/net/wireless/microchip/wilc1000/sdio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c index d6d394693090..52a770c5e76f 100644 --- a/drivers/net/wireless/microchip/wilc1000/sdio.c +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c @@ -981,8 +981,7 @@ static struct sdio_driver wilc_sdio_driver = { .of_match_table = wilc_of_match, } }; -module_driver(wilc_sdio_driver, - sdio_register_driver, - sdio_unregister_driver); +module_sdio_driver(wilc_sdio_driver); + MODULE_DESCRIPTION("Atmel WILC1000 SDIO wireless driver"); MODULE_LICENSE("GPL"); From patchwork Fri Mar 29 17:10:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13610844 X-Patchwork-Delegate: kvalo@adurom.com Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D4B713A879 for ; Fri, 29 Mar 2024 17:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732239; cv=none; b=DR4/CU98+nfS47LZy3ilCna+xQxvAgDEpz1YE8w3VbLCFBzYB20DI+kkz6bbq4MRuDE2XIM5WzpLEf4Hwp384D7zgE0mXNrX+pQ+iH4zvnss6LHgFxFPX1Qm7VZ5Xb/PIyDcc7yv6vAL7KpQJvrYoT/py69FZzdX5cDBDYhuR6o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711732239; c=relaxed/simple; bh=TtoLYL6/37TatoGV95OdUAgrxwm+qIAgopro4pJ3dOg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IkLfCFPpbPDTHGQ5S7O6bx704OhQeFtqa5GplnNjxKiaUYHQ6bIXAsbECJJDHtlGstZ54oeUtpNZRar26oSaeCNgw6PiRJ7JkfYd8dhQqcet+eSUDUAjl3y29HzPhuxH5uHOxcb3ZOsKb2aGLsBHYuhWTU4V8PraZPRvLeY5tAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pYdkybMP; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pYdkybMP" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-33d90dfe73cso1146922f8f.0 for ; Fri, 29 Mar 2024 10:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711732235; x=1712337035; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EySlbPc6lhk6b3mrukjMCPGSpH2zeiX1mm/v3sWT7Wk=; b=pYdkybMP/oxDS75jztBh8pcoWsmTGNySgSqINdQP1oknjqoRlVvHX1zudh4csugXan nLp4bYyy6IxM/lpoWritifzvYUjv8ZT9QJ8PoV6cML0wfzWIFOOKWBXf8/eQF8RC6NeA s+Tua+XD6G5LH2aujkPrEEudk7NsI1t+Ppd+yI0aFzPseBHk/d61TAJwupj7Nyb/nSHI snA43tbpq1Ri0hFzofiiYHGCAArUeNj62Et3NzesglAN0ELsXMdFa61UTme/RlTWtaBv N4OBfgAbcX+6HWWSSt2VkhptZpdOjuVv60J6rrJX3xnB4PGgY6tS/JmNVXB/yBk7QfNk +ZKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711732235; x=1712337035; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EySlbPc6lhk6b3mrukjMCPGSpH2zeiX1mm/v3sWT7Wk=; b=DWFcVAlv7kpvaLbEUjUFt747vYpQ25ccN2xW4bvJug3ia15oXjddxHkQCT37EdvyS/ 9tOmymSzbVtLRAlx87tMFqyU7BrzhXPkBtfe9SZJQqRC64Z/0Sac3Gm7yGKytlw6s8BR IXc4vDeudG7gK53238ToRTtkX6jZVHMPOvEbJRyqNFwSnvJqQNzKs+0UbhVBr2VUsHlF +Q+Lfq0/842xtESQh16DJ3FwfNIGRaJf6zTakfT8zsnvQjR3Q/4EVxpeJwfh9jJqRoru hvGmypyp1rnl/c3A+kRM2TFLUvi821HrgA6MDH1Ft4dTYz8dpmrtTNxkQfq6btklHC9i 2u2A== X-Forwarded-Encrypted: i=1; AJvYcCU2ixozyenSepge4RZrKEVsoo20cZf1IRACcUSLTe1QQaCQpSh4Vte2rQ4F4IWLAWkloSkBg4sC/D4llg7F5iplHh9RknMOVyscBfPRAQ8= X-Gm-Message-State: AOJu0YwwSOoJ7kMvQLxH6tPTHeopQalL+LY/iRByEbBkpF4OK0I/Eqns dh80RE+8n2C0Nc50UqdSr2lE088B1yH41+CagLIAmu6YJgthVVTCYBUCubpWKIE= X-Google-Smtp-Source: AGHT+IEqNLgv3fhZtbvScXxguICCF550H3MDTyxKI1RnEPjR6ISgVMuNMpqBGyf1gUhiVrwdueDb6Q== X-Received: by 2002:adf:f108:0:b0:33e:c68d:d536 with SMTP id r8-20020adff108000000b0033ec68dd536mr2617553wro.15.1711732235465; Fri, 29 Mar 2024 10:10:35 -0700 (PDT) Received: from krzk-bin.. ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id o17-20020a5d6851000000b0033ec9936909sm4577665wrw.39.2024.03.29.10.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 10:10:35 -0700 (PDT) From: Krzysztof Kozlowski To: Kalle Valo , Jeff Johnson , Brian Norris , Ajay Singh , Claudiu Beznea , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 6/6] wifi: marvell: mwifiex: replace open-coded module_sdio_driver() Date: Fri, 29 Mar 2024 18:10:19 +0100 Message-Id: <20240329171019.63836-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> References: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Use module_sdio_driver() instead of open-coding it. No functional difference. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Francesco Dolcini --- drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c index 75f53c2f1e1f..e1b58ca1b3ba 100644 --- a/drivers/net/wireless/marvell/mwifiex/sdio.c +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c @@ -3183,7 +3183,7 @@ static struct mwifiex_if_ops sdio_ops = { .up_dev = mwifiex_sdio_up_dev, }; -module_driver(mwifiex_sdio, sdio_register_driver, sdio_unregister_driver); +module_sdio_driver(mwifiex_sdio); MODULE_AUTHOR("Marvell International Ltd."); MODULE_DESCRIPTION("Marvell WiFi-Ex SDIO Driver version " SDIO_VERSION);