From patchwork Tue Apr 2 02:22:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13613274 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 062EFCD1288 for ; Tue, 2 Apr 2024 02:29:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=tOafxq2pcJxBKhqf/S3S3gPGC2+bN17DMqGq3iQQm3A=; b=3wrqmFdSW7Fc1OG+GdD8gED+sc wifoVK8hyHIPBGz8b1h0sxqbvIi+HCoLvJIIpjxNxUa0ZhM4BaW6nmWK3dlTwQdlioOUW8lioW91m FFUPRndi49MQ2UEQSvgXGFVVtH5Ex1shQ7/yC+zQi8+GvXzpU1zOQ9R/+wE3H3pKm5N3pA0LMH4ji 1YW8HY/zrVkAQtlyPIWLcp+FHOM2K+OxERN7S+oRe/q+FSQ2X8PGUGsZRzqImOt8u1WykOj+1KKLM Rv/KWV4HUZGmxED+xXjmvrif71atmQ1bg9du3cGerJfhecvurswLBVmyf4icarYa9mkcl9Z74r1Vh +jdYfHlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrTuA-00000009SvJ-1Yi8; Tue, 02 Apr 2024 02:29:42 +0000 Received: from mail-am6eur05on20701.outbound.protection.outlook.com ([2a01:111:f403:2612::701] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrTu6-00000009Ssd-203v for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 02:29:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OGY80pORGK0V5WXK5F+QvloLNgl0JFKxwdj5JOvCbDAhJnV5wHT/BdwyjvgaPA6wlyCmPfDd+xHb0SaQbdv/LCws3Wm7vkwsLrxDu+iv2VQaMvuW+NfRmQq4YULds20BXvPIHL0+0KSck7evtYWXQVzJ+W2mVmmp33hiHEhyzKhgcWDx71TJRy5+0UyjltGDsy3014A3Sgbf0d8qsqu5pT9tv6BZuY2NgrvoDiR9MSD7477oj05aJ3a2jsbrHcax85IOc7Fw6pRgsvqLv4u9cYMtK7YoKS1hbNGdyLqig86WAP3lv27Q07oY92AZy8DB/wA0zq18FG+JoyS9gnA/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DkhFzy347CReKh8Y/3De5x5m9e7u839I/9k6SdaIf8U=; b=mV5KuqQjWfeKmIYlAK9YyOO/Cr7iTLfv3O+0NTI5nSKZY4/F4FHmgczr2um6oGD+xmCyEtYCogYVKTTiqPfJhANUfzUzGe8LVOdn7O4rG3GUlWnIP5AU6OSRfUral7bezCRp1pV/rjno8wmACdC+SAzr0NC2ibdbRjpTXb2RMe76vt6wNjxkJIBP5x0rga18qR+Zih7e3y8fIb7Erux2+DfzgxU3kZVUh2BWff0na4ERDYhNis1enlm6PdVWxfbypTKi/D7VysHohwLMy0kByg9VUTyokPUHg+4jioFKpHxJDPbdopb3/2zCs9QJpKIz8vwC1QcEpSl5YeyFlNB1yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DkhFzy347CReKh8Y/3De5x5m9e7u839I/9k6SdaIf8U=; b=N8sKeHH/M8AdyTjnZdNWgq8fFGuqKr4AnJOyzoD4ZT0Wwr/e8Vn4tyWHHpBfrYVA3skKMN4D5CofyZaFUuMdSFZLKZfM2/6L6y3Volx6LmuIoeNJr3/rlX7QDogUtv6B+Ot9eIuhjlnuQfF89EcXwgC6DRgEWEWHd+XSgtqQaII= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI0PR04MB10163.eurprd04.prod.outlook.com (2603:10a6:800:245::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Tue, 2 Apr 2024 02:14:26 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Tue, 2 Apr 2024 02:14:26 +0000 From: "Peng Fan (OSS)" Date: Tue, 02 Apr 2024 10:22:21 +0800 Subject: [PATCH v7 1/4] firmware: arm_scmi: introduce helper get_max_msg_size Message-Id: <20240402-pinctrl-scmi-v7-1-3ea519d12cf7@nxp.com> References: <20240402-pinctrl-scmi-v7-0-3ea519d12cf7@nxp.com> In-Reply-To: <20240402-pinctrl-scmi-v7-0-3ea519d12cf7@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712024557; l=2653; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=dKDsMHnM+cuvfvX6K6tAU3ADCasBJe+OHaz6qBQ1Tuc=; b=BXEvqDrMweYTrQWmeCX90oHZaEQ8sAgyCC+pFmkKF6QbH71xD0VSg0R59q76yjlcUJqjT+YPX 8bCHxaQc6NRDkbLO8e8F07O4pdjxaJT1bPKITT7N7CGrM0ypjjIEWXi X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR04CA0015.apcprd04.prod.outlook.com (2603:1096:4:197::21) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|VI0PR04MB10163:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XeY4g3fFyAd3tOJanD9V5prcD+bNXO2c53OXcLUOnQh7TH3ElRBmgMedEtiLLJHOk5bgjRx3oG6ryobMN4TnTrJfsKihDeG1PEbsb59xXtAOk5PEiFxmB7JD/bFOLs2pZ1Vd74pPYRUKFGiqYNsDXQWzEVXWXIrwR9HEcrNeyw+W7VuFe6wixkWdbA7M0VbJ7LDAOrJr7nQ62UufVdOWnUmXWftHPGIzMeAUEpav0Y5ePuCcqABUA/oLcUp3mxDMSVBTUiPayjjb3lET5GvL6StP6vZaCIpZSUyZw85sl4HpgvKAje1Xu6jyy6vFRF2bcbKhgXc9eGNPH4r8ZAR6OR79Q95buGc62qS1n6dvdTZgPfSUdzEyOTHWV3nyV3EcXoPoOF1UctRH3XalHLEXm25/9e+i5Qe4lHfGaRP6rtCmk2MHL9oohPBRjDYtXCkEphGpeRNOt9n2Bj4LGdfQslb2ZRFrwvS8A86oQVLW9arMlOoPtQwRqmE83aA3vDdcr5EqBpK2TjOV7VF7m/wATwiMiQ5Q/v0V9R7rg4pGFdBkNJjMZTBTwR8Q9LLq56bKqsJ0Ka4WG3qJj0tZfweA7pVgO0em+z7ip4Pe5rfW0DKWp1SZzF+dJT9SkihReIrmJ8TIh84EeYz8ICj05KfM1HlCoeYf7ueGIi0ZoszKqTs77xM2h1spotnLiD2KPNKmuBGG81ReQq9FrBMYNKSDb621DHqXbXMYPiv5f7P1hdM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(7416005)(366007)(52116005)(1800799015)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?VRQo+WmsR6Bot5gGZ1kv93TXxmKQ?= =?utf-8?q?YmJ/Ebgh+vyeiQ6I4IkR4qtJ6RiTnwRDqLCOjER0gArTWeTkanqtD55qGfv7eU99J?= =?utf-8?q?HUH64UDgUOUP9fxe9UU7gRE4SOKoNVOsxEsZEGdl/OTUVqNWINk5x5CUct6AcBVBh?= =?utf-8?q?9bq2DLTbpY56Cmfr1TUGEnduwaDdfXa8oNAgLRzDXr/UiplYiOGE73cFduqs8iqta?= =?utf-8?q?/8GqjCkIlApn9r6zbB0G43axJ7sgRtK+gxEyKLoURFAvIT5fLNBmRSIXsuogAfqu0?= =?utf-8?q?2UnMe5vmlPapvMjh8JxybQtVRVfDeIewAfRvfgAeFIiLozmbbnV7LPLCzENa6K5ao?= =?utf-8?q?oCoXVlcyCEb0dGQPCIXfPM2f2LwJJ1NLSFxndpxsnrrxERafftNLQNTaqPEP7IINb?= =?utf-8?q?9SzSTJV5PvEN3fDyVQvPotSBxRjhEwM7C+rj13wRZR55NpZZQbeCqPp659toMgzPN?= =?utf-8?q?PhEg7acOlPdD1bARrSmN/3amy4YI8r8C8BQ9twm6zJkkYmfSS6mXqqZDQmOICfgCJ?= =?utf-8?q?WOZ3WkLkEPAOFJwgJrE5h+DjSnFbxyaCm/FEg+eNOkh8ZIuBQpvktf10NNYztf6JQ?= =?utf-8?q?ihvNtvTvK4sdyzLe6XBTZcsXVfmYfzQ2uF/T5+YnGED0tuWPuwMoqUBDv6WduIhL3?= =?utf-8?q?TxDxaDjbOGm11bxM3yRG1ZizqaLVcqjHaunIKDuCdVMzYk98PrfJUTwL2MW2IoBvx?= =?utf-8?q?mkixg6TvhS6OSHntLsciu/WBaQpmTMwn/ODdcdoACAxvjTp6FXOQFxKoGPUT0fvDC?= =?utf-8?q?d2JHG+7w11z77yiWeXOp8AS3aSDPTDzkvmFjZ4MVsbkQEe67BXOXIC5eCqa30iz+x?= =?utf-8?q?uGHweuIKfcoznG7VcsFqtr8fVb8T+13OSuvcdnzwFYZiFdGWPN2GZ+d71uFl21OjP?= =?utf-8?q?WHBtwYyhqgbfVsVEejR9Qoz4RJ2pf3Z96LnhB8fOtmWfsyGiPRD1fO9vgj2pQMafL?= =?utf-8?q?tDyzZA35eTPPX0ScCac8Pz4oHu+ZBOqn8nGS3xTWd530baeWdBlQWZ6AU4ktBbm16?= =?utf-8?q?SSCmi9ylntf3rzzF2B/sZJpUvp0x21Y44K0wPviWa+2Jf9kQWAANwSjJfuD/M7Zje?= =?utf-8?q?j81PNiaj9/NllaTLfz/cp4vEIoc2JEpzyrE/yExdJa9FG24W1Ljs6A5RePUOD8K9y?= =?utf-8?q?6CUC0+QKyzpbu+AdrRzcoEc5rRa4kMBFz7Pp8dcxt/1vkIrqdHOg7NTswRGuTO4BN?= =?utf-8?q?SQgEjlDOZ9HW+T10xpzC6H+byzUMS849LacaWZD+ZGFCTIiMvcjQnj6PFx1pjNXuC?= =?utf-8?q?zQYc/kSAQeeOghRi0KS/3fs6S0G9yNW29ILL5L7HVTis4yPDm3OhUMG7Q1tr+1cgE?= =?utf-8?q?qlUXp1CDBQtBFQBrFurelMVzREIES2vsVxH4qywVk9hrtaLjQnDpCeugE3UM/YS/j?= =?utf-8?q?fhUdJ05d64EnPOuYQFN0NvFtg07BMZZ0NLkbEw9vjdFQs1fCFIfK7XHDSFzGUgmgK?= =?utf-8?q?E5r9xJ7/Dcktexd58Y3Rqgde543WMH4CBcT7JjAL85O6nxLGtG9t/HGrwldQGqMhp?= =?utf-8?q?85R3d2wHAukO?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca47d151-f66f-4488-c4e8-08dc52ba9ee5 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 02:14:26.3867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wFjV9CCWTLKjFXjK9O4Dr2rsjUMpnD7xDxq10isFrOYqUY+b8iUJ2ovRd+C6opasq7hgNOdVtZLoCQgfaAK3vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10163 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_192938_717220_93054179 X-CRM114-Status: GOOD ( 11.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan When Agent sending data to SCMI server, the Agent driver could check the size to avoid protocol buffer overflow. So introduce the helper get_max_msg_size. Reviewed-by: Cristian Marussi Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/driver.c | 15 +++++++++++++++ drivers/firmware/arm_scmi/protocols.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 2709598f3008..415e6f510057 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1488,6 +1488,20 @@ static int scmi_common_extended_name_get(const struct scmi_protocol_handle *ph, return ret; } +/** + * scmi_common_get_max_msg_size - Get maximum message size + * @ph: A protocol handle reference. + * + * Return: Maximum message size for the current protocol. + */ +static int scmi_common_get_max_msg_size(const struct scmi_protocol_handle *ph) +{ + const struct scmi_protocol_instance *pi = ph_to_pi(ph); + struct scmi_info *info = handle_to_scmi_info(pi->handle); + + return info->desc->max_msg_size; +} + /** * struct scmi_iterator - Iterator descriptor * @msg: A reference to the message TX buffer; filled by @prepare_message with @@ -1799,6 +1813,7 @@ static int scmi_protocol_msg_check(const struct scmi_protocol_handle *ph, static const struct scmi_proto_helpers_ops helpers_ops = { .extended_name_get = scmi_common_extended_name_get, + .get_max_msg_size = scmi_common_get_max_msg_size, .iter_response_init = scmi_iterator_init, .iter_response_run = scmi_iterator_run, .protocol_msg_check = scmi_protocol_msg_check, diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_scmi/protocols.h index 317d3fb32676..3e91536a77a3 100644 --- a/drivers/firmware/arm_scmi/protocols.h +++ b/drivers/firmware/arm_scmi/protocols.h @@ -258,6 +258,7 @@ struct scmi_fc_info { * @fastchannel_init: A common helper used to initialize FC descriptors by * gathering FC descriptions from the SCMI platform server. * @fastchannel_db_ring: A common helper to ring a FC doorbell. + * @get_max_msg_size: A common helper to get the maximum message size. */ struct scmi_proto_helpers_ops { int (*extended_name_get)(const struct scmi_protocol_handle *ph, @@ -277,6 +278,7 @@ struct scmi_proto_helpers_ops { struct scmi_fc_db_info **p_db, u32 *rate_limit); void (*fastchannel_db_ring)(struct scmi_fc_db_info *db); + int (*get_max_msg_size)(const struct scmi_protocol_handle *ph); }; /** From patchwork Tue Apr 2 02:22:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13613272 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B8E0CD128A for ; Tue, 2 Apr 2024 02:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=3uVMD2uWMLWGzrxF7ffD5s+x32h+1pK32sZCWgZEigc=; b=Sb3dkFrjaahbw8eBVJpZOLWtkq Dm4KjeYHO++kYFcP11slE/3SSuAgrIOZiiRSRuF7Jpwkkvy18XmB3kxhIJ+MybPnk6ti3ccq3nAAn Zhz6Y2+8OenhShileTIWHptGcHEBEIkjwcD+MR9Rx3S0978tpnsJSuajRn1Ij2UuLGIEmJW9IrPet hdx9lJInPOr0GobHqB2fHHZYutOQEQKKY/igMTb9ZtCNDA1FZFZi7qn2vmdiOiFncFZicuVhNOPNN drD8hHifHI4Hhr8VSUna36wAD9FrK4F1uBZBb1KHa1sGHwj7NUDFi3eIrLuGBwdiXV5XavR9CUn74 OYTSpFHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrTtb-00000009SgO-3MQP; Tue, 02 Apr 2024 02:29:07 +0000 Received: from mail-vi1eur05on20700.outbound.protection.outlook.com ([2a01:111:f403:2613::700] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrTtW-00000009Se3-2iWW for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 02:29:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RNWz73kvzn+pdbMhZQChM7gnFILcx9OlXcb89CiqrMcRDBOLGfKl028582xgejQYbdACSGCLN1MtWfpN6yIPWi8DjM9BHihnShE2kVRG+TSGYDjDrc+X7MiZiHH/kCzw5HNgy/0uaPDFtm41LVPVIb2XkJ1uRRtJEbZPlmBEOrjWhLkv1SfmxIxlcKR14gBiOzpd9tOTXP8WbqB+cU2sjtMGPyUw3s2dFOwCvd0dkWCZu5yKyO95Dtd7F2+eONx8nwLZCbX6lrEIG6wCcWldxhQTJu0Z8bM1S1ujIht7LjBq0Pti1NdjBEaPdcWLGNB/caiocz+syoaBwGabWJm1Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/BzLovi5aKNOiOuw8s4YMGfV7RBPkidh8VfX3S2pYQ=; b=Ffw0wTt91u5Pejb/R09iiuOnfYpdxB8khjROusUVwI/KK5ehBumsb23h8juxL4eGFi5PqQhmD51m4TDYKzDwX8kyWytqYr+aoLatCXLduIbsJ1M/HRQWif47I7o/iG9vGBuuwKs4iGNKfaM4iG0zVO+tIOaSetYQFu0q5o0MQMH7K14lLlefXpmxdeeCr0glLZeDTXB9GdovMHapEhjBZoNQN6BxKpl9Z42kprsgay5RCiphgeS4fDQeG9O+erL6d1jF3dbekVarGGSYc4zyq3SuSp4AfgK77aArEtNZrWKLP8FaYC7eUSphhj5ocl/n9yjLoMukXSzZbv7S6z2vkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/BzLovi5aKNOiOuw8s4YMGfV7RBPkidh8VfX3S2pYQ=; b=kVkKN8+Qal41bqPveCuRWbcUdY097uBskLeiDhp9uFDNT49OmVE6r5rrK8MU6ZDw0ew4e98TRcud9ZREA/8dro+sAYS09Y6z8W48k42/NqhfZgKGs3Mg0kzLc3jOdi+o4tRCBSacgAYcH0JHbZTIKtuOc9W2OvoziKItn0GqjVA= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI0PR04MB10163.eurprd04.prod.outlook.com (2603:10a6:800:245::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Tue, 2 Apr 2024 02:14:30 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Tue, 2 Apr 2024 02:14:30 +0000 From: "Peng Fan (OSS)" Date: Tue, 02 Apr 2024 10:22:22 +0800 Subject: [PATCH v7 2/4] dt-bindings: firmware: arm,scmi: support pinctrl protocol Message-Id: <20240402-pinctrl-scmi-v7-2-3ea519d12cf7@nxp.com> References: <20240402-pinctrl-scmi-v7-0-3ea519d12cf7@nxp.com> In-Reply-To: <20240402-pinctrl-scmi-v7-0-3ea519d12cf7@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712024557; l=2362; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=1H2rME0+2KWUaw0j7tYsXFokSaYx/bEPhCjn1uDoVYo=; b=CnToFQguE8XWssO8wp8RiiXw25ULCoGascUwv6rvQsxgBT0F1zNAgVL+8pxr3RYLCO8xwOeGd GxozKIphA8gCGc/NogPJBPWbeZOH13cc8HNw9IluGUxkMnSBrpeHC4f X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR04CA0015.apcprd04.prod.outlook.com (2603:1096:4:197::21) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|VI0PR04MB10163:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pi8sBonqQ0wsBYe+MySU/uAMNb9zE/hhp4BLTqRkJckfXCLVijQE9snQ4Xdww1b/deW+1x1p05fF8DX2AddCiZJ1c1yaFjq+J0fxPrKjjxj1BIWcT0dQajPU3Fs5+r6Q8GWuxknQ0I9yo7hjnBusrArLlJYwDOF4cpCXCc7lpguKv0fsTVzYZhSiQHOA2xHmt/4U1OrHciuADS70wOdiknLj/ajmxcQ+v5xz+dn56ZZSWSRqP7MPXe+ogXK12C3eEhFmdx7Q5XPRh/j5zk0NaVpDr/bpLMYX6EcWTQsnMJODxOCLnVxjv0HHU/eYxtpiOIiOnX8v/lBmWdb3YjfsogOcOWtN8zqLascv+ouUDYgUYxJG7lGhpyaPHttJGPsuOrMTstccgNoe0jXuYP1MZTumZ6TCAr2C5Zglrs6+PxCO+TTLaxxF4isZoKGKcrELl19Kh3HDQyJdIuMPURapN82zoUVsc47lBmLKAidO31IQ8/HFKuCkYEWsVCP1UCW3IX+dW/PBb/L0osBN5FfO6TpXuOT99wKjtLzvU6bHkvFJIfuKRJ0ezqzB2qRccDUEvVHiMbCNrkSn835mP5T0hrT4kot2IZ8FR4QlSXLCL67sHF7jcNxGUPGKUk569HlNxouVLHxo8h2HrKsfQqM6inVXu1sJh5P3YodTDhag6CJ7p3299NG4w4hjiMKYMGO0/xUD4eTigCnnMhM0v6lMVE1S3+2/6T+zuEoT+HEPrZY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(7416005)(366007)(52116005)(1800799015)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?kFpzk7RG5ZJEzgD3NjS+HOrljvr+?= =?utf-8?q?sszHO801WH29wLKO59eGLs/D9c/gMJPUTeb9puXynvmzNrYPl23rO3nhhPi6GbQ/a?= =?utf-8?q?LhfqDzi0qeryXksd/EnoIB/il8nBb+3NEoKR4w/rEmXEV/L96qIrRqbRnfSMY3T/7?= =?utf-8?q?3X2gEFfy/V7bt/PWFLEz8CIxTWE4Zz9w/umXOEGXFN4mNq8jcnJRO4k7aR9GtifU+?= =?utf-8?q?I3voqaFMzN7Fv6ECJwqReixe1VZLpTwZEB51Bzr/3xvkIJkLMUMJsTFtlifY0rxOq?= =?utf-8?q?jcUpzVfYWDOfyRHyYI+sLW/m7ezDF+KtNy3Ia0dGu8e3Qor7Lgg7N3YaTOl9w4Gs8?= =?utf-8?q?DKbc/zjbA8av+JHJAsqkzKS1POLR7Mhz4GoMxNEBa/ALU9lVIi+Ks2wj5vbYRU/CB?= =?utf-8?q?qiKodJW7H5Pm2bpCKAIbhxQN6hMfpZ6Tg7jc22m+7bQFnq+K0UNolJ68B17S9D9F0?= =?utf-8?q?4BexMsa3kb3G2sfDTwEQbu2Ep+iF1VxhnBx/v4qxWyIInyh1QMa73Flv9Z2/NHaNV?= =?utf-8?q?dv8U8QjakNzlYerJ4ZxDFYSZjJ6T5IGyIB17W6hUS+MOBneBN17bK0CQTuzQQ13q/?= =?utf-8?q?XsxcMRSV+x6ZMd8mzgZ8aOS22bVXxeYSKg4vojRDBhYmlzonQK1Pm++ovlWHFd8fG?= =?utf-8?q?QVIeXxa8Vd4Tcd9NtdoIF/OJeRphpWj3R0hiMF/m+Qq6HOeVSGxB1+gYBvZidfrSu?= =?utf-8?q?ODRRqjp2GP78Sdv+Dk5PVDSZDTAmjbBM1bGNki7VoWrw/IDnQKWC2hvkx0yMSxTTy?= =?utf-8?q?DmnD1hJS2rHZehe44c7jdFAuLm+ktdK8fxpWQA11ht08Vx0HGNIiAkxxieUJp3mpx?= =?utf-8?q?ZOCZRuJDiFn/ImwnUcKbGGc/GPoTKitsVCp0Vt/NUjYzDA0V8K5KjW/7+NMkAB+wA?= =?utf-8?q?EPtHspUFbPeIoRGnZ8GjRk+ql0sxRMqtNMJjz/ZUTackW71ziWj7ulHX78L7DQ9g1?= =?utf-8?q?Sk0y1gWdkNw81r06Dw7QQj+t/MxL2qXbguPa2V+DsRBla80gE+5ERfxVZ5zIRzl3c?= =?utf-8?q?nzv+MmFYK2OfFfEWsuAiIBLRwxRjbBXz/rr+dq6YqXOMUzmgQWfO7ldnqqQ30lr9o?= =?utf-8?q?5Q2zdyv5Tt9pRvEW0lcSo/w7sLupQvZDCRu89BdN1c8uG3qXV9folPT1bZKq8E3LJ?= =?utf-8?q?+BITPp06ifLh3XZC4qyE++f17En9xeRkIRpbXOWfNZGdkvPstoGErIfKng9Pjmknp?= =?utf-8?q?mOmbrHKOcRrT0LLnMB52u+sNz45NB43QrBVhvOAR8+SpcXd8uMyIKYUt1teYRSjLM?= =?utf-8?q?Q9u4TDBdnkFb3wlwRY24m7ezcP5GilrRzFuVP8EQ6LahbZqmXpdBw6dX7OicLQh9E?= =?utf-8?q?P3Bao+zuh33Xc3HK13KgtFoYGhmVVYNhTPi6bYDaDZWU+swxu1j828/YxhD7lzLIa?= =?utf-8?q?yCCX7kiqye8HSXPWJwoc6lZ6sqOytHc3nzBX/KbRZ9W/C2xf+5DFZhyN5TiXNl1/0?= =?utf-8?q?mKXxBe2mQrb94ozpW/ECPpb0/nqbVP2aG6RYcn/SpjlHdEPiz8eE7+M1apOkxGOUK?= =?utf-8?q?5L5h6TZJEAqy?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f48e070a-faee-44e2-8567-08dc52baa11e X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 02:14:30.0943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i5YquuwUKCTDzqi5qdMEYjBk8txOR44MKjZMFG7XN2B9jeyFALIJ7o3XwTyLbb5rpKMRuUfG6pNwM+aeXQoVcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10163 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_192902_913035_32342662 X-CRM114-Status: UNSURE ( 9.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Add SCMI v3.2 pinctrl protocol bindings and example. Reviewed-by: Rob Herring Reviewed-by: Linus Walleij Signed-off-by: Peng Fan --- .../devicetree/bindings/firmware/arm,scmi.yaml | 50 ++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml index 4591523b51a0..e9d3f043c4ed 100644 --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml @@ -247,6 +247,37 @@ properties: reg: const: 0x18 + protocol@19: + type: object + allOf: + - $ref: '#/$defs/protocol-node' + - $ref: /schemas/pinctrl/pinctrl.yaml + + unevaluatedProperties: false + + properties: + reg: + const: 0x19 + + patternProperties: + '-pins$': + type: object + allOf: + - $ref: /schemas/pinctrl/pincfg-node.yaml# + - $ref: /schemas/pinctrl/pinmux-node.yaml# + unevaluatedProperties: false + + description: + A pin multiplexing sub-node describes how to configure a + set of pins in some desired function. + A single sub-node may define several pin configurations. + This sub-node is using the default pinctrl bindings to configure + pin multiplexing and using SCMI protocol to apply a specified + configuration. + + required: + - reg + additionalProperties: false $defs: @@ -401,6 +432,25 @@ examples: scmi_powercap: protocol@18 { reg = <0x18>; }; + + scmi_pinctrl: protocol@19 { + reg = <0x19>; + + i2c2-pins { + groups = "g_i2c2_a", "g_i2c2_b"; + function = "f_i2c2"; + }; + + mdio-pins { + groups = "g_avb_mdio"; + drive-strength = <24>; + }; + + keys_pins: keys-pins { + pins = "gpio_5_17", "gpio_5_20", "gpio_5_22", "gpio_2_1"; + bias-pull-up; + }; + }; }; }; From patchwork Tue Apr 2 02:22:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13613273 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C0E2CD128A for ; Tue, 2 Apr 2024 02:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=LgAXU0YhKawcSWhcQLbz2spqfBNbRIwjxYKX2GbfqM0=; b=u2oXrdoccREq3SmFu9FWTfM8LD DuAsrQQy6X+m6JNCGq18YoUq3ryzT53L0++nZL0awyCg+pF3ancI+zbccPTtm1ntTvzfLRtavP84N G33SSXGlitN3xET8+2MlZpEY5Abj42lqPHtWKtGAiMLWVLTjysE7t9uvnImymJ/UR6jsM4vrLkIgB 26fV9FuaYjT3fcBP4CHHZCfEupaplH/L9cbWgv3nhrrhHjOXR+6kAoadBzVyz23sYZKKIhPKimU/h phrHPUjNSggoz+3axwE6TUIVW+exWYcgrCfTuvbpAK3fwHkzb7G8I7rlqDscoAsufVPDQwzKKKheL I0LeuYxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrTte-00000009Shl-2jV5; Tue, 02 Apr 2024 02:29:10 +0000 Received: from mail-vi1eur05on20700.outbound.protection.outlook.com ([2a01:111:f403:2613::700] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrTta-00000009Se3-0jiL for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 02:29:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S63Ior2XNfZL+WKH6GWc06sUW3J+DPO3zp2bSVowo4zTxMkEM0Nyp4qNJoFG1CEvi9L9/EU46ZQedoHbnof3j4YXvJcmjyXn6bSuJkRJSstEgBuNDti3qazJHxan4Xp7PXx1HDed7R2vBYUestkgzdgbJXQKU14ta/p85tf67HFgp1v07O9klaYjmogFpOlA2S/cOtvUjfnpZlqhg270kAidrdZYbJLHYK1I4YfxdljUi9EfISaydidNHvUQKRpeBWspax6uDrtZcAG0UL93CW/oCoei/yqKbmWFs/3Vg5g2Dcyb14Git42ZSecB7szcLhYN8yAOj0GxGXqD/+hVPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3gMYasi0SC4BYrugBOBLUv0189SiY8AqhmUuhnnRxdw=; b=m4QdcwzXvDGuA5zbTAIonUfMG6bSMN3GlqYixj7u5QVQXZ31tAPnycZntNgY+B0b6Oa6QT977Vqo+sCn/U3Rp6Ro/GuqX/qFrYHlWZDAGULht+nsgBuJDSEsi2WfltKmorUvWFHlLHoJ4LLBEPNHf+xsYuZSDsZAeXWurSS6ygiCWVbQ/wjlY4IKZpu/p0I+WxPjCA39zrYdgqKoe128vgGgmhgM4KhgYXiVE5mGfuVPuDrHGa3yllEXT/ZYpQwnuwhqM6YoieS8RqxyYkrGBEZTGLSAThM6hYww/ziqMgPTxi0QwXRSi7rOpyJx/NvgUXA0OdDf72hGB5GgI6gMug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3gMYasi0SC4BYrugBOBLUv0189SiY8AqhmUuhnnRxdw=; b=msPDX7ArzLUgvmAQEuYq+AuJt0OvQ5/kovpe99CnObNFep1pf4HSn4UY1WCdz8S1q0zTwrQ82bydfrB7r6wcA17hcDEyQ0FhUaSnqhQICVHePt6gAsko6KC3hJidYD9Kjv9NHjgEEJC1cN0pNq+VtyANImUp1sWsg2qfyPatoNg= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI0PR04MB10163.eurprd04.prod.outlook.com (2603:10a6:800:245::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Tue, 2 Apr 2024 02:14:34 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Tue, 2 Apr 2024 02:14:34 +0000 From: "Peng Fan (OSS)" Date: Tue, 02 Apr 2024 10:22:23 +0800 Subject: [PATCH v7 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Message-Id: <20240402-pinctrl-scmi-v7-3-3ea519d12cf7@nxp.com> References: <20240402-pinctrl-scmi-v7-0-3ea519d12cf7@nxp.com> In-Reply-To: <20240402-pinctrl-scmi-v7-0-3ea519d12cf7@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712024557; l=29592; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=QDQMn/pyZt1DNvj+/EHowHOSwDsyja68SmLFdOEv/Zk=; b=rkQLI112MZ/YS0BS7kxTJwFPpG3auUwV2kUD8bW5gZVNpjF9rQL6d4AsLTbSyqZdZRpQNtLFk b7fZAJizCeoDtRCrgxpTEEK101Lsb1wNs3TzDrfIHtB1M/I4LDtTpUK X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR04CA0015.apcprd04.prod.outlook.com (2603:1096:4:197::21) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|VI0PR04MB10163:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2qLpbynGKBupCWv6s4bV44979kSPge98EoH8WqyHaiDV/EW0pAnwlRmm0PABEyA/gyJoLLxhgZUciJakptLgroiVrLW68acHZFRJBbDB9MBapdrwAIG1A3+3Sbm/DpoJwnAjgCcL7/J6TkZe3Ht8DMyluCYtU375Z7rLg7dH5VsKr4tY8SLVjSUr3eSbshIv+BewyLEHGZLxNXR9dup/a7KiHQ7x+XWeHThbxxhab+rEjd5s9gGh6MRPWFzNYIa1YzjMVIpkBeYaSblYdwl0K/0VzlmjKe6DhWqWTkTD7KbzH8Qf/wN+aIZRuhSee1INZEbuo6n+aUOzd4VUdYEjFCh7zwAMQqazizmg92zGwDnO72WhlilzH2BJnfCSJe1kyEuxWUAXFl48IGjb7WbfIXsJ96V5nFVuPOix7rN/p6AwrNDZL2wKTXd0d88tAMZzsDE6WIM8yQ0tZITKT5Om0vsUVK+3aa4iiiDcK1cS4R+WurACptvbC15c3QAjIjecOxv8J8CJSmVATYs6l5dAg2sHtQwAZjHBmeW+CTQEAdnp+u7eG18FG941JQ09JnmRwheaXApDS40V1Uf1tq6vU7ncbtRJ/2YVaWUbncq6kCg6owdzehwf2L7MhmBZ0XBKuYYeDfNm2HtnlWc1YaIe/r9lfu1+riA3pNHzBM9DXDDNttMhuFb6QxwlaoVRgm7nFF3xtnbR3ZCC43oNJjPyx6u4p8hr7DgNezhk66G0Xm4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(7416005)(366007)(52116005)(1800799015)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?z2o5XSNWFMD2X47BLuMZ4bWxvc6L?= =?utf-8?q?gyAOTcOepNlEhNCEpipmmugmJiXdV68mJUCEXXNb6Q0AmqP3XKCywiXC5+XaSpq4y?= =?utf-8?q?8PWE+RnFr8TQLvJ1cTLBrm8Xx0FxL5ya1OinDFOoAc/HHVCeg1NCkf6Q1SmaRrVG7?= =?utf-8?q?fVhCjVQEe0T5b8yijsgOpG8wSu7aic67J2Bur8w3iyRfHO3jKELDGW5Fxg9Ptq/Ym?= =?utf-8?q?JFQqE58g4aKmOT6QLKJgzEQx7g1UOW2TVHZHBVq3vJxXJFka3vwsj1nlgmLAL93/n?= =?utf-8?q?B/lS+Pkiq2M2cSPzi6IHLqAqM5id8YSzSoDYs+jdwfx1nqV/6S26arJYUeEWWSD7k?= =?utf-8?q?N9tFcPm/XV4Q25Pz307XeCrgHMPtLbE5sfFkn/1hef8cpZ1ipqVQ3RScwOPuB8fvx?= =?utf-8?q?TYN1EnYCBsuw9DONjLHNfi6zGJsvEg8tPLqCue/b3725Y5yZ8VhnZxt3GVuqwGfsZ?= =?utf-8?q?JMkGWZNCw/VOkXyg+rX4/g9hbjdRzbAAi2aDDYg0hjjKkIf1Q6NYy0/p1LBthd5gI?= =?utf-8?q?gdr58MqP8d8dlVW9G1dHZ4EZheVMRiT34kyNH3hIquaMf0gQlmNAUzo5zlaj1K6po?= =?utf-8?q?dquqi9+ZKDEhVM65WviqLUjS0EYFNbW7LVr4FdzdDIa/pLE/pYxHV8TDcEqsBxG7S?= =?utf-8?q?8cdP1ze5W/ustKwnK61om7a+TmtUynNtyUveYa/nCix6aD0D759AvoVmSXOOeYn7O?= =?utf-8?q?ZZg8EmywmOWHkGWJ/p2pK9XFgXy+6u+7KGV6sFEG764mozfFyHEVvQJi5Ws8h5uvs?= =?utf-8?q?CrtEdcO96tkxQCGuKz84ZaKyQU9YP63umGmqal8u0hHD0+bGFOB2ve8LAHm0+bpIp?= =?utf-8?q?jzijd/ieJyul1GhovKM2twN/MwUjgGGmLqudQ8hF41wAiJskhOOpHaXP9BsyX0VZ7?= =?utf-8?q?V56yhBw+EMIJ9pSbP0Vwslap6sJ/KIDRRakrm1suRG6AuaK70ZvXfYB3upes+0rdm?= =?utf-8?q?CWm7n9jdVQIAcWiyEZxqYqVnTnvNb5J/FFb9CgrW+j5/jct3nhWeUCZIf/IIxMX23?= =?utf-8?q?tyeCoE3hcDWG+fkY4B2z1cV5nkKKZ8LWxQOvTy1cHla3EmtyCfwdKKkvNbAFgI4kw?= =?utf-8?q?VFtRfr0xazjA3uq+8hNYNURfp800BEGtD8BNIsDjGCNKMu2h8J8bC7mDuo43YQkwB?= =?utf-8?q?GUQ/vEyHieQS6bGaLtLwx18ezOJceP/5Eu51xjk2hPgJQEiqG6MbvfWLiFfjI7/PG?= =?utf-8?q?Js8zNUwIXgG+vCEXrqS9S2j8tRgZHfY0bK5nP1Bol45biBvh8rKeLN62YVJMaUAqi?= =?utf-8?q?BA5EbVMfJIVj8IaKI5pGbFjUchVWWAAEWJ0YW1rqufyxKm0kPUWiwMQo2SC1EGIbj?= =?utf-8?q?nEnB4cEIfU/XYCzMHcTVA1Yf6q8AktllWlt9tZwVjTfRYrwvpoDzDhIOCMZwvUFmO?= =?utf-8?q?oWs1DnT1KZjoGQiJ0WMOktQvoIl1yi4MaeeJAGU+HB7j5k5QgFh3YF/Sc5Ys/WgTl?= =?utf-8?q?8A1IqYB2eZA8BKKGdIYppblqeHdVFcYudb02fctYINSv3/yirY2lMbR0eAYaaeyTU?= =?utf-8?q?5Xa52EbvMhGT?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 960689f1-052e-424f-90ef-08dc52baa38a X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 02:14:34.3556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 64wN+AAzpADEdk+uYfsOzI5CAE2l5w3ol+okWT7veYKXPKneI/qwL20+J7ZBizpB9BlKkrdKEQXgs/XvvnreqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10163 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_192906_632247_A375EE03 X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Add basic implementation of the SCMI v3.2 pincontrol protocol. Co-developed-by: Oleksii Moisieiev Signed-off-by: Oleksii Moisieiev Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/Makefile | 3 +- drivers/firmware/arm_scmi/driver.c | 2 + drivers/firmware/arm_scmi/pinctrl.c | 897 ++++++++++++++++++++++++++++++++++ drivers/firmware/arm_scmi/protocols.h | 1 + include/linux/scmi_protocol.h | 83 ++++ 5 files changed, 985 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/Makefile b/drivers/firmware/arm_scmi/Makefile index a7bc4796519c..fd59f58ce8a2 100644 --- a/drivers/firmware/arm_scmi/Makefile +++ b/drivers/firmware/arm_scmi/Makefile @@ -10,7 +10,8 @@ scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_SMC) += smc.o scmi-transport-$(CONFIG_ARM_SCMI_HAVE_MSG) += msg.o scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_VIRTIO) += virtio.o scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_OPTEE) += optee.o -scmi-protocols-y = base.o clock.o perf.o power.o reset.o sensors.o system.o voltage.o powercap.o +scmi-protocols-y := base.o clock.o perf.o power.o reset.o sensors.o system.o voltage.o powercap.o +scmi-protocols-y += pinctrl.o scmi-module-objs := $(scmi-driver-y) $(scmi-protocols-y) $(scmi-transport-y) obj-$(CONFIG_ARM_SCMI_PROTOCOL) += scmi-core.o diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 415e6f510057..ac2d4b19727c 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -3142,6 +3142,7 @@ static int __init scmi_driver_init(void) scmi_voltage_register(); scmi_system_register(); scmi_powercap_register(); + scmi_pinctrl_register(); return platform_driver_register(&scmi_driver); } @@ -3159,6 +3160,7 @@ static void __exit scmi_driver_exit(void) scmi_voltage_unregister(); scmi_system_unregister(); scmi_powercap_unregister(); + scmi_pinctrl_unregister(); scmi_transports_exit(); diff --git a/drivers/firmware/arm_scmi/pinctrl.c b/drivers/firmware/arm_scmi/pinctrl.c new file mode 100644 index 000000000000..503cd1b55561 --- /dev/null +++ b/drivers/firmware/arm_scmi/pinctrl.c @@ -0,0 +1,897 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * System Control and Management Interface (SCMI) Pinctrl Protocol + * + * Copyright (C) 2024 EPAM + * Copyright 2024 NXP + */ + +#include +#include +#include + +#include "common.h" +#include "protocols.h" + +/* Updated only after ALL the mandatory features for that version are merged */ +#define SCMI_PROTOCOL_SUPPORTED_VERSION 0x10000 + +#define GET_GROUPS_NR(x) le32_get_bits((x), GENMASK(31, 16)) +#define GET_PINS_NR(x) le32_get_bits((x), GENMASK(15, 0)) +#define GET_FUNCTIONS_NR(x) le32_get_bits((x), GENMASK(15, 0)) + +#define EXT_NAME_FLAG(x) le32_get_bits((x), BIT(31)) +#define NUM_ELEMS(x) le32_get_bits((x), GENMASK(15, 0)) + +#define REMAINING(x) le32_get_bits((x), GENMASK(31, 16)) +#define RETURNED(x) le32_get_bits((x), GENMASK(11, 0)) + +#define CONFIG_FLAG_MASK GENMASK(19, 18) +#define SELECTOR_MASK GENMASK(17, 16) +#define SKIP_CONFIGS_MASK GENMASK(15, 8) +#define CONFIG_TYPE_MASK GENMASK(7, 0) + +enum scmi_pinctrl_protocol_cmd { + PINCTRL_ATTRIBUTES = 0x3, + PINCTRL_LIST_ASSOCIATIONS = 0x4, + PINCTRL_SETTINGS_GET = 0x5, + PINCTRL_SETTINGS_CONFIGURE = 0x6, + PINCTRL_REQUEST = 0x7, + PINCTRL_RELEASE = 0x8, + PINCTRL_NAME_GET = 0x9, + PINCTRL_SET_PERMISSIONS = 0xa, +}; + +struct scmi_msg_settings_conf { + __le32 identifier; + __le32 function_id; + __le32 attributes; + __le32 configs[]; +}; + +struct scmi_msg_settings_get { + __le32 identifier; + __le32 attributes; +}; + +struct scmi_resp_settings_get { + __le32 function_selected; + __le32 num_configs; + __le32 configs[]; +}; + +struct scmi_msg_pinctrl_protocol_attributes { + __le32 attributes_low; + __le32 attributes_high; +}; + +struct scmi_msg_pinctrl_attributes { + __le32 identifier; + __le32 flags; +}; + +struct scmi_resp_pinctrl_attributes { + __le32 attributes; + u8 name[SCMI_SHORT_NAME_MAX_SIZE]; +}; + +struct scmi_msg_pinctrl_list_assoc { + __le32 identifier; + __le32 flags; + __le32 index; +}; + +struct scmi_resp_pinctrl_list_assoc { + __le32 flags; + __le16 array[]; +}; + +struct scmi_msg_request { + __le32 identifier; + __le32 flags; +}; + +struct scmi_group_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; + u32 *group_pins; + u32 nr_pins; +}; + +struct scmi_function_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; + u32 *groups; + u32 nr_groups; +}; + +struct scmi_pin_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; +}; + +struct scmi_pinctrl_info { + u32 version; + int nr_groups; + int nr_functions; + int nr_pins; + struct scmi_group_info *groups; + struct scmi_function_info *functions; + struct scmi_pin_info *pins; +}; + +static int scmi_pinctrl_attributes_get(const struct scmi_protocol_handle *ph, + struct scmi_pinctrl_info *pi) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_pinctrl_protocol_attributes *attr; + + ret = ph->xops->xfer_get_init(ph, PROTOCOL_ATTRIBUTES, 0, sizeof(*attr), + &t); + if (ret) + return ret; + + attr = t->rx.buf; + + ret = ph->xops->do_xfer(ph, t); + if (!ret) { + pi->nr_functions = GET_FUNCTIONS_NR(attr->attributes_high); + pi->nr_groups = GET_GROUPS_NR(attr->attributes_low); + pi->nr_pins = GET_PINS_NR(attr->attributes_low); + if (pi->nr_pins == 0) { + dev_warn(ph->dev, "returned zero pins\n"); + ret = -EINVAL; + } + } + + ph->xops->xfer_put(ph, t); + return ret; +} + +static int scmi_pinctrl_count_get(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + switch (type) { + case PIN_TYPE: + return pi->nr_pins; + case GROUP_TYPE: + return pi->nr_groups; + case FUNCTION_TYPE: + return pi->nr_functions; + default: + return -EINVAL; + } +} + +static int scmi_pinctrl_validate_id(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type) +{ + int value; + + value = scmi_pinctrl_count_get(ph, type); + if (value < 0) + return value; + + if (selector >= value || value == 0) + return -EINVAL; + + return 0; +} + +static int scmi_pinctrl_attributes(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type, + u32 selector, char *name, + u32 *n_elems) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_pinctrl_attributes *tx; + struct scmi_resp_pinctrl_attributes *rx; + bool ext_name_flag; + + if (!name) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + ret = ph->xops->xfer_get_init(ph, PINCTRL_ATTRIBUTES, sizeof(*tx), + sizeof(*rx), &t); + if (ret) + return ret; + + tx = t->tx.buf; + rx = t->rx.buf; + tx->identifier = cpu_to_le32(selector); + tx->flags = cpu_to_le32(type); + + ret = ph->xops->do_xfer(ph, t); + if (!ret) { + if (n_elems) + *n_elems = NUM_ELEMS(rx->attributes); + + strscpy(name, rx->name, SCMI_SHORT_NAME_MAX_SIZE); + + ext_name_flag = !!EXT_NAME_FLAG(rx->attributes); + } + + ph->xops->xfer_put(ph, t); + + if (ret) + return ret; + /* + * If supported overwrite short name with the extended one; + * on error just carry on and use already provided short name. + */ + if (ext_name_flag) + ret = ph->hops->extended_name_get(ph, PINCTRL_NAME_GET, + selector, (u32 *)&type, name, + SCMI_MAX_STR_SIZE); + return ret; +} + +struct scmi_pinctrl_ipriv { + u32 selector; + enum scmi_pinctrl_selector_type type; + u32 *array; +}; + +static void iter_pinctrl_assoc_prepare_message(void *message, + u32 desc_index, + const void *priv) +{ + struct scmi_msg_pinctrl_list_assoc *msg = message; + const struct scmi_pinctrl_ipriv *p = priv; + + msg->identifier = cpu_to_le32(p->selector); + msg->flags = cpu_to_le32(p->type); + msg->index = cpu_to_le32(desc_index); +} + +static int iter_pinctrl_assoc_update_state(struct scmi_iterator_state *st, + const void *response, void *priv) +{ + const struct scmi_resp_pinctrl_list_assoc *r = response; + + st->num_returned = RETURNED(r->flags); + st->num_remaining = REMAINING(r->flags); + + return 0; +} + +static int +iter_pinctrl_assoc_process_response(const struct scmi_protocol_handle *ph, + const void *response, + struct scmi_iterator_state *st, void *priv) +{ + const struct scmi_resp_pinctrl_list_assoc *r = response; + struct scmi_pinctrl_ipriv *p = priv; + + p->array[st->desc_index + st->loop_idx] = + le16_to_cpu(r->array[st->loop_idx]); + + return 0; +} + +static int scmi_pinctrl_list_associations(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + u16 size, u32 *array) +{ + int ret; + void *iter; + struct scmi_iterator_ops ops = { + .prepare_message = iter_pinctrl_assoc_prepare_message, + .update_state = iter_pinctrl_assoc_update_state, + .process_response = iter_pinctrl_assoc_process_response, + }; + struct scmi_pinctrl_ipriv ipriv = { + .selector = selector, + .type = type, + .array = array, + }; + + if (!array || !size || type == PIN_TYPE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + iter = ph->hops->iter_response_init(ph, &ops, size, + PINCTRL_LIST_ASSOCIATIONS, + sizeof(struct scmi_msg_pinctrl_list_assoc), + &ipriv); + if (IS_ERR(iter)) + return PTR_ERR(iter); + + return ph->hops->iter_response_run(iter); +} + +struct scmi_settings_get_ipriv { + u32 selector; + enum scmi_pinctrl_selector_type type; + bool get_all; + enum scmi_pinctrl_conf_type *config_types; + u32 *config_values; +}; + +static void +iter_pinctrl_settings_get_prepare_message(void *message, u32 desc_index, + const void *priv) +{ + struct scmi_msg_settings_get *msg = message; + const struct scmi_settings_get_ipriv *p = priv; + u32 attributes; + + attributes = FIELD_PREP(SELECTOR_MASK, p->type); + + if (p->get_all) { + attributes |= FIELD_PREP(CONFIG_FLAG_MASK, 1) | + FIELD_PREP(SKIP_CONFIGS_MASK, desc_index); + } else { + attributes |= FIELD_PREP(CONFIG_TYPE_MASK, p->config_types[0]); + } + + msg->attributes = cpu_to_le32(attributes); + msg->identifier = cpu_to_le32(p->selector); +} + +static int +iter_pinctrl_settings_get_update_state(struct scmi_iterator_state *st, + const void *response, void *priv) +{ + const struct scmi_resp_settings_get *r = response; + struct scmi_settings_get_ipriv *p = priv; + + if (p->get_all) { + st->num_returned = le32_get_bits(r->num_configs, GENMASK(7, 0)); + st->num_remaining = le32_get_bits(r->num_configs, GENMASK(31, 24)); + } else { + st->num_returned = 1; + st->num_remaining = 0; + } + + return 0; +} + +static int +iter_pinctrl_settings_get_process_response(const struct scmi_protocol_handle *ph, + const void *response, + struct scmi_iterator_state *st, + void *priv) +{ + const struct scmi_resp_settings_get *r = response; + struct scmi_settings_get_ipriv *p = priv; + u32 type = le32_get_bits(r->configs[st->loop_idx * 2], GENMASK(7, 0)); + u32 val = le32_to_cpu(r->configs[st->loop_idx * 2 + 1]); + + if (p->get_all) { + p->config_types[st->desc_index + st->loop_idx] = type; + } else { + if (p->config_types[0] != type) + return -EINVAL; + } + + p->config_values[st->desc_index + st->loop_idx] = val; + + return 0; +} + +static int +scmi_pinctrl_settings_get(const struct scmi_protocol_handle *ph, u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value, bool get_all) +{ + int ret; + void *iter; + struct scmi_iterator_ops ops = { + .prepare_message = iter_pinctrl_settings_get_prepare_message, + .update_state = iter_pinctrl_settings_get_update_state, + .process_response = iter_pinctrl_settings_get_process_response, + }; + struct scmi_settings_get_ipriv ipriv = { + .selector = selector, + .type = type, + .get_all = get_all, + .config_types = &config_type, + .config_values = config_value, + }; + + if (!config_value || type == FUNCTION_TYPE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + iter = ph->hops->iter_response_init(ph, &ops, SCMI_PIN_OEM_END, + PINCTRL_SETTINGS_GET, + sizeof(struct scmi_msg_settings_get), + &ipriv); + if (IS_ERR(iter)) + return PTR_ERR(iter); + + return ph->hops->iter_response_run(iter); +} + +static int scmi_pinctrl_settings_get_one(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value) +{ + return scmi_pinctrl_settings_get(ph, selector, type, config_type, + config_value, false); +} + +static int scmi_pinctrl_settings_get_all(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value) +{ + return scmi_pinctrl_settings_get(ph, selector, type, config_type, + config_value, true); +} + +static int +scmi_pinctrl_settings_conf(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + u32 nr_configs, + enum scmi_pinctrl_conf_type *config_type, + u32 *config_value) +{ + struct scmi_xfer *t; + struct scmi_msg_settings_conf *tx; + u32 attributes; + int ret, i; + u32 configs_in_chunk, conf_num = 0; + u32 chunk; + int max_msg_size = ph->hops->get_max_msg_size(ph); + + if (!config_type || !config_value || type == FUNCTION_TYPE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + configs_in_chunk = (max_msg_size - sizeof(*tx)) / (sizeof(__le32) * 2); + while (conf_num < nr_configs) { + chunk = (nr_configs - conf_num > configs_in_chunk) ? + configs_in_chunk : nr_configs - conf_num; + + ret = ph->xops->xfer_get_init(ph, PINCTRL_SETTINGS_CONFIGURE, + sizeof(*tx) + + chunk * 2 * sizeof(__le32), 0, &t); + if (ret) + break; + + tx = t->tx.buf; + tx->identifier = cpu_to_le32(selector); + tx->function_id = cpu_to_le32(0xFFFFFFFF); + attributes = FIELD_PREP(GENMASK(1, 0), type) | + FIELD_PREP(GENMASK(9, 2), chunk); + tx->attributes = cpu_to_le32(attributes); + + for (i = 0; i < chunk; i++) { + tx->configs[i * 2] = + cpu_to_le32(config_type[conf_num + i]); + tx->configs[i * 2 + 1] = + cpu_to_le32(config_value[conf_num + i]); + } + + ret = ph->xops->do_xfer(ph, t); + + ph->xops->xfer_put(ph, t); + + if (ret) + break; + + conf_num += chunk; + } + + return ret; +} + +static int scmi_pinctrl_function_select(const struct scmi_protocol_handle *ph, + u32 group, + enum scmi_pinctrl_selector_type type, + u32 function_id) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_settings_conf *tx; + u32 attributes; + + ret = scmi_pinctrl_validate_id(ph, group, type); + if (ret) + return ret; + + ret = ph->xops->xfer_get_init(ph, PINCTRL_SETTINGS_CONFIGURE, + sizeof(*tx), 0, &t); + if (ret) + return ret; + + tx = t->tx.buf; + tx->identifier = cpu_to_le32(group); + tx->function_id = cpu_to_le32(function_id); + attributes = FIELD_PREP(GENMASK(1, 0), type) | BIT(10); + tx->attributes = cpu_to_le32(attributes); + + ret = ph->xops->do_xfer(ph, t); + ph->xops->xfer_put(ph, t); + + return ret; +} + +static int scmi_pinctrl_request_free(const struct scmi_protocol_handle *ph, + u32 identifier, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_protocol_cmd cmd) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_request *tx; + + if (type == FUNCTION_TYPE) + return -EINVAL; + + if (cmd != PINCTRL_REQUEST && cmd != PINCTRL_RELEASE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, identifier, type); + if (ret) + return ret; + + ret = ph->xops->xfer_get_init(ph, cmd, sizeof(*tx), 0, &t); + if (ret) + return ret; + + tx = t->tx.buf; + tx->identifier = cpu_to_le32(identifier); + tx->flags = cpu_to_le32(type); + + ret = ph->xops->do_xfer(ph, t); + ph->xops->xfer_put(ph, t); + + return ret; +} + +static int scmi_pinctrl_pin_request(const struct scmi_protocol_handle *ph, + u32 pin) +{ + return scmi_pinctrl_request_free(ph, pin, PIN_TYPE, PINCTRL_REQUEST); +} + +static int scmi_pinctrl_pin_free(const struct scmi_protocol_handle *ph, u32 pin) +{ + return scmi_pinctrl_request_free(ph, pin, PIN_TYPE, PINCTRL_RELEASE); +} + +static int scmi_pinctrl_get_group_info(const struct scmi_protocol_handle *ph, + u32 selector, + struct scmi_group_info *group) +{ + int ret; + + ret = scmi_pinctrl_attributes(ph, GROUP_TYPE, selector, group->name, + &group->nr_pins); + if (ret) + return ret; + + if (!group->nr_pins) { + dev_err(ph->dev, "Group %d has 0 elements", selector); + return -ENODATA; + } + + group->group_pins = kmalloc_array(group->nr_pins, + sizeof(*group->group_pins), + GFP_KERNEL); + if (!group->group_pins) + return -ENOMEM; + + ret = scmi_pinctrl_list_associations(ph, selector, GROUP_TYPE, + group->nr_pins, group->group_pins); + if (ret) { + kfree(group->group_pins); + return ret; + } + + group->present = true; + return 0; +} + +static int scmi_pinctrl_get_group_name(const struct scmi_protocol_handle *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >= pi->nr_groups || pi->nr_groups == 0) + return -EINVAL; + + if (!pi->groups[selector].present) { + int ret; + + ret = scmi_pinctrl_get_group_info(ph, selector, + &pi->groups[selector]); + if (ret) + return ret; + } + + *name = pi->groups[selector].name; + + return 0; +} + +static int scmi_pinctrl_group_pins_get(const struct scmi_protocol_handle *ph, + u32 selector, const u32 **pins, + u32 *nr_pins) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!pins || !nr_pins) + return -EINVAL; + + if (selector >= pi->nr_groups || pi->nr_groups == 0) + return -EINVAL; + + if (!pi->groups[selector].present) { + int ret; + + ret = scmi_pinctrl_get_group_info(ph, selector, + &pi->groups[selector]); + if (ret) + return ret; + } + + *pins = pi->groups[selector].group_pins; + *nr_pins = pi->groups[selector].nr_pins; + + return 0; +} + +static int scmi_pinctrl_get_function_info(const struct scmi_protocol_handle *ph, + u32 selector, + struct scmi_function_info *func) +{ + int ret; + + ret = scmi_pinctrl_attributes(ph, FUNCTION_TYPE, selector, func->name, + &func->nr_groups); + if (ret) + return ret; + + if (!func->nr_groups) { + dev_err(ph->dev, "Function %d has 0 elements", selector); + return -ENODATA; + } + + func->groups = kmalloc_array(func->nr_groups, sizeof(*func->groups), + GFP_KERNEL); + if (!func->groups) + return -ENOMEM; + + ret = scmi_pinctrl_list_associations(ph, selector, FUNCTION_TYPE, + func->nr_groups, func->groups); + if (ret) { + kfree(func->groups); + return ret; + } + + func->present = true; + return 0; +} + +static int scmi_pinctrl_get_function_name(const struct scmi_protocol_handle *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >= pi->nr_functions || pi->nr_functions == 0) + return -EINVAL; + + if (!pi->functions[selector].present) { + int ret; + + ret = scmi_pinctrl_get_function_info(ph, selector, + &pi->functions[selector]); + if (ret) + return ret; + } + + *name = pi->functions[selector].name; + return 0; +} + +static int +scmi_pinctrl_function_groups_get(const struct scmi_protocol_handle *ph, + u32 selector, u32 *nr_groups, + const u32 **groups) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!groups || !nr_groups) + return -EINVAL; + + if (selector >= pi->nr_functions || pi->nr_functions == 0) + return -EINVAL; + + if (!pi->functions[selector].present) { + int ret; + + ret = scmi_pinctrl_get_function_info(ph, selector, + &pi->functions[selector]); + if (ret) + return ret; + } + + *groups = pi->functions[selector].groups; + *nr_groups = pi->functions[selector].nr_groups; + + return 0; +} + +static int scmi_pinctrl_mux_set(const struct scmi_protocol_handle *ph, + u32 selector, u32 group) +{ + return scmi_pinctrl_function_select(ph, group, GROUP_TYPE, selector); +} + +static int scmi_pinctrl_get_pin_info(const struct scmi_protocol_handle *ph, + u32 selector, struct scmi_pin_info *pin) +{ + int ret; + + if (!pin) + return -EINVAL; + + ret = scmi_pinctrl_attributes(ph, PIN_TYPE, selector, pin->name, NULL); + if (ret) + return ret; + + pin->present = true; + return 0; +} + +static int scmi_pinctrl_get_pin_name(const struct scmi_protocol_handle *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >= pi->nr_pins) + return -EINVAL; + + if (!pi->pins[selector].present) { + int ret; + + ret = scmi_pinctrl_get_pin_info(ph, selector, + &pi->pins[selector]); + if (ret) + return ret; + } + + *name = pi->pins[selector].name; + + return 0; +} + +static int scmi_pinctrl_name_get(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + const char **name) +{ + switch (type) { + case PIN_TYPE: + return scmi_pinctrl_get_pin_name(ph, selector, name); + case GROUP_TYPE: + return scmi_pinctrl_get_group_name(ph, selector, name); + case FUNCTION_TYPE: + return scmi_pinctrl_get_function_name(ph, selector, name); + default: + return -EINVAL; + } +} + +static const struct scmi_pinctrl_proto_ops pinctrl_proto_ops = { + .count_get = scmi_pinctrl_count_get, + .name_get = scmi_pinctrl_name_get, + .group_pins_get = scmi_pinctrl_group_pins_get, + .function_groups_get = scmi_pinctrl_function_groups_get, + .mux_set = scmi_pinctrl_mux_set, + .settings_get_one = scmi_pinctrl_settings_get_one, + .settings_get_all = scmi_pinctrl_settings_get_all, + .settings_conf = scmi_pinctrl_settings_conf, + .pin_request = scmi_pinctrl_pin_request, + .pin_free = scmi_pinctrl_pin_free, +}; + +static int scmi_pinctrl_protocol_init(const struct scmi_protocol_handle *ph) +{ + int ret; + u32 version; + struct scmi_pinctrl_info *pinfo; + + ret = ph->xops->version_get(ph, &version); + if (ret) + return ret; + + dev_dbg(ph->dev, "Pinctrl Version %d.%d\n", + PROTOCOL_REV_MAJOR(version), PROTOCOL_REV_MINOR(version)); + + pinfo = devm_kzalloc(ph->dev, sizeof(*pinfo), GFP_KERNEL); + if (!pinfo) + return -ENOMEM; + + ret = scmi_pinctrl_attributes_get(ph, pinfo); + if (ret) + return ret; + + pinfo->pins = devm_kcalloc(ph->dev, pinfo->nr_pins, + sizeof(*pinfo->pins), GFP_KERNEL); + if (!pinfo->pins) + return -ENOMEM; + + pinfo->groups = devm_kcalloc(ph->dev, pinfo->nr_groups, + sizeof(*pinfo->groups), GFP_KERNEL); + if (!pinfo->groups) + return -ENOMEM; + + pinfo->functions = devm_kcalloc(ph->dev, pinfo->nr_functions, + sizeof(*pinfo->functions), GFP_KERNEL); + if (!pinfo->functions) + return -ENOMEM; + + pinfo->version = version; + + return ph->set_priv(ph, pinfo, version); +} + +static int scmi_pinctrl_protocol_deinit(const struct scmi_protocol_handle *ph) +{ + int i; + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + for (i = 0; i < pi->nr_groups; i++) { + if (pi->groups[i].present) { + kfree(pi->groups[i].group_pins); + pi->groups[i].present = false; + } + } + + for (i = 0; i < pi->nr_functions; i++) { + if (pi->functions[i].present) { + kfree(pi->functions[i].groups); + pi->functions[i].present = false; + } + } + + return 0; +} + +static const struct scmi_protocol scmi_pinctrl = { + .id = SCMI_PROTOCOL_PINCTRL, + .owner = THIS_MODULE, + .instance_init = &scmi_pinctrl_protocol_init, + .instance_deinit = &scmi_pinctrl_protocol_deinit, + .ops = &pinctrl_proto_ops, + .supported_version = SCMI_PROTOCOL_SUPPORTED_VERSION, +}; +DEFINE_SCMI_PROTOCOL_REGISTER_UNREGISTER(pinctrl, scmi_pinctrl) diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_scmi/protocols.h index 3e91536a77a3..c02cbfd2bb03 100644 --- a/drivers/firmware/arm_scmi/protocols.h +++ b/drivers/firmware/arm_scmi/protocols.h @@ -355,6 +355,7 @@ void __exit scmi_##name##_unregister(void) \ DECLARE_SCMI_REGISTER_UNREGISTER(base); DECLARE_SCMI_REGISTER_UNREGISTER(clock); DECLARE_SCMI_REGISTER_UNREGISTER(perf); +DECLARE_SCMI_REGISTER_UNREGISTER(pinctrl); DECLARE_SCMI_REGISTER_UNREGISTER(power); DECLARE_SCMI_REGISTER_UNREGISTER(reset); DECLARE_SCMI_REGISTER_UNREGISTER(sensors); diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h index b807141acc14..e59c48c1aed6 100644 --- a/include/linux/scmi_protocol.h +++ b/include/linux/scmi_protocol.h @@ -737,6 +737,88 @@ struct scmi_powercap_proto_ops { u32 *power_thresh_high); }; +enum scmi_pinctrl_selector_type { + PIN_TYPE = 0, + GROUP_TYPE, + FUNCTION_TYPE, +}; + +enum scmi_pinctrl_conf_type { + SCMI_PIN_DEFAULT = 0, + SCMI_PIN_BIAS_BUS_HOLD = 1, + SCMI_PIN_BIAS_DISABLE = 2, + SCMI_PIN_BIAS_HIGH_IMPEDANCE = 3, + SCMI_PIN_BIAS_PULL_UP = 4, + SCMI_PIN_BIAS_PULL_DEFAULT = 5, + SCMI_PIN_BIAS_PULL_DOWN = 6, + SCMI_PIN_DRIVE_OPEN_DRAIN = 7, + SCMI_PIN_DRIVE_OPEN_SOURCE = 8, + SCMI_PIN_DRIVE_PUSH_PULL = 9, + SCMI_PIN_DRIVE_STRENGTH = 10, + SCMI_PIN_INPUT_DEBOUNCE = 11, + SCMI_PIN_INPUT_MODE = 12, + SCMI_PIN_PULL_MODE = 13, + SCMI_PIN_INPUT_VALUE = 14, + SCMI_PIN_INPUT_SCHMITT = 15, + SCMI_PIN_LOW_POWER_MODE = 16, + SCMI_PIN_OUTPUT_MODE = 17, + SCMI_PIN_OUTPUT_VALUE = 18, + SCMI_PIN_POWER_SOURCE = 19, + SCMI_PIN_SLEW_RATE = 20, + SCMI_PIN_OEM_START = 192, + SCMI_PIN_OEM_END = 255, +}; + +/** + * struct scmi_pinctrl_proto_ops - represents the various operations provided + * by SCMI Pinctrl Protocol + * + * @count_get: returns count of the registered elements in given type + * @name_get: returns name by index of given type + * @group_pins_get: returns the set of pins, assigned to the specified group + * @function_groups_get: returns the set of groups, assigned to the specified + * function + * @mux_set: set muxing function for groups of pins + * @settings_get_one: returns one configuration parameter for pin or group + * specified by config_type + * @settings_get_all: returns all configuration parameters for pin or group + * @settings_conf: sets the configuration parameter for pin or group + * @pin_request: aquire pin before selecting mux setting + * @pin_free: frees pin, acquired by request_pin call + */ +struct scmi_pinctrl_proto_ops { + int (*count_get)(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type); + int (*name_get)(const struct scmi_protocol_handle *ph, u32 selector, + enum scmi_pinctrl_selector_type type, + const char **name); + int (*group_pins_get)(const struct scmi_protocol_handle *ph, + u32 selector, const unsigned int **pins, + unsigned int *nr_pins); + int (*function_groups_get)(const struct scmi_protocol_handle *ph, + u32 selector, unsigned int *nr_groups, + const unsigned int **groups); + int (*mux_set)(const struct scmi_protocol_handle *ph, u32 selector, + u32 group); + int (*settings_get_one)(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value); + int (*settings_get_all)(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value); + int (*settings_conf)(const struct scmi_protocol_handle *ph, + u32 selector, enum scmi_pinctrl_selector_type type, + unsigned int nr_configs, + enum scmi_pinctrl_conf_type *config_type, + u32 *config_value); + int (*pin_request)(const struct scmi_protocol_handle *ph, u32 pin); + int (*pin_free)(const struct scmi_protocol_handle *ph, u32 pin); +}; + /** * struct scmi_notify_ops - represents notifications' operations provided by * SCMI core @@ -844,6 +926,7 @@ enum scmi_std_protocol { SCMI_PROTOCOL_RESET = 0x16, SCMI_PROTOCOL_VOLTAGE = 0x17, SCMI_PROTOCOL_POWERCAP = 0x18, + SCMI_PROTOCOL_PINCTRL = 0x19, }; enum scmi_system_events { From patchwork Tue Apr 2 02:22:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13613287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DBABCD1288 for ; Tue, 2 Apr 2024 02:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=N7icWUH80awdY93X8FNtkUU82L8AnD9Xxgiu8EGJY7o=; b=laDYW4dr0/v/RESd5Gd0xDLRiu nqnnv82Yo9gQe7X9447CZdp6pj9CXVWAQsTPyeuWfFFK77QL3hIh0YxmvrdY3aVQg4+DoNX9h0pX2 rJWiKZt99oHEilWn5nbLG7thLjwALdS0dxxQhfTWOXC+TjN++odfJkohs2kboQ/tA97C4772/2alf 82aRGrQogafACKtxVV5dMbmH9U/zLoyz/KFAOxdtdhZOtteB+sMZGJalXM6slvAcrr1fx1cDe0/Bb JSlai1k+LuMMcg18u1/xGh9WM3tS+JKXSPoY0z96pm/z42NZE39JkBBPFh6E6s7nu9SrhiZ9cZyEh Y4lUsj/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrUCi-00000009V7R-0XNa; Tue, 02 Apr 2024 02:48:52 +0000 Received: from mail-he1eur04on20700.outbound.protection.outlook.com ([2a01:111:f403:260f::700] helo=EUR04-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrUCe-00000009V6Y-0y98 for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2024 02:48:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JoVaPyIvQsKkKVQdMbyieEw/oVpcDd8aeZUD9c+G8DtkHYrZwIU5zZQey3lZf1rL7NdU0jEC2NStu96FKSoczof+ZKjeKPTXkJEt+VXh6/MRJdFOnQuFYG70Kr3A4kwFOP/9Okpwby7qAzbxZ2aRpCDoYu2lgUr8DxHem913/6tWmhXhMXF/I2AKUngqre8TkoUV4bb1XBoY2FboViy73L7csFdYq0S9Coh+99K8JXK+3StfP7rg5oEciAQo8rSIBaCqwfvHiZDry3icT0/TpcNKs9I9YcJxkUVSHNbX272PbOCkPi7jAXsqI3xpUNrKzZGN35WNQOIWzxyXEp6IuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ulWCSZyziQTxWvaZEW0oMbGrfl0h+XL8SpBOOdVk7y0=; b=aZhQ09xg+Lzdyu3QnG6U3jssZ59R0bTbuWxFE5iuf7Nn/sxWzTfklces38YHLSkOEJReuVMH/8OZ7eVDBmsDbNrNyiBZqqH8B9J1apmHW81PZagzEJ3LZBj3gFha9lJKMpcyl8za+4WhpIH2/E/zcES16aDX40Nh5awbTTrjttQSDOXlKr0j0/oR7xjtFqi5owkGNOebXs4NyGBfHAVf+iMoFaoTnhWNmAIUNOpqQXJLqAoIDwXIIxFtsH1bowE1YQv4sIRJVzQRm40sYDavDQeZn48uLM+qD1RyDoLHsVjwHKsyuWpuOXyR2+qWyDlUbS22t0iR4JZkF2xNTygmHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ulWCSZyziQTxWvaZEW0oMbGrfl0h+XL8SpBOOdVk7y0=; b=JiKmC5BUJQvDFpI30SG1a+NhYz3h1J1gweNd1oa04jgbD32hTkwMk51E8sr03x1xdd2pyfeVhyxAWyVmRD1aPayFgFhybd8sVqdIqRGk1sJ+fBlNeq5NTNETE/7u8trsbp2/z5K2yMMNW+BsYL8Gi/ZgU+QNwpr1I0gKRIcVhXU= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI0PR04MB10163.eurprd04.prod.outlook.com (2603:10a6:800:245::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Tue, 2 Apr 2024 02:14:38 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Tue, 2 Apr 2024 02:14:38 +0000 From: "Peng Fan (OSS)" Date: Tue, 02 Apr 2024 10:22:24 +0800 Subject: [PATCH v7 4/4] pinctrl: Implementation of the generic scmi-pinctrl driver Message-Id: <20240402-pinctrl-scmi-v7-4-3ea519d12cf7@nxp.com> References: <20240402-pinctrl-scmi-v7-0-3ea519d12cf7@nxp.com> In-Reply-To: <20240402-pinctrl-scmi-v7-0-3ea519d12cf7@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712024558; l=18146; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=UERHr4F3f6FwDhLabCgl27ZHbM2x1cDubkQC3wdRx5o=; b=CVloQHrBmHVxwE8wLsRPF6FF1ByjjUYi/nZNtOSac4108lJcaBoOp/156083/TpSpzM4bZ37G LI+vHdWIQ1qBmJCSsQNSaWBwEwhv1Fu6gEbYWEeAaEtRglfiod0W/4M X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR04CA0015.apcprd04.prod.outlook.com (2603:1096:4:197::21) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|VI0PR04MB10163:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g/pOLDh28GcJKfqwVXgbQHWFiSIPm6IGm5MerASFPeQbmdjXzM2DO7QWtMVUEo4ysEKfrsspRI3FAPUNr7laiD+/VdalzlLAJtzFpJuoVEDZy6X5grFdtAQLxgHLQ2yDz2Q9HKUaBPyvuATQIo4XQ8q23VL7mnu/sZmKvkV/SLS1bEq3dtCN8HI1zA+C+blWfMxZc2pJdnSZKRCYk5OUZoh5WST+f4kBqAcC6rSajGCdcHV0m0shpARhe8FvhsBdCnmUawUqzAtVuoiZlJ8j/rwluiONADl3+Jj4H70qFfgBYjWZe54FfHdlx2C27fcrZnHOKmlhNpwij68y4FZeIsCi2jM+zswRVlxeoGrfH+W9l2lQpOPGYs1dv/R6CiZut7/HuBjefluUr6IxoOQg+Z32zFd5uCptk6G5yJrsVJg3E1l7PkcGaNqCnWoaAysvhCBje++37QVolaVxhhMqZ09IRq2aQ5NQPeDKSqblRuOVaJFPCqMWtU+YliQo1q26nZHYehFXZkVlvS0oQMNzE+uWoIp2TVKYPzu4FJziVOAIiOt5GnIkPcEhzH/9Tm2ewRI7rzDqlrx/kuv1/BDe/3aYz5GCodrUR8k7afBy5O6cGAzYjuveBOCfEjKkEz+VQroxVTl74ZCxEsEOgdNQZvd6J9TLX9LLK9Bo+9IvKULFqYEg12zpVFxqwK7LeLIGHQBPywDr4wSzTcoSs0tcU4BhL7OeVxm0z9hRHOcRRgk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(7416005)(366007)(52116005)(1800799015)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?QAsQQadAOOu65tYmElh8q2xXSoZA?= =?utf-8?q?k79o53q+4+wdVn+U0PIxebTGu6VD6FsOiKDWAQJ5iVS8gfF1SMf1IuVaJVtBsuSxy?= =?utf-8?q?ITpX52qFs2/bbIYXFRluxiuzoBGthJbl+efhza6gVjno4Vh8lvP008K4LV31rZfDK?= =?utf-8?q?pt+/gHMboiH9Ks3+A5NVe4B4S8nQziTzCZaojcBGWS640OyxJ+tSEwlGbyJ0nu+Mi?= =?utf-8?q?L2HvFAWiC2C8kbAku54CqiXFhPUxq3P7WJaSJzZ9o544hAViEcusOIJ4AWGdyilZF?= =?utf-8?q?u0W4POzAk858OmFVSSEgq7/hNRgb+B1+/JGi09s1EyzuaDWZqsItGmBhVlXoKcPDN?= =?utf-8?q?H3GDlYjQ8xBKBFu6Xva03i9/T/bLRoD/kQ0O0tKmixnl1RT7puNjYls152GDWrLxt?= =?utf-8?q?Xfgcq2q+ckJmCMRY8/r06uP6y2wl5OYYeBS1ng8DJBXaFYvFSWYEOwjgE3aoN8EXt?= =?utf-8?q?9hwRcXhBiHef8StDEBroRCLLJrjEsLs8Al0MeL37mqtZf0CqhgNhv5kEWodnx9IpC?= =?utf-8?q?hfATXbO+cKhqRCWwk/Qp3D/4wtnbVjj36oDwMMfpbKQVirW7MpWCCmMmVxjgfEuf4?= =?utf-8?q?XsYdBT9DYrn5DWGiCdJDb2oNxVmdZkp9wAyVa6tD2EJlF9dRi8QUWIowFV0oamobM?= =?utf-8?q?v8QkpR5nO9laIEVMEfKgHNwSQpHqNmYx53uuLvwm/Wbf0f9UP4FRFikQ+3XU7DpBh?= =?utf-8?q?ys4oIEe+366+gjvHnmCgGL4N/9rscsjFmeDCR+7lh0RPMwLD83DuY744kUbZ9e0yP?= =?utf-8?q?+w366u03Ig+nWWXrMNX8qOkbAUYBQVX9TO5rUqtNDM8kqYb7cMbacO914g7hqwa3Z?= =?utf-8?q?FQirgfuusl+iAwg2I5kv2mqHRA6Y4CaAdyXc3npRI96UZsp6h550/JKDIdWCkTTL8?= =?utf-8?q?v01iktEiogoMS2hDigIWo3YbN7adoDsonQd6LaGJLIMR8mJdB+vcYrNlcqriPmT8V?= =?utf-8?q?RGwfbScmCpfcJW9FQvpsrwXnijoURvYF5I2+qckO/JshC5P6Py6BQO8xIotVCQI11?= =?utf-8?q?Msew/NG0A+lgTMTL/kyi1ox3ozfZHwRzreEomoYNKtFwXdBUDB9k9LLblBMUNArTe?= =?utf-8?q?3nNc6SSvolq3Ai8a3PlLMbZu8SoO4QJhf5SVjSXmJHEV75UPxj36KhEh3gwZ9qZ85?= =?utf-8?q?k1f2G8fs8aEXRWFUVKcv6xObUuQMujb6TNQDo0Iq3C25VI5jdYDf2AmGJBlEWGvMy?= =?utf-8?q?6pziyovtPX+0T0+q5faydvORvc3ZWweBsitlX0kuYKCkFKO4uYHu9dJ4yjcgUnQaV?= =?utf-8?q?BzeDdEbKwuB5k9SIRFUrDi6I8lG9o6/9eozPaNriaOUj45inC/yaW8aoK4itpMCf/?= =?utf-8?q?orRZ7GoSTKZISBwndwHW5uNu3h5JMzS/KmCg03y5mooMK8K3mT442xsvVflIJJAjV?= =?utf-8?q?/iuB0T5wdvUg3Kf6DAE95wZk9Fd868m4FSaGsPvHJgdDlKDYCv+9UUIMmRrdjpj8/?= =?utf-8?q?BNOBf0+YYaO41ZVv7rMY+DPThr6lQ3swB8leFcu4SuB/scCgK9ugrRvf6lpGRTme/?= =?utf-8?q?KWRcYyYrte8o?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cecb838-cd3f-485d-ea05-08dc52baa658 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 02:14:38.8687 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7oeWFTm9xaQ1GUDCBi8N7l2hvw0fYFw9ud+GmLAvlGhbMUFu/XhoeVOX3AJlcWCeH/zVrlSPsfhT8nL7lIYiLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10163 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240401_194848_527819_98FC9A86 X-CRM114-Status: GOOD ( 19.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan scmi-pinctrl driver implements pinctrl driver interface and using SCMI protocol to redirect messages from pinctrl subsystem SDK to SCMI platform firmware, which does the changes in HW. Co-developed-by: Oleksii Moisieiev Signed-off-by: Oleksii Moisieiev Signed-off-by: Peng Fan --- MAINTAINERS | 1 + drivers/pinctrl/Kconfig | 11 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-scmi.c | 560 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 573 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4b511a55101c..d8270ac6651a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21457,6 +21457,7 @@ F: drivers/cpufreq/sc[mp]i-cpufreq.c F: drivers/firmware/arm_scmi/ F: drivers/firmware/arm_scpi.c F: drivers/hwmon/scmi-hwmon.c +F: drivers/pinctrl/pinctrl-scmi.c F: drivers/pmdomain/arm/ F: drivers/powercap/arm_scmi_powercap.c F: drivers/regulator/scmi-regulator.c diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index d45657aa986a..4e6f65cf0e76 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -450,6 +450,17 @@ config PINCTRL_ROCKCHIP help This support pinctrl and GPIO driver for Rockchip SoCs. +config PINCTRL_SCMI + tristate "Pinctrl driver using SCMI protocol interface" + depends on ARM_SCMI_PROTOCOL || COMPILE_TEST + select PINMUX + select GENERIC_PINCONF + help + This driver provides support for pinctrl which is controlled + by firmware that implements the SCMI interface. + It uses SCMI Message Protocol to interact with the + firmware providing all the pinctrl controls. + config PINCTRL_SINGLE tristate "One-register-per-pin type device tree based pinctrl driver" depends on OF diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index 2152539b53d5..cc809669405a 100644 --- a/drivers/pinctrl/Makefile +++ b/drivers/pinctrl/Makefile @@ -45,6 +45,7 @@ obj-$(CONFIG_PINCTRL_PIC32) += pinctrl-pic32.o obj-$(CONFIG_PINCTRL_PISTACHIO) += pinctrl-pistachio.o obj-$(CONFIG_PINCTRL_RK805) += pinctrl-rk805.o obj-$(CONFIG_PINCTRL_ROCKCHIP) += pinctrl-rockchip.o +obj-$(CONFIG_PINCTRL_SCMI) += pinctrl-scmi.o obj-$(CONFIG_PINCTRL_SINGLE) += pinctrl-single.o obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o obj-$(CONFIG_PINCTRL_STMFX) += pinctrl-stmfx.o diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c new file mode 100644 index 000000000000..827d9ef8a209 --- /dev/null +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -0,0 +1,560 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * System Control and Power Interface (SCMI) Protocol based pinctrl driver + * + * Copyright (C) 2024 EPAM + * Copyright 2024 NXP + */ + +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#include "pinctrl-utils.h" +#include "core.h" +#include "pinconf.h" + +#define DRV_NAME "scmi-pinctrl" + +/* Define num configs, if not large than 4 use stack, else use kcalloc */ +#define SCMI_NUM_CONFIGS 4 + +static const struct scmi_pinctrl_proto_ops *pinctrl_ops; + +struct scmi_pinctrl { + struct device *dev; + struct scmi_protocol_handle *ph; + struct pinctrl_dev *pctldev; + struct pinctrl_desc pctl_desc; + struct pinfunction *functions; + unsigned int nr_functions; + struct pinctrl_pin_desc *pins; + unsigned int nr_pins; +}; + +static int pinctrl_scmi_get_groups_count(struct pinctrl_dev *pctldev) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->count_get(pmx->ph, GROUP_TYPE); +} + +static const char *pinctrl_scmi_get_group_name(struct pinctrl_dev *pctldev, + unsigned int selector) +{ + int ret; + const char *name; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + ret = pinctrl_ops->name_get(pmx->ph, selector, GROUP_TYPE, &name); + if (ret) { + dev_err(pmx->dev, "get name failed with err %d", ret); + return NULL; + } + + return name; +} + +static int pinctrl_scmi_get_group_pins(struct pinctrl_dev *pctldev, + unsigned int selector, + const unsigned int **pins, + unsigned int *num_pins) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->group_pins_get(pmx->ph, selector, pins, num_pins); +} + +static const struct pinctrl_ops pinctrl_scmi_pinctrl_ops = { + .get_groups_count = pinctrl_scmi_get_groups_count, + .get_group_name = pinctrl_scmi_get_group_name, + .get_group_pins = pinctrl_scmi_get_group_pins, +#ifdef CONFIG_OF + .dt_node_to_map = pinconf_generic_dt_node_to_map_all, + .dt_free_map = pinconf_generic_dt_free_map, +#endif +}; + +static int pinctrl_scmi_get_functions_count(struct pinctrl_dev *pctldev) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->count_get(pmx->ph, FUNCTION_TYPE); +} + +static const char *pinctrl_scmi_get_function_name(struct pinctrl_dev *pctldev, + unsigned int selector) +{ + int ret; + const char *name; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + ret = pinctrl_ops->name_get(pmx->ph, selector, FUNCTION_TYPE, &name); + if (ret) { + dev_err(pmx->dev, "get name failed with err %d", ret); + return NULL; + } + + return name; +} + +static int pinctrl_scmi_get_function_groups(struct pinctrl_dev *pctldev, + unsigned int selector, + const char * const **p_groups, + unsigned int * const p_num_groups) +{ + struct pinfunction *func; + const unsigned int *group_ids; + unsigned int num_groups; + const char **groups; + int ret, i; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + if (!p_groups || !p_num_groups) + return -EINVAL; + + if (selector >= pmx->nr_functions) + return -EINVAL; + + func = &pmx->functions[selector]; + if (func->ngroups) + goto done; + + ret = pinctrl_ops->function_groups_get(pmx->ph, selector, &num_groups, + &group_ids); + if (ret) { + dev_err(pmx->dev, "Unable to get function groups, err %d", ret); + return ret; + } + if (!num_groups) + return -EINVAL; + + groups = kcalloc(num_groups, sizeof(*groups), GFP_KERNEL); + if (!groups) + return -ENOMEM; + + for (i = 0; i < num_groups; i++) { + groups[i] = pinctrl_scmi_get_group_name(pctldev, group_ids[i]); + if (!groups[i]) { + ret = -EINVAL; + goto err_free; + } + } + + func->ngroups = num_groups; + func->groups = groups; +done: + *p_groups = (const char * const *)func->groups; + *p_num_groups = func->ngroups; + + return 0; + +err_free: + kfree(groups); + + return ret; +} + +static int pinctrl_scmi_func_set_mux(struct pinctrl_dev *pctldev, + unsigned int selector, unsigned int group) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->mux_set(pmx->ph, selector, group); +} + +static int pinctrl_scmi_request(struct pinctrl_dev *pctldev, + unsigned int offset) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->pin_request(pmx->ph, offset); +} + +static int pinctrl_scmi_free(struct pinctrl_dev *pctldev, unsigned int offset) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->pin_free(pmx->ph, offset); +} + +static const struct pinmux_ops pinctrl_scmi_pinmux_ops = { + .request = pinctrl_scmi_request, + .free = pinctrl_scmi_free, + .get_functions_count = pinctrl_scmi_get_functions_count, + .get_function_name = pinctrl_scmi_get_function_name, + .get_function_groups = pinctrl_scmi_get_function_groups, + .set_mux = pinctrl_scmi_func_set_mux, +}; + +static int pinctrl_scmi_map_pinconf_type(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + u32 arg = param; + + switch (arg) { + case PIN_CONFIG_BIAS_BUS_HOLD: + *type = SCMI_PIN_BIAS_BUS_HOLD; + break; + case PIN_CONFIG_BIAS_DISABLE: + *type = SCMI_PIN_BIAS_DISABLE; + break; + case PIN_CONFIG_BIAS_HIGH_IMPEDANCE: + *type = SCMI_PIN_BIAS_HIGH_IMPEDANCE; + break; + case PIN_CONFIG_BIAS_PULL_DOWN: + *type = SCMI_PIN_BIAS_PULL_DOWN; + break; + case PIN_CONFIG_BIAS_PULL_PIN_DEFAULT: + *type = SCMI_PIN_BIAS_PULL_DEFAULT; + break; + case PIN_CONFIG_BIAS_PULL_UP: + *type = SCMI_PIN_BIAS_PULL_UP; + break; + case PIN_CONFIG_DRIVE_OPEN_DRAIN: + *type = SCMI_PIN_DRIVE_OPEN_DRAIN; + break; + case PIN_CONFIG_DRIVE_OPEN_SOURCE: + *type = SCMI_PIN_DRIVE_OPEN_SOURCE; + break; + case PIN_CONFIG_DRIVE_PUSH_PULL: + *type = SCMI_PIN_DRIVE_PUSH_PULL; + break; + case PIN_CONFIG_DRIVE_STRENGTH: + *type = SCMI_PIN_DRIVE_STRENGTH; + break; + case PIN_CONFIG_DRIVE_STRENGTH_UA: + *type = SCMI_PIN_DRIVE_STRENGTH; + break; + case PIN_CONFIG_INPUT_DEBOUNCE: + *type = SCMI_PIN_INPUT_DEBOUNCE; + break; + case PIN_CONFIG_INPUT_ENABLE: + *type = SCMI_PIN_INPUT_MODE; + break; + case PIN_CONFIG_INPUT_SCHMITT: + *type = SCMI_PIN_INPUT_SCHMITT; + break; + case PIN_CONFIG_INPUT_SCHMITT_ENABLE: + *type = SCMI_PIN_INPUT_MODE; + break; + case PIN_CONFIG_MODE_LOW_POWER: + *type = SCMI_PIN_LOW_POWER_MODE; + break; + case PIN_CONFIG_OUTPUT: + *type = SCMI_PIN_OUTPUT_VALUE; + break; + case PIN_CONFIG_OUTPUT_ENABLE: + *type = SCMI_PIN_OUTPUT_MODE; + break; + case PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS: + *type = SCMI_PIN_OUTPUT_VALUE; + break; + case PIN_CONFIG_POWER_SOURCE: + *type = SCMI_PIN_POWER_SOURCE; + break; + case PIN_CONFIG_SLEW_RATE: + *type = SCMI_PIN_SLEW_RATE; + break; + case SCMI_PIN_OEM_START ... SCMI_PIN_OEM_END: + *type = arg; + break; + default: + return -EINVAL; + } + + return 0; +} + +static int pinctrl_scmi_pinconf_get(struct pinctrl_dev *pctldev, + unsigned int _pin, unsigned long *config) +{ + int ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum pin_config_param config_type; + enum scmi_pinctrl_conf_type type; + u32 config_value; + + if (!config) + return -EINVAL; + + config_type = pinconf_to_config_param(*config); + + ret = pinctrl_scmi_map_pinconf_type(config_type, &type); + if (ret) + return ret; + + ret = pinctrl_ops->settings_get_one(pmx->ph, _pin, PIN_TYPE, type, + &config_value); + if (ret) + return ret; + + *config = pinconf_to_config_packed(config_type, config_value); + + return 0; +} + +static int +pinctrl_scmi_alloc_configs(struct pinctrl_dev *pctldev, u32 num_configs, + u32 **p_config_value, + enum scmi_pinctrl_conf_type **p_config_type) +{ + if (num_configs <= SCMI_NUM_CONFIGS) + return 0; + + *p_config_value = kcalloc(num_configs, sizeof(**p_config_value), GFP_KERNEL); + if (!*p_config_value) + return -ENOMEM; + + *p_config_type = kcalloc(num_configs, sizeof(**p_config_type), GFP_KERNEL); + if (!*p_config_type) { + kfree(*p_config_value); + return -ENOMEM; + } + + return 0; +} + +static void +pinctrl_scmi_free_configs(struct pinctrl_dev *pctldev, u32 num_configs, + u32 **p_config_value, + enum scmi_pinctrl_conf_type **p_config_type) +{ + if (num_configs <= SCMI_NUM_CONFIGS) + return; + + kfree(*p_config_value); + kfree(*p_config_type); +} + +static int pinctrl_scmi_pinconf_set(struct pinctrl_dev *pctldev, + unsigned int _pin, + unsigned long *configs, + unsigned int num_configs) +{ + int i, ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; + u32 config_value[SCMI_NUM_CONFIGS]; + enum scmi_pinctrl_conf_type *p_config_type = config_type; + u32 *p_config_value = config_value; + enum pin_config_param param; + + if (!configs || !num_configs) + return -EINVAL; + + ret = pinctrl_scmi_alloc_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + if (ret) + return ret; + + for (i = 0; i < num_configs; i++) { + param = pinconf_to_config_param(configs[i]); + ret = pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + goto free_config; + } + p_config_value[i] = pinconf_to_config_argument(configs[i]); + } + + ret = pinctrl_ops->settings_conf(pmx->ph, _pin, PIN_TYPE, num_configs, + p_config_type, p_config_value); + if (ret) + dev_err(pmx->dev, "Error parsing config %d\n", ret); + +free_config: + pinctrl_scmi_free_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + return ret; +} + +static int pinctrl_scmi_pinconf_group_set(struct pinctrl_dev *pctldev, + unsigned int group, + unsigned long *configs, + unsigned int num_configs) +{ + int i, ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; + u32 config_value[SCMI_NUM_CONFIGS]; + enum scmi_pinctrl_conf_type *p_config_type = config_type; + u32 *p_config_value = config_value; + enum pin_config_param param; + + if (!configs || !num_configs) + return -EINVAL; + + ret = pinctrl_scmi_alloc_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + if (ret) + return ret; + + for (i = 0; i < num_configs; i++) { + param = pinconf_to_config_param(configs[i]); + ret = pinctrl_scmi_map_pinconf_type(param, + &p_config_type[i]); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + goto free_config; + } + + p_config_value[i] = pinconf_to_config_argument(configs[i]); + } + + ret = pinctrl_ops->settings_conf(pmx->ph, group, GROUP_TYPE, + num_configs, p_config_type, + p_config_value); + if (ret) + dev_err(pmx->dev, "Error parsing config %d", ret); + +free_config: + pinctrl_scmi_free_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + return ret; +}; + +static int pinctrl_scmi_pinconf_group_get(struct pinctrl_dev *pctldev, + unsigned int group, + unsigned long *config) +{ + int ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum pin_config_param config_type; + enum scmi_pinctrl_conf_type type; + u32 config_value; + + if (!config) + return -EINVAL; + + config_type = pinconf_to_config_param(*config); + ret = pinctrl_scmi_map_pinconf_type(config_type, &type); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + return ret; + } + + ret = pinctrl_ops->settings_get_one(pmx->ph, group, GROUP_TYPE, type, + &config_value); + if (ret) + return ret; + + *config = pinconf_to_config_packed(config_type, config_value); + + return 0; +} + +static const struct pinconf_ops pinctrl_scmi_pinconf_ops = { + .is_generic = true, + .pin_config_get = pinctrl_scmi_pinconf_get, + .pin_config_set = pinctrl_scmi_pinconf_set, + .pin_config_group_set = pinctrl_scmi_pinconf_group_set, + .pin_config_group_get = pinctrl_scmi_pinconf_group_get, + .pin_config_config_dbg_show = pinconf_generic_dump_config, +}; + +static int pinctrl_scmi_get_pins(struct scmi_pinctrl *pmx, + struct pinctrl_desc *desc) +{ + struct pinctrl_pin_desc *pins; + unsigned int npins; + int ret, i; + + npins = pinctrl_ops->count_get(pmx->ph, PIN_TYPE); + /* + * npins will never be zero, the scmi pinctrl driver has bailed out + * if npins is zero. + */ + pins = devm_kmalloc_array(pmx->dev, npins, sizeof(*pins), GFP_KERNEL); + if (!pins) + return -ENOMEM; + + for (i = 0; i < npins; i++) { + pins[i].number = i; + ret = pinctrl_ops->name_get(pmx->ph, i, PIN_TYPE, &pins[i].name); + if (ret) + return dev_err_probe(pmx->dev, ret, + "Can't get name for pin %d", i); + } + + desc->npins = npins; + desc->pins = pins; + dev_dbg(pmx->dev, "got pins %u", npins); + + return 0; +} + +static const struct scmi_device_id scmi_id_table[] = { + { SCMI_PROTOCOL_PINCTRL, "pinctrl" }, + { } +}; +MODULE_DEVICE_TABLE(scmi, scmi_id_table); + +static int scmi_pinctrl_probe(struct scmi_device *sdev) +{ + int ret; + struct device *dev = &sdev->dev; + struct scmi_pinctrl *pmx; + const struct scmi_handle *handle; + struct scmi_protocol_handle *ph; + + if (!sdev->handle) + return -EINVAL; + + handle = sdev->handle; + + pinctrl_ops = handle->devm_protocol_get(sdev, SCMI_PROTOCOL_PINCTRL, &ph); + if (IS_ERR(pinctrl_ops)) + return PTR_ERR(pinctrl_ops); + + pmx = devm_kzalloc(dev, sizeof(*pmx), GFP_KERNEL); + if (!pmx) + return -ENOMEM; + + pmx->ph = ph; + + pmx->dev = dev; + pmx->pctl_desc.name = DRV_NAME; + pmx->pctl_desc.owner = THIS_MODULE; + pmx->pctl_desc.pctlops = &pinctrl_scmi_pinctrl_ops; + pmx->pctl_desc.pmxops = &pinctrl_scmi_pinmux_ops; + pmx->pctl_desc.confops = &pinctrl_scmi_pinconf_ops; + + ret = pinctrl_scmi_get_pins(pmx, &pmx->pctl_desc); + if (ret) + return ret; + + ret = devm_pinctrl_register_and_init(dev, &pmx->pctl_desc, pmx, + &pmx->pctldev); + if (ret) + return dev_err_probe(dev, ret, "Failed to register pinctrl\n"); + + pmx->nr_functions = pinctrl_scmi_get_functions_count(pmx->pctldev); + pmx->functions = devm_kcalloc(dev, pmx->nr_functions, + sizeof(*pmx->functions), GFP_KERNEL); + if (!pmx->functions) + return -ENOMEM; + + return pinctrl_enable(pmx->pctldev); +} + +static struct scmi_driver scmi_pinctrl_driver = { + .name = DRV_NAME, + .probe = scmi_pinctrl_probe, + .id_table = scmi_id_table, +}; +module_scmi_driver(scmi_pinctrl_driver); + +MODULE_AUTHOR("Oleksii Moisieiev "); +MODULE_AUTHOR("Peng Fan "); +MODULE_DESCRIPTION("ARM SCMI pin controller driver"); +MODULE_LICENSE("GPL");