From patchwork Wed Apr 3 08:19:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huisong Li X-Patchwork-Id: 13615355 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC8CBCD1288 for ; Wed, 3 Apr 2024 08:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tSLkbJNtEhjJYmfjeuLFCWydhgGtNp/TYGSZZhbGMks=; b=Is6jA1hPX8/tVS Jk/upG/IUQB+lPh5qGCkeYiQBZ6Alyea2Qg6maUITr09aknBMKltmJIjuDzyXuMln/jjnt4wQJAbL psvnvIJP4hKNIjlJ3kF25yy8vhUuVEO77ftysUyaOCDTx4xaCJXZE4h4miZOxn2eHzXRRR6qzDNxe 3sYHkyxXBCKRKLIq6IjuVoBPwkpKjTvnJyMn+JpaQ+St6zl9WJQEzBj9io0kCeWFQLZWMu/bOLxfG bzWpRyz5cLFpbwa1IY+Og0U9oVaUsmZQpBTgOykB1M/Ii62L8kl+yZLCuWSBtRBJX77hQNDN5WLEd FExZVFOK1EE/A81QzYWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrvxl-0000000EsAm-0W74; Wed, 03 Apr 2024 08:27:17 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrvxh-0000000Es55-00JI for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 08:27:15 +0000 Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4V8d7y2YQxz1R8dx; Wed, 3 Apr 2024 16:24:14 +0800 (CST) Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242]) by mail.maildlp.com (Postfix) with ESMTPS id 52D0918001A; Wed, 3 Apr 2024 16:27:00 +0800 (CST) Received: from localhost.localdomain (10.28.79.22) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 3 Apr 2024 16:26:59 +0800 From: Huisong Li To: CC: , , , , , Subject: [PATCH 1/2] soc: hisilicon: kunpeng_hccs: Add the check for obtaining complete port attribute Date: Wed, 3 Apr 2024 16:19:34 +0800 Message-ID: <20240403081935.24308-2-lihuisong@huawei.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20240403081935.24308-1-lihuisong@huawei.com> References: <20240403081935.24308-1-lihuisong@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.28.79.22] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600004.china.huawei.com (7.193.23.242) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_012713_243241_F880BA3B X-CRM114-Status: GOOD ( 11.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The hccs_get_all_port_attr() is used to obtained the attribute of all ports on a specified DIE from firmware. However, this interface doesn't ensure whether firmware reports the complete attribute of all ports or not. So this patch adds the check for this. Signed-off-by: Huisong Li --- drivers/soc/hisilicon/kunpeng_hccs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/soc/hisilicon/kunpeng_hccs.c b/drivers/soc/hisilicon/kunpeng_hccs.c index 9ff70b38e5e9..bb69a95b5f2d 100644 --- a/drivers/soc/hisilicon/kunpeng_hccs.c +++ b/drivers/soc/hisilicon/kunpeng_hccs.c @@ -556,6 +556,12 @@ static int hccs_get_all_port_attr(struct hccs_dev *hdev, start_id = rsp_head.next_id; } + if (left_buf_len != 0) { + dev_err(hdev->dev, "do not get the expected port number(%u) attribute.\n", + size); + return -EINVAL; + } + return 0; } From patchwork Wed Apr 3 08:19:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huisong Li X-Patchwork-Id: 13615357 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAD40CD128D for ; Wed, 3 Apr 2024 08:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GkECT0ueDufIEBoc3wo3aq/7eDhuaMyd+IsIc8cHMDc=; b=hbpzVOQQGO8L9G XFz7DAKg3NjuFVBy60iaMDgdvr0FSO8LpC966DiV/ihEj6ZcQkpj2dnGJhbmkc3FdhKTeeo7LQnW3 KHG75L4WeNfnYL+BVYaQNVxt04Pq5xYVNRZ1hronN1cJeUW75I7KX1kudoRgaQeOKc9TCHzzmB6Y1 9eMq2IQqAYUQSvYjpNGGuctrmlEgQCRyS/IxwIxzfOmk45sS4sMbPMHwlkN4Azb+nYdaIcHsO5Rcx lXyPGQcJZ7knfocVW4pk7vf4OIJTnz8ZuuNHzU8KkHKkprbytFcBNxSiVYe5qRU2dRhPP9eQM1tTw V5eFqlM1mJAKfpYSkqXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrvxl-0000000EsBY-3s3C; Wed, 03 Apr 2024 08:27:17 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrvxh-0000000Es53-0IGt for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 08:27:15 +0000 Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4V8d7z1mhcz1h5X0; Wed, 3 Apr 2024 16:24:15 +0800 (CST) Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242]) by mail.maildlp.com (Postfix) with ESMTPS id AC148140133; Wed, 3 Apr 2024 16:27:00 +0800 (CST) Received: from localhost.localdomain (10.28.79.22) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 3 Apr 2024 16:27:00 +0800 From: Huisong Li To: CC: , , , , , Subject: [PATCH 2/2] soc: hisilicon: kunpeng_hccs: replace MAILBOX dependency with PCC Date: Wed, 3 Apr 2024 16:19:35 +0800 Message-ID: <20240403081935.24308-3-lihuisong@huawei.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20240403081935.24308-1-lihuisong@huawei.com> References: <20240403081935.24308-1-lihuisong@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.28.79.22] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600004.china.huawei.com (7.193.23.242) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_012713_300831_9C0040BD X-CRM114-Status: GOOD ( 10.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The kunpeng_hccs driver depands on Platform Communication Channel Driver. If PCC driver is not enabled, this driver fails to probe. Seeing as how PCC driver depands on MAILBOX. so replace MAILBOX dependency with PCC. Signed-off-by: Huisong Li --- drivers/soc/hisilicon/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/hisilicon/Kconfig b/drivers/soc/hisilicon/Kconfig index 0ab688af308f..4b0a099b28cc 100644 --- a/drivers/soc/hisilicon/Kconfig +++ b/drivers/soc/hisilicon/Kconfig @@ -6,7 +6,7 @@ menu "Hisilicon SoC drivers" config KUNPENG_HCCS tristate "HCCS driver on Kunpeng SoC" depends on ACPI - depends on MAILBOX + depends on PCC depends on ARM64 || COMPILE_TEST help The Huawei Cache Coherence System (HCCS) is a multi-chip