From patchwork Thu Apr 4 10:07:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13617538 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BFB6CD1284 for ; Thu, 4 Apr 2024 10:08:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 27CAF11B338; Thu, 4 Apr 2024 10:08:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="tRRrRXuy"; dkim-atps=neutral Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78F0C11B32D for ; Thu, 4 Apr 2024 10:08:10 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-56e0e1d162bso725163a12.1 for ; Thu, 04 Apr 2024 03:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225289; x=1712830089; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Dp8USTzsG3ntp/LxWp9gHMeUcZJjL0z8l7/Rhp/dYWg=; b=tRRrRXuyTYoATrxWvu2M9J/av8KgVuLiIgd5lJrODLYBjhXaQ111HsV125XJwARKGy kbz5GJ7ChlM8N0BHvnXiAw3QfOGtPgnJE4uTtslYSCSgYhFsK6bWAO9rNqcTHy4UjZj4 AKxdCFGc3rhsdC2t+cLcM6Wh+o5lQVJhrDhvbpj4bJCcfRz4wgHM+Z6AZ1Z3h6RXzcCd vrCJxo83ON3PvWtgpzpAA06fP2le60zvgBpR5mQXZi2YznzsmKbWcu2QTxeYmJ0lezT5 d5668dSfKTLUOU61+fylqeMeSe+Y8M18Q2DrBM7wgHeE/61jveoFGEcx/tiZ2TUqZ61Q AJVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225289; x=1712830089; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dp8USTzsG3ntp/LxWp9gHMeUcZJjL0z8l7/Rhp/dYWg=; b=lYqn9uV/Sqsm7gvuijuVyaKbmDdrI8sVSRFUHzS5tXbLyO0mWME09VagEEQ0Wbpx1p PmNxoxnjPRY0Tg7FlLgHECMu1CczjD4LjFrL5LGFD8SlsWFS9NqSmma60E3Xws8jL6dF +KpeTl7U2z+/G5vpy9OvlEACSEky8X0VOLkHHx6inCYr2YGANt/0Wr1xIqsDEEnAMukX jZR6ENrLWBCrcMk7Wq6rwf3VgFsn+X37xJ48LPJbVCH6sIJxppwlzgy2XfQHHGaisXAO MkuX58lcB2y0DuANi/OKqVQEi3ZBKmJ7g7/0dbDCSHGNLShFLJKjfkQ8TySoR/XEZdKv ybCg== X-Gm-Message-State: AOJu0YwSUKMy0yPB0Un0zUTSxg52RtjB51LKk1L7aOkDB1OoYyjrXS/t yOdflBILXM7FAYqD6jTsBuaIWS8GxlML7jaRdmoEUBIhPQ4/KaZzmuDgAqbyh1A= X-Google-Smtp-Source: AGHT+IHpY7DJnbfRwrN+pggOgCfH6syNZv4JzFQ7NFRdr6EFSZOLNeW3eQkAhrKYCeBUc5BBBg2YBA== X-Received: by 2002:a50:d4de:0:b0:56e:df1:534a with SMTP id e30-20020a50d4de000000b0056e0df1534amr1014440edj.42.1712225288726; Thu, 04 Apr 2024 03:08:08 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:08 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:07:59 +0300 Subject: [PATCH 1/6] drm/panel: visionox-rm69299: don't unregister DSI device MIME-Version: 1.0 Message-Id: <20240404-drop-panel-unregister-v1-1-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=944; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=xtfhuUTM99xHxoMeoYk5bzlIduxzhp/GTlxP2mkYgaY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDnwFymsormB7E2rQzeFs0/IGcTvRxMiWf2O5A yUo7xUWQCKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZg58BQAKCRCLPIo+Aiko 1TgJB/4z75ZXyRi0GestVgdCyBjlrKyuTdUKv5EevhWnh+aLaSOFY5w85Ts/sc4S/+3rDxvdwU2 CkN/oVbiKN54mlfRaS7cm0j6/4ZpwgfPkr9H/WmkWaCG5eC8HSr4z3U46sxjNJdaj3FuUW8ouk5 h04EnLDzSFxa+NJdOnAoFE/qEWblFiPDpVFKpw/ml2sjTU1HUObnzOLZtarfPdKnp10mk7Xmgte pwYLYkrAbrUp0xySxMlW7cfEQS6poi0IhoOj0tt7YLGHJq5j5Cp7x/HwHMfaFAyrayEdvlIXJMT TQ2msvq1B4rSIXl5Ein9MwCCBaktTd8fYP5gAedMvW3SnueF X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The DSI device for the panel was registered by the DSI host, so it is an error to unregister it from the panel driver. Drop the call to mipi_dsi_device_unregister(). Fixes: c7f66d32dd43 ("drm/panel: add support for rm69299 visionox panel") Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c index 775144695283..b15ca56a09a7 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -253,8 +253,6 @@ static void visionox_rm69299_remove(struct mipi_dsi_device *dsi) struct visionox_rm69299 *ctx = mipi_dsi_get_drvdata(dsi); mipi_dsi_detach(ctx->dsi); - mipi_dsi_device_unregister(ctx->dsi); - drm_panel_remove(&ctx->panel); } From patchwork Thu Apr 4 10:08:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13617533 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A8A5CD1297 for ; Thu, 4 Apr 2024 10:08:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CCEBE11B32D; Thu, 4 Apr 2024 10:08:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="T4DFH1Ab"; dkim-atps=neutral Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7CD5511B32E for ; Thu, 4 Apr 2024 10:08:11 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a4e79d7d21dso52456466b.1 for ; Thu, 04 Apr 2024 03:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225290; x=1712830090; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DOrh7Irjq4f+bzjvRmtdFPtj9HsVRJ5Kf8V2j16C7zQ=; b=T4DFH1AbzP2/Sn7l59wUTSxqKY2DkLpmTb8STZ6lVMAziB30z2y4uwQ4zku2OopmG6 BX/oXHEsj9T/YsgHAJwAUYmifixoOGtk/N2NR+XbvNQx10xuLwPrkGilx6k8LW/1KFkz prAJyzudUOhis2WJifO9Ro1ja35YJdzbCYLQQjpCDqWdHoXzTLBNQamnAvqYJI95idzQ tDSxu8iPbhQYbvr69ENEOJvouJCd9YL+gMWbJEfOXYEnuQEnPVVWwqVrwLM2skMxt8TR Tn1jI1A1s/DrMtOyUBtj2TTiguQdgNUlaDlPJtahUlW4hQR6gm8jMUCG2CUZHfUM3dmx iFLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225290; x=1712830090; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DOrh7Irjq4f+bzjvRmtdFPtj9HsVRJ5Kf8V2j16C7zQ=; b=h9Cx63QX0lc+NtdrhuTtA7njs3qkezKrKaA6xN64faT+U1dKo4n2343W8LVlkMmCgf VprbzjkiQh5eIlFMyH+f4rqZba+oEPT5us53ODRx7qKIlSIpgUnh2BkBujg3m9kNf282 GXeWkbjVomiulJLseD/QyE3lLbUGGpJbYt7L/Roz4ULP1AkkYRsDdvMYf/pZZqu5IWuc RVk3fD0Fg66qBGl8GJzjHZEizcIybLyHkhxeULt5phsupDhPlNCcYF5qRrPVgFHNl8lH 7lbSZ7GzCPkC2DtJ+zBenfdfvSXCosfjTemNxgnvepdSLmNgGvUSblYTXxTAfPn+w33a 8SlQ== X-Gm-Message-State: AOJu0YznNPNQyq/SPRZzJygD8i8joiivRkGbuIYSKPy3oiNqswN09MGO sorExmKDsE0MF678IEJ/8e2Ffuzg63LeHmgj98WmqWxSNayiNNbG1iYSm/ZQfWg= X-Google-Smtp-Source: AGHT+IFFx0jNeXxS8p/PVfSfopzv8XenHyOICPv85lhOjQmeM3QgrFtbE28snmGj70mzNCw3CZotQw== X-Received: by 2002:a50:d596:0:b0:56e:a2f:34ef with SMTP id v22-20020a50d596000000b0056e0a2f34efmr1734540edi.11.1712225289818; Thu, 04 Apr 2024 03:08:09 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:09 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:08:00 +0300 Subject: [PATCH 2/6] drm/panel: novatek-nt36682e: don't unregister DSI device MIME-Version: 1.0 Message-Id: <20240404-drop-panel-unregister-v1-2-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=947; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=KIPxE7WAFkz5qGRN5hVp/Vx45cUpVvzgjI6wREzKChI=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQxpfDSv7hI3TUjp563fNvq67k9crjWPPPcY5oismPevXW RaeJfuvk9GYhYGRi0FWTJHFp6Blasym5LAPO6bWwwxiZQKZwsDFKQATyWNk/x9rm9pqXJBosO34 jqepk9az65ZM2LRfYa1kTVNiU8W7L1HNBzW/LgzWmLGnjj9pT2qX7c5gy28JfsKTpuzbt2iX6fE ziszrD9ybVLOTK6HEPl/JIndJSFbX/0Jpy0U/7zD9yVG0Ojv7VWNr6GZZHXOV1BeZs/8IOTbU3C +2EJrkLJ0q5Cha23P75ZErlv0+mlZZ9gL2v7fNnfy72UEmx7D23auIedxlIcz/d19X01FsmP03g 51JwLvQzf9LSWfLnMb9rjOSFlhL7TqUzNVTPkVHXuDXV8v+5JfK7YlJUWGtrZ2Z7TEy1cJHxRRs kler227qOfFAuEN3of7uTXOP8xYqtVX937MrZYLLhAIA X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The DSI device for the panel was registered by the DSI host, so it is an error to unregister it from the panel driver. Drop the call to mipi_dsi_device_unregister(). Fixes: ea4f9975625a ("drm/panel: Add support for Novatek NT36672E panel driver") Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-novatek-nt36672e.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c index cb7406d74466..c39fe0fc5d69 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c @@ -614,8 +614,6 @@ static void nt36672e_panel_remove(struct mipi_dsi_device *dsi) struct nt36672e_panel *ctx = mipi_dsi_get_drvdata(dsi); mipi_dsi_detach(ctx->dsi); - mipi_dsi_device_unregister(ctx->dsi); - drm_panel_remove(&ctx->panel); } From patchwork Thu Apr 4 10:08:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13617536 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40993CD1292 for ; Thu, 4 Apr 2024 10:08:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CF5D11B335; Thu, 4 Apr 2024 10:08:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="vhqeKXZG"; dkim-atps=neutral Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id EEBC211B331 for ; Thu, 4 Apr 2024 10:08:12 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-516bf5a145aso945834e87.1 for ; Thu, 04 Apr 2024 03:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225291; x=1712830091; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BdIQoQEcKOWWU/GbrzKgWkHTMEPIUceBmA7aLedovAc=; b=vhqeKXZG9xRrth5pPtknMFJphJ+5uVsxALCXVLR4tWafb4laPyVlOQWsCU8qQyT17F 7Ufpduh9LxO8O6G6eTfFpc9xqyHdI0MZ7vV/H/U44p0Rohj62QzqpeFYj+7aFR7vP7VF O3jUJ5Pa1/FzQXICyWdJpD4LhXXqzkVCJsHFIZFjxpG1KOsENQjKRygtfn8RiuZjlFl3 O5CZgGH9/3uavrherdvyYQ99QdsFbCJIiRL1tjZLsDyv+vLHDOdaD1d7eE80FM2Zvulr Z5aOsGfGgAZ7OlaoicExgFULiiR8c/0Kd3lHVCu88BtgiT/QfU9+HESZxA+D/mDkrtQJ fd6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225291; x=1712830091; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BdIQoQEcKOWWU/GbrzKgWkHTMEPIUceBmA7aLedovAc=; b=tKvK10u6BbFf4BcLojkjH/GZiNVn8kS/9Kr64Q8Cer58yRuT7yRBm+FP/c3cb2nkDu lhYJyCKIjX8APjNtkVSk6Zgs7udbMA+y7eO5IvGi3MRzEeRaNv7K37+Adj3Xiy5eW3sd RS7agVmv5pKXyZlBNln7nhRQ8PnGJGKJJi8JUkC9V59d9SiM+LQW1cs2DzzbSuQjhB0U 7Hn/sAyUDkVnRRQOuuXFIWr97x6INq3i3wdH/AUm7tEIM3ne/Fvi9HjCe79ifcRPhyMn 9JAHxOt2pRfLEZlgyA3yDyr57iXl94wXEtJA0tjK5nbncO53E1mLNpvYxUCF5GocagPN hldQ== X-Gm-Message-State: AOJu0Yz5GjsIwG6ux4caJxl6d/5+YGNLkEkzy8+KI7yI0el7lYzgAPw1 38J4F7UFr7lx843UcysK6BbQBO7rl8smJjIouYU9EfY0LXDYeO1LRZ6dldj9m8A= X-Google-Smtp-Source: AGHT+IGVlQ33RJEgohTvVD0EMCqh4p4Buhi5vVkciZI4lYNhGCrK13DBduxsmLyc55fg2pHBdTILcg== X-Received: by 2002:a19:644f:0:b0:516:bfd7:de92 with SMTP id b15-20020a19644f000000b00516bfd7de92mr1308662lfj.43.1712225290902; Thu, 04 Apr 2024 03:08:10 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:10 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:08:01 +0300 Subject: [PATCH 3/6] drm/panel: novatek-nt36672e: stop setting register load before disable MIME-Version: 1.0 Message-Id: <20240404-drop-panel-unregister-v1-3-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1555; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=rZ4pFCxBcKO4r0UopE2b8togAYR+akgCS3Rw6K0bDz4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDnwFAm7x8NXoFqiIBscoezOHH9QYMPEReQDM6 baVaKAbFWeJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZg58BQAKCRCLPIo+Aiko 1ZRhB/0Umx3VwSsiurPyTfgDRGxeKFo9jV4d99djRhqqhRRDIYlh8kwO4kA/En/A9IdV0bOtlR9 /tdlRL1lMwq5S/Z/XcOzVee8BHb9ffUqX1dOuUuTltDlMQWoOaDrLarzWzFAT31SxJPISPS2/Ba t7yEsKdIiV9/+9QaSvG35b8LNMeiCtyFsBkaNJrbiKOOTsCDquPJgIy9tVHDlHRtqbJ+8CBaexn QgKfxEqZCuj1lh7PHG2SoHaV1GeK0QD7pl6DA6kosRxf9TFkCE/IgmeNJdL3msAFWJcfb2mAwKv O7iqZ6oMAWOYwSEiq6XRjNpjv5vzQFFlPs194hg5J4rHFlyG X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It is pointless to set register load before disabling the register. This vote is going to be dropped as soon as the register is disabled. Drop these register_set_load calls. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-novatek-nt36672e.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c index c39fe0fc5d69..9a870b9b6765 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c @@ -25,12 +25,6 @@ static const unsigned long regulator_enable_loads[] = { 100000, }; -static const unsigned long regulator_disable_loads[] = { - 80, - 100, - 100, -}; - struct panel_desc { const struct drm_display_mode *display_mode; u32 width_mm; @@ -385,20 +379,9 @@ static int nt36672e_power_off(struct nt36672e_panel *ctx) { struct mipi_dsi_device *dsi = ctx->dsi; int ret = 0; - int i; gpiod_set_value(ctx->reset_gpio, 0); - for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) { - ret = regulator_set_load(ctx->supplies[i].consumer, - regulator_disable_loads[i]); - if (ret) { - dev_err(&dsi->dev, "regulator set load failed for supply %s: %d\n", - ctx->supplies[i].supply, ret); - return ret; - } - } - ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); if (ret) dev_err(&dsi->dev, "regulator bulk disable failed: %d\n", ret); From patchwork Thu Apr 4 10:08:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13617535 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66B72CD1297 for ; Thu, 4 Apr 2024 10:08:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD0FD11B331; Thu, 4 Apr 2024 10:08:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="KIHQWXdz"; dkim-atps=neutral Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0401611B333 for ; Thu, 4 Apr 2024 10:08:13 +0000 (UTC) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-56e1e6e1d01so567297a12.1 for ; Thu, 04 Apr 2024 03:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225292; x=1712830092; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3iEJ/RqQGEQXC2ep2uq6icF6qECUCl++i3ec6IEoffE=; b=KIHQWXdzAm/oTpuOvjHnuNOMO771tey3pGskrjXAaZH39hO3j1nwNyTVrn+aPtHELy +WxSnu8/3Aa1hTiQRxVy+rLazP8LWb3pNngT0G6+pBBmFbjI+eYJ2KBd6kr0FbDNNfA5 Z40vNp0RB6Ib/KozUm0/Qn6np2LksLVEncTHmVgOHgVPW66/fNJ3yvoLTbkRz1OewfXU siqZFvs8cj6hqs33BRfgSwE0wyzVJXYY/ukwkoAbJI+HKd3Yd9fES5lt7QibMzmLSP7V mG+g6TTy0V3taD2f8INr4XyOpwxznOseUE4Sj5/fvmwxM/zkQTZ4rpwcr7g6Q8vUYkRy Xnqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225292; x=1712830092; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3iEJ/RqQGEQXC2ep2uq6icF6qECUCl++i3ec6IEoffE=; b=OpQYohaPPZPE042bq2FUSg37EF0y4TVit1FUU5wuxZop7rJL3lOgc5v4FlGEE+WPJL iEop2NgjYUWDT17cxpNgunKlJBE4bHrf6l3xYd5lvPexG4Fk5cfrCtuiwBggWg6CIHU/ eBsaCVPrN8xU6souZ5LUEBJb4k7Ju3bHpi8GKyc/u07TMCfYi8zx09gJ+gOgmJOgXibH qnUKbFwluEYI6yXZv9ei1NGmJ5y7jmuXZlDVRg7oixJ9zx+sUc8+lgeJueyO5c5+nIbi 2NS7uAQHuNAzVwJFL38+dgAIF9zAa9Ht9Ry0Prcu8XgmTeQRM0IqBmpKbjE+zwx71aNz 4zjg== X-Gm-Message-State: AOJu0YxGousoteMK0tNv8nuclaQ5oHpwRQvl4B2QjmWVo0IwvtgF+533 7uc0pBv0y/4Tl2Dy2oy+1dP+RoALmFrTCIgdhn7po9jYsuNixSEjyyyWdM7uwlk= X-Google-Smtp-Source: AGHT+IE7uZg+Q8MxKj9wP0qIcOCX5VGa3Rs8Ms9OK8oC2SCWf7JhMx8FjKV08qwBA1+QirOE+lHo/Q== X-Received: by 2002:a50:9f22:0:b0:56b:a077:2eee with SMTP id b31-20020a509f22000000b0056ba0772eeemr1463352edf.4.1712225292236; Thu, 04 Apr 2024 03:08:12 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:11 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:08:02 +0300 Subject: [PATCH 4/6] drm/panel: novatek-nt36672e: stop calling regulator_set_load manually MIME-Version: 1.0 Message-Id: <20240404-drop-panel-unregister-v1-4-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1608; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=H9DTnvxOhLAsFMR7/zYzkTplDuaaTlPMoOsjC54VSys=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDnwGOSkOIwSEiA9PVDGHOoidJ+W9OPRJ8acpz nzm2l9u+zqJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZg58BgAKCRCLPIo+Aiko 1WMWB/96tYjo2hhtiGxIK0g/c0rr8Y2g8PIUfBaRQ5yKZE6bHjOHd5kpM6RTO95gR5cX2m37Vdz UdtHFCsw0p0GHa7VQMeJHwwmYGlyq5kRRXYAJWN/xffSJZXSFHO/7jf3lt6u+zTKuIjEdWP00GK 65z43VET+dmpitof8CNOty04Q0GD46F76Zivvy9YjMyNO3nH+EThYsPB92alpFXLqdZvkt7G3Ih IuydjRCHtNDxoaamGsLDzUPVrBVVmAEWWT2+dntfqtcB17zyb98nVkcdXqTpX6BDWWMuCqgzjbM YNdfJaHSbeOUe324ctffoZk9jtJan5O0VkntBwKi++N0l0Tg X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use .init_load_uA part of the bulk regulator API instead of calling register_set_load() manually. Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-novatek-nt36672e.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c index 9a870b9b6765..20b7bfe4aa12 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c @@ -343,17 +343,7 @@ static int nt36672e_1080x2408_60hz_init(struct mipi_dsi_device *dsi) static int nt36672e_power_on(struct nt36672e_panel *ctx) { struct mipi_dsi_device *dsi = ctx->dsi; - int ret, i; - - for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) { - ret = regulator_set_load(ctx->supplies[i].consumer, - regulator_enable_loads[i]); - if (ret) { - dev_err(&dsi->dev, "regulator set load failed for supply %s: %d\n", - ctx->supplies[i].supply, ret); - return ret; - } - } + int ret; ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); if (ret < 0) { @@ -550,8 +540,10 @@ static int nt36672e_panel_probe(struct mipi_dsi_device *dsi) return -ENODEV; } - for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) + for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) { ctx->supplies[i].supply = regulator_names[i]; + ctx->supplies[i].init_load_uA = regulator_enable_loads[i]; + } ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), ctx->supplies); From patchwork Thu Apr 4 10:08:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13617534 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65DAECD1292 for ; Thu, 4 Apr 2024 10:08:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6357511B32E; Thu, 4 Apr 2024 10:08:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="CUVl/Zv6"; dkim-atps=neutral Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81F1B11B334 for ; Thu, 4 Apr 2024 10:08:15 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a46de423039so50398466b.0 for ; Thu, 04 Apr 2024 03:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225294; x=1712830094; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PPN+AHE8y2MkIJuM9pYz2Ll5VT40Ao0mKYYFM9ZEDlc=; b=CUVl/Zv6e2MuCwH5qj5bap2522VJWt8ZxxL0zVqlLTaW7dlsZVovc9Kz8MhBz76N3Z KAOT6xpT8OohT4c29+rbqW1CtTRb2T+TCLqd/iseytOaKEc4x/XGWLSO42rrGe6tdjFl xN0wk5cYjT2wJKqVFWBgDjX+hnFkmaFD2R//duKwvlOBBmU+FZuLJPJOq3nAnLq5Y4b8 kpKPKr2/sP7dAJur5/l2ea6xRnIaBEt04ZZaEc5kVsuFnyLO9PFdVXYZOdL223LCSoBT ABKUD54ToW8CNgTlEgKvH8dsF1mxwuILpIfbsxga5Ehotl0aqeS0BD92Fr2FVMNGfRr9 nc1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225294; x=1712830094; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PPN+AHE8y2MkIJuM9pYz2Ll5VT40Ao0mKYYFM9ZEDlc=; b=v8Ukky5TW8eUrbAu2pGk18jvTVB5lf4+3wW+dbbtdwcmqXGUMe7r8Y3G/QlOKwYbaR X+6fQUSVddkSq9/f6EqyohzJzPUmVYRW1J+qKHG6WAGDqVvADPiXryxTVtuhd65FCegm NmI9Oj5nyBWyEA3n1B9649GkuthFYPe73C26nDZl72Z4ov6naFLN8RucIbTN6stfx2Wd JMXE4gK9VYtwgCtQLWhkNQ+zK1hOr/Swcc+phM8551dYIOgf1Valh6XcT6MMrPr8oAok bBtsLAHq7pHcnq8TP9F5L46d70VrMUyG6kSkERLQ4lvwijFhkhQbDdKVfUJYDlN+eaJT teZQ== X-Gm-Message-State: AOJu0YyH1BtD4ade2D9NOkDYCZ4k6Cy+EdtYfiEO7PJ0vQ4YxK4Ilb06 w06ocVLGiqRXP7XwdQVjz9GNsOIuKfgryXd9TUPvfigDNqqt7JRhEVk/iS5Fo4U= X-Google-Smtp-Source: AGHT+IG+bzEJEONgFdA3wAMbc5bzkjLYvW9jbIlri8O2GdxrDMhypvw8vGmRretwMNzBqrsEp+LLtw== X-Received: by 2002:a50:9516:0:b0:56d:eb22:eaf2 with SMTP id u22-20020a509516000000b0056deb22eaf2mr1641222eda.21.1712225293709; Thu, 04 Apr 2024 03:08:13 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:13 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:08:03 +0300 Subject: [PATCH 5/6] drm/panel: novatek-nt36672a: stop calling regulator_set_load manually MIME-Version: 1.0 Message-Id: <20240404-drop-panel-unregister-v1-5-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1557; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=eCcqI9AuK/Z4GvlfkxunJCyaNrb4UqWmCkVQLFSw/nQ=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDnwGnnj+WYVJzPKl/9S+XC8FxF5CW7r/Do0cf 314BZ0pIASJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZg58BgAKCRCLPIo+Aiko 1VZVB/4z5IlE0BLotgSxrMP0zTg3pTxhrC760H1bsEoAEATmeiT5vkTHU3LD95tNz3V8GnPGFDF YrGEzRLYnT0SOGtCu8HEXePqHwzQJyr1Wo900PMx/JZj56s91T5ya+wqhW4mZwda5H0yQVU2rk8 l92jyhHDAuFtuL6Ey9S5DIR4w8zhC2C6GM/Pv6YBXS80WgqFUHMgjjzF3NM5FJCpxqgut29qpSs svgtDFYO5QNcRXro8ChmX0QRZNzX/tFAzKqf/kZtc5UEimqhbnM2eiQfdB8Os08R1FUioTI20em +CHMaTUzjjXXAjk+1ZwVOZizCsXDwF1x6pCj62qPSYbSBfFb X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use .init_load_uA part of the bulk regulator API instead of calling register_set_load() manually. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c index 33fb3d715e54..3886372415c2 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c @@ -605,21 +605,16 @@ static int nt36672a_panel_add(struct nt36672a_panel *pinfo) struct device *dev = &pinfo->link->dev; int i, ret; - for (i = 0; i < ARRAY_SIZE(pinfo->supplies); i++) + for (i = 0; i < ARRAY_SIZE(pinfo->supplies); i++) { pinfo->supplies[i].supply = nt36672a_regulator_names[i]; + pinfo->supplies[i].init_load_uA = nt36672a_regulator_enable_loads[i]; + } ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(pinfo->supplies), pinfo->supplies); if (ret < 0) return dev_err_probe(dev, ret, "failed to get regulators\n"); - for (i = 0; i < ARRAY_SIZE(pinfo->supplies); i++) { - ret = regulator_set_load(pinfo->supplies[i].consumer, - nt36672a_regulator_enable_loads[i]); - if (ret) - return dev_err_probe(dev, ret, "failed to set regulator enable loads\n"); - } - pinfo->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(pinfo->reset_gpio)) return dev_err_probe(dev, PTR_ERR(pinfo->reset_gpio), From patchwork Thu Apr 4 10:08:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13617537 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B575CCD1284 for ; Thu, 4 Apr 2024 10:08:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0996811B334; Thu, 4 Apr 2024 10:08:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="dxHZGcZa"; dkim-atps=neutral Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E04311B335 for ; Thu, 4 Apr 2024 10:08:16 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-56845954ffeso1308654a12.2 for ; Thu, 04 Apr 2024 03:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225295; x=1712830095; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9gdreFmOsn9hnQ9/3et99EfVumTY2yhwD/QDrRRb3VQ=; b=dxHZGcZaDupKsMFjm2rnrtoiNjfPVTES7uXBigKtLxRVx//wIyiU0LozMyM40tglNO S0i2BcJuUu1lrt4TPZKdwR+Oym+irGL+HJmcaUzQSOcHwqAQ6oy9UTpTWuQjEDZPhnwj svV+NWsTBdeo2QkmSv8GOZdptMA0Jpns0LI9M1YRScLs+jJUxyw8c4OAFQ0w9iDNJ1ck neWYvnil58O8gWr6MXRfdc9e/3sgr82eFNOw1gZ8QGbZq0q5JGgw2UUAfnbGCVCGHmtB 453Tp1w5xqfYb1L9hpYV+BgtutOTyMonBEqKB2+O/fdyk7bICHtUk73Co6K397saMT0f vTNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225295; x=1712830095; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9gdreFmOsn9hnQ9/3et99EfVumTY2yhwD/QDrRRb3VQ=; b=hO/tWET1d9x18s8PEQhi1iYSXayIUByX0gHBMHp7R7shi2rMzcLTLKwnMs2/SVyP0d wWRv4NyjoU2gVFmCSkiTgMm/qIX0Z05YgHzbcHXZFzxNuEKPZ6bsBtlbQHvwzJ0TDvg0 uZI3NJYmJDcTAg+Wb1nHTeQO+pyX00OpwNQk+TPCFQ3+EtgGxNibIqhxAEAK42sh1yiZ uEuLkLC1EQFkRADz+5n/Gase3tZolY6fielM835momaMnSvDcAZY6UZ/wWQshfBGDdHz JowpJ8g+Q6tSakCI39ZmuC9ixfuhK7o4ibWKHW30drw/U0/LRZfP95xzZ98eh9atiNvE kjYg== X-Gm-Message-State: AOJu0YzVtdENs2FZYAA1jpZ1Tu5oqdjOqayL6ccyrdBmD78h8dMA7QcU yPkEKAT0NIYLTwsE5hmGqA/KEiHuH2Y4M0p4RDhGN70li2kCKzMyqL2X9NyXXiI= X-Google-Smtp-Source: AGHT+IG6MIBoUnhn5kD8YkyWDaqubmu5zZw/UDEyEutc/LQNpwjh73npo2Rh0hXKgklGbZY1tDHrxg== X-Received: by 2002:a50:999a:0:b0:568:b622:f225 with SMTP id m26-20020a50999a000000b00568b622f225mr1367415edb.30.1712225294754; Thu, 04 Apr 2024 03:08:14 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:14 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:08:04 +0300 Subject: [PATCH 6/6] drm/panel: visionox-rm69299: stop calling regulator_set_load manually MIME-Version: 1.0 Message-Id: <20240404-drop-panel-unregister-v1-6-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1559; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=irilOr1F66J72zSf/iZ/FxY1c7hsuCBIEPtG00CVG8k=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDnwGO0eQ0yN5Gyv9QpomFj0R6gyXZ+5rtNEtm IGQoU0uAEaJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZg58BgAKCRCLPIo+Aiko 1WYFCACn5db1y7XDZnwi8s8NKNDV0h88BTcuOpypH5tfLwAH0CVs/5d5b23X+DvXMpORhQEi1jY Dlh/F0h8AceX/ZhR04srs58R1l1cV18WdVKPKoWheb7OstyQjJweYXovPKwMHJ9oAgyIVfGWA2b ZkPVfk1YaWtNi7jLO44GU7J7TOMbi9Y6tHvkxgEb7LpRXi6KzxA5Vxn/hlitMipltv3Th8rHBbU k6h0ttkCAmQbWlJKlqYqcNOE615htx4ndaJ81GMF6rJ4I8/2/oiVwmjy5y3aLOLWsJ0Iurs02L+ MwsKQn0YXCDkU5gtyKKVeeXSmjgnvndGlJJ+gU7szKQ6+s6Q X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use .init_load_uA part of the bulk regulator API instead of calling register_set_load() manually. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c index b15ca56a09a7..272490b9565b 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -197,7 +197,9 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi) ctx->dsi = dsi; ctx->supplies[0].supply = "vdda"; + ctx->supplies[0].init_load_uA = 32000; ctx->supplies[1].supply = "vdd3p3"; + ctx->supplies[1].init_load_uA = 13200; ret = devm_regulator_bulk_get(ctx->panel.dev, ARRAY_SIZE(ctx->supplies), ctx->supplies); @@ -227,22 +229,8 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi) goto err_dsi_attach; } - ret = regulator_set_load(ctx->supplies[0].consumer, 32000); - if (ret) { - dev_err(dev, "regulator set load failed for vdda supply ret = %d\n", ret); - goto err_set_load; - } - - ret = regulator_set_load(ctx->supplies[1].consumer, 13200); - if (ret) { - dev_err(dev, "regulator set load failed for vdd3p3 supply ret = %d\n", ret); - goto err_set_load; - } - return 0; -err_set_load: - mipi_dsi_detach(dsi); err_dsi_attach: drm_panel_remove(&ctx->panel); return ret;