From patchwork Thu Apr 4 16:14:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Usama Anjum X-Patchwork-Id: 13618039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF818CD1292 for ; Thu, 4 Apr 2024 16:14:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D4B26B008C; Thu, 4 Apr 2024 12:14:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3878C6B009E; Thu, 4 Apr 2024 12:14:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 227E96B0099; Thu, 4 Apr 2024 12:14:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 039A96B009E for ; Thu, 4 Apr 2024 12:14:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A86A8804D5 for ; Thu, 4 Apr 2024 16:14:16 +0000 (UTC) X-FDA: 81972346512.07.0AFF5F2 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf25.hostedemail.com (Postfix) with ESMTP id 042F9A0027 for ; Thu, 4 Apr 2024 16:14:14 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Ge1bY6gJ; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf25.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712247255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rYfcPB4AxSG0Elguh372X9YReOtOGGmex5J7vbKWRPs=; b=4pIHLJ3ATuJjuASjbXIXjCdJSHybh17J3VMs2gtutgZbIixYifSFG0Dc9vlzStuNvl4aTl BiJpWRA/Fghi9JzDQZHR/DYFApnCZgS1g70+QYKG+l8KvzsoMeyiUlTbMopz7Al6IvDikf JNn2+6YkPK9ygUYVwAmAoKBpk33HcEQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Ge1bY6gJ; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf25.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712247255; a=rsa-sha256; cv=none; b=MVBB5QWR5DRkhBOKdLjN1lBVFRoAp932K6lg4NHcqmBObj07oO1bPE8OAXD/VahJlVDgha JXDWUQyqNYaqFGMNs1TGlLsnsvNryz5o4tC+p1itFkRHFjb16OgA9LPs1vgtXCxJ3Vyqe/ oeAW4+dD/nmkbbAC4s9hPRYNGOwcWXE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1712247253; bh=boDL5nHOi6Lw/iE+qqB7X+GYBlXdpClEfHq4s6TIuWo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ge1bY6gJXP/VQg+cVNTG6HkpGguexAj/rR7+IrElRFFuC6JIWVk2BTA+MEQ/wtY8V qtyRZ8S2iIl+4J/4u4qMxUWf2k3VRpdg6ktbBjv3mBfE0p0Ynzlf4Wsw4OhHI7bDIW D4SvB2DcTayeOHd9wgGb13zqts5ZlfpBArMT6h72PANYY9Uigq2GeTA5eaJcAQ2URx 9u68VpEuWE4sbNOCOOo3ZzOZRIn7FyPZ1gWMeg0Ldd5XHiu2HzV0gq0XffLOirrdDk NuBVPhqxowuMVTRZ+YfFiXoWFsyMQHmBKAsHWhwKic+f6mFBgYehR/Ht7THAxSPg+D GEv+GZ8oU8NEA== Received: from localhost.localdomain (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 50B4F3782129; Thu, 4 Apr 2024 16:14:08 +0000 (UTC) From: Muhammad Usama Anjum To: Eric Biederman , Kees Cook , Shuah Khan , Muhammad Usama Anjum , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel@collabora.com Subject: [PATCH 1/2] selftests: add ksft_exit_fail_perror() Date: Thu, 4 Apr 2024 21:14:32 +0500 Message-Id: <20240404161433.114497-2-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240404161433.114497-1-usama.anjum@collabora.com> References: <20240404161433.114497-1-usama.anjum@collabora.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 042F9A0027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: to1mb3nn7ao3wgnh3p9fd9otj1c65ike X-HE-Tag: 1712247254-661695 X-HE-Meta: U2FsdGVkX18xT4ene89Drw6cLF2YQPhazcoeFvw/Jm0aBqoQjgzSCAMdjPQ4sfWqhunTd+qHkQhrdlObK3FId8K+X6IKp9epu4gzrN/F178bGaVaiW9nVlTwqxWl9IhlQ1BQk6WHbLvIwP//MZ0UrfYADxSnA2q89O1C+sNO4WRcmzAOZcW7rof6GMft0RSMNO3yaH8am/diBLmgHbIwTYiymkfevjD+NFGOqg9Wksdffhe40WKPVSW0Dw4m490XBea6Azrv/xs2DNc0rGuJDATVajGO8RZj4BalbdrQWjkT2RxvCZsNJLMIXYaS+jQTbB6gwzZiIXCzf2YIr8BgfI+NrkBaQkh/NejsHkyNwQUZZ3vaO8nSebarsqToGtl5Prh5JKY5Su6gdTnoE/dI6cTbMT2RSCbUolqJ1mDOtTi3D9GU3QZc11+2PHCYGmTAulE53ONBYGxy23j6WZuXYXBvoVPNYbdc9WaoOeNYY31rCL+lj2GCm8wph6QsiA/ZolD/WJv0C8wMtaK2kBbOhdl1bXnqSV5BIXncuQf9MoOVR0V5tDUdUhCZZeb1mgeZb3Tvb1hGxazuCgXQMjGY0iR6NUVacRl13zOV4EDXFM6NWjdiyzwy/kOduhMCvaPzfFU7DG252YRWYUUmR4Tb61zNtrz/sLhld4xuYiKyhoITGblGSJBq8GDhlZG2mlLGTPdsQKoohprwvFm6jmyzql3snwSWvhSUZOv5PNVQ/j0BdIGb65Tt7Kt3iELyZSBgtWfgbangrBCFBO/D9LiKld1xLF3jZQ/PdOJTIudTkyIfMng2Vim+uDII5qdNQbTLx1FjYSoyseUtzAbfZGWnUOVXhmefZWtlNiv7iq//fNCznBbkeQcgK6/HVCO8r4g6QAcq2Q5B+ZpgqFvhT+O6NS2fgLwGffrfcXB9+hhjbaisKOTYx/8kChDTG2PnSi/EmYh7g3sY+lBpBtjG6cA m8I36dYD f+WUKsKrNkJ7xE+8MI7Dv9Q4w3w+tlV3jBLTkW7N7BDQBw8e9xhx2wAG83EpmWF1DQg8ZVZS3y527jac2FDvMq2C83v+lqytnXJUFliyHgiZhABAnnkS0kj84ORYNOtXJcnxvZV6tPEFDX0RaHz4a1sRXN6RQmDX+4mTeLRYrhjU6RGMXcm4wfGymnPvQUnh45wSixwVFAdrL/48DaFyhxYoaqEkGzoSQ480eoBFEUrUzu5hH5B3Vw4vPy0ikZS/2MQ021z7IpgNEEo/3UjcqeCWMJXDCx7qRQL69tMKi/f1WfyY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add a version of ksft_exit_fail_msg() which prints the errno and its string form with ease. There is no benefit of exit message without errno. Whenever some error occurs, instead of printing errno manually, this function would be very helpful. In the next TAP ports or new tests, this function will be used instead of ksft_exit_fail_msg() as it prints errno. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/kselftest.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h index 159bf8e314fa3..2cd93d220f434 100644 --- a/tools/testing/selftests/kselftest.h +++ b/tools/testing/selftests/kselftest.h @@ -41,6 +41,7 @@ * the program is aborting before finishing all tests): * * ksft_exit_fail_msg(fmt, ...); + * ksft_exit_fail_perror(msg); * */ #ifndef __KSELFTEST_H @@ -370,6 +371,19 @@ static inline __printf(1, 2) int ksft_exit_fail_msg(const char *msg, ...) exit(KSFT_FAIL); } +static inline void ksft_exit_fail_perror(const char *msg) +{ +#ifndef NOLIBC + ksft_exit_fail_msg("%s: %s (%d)\n", msg, strerror(errno), errno); +#else + /* + * nolibc doesn't provide strerror() and it seems + * inappropriate to add one, just print the errno. + */ + ksft_exit_fail_msg("%s: %d)\n", msg, errno); +#endif +} + static inline int ksft_exit_xfail(void) { ksft_print_cnts(); From patchwork Thu Apr 4 16:14:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Usama Anjum X-Patchwork-Id: 13618040 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4C02CD1292 for ; Thu, 4 Apr 2024 16:14:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4740F6B00A2; Thu, 4 Apr 2024 12:14:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 422086B00A3; Thu, 4 Apr 2024 12:14:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29BBC6B00A4; Thu, 4 Apr 2024 12:14:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0BA986B00A2 for ; Thu, 4 Apr 2024 12:14:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 96B5AC0523 for ; Thu, 4 Apr 2024 16:14:21 +0000 (UTC) X-FDA: 81972346722.01.4493767 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf06.hostedemail.com (Postfix) with ESMTP id E6B2C180016 for ; Thu, 4 Apr 2024 16:14:19 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=fRx2C0Ai; spf=pass (imf06.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712247260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m56r0GSROYrACguTsmxOrhJF5RdeE/vmtoJTbm7JVvQ=; b=SD6hvLKaWwrf59YvA8Y8H7IGTtjH124E9wYEgrHKqaVS/EDimQcKACyOdLzsCUAFC7/hM0 TgamSStOPomJuZh/SMPXtoJ7COQhCkglOE7DaNutkSHr9nkW1OAeLATytWCgbsUXFDw9OC js/UJCRuENP54seVW+8qRqQJuSBeanU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=fRx2C0Ai; spf=pass (imf06.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712247260; a=rsa-sha256; cv=none; b=wKcIj61D8U783ICFjZgKJNuNiDFi+GuG+G3FrHLNZnnE77Uj9t2/KjSrk81LcHu+bZ8+8W GTOzBjUVxvwwFT2maO9Qli64IZ3RidRz3aQvEr3uZfzY0G64+hiHDtnnmNKF4AdPsLUy/2 T9zS3cKGOoRxHaFDVYSv1vWp5ZqZhxs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1712247258; bh=ldtvjkAh4uiGxCheNFBwI4fa4kaJRENVGkoL+ZPIS0g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fRx2C0AiLQ4G1u6VFtu1nRt8ktODQ2HPoOEC4eASfbnsv3kNtEnb3RqER3Y2wbRY9 d/pJoQRl2pj7+q7DT0patY2f1zEPrCtrwOUGfyEg+1Y9GoFWQMUusXNax/Kl1k9DY1 73JunOQKqEIxh0+00nwpZp9kupfykapjNm13AahJ2r9U2cuRX5xsRw9syYMPjG5lR1 JnvrI/7rMjOBLXXhKhsNJ9b2Be3kKxApdA/+kWDhXAzANyGnmiGUzjGpQ0M/2GT64W SpEU9pSg90tT9ET8Bb0UgJvlZbj/k0v0OPetMnblBZWVFmWXQfOqKLD2YM0CZcB08/ VqJE/TPfcDIEA== Received: from localhost.localdomain (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id B8A7B378212B; Thu, 4 Apr 2024 16:14:14 +0000 (UTC) From: Muhammad Usama Anjum To: Eric Biederman , Kees Cook , Shuah Khan , Muhammad Usama Anjum , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel@collabora.com Subject: [PATCH 2/2] selftests: exec: Use new ksft_exit_fail_perror() helper Date: Thu, 4 Apr 2024 21:14:33 +0500 Message-Id: <20240404161433.114497-3-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240404161433.114497-1-usama.anjum@collabora.com> References: <20240404161433.114497-1-usama.anjum@collabora.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: E6B2C180016 X-Rspam-User: X-Stat-Signature: kwqyo7f58junf4p586rbamf8xeygfrix X-Rspamd-Server: rspam01 X-HE-Tag: 1712247259-467999 X-HE-Meta: U2FsdGVkX18esvnoN1PpCEPPRe2xWTBJ5DEE+flR5cZXyJjRpAzAif7oc/x+WLd9f1Hs0ifTmXk92SDQ/xhBONI4gtT/zXJAtM548qSDvx7yxGnd4MRKQ1jEklHY5vu1EP7PSyaaMY9PrBHwWdzq5lQY9RB+5d8SWrrVEz+WYOrLH8GLJwy3dTFZJAcneqjQaUU4vLmc5N6ADWvcX5keO7ryxMe0Na2yRcspqrlNpueScEXQUfLYCidE/yalks01kl7nJHmqWrc4yY73z51AiH1JRLkYgbdDFZRnnoi9d7Va37FnbpNz60uebiHM8a1q56uEkj3+RcoGISGbBZ0ylojLZpurI1/VDcpD5i5gCO1GVautZVWLwsHE+xjZLP/lpGDP9dC6h7B+Fv7boidneO0IT4v+fAg+nhOK3tpl9Qs8qVxSdosimvK9qD7C2SucI9llk9jceCs7uQsxxCbJOlG/p4hkXSIy+hmdOymMsA9KOFd+MYQT1pqPbSaKZ6Wje1mppRMnhzSEoJ55ZNhHWXG9IM+p/lTXO7VJfX3oa1srqfCx4oDuG7BUxOZDvUYQ95pTkHW9IzpaTFtMyXMbkZobCpW0r06ineHO7YfV8FmA0kOz9JZfKPfInUoEZQam28CxWaLwC1LULPyci7IGEceRT2EUCfW+wxXzjXvo9dS4FNViY6G8qZRoa9IoL86Gs9hVLQuYfP1CQH92SA/HOHWvNP95wE/IGh/+GB8b/sMvv2m10gm3caCTxYOl0wSXTY/EAKbg2g9/HeG2/EogzbNhTbUOMPlFNLGMY4k9132XaeY8heHCEtY5zUmY3gOeBfzz+Ic7qDFVNDgQwFz87EwOzQgHT8xV65YI+DpreJZmNJ32pJsaeOD6w0k9IEQSfr4pD1zSp7nSPeCK9Hvlt2VfZhmO6gulsDwmp6K5mdTVi8f0iL1+r3+/9Um85KXEUEQb2l+uRuW9TvezSPA QqKykkp5 MIhuRlQ7bKqpJh3M0n+02ueUJNBkP/DOhZvmbX0j9jM3q+/f761oKKx5IqtEFEXAh2IxIKJPG+/B9Ux8lfCatvK3tgIInYcKnbSYo90/kKkzJuSAUDLg4hkUB3JFRi7Rw6nj2yyt63Q4wpuL55POlqQveF9ReUdKGQBPN2OUB1sNN1ZYv8noRsYBty6SfrFUFY3NYotbaPUzLGztoN55JC1fP/KSd81KTgYD4GCXkLVTjNFrDhTi66XUh9V32CQj8KfkoMPD8YhpBF4W0sbR6J4YJC1rmClrCvWilPplIQlE7GGA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use ksft_exit_fail_perror() to print the value of errno and its string form. This is the first user of the ksft_exit_fail_perror() and proves the usefulness of this API. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/exec/recursion-depth.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/exec/recursion-depth.c b/tools/testing/selftests/exec/recursion-depth.c index b2f37d86a5f62..438c8ff2fd260 100644 --- a/tools/testing/selftests/exec/recursion-depth.c +++ b/tools/testing/selftests/exec/recursion-depth.c @@ -37,25 +37,25 @@ int main(void) ksft_test_result_skip("error: unshare, errno %d\n", errno); ksft_finished(); } - ksft_exit_fail_msg("error: unshare, errno %d\n", errno); + ksft_exit_fail_perror("error: unshare"); } if (mount(NULL, "/", NULL, MS_PRIVATE | MS_REC, NULL) == -1) - ksft_exit_fail_msg("error: mount '/', errno %d\n", errno); + ksft_exit_fail_perror("error: mount '/'"); /* Require "exec" filesystem. */ if (mount(NULL, "/tmp", "ramfs", 0, NULL) == -1) - ksft_exit_fail_msg("error: mount ramfs, errno %d\n", errno); + ksft_exit_fail_perror("error: mount ramfs"); #define FILENAME "/tmp/1" fd = creat(FILENAME, 0700); if (fd == -1) - ksft_exit_fail_msg("error: creat, errno %d\n", errno); + ksft_exit_fail_perror("error: creat"); #define S "#!" FILENAME "\n" if (write(fd, S, strlen(S)) != strlen(S)) - ksft_exit_fail_msg("error: write, errno %d\n", errno); + ksft_exit_fail_perror("error: write"); close(fd);