From patchwork Fri Apr 5 01:59:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13618354 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18463CD1292 for ; Fri, 5 Apr 2024 01:51:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=tOafxq2pcJxBKhqf/S3S3gPGC2+bN17DMqGq3iQQm3A=; b=MjwI7RTeROrwq9IT/o+GS9kIuI Mv261N+04GWo/7xVwGJDpyi21st6JtV5SCVdSN6PKJj09AAWO5ux+2hW13G2Y428v0hYqifyeMbuF X0QNHfeCDcJ1atY45xJOXlQDuZyg1TJZplQVQCq4ok7tW37xxi2n+hMfXeN0exT6eyjMUxgk6FCtx L3m75CjhDNCNbfcVVgw0eHE1U3ll798g5YBIaG8R5KHZ+xWC/9wS1EkRRxe791PUoqnPeBqRHgkkO f9QTddbhsKZSX1i6t1x4/gI4ITMlpwDgNRTErq/fjwQvVcqJMPXgeLP5XPp7TK9uZV66a0v3bESeK QAABpr6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsYk6-00000004qdW-2v53; Fri, 05 Apr 2024 01:51:46 +0000 Received: from mail-am0eur02on20700.outbound.protection.outlook.com ([2a01:111:f403:2606::700] helo=EUR02-AM0-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsYk1-00000004qar-48wa for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2024 01:51:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m3KKLuBU/RaM3j1zf9hUhmTnMcx8+fTiOr7CJv17Aj+SbG1Cu4XmhUKCBCwi9VNDCMneLPjZZPHHoSEFBthrMncClJuPJXxoEBaYriw8yv5lj580uZYDCXPIyUOHBM6Tdg3kiybBeEFrznFsSpblqmpFSoIVSCU7U9itBsHmeBjSJCBN77E08+OcMPjFcE3bPTomjN1HIdPHN5lgVS5UIvpmmpp1joro7PnwjawdTkedGlAi47nJtXLzKf+GKmoCIdnMpfEMfPB4CzJlqro9JDiLMOcmhYxAOpnvWkQJO8zVxKQ2JWDKR+ZIOWny1FsXWl7Utk8lyyhl9BdFGBpLcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DkhFzy347CReKh8Y/3De5x5m9e7u839I/9k6SdaIf8U=; b=WmN3efy4xMIp/fUeGsA5R+g+i9NLUl3pXL3Zchy6s7WEFNc5y86I1IAxm2xWHH8VxQBvqaKNtjss+t46HSCL4w/EebHzCXds0F9j+Fmrfjl/jNR6QpmKwRqdghAISpDJ7HRFDi9+wXtAkGxXRif+4WP7TrZvw9C0WE66QHRLpVfp87G8a5Q6P8OrJQf16pNACUlD7AhRAZu0C3fAOBJi6dvSgEmaoEV9cpWW7IHiWcvvDpVGIe9bjL1UYHjF9MQ77tZG/KDrZk4hcjZcA8YTnE8WQLXxUR0BI8039oA0aUHn+LREgWFmMuvbq8b9qKpGBkjJ1qTzDgqut/7bWPE3aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DkhFzy347CReKh8Y/3De5x5m9e7u839I/9k6SdaIf8U=; b=bUd7P619XWnp3H7OB77VkVB8OjiOKtLehRwdwc7i7ObBojlmSrOn8fD4HC7nF+r7v3Li6Fo9F0JGYKulTHZOP7635PBPUu3X1fOt9sKeoc2jEPHd1uobkiZQPz0nN3ckPOicv2zJ+KWtilliMIezd33QiWN4Nn1VdajDVTZrmGA= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS1PR04MB9334.eurprd04.prod.outlook.com (2603:10a6:20b:4de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 5 Apr 2024 01:51:34 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 5 Apr 2024 01:51:34 +0000 From: "Peng Fan (OSS)" Date: Fri, 05 Apr 2024 09:59:32 +0800 Subject: [PATCH v8 1/4] firmware: arm_scmi: introduce helper get_max_msg_size Message-Id: <20240405-pinctrl-scmi-v8-1-5fc8e33871bf@nxp.com> References: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> In-Reply-To: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712282385; l=2653; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=dKDsMHnM+cuvfvX6K6tAU3ADCasBJe+OHaz6qBQ1Tuc=; b=OKFZQg9iNV1rPeKGiN9dUt7Lvl/bm1h4ZwOVkECy3ViF7GlUxLssVqnSRyB0Yha8FHSCNp3PX 7aAXJzxNv0yB+24h16cq7oABrZSWw+2KTCYLGeC9R/8NXU8yEFeo0fW X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS1PR04MB9334:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g9dfYGQpdcCOKQ8McC+8G15rjDNZ4jlFM9AOLx658oZd7XHdHopuO+jT3i+32LZww+7fdPw8me6KVOAf0gHM4549P+b/YtoHg/LfQOXozSUGugidZ1+uvi5hoJSP+4oz2x8zMYDSAexJ5QnhfbrVX7CEj1WfKToV3CzG5pL51dt7xk9khbN/vJHUoH7fAF0mpmGe8nuzSZ/W3ILvY04GZKdTuVauuBFGiNPISEbENVSd7pYfAnyg12hisPlxO4UJtbrnTxgTW0jg+JF3Tqz+2/zNfgGdeknhXvG1DCaj/DHqPY7QQx13BnsjHQSuFYmh6clDv+C5FOPur6HqdrTva/Yg1WaF+27U6K6mqNkfp5OiPOFynpY9vhn8yv/hfvrHHsumKzqYw0SnryzFLMTYXmOaI1M+Fgc7IMNiqSLjAV3HNeaMbQ+5o4TgfGL0x8ZFmYM/Kgy0Eh2PpKfbsId9p0xLcQKnssiN6hXV2VE54wpuhjhrHUjCrzh34sC/6w6q9DsK6t5XKbh03jWVDIZNjxfwbStIazuxHekfYQxs6rGShZUQdqsuNbwOIiIBZxTQjYivaHJV8YvwxJJYy+5ygfaTX4XKyzTSvOUqIzT36jCWDf6X15T2vI5iWYMYtvf9eKUXKw0BWERo/eNHGE+CypqtARB1p8cgBc1eaUXdW4khSJqip9KpO/YbbuOwlFtbvmo18J0IfZ0ZAKsOadsUxWrAiQGuYG/Cc99wfC+Q1B8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(7416005)(52116005)(376005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?UAmWMHe4aF2f50CLHJq2JnafRjta?= =?utf-8?q?X8wBqE3J+PudtWFR5U3xElWW/rGaDd0HHRoGTFefJhWCLbwB30jPWx34+ZWRjb7FJ?= =?utf-8?q?Pc0uK7b9BaGbQHydxJMA2QgX9tG6wRBU2ReAR9vBuHIBl/CJZncSo5s97i2jWraXs?= =?utf-8?q?z7y2amodn6JQjUq0I1n/KFUvZ8eNM6LU8vbLrtBE4EXwXBATFEkirIxw8ZPVW29A2?= =?utf-8?q?PpMCJKJDg1wjjkROkMhB3pmIZmNKcZKnJTrWeGzVqU3tdZT4lmGRAIYgtSyj8bpka?= =?utf-8?q?i166f2P8XU+DK1Mev6ufjj5dURgg9AEM2AmlsvrszLv3GNAPymXbg2hTuHfeM26xV?= =?utf-8?q?CbH3YFbcNZ7S/pLLUumjEpXWfKMqbIIwBI32DGfZqJUBf/M6UZzEG+k5Nix9lFIzL?= =?utf-8?q?QM8+kHwk62Cn0lf4HIOu4+dy3QnNfwHa7MhYB8OvizS5ZIJj4L9t+gmnYg3IGPWkw?= =?utf-8?q?fogQ28XgUZToSZmqLvTf9UDXBBHojNRu30xDvod+C6Fn3Nx30SB3o8ttDiigyClkT?= =?utf-8?q?7Jl/34gUsoSG2ppWKomWl303NWJRjFdjyrwAWIktFDkb83/sWbo5r5gxcRAOlYSC1?= =?utf-8?q?KvWPhuSKmRBIbZWrbgnfpcex6aSkk3l7v6mj7Q44j7nmmXN7wyDVWXozQDM8v03ed?= =?utf-8?q?1x+aHGd15phP5u78UpMxJiu2lYoY5EMWTOPtbDMe/ZMl34pTYAEQYtpjKGakrIeFX?= =?utf-8?q?2pjdsp0jiW4t3UZJpR5/pp/AcPxokcvCxTIRVyEGAIB1X2D2Fy5JZF3ZQ6u4+icr6?= =?utf-8?q?ZVDesW+o2aorUfL87fMwNOoaZj7HVG1QItp7huo5lAoJ91QXpZ2ow5DS+g03V9eXA?= =?utf-8?q?x3RvRFcXai3mAp7n6KRtweCUKrMr1yfjN0nkAX2UM0xxWGwF7UvN62leBxymPW5Ci?= =?utf-8?q?GCjeCFCFV5PIgNPITQcq4uEtsVwrKY4+21xgIV2GY5ZZpAGXr6Xm2QeBpR3BFEPfZ?= =?utf-8?q?/9oXNZulsFsYNGyrvJl/eM+DNv2DdD10GhwJChEkdauqtTxkuLAuob+N1LIDk6PJ7?= =?utf-8?q?a4eTGNgA8wS6xhn7KywGfo6EQiRPQphIB/hdi9r3netEYdOuoNMHzBnR3KjNRmX0y?= =?utf-8?q?toQmuGc0NtLKTEMCfbtpDjg/73bQVZesRdXmsdPEQBalFd3DCgRzjMDM/h0hAInMG?= =?utf-8?q?zPBc57eAyHaSlgsMy2KP2VlQQL2ncVH9bmebTjWnJGeuzGDzXgq4z5ewTpSg3hmTO?= =?utf-8?q?7zLWh5q+S2zZynzkwFzLQGBSrCg7f49aorEXOweARiLc1segSP6nk3EsRzRsGdMNo?= =?utf-8?q?3oJpObCY/sofIolMhm5n+7ifbBIucQHSs5dexsvBMTwiPg72tsproX0ijKRNm4FNk?= =?utf-8?q?Y4QmFPXjAUomEyzNb8cvxrsDLpBiB9UGD0XVF4PnRVsp70miyECKoZnsxher7peK/?= =?utf-8?q?7pDokkJo9NqOWtb6petSSmctGK7E4oYUdd4Ce4EAOOgsSWvIuwbgSKNKQsq3N90Oj?= =?utf-8?q?0Cm4ICdN2PpvHX4FKD5MjoypbwH50W/6SitoZIqvgNybZ9m3C7MVbrHAqQumnW+JO?= =?utf-8?q?qzBhz2dIcApz?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b766d00-8ad2-49cf-80e7-08dc5512ec3b X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 01:51:34.2107 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lANtDZAk84Tkv0d9S2t+ox0JJHJbEHIoQ3+D1/HwqKlUj+o7/1s1RKyF7O+4Cr8AJXA3gxUAWS7zDtFJ7YK9pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9334 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_185142_070905_E4C76AED X-CRM114-Status: GOOD ( 10.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan When Agent sending data to SCMI server, the Agent driver could check the size to avoid protocol buffer overflow. So introduce the helper get_max_msg_size. Reviewed-by: Cristian Marussi Signed-off-by: Peng Fan Reviewed-by: Dhruva Gole --- drivers/firmware/arm_scmi/driver.c | 15 +++++++++++++++ drivers/firmware/arm_scmi/protocols.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 2709598f3008..415e6f510057 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1488,6 +1488,20 @@ static int scmi_common_extended_name_get(const struct scmi_protocol_handle *ph, return ret; } +/** + * scmi_common_get_max_msg_size - Get maximum message size + * @ph: A protocol handle reference. + * + * Return: Maximum message size for the current protocol. + */ +static int scmi_common_get_max_msg_size(const struct scmi_protocol_handle *ph) +{ + const struct scmi_protocol_instance *pi = ph_to_pi(ph); + struct scmi_info *info = handle_to_scmi_info(pi->handle); + + return info->desc->max_msg_size; +} + /** * struct scmi_iterator - Iterator descriptor * @msg: A reference to the message TX buffer; filled by @prepare_message with @@ -1799,6 +1813,7 @@ static int scmi_protocol_msg_check(const struct scmi_protocol_handle *ph, static const struct scmi_proto_helpers_ops helpers_ops = { .extended_name_get = scmi_common_extended_name_get, + .get_max_msg_size = scmi_common_get_max_msg_size, .iter_response_init = scmi_iterator_init, .iter_response_run = scmi_iterator_run, .protocol_msg_check = scmi_protocol_msg_check, diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_scmi/protocols.h index 317d3fb32676..3e91536a77a3 100644 --- a/drivers/firmware/arm_scmi/protocols.h +++ b/drivers/firmware/arm_scmi/protocols.h @@ -258,6 +258,7 @@ struct scmi_fc_info { * @fastchannel_init: A common helper used to initialize FC descriptors by * gathering FC descriptions from the SCMI platform server. * @fastchannel_db_ring: A common helper to ring a FC doorbell. + * @get_max_msg_size: A common helper to get the maximum message size. */ struct scmi_proto_helpers_ops { int (*extended_name_get)(const struct scmi_protocol_handle *ph, @@ -277,6 +278,7 @@ struct scmi_proto_helpers_ops { struct scmi_fc_db_info **p_db, u32 *rate_limit); void (*fastchannel_db_ring)(struct scmi_fc_db_info *db); + int (*get_max_msg_size)(const struct scmi_protocol_handle *ph); }; /** From patchwork Fri Apr 5 01:59:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13618356 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C55BFCD1284 for ; Fri, 5 Apr 2024 01:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=3uVMD2uWMLWGzrxF7ffD5s+x32h+1pK32sZCWgZEigc=; b=i9bG8139ocEjmVmdYCWDLrkgyw BfOtoEr2QB3P7FdmpW8FYiU52ucKOF+HhiZHI+mjesbCpEbNHXUESuuE4uCLvJz6KvmcFMP/ZS702 9RRKatTjhRcDyqmWCA4kmsLEXc4xM0x1UIgcAOhmDyECddroVv30UAOQvQltapAAZKyoV5Wig38tK 7pEn8Y1PYt+4Aq7MR1jbL7d78O0nnO2GLqlC4rgOegU5Ha4cwItECduj4ichXVdpeCZ0ze7rA0b7y HPSf32ie8mi45hL/imqzUAYeJgQPOFx+8WpNWtChZ74Qe/Ye2Oy80gU9BGhgqImbvHK/W8fActhbl Hgqt/whA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsYk7-00000004qds-2Iux; Fri, 05 Apr 2024 01:51:47 +0000 Received: from mail-am0eur02on20700.outbound.protection.outlook.com ([2a01:111:f403:2606::700] helo=EUR02-AM0-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsYk3-00000004qar-2fX8 for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2024 01:51:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LxKpsBf0zWtVP97or+M8KJAfgSxLkTt26IKCnXDdu1HY/a0JUBzt/OTO3Ggmza4a4vfKxb3pl279WNINIPJ9ZM2J7oRZ+BuydxfO8DnxBV3edfXFn5WzDDMpmrKc4EUbY7/ua0sN/7mVsadTYRRvxSDqsjWeoWUgK+zJiARbU8MHBuPopM3+IWEglf5rkYJlrDwQhfxyQukS8OZ3q+GcqsVyU6+daITA8bIUhfp5uKeRWPLW3gyqyZygaOIXSRxgVrEVMYDgxUQt1YBkdpKfYkAg4qbmbGTqxBbVPfGDrG5KnDdjaMfHI0/MO2kCeNAUFKdTF6tOQ+IHrS0p3dt0Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/BzLovi5aKNOiOuw8s4YMGfV7RBPkidh8VfX3S2pYQ=; b=GDlMpZLsJJ3MZAi3PoTN6Udsa5cwOS4iCZE06htIl9Kg7zQNfPzh/uJEZhpLwCmOKtgRzdemwCO4ITA8ltQlZax+xgxazlqUBJfxBU9WlMeLdlmSNXzcofQrGTOoL6T2J9MMXdRA1vV3Xu07Q7ju1Twc/aBtSnSjEgCW+ydM2MQfvF3kzeHKIc5HgnNH1zZAEOT3XcvXW39r03YnOv4k/p844tt12YGwRQa+vaMHdy6Gw291J0mSDAyS0XqzlX2D1a4XPHtAf2QMpWCViE7U8KaRFMipdDJ9qUcMdZxfTKdyG9i6n2XPr/UjGS2VY0HPb6CvfoIera3/ahWy9OVM0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/BzLovi5aKNOiOuw8s4YMGfV7RBPkidh8VfX3S2pYQ=; b=Z6mF+gr7BbXSr+H9yoNfUxdlplWIEpRY5Aq4ApNaNPY+t7ORnO4AanVjqKXGgiavhac/xuiSCI0bwxs2IYs3oO5PMeET9xNoc/3SWpNGu/oRCtns26wrHUPjiqcK04bB8WzlwlGECeMd0ZQ8DZuik+d8eYF/r7I6wx91t0azLFQ= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS1PR04MB9334.eurprd04.prod.outlook.com (2603:10a6:20b:4de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 5 Apr 2024 01:51:38 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 5 Apr 2024 01:51:38 +0000 From: "Peng Fan (OSS)" Date: Fri, 05 Apr 2024 09:59:33 +0800 Subject: [PATCH v8 2/4] dt-bindings: firmware: arm,scmi: support pinctrl protocol Message-Id: <20240405-pinctrl-scmi-v8-2-5fc8e33871bf@nxp.com> References: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> In-Reply-To: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712282385; l=2362; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=1H2rME0+2KWUaw0j7tYsXFokSaYx/bEPhCjn1uDoVYo=; b=BUg2Cj4WROOGS5yaciuXQoewxdfbg74i5cVScjfGO+Sj5vomm0JEOhabackVE8ZtBVN2UbgQv PU3CwxUabP1DXjMNnwwj8+2nYHZNcbdJv4mld2rtsaL5vzAsVWC3xLe X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS1PR04MB9334:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: So1+PPKJB5KIPLEJc9gt1uj6emVSWX1IrxMf//nOK/mDfmFEyWm0O3YXxpcvE5EnOobm2qYLBiPqoRQ3DoHge7UeHQGEV25Rp6qRfxrCnmNF6aSBwZhwnsfpfAxEL2YUti3e0qxqfj0N5yS7sOWzQMw2kr/JamkFzdZG1+QIRr1gJP0v9yIahNHKbnD5b5VgHu9PPWiHvFk+WZTQDwfknhR2bCUq5eBg6LdZXTAb2WLi0h3K9PyaSNqtPro1lk5/xLR00suH0xbOPVi3qj9vJArCP2Dwq4ysHOrS1RusjT0KtnSF2c3gXp2mSkdRiCqT19rMyXqcJ9mKBuIcN2G935EWRlCxC4Hr9WptbgsiVu70y6LQIr2e3i/ML4+7ZU2Hy/Kj3+7pL82nVGxAjJTDo/eYLHPc+BtIhG0Z1dTYEVcFIYxZrBxvCMoQqa22BOgdyRx2NWGXBy8QrCBZPFNIg5hCtD27+GvzIh2fivKSNGxB4MrhLRes3JmBvV40Fh28eOPvSjtwSqPJY4SX4+qtADsMJtllFGrLww7IfXjiBqqb1IdmHg0Rz4mqHo0tbVxvlXNpAH3bw19mIlQhYz7aHsmQmOq8UfP9DETP0kHfeF8ZBLMeEPp8Uaz572W/RmdnRXTiGdegTqMm3kj2nrGB3L2ehGYuOK/jFmodTCk+r2A32a4X+EOQWuzY0r4uboMJpXi98Vbcrj9IBj5kDIfDka0URgR4axQ94dQOBmNipBM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(7416005)(52116005)(376005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?0taMi1Xz9vrh743Xory+WtI4WOuv?= =?utf-8?q?Yr/au1ZVSHUs/Zniyn62+xgY1X/XqvfH/feFf5e6tovp8g3EftqJtoZnwLDmFy6MK?= =?utf-8?q?hfDc25L0KfjJn7etTwEriSOTe3k+6Q6IKjEg9pc5sby8iIYfk9GrhIGuxu+XHHpUZ?= =?utf-8?q?ScJUuYUQXiwsejRJz7E7tImY7vd33Ggfu7Q9R+mte3jVE4ZufKBx6OHlsCvilTSkl?= =?utf-8?q?z22AOk79oRk4plE3sMy8gXY4WixEmHyZYNhNDnahjBjvK8uHOHLIuJc/Es+PqmZKI?= =?utf-8?q?6qw0zLWSOarycI82N8r0sUTrAIxguThGkiDtfmVGQnzlihOWgDIisY6yBVpcjqVAP?= =?utf-8?q?H/WggggA1aCzGCTWTf1ipG2k8V5Bmu5rTEfa2AtcWaZ7CV7TNE9iAUOawZVoBTXYE?= =?utf-8?q?A0lb8Ci1GLyDbQheOTX3Rj59o/48riW3OLww/VbhcFvyfjCmI9Hu3Eb9kJ5MkbJ6x?= =?utf-8?q?gZuR8gHkX5Gik01K2qA012e1T0tYx906oqMbgIK0dj/2BFaUi0lAbUieka8e/7Qhw?= =?utf-8?q?JIvzRNHaYVv0gj2f/HgWDSiBzUhQsZqnKRF2pLFY9IhexwqPeO6HiswEqOhIQhMmj?= =?utf-8?q?B8Ntp+Tp3eYB21ZdHPD86VYQ23nUeOPWDEWjLfT2lVpb0JCgLwYsWN24EU2UnRqyX?= =?utf-8?q?yvGcC83t46/dC5T35321kX2uDszY13bmAurUIrynF1/08DWcvsXddI23xDozMQ2/2?= =?utf-8?q?efPSUJCO3828/CQDQ7IUQsiKcwtM759A2UgrzDpD4F4omQ4xKtCEHKhg/rewyfy/z?= =?utf-8?q?tt5TmOULepaEGaHfI+QeKAVMvB0uhq8riQDLecqExtgO8z/Tc6WqKfVPfQqPJbTwy?= =?utf-8?q?zkLjmkg+5AbibAwODby55DZ9m92z4cT9SpoCvRsrLW8+wy1oopkelGK28N//wxWPt?= =?utf-8?q?NQEtpqn6GI3MYFjK21PCw2YXLpByycsFsIRrh+kPjbI32XX0hKrPLfYKvkAOk3j7H?= =?utf-8?q?V6CI0JVTuXkCwbDqG9rcHxgxMZHUjeqGrexPyT03W78zxmvfONcEzEobJ+4rKoIRa?= =?utf-8?q?V8qfw/TjXwc8/EorUtWQZMqyyV1oH3f9yjXcIJdlH0pEAEwE7mlO02k3RK7ulEVRW?= =?utf-8?q?nJ7tbnJ099PTEhMfgplNN/QSiqmzPVekJjWxdulCF7Pp0jOdhhVuHSN4eMQVcz7tQ?= =?utf-8?q?mvlo25luLNYq4LSU8aphy2uvVb7UlCrOebVHqBnn/gokA8kSThaWsv0/Uu2BXxHZp?= =?utf-8?q?4mZeQI5G8qBMDzNbdav/QsTl9B736U0a04+lY0/v5s9KKTmF4VVy6QPDsf7pXjL+B?= =?utf-8?q?5+46ZxDq9NuQCwMJRHra94vJ/xlO343CesxMgJJ8jpNwl8U0iQEVLu9mrEzO86c7f?= =?utf-8?q?8C7UZP+Er7lOEEt210jQc8XvC2NYrW/EW4ip+WBot8Lo7mr0g+1q6Ki8xCmx3QN5s?= =?utf-8?q?fF0h2USbB+EN6eAlD6Qmb61gx1Mxf4DMvT6XGJW22RZfWK0DWstJ/o2IE91apGGdD?= =?utf-8?q?AJHm1TiEnqzNZae/5HULYkWQy+s6dijxtDyo2GAnL/WiK+m3PDDYEObz9CDINPLLN?= =?utf-8?q?v+3ATuv/BsaG?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ec8c218-02d7-4604-1dba-08dc5512ee9d X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 01:51:38.1992 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UJ3b4LYDluYeInuQqhKy82ZqKige506KSpgIVjUSnaBUWmjQ/t26h6KUxbqrE9qI0XLItmqaxUfe6zf1ieF6LQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9334 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_185143_731505_2E6E8ECB X-CRM114-Status: UNSURE ( 9.17 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Add SCMI v3.2 pinctrl protocol bindings and example. Reviewed-by: Rob Herring Reviewed-by: Linus Walleij Signed-off-by: Peng Fan Reviewed-by: Dhruva Gole --- .../devicetree/bindings/firmware/arm,scmi.yaml | 50 ++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml index 4591523b51a0..e9d3f043c4ed 100644 --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml @@ -247,6 +247,37 @@ properties: reg: const: 0x18 + protocol@19: + type: object + allOf: + - $ref: '#/$defs/protocol-node' + - $ref: /schemas/pinctrl/pinctrl.yaml + + unevaluatedProperties: false + + properties: + reg: + const: 0x19 + + patternProperties: + '-pins$': + type: object + allOf: + - $ref: /schemas/pinctrl/pincfg-node.yaml# + - $ref: /schemas/pinctrl/pinmux-node.yaml# + unevaluatedProperties: false + + description: + A pin multiplexing sub-node describes how to configure a + set of pins in some desired function. + A single sub-node may define several pin configurations. + This sub-node is using the default pinctrl bindings to configure + pin multiplexing and using SCMI protocol to apply a specified + configuration. + + required: + - reg + additionalProperties: false $defs: @@ -401,6 +432,25 @@ examples: scmi_powercap: protocol@18 { reg = <0x18>; }; + + scmi_pinctrl: protocol@19 { + reg = <0x19>; + + i2c2-pins { + groups = "g_i2c2_a", "g_i2c2_b"; + function = "f_i2c2"; + }; + + mdio-pins { + groups = "g_avb_mdio"; + drive-strength = <24>; + }; + + keys_pins: keys-pins { + pins = "gpio_5_17", "gpio_5_20", "gpio_5_22", "gpio_2_1"; + bias-pull-up; + }; + }; }; }; From patchwork Fri Apr 5 01:59:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13618357 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3485ECD1292 for ; Fri, 5 Apr 2024 01:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4teeLcGUHTW6HN834bU44PMkcsTLcEybyk5Jy4zv6cI=; b=LMYZck+gUN6MgRgbx3UqS7wqBd sRdenqSHnKmuD2jWjx2uVStWSZcIQ2pVCTlA3tQJb8fTg3WPcsOlHLHe253x/aJ+JOSTLy1exj/oq LCZleEzC7O9FBlefzXz/ubHkUJ2CaBSg34DXNQulyAdf75vtQw9kKvhmu3ELxECFDpzQk1oyEJW37 MaTiTJ9oln3jqJyY1z1iUl0Kc04E89nikwyel2L7qQzonM3oePsyOtkkiHMSvYomKDPePAXZ8hiTu zmTNzeE4zPUkts8YWbPTD57iX9mdrn1nr6XDNPCoc7fuU8kfA8sC27crUx8kU3/MFJSsiZ37iNXkO bYFJZXsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsYkB-00000004qfs-3TYY; Fri, 05 Apr 2024 01:51:51 +0000 Received: from mail-am0eur02on20700.outbound.protection.outlook.com ([2a01:111:f403:2606::700] helo=EUR02-AM0-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsYk5-00000004qar-0xiF for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2024 01:51:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lA4vlFjDE488436ETYxlyAT1RCax7PmsBEKNBoRJQLC/Bi6lZOj5IkVx+b/Bk5JcNvUbmHfzF9RzpWwT6gBYJW4T+WfvVS1SNAXRtSmEeEjEcHJXEtlQj+1HUkQ99Cuf8ITR1rtJKDPLbwXERlDnZeThZ75nRTaEvMr2btSeC2Pk6jwnqAelBXasPeZCRKRb5QsFrzzXPtCw84ISwnkfWzdUA8uhnvUe84p/pRWb01qKgmhNmW+izveRfVI3H6o+40L6DJkXNiDN0lcAdViXg7LNqJwztAcLBGVkyMNq0k/ZtXzaCZz9+GgviCkn76OMkeAaFm40niRswcYmHxC4PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T+gf/HxSb3mYO0Kv1k4ovO2uwhjiZsrfA82adbv+lSQ=; b=hhTlpKkamSWb1Pj4EEPhUzwDFg0H4vSLNIYW51NpMuYPZad5nDp3BQVez6ff1w17v6odi5cEWfYT40csm4nc2lX2x1LozFIKmyqpKWtPGBO3o06sCVVzsisqF26LK/0UvKOro+Kf5FW8C+5VideFcnEc0dbGivvtcPBK5OIpVuMY1A3QKVA5R+9EY/wcllv/B/TraCremlIb84NpLVWo8prQXKR80+TyMo8SuKKyJbCo+eqKr0CBxPYyIitCwUqE23H/rHJGNuYoG/p4WoWq041CGIk9ypdxRSndDDLxvOAoYUcG1M3IAvvDNEx0tjixUqx+hm3DiVXG/oxEsh3Nbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T+gf/HxSb3mYO0Kv1k4ovO2uwhjiZsrfA82adbv+lSQ=; b=aH8nyoubFRo8lKMp1lHo9A/g6sRmjSMxzJM4zHOeP2VNQH27Hk/eNhsX+yZN/jku7m0HpKp5wj4M1HvRiAhzC7LOQlIqzNg7TrJnvbjCCa/V4O4pRUD/H6IyMDox1NIbtvxC6wBjw/qw4kEagXzHpvqCnmJdlQKTNs3E+PrbzUs= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS1PR04MB9334.eurprd04.prod.outlook.com (2603:10a6:20b:4de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 5 Apr 2024 01:51:42 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 5 Apr 2024 01:51:42 +0000 From: "Peng Fan (OSS)" Date: Fri, 05 Apr 2024 09:59:34 +0800 Subject: [PATCH v8 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Message-Id: <20240405-pinctrl-scmi-v8-3-5fc8e33871bf@nxp.com> References: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> In-Reply-To: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712282385; l=30412; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=66yyslbn31g3m2BveLmqG+nfctE+wEn4ra5Q9YPcQOQ=; b=wqKWdBtJuPbFmEjQ3aCOiEPZElTaxtxGbMN8T+FJLsQASvtLhL4wbVJGoW3Jk6ko0tRzxM5RB kH1wz8qjeuRCUYL4ja74aHvlMRpb9p96nXgj0HKJ+Gwy1SWGAvVLhrq X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS1PR04MB9334:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hVtWOI7fqf9YA/AF4BN8xL9d6jMoMg51lXHwdkwl3o2w4N8IZ6TZ5F7YbD3Ey+CzUaBfLdzcFL9OYl3fNeNoBvcUhlNwirQLje480mkm5y6ILhXqa43OiwYXt2mhtY23IllfD/9OPWi7q+HsYJaFnTrQDHyqcOknBvdmHdrq9ZT2Wi6SbcoMg8pf45EfMf1JV5en/Xl4l7+rQIJDlb14Dv58qx9U6Hy+cjhZvnOYFtdwyzxNR4sJtZEI5OPQY+kqYGBI07Zao82wtiG35x67MhblkF8ixea7VJy/78OLlQ0caIqrw+Aqj0RbvK+CRQNU/CJOcq2HcKRAjPjxxqyFu9KR+7ch3WTBF9EnlLK19ucezeTgshSQIJdNNlgUv8mvuUu4NUW/ddITGjXn8jLRn0lFX+kKUpW9DGTY52OVtrMfzn1QPoXT06f1nePc8shc6sZWQ19BbFeUv0ArIoZUHkS0E2PZZOE2wTJ4ij4ViVhHfaDrre6HYRR47mchpsRn0FK1oG80GfAQ1Wd2XVzhOlSTE3IrP+b8z77nfEdKT9Sz2nH8jdnrnwhOsL/6uxc3h0vCMUcXKEqZJJffyM/x9lyvAMvgQcJdkp2v+uZiaxEa4WaK6kiR+MDf/QRLm7R8jlqoJDQ3ssL+K2zWWxOFAIM3zmvkgHBKmXFL7J9/vtWEqRlEwIYx6wDB0JFWN+/ksIRAVcuC6UPkYPA4x8mchzGUjrr0LJWPJpic6tGWcWE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(7416005)(52116005)(376005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?nYq0RfvV+C3hSGxDvyo0OL4DA5IC?= =?utf-8?q?sEbF0VgNch2BkgWXiUTFQrzOalrWz0fkF0lxzes6oGG+vG7ST3qmcnYVry4G36YKP?= =?utf-8?q?4tzpBTxHCVHFhfbJmvyQKIU74n+DAxXyDrW8qzaJ9W6PdmGvk1CUCVYqHFwC9VPM7?= =?utf-8?q?Yuu7+qEGGV0M+amJ0PrpOxN6xh3hKd8LnlYufFbOXd/mS7bVrWMkmD/LbMFXxPwRB?= =?utf-8?q?rqASaf5qh4Scs9yrOUYz/xSChtG04eBtebA3a2Uj/fXeKQU2fNv/xXNbJYURfqnGY?= =?utf-8?q?xBuIWeD5sDLtqbE0rHWd7jUq4hagCZPf+/HhiS9j99+XpJiMggXBISdC3M/SgW7Ia?= =?utf-8?q?yWZdXMIMK7LCfDwXycrnpHUz6kgX6TyKTr/YcdwFCndUDDFZMGpFRH+a29tk61G9t?= =?utf-8?q?fDWK6p/HxG1PFbLLnz5Hpf7zn4wsv8DTsM3EHExChz7oVKaGLSuLTmzOfq9kXiH4q?= =?utf-8?q?NC58MqOyqgjaEF7wrC9frjI2A/5XS7RBRfOmsgU8SSdUK24++2c5IIzFWmiug+fKi?= =?utf-8?q?6GwSQeUI+px1Wpsh7KpssPCEHZOG4u4vx8XEO4zQ/qk9jJweWnOuDnJupbUiTFvZM?= =?utf-8?q?mwhv89pDbMsPDslEpJA5lckceEFIv9WrV1go6KoxqomoBc0pDQtL+E75v7mDMTrJg?= =?utf-8?q?HLFYpPYQajrEG+HlO83/cW76RZmJyg5qcUl+UqQSPoKNqjoWcJkDiGbeEaieODvNv?= =?utf-8?q?dlm2wmgm+x6AkseSImG2qO7jTqa2bxuwydMFedw2lk7QNtE4G4SS/SkDdkkRvlBUg?= =?utf-8?q?+N0K5k+I78gL5rzItInu77EwG247RPFmljy1dUY7sA2fqm7wITmSLWSOIQjbL6K8L?= =?utf-8?q?YVRlfc/FGb4Hh47bt0NI+PZ46SZRaosuobYnS72mszIJB7vbOkU9EvAVEERiCFcR+?= =?utf-8?q?AqEdLVRIQWxm/Lhcmiqcg2WdnLgwmmJLfWXiwAWIMGvod9BTJwfhx9OFdsHGcN4NP?= =?utf-8?q?Qlf3xpsolEu2nzHZnzCYUTpx6ZK77do1f0r8Kc75V6U+2IhEt+muAa1pdryd2teIf?= =?utf-8?q?MmGmLBTMtmuZ0d2cDU2kRmpMiEegIpc02WnadaTbR+2aXbp1yGNGiUeZo45TD2/m4?= =?utf-8?q?aH6fvoq4tQQRF2eAZYOUjfF6YPVFAaJ8bsJ7sFWCV4LruLlUcsrAuRUVN8M1eYzyM?= =?utf-8?q?0LcP9DBNgga8sEfD5bbMpM7pVqb/sVnB+XKYzXRRgKk8HFDCrIT4LFU/c1XCiWI01?= =?utf-8?q?LQVxteevgdP4yUGP545SenmMsJsiY5Sv69SfkHdUBeF1N+pJjn06SZFvfBCDSv6EX?= =?utf-8?q?mmt4mbanDlGEJ7Gp3BIKK+cDb5jF/vHmbC63tdq8kqa2Ix1OSeivQYy7wRmkN2YmS?= =?utf-8?q?FMfIoR+Qdpw8BsLhYn93usfQ5LDZDKbMQtZLO0Lv5IZu8m2apZwK83X9nHhQi4Fgf?= =?utf-8?q?l+7v4cFPyik17oQzEhtyrvRiSsJ6EGu6nm6jaf0kxJTMyltziWNW6OuAi1zsv+FS+?= =?utf-8?q?keeJfQu2275o56jKb8X5k207ZzvHSb+qIie7/Xr4LenD+1he/ECvAiTRDdpW0yqUy?= =?utf-8?q?RDbrefQ/DLVh?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a4dc718-ca4f-4675-61f7-08dc5512f132 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 01:51:42.5328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yLXUAKqr9KIZri8HwVU5j55lZUUbf2625N09TNL7BQB6NjoHZBrr1eMr06mBsRHD5VxxQSVSkL7cCWOcux/6ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9334 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_185145_604989_940BAB82 X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Add basic implementation of the SCMI v3.2 pincontrol protocol. Co-developed-by: Oleksii Moisieiev Signed-off-by: Oleksii Moisieiev Co-developed-by: Cristian Marussi Signed-off-by: Cristian Marussi Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/Makefile | 3 +- drivers/firmware/arm_scmi/driver.c | 2 + drivers/firmware/arm_scmi/pinctrl.c | 916 ++++++++++++++++++++++++++++++++++ drivers/firmware/arm_scmi/protocols.h | 1 + include/linux/scmi_protocol.h | 84 ++++ 5 files changed, 1005 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/Makefile b/drivers/firmware/arm_scmi/Makefile index a7bc4796519c..fd59f58ce8a2 100644 --- a/drivers/firmware/arm_scmi/Makefile +++ b/drivers/firmware/arm_scmi/Makefile @@ -10,7 +10,8 @@ scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_SMC) += smc.o scmi-transport-$(CONFIG_ARM_SCMI_HAVE_MSG) += msg.o scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_VIRTIO) += virtio.o scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_OPTEE) += optee.o -scmi-protocols-y = base.o clock.o perf.o power.o reset.o sensors.o system.o voltage.o powercap.o +scmi-protocols-y := base.o clock.o perf.o power.o reset.o sensors.o system.o voltage.o powercap.o +scmi-protocols-y += pinctrl.o scmi-module-objs := $(scmi-driver-y) $(scmi-protocols-y) $(scmi-transport-y) obj-$(CONFIG_ARM_SCMI_PROTOCOL) += scmi-core.o diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 415e6f510057..ac2d4b19727c 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -3142,6 +3142,7 @@ static int __init scmi_driver_init(void) scmi_voltage_register(); scmi_system_register(); scmi_powercap_register(); + scmi_pinctrl_register(); return platform_driver_register(&scmi_driver); } @@ -3159,6 +3160,7 @@ static void __exit scmi_driver_exit(void) scmi_voltage_unregister(); scmi_system_unregister(); scmi_powercap_unregister(); + scmi_pinctrl_unregister(); scmi_transports_exit(); diff --git a/drivers/firmware/arm_scmi/pinctrl.c b/drivers/firmware/arm_scmi/pinctrl.c new file mode 100644 index 000000000000..a2a7f880d6a3 --- /dev/null +++ b/drivers/firmware/arm_scmi/pinctrl.c @@ -0,0 +1,916 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * System Control and Management Interface (SCMI) Pinctrl Protocol + * + * Copyright (C) 2024 EPAM + * Copyright 2024 NXP + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "common.h" +#include "protocols.h" + +/* Updated only after ALL the mandatory features for that version are merged */ +#define SCMI_PROTOCOL_SUPPORTED_VERSION 0x10000 + +#define GET_GROUPS_NR(x) le32_get_bits((x), GENMASK(31, 16)) +#define GET_PINS_NR(x) le32_get_bits((x), GENMASK(15, 0)) +#define GET_FUNCTIONS_NR(x) le32_get_bits((x), GENMASK(15, 0)) + +#define EXT_NAME_FLAG(x) le32_get_bits((x), BIT(31)) +#define NUM_ELEMS(x) le32_get_bits((x), GENMASK(15, 0)) + +#define REMAINING(x) le32_get_bits((x), GENMASK(31, 16)) +#define RETURNED(x) le32_get_bits((x), GENMASK(11, 0)) + +#define CONFIG_FLAG_MASK GENMASK(19, 18) +#define SELECTOR_MASK GENMASK(17, 16) +#define SKIP_CONFIGS_MASK GENMASK(15, 8) +#define CONFIG_TYPE_MASK GENMASK(7, 0) + +enum scmi_pinctrl_protocol_cmd { + PINCTRL_ATTRIBUTES = 0x3, + PINCTRL_LIST_ASSOCIATIONS = 0x4, + PINCTRL_SETTINGS_GET = 0x5, + PINCTRL_SETTINGS_CONFIGURE = 0x6, + PINCTRL_REQUEST = 0x7, + PINCTRL_RELEASE = 0x8, + PINCTRL_NAME_GET = 0x9, + PINCTRL_SET_PERMISSIONS = 0xa, +}; + +struct scmi_msg_settings_conf { + __le32 identifier; + __le32 function_id; + __le32 attributes; + __le32 configs[]; +}; + +struct scmi_msg_settings_get { + __le32 identifier; + __le32 attributes; +}; + +struct scmi_resp_settings_get { + __le32 function_selected; + __le32 num_configs; + __le32 configs[]; +}; + +struct scmi_msg_pinctrl_protocol_attributes { + __le32 attributes_low; + __le32 attributes_high; +}; + +struct scmi_msg_pinctrl_attributes { + __le32 identifier; + __le32 flags; +}; + +struct scmi_resp_pinctrl_attributes { + __le32 attributes; + u8 name[SCMI_SHORT_NAME_MAX_SIZE]; +}; + +struct scmi_msg_pinctrl_list_assoc { + __le32 identifier; + __le32 flags; + __le32 index; +}; + +struct scmi_resp_pinctrl_list_assoc { + __le32 flags; + __le16 array[]; +}; + +struct scmi_msg_request { + __le32 identifier; + __le32 flags; +}; + +struct scmi_group_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; + u32 *group_pins; + u32 nr_pins; +}; + +struct scmi_function_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; + u32 *groups; + u32 nr_groups; +}; + +struct scmi_pin_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; +}; + +struct scmi_pinctrl_info { + u32 version; + int nr_groups; + int nr_functions; + int nr_pins; + struct scmi_group_info *groups; + struct scmi_function_info *functions; + struct scmi_pin_info *pins; +}; + +static int scmi_pinctrl_attributes_get(const struct scmi_protocol_handle *ph, + struct scmi_pinctrl_info *pi) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_pinctrl_protocol_attributes *attr; + + ret = ph->xops->xfer_get_init(ph, PROTOCOL_ATTRIBUTES, 0, sizeof(*attr), &t); + if (ret) + return ret; + + attr = t->rx.buf; + + ret = ph->xops->do_xfer(ph, t); + if (!ret) { + pi->nr_functions = GET_FUNCTIONS_NR(attr->attributes_high); + pi->nr_groups = GET_GROUPS_NR(attr->attributes_low); + pi->nr_pins = GET_PINS_NR(attr->attributes_low); + if (pi->nr_pins == 0) { + dev_warn(ph->dev, "returned zero pins\n"); + ret = -EINVAL; + } + } + + ph->xops->xfer_put(ph, t); + return ret; +} + +static int scmi_pinctrl_count_get(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + switch (type) { + case PIN_TYPE: + return pi->nr_pins; + case GROUP_TYPE: + return pi->nr_groups; + case FUNCTION_TYPE: + return pi->nr_functions; + default: + return -EINVAL; + } +} + +static int scmi_pinctrl_validate_id(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type) +{ + int value; + + value = scmi_pinctrl_count_get(ph, type); + if (value < 0) + return value; + + if (selector >= value || value == 0) + return -EINVAL; + + return 0; +} + +static int scmi_pinctrl_attributes(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type, + u32 selector, char *name, + u32 *n_elems) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_pinctrl_attributes *tx; + struct scmi_resp_pinctrl_attributes *rx; + bool ext_name_flag; + + if (!name) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + ret = ph->xops->xfer_get_init(ph, PINCTRL_ATTRIBUTES, sizeof(*tx), + sizeof(*rx), &t); + if (ret) + return ret; + + tx = t->tx.buf; + rx = t->rx.buf; + tx->identifier = cpu_to_le32(selector); + tx->flags = cpu_to_le32(type); + + ret = ph->xops->do_xfer(ph, t); + if (!ret) { + if (n_elems) + *n_elems = NUM_ELEMS(rx->attributes); + + strscpy(name, rx->name, SCMI_SHORT_NAME_MAX_SIZE); + + ext_name_flag = !!EXT_NAME_FLAG(rx->attributes); + } + + ph->xops->xfer_put(ph, t); + + if (ret) + return ret; + /* + * If supported overwrite short name with the extended one; + * on error just carry on and use already provided short name. + */ + if (ext_name_flag) + ret = ph->hops->extended_name_get(ph, PINCTRL_NAME_GET, + selector, (u32 *)&type, name, + SCMI_MAX_STR_SIZE); + return ret; +} + +struct scmi_pinctrl_ipriv { + u32 selector; + enum scmi_pinctrl_selector_type type; + u32 *array; +}; + +static void iter_pinctrl_assoc_prepare_message(void *message, + u32 desc_index, + const void *priv) +{ + struct scmi_msg_pinctrl_list_assoc *msg = message; + const struct scmi_pinctrl_ipriv *p = priv; + + msg->identifier = cpu_to_le32(p->selector); + msg->flags = cpu_to_le32(p->type); + msg->index = cpu_to_le32(desc_index); +} + +static int iter_pinctrl_assoc_update_state(struct scmi_iterator_state *st, + const void *response, void *priv) +{ + const struct scmi_resp_pinctrl_list_assoc *r = response; + + st->num_returned = RETURNED(r->flags); + st->num_remaining = REMAINING(r->flags); + + return 0; +} + +static int +iter_pinctrl_assoc_process_response(const struct scmi_protocol_handle *ph, + const void *response, + struct scmi_iterator_state *st, void *priv) +{ + const struct scmi_resp_pinctrl_list_assoc *r = response; + struct scmi_pinctrl_ipriv *p = priv; + + p->array[st->desc_index + st->loop_idx] = + le16_to_cpu(r->array[st->loop_idx]); + + return 0; +} + +static int scmi_pinctrl_list_associations(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + u16 size, u32 *array) +{ + int ret; + void *iter; + struct scmi_iterator_ops ops = { + .prepare_message = iter_pinctrl_assoc_prepare_message, + .update_state = iter_pinctrl_assoc_update_state, + .process_response = iter_pinctrl_assoc_process_response, + }; + struct scmi_pinctrl_ipriv ipriv = { + .selector = selector, + .type = type, + .array = array, + }; + + if (!array || !size || type == PIN_TYPE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + iter = ph->hops->iter_response_init(ph, &ops, size, + PINCTRL_LIST_ASSOCIATIONS, + sizeof(struct scmi_msg_pinctrl_list_assoc), + &ipriv); + if (IS_ERR(iter)) + return PTR_ERR(iter); + + return ph->hops->iter_response_run(iter); +} + +struct scmi_settings_get_ipriv { + u32 selector; + enum scmi_pinctrl_selector_type type; + bool get_all; + unsigned int *nr_configs; + enum scmi_pinctrl_conf_type *config_types; + u32 *config_values; +}; + +static void +iter_pinctrl_settings_get_prepare_message(void *message, u32 desc_index, + const void *priv) +{ + struct scmi_msg_settings_get *msg = message; + const struct scmi_settings_get_ipriv *p = priv; + u32 attributes; + + attributes = FIELD_PREP(SELECTOR_MASK, p->type); + + if (p->get_all) { + attributes |= FIELD_PREP(CONFIG_FLAG_MASK, 1) | + FIELD_PREP(SKIP_CONFIGS_MASK, desc_index); + } else { + attributes |= FIELD_PREP(CONFIG_TYPE_MASK, p->config_types[0]); + } + + msg->attributes = cpu_to_le32(attributes); + msg->identifier = cpu_to_le32(p->selector); +} + +static int +iter_pinctrl_settings_get_update_state(struct scmi_iterator_state *st, + const void *response, void *priv) +{ + const struct scmi_resp_settings_get *r = response; + struct scmi_settings_get_ipriv *p = priv; + + if (p->get_all) { + st->num_returned = le32_get_bits(r->num_configs, GENMASK(7, 0)); + st->num_remaining = le32_get_bits(r->num_configs, GENMASK(31, 24)); + } else { + st->num_returned = 1; + st->num_remaining = 0; + } + + return 0; +} + +static int +iter_pinctrl_settings_get_process_response(const struct scmi_protocol_handle *ph, + const void *response, + struct scmi_iterator_state *st, + void *priv) +{ + const struct scmi_resp_settings_get *r = response; + struct scmi_settings_get_ipriv *p = priv; + u32 type = le32_get_bits(r->configs[st->loop_idx * 2], GENMASK(7, 0)); + u32 val = le32_to_cpu(r->configs[st->loop_idx * 2 + 1]); + + if (p->get_all) { + p->config_types[st->desc_index + st->loop_idx] = type; + } else { + if (p->config_types[0] != type) + return -EINVAL; + } + + p->config_values[st->desc_index + st->loop_idx] = val; + ++*p->nr_configs; + + return 0; +} + +static int +scmi_pinctrl_settings_get(const struct scmi_protocol_handle *ph, u32 selector, + enum scmi_pinctrl_selector_type type, + unsigned int *nr_configs, + enum scmi_pinctrl_conf_type *config_types, + u32 *config_values) +{ + int ret; + void *iter; + unsigned int max_configs = *nr_configs; + struct scmi_iterator_ops ops = { + .prepare_message = iter_pinctrl_settings_get_prepare_message, + .update_state = iter_pinctrl_settings_get_update_state, + .process_response = iter_pinctrl_settings_get_process_response, + }; + struct scmi_settings_get_ipriv ipriv = { + .selector = selector, + .type = type, + .get_all = (max_configs > 1), + .nr_configs = nr_configs, + .config_types = config_types, + .config_values = config_values, + }; + + if (!config_types || !config_values || type == FUNCTION_TYPE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + /* Prepare to count returned configs */ + *nr_configs = 0; + iter = ph->hops->iter_response_init(ph, &ops, max_configs, + PINCTRL_SETTINGS_GET, + sizeof(struct scmi_msg_settings_get), + &ipriv); + if (IS_ERR(iter)) + return PTR_ERR(iter); + + return ph->hops->iter_response_run(iter); +} + +static int scmi_pinctrl_settings_get_one(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value) +{ + unsigned int nr_configs = 1; + + return scmi_pinctrl_settings_get(ph, selector, type, &nr_configs, + &config_type, config_value); +} + +static int scmi_pinctrl_settings_get_all(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + unsigned int *nr_configs, + enum scmi_pinctrl_conf_type *config_types, + u32 *config_values) +{ + if (!nr_configs || *nr_configs == 0) + return -EINVAL; + + return scmi_pinctrl_settings_get(ph, selector, type, nr_configs, + config_types, config_values); +} + +static int +scmi_pinctrl_settings_conf(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + u32 nr_configs, + enum scmi_pinctrl_conf_type *config_type, + u32 *config_value) +{ + struct scmi_xfer *t; + struct scmi_msg_settings_conf *tx; + u32 attributes; + int ret, i; + u32 configs_in_chunk, conf_num = 0; + u32 chunk; + int max_msg_size = ph->hops->get_max_msg_size(ph); + + if (!config_type || !config_value || type == FUNCTION_TYPE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + configs_in_chunk = (max_msg_size - sizeof(*tx)) / (sizeof(__le32) * 2); + while (conf_num < nr_configs) { + chunk = (nr_configs - conf_num > configs_in_chunk) ? + configs_in_chunk : nr_configs - conf_num; + + ret = ph->xops->xfer_get_init(ph, PINCTRL_SETTINGS_CONFIGURE, + sizeof(*tx) + + chunk * 2 * sizeof(__le32), 0, &t); + if (ret) + break; + + tx = t->tx.buf; + tx->identifier = cpu_to_le32(selector); + tx->function_id = cpu_to_le32(0xFFFFFFFF); + attributes = FIELD_PREP(GENMASK(1, 0), type) | + FIELD_PREP(GENMASK(9, 2), chunk); + tx->attributes = cpu_to_le32(attributes); + + for (i = 0; i < chunk; i++) { + tx->configs[i * 2] = + cpu_to_le32(config_type[conf_num + i]); + tx->configs[i * 2 + 1] = + cpu_to_le32(config_value[conf_num + i]); + } + + ret = ph->xops->do_xfer(ph, t); + + ph->xops->xfer_put(ph, t); + + if (ret) + break; + + conf_num += chunk; + } + + return ret; +} + +static int scmi_pinctrl_function_select(const struct scmi_protocol_handle *ph, + u32 group, + enum scmi_pinctrl_selector_type type, + u32 function_id) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_settings_conf *tx; + u32 attributes; + + ret = scmi_pinctrl_validate_id(ph, group, type); + if (ret) + return ret; + + ret = ph->xops->xfer_get_init(ph, PINCTRL_SETTINGS_CONFIGURE, + sizeof(*tx), 0, &t); + if (ret) + return ret; + + tx = t->tx.buf; + tx->identifier = cpu_to_le32(group); + tx->function_id = cpu_to_le32(function_id); + attributes = FIELD_PREP(GENMASK(1, 0), type) | BIT(10); + tx->attributes = cpu_to_le32(attributes); + + ret = ph->xops->do_xfer(ph, t); + ph->xops->xfer_put(ph, t); + + return ret; +} + +static int scmi_pinctrl_request_free(const struct scmi_protocol_handle *ph, + u32 identifier, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_protocol_cmd cmd) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_request *tx; + + if (type == FUNCTION_TYPE) + return -EINVAL; + + if (cmd != PINCTRL_REQUEST && cmd != PINCTRL_RELEASE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, identifier, type); + if (ret) + return ret; + + ret = ph->xops->xfer_get_init(ph, cmd, sizeof(*tx), 0, &t); + if (ret) + return ret; + + tx = t->tx.buf; + tx->identifier = cpu_to_le32(identifier); + tx->flags = cpu_to_le32(type); + + ret = ph->xops->do_xfer(ph, t); + ph->xops->xfer_put(ph, t); + + return ret; +} + +static int scmi_pinctrl_pin_request(const struct scmi_protocol_handle *ph, + u32 pin) +{ + return scmi_pinctrl_request_free(ph, pin, PIN_TYPE, PINCTRL_REQUEST); +} + +static int scmi_pinctrl_pin_free(const struct scmi_protocol_handle *ph, u32 pin) +{ + return scmi_pinctrl_request_free(ph, pin, PIN_TYPE, PINCTRL_RELEASE); +} + +static int scmi_pinctrl_get_group_info(const struct scmi_protocol_handle *ph, + u32 selector, + struct scmi_group_info *group) +{ + int ret; + + ret = scmi_pinctrl_attributes(ph, GROUP_TYPE, selector, group->name, + &group->nr_pins); + if (ret) + return ret; + + if (!group->nr_pins) { + dev_err(ph->dev, "Group %d has 0 elements", selector); + return -ENODATA; + } + + group->group_pins = kmalloc_array(group->nr_pins, + sizeof(*group->group_pins), + GFP_KERNEL); + if (!group->group_pins) + return -ENOMEM; + + ret = scmi_pinctrl_list_associations(ph, selector, GROUP_TYPE, + group->nr_pins, group->group_pins); + if (ret) { + kfree(group->group_pins); + return ret; + } + + group->present = true; + return 0; +} + +static int scmi_pinctrl_get_group_name(const struct scmi_protocol_handle *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >= pi->nr_groups || pi->nr_groups == 0) + return -EINVAL; + + if (!pi->groups[selector].present) { + int ret; + + ret = scmi_pinctrl_get_group_info(ph, selector, + &pi->groups[selector]); + if (ret) + return ret; + } + + *name = pi->groups[selector].name; + + return 0; +} + +static int scmi_pinctrl_group_pins_get(const struct scmi_protocol_handle *ph, + u32 selector, const u32 **pins, + u32 *nr_pins) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!pins || !nr_pins) + return -EINVAL; + + if (selector >= pi->nr_groups || pi->nr_groups == 0) + return -EINVAL; + + if (!pi->groups[selector].present) { + int ret; + + ret = scmi_pinctrl_get_group_info(ph, selector, + &pi->groups[selector]); + if (ret) + return ret; + } + + *pins = pi->groups[selector].group_pins; + *nr_pins = pi->groups[selector].nr_pins; + + return 0; +} + +static int scmi_pinctrl_get_function_info(const struct scmi_protocol_handle *ph, + u32 selector, + struct scmi_function_info *func) +{ + int ret; + + ret = scmi_pinctrl_attributes(ph, FUNCTION_TYPE, selector, func->name, + &func->nr_groups); + if (ret) + return ret; + + if (!func->nr_groups) { + dev_err(ph->dev, "Function %d has 0 elements", selector); + return -ENODATA; + } + + func->groups = kmalloc_array(func->nr_groups, sizeof(*func->groups), + GFP_KERNEL); + if (!func->groups) + return -ENOMEM; + + ret = scmi_pinctrl_list_associations(ph, selector, FUNCTION_TYPE, + func->nr_groups, func->groups); + if (ret) { + kfree(func->groups); + return ret; + } + + func->present = true; + return 0; +} + +static int scmi_pinctrl_get_function_name(const struct scmi_protocol_handle *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >= pi->nr_functions || pi->nr_functions == 0) + return -EINVAL; + + if (!pi->functions[selector].present) { + int ret; + + ret = scmi_pinctrl_get_function_info(ph, selector, + &pi->functions[selector]); + if (ret) + return ret; + } + + *name = pi->functions[selector].name; + return 0; +} + +static int +scmi_pinctrl_function_groups_get(const struct scmi_protocol_handle *ph, + u32 selector, u32 *nr_groups, + const u32 **groups) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!groups || !nr_groups) + return -EINVAL; + + if (selector >= pi->nr_functions || pi->nr_functions == 0) + return -EINVAL; + + if (!pi->functions[selector].present) { + int ret; + + ret = scmi_pinctrl_get_function_info(ph, selector, + &pi->functions[selector]); + if (ret) + return ret; + } + + *groups = pi->functions[selector].groups; + *nr_groups = pi->functions[selector].nr_groups; + + return 0; +} + +static int scmi_pinctrl_mux_set(const struct scmi_protocol_handle *ph, + u32 selector, u32 group) +{ + return scmi_pinctrl_function_select(ph, group, GROUP_TYPE, selector); +} + +static int scmi_pinctrl_get_pin_info(const struct scmi_protocol_handle *ph, + u32 selector, struct scmi_pin_info *pin) +{ + int ret; + + if (!pin) + return -EINVAL; + + ret = scmi_pinctrl_attributes(ph, PIN_TYPE, selector, pin->name, NULL); + if (ret) + return ret; + + pin->present = true; + return 0; +} + +static int scmi_pinctrl_get_pin_name(const struct scmi_protocol_handle *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >= pi->nr_pins) + return -EINVAL; + + if (!pi->pins[selector].present) { + int ret; + + ret = scmi_pinctrl_get_pin_info(ph, selector, &pi->pins[selector]); + if (ret) + return ret; + } + + *name = pi->pins[selector].name; + + return 0; +} + +static int scmi_pinctrl_name_get(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + const char **name) +{ + switch (type) { + case PIN_TYPE: + return scmi_pinctrl_get_pin_name(ph, selector, name); + case GROUP_TYPE: + return scmi_pinctrl_get_group_name(ph, selector, name); + case FUNCTION_TYPE: + return scmi_pinctrl_get_function_name(ph, selector, name); + default: + return -EINVAL; + } +} + +static const struct scmi_pinctrl_proto_ops pinctrl_proto_ops = { + .count_get = scmi_pinctrl_count_get, + .name_get = scmi_pinctrl_name_get, + .group_pins_get = scmi_pinctrl_group_pins_get, + .function_groups_get = scmi_pinctrl_function_groups_get, + .mux_set = scmi_pinctrl_mux_set, + .settings_get_one = scmi_pinctrl_settings_get_one, + .settings_get_all = scmi_pinctrl_settings_get_all, + .settings_conf = scmi_pinctrl_settings_conf, + .pin_request = scmi_pinctrl_pin_request, + .pin_free = scmi_pinctrl_pin_free, +}; + +static int scmi_pinctrl_protocol_init(const struct scmi_protocol_handle *ph) +{ + int ret; + u32 version; + struct scmi_pinctrl_info *pinfo; + + ret = ph->xops->version_get(ph, &version); + if (ret) + return ret; + + dev_dbg(ph->dev, "Pinctrl Version %d.%d\n", + PROTOCOL_REV_MAJOR(version), PROTOCOL_REV_MINOR(version)); + + pinfo = devm_kzalloc(ph->dev, sizeof(*pinfo), GFP_KERNEL); + if (!pinfo) + return -ENOMEM; + + ret = scmi_pinctrl_attributes_get(ph, pinfo); + if (ret) + return ret; + + pinfo->pins = devm_kcalloc(ph->dev, pinfo->nr_pins, + sizeof(*pinfo->pins), GFP_KERNEL); + if (!pinfo->pins) + return -ENOMEM; + + pinfo->groups = devm_kcalloc(ph->dev, pinfo->nr_groups, + sizeof(*pinfo->groups), GFP_KERNEL); + if (!pinfo->groups) + return -ENOMEM; + + pinfo->functions = devm_kcalloc(ph->dev, pinfo->nr_functions, + sizeof(*pinfo->functions), GFP_KERNEL); + if (!pinfo->functions) + return -ENOMEM; + + pinfo->version = version; + + return ph->set_priv(ph, pinfo, version); +} + +static int scmi_pinctrl_protocol_deinit(const struct scmi_protocol_handle *ph) +{ + int i; + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + /* Free groups_pins allocated in scmi_pinctrl_get_group_info */ + for (i = 0; i < pi->nr_groups; i++) { + if (pi->groups[i].present) { + kfree(pi->groups[i].group_pins); + pi->groups[i].present = false; + } + } + + /* Free groups allocated in scmi_pinctrl_get_function_info */ + for (i = 0; i < pi->nr_functions; i++) { + if (pi->functions[i].present) { + kfree(pi->functions[i].groups); + pi->functions[i].present = false; + } + } + + return 0; +} + +static const struct scmi_protocol scmi_pinctrl = { + .id = SCMI_PROTOCOL_PINCTRL, + .owner = THIS_MODULE, + .instance_init = &scmi_pinctrl_protocol_init, + .instance_deinit = &scmi_pinctrl_protocol_deinit, + .ops = &pinctrl_proto_ops, + .supported_version = SCMI_PROTOCOL_SUPPORTED_VERSION, +}; +DEFINE_SCMI_PROTOCOL_REGISTER_UNREGISTER(pinctrl, scmi_pinctrl) diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_scmi/protocols.h index 3e91536a77a3..c02cbfd2bb03 100644 --- a/drivers/firmware/arm_scmi/protocols.h +++ b/drivers/firmware/arm_scmi/protocols.h @@ -355,6 +355,7 @@ void __exit scmi_##name##_unregister(void) \ DECLARE_SCMI_REGISTER_UNREGISTER(base); DECLARE_SCMI_REGISTER_UNREGISTER(clock); DECLARE_SCMI_REGISTER_UNREGISTER(perf); +DECLARE_SCMI_REGISTER_UNREGISTER(pinctrl); DECLARE_SCMI_REGISTER_UNREGISTER(power); DECLARE_SCMI_REGISTER_UNREGISTER(reset); DECLARE_SCMI_REGISTER_UNREGISTER(sensors); diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h index b807141acc14..5e75578706ce 100644 --- a/include/linux/scmi_protocol.h +++ b/include/linux/scmi_protocol.h @@ -737,6 +737,89 @@ struct scmi_powercap_proto_ops { u32 *power_thresh_high); }; +enum scmi_pinctrl_selector_type { + PIN_TYPE = 0, + GROUP_TYPE, + FUNCTION_TYPE, +}; + +enum scmi_pinctrl_conf_type { + SCMI_PIN_DEFAULT = 0, + SCMI_PIN_BIAS_BUS_HOLD = 1, + SCMI_PIN_BIAS_DISABLE = 2, + SCMI_PIN_BIAS_HIGH_IMPEDANCE = 3, + SCMI_PIN_BIAS_PULL_UP = 4, + SCMI_PIN_BIAS_PULL_DEFAULT = 5, + SCMI_PIN_BIAS_PULL_DOWN = 6, + SCMI_PIN_DRIVE_OPEN_DRAIN = 7, + SCMI_PIN_DRIVE_OPEN_SOURCE = 8, + SCMI_PIN_DRIVE_PUSH_PULL = 9, + SCMI_PIN_DRIVE_STRENGTH = 10, + SCMI_PIN_INPUT_DEBOUNCE = 11, + SCMI_PIN_INPUT_MODE = 12, + SCMI_PIN_PULL_MODE = 13, + SCMI_PIN_INPUT_VALUE = 14, + SCMI_PIN_INPUT_SCHMITT = 15, + SCMI_PIN_LOW_POWER_MODE = 16, + SCMI_PIN_OUTPUT_MODE = 17, + SCMI_PIN_OUTPUT_VALUE = 18, + SCMI_PIN_POWER_SOURCE = 19, + SCMI_PIN_SLEW_RATE = 20, + SCMI_PIN_OEM_START = 192, + SCMI_PIN_OEM_END = 255, +}; + +/** + * struct scmi_pinctrl_proto_ops - represents the various operations provided + * by SCMI Pinctrl Protocol + * + * @count_get: returns count of the registered elements in given type + * @name_get: returns name by index of given type + * @group_pins_get: returns the set of pins, assigned to the specified group + * @function_groups_get: returns the set of groups, assigned to the specified + * function + * @mux_set: set muxing function for groups of pins + * @settings_get_one: returns one configuration parameter for pin or group + * specified by config_type + * @settings_get_all: returns all configuration parameters for pin or group + * @settings_conf: sets the configuration parameter for pin or group + * @pin_request: aquire pin before selecting mux setting + * @pin_free: frees pin, acquired by request_pin call + */ +struct scmi_pinctrl_proto_ops { + int (*count_get)(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type); + int (*name_get)(const struct scmi_protocol_handle *ph, u32 selector, + enum scmi_pinctrl_selector_type type, + const char **name); + int (*group_pins_get)(const struct scmi_protocol_handle *ph, + u32 selector, const unsigned int **pins, + unsigned int *nr_pins); + int (*function_groups_get)(const struct scmi_protocol_handle *ph, + u32 selector, unsigned int *nr_groups, + const unsigned int **groups); + int (*mux_set)(const struct scmi_protocol_handle *ph, u32 selector, + u32 group); + int (*settings_get_one)(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value); + int (*settings_get_all)(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + unsigned int *nr_configs, + enum scmi_pinctrl_conf_type *config_types, + u32 *config_values); + int (*settings_conf)(const struct scmi_protocol_handle *ph, + u32 selector, enum scmi_pinctrl_selector_type type, + unsigned int nr_configs, + enum scmi_pinctrl_conf_type *config_type, + u32 *config_value); + int (*pin_request)(const struct scmi_protocol_handle *ph, u32 pin); + int (*pin_free)(const struct scmi_protocol_handle *ph, u32 pin); +}; + /** * struct scmi_notify_ops - represents notifications' operations provided by * SCMI core @@ -844,6 +927,7 @@ enum scmi_std_protocol { SCMI_PROTOCOL_RESET = 0x16, SCMI_PROTOCOL_VOLTAGE = 0x17, SCMI_PROTOCOL_POWERCAP = 0x18, + SCMI_PROTOCOL_PINCTRL = 0x19, }; enum scmi_system_events { From patchwork Fri Apr 5 01:59:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13618358 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E4CACD1284 for ; Fri, 5 Apr 2024 01:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=702FgFzXO0ouJU1tl1LMstwkBMVxw2TwN98CyVUCRJs=; b=QmT1vnxPN6GjsY9GRoBLSRHdjR uDfN/1sDPv5DM66a5tUaxigpjblX7jxc+BzwqGJQSpKrJXZvuoFM7Ae3TOQDHS1mnkUcTFcs6b4S7 xP39wEx5EdqRWpOxEzy4TJah0wtzEzxLEZFVieNPYTgmkkP5f/aq1gxLZ0Iwr5mXsIvYsSontFI1R TlDAMROEId+vkGQUL0X6AqidAGa0MGeA/pn/uAQhWd9AOEntTTXDAid15tzsGlBRjQsX8rd+xfB8D aiUEDZ7aagFTKxACe1SJiy+/lLCQO4/2abooqIVkTNhpaqmgd0oo0KY2bWDFXyDvGeEXnILLyobRb 2bl5DIPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsYkG-00000004qif-2WTa; Fri, 05 Apr 2024 01:51:56 +0000 Received: from mail-am0eur02on20700.outbound.protection.outlook.com ([2a01:111:f403:2606::700] helo=EUR02-AM0-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsYk9-00000004qar-0S5Y for linux-arm-kernel@lists.infradead.org; Fri, 05 Apr 2024 01:51:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hCBF/5QJY7FpawfVVAfJNFjHw+fE0u1R6BxsQ+eXWXRnBL2MFoA4bcTDT+dss2HQEwB5awhvhEFhaqsOrFFmI7IHEErvtcPb4uX/Snv1EBeKMWmxSf3wr9HfCtKAGVJXmj14qneVJxjBQN+WK90xrVxQhq9m9NpsLzx46ERIProjwvgzQ0cPEQyL/YJC85uHuZgCyVtXhvQ0X/wJ0AjvgI3rHmWBVP5Rwav8oXX1mO3j1SFTyxB0lfitSnpWpODjVFx9kaNOVSozb30AqSi335bgQCs3/hLgmPXnuPQB64PDaJOFccShAX9PsSiBCjMQ+08wJ7kEQswYLfIZBsYmdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UZpY0FB4CcuIWdsXFpbNhSUGvrVt0Nr/jyeCFpYOnlU=; b=eWTcZDeQHUweCZDq39zaQUpD+FJlO5o+hkgDx5Fu2g+n/yop0Wyvgb8vkhRy/Ve18zf51jZlq7w3wHDMVkmNCJWPmC01iwAij8BFzSxTH4P0hjZI4Vb8xYH27UXfcMPPik9z3HWNggljTbf/vRE4Q5iUx9fZzTaQekPIzX4kb9zSso32fEG2O1SdRiy80mSchEBho7tEPbqHjKlVU2UqyhLI2HtzPL2A6QLfS4gOUNWUKpzu0krWjtCCfouzDgp2hAIwJq/TbgmpIlOfqkt4Iay1RFWbB2+EY0D9Aj35CltvZlKQzpS/QJg6DIKmHbnWePPKXiBw6sjycBmR5s8Vvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZpY0FB4CcuIWdsXFpbNhSUGvrVt0Nr/jyeCFpYOnlU=; b=IkKhv8iNwoI7+0Z0B61oZZjYYL1/S9Df6IWgIaJZLhio45vgFYsEaYnXVc51KQ/QWxdAi5WnceYGVPO5j5xWQ1b4Z/qTo4kvhzM8hFuAj3it6f4BlQ+WkbmveOrvwJAljxSPshipJstvjEjmPymE/XEMoOvSrDuqiGmorxTMttY= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS1PR04MB9334.eurprd04.prod.outlook.com (2603:10a6:20b:4de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 5 Apr 2024 01:51:46 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 5 Apr 2024 01:51:46 +0000 From: "Peng Fan (OSS)" Date: Fri, 05 Apr 2024 09:59:35 +0800 Subject: [PATCH v8 4/4] pinctrl: Implementation of the generic scmi-pinctrl driver Message-Id: <20240405-pinctrl-scmi-v8-4-5fc8e33871bf@nxp.com> References: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> In-Reply-To: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712282385; l=18244; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=AbjpOrl7yBEnYMIcYlspNvfej90dVHj0Zx/z0qnvcvQ=; b=ppGhd76dTZEbiyARreRonhXafGAg20CJ4XP2TdkrqCVpeuwmYv61D36/rCLAhxy3FBvOFNBA3 vnmrWFGfFmpCRqkJI+GOjQYTbIRMxUqwOCZxX0mvw8EJf7SM7hNW1A7 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS1PR04MB9334:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oCkjkrW78NNUQeHAbYkoEh36bmn/Gc6Lc2Bm9sc23UEvlkBJ9J3AOR5Iw+c+0lyRweNAu05g+ihAjO9IoxeCL1MAWwrAtaryY8O3KdYqADe9wMz8DIZ4vd+ZRFjol+ICCcebRv0dqQIMJc8KQ+NjRgr/fT8gYK1o9vpaI44ne5Cv+r713RiVrH5Gn+7uIOF0j0lyYxHbAED3uEhmOkVN7/R8AAgvxWwFnVn6lDQ6WGII2lBom+KvPSy7wd/YARDJcIAiDYQhEDO1rlt4j2NCN1eM7cgNej+Ti3ckdKqlVF4VFUI0sqwVk2C0yeGXarcK9Ml4scO4Nl4ud2Lx1SmTKscaQz/xvxu14OHRq5Qmd8tstRp9bBPBEsF+17aWMGGtUxsekGnB9JzhfV7Y3mmHPwVRQw764BFzPqdRfD4+1iahaNpp4+X8weJTxaVnjl2Ewee6KvOpescdgPv16vFxVV3HfNyOR2FyiswzoBMk/m99uLOoZt7GN4s9daWmTvG1jG5FJ775cJVjs6I9orkwDyPeJfj/fV7DvJI2vdyyFgxVB4Ck16ikXg1et51AkHXpFihqkUdgfBeckTtcb+yXnreoV7TpwkbFZHjEiEM2foZhm/CXw6VNHsn4TiVpyWfzaTYROWk3E3WIttXqcsd/5XdGYGiZj8MI1kmLR5dk0EN0HIMod9wvvCH8oTbyUOvGp9nj4KMnS0J5M1J/R4taw1ceraoo2jzVb/F4LUH3AOg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(7416005)(52116005)(376005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?gPvCXjDXeIEA8LOoS/dyCCQPgL7H?= =?utf-8?q?60+oXrup4Iw3unhkmV9UZ3B9+t85m/MtZLk2ec0lngMUdZ6ZUbglkgXlxlha9D/7H?= =?utf-8?q?MbbEQJn+DNzqJ8anY/E7yI9hYk2h8PpLDyBF7aR9NMBiRh5L+qS4fyAunNS7fCG25?= =?utf-8?q?AVf4m0GTcCSpALuaXS4eSbVWf2B5A2J1U0KJWg1IczvdZahiwH5WVIlaqmTwfTmPe?= =?utf-8?q?x1d4RicuTntmS1LW80hH7fmkDZFRGvHBogzGOoJAeN48AU4IQxKOBQ4yICZz7JlYv?= =?utf-8?q?qR0aHN4zd3GgtIdddWg3AQdOl0BGNRJMg4RYSdc4sD2Uzwovz4PYW4rBwX2Al8+yR?= =?utf-8?q?LINoD0rDsjDtiw6PnWRKgitlfLp0DfED0bhEMdAND4bEsd8gW0ARysJ6QvNfIY442?= =?utf-8?q?rs45umPO6anNX+dqUOy27VDQlu1SeFhTaPE9b7TmnnMTui8/mFrKrenLMRFvn5Ke5?= =?utf-8?q?cCVYbgV0DuxLYidjpVLBw9/fqwGbuqRMfp9vVEPgFJeDBNxQTWsXoReNpM/izLGwR?= =?utf-8?q?Unh9SbeQKd1NqoEbep/3KMGZDvNQBKjxNxmetHBdncQVl0d2olfZ93tPlWMxY2w1j?= =?utf-8?q?ZrIPQR3Zuk39zHKgSsq7NOkigQ1zmzxESMN/TqhFVuIZeGGx1KfavKNkEaQbT7/s8?= =?utf-8?q?YbrlXBXJ4W+csFgRCOAWd6czuo1zG7enk32aaa6Jaf5fc53m1V/gMkhMdl9MVUZA4?= =?utf-8?q?tGxmJhE3iVGqMmBN6nGkFPEJisefjD+p/+w7mWMgxo24SjOEKkUQ6UV6lKVk84gQJ?= =?utf-8?q?wqGqpbLlb/alPnK/kVWuOYzH3dfExX3n8xq1HO4dfa2NfSlOYyR5W8BQ14OhxKefZ?= =?utf-8?q?FioJ9i+STfCZSQfhZNIF1HTRKh2NZXBOOWfOFlWSdeSw2nP3Ln8SfJGTVQMEIRLWH?= =?utf-8?q?5pz9pgQgh/5Ja++8fUCAv375JkONLHn913eQ6wUIdWMkBZOISAEpqqMK+s7wFGnBZ?= =?utf-8?q?wDb5zcxdtT1xAyenq4FOvvTUEs3niyDXzrdV3jC1wBDyYguNtbxGb3qqpbK0hxa0V?= =?utf-8?q?psbvG3358KcElz+8GmblBR19jC+J0Z21ztN9pBjTr1yWwidNMqIwMSAwlAoKzaHdw?= =?utf-8?q?UN9owcbNpIxX0ttefUMFFe4CJfoURwkqSn6HDKa1LItDgL6/JGz2rfEgmpZpwZDLn?= =?utf-8?q?qvXw804u/CNmgHV/BvkkzSu4zGbQcGilJq2I3D+eGFjxLe4+AyUXmeOHEynee1SQH?= =?utf-8?q?3Eco2XmINzVh4yYRdN+Z1yui5S7wVPdDIdUsuFJGqf998WOkJgEkSMmhixOQb825i?= =?utf-8?q?jjrmsKzgmv9h8edR9FbMUlsmCFk/uqt7gODdKuHVeLzAH89vhnbFs8MxNwFFvBYT0?= =?utf-8?q?2W/8m9WBPUsm8GO3x+ciyVPEntg8qZPU2mzhFbDTiDFTEluQTaKHNnVhq3Sb+dDE7?= =?utf-8?q?izi4jz12F8BcL49ZCJabwV5BCZq9mj6Bb63QYR44QKNytNakPEkhjLci5MoUORt+7?= =?utf-8?q?IP0bVHUobVPRHffrKuufVxgj7wFpM7LQkh2pVo+AeIWbPTcBduShftfj1Tlz4PONc?= =?utf-8?q?DAGzMr2i3DoM?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73bef76d-0b8b-4708-b218-08dc5512f3b6 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 01:51:46.8209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w0MSOLuC7n7qalFSpMtYjkt1NeVI/0u+kUfyBbO9WduhCA2e6Luk4sZszMldsGlRcTqzup/v+HYkHMaOyn+41g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9334 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_185149_478134_13E76717 X-CRM114-Status: GOOD ( 18.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan scmi-pinctrl driver implements pinctrl driver interface and using SCMI protocol to redirect messages from pinctrl subsystem SDK to SCMI platform firmware, which does the changes in HW. Co-developed-by: Oleksii Moisieiev Signed-off-by: Oleksii Moisieiev Signed-off-by: Peng Fan Reviewed-by: Dhruva Gole --- MAINTAINERS | 1 + drivers/pinctrl/Kconfig | 11 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-scmi.c | 564 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 577 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4b511a55101c..d8270ac6651a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21457,6 +21457,7 @@ F: drivers/cpufreq/sc[mp]i-cpufreq.c F: drivers/firmware/arm_scmi/ F: drivers/firmware/arm_scpi.c F: drivers/hwmon/scmi-hwmon.c +F: drivers/pinctrl/pinctrl-scmi.c F: drivers/pmdomain/arm/ F: drivers/powercap/arm_scmi_powercap.c F: drivers/regulator/scmi-regulator.c diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index d45657aa986a..4e6f65cf0e76 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -450,6 +450,17 @@ config PINCTRL_ROCKCHIP help This support pinctrl and GPIO driver for Rockchip SoCs. +config PINCTRL_SCMI + tristate "Pinctrl driver using SCMI protocol interface" + depends on ARM_SCMI_PROTOCOL || COMPILE_TEST + select PINMUX + select GENERIC_PINCONF + help + This driver provides support for pinctrl which is controlled + by firmware that implements the SCMI interface. + It uses SCMI Message Protocol to interact with the + firmware providing all the pinctrl controls. + config PINCTRL_SINGLE tristate "One-register-per-pin type device tree based pinctrl driver" depends on OF diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index 2152539b53d5..cc809669405a 100644 --- a/drivers/pinctrl/Makefile +++ b/drivers/pinctrl/Makefile @@ -45,6 +45,7 @@ obj-$(CONFIG_PINCTRL_PIC32) += pinctrl-pic32.o obj-$(CONFIG_PINCTRL_PISTACHIO) += pinctrl-pistachio.o obj-$(CONFIG_PINCTRL_RK805) += pinctrl-rk805.o obj-$(CONFIG_PINCTRL_ROCKCHIP) += pinctrl-rockchip.o +obj-$(CONFIG_PINCTRL_SCMI) += pinctrl-scmi.o obj-$(CONFIG_PINCTRL_SINGLE) += pinctrl-single.o obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o obj-$(CONFIG_PINCTRL_STMFX) += pinctrl-stmfx.o diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c new file mode 100644 index 000000000000..0f55f000a679 --- /dev/null +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -0,0 +1,564 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * System Control and Power Interface (SCMI) Protocol based pinctrl driver + * + * Copyright (C) 2024 EPAM + * Copyright 2024 NXP + */ + +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#include "pinctrl-utils.h" +#include "core.h" +#include "pinconf.h" + +#define DRV_NAME "scmi-pinctrl" + +/* Define num configs, if not large than 4 use stack, else use kcalloc */ +#define SCMI_NUM_CONFIGS 4 + +static const struct scmi_pinctrl_proto_ops *pinctrl_ops; + +struct scmi_pinctrl { + struct device *dev; + struct scmi_protocol_handle *ph; + struct pinctrl_dev *pctldev; + struct pinctrl_desc pctl_desc; + struct pinfunction *functions; + unsigned int nr_functions; + struct pinctrl_pin_desc *pins; + unsigned int nr_pins; +}; + +static int pinctrl_scmi_get_groups_count(struct pinctrl_dev *pctldev) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->count_get(pmx->ph, GROUP_TYPE); +} + +static const char *pinctrl_scmi_get_group_name(struct pinctrl_dev *pctldev, + unsigned int selector) +{ + int ret; + const char *name; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + ret = pinctrl_ops->name_get(pmx->ph, selector, GROUP_TYPE, &name); + if (ret) { + dev_err(pmx->dev, "get name failed with err %d", ret); + return NULL; + } + + return name; +} + +static int pinctrl_scmi_get_group_pins(struct pinctrl_dev *pctldev, + unsigned int selector, + const unsigned int **pins, + unsigned int *num_pins) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->group_pins_get(pmx->ph, selector, pins, num_pins); +} + +static const struct pinctrl_ops pinctrl_scmi_pinctrl_ops = { + .get_groups_count = pinctrl_scmi_get_groups_count, + .get_group_name = pinctrl_scmi_get_group_name, + .get_group_pins = pinctrl_scmi_get_group_pins, +#ifdef CONFIG_OF + .dt_node_to_map = pinconf_generic_dt_node_to_map_all, + .dt_free_map = pinconf_generic_dt_free_map, +#endif +}; + +static int pinctrl_scmi_get_functions_count(struct pinctrl_dev *pctldev) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->count_get(pmx->ph, FUNCTION_TYPE); +} + +static const char *pinctrl_scmi_get_function_name(struct pinctrl_dev *pctldev, + unsigned int selector) +{ + int ret; + const char *name; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + ret = pinctrl_ops->name_get(pmx->ph, selector, FUNCTION_TYPE, &name); + if (ret) { + dev_err(pmx->dev, "get name failed with err %d", ret); + return NULL; + } + + return name; +} + +static int pinctrl_scmi_get_function_groups(struct pinctrl_dev *pctldev, + unsigned int selector, + const char * const **p_groups, + unsigned int * const p_num_groups) +{ + struct pinfunction *func; + const unsigned int *group_ids; + unsigned int num_groups; + const char **groups; + int ret, i; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + if (!p_groups || !p_num_groups) + return -EINVAL; + + if (selector >= pmx->nr_functions) + return -EINVAL; + + func = &pmx->functions[selector]; + if (func->ngroups) + goto done; + + ret = pinctrl_ops->function_groups_get(pmx->ph, selector, &num_groups, + &group_ids); + if (ret) { + dev_err(pmx->dev, "Unable to get function groups, err %d", ret); + return ret; + } + if (!num_groups) + return -EINVAL; + + groups = kcalloc(num_groups, sizeof(*groups), GFP_KERNEL); + if (!groups) + return -ENOMEM; + + for (i = 0; i < num_groups; i++) { + groups[i] = pinctrl_scmi_get_group_name(pctldev, group_ids[i]); + if (!groups[i]) { + ret = -EINVAL; + goto err_free; + } + } + + func->ngroups = num_groups; + func->groups = groups; +done: + *p_groups = func->groups; + *p_num_groups = func->ngroups; + + return 0; + +err_free: + kfree(groups); + + return ret; +} + +static int pinctrl_scmi_func_set_mux(struct pinctrl_dev *pctldev, + unsigned int selector, unsigned int group) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->mux_set(pmx->ph, selector, group); +} + +static int pinctrl_scmi_request(struct pinctrl_dev *pctldev, + unsigned int offset) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->pin_request(pmx->ph, offset); +} + +static int pinctrl_scmi_free(struct pinctrl_dev *pctldev, unsigned int offset) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->pin_free(pmx->ph, offset); +} + +static const struct pinmux_ops pinctrl_scmi_pinmux_ops = { + .request = pinctrl_scmi_request, + .free = pinctrl_scmi_free, + .get_functions_count = pinctrl_scmi_get_functions_count, + .get_function_name = pinctrl_scmi_get_function_name, + .get_function_groups = pinctrl_scmi_get_function_groups, + .set_mux = pinctrl_scmi_func_set_mux, +}; + +static int pinctrl_scmi_map_pinconf_type(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + u32 arg = param; + + switch (arg) { + case PIN_CONFIG_BIAS_BUS_HOLD: + *type = SCMI_PIN_BIAS_BUS_HOLD; + break; + case PIN_CONFIG_BIAS_DISABLE: + *type = SCMI_PIN_BIAS_DISABLE; + break; + case PIN_CONFIG_BIAS_HIGH_IMPEDANCE: + *type = SCMI_PIN_BIAS_HIGH_IMPEDANCE; + break; + case PIN_CONFIG_BIAS_PULL_DOWN: + *type = SCMI_PIN_BIAS_PULL_DOWN; + break; + case PIN_CONFIG_BIAS_PULL_PIN_DEFAULT: + *type = SCMI_PIN_BIAS_PULL_DEFAULT; + break; + case PIN_CONFIG_BIAS_PULL_UP: + *type = SCMI_PIN_BIAS_PULL_UP; + break; + case PIN_CONFIG_DRIVE_OPEN_DRAIN: + *type = SCMI_PIN_DRIVE_OPEN_DRAIN; + break; + case PIN_CONFIG_DRIVE_OPEN_SOURCE: + *type = SCMI_PIN_DRIVE_OPEN_SOURCE; + break; + case PIN_CONFIG_DRIVE_PUSH_PULL: + *type = SCMI_PIN_DRIVE_PUSH_PULL; + break; + case PIN_CONFIG_DRIVE_STRENGTH: + *type = SCMI_PIN_DRIVE_STRENGTH; + break; + case PIN_CONFIG_DRIVE_STRENGTH_UA: + *type = SCMI_PIN_DRIVE_STRENGTH; + break; + case PIN_CONFIG_INPUT_DEBOUNCE: + *type = SCMI_PIN_INPUT_DEBOUNCE; + break; + case PIN_CONFIG_INPUT_ENABLE: + *type = SCMI_PIN_INPUT_MODE; + break; + case PIN_CONFIG_INPUT_SCHMITT: + *type = SCMI_PIN_INPUT_SCHMITT; + break; + case PIN_CONFIG_INPUT_SCHMITT_ENABLE: + *type = SCMI_PIN_INPUT_MODE; + break; + case PIN_CONFIG_MODE_LOW_POWER: + *type = SCMI_PIN_LOW_POWER_MODE; + break; + case PIN_CONFIG_OUTPUT: + *type = SCMI_PIN_OUTPUT_VALUE; + break; + case PIN_CONFIG_OUTPUT_ENABLE: + *type = SCMI_PIN_OUTPUT_MODE; + break; + case PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS: + *type = SCMI_PIN_OUTPUT_VALUE; + break; + case PIN_CONFIG_POWER_SOURCE: + *type = SCMI_PIN_POWER_SOURCE; + break; + case PIN_CONFIG_SLEW_RATE: + *type = SCMI_PIN_SLEW_RATE; + break; + case SCMI_PIN_OEM_START ... SCMI_PIN_OEM_END: + *type = arg; + break; + default: + return -EINVAL; + } + + return 0; +} + +static int pinctrl_scmi_pinconf_get(struct pinctrl_dev *pctldev, + unsigned int pin, unsigned long *config) +{ + int ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum pin_config_param config_type; + enum scmi_pinctrl_conf_type type; + u32 config_value; + + if (!config) + return -EINVAL; + + config_type = pinconf_to_config_param(*config); + + ret = pinctrl_scmi_map_pinconf_type(config_type, &type); + if (ret) + return ret; + + ret = pinctrl_ops->settings_get_one(pmx->ph, pin, PIN_TYPE, type, + &config_value); + if (ret) + return ret; + + *config = pinconf_to_config_packed(config_type, config_value); + + return 0; +} + +static int +pinctrl_scmi_alloc_configs(struct pinctrl_dev *pctldev, u32 num_configs, + u32 **p_config_value, + enum scmi_pinctrl_conf_type **p_config_type) +{ + if (num_configs <= SCMI_NUM_CONFIGS) + return 0; + + *p_config_value = kcalloc(num_configs, sizeof(**p_config_value), GFP_KERNEL); + if (!*p_config_value) + return -ENOMEM; + + *p_config_type = kcalloc(num_configs, sizeof(**p_config_type), GFP_KERNEL); + if (!*p_config_type) { + kfree(*p_config_value); + return -ENOMEM; + } + + return 0; +} + +static void +pinctrl_scmi_free_configs(struct pinctrl_dev *pctldev, u32 num_configs, + u32 **p_config_value, + enum scmi_pinctrl_conf_type **p_config_type) +{ + if (num_configs <= SCMI_NUM_CONFIGS) + return; + + kfree(*p_config_value); + kfree(*p_config_type); +} + +static int pinctrl_scmi_pinconf_set(struct pinctrl_dev *pctldev, + unsigned int pin, + unsigned long *configs, + unsigned int num_configs) +{ + int i, ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; + u32 config_value[SCMI_NUM_CONFIGS]; + enum scmi_pinctrl_conf_type *p_config_type = config_type; + u32 *p_config_value = config_value; + enum pin_config_param param; + + if (!configs || !num_configs) + return -EINVAL; + + ret = pinctrl_scmi_alloc_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + if (ret) + return ret; + + for (i = 0; i < num_configs; i++) { + param = pinconf_to_config_param(configs[i]); + ret = pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + goto free_config; + } + p_config_value[i] = pinconf_to_config_argument(configs[i]); + } + + ret = pinctrl_ops->settings_conf(pmx->ph, pin, PIN_TYPE, num_configs, + p_config_type, p_config_value); + if (ret) + dev_err(pmx->dev, "Error parsing config %d\n", ret); + +free_config: + pinctrl_scmi_free_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + return ret; +} + +static int pinctrl_scmi_pinconf_group_set(struct pinctrl_dev *pctldev, + unsigned int group, + unsigned long *configs, + unsigned int num_configs) +{ + int i, ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; + u32 config_value[SCMI_NUM_CONFIGS]; + enum scmi_pinctrl_conf_type *p_config_type = config_type; + u32 *p_config_value = config_value; + enum pin_config_param param; + + if (!configs || !num_configs) + return -EINVAL; + + ret = pinctrl_scmi_alloc_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + if (ret) + return ret; + + for (i = 0; i < num_configs; i++) { + param = pinconf_to_config_param(configs[i]); + ret = pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + goto free_config; + } + + p_config_value[i] = pinconf_to_config_argument(configs[i]); + } + + ret = pinctrl_ops->settings_conf(pmx->ph, group, GROUP_TYPE, + num_configs, p_config_type, + p_config_value); + if (ret) + dev_err(pmx->dev, "Error parsing config %d", ret); + +free_config: + pinctrl_scmi_free_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + return ret; +}; + +static int pinctrl_scmi_pinconf_group_get(struct pinctrl_dev *pctldev, + unsigned int group, + unsigned long *config) +{ + int ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum pin_config_param config_type; + enum scmi_pinctrl_conf_type type; + u32 config_value; + + if (!config) + return -EINVAL; + + config_type = pinconf_to_config_param(*config); + ret = pinctrl_scmi_map_pinconf_type(config_type, &type); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + return ret; + } + + ret = pinctrl_ops->settings_get_one(pmx->ph, group, GROUP_TYPE, type, + &config_value); + if (ret) + return ret; + + *config = pinconf_to_config_packed(config_type, config_value); + + return 0; +} + +static const struct pinconf_ops pinctrl_scmi_pinconf_ops = { + .is_generic = true, + .pin_config_get = pinctrl_scmi_pinconf_get, + .pin_config_set = pinctrl_scmi_pinconf_set, + .pin_config_group_set = pinctrl_scmi_pinconf_group_set, + .pin_config_group_get = pinctrl_scmi_pinconf_group_get, + .pin_config_config_dbg_show = pinconf_generic_dump_config, +}; + +static int pinctrl_scmi_get_pins(struct scmi_pinctrl *pmx, + struct pinctrl_desc *desc) +{ + struct pinctrl_pin_desc *pins; + unsigned int npins; + int ret, i; + + npins = pinctrl_ops->count_get(pmx->ph, PIN_TYPE); + /* + * npins will never be zero, the scmi pinctrl driver has bailed out + * if npins is zero. + */ + pins = devm_kmalloc_array(pmx->dev, npins, sizeof(*pins), GFP_KERNEL); + if (!pins) + return -ENOMEM; + + for (i = 0; i < npins; i++) { + pins[i].number = i; + /* + * The memory for name is handled by the scmi firmware driver, + * no need free here + */ + ret = pinctrl_ops->name_get(pmx->ph, i, PIN_TYPE, &pins[i].name); + if (ret) + return dev_err_probe(pmx->dev, ret, + "Can't get name for pin %d", i); + } + + desc->npins = npins; + desc->pins = pins; + dev_dbg(pmx->dev, "got pins %u", npins); + + return 0; +} + +static int scmi_pinctrl_probe(struct scmi_device *sdev) +{ + int ret; + struct device *dev = &sdev->dev; + struct scmi_pinctrl *pmx; + const struct scmi_handle *handle; + struct scmi_protocol_handle *ph; + + if (!sdev->handle) + return -EINVAL; + + handle = sdev->handle; + + pinctrl_ops = handle->devm_protocol_get(sdev, SCMI_PROTOCOL_PINCTRL, &ph); + if (IS_ERR(pinctrl_ops)) + return PTR_ERR(pinctrl_ops); + + pmx = devm_kzalloc(dev, sizeof(*pmx), GFP_KERNEL); + if (!pmx) + return -ENOMEM; + + pmx->ph = ph; + + pmx->dev = dev; + pmx->pctl_desc.name = DRV_NAME; + pmx->pctl_desc.owner = THIS_MODULE; + pmx->pctl_desc.pctlops = &pinctrl_scmi_pinctrl_ops; + pmx->pctl_desc.pmxops = &pinctrl_scmi_pinmux_ops; + pmx->pctl_desc.confops = &pinctrl_scmi_pinconf_ops; + + ret = pinctrl_scmi_get_pins(pmx, &pmx->pctl_desc); + if (ret) + return ret; + + ret = devm_pinctrl_register_and_init(dev, &pmx->pctl_desc, pmx, + &pmx->pctldev); + if (ret) + return dev_err_probe(dev, ret, "Failed to register pinctrl\n"); + + pmx->nr_functions = pinctrl_scmi_get_functions_count(pmx->pctldev); + pmx->functions = devm_kcalloc(dev, pmx->nr_functions, + sizeof(*pmx->functions), GFP_KERNEL); + if (!pmx->functions) + return -ENOMEM; + + return pinctrl_enable(pmx->pctldev); +} + +static const struct scmi_device_id scmi_id_table[] = { + { SCMI_PROTOCOL_PINCTRL, "pinctrl" }, + { } +}; +MODULE_DEVICE_TABLE(scmi, scmi_id_table); + +static struct scmi_driver scmi_pinctrl_driver = { + .name = DRV_NAME, + .probe = scmi_pinctrl_probe, + .id_table = scmi_id_table, +}; +module_scmi_driver(scmi_pinctrl_driver); + +MODULE_AUTHOR("Oleksii Moisieiev "); +MODULE_AUTHOR("Peng Fan "); +MODULE_DESCRIPTION("ARM SCMI pin controller driver"); +MODULE_LICENSE("GPL");