From patchwork Sat Apr 6 01:22:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13619634 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EE55947E for ; Sat, 6 Apr 2024 01:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366543; cv=none; b=CLpjbd6R7N3g9Qpbsd5cI7uM5eLJkuKW8xhWBqPmCdNdWh8vfGtuI9zI8QvdvyRRomFKrFXOlIXfc3qDAbaEWOX3tBwCkOYUh6Ftcp0XQNSlvi1hCqFluoYU3CyGg00LOa5DRZXltWr1q7zS+LO044tyWfmzOW45YFWqkqYbqr0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366543; c=relaxed/simple; bh=vcQ6z8+A5Fqbco8sFxdrFU/OO8em9qflDOvoMhGUbVY=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=s3SM9pFZganwZitUhb2X/IQL5r4qCA1VELgKB06az0Sn5Ds39KQiWMp73+f9CrSEaxQia74th1vXPI996J3blT62CezNbxL1okybx0ecE/v5AgXFt3GhfFgFWz7N1nDfv2d7om1s5r0xzQ22wbvAdPdPAK8pz6Quv6nLdGK62Ww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MNErc9u4; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MNErc9u4" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4163a8bd184so112085e9.2 for ; Fri, 05 Apr 2024 18:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712366539; x=1712971339; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=nj17tucsBUGbyNmeNwAY/DnKxGauoSiyw/ZPtBvyark=; b=MNErc9u4MXrojiw2oQukDuTnvEmttgZj+EDTaXWBSUecxzLyAu6B9YO2f6M4dGb55n SC+00dzS88GcIyEGqRcC3589QCC5lsi5erQZXi2NC9cQkuJZNK0GHkzLXN/1I+IrUq0n Ic62PqLWmbn5WX1EYvV/QztBtKJJwviFQ1KLm43Np8t21n0UACPysJIb+wT5T1O2Gjed a1qR6KPiMmdZB/k4rItonZgt+owJMZVhVXvTKT/va1DAajdWx6M3R/2HjUYnMJ1UbajY ADYTmrbc0laejiz83usbFgwohYbEzhXUoHdhWKMS+mUA1OAHVufpgcG/B1xn21e9gQth Ilbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712366539; x=1712971339; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nj17tucsBUGbyNmeNwAY/DnKxGauoSiyw/ZPtBvyark=; b=GI2o+ahixN6HVkQPqmYm1h4z7TdHD34poagh09TXGP9WwwTwmGDsf9VWYMwjZy7/f3 SsXzDQ3PYA1MrCG5+03ORN1Y6ZsXpX3Z8/+MkFeZ2qwR5y9cNBaKk0a7DueZGfJ6MWY/ OAuolCwcmOatBTI8c3AZQpYOAeT5AkbNegwDmOcX2XzHZ/83doSqRpQ1gSC6VOHQ2XWR TNkxUBlbUP+fEnI4aYETfs0vicjYmt45755Lt326miF/JWe1Kl+3cce7vuZyjy1ZbNo2 mtHPfiXK+ySjbOuxKBMI3XybouhOI/pLsBgVk0sJMKNUuKw6pm0ZHABXXmaD/quPXLIX ynfA== X-Gm-Message-State: AOJu0YwEDZmI/aHp0Aw58j3kPIzs8T4nXu26ulTl/oFzAZf/QUKv2yqa QKhEQ052IoCAGMmcmdJ16hyquEZKG39AW8+EdQkFge8ulT4TusgpMrVeS9dJ X-Google-Smtp-Source: AGHT+IFNqUSpanozjx1ykeyZHiXjhnA7SSVaIOBx9gfKPebYykJgcyBxQP+BviPh1TkWzb9umUevhw== X-Received: by 2002:a05:600c:3583:b0:414:216:2cd1 with SMTP id p3-20020a05600c358300b0041402162cd1mr2259767wmq.5.1712366538630; Fri, 05 Apr 2024 18:22:18 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id q18-20020a05600c46d200b00414659ba8c2sm4718603wmo.37.2024.04.05.18.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 18:22:18 -0700 (PDT) Message-Id: <3817e7f3cd007fe26b8bfdec6babed1c17ec3795.1712366536.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Sat, 06 Apr 2024 01:22:09 +0000 Subject: [PATCH v2 1/8] MyFirstContribution: mention contrib/contacts/git-contacts Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Although we've had this script since 4d06402b1b (contrib: add git-contacts helper, 2013-07-21), we don't mention it in our introductory docs. Do so now. Signed-off-by: Linus Arver --- Documentation/MyFirstContribution.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt index f06563e9817..ad3989f53e5 100644 --- a/Documentation/MyFirstContribution.txt +++ b/Documentation/MyFirstContribution.txt @@ -1116,6 +1116,11 @@ $ git send-email --to=target@example.com psuh/*.patch NOTE: Check `git help send-email` for some other options which you may find valuable, such as changing the Reply-to address or adding more CC and BCC lines. +NOTE: Use `contrib/contacts/git-contacts` to get a list of reviewers you should +include in the CC list. In addition, you can do `git send-email --cc-cmd='git +contacts' feature/*.patch` to automatically pass this list of emails to +`send-email`. + NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but please don't send your patchset from the tutorial to the real mailing list! For now, you can send it to yourself, to make sure you understand how it will look. From patchwork Sat Apr 6 01:22:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13619635 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1CC8BE58 for ; Sat, 6 Apr 2024 01:22:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366544; cv=none; b=IHOPs5AJGUzCbGxTyUx4Iqf/nSBwtebWMIa5gHJmiMg5Acvk4X1BU/w0zZVElXAZtBUEEFuGE1DI2+whv1lFxnX/I46Q24MloBA2/ox5drA7mv+ylVSUl8hNxizdzaB89o5XMdNW5LPw0J8BqHcIDL6gTdD0Af8z1TX7k3tNfAU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366544; c=relaxed/simple; bh=xk57zUsLcULI4piYDwAtccyPpYcWKKlCtENISMpU5Eo=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=Xy0p0lT7BFSC4bWfQDEsTxt3SuRZ3zPTH7CHl3+nKCn3A57bPRJgUrRcrDmtIRKuU0a6Ju1/RkMPQkXC3zFJG4PMmWGMA9qQjko8d+phTDjT0MqGhc62mS0ps0qeWsvkYIqZTu6YVogrR9HBzqo9vE2Po7VdULH3nMoHx1qKttA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B1Zkbo5m; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B1Zkbo5m" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-41632010478so6793745e9.1 for ; Fri, 05 Apr 2024 18:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712366540; x=1712971340; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=waqH/iRrWNhiEfcSl3rSo7z9FkzRwk5MNMpC/HcssOg=; b=B1Zkbo5mRsNKSz4VZHXy6QTrzBmpvA7RRBHYS/60l8Wbi9FKd1Gua3+E0aXV5W4RC7 IMTq0RZkw+GdhLEtAK4pUvxamcXQuptONVR0MdsAK5LXFmqa2STNu2D6FHFd6xVpawba FUUIltEyQRRTbCyIqAp6DGBoLmPmth1V+H+/9Y1j02nsepj+u4BiPWuzz8WBAkJKzAjv RePoy2LDN7erbAlvh/lwz7x7rPRLqqmybwW61CAANxO8fXnEfnbnB65pfV8Zw5nkzfL5 6cxQfVwm3f/8uwKL3rwwVph0EceGTdZ0Wpybd+mCY+kRWJVNV89CVs7Sd3xEQZ+22o9z GnuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712366540; x=1712971340; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=waqH/iRrWNhiEfcSl3rSo7z9FkzRwk5MNMpC/HcssOg=; b=AF9nXSWtVuShpEURsplBIiKf+0tDdyuyzwldd3YqRQfVo5JjlKyynvtXpWEq7j+0Rb iWX4lg2kFLZkKAz9Lp9qyaL84QL/oIZ6fwLogAu0p2lCAmxGhTspqXDx3EA0haBHRKdj H7n36UYJYv4bGkv3hSU6ByJNFu0ZP+CeBVgLzK9bgTjppIhvobedEKnRAv7/e7KPR6Uh gQJpWoDN+FwUb3NpqWvb05cp3uAW1K2m6HrKpzzHjJE56FtfYwr4ZLmbYNAH9pwtyyEE VgAjGsWtqYFNBF7Wu/Xvf0X5+amjfsgYxZZ7srVYwTOuUGxxEF/7acAbAT8fkS3Ax82r lrOw== X-Gm-Message-State: AOJu0YxHHzJKquIyZDV7uG84+WxRPBQSI/oaZdaJI1ogu2eQXyzXB6EC ykRgC5b15Osb2mFHwiKEYpPlfHfTzqBGgUr3M7yWooEXj0ytNdjEC3nHUro8 X-Google-Smtp-Source: AGHT+IGrzhqa+aB68fG7YYj5s/NMDu4tBdYFOkSGl+H2ACcoZRPh57QOpxepLNpMksT9qS/zaLwjuA== X-Received: by 2002:a05:600c:3585:b0:413:21f5:de48 with SMTP id p5-20020a05600c358500b0041321f5de48mr2708199wmq.18.1712366540405; Fri, 05 Apr 2024 18:22:20 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id n34-20020a05600c3ba200b0041625fc652asm8205223wms.26.2024.04.05.18.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 18:22:18 -0700 (PDT) Message-Id: <82e5e05288ded6394e562408507e3269c26e688a.1712366536.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Sat, 06 Apr 2024 01:22:10 +0000 Subject: [PATCH v2 2/8] SubmittingPatches: make 'git contacts' grep-friendly Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Avoid splitting up the command over two lines. This way, a command like $ git grep git.contacts Documentation will return a positive hit for this location. Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index e734a3f0f17..a33fe7e11f6 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -494,8 +494,8 @@ mentioned below, but should instead be sent privately to the Git Security mailing list{security-ml-ref}. Send your patch with "To:" set to the mailing list, with "cc:" listing -people who are involved in the area you are touching (the `git -contacts` command in `contrib/contacts/` can help to +people who are involved in the area you are touching (the `git contacts` +command in `contrib/contacts/` can help to identify them), to solicit comments and reviews. Also, when you made trial merges of your topic to `next` and `seen`, you may have noticed work by others conflicting with your changes. There is a good possibility From patchwork Sat Apr 6 01:22:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13619636 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7293125DC for ; Sat, 6 Apr 2024 01:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366545; cv=none; b=ikrzW0rBjJ57l65YZEnpnbw6nT114gY2SEMzz7KDphMnnoJFqEI5q2SHmVLTezkumxMsItgB09ksV6jked0OA9HHWcwM43YFDO0b1DO8xF/42+TEj5c+ZC4yPbUVo6251ZZyTFWP0d+S1PmQg/wMCUbao6Tdndzhlb1DZiFNcz8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366545; c=relaxed/simple; bh=njHys7aqHmJeoegisq0yVyi01xQBW0W7XIJMtB8rfSw=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=ibqbsJ83VxPw7p98QQ26zqa0x6+J8cpm7MrjqrkCcrs1i/M80mrQ5P62U6NE2bDlVHlVkVCicB6K3wg7sd/KhMng4aUZIOHBpuZYY55L8eE3ji618x2Y3n95gejg53h1NCKTexcdGGRcJAUaf/aBIbF8kf9fgFmqID5QaDASqLg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FbHXNwS/; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FbHXNwS/" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-41638ba5323so442035e9.3 for ; Fri, 05 Apr 2024 18:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712366542; x=1712971342; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=wlOpFDkfpFvhax3pB4KYhZY4cXff/yHJbwusPhgiXWg=; b=FbHXNwS/dUuj1Oy5yLyf6DVbR8Lxjq9nelkcvXdcC5eTQgFMsHdDgR0lBYSBWhIFIO 72HFHCsEv3KQuS4rwC+n7CRpJ3B2O7pNc8ToYEJ2jVnu94mFcsPGNTuRZYBZOED/+3nu FbVxQH+l3XWZ5sEbJ4R+rL13iZVz2NGlS5Oann7hnSjtScUuhfk6rykzgxg2B5ordORA 4Ibbufu6qrVq4ryYsMHgnBOL+I/vIIeGpoS1dzBhoEZNg5g5HEhrRQDwykLKsngVwAWx licKp7RrDnh99wT4kD5T7h2emxvveQ7D9LkyvyV5rIS2zhYuoFrdySqyhrnldc1tawLr eNnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712366542; x=1712971342; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wlOpFDkfpFvhax3pB4KYhZY4cXff/yHJbwusPhgiXWg=; b=AA7ODfElDfd2LH7AHFtN9wvtet8GvJYSgDg9ubiBsrwVnJpLqUfIxzOIWYgz3+Lf/a KZZTfQ/GhIeEcx0K4L7m4h7uY73Ojdx8vDIGj+/xoTNzmD6HywphmAi4hfOSn0C3C1uS HKsK0Y/xxBbnV1IchIG1E0CuhmQwuZ3FEP3wdNPhvhQnRl1hSEO0GBVCsHdWNsGDQO0v 5lZoa8PYns5cgJ7GW1o9hZLWFPmU+GYy8yLCFTO/qD69MkBiUNdrChNT6RhHEgRXXEus 9QQHUXErR0pdLvbvGQGIYZSUMQEg+taB4xzRg0fb584ypfVeeLQTopFT0Qzdb607x+4Q djtg== X-Gm-Message-State: AOJu0Ywb23yC3W7p8vwmV0+zwMCah6XS7l0Tuq1BM9QoxhKAPvO73ymF nDQvLtUUWQm7yvJF6DsASmWKbauPfY0u5TOXvOSh6vpbqu8BJK0vmp0wED5B X-Google-Smtp-Source: AGHT+IF/KPUDkAnIaiXFtEu+S0nI45kAdgU4bWr3Qxs7T0WyL68OjLTL4DCssVbVyg85p9w5B8IVMg== X-Received: by 2002:a05:600c:4754:b0:414:a76:3d5e with SMTP id w20-20020a05600c475400b004140a763d5emr2400018wmo.28.1712366541883; Fri, 05 Apr 2024 18:22:21 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id a9-20020adfed09000000b00343d33ac824sm3229590wro.78.2024.04.05.18.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 18:22:20 -0700 (PDT) Message-Id: <6e6950afa6e6e884ee89ac24c05b50dcc722657d.1712366536.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Sat, 06 Apr 2024 01:22:11 +0000 Subject: [PATCH v2 3/8] SubmittingPatches: mention GitGitGadget Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index a33fe7e11f6..48b270b4c48 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -408,6 +408,10 @@ are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME type e-mails) might render your patches unusable. +NOTE: You can also use GitGitGadget (https://gitgitgadget.github.io/) to send in +your patches. The discussion here focuses on using `format-patch` and +`send-email`. + People on the Git mailing list need to be able to read and comment on the changes you are submitting. It is important for a developer to be able to "quote" your changes, using standard From patchwork Sat Apr 6 01:22:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13619637 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76B5D1864C for ; Sat, 6 Apr 2024 01:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366548; cv=none; b=YVq1/Y+dmpYVWLSibiisMHucUMmMYfCc2g2xVxLa61Eki9bm9sYX4ZnhtYKGDQqolvfx3W3X6ASQIp34Aov3JEWhXYPi30St9ZQ6iKR4FGci9YAdkGkV37BzViARWn4KDOrYPSDMVf0NibRD+aj3Z6H+p1rc/ptEin6z4HYAaG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366548; c=relaxed/simple; bh=CmzZnMlncjuY3eA2HBuzS9D9pHnJ6nNm5KiVNgpysMQ=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=pAv3QaK3+iiLDZWVnBdlXi6xAjj/dfakjdP01R+0e5XwN6HQ9OEiy+esmae1uVkapJ3g3cxSa62G/R9OgPecWs2Q+za3UNXgubQTlY6zPrONXpswAyxluczpmhGV4HAlStOchaEtMbT35kxI9oFO/ye3bSeBtkTYjFqD2mC7Eqk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A+A8vA86; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A+A8vA86" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-343cd12630aso1423918f8f.1 for ; Fri, 05 Apr 2024 18:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712366543; x=1712971343; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=5Pfd4ptpPwLTQDjG1HgBLjWLc/ce3d0suhzBjCfS4sg=; b=A+A8vA861gdp+aSU926nNee3gh3np/Nw2QwQK7AnzG4ymu08EMlZdZqJT+HP0ueGkO QZ7yKChiIEfOCtRCr3YQ+gOccd1rrO5Z0zlFyknZ23eeqRTJNICv7jHMq3PeOdV7Y6LQ KmvgUVdcRfnt66kEP+nIOtNeCbORr8OfjGF4wHHbKSPLuoLCrfpe2AXFqC5iHHkEwOYn mEWWn5JAReElM5WAdycpCEcQu68LDBJKtPNRVhZ3NdAe2a1U9nmSqEwGVIsNFMtPM+JX GpLVqm5juNwdEhq7zlQYCYwZ1fzDTfjs/6CW7I8ggMTrYXljrJh5QgQDgZmv/a5n8Tk2 MANQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712366543; x=1712971343; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Pfd4ptpPwLTQDjG1HgBLjWLc/ce3d0suhzBjCfS4sg=; b=sIlYKv64Qk7Cw20n2BMEt+NFq7OV58OPy+mv+gl0RtTUePeF75sULncEiPwD1jARMg I38pgNQwqVMP5QE9yW/v+EpmH2ybw7Ozz7rvAhwbUP1xstgWo5YgFxw2Ds6j09NiqOgy oePAN1aOoljh3n9pU/ARHfH6v5TAI2Ie3f6fP/w4F+D00Y6tqnt6udqW7MkWCBK0YVge vlMSLUgFSMnz7lAyPdAl7tQvbqkTt0mjXcFLNcn7bWwm9BrDXvywfAvWehPyqEW3oJiE 2AvCgb2mX2tsc57F26LEkXL0Bwy4aNeBg39AUKWrtEcmengtHL3CKO0+xMPuLyzX8ZOV rXaw== X-Gm-Message-State: AOJu0YxjtfwKyxFton7W76C2V+bbybMVUS8GebfZ3MKGMY8Jy552y4mY HLec/X3Q6ZliPMUHGGu8rUz/uinDM5wJlePorNsbjNuJe3Lqf+EKmf7+QBrO X-Google-Smtp-Source: AGHT+IGumURzZ/xkgmHsEKGEOZVtiz5SiOZOyFUny1M3PCA4IrtPdq/rx3MOaNilJjlgVmIKyfB04A== X-Received: by 2002:a05:600c:1d90:b0:416:37ec:4bf9 with SMTP id p16-20020a05600c1d9000b0041637ec4bf9mr176242wms.26.1712366542912; Fri, 05 Apr 2024 18:22:22 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id l13-20020a5d668d000000b0034354a99d43sm3214484wru.43.2024.04.05.18.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 18:22:22 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Sat, 06 Apr 2024 01:22:12 +0000 Subject: [PATCH v2 4/8] SubmittingPatches: quote commands Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 48b270b4c48..24c7041a06f 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -403,7 +403,7 @@ Before sending any patches, please note that patches that may be security relevant should be submitted privately to the Git Security mailing list{security-ml}, instead of the public mailing list. -Learn to use format-patch and send-email if possible. These commands +Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME type e-mails) might render your patches unusable. From patchwork Sat Apr 6 01:22:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13619638 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AECC18C31 for ; Sat, 6 Apr 2024 01:22:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366548; cv=none; b=HR4tjmE1MDFd9rHeFNMKt5DC75sv+IJ2XN4M0J8qLOuR3nk6K3QF9RUUQfdTLph7ArIZ7sibRq/6le0UjzVoWDJPNLxtZdgMSL8u3FYiJPE/DT3D1Fe8ikKLVyiYZ+6JHvMPU+T8TZDaEHSZHVB5Yh4yguR/4tWhohiT71I8O1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366548; c=relaxed/simple; bh=QvyZWQBvNcjyOtZldMnHawONGsX3lLlukOi5dH4BWU8=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=cLHxxWLgPlu/r//mqdAF+eZDDh2B3eyOXxKt6jbcCvSJiqWHEYTZyYGKK2rKRW+Sd4ye5z4PdJT1Id/qQhwbA5E7E0pjABhm+m2VSs4sihUOdvnikfHj7KGe2TitNAAPhzPRUNmxFqQBN/ZQKoil8FVgEDiTsIlcU8RXn46pDNU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EFf1Afz4; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EFf1Afz4" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4162ae2a0e4so15062985e9.3 for ; Fri, 05 Apr 2024 18:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712366544; x=1712971344; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=PhWMCu09nW3c5n5D/UILz3t0YxM+LGCIZpIwSXWRpL8=; b=EFf1Afz4Y+tnI9mdNYC8eqvcQ0UFwoAIaMY8AXY/reKZwUQqyxkHyayI2GwdK3K34u YchdYGEnAC74JT22uo5wJWTRSqtU4wfnGhe44AYTo+S7XiwyeNCeJMUYbH37GXjUaxAm /zYH7v5yJ5neUhRIz34AID0xkd5P76STaGhwvkJ9EUUDB1djksCERmsBVMfdQLKCz9fk vjqFbNqBWq5iuqYKWrPwo1sPEkl/PFWAKqiLJ0Bq7kf61enbT6afZQsNBOtGp9ZJOBmB jTh1n8/72y2ERnveHOwKQi4oLw8nGYFwu/m+A8MVZZUBpC10HOmPwBdiGGFwUGbZnm5J Lmeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712366544; x=1712971344; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PhWMCu09nW3c5n5D/UILz3t0YxM+LGCIZpIwSXWRpL8=; b=lAAeQIocI+qVvX7OPI/BH24argzrLueQzgon9GIHbbu1Jz+McYajSoNe+NNmERBgQ0 0iE/tTKp+3HZRlit32qr5Nu8pLGXh7SrMqZV+AmPwlCMP4zpH76KNEeonlqR5ba8Mo6O mQvEri+OYbGHT8AEB5XfumzN2G+71ZVC9uejWiF3vNfCqVFxbbP+SmIPm6z5ltf/29Fn D4LcA5HTfG/3HSNfPgKKD7ulNozL5Zhu7JwFP3pF202TXWyAb2W9/6Hz5seF96eq5qjh 4G7eraeY+bxIz29sVo6iRNQcc9L8NbxC+LbF2My7Ql5MrDOGJpWTAgX9az1wAR+5g0ug IaHA== X-Gm-Message-State: AOJu0YyXxohNhDiZ7N9cM27ZoTvuSd/x4IzmUcwaRNEGibJnLs+cNuE1 2H022Keqaxete0ICX09mDzrqljj86ttwQvvkvVKZFsfUE/IuAufmSBYYAVez X-Google-Smtp-Source: AGHT+IFaM9M9fb8zjUDFC4mC/yP+AS3x94Yyk+Zl2DTqzZs7PgrNwo+b60B5MTzp4fl9LtfkhOrzzQ== X-Received: by 2002:a05:600c:154e:b0:416:33e6:25c7 with SMTP id f14-20020a05600c154e00b0041633e625c7mr626404wmg.36.1712366543920; Fri, 05 Apr 2024 18:22:23 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id d15-20020adfa34f000000b00341c88ab493sm3268792wrb.10.2024.04.05.18.22.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 18:22:23 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Sat, 06 Apr 2024 01:22:13 +0000 Subject: [PATCH v2 5/8] SubmittingPatches: discuss reviewers first Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver No matter how well someone configures their email tooling, understanding who to send the patches to is something that must always be considered. So discuss it first instead of at the end. In the following commit we will clean up the (now redundant) discussion about sending security patches to the Git Security mailing list. Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 58 +++++++++++++++++---------------- 1 file changed, 30 insertions(+), 28 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 24c7041a06f..17db961bac4 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -397,6 +397,36 @@ letter. [[send-patches]] === Sending your patches. +==== Choosing your reviewers + +:security-ml-ref: footnoteref:[security-ml] + +As mentioned at the beginning of the section, patches that may be +security relevant should not be submitted to the public mailing list +mentioned below, but should instead be sent privately to the Git +Security mailing list{security-ml-ref}. + +Send your patch with "To:" set to the mailing list, with "cc:" listing +people who are involved in the area you are touching (the `git contacts` +command in `contrib/contacts/` can help to +identify them), to solicit comments and reviews. Also, when you made +trial merges of your topic to `next` and `seen`, you may have noticed +work by others conflicting with your changes. There is a good possibility +that these people may know the area you are touching well. + +:current-maintainer: footnote:[The current maintainer: gitster@pobox.com] +:git-ml: footnote:[The mailing list: git@vger.kernel.org] + +After the list reached a consensus that it is a good idea to apply the +patch, re-send it with "To:" set to the maintainer{current-maintainer} +and "cc:" the list{git-ml} for inclusion. This is especially relevant +when the maintainer did not heavily participate in the discussion and +instead left the review to trusted others. + +Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and +`Tested-by:` lines as necessary to credit people who helped your +patch, and "cc:" them when sending such a final version for inclusion. + :security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] Before sending any patches, please note that patches that may be @@ -490,34 +520,6 @@ patch, format it as "multipart/signed", not a text/plain message that starts with `-----BEGIN PGP SIGNED MESSAGE-----`. That is not a text/plain, it's something else. -:security-ml-ref: footnoteref:[security-ml] - -As mentioned at the beginning of the section, patches that may be -security relevant should not be submitted to the public mailing list -mentioned below, but should instead be sent privately to the Git -Security mailing list{security-ml-ref}. - -Send your patch with "To:" set to the mailing list, with "cc:" listing -people who are involved in the area you are touching (the `git contacts` -command in `contrib/contacts/` can help to -identify them), to solicit comments and reviews. Also, when you made -trial merges of your topic to `next` and `seen`, you may have noticed -work by others conflicting with your changes. There is a good possibility -that these people may know the area you are touching well. - -:current-maintainer: footnote:[The current maintainer: gitster@pobox.com] -:git-ml: footnote:[The mailing list: git@vger.kernel.org] - -After the list reached a consensus that it is a good idea to apply the -patch, re-send it with "To:" set to the maintainer{current-maintainer} -and "cc:" the list{git-ml} for inclusion. This is especially relevant -when the maintainer did not heavily participate in the discussion and -instead left the review to trusted others. - -Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and -`Tested-by:` lines as necessary to credit people who helped your -patch, and "cc:" them when sending such a final version for inclusion. - == Subsystems with dedicated maintainers Some parts of the system have dedicated maintainers with their own From patchwork Sat Apr 6 01:22:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13619639 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DE3B18C36 for ; Sat, 6 Apr 2024 01:22:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366548; cv=none; b=quUhKfi87VT/CTbIHo94Jim2HQMM34UXmwaFKKQzQSq4FOy/DoKuDiiW74qEhYHsHhrOXtuPFROkoshZsmcfYjOt8Y6wIQccQ9jiP3fOQJn2l/w1+dHYuMRCA4rIIa+cP+l3tPq7l9XC2m3bSF3F9nuVeykI5dSQrgUihUzGQtU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366548; c=relaxed/simple; bh=Jy3UQAwLerFCkgDypFQwtqYPfZiq+iQrYx8hkg/QbHg=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=sr5wO/E5ZtIL/21l9tPm5MaIcieI6+SSjp5UGDkM4VAi7GX7KJgikg4pd0wsc4HGyzjuwBkk5wCf5uxNiVJv1AZvy0D+fYjkMee+H6SGFkK8SECkWsTJCCWT0tEVvPSNFhmt4o0BD17UKjXigVGBi9QMIvQOHwpgClEQ6nxMx6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TaY18dDl; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TaY18dDl" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3454fbdd88aso70704f8f.3 for ; Fri, 05 Apr 2024 18:22:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712366545; x=1712971345; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=8H5ODmcle9HDiLrIV62Z8QVANHMAPlqooF6ONKnyKAQ=; b=TaY18dDlqtAMlOSZInzoRaY3QlkLvthMQx4pm1fhrQ5k0BHaR5AiQW+t9NsEAHS1TA G5zpY0M82lnVIifecstKcZ697Z7rh7rjQQxJZHRxH1oXEI733GEN2kVVT+OTF00sycVm 5ivMhAsmGLQ3SNZklHECePjBsDds9AfdvNP1tAy8IeWK4uc+3ENQhHkzCx0tcMViOnE+ 12rfkRYrRGpBjlJtlI49xMZ7f5qQwGgV5HFcaM9GP0j/vfZNPu/+lkIbdRSGOB7edKd0 RxyuRWyufQZfm9IzO00cJ9gwscpWzmRBXtiKAt+1mbyeXTIKHF07v8dwr2X38sAbNLZd 274Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712366545; x=1712971345; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8H5ODmcle9HDiLrIV62Z8QVANHMAPlqooF6ONKnyKAQ=; b=qLzJfPh/Y3zKMaK4Q3VlK4FUzGheGja+KutFnaHLS3wU4aUrC2WgJqIRjEldiDlNpk 7l8NTKy7cZUcN1CDQIskyxsIAObLPACXnIYdNsIeFpykfjMF/8vfm2MsD0bbUSLsCDYJ An5hXLrh8N0EEAMaId34VaD/M/gVTVi0UKBzDBXqlcVas4ogmQbqzUzoWFRty9y03hjY vWAV6trBfxRtARUe530sYUzpgmZKcLVlUYEnN9Op4rGnObgN/DwBp2OK5XRHuVyUPnb3 Rpu9iEBvqKoW2/pXplF6sRTBeQv/VnMBIvskl08u/LcSUjMeehoW+m9Rp8yrjJOJKPy3 TLlw== X-Gm-Message-State: AOJu0YxsuXGvDIKNPml0hCaAkmAQryeu3M6KriiJ+tZSMiGDdLM3YgGT LPc1dNnhtnSwNOtEaMsDoswZV/eO4tHYU45VZ0ARPuLslTOYnpxdton12k/Y X-Google-Smtp-Source: AGHT+IEgi01jrTDW33u8hFujMLBejyHuoZC7pcJKnhAkViF91EB5RxUOJfDDU0UMxZvXfW+hkoRbwg== X-Received: by 2002:adf:e44d:0:b0:343:ce59:c702 with SMTP id t13-20020adfe44d000000b00343ce59c702mr2751112wrm.50.1712366545379; Fri, 05 Apr 2024 18:22:25 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id q18-20020adfcd92000000b00343e5f3a3e2sm2822263wrj.19.2024.04.05.18.22.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 18:22:24 -0700 (PDT) Message-Id: <326afe1331568b4e2efbef12b8beebb263d1cfe4.1712366536.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Sat, 06 Apr 2024 01:22:14 +0000 Subject: [PATCH v2 6/8] SubmittingPatches: dedupe discussion of security patches Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 17db961bac4..311f306394b 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -399,12 +399,11 @@ letter. ==== Choosing your reviewers -:security-ml-ref: footnoteref:[security-ml] +:security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] -As mentioned at the beginning of the section, patches that may be -security relevant should not be submitted to the public mailing list -mentioned below, but should instead be sent privately to the Git -Security mailing list{security-ml-ref}. +NOTE: Patches that may be +security relevant should be submitted privately to the Git Security +mailing list{security-ml}, instead of the public mailing list. Send your patch with "To:" set to the mailing list, with "cc:" listing people who are involved in the area you are touching (the `git contacts` @@ -427,12 +426,6 @@ Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your patch, and "cc:" them when sending such a final version for inclusion. -:security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] - -Before sending any patches, please note that patches that may be -security relevant should be submitted privately to the Git Security -mailing list{security-ml}, instead of the public mailing list. - Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME From patchwork Sat Apr 6 01:22:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13619640 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D08CDBE4F for ; Sat, 6 Apr 2024 01:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366550; cv=none; b=hfo7YjlXS7ZF1PI+fvRIe5OTiw4xVDjyw1/AdrpVNiJFfi0imrrB3vliA88V7F+ysBr5dqiw+AXLSCTt5nsGLLOXqQTDSwVh4IqzaDnrgejxkdeXwYN8N+lsx0dQ+LE3GbhDb2TV+TeLA9vy9dd+Dgdvx1zw38G+jMSdtxLVda8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366550; c=relaxed/simple; bh=jZKRm+2mEdekboNrU7z5B7zDXHMsJR3ygUNr2bizhGU=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=nQkWOP27UIX/lZ45s3+NUyM6Ejy6z3PLiLAq8jmOgsS+iG6dQxY57s60CmuzvOi7uLTZhfTQwDNhwqYa4EW69yWDA7Q7+FNp9JSvJ+TZFx+GY8Ta/2urEVBlJJb/Z31GGfUFWBG8r8VFAfN1RZfAsefrypbxzW+z8F0WE9tO3HQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CPmy1aZJ; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CPmy1aZJ" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2d47a92cfefso35998811fa.1 for ; Fri, 05 Apr 2024 18:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712366547; x=1712971347; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=qM96Pg+v2WSlmqea84VoJywARHIirt8ccQRhuqk6neE=; b=CPmy1aZJCCPJgoYDdkzwtPvBrflR8ifvuMVXphU0MojBqx7cFel1I7Yi6DJJ/JjFXj KgwbRqYNxR/oe/obPLJWGxBzSLnFQPsIgoasG1zIINiX17ZCRAjVWea8ekgUu4zIK9+1 twAqyeDnqkMR11Om1XYnOktpdDxBQH4X5uvT0W2fgN+nOffcUkQBe+rSndDAn+RNCzvo kn/JnrwAEDhb9ybC/UEdZFf1bE8+s+6n6qmdQ3sWMKvnIlbzapcEUyBm8kLwP+w7zZhy yU7RNB6t3e79u750s9clqB64n7eWIDeQ6/KsZd7SdAiVTIRKjVwd5+pMOqwe8wJN//oa WE2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712366547; x=1712971347; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qM96Pg+v2WSlmqea84VoJywARHIirt8ccQRhuqk6neE=; b=D72FlbP0TKyvMclqgMOXK45V3WS7ORwoet+4Nd6VMXN6nt9wBOU0PmRYLMrjMfnPcC QDmS11AYXePmT+vB3eCVJvB32V0+qAD2KIHU+M2bCIvUy+YygXpV6qqWefFH7eVO2cwy gsDWWBbMNldZnf0cO+XygQmKM7Cqd+3/XXy/fxfXKyndiq6LOKsqVUBjHTFBWqnWQh80 GzOERUvn3/klp8wdNkDF4rddj+CmylOPfbYg89BhEThRZZpruno57y4c5xDoGxBL1Wx9 Tf5RQGZxUl52t3p0VCy31YOTCUkq8rQrxVUKyanKSm8xpbnyLv6n9lVe0lkTdHZLWVji tdRQ== X-Gm-Message-State: AOJu0Yzqrrc1MqbJ2Ly1VzMoAJ2lIMy7j4XD1lhn2UsDx/nLUj1tp1hc Ck6S9OODszksXJoB4syPDbLSTfhqurCZxNGl/yfyqi2MQ3IXE2H6UNA3EjrM X-Google-Smtp-Source: AGHT+IFp/0l0tefahCaseMXQW8i7BmveSRsuvW2+LzL1Pir2SFQ/gE49jZ9+RaSZv05HYcTKa8zjyQ== X-Received: by 2002:a2e:7d15:0:b0:2d8:63a2:50dc with SMTP id y21-20020a2e7d15000000b002d863a250dcmr2152900ljc.48.1712366546423; Fri, 05 Apr 2024 18:22:26 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id h7-20020a05600c350700b004154399fbd9sm8319569wmq.45.2024.04.05.18.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 18:22:25 -0700 (PDT) Message-Id: <09f4e7ad123b7359d29981b9a61243e9554487c6.1712366536.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Sat, 06 Apr 2024 01:22:15 +0000 Subject: [PATCH v2 7/8] SubmittingPatches: add heading for format-patch and send-email Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 311f306394b..48224e745ff 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -426,6 +426,8 @@ Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your patch, and "cc:" them when sending such a final version for inclusion. +==== `format-patch` and `send-email` + Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME From patchwork Sat Apr 6 01:22:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13619641 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78CFB1BF31 for ; Sat, 6 Apr 2024 01:22:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366551; cv=none; b=DmnNJaTSwk+bFHFN6kAOr+R//HCG+TK++c+3YVm+q56uOaYpKj1lDPvcPtOZBA4w7v4WVXuBY2j3EC/trTBoRzCuB0qwbirHgGpK4pcC7fRQ4ANalWaB8rHOCZCPlPwWBz9Dg4YQBeE9j+aD/xQgaavMIr3aZdi4T7Q00sXstdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712366551; c=relaxed/simple; bh=A9u0dvzLwFmWjdg1odRVfFFjXVFBaShVixUOJj2OmdQ=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=pZ9sbJLfsHdQ50Cff7ryXTh3iyi+C+6iX7PEMe9dayKeNGr0tNYZq8tevu+x+cw9geEEfaKn7QYKV/gOfzYzSL1WYytKDzlSTpBoeYwY6Dtf6y82ecsBVBzNrlIakt1ejitLOESVbMQJZycaa5pcEQBJf0J+GvHw05R2zJoxUQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AgWvP113; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AgWvP113" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4162b0e21b0so14857905e9.0 for ; Fri, 05 Apr 2024 18:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712366547; x=1712971347; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=ArzzgeZqp6f/ie1rMicJVmVBDZpVN+vnuC5DQMBVDwQ=; b=AgWvP113Hm1ETy8w7uCFHV/eWFxjsWRvhfxrwPmTNZRuGeAoj4Qe7VXDRdOhMD+0bi DZ/1RjYW2ODpFmM20PFGYYGxXZm7VY4Krk2rc0A79/JNi8CWN2y3VeN/ip6Zwy7sHjYw UfmaAnesb6s6/FQdpR+4ErJY8GsQNhbeWZi/vqATP4IHhYCXUs8hAzpD0Xs7RPZFR0T8 wSczmPBLnMmCWavCa2uz51OojKgHQ1u2//0AZSDRajJWe8ytrFroXOZWuC+akVXZZcZt RpBUbElN+5V/pvCFflbPZ5xzbSzaLxgWnUOuOXybmJbvTDmI3jV1ZSQ86Bgy72sbRKCF kCdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712366547; x=1712971347; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ArzzgeZqp6f/ie1rMicJVmVBDZpVN+vnuC5DQMBVDwQ=; b=M3KubhZr8o4TciqiJU4GjjHkgnPo61oYsYhdDx/0xee4lmObJaehldrzUfw1mfPpZF 925psIcN5vH98K5VEf+840NQA7t1FA+RVXEoWcKQ1D41E7oAxMz27WKKvmja0j1NwH2o Gf1foNzt133RsLBLikoStJr6oEVTXnSbTGSs8PNKsbmCzY2khIfxXbfj+L0kNNwdZj77 eOpbEfvPUIUjq2m65gffY5ArB1WWes+KWji0UelvedZDOhCaPrKfFEp7xhdxzxh1iCJq C4L9NicQIznq6G7DBC83iT5I9h8f1gauLnVULDWqDigkSUPe3k349cnmUPQmGQFgOzdP 0wjw== X-Gm-Message-State: AOJu0Yy3fmAQFT/NM5doJ/JQDnfZ7HGm2x0Hmn90pj0B6BrNM7Nfn9nI s44JPCy/YboS9fELNLaac1RyQt/lxJYo24FzW00lgu6e8cOAM7BkKAox1+4N X-Google-Smtp-Source: AGHT+IE+2ZwxkzKUuHzYYKjhiNufQFU9wEKWqS37a3OQq4alFb58iGzZweWTNfX+HNzA6PhMeBjbbw== X-Received: by 2002:a05:600c:a0f:b0:416:33e9:1e5 with SMTP id z15-20020a05600c0a0f00b0041633e901e5mr503783wmp.0.1712366547232; Fri, 05 Apr 2024 18:22:27 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id bg35-20020a05600c3ca300b004162020cee2sm8458286wmb.4.2024.04.05.18.22.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 18:22:26 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Sat, 06 Apr 2024 01:22:16 +0000 Subject: [PATCH v2 8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 48224e745ff..11c3e94d4a5 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -413,6 +413,13 @@ trial merges of your topic to `next` and `seen`, you may have noticed work by others conflicting with your changes. There is a good possibility that these people may know the area you are touching well. +If you are using `send-email`, you can feed it the output of `git contacts` like +this: + +.... + git send-email --cc-cmd='git contacts' feature/*.patch +.... + :current-maintainer: footnote:[The current maintainer: gitster@pobox.com] :git-ml: footnote:[The mailing list: git@vger.kernel.org]