From patchwork Tue Apr 9 07:35:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Daisuke Kobayashi (Fujitsu)" X-Patchwork-Id: 13621907 Received: from esa1.hc1455-7.c3s2.iphmx.com (esa1.hc1455-7.c3s2.iphmx.com [207.54.90.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD57A7BB11; Tue, 9 Apr 2024 07:33:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=207.54.90.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712648011; cv=none; b=bLCp9y6gcqKY57h9cLxakeRG+MW5PlbdMqH9+cIkgrGtmAvb4ihAqSkKZtelXT8E8hXTnljULNsrY5EfFDkSSTZ2smqY+obYEKqyqb5Qy89hauTH/zxPlFmBZIt66JEX4La5YkeMvfBjMrzJQYaI+BqnNLCgBfXpILMRbfFXh78= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712648011; c=relaxed/simple; bh=qp+YgUH3bz+WFmudL3wOvXuBwp14NHmw9plnq6kfLYg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fy+SRaaOLqWxwhz1zVHefyca+q7RxIdA+Mr+ezSYPzPZrSmW6iRAKjDrJAl/3bYF1dDkC4zWzjVqv0vlmYuJnCWnrrDFsiAuxM67AMV3Ks9CETBiftyEQ0JutbaB4s64I7Fl/D6wAR1ZlyejF3Yl2j5g9+KWRugQBCNZwgAHLu4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fujitsu.com; spf=pass smtp.mailfrom=fujitsu.com; dkim=pass (2048-bit key) header.d=fujitsu.com header.i=@fujitsu.com header.b=hd9g7OVz; arc=none smtp.client-ip=207.54.90.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fujitsu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fujitsu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fujitsu.com header.i=@fujitsu.com header.b="hd9g7OVz" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj2; t=1712648009; x=1744184009; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qp+YgUH3bz+WFmudL3wOvXuBwp14NHmw9plnq6kfLYg=; b=hd9g7OVzCa7LT2r5GU5zz16SIRlW5GgKDjll/DxyC0Jlvi7KWPHjHLSb 3Rj8Lr8CWH8S1CiqANzQWoxCDXosnKeNGYIq95UA7xuAF/ydvCdT1jVbQ UejGMkTUFXAudEMob8+DEQ2JWDX7/WPGnlByMeJqeoRc99iAe7JFENABP aavB3Clmab1GUtpD4NsURco2LmCWE70pnphqgxkXCdLe1HKrsWMh14r6q gVJCYECk4ZVNyozUk3AonSWJUTp8K9I1+3w0lsn+/SS7e4oI12pHxqLG+ +Zi8/Tev0tkULlh3cIsrZWX34PDRoAaH4FdTuysgkmSc1ZoCXa2CU2mPY Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="154907598" X-IronPort-AV: E=Sophos;i="6.07,189,1708354800"; d="scan'208";a="154907598" Received: from unknown (HELO yto-r1.gw.nic.fujitsu.com) ([218.44.52.217]) by esa1.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 16:33:22 +0900 Received: from yto-m2.gw.nic.fujitsu.com (yto-nat-yto-m2.gw.nic.fujitsu.com [192.168.83.65]) by yto-r1.gw.nic.fujitsu.com (Postfix) with ESMTP id D7EA8CA142; Tue, 9 Apr 2024 16:33:19 +0900 (JST) Received: from m3002.s.css.fujitsu.com (msm3.b.css.fujitsu.com [10.128.233.104]) by yto-m2.gw.nic.fujitsu.com (Postfix) with ESMTP id 1A1B6D595C; Tue, 9 Apr 2024 16:33:19 +0900 (JST) Received: from cxl-test.. (unknown [10.118.236.45]) by m3002.s.css.fujitsu.com (Postfix) with ESMTP id E77DE204E19D; Tue, 9 Apr 2024 16:33:18 +0900 (JST) From: "Kobayashi,Daisuke" To: kobayashi.da-06@jp.fujitsu.com, linux-cxl@vger.kernel.org Cc: y-goto@fujitsu.com, linux-pci@vger.kernel.org, mj@ucw.cz, dan.j.williams@intel.com, "Kobayashi,Daisuke" Subject: [PATCH v4 1/3] cxl: Add rcd_regs to cxl_rcrb_info Date: Tue, 9 Apr 2024 16:35:26 +0900 Message-ID: <20240409073528.13214-2-kobayashi.da-06@fujitsu.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240409073528.13214-1-kobayashi.da-06@fujitsu.com> References: <20240409073528.13214-1-kobayashi.da-06@fujitsu.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-TM-AS-GCONF: 00 Add rcd regs to cxl_rcrb_info to cache the RCD register values. Signed-off-by: "Kobayashi,Daisuke" --- drivers/cxl/cxl.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h index 003feebab79b..2dc827c301a1 100644 --- a/drivers/cxl/cxl.h +++ b/drivers/cxl/cxl.h @@ -647,6 +647,9 @@ cxl_find_dport_by_dev(struct cxl_port *port, const struct device *dport_dev) struct cxl_rcrb_info { resource_size_t base; u16 aer_cap; + u16 rcd_lnkctrl; + u16 rcd_lnkstatus; + u32 rcd_lnkcap; }; /** From patchwork Tue Apr 9 07:35:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Daisuke Kobayashi (Fujitsu)" X-Patchwork-Id: 13621906 Received: from esa11.hc1455-7.c3s2.iphmx.com (esa11.hc1455-7.c3s2.iphmx.com [207.54.90.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C61DB7D3F7; Tue, 9 Apr 2024 07:33:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=207.54.90.137 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712648010; cv=none; b=cd1WW/bPxloexClPWdjyY8uK+6cJEYMtsP+Vv85E2z6RIijHz9ZD1djZQ8r2pYV6RYhCkRPuQOUlC6r0ZPix0SHt2cBeiwT4ySSQnNxw6P/rkLLOUreqhIoT3uL6H2y8txw4XBoZBpPvHwoxw0JtSXa6bsuEfajlWj4xz/oPiFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712648010; c=relaxed/simple; bh=WOz53IFk3XpJYU+ZqEfac1yqvSj/RaZIfJvfEww8Mcs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dsDhErQYPNANJ6qditcdZuGr28HujWRthLVvVGM/bpELWeYU6f41Ryr1KgA1JptMRVZ0tXmzuS92zru+2mcL08wkNJgVuB0KXEbjRbMr8ejJVyMRQSiLcwFHmegqcZIUEaEXjJa9S6F8TBS5EmxFZyi+j+zmh4oW6QY09Tsua7A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fujitsu.com; spf=pass smtp.mailfrom=fujitsu.com; dkim=pass (2048-bit key) header.d=fujitsu.com header.i=@fujitsu.com header.b=E0lGS8oj; arc=none smtp.client-ip=207.54.90.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fujitsu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fujitsu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fujitsu.com header.i=@fujitsu.com header.b="E0lGS8oj" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj2; t=1712648009; x=1744184009; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WOz53IFk3XpJYU+ZqEfac1yqvSj/RaZIfJvfEww8Mcs=; b=E0lGS8ojtYXQnDOIBhAUrfF1ZHKTFHVfqkgG2hKSIkqIrR3DJxb1Pbeb YG1sIzjZsojsqzUXMGxlEcxV9AkZu+YlylB+ryRYIg7v7Ik/ZH/eCyuKL 61w9qbAz+ea8fNKnnJbseRmNycu2SWSCmDx+tDfWFqiOUHorGBkgYFxbu SoOoeuQ68PwJMBBHwh94YRDnDvyKtcu76eXk+bG2nI5bro4rwCc0Uo8sH 3SrzZTCX5WlFV3ze16fBhz8huQ0ujcF8OS5beDRWbd2f8LOm+B31YNBcA eeXhOzDWzdW95Mhi8wtbyWxLmRbfCrIDT4j+N1hGZsIRVSxiqB0g9fW4J A==; X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="134397682" X-IronPort-AV: E=Sophos;i="6.07,189,1708354800"; d="scan'208";a="134397682" Received: from unknown (HELO oym-r1.gw.nic.fujitsu.com) ([210.162.30.89]) by esa11.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 16:33:24 +0900 Received: from oym-m2.gw.nic.fujitsu.com (oym-nat-oym-m2.gw.nic.fujitsu.com [192.168.87.59]) by oym-r1.gw.nic.fujitsu.com (Postfix) with ESMTP id A9BB8D4801; Tue, 9 Apr 2024 16:33:21 +0900 (JST) Received: from m3002.s.css.fujitsu.com (msm3.b.css.fujitsu.com [10.128.233.104]) by oym-m2.gw.nic.fujitsu.com (Postfix) with ESMTP id DA822D3E1A; Tue, 9 Apr 2024 16:33:20 +0900 (JST) Received: from cxl-test.. (unknown [10.118.236.45]) by m3002.s.css.fujitsu.com (Postfix) with ESMTP id A3C07204E19D; Tue, 9 Apr 2024 16:33:20 +0900 (JST) From: "Kobayashi,Daisuke" To: kobayashi.da-06@jp.fujitsu.com, linux-cxl@vger.kernel.org Cc: y-goto@fujitsu.com, linux-pci@vger.kernel.org, mj@ucw.cz, dan.j.williams@intel.com, "Kobayashi,Daisuke" Subject: [PATCH v4 2/3] cxl/core/regs: Add rcd_regs initialization at __rcrb_to_component() Date: Tue, 9 Apr 2024 16:35:27 +0900 Message-ID: <20240409073528.13214-3-kobayashi.da-06@fujitsu.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240409073528.13214-1-kobayashi.da-06@fujitsu.com> References: <20240409073528.13214-1-kobayashi.da-06@fujitsu.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-TM-AS-GCONF: 00 Add rcd_regs initialization at __rcrb_to_component() to cache the cxl1.1 device link status information. Reduce access to the memory map area where the RCRB is located by caching the cxl1.1 device link status information. Signed-off-by: "Kobayashi,Daisuke" --- drivers/cxl/core/regs.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/cxl/core/regs.c b/drivers/cxl/core/regs.c index 372786f80955..308eb951613e 100644 --- a/drivers/cxl/core/regs.c +++ b/drivers/cxl/core/regs.c @@ -514,6 +514,8 @@ resource_size_t __rcrb_to_component(struct device *dev, struct cxl_rcrb_info *ri u32 bar0, bar1; u16 cmd; u32 id; + u16 offset; + u32 cap_hdr; if (which == CXL_RCRB_UPSTREAM) rcrb += SZ_4K; @@ -537,6 +539,22 @@ resource_size_t __rcrb_to_component(struct device *dev, struct cxl_rcrb_info *ri cmd = readw(addr + PCI_COMMAND); bar0 = readl(addr + PCI_BASE_ADDRESS_0); bar1 = readl(addr + PCI_BASE_ADDRESS_1); + + offset = readw(addr + PCI_CAPABILITY_LIST); + offset &= 0x00ff; + cap_hdr = readl(addr + offset); + while ((cap_hdr & 0x000000ff) != PCI_CAP_ID_EXP) { + offset = (cap_hdr >> 8) & 0x000000ff; + if (offset == 0) // End of capability list + break; + cap_hdr = readl(addr + offset); + } + if (offset) { + ri->rcd_lnkcap = readl(addr + offset + PCI_EXP_LNKCAP); + ri->rcd_lnkctrl = readl(addr + offset + PCI_EXP_LNKCTL); + ri->rcd_lnkstatus = readl(addr + offset + PCI_EXP_LNKSTA); + } + iounmap(addr); release_mem_region(rcrb, SZ_4K); From patchwork Tue Apr 9 07:35:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Daisuke Kobayashi (Fujitsu)" X-Patchwork-Id: 13621908 Received: from esa7.hc1455-7.c3s2.iphmx.com (esa7.hc1455-7.c3s2.iphmx.com [139.138.61.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A6F97E105; Tue, 9 Apr 2024 07:34:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=139.138.61.252 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712648086; cv=none; b=qWsthREPESos0/5/MAs5WIF3GDVnAVgMP4TS2RCZY7iJY/DcG85KWELi1mz/aAx1i9kzklIlxcpWvFzXj0yiSx7kO3gC/ZaMfVohD/lmTeHryP7KMuEh7UZxlFYr1EiJeMMhx0lJ0XthxNXx4UAdyPCrkzffknDoxm0sIY+9tc0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712648086; c=relaxed/simple; bh=J3w0/ylkb4XiYg+NOVUCBlML1Xs+JJ1NLrEyKUxtTsc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IzJUWEgZI7khyNs3uHrzlf8j5GGFDw4Tn1Uzqo19SWbdvnGCNOGRbfOrE93JHvdlrQBnyglOrGMpzO0JUbtJrN2AMn1PuFzpUgq44OtkB0klrGBCk91gxR0w4jko9TIh68qV8EFdY7lTZlDCenuyKSZu8CJZ3o/EXNUI5xiCYwM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fujitsu.com; spf=pass smtp.mailfrom=fujitsu.com; dkim=pass (2048-bit key) header.d=fujitsu.com header.i=@fujitsu.com header.b=kBIlOl2/; arc=none smtp.client-ip=139.138.61.252 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fujitsu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fujitsu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fujitsu.com header.i=@fujitsu.com header.b="kBIlOl2/" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj2; t=1712648084; x=1744184084; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=J3w0/ylkb4XiYg+NOVUCBlML1Xs+JJ1NLrEyKUxtTsc=; b=kBIlOl2/GeAVXj0EeSQ5Izo5xQT77mG/Ejow8SdDKGH0TsyyPAI+3+tT wWr5sO9WnIn7WtHk7n++7s6bnwMZIi3JRTN+WWjpxCDqXGumz/dSYdypN ZplT1RdKC9DQJK0VukP2vo+UHJS/F3Ab7FrqXzFx4yIke5iIRlyUUHwHJ CzxTzBCjwQBbySgyvD+k8VEjYN6Lb7aknj08CUlxlvxYUFU0DS838XWaf 7kywr5/p37Vc9vddRA0TD2BNUnfN+rXFxoB/+OCDh7NAI0NOrL6GhQe8j A6+heO1ADEMv3C3ctfs9Fd5GIpkMY/eifxgZ4bsXZRBrx8nCChf8AYMdi A==; X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="133822738" X-IronPort-AV: E=Sophos;i="6.07,189,1708354800"; d="scan'208";a="133822738" Received: from unknown (HELO yto-r3.gw.nic.fujitsu.com) ([218.44.52.219]) by esa7.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 16:33:31 +0900 Received: from yto-m1.gw.nic.fujitsu.com (yto-nat-yto-m1.gw.nic.fujitsu.com [192.168.83.64]) by yto-r3.gw.nic.fujitsu.com (Postfix) with ESMTP id 6D38AE9A34; Tue, 9 Apr 2024 16:33:29 +0900 (JST) Received: from m3002.s.css.fujitsu.com (msm3.b.css.fujitsu.com [10.128.233.104]) by yto-m1.gw.nic.fujitsu.com (Postfix) with ESMTP id B037D35C3E; Tue, 9 Apr 2024 16:33:28 +0900 (JST) Received: from cxl-test.. (unknown [10.118.236.45]) by m3002.s.css.fujitsu.com (Postfix) with ESMTP id 85718204E19B; Tue, 9 Apr 2024 16:33:28 +0900 (JST) From: "Kobayashi,Daisuke" To: kobayashi.da-06@jp.fujitsu.com, linux-cxl@vger.kernel.org Cc: y-goto@fujitsu.com, linux-pci@vger.kernel.org, mj@ucw.cz, dan.j.williams@intel.com, "Kobayashi,Daisuke" Subject: [PATCH v4 3/3] cxl/pci: Add sysfs attribute for CXL 1.1 device link status Date: Tue, 9 Apr 2024 16:35:28 +0900 Message-ID: <20240409073528.13214-4-kobayashi.da-06@fujitsu.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240409073528.13214-1-kobayashi.da-06@fujitsu.com> References: <20240409073528.13214-1-kobayashi.da-06@fujitsu.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-TM-AS-GCONF: 00 Add sysfs attribute for CXL 1.1 device link status to the cxl pci device. In CXL1.1, the link status of the device is included in the RCRB mapped to the memory mapped register area. Critically, that arrangement makes the link status and control registers invisible to existing PCI user tooling. Export those registers via sysfs with the expectation that PCI user tooling will alternatively look for these sysfs files when attempting to access to these CXL 1.1 endpoints registers. Signed-off-by: "Kobayashi,Daisuke" --- drivers/cxl/pci.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c index 2ff361e756d6..0ff15738b1ba 100644 --- a/drivers/cxl/pci.c +++ b/drivers/cxl/pci.c @@ -786,6 +786,79 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge, return 0; } +static ssize_t rcd_link_cap_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct cxl_port *port; + struct cxl_dport *dport; + struct device *parent = dev->parent; + struct pci_dev *parent_pdev = to_pci_dev(parent); + + port = cxl_pci_find_port(parent_pdev, &dport); + if (!port) + return -EINVAL; + + return sysfs_emit(buf, "%x\n", dport->rcrb.rcd_lnkcap); +} +static DEVICE_ATTR_RO(rcd_link_cap); + +static ssize_t rcd_link_ctrl_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct cxl_port *port; + struct cxl_dport *dport; + struct device *parent = dev->parent; + struct pci_dev *parent_pdev = to_pci_dev(parent); + + port = cxl_pci_find_port(parent_pdev, &dport); + if (!port) + return -EINVAL; + + return sysfs_emit(buf, "%x\n", dport->rcrb.rcd_lnkctrl); +} +static DEVICE_ATTR_RO(rcd_link_ctrl); + +static ssize_t rcd_link_status_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct cxl_port *port; + struct cxl_dport *dport; + struct device *parent = dev->parent; + struct pci_dev *parent_pdev = to_pci_dev(parent); + + port = cxl_pci_find_port(parent_pdev, &dport); + if (!port) + return -EINVAL; + + return sysfs_emit(buf, "%x\n", dport->rcrb.rcd_lnkstatus); +} +static DEVICE_ATTR_RO(rcd_link_status); + +static struct attribute *cxl_rcd_attrs[] = { + &dev_attr_rcd_link_cap.attr, + &dev_attr_rcd_link_ctrl.attr, + &dev_attr_rcd_link_status.attr, + NULL +}; + +static umode_t cxl_rcd_visible(struct kobject *kobj, + struct attribute *a, int n) +{ + struct device *dev = kobj_to_dev(kobj); + struct pci_dev *pdev = to_pci_dev(dev); + + if (is_cxl_restricted(pdev)) + return a->mode; + + return 0; +} + +static struct attribute_group cxl_rcd_group = { + .attrs = cxl_rcd_attrs, + .is_visible = cxl_rcd_visible, +}; +__ATTRIBUTE_GROUPS(cxl_rcd); + static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) { struct pci_host_bridge *host_bridge = pci_find_host_bridge(pdev->bus); @@ -969,6 +1042,7 @@ static struct pci_driver cxl_pci_driver = { .id_table = cxl_mem_pci_tbl, .probe = cxl_pci_probe, .err_handler = &cxl_error_handlers, + .dev_groups = cxl_rcd_groups, .driver = { .probe_type = PROBE_PREFER_ASYNCHRONOUS, },