From patchwork Tue Apr 9 16:15:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13622921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F7A4CD128A for ; Tue, 9 Apr 2024 16:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=gI0AadTIllqqvQVxF1x2EvegK6VeMGrfxc27SOUeE7c=; b=nx4Pp3+bU2UrY0 eYQgaMprWApiJVZi7CHmbNL4vh1OCvLFx93XzgRuQlo4E7SvrCaWRsXg9kw6FaKT5gL45gX/z8lES vTKwNgd6Oz/8XetDrdpLoBE1MKzA0yVRek54Ht9kG67lpY/ZMZXGNUk+ntpwb71dFTe2two4e+g+d ZVr0BP40Wds5V9UHJDLrDLli3PnIjh5o7clZzYvacxxnBkkM9NzrH2K0D9MEiGQGLx49qmfx/00ze c6+sh8T2lLWRm9kPjmlWIt2LxNQ6vL3U/ciWbpY50/+RofHEc1T9j3sLopJqmUeyYK2DMBAkT2UxK wyK2pEj25FlldpLuCjiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruE82-00000002tMo-0sjB; Tue, 09 Apr 2024 16:15:22 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruE7y-00000002tK6-2WE1 for linux-phy@lists.infradead.org; Tue, 09 Apr 2024 16:15:20 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruE7p-0004Jl-4y; Tue, 09 Apr 2024 18:15:09 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruE7o-00BKsS-NN; Tue, 09 Apr 2024 18:15:08 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ruE7o-00H3jd-23; Tue, 09 Apr 2024 18:15:08 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I Cc: Lucas Stach , Adam Ford , Marco Felsch , kernel@pengutronix.de, linux-phy@lists.infradead.org Subject: [PATCH] phy: freescale: fsl-samsung-hdmi: Convert to platform remove callback returning void Date: Tue, 9 Apr 2024 18:15:06 +0200 Message-ID: <20240409161505.66619-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2186; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=UODHebjoSRsDBh4aJIcSDZTcohe95O3Vckhf7QF1o7k=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmFWmJQu+7+BClDllOlLVxiKIlBJ9uwSJIrjRlS chsD2/Y1s2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZhVpiQAKCRCPgPtYfRL+ TsMhCACZ0/Aq+jK/yeH9y/XY9appTHmSYkynpNly+AOXb+/GPhtjxJ4P3m0nSIzYDa73htQt+Qn XpSkQk8X99dyD9dpb4Nyj70zWpX2F8615uxEUmQ8pd/q5v4rDB8vA8EP0KNxlnWazHi8PZB3lNC V39FtIbiy0DC59XGSyjgrUg7S8KRarKSbd2hQ8WEdBFt8ZWAbYmeOKoko384saRFnogcYxbxCNE YmZVIIusOLdFu5Bcc/qWIB4Oxjz0Lb0rJssRqzYmDfSH+fZ4GPm56TU/8QEUMvfNvJNFFR5CpsU vlBRTQmEGCE+UN4FbnC2PT2ijEDO2Bp2NvKXK7l+Cmy2FWyi X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_091518_666808_29914AAC X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- Hello, the driver patched here doesn't exist yet in the main line, it currently is added in commit 6ad082bee902 available in git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git next . Best regards Uwe drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) base-commit: a053fd3ca5d1b927a8655f239c84b0d790218fda diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c index 89e2c01f2ccf..9048cdc760c2 100644 --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c @@ -657,11 +657,9 @@ static int fsl_samsung_hdmi_phy_probe(struct platform_device *pdev) return ret; } -static int fsl_samsung_hdmi_phy_remove(struct platform_device *pdev) +static void fsl_samsung_hdmi_phy_remove(struct platform_device *pdev) { of_clk_del_provider(pdev->dev.of_node); - - return 0; } static int __maybe_unused fsl_samsung_hdmi_phy_suspend(struct device *dev) @@ -706,7 +704,7 @@ MODULE_DEVICE_TABLE(of, fsl_samsung_hdmi_phy_of_match); static struct platform_driver fsl_samsung_hdmi_phy_driver = { .probe = fsl_samsung_hdmi_phy_probe, - .remove = fsl_samsung_hdmi_phy_remove, + .remove_new = fsl_samsung_hdmi_phy_remove, .driver = { .name = "fsl-samsung-hdmi-phy", .of_match_table = fsl_samsung_hdmi_phy_of_match,