From patchwork Tue Apr 9 21:56:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13623269 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 869F1158A37 for ; Tue, 9 Apr 2024 21:57:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699822; cv=none; b=g9/IqJtOjpbjsJdFnm/OQrN6teEJGh9aNnkOx4yWPrMrBywvDqQY7x9RqqwEpKlW7vCxC8T6xZClIQM4rIq5ceDkVhgw7ygKJv/CRzoeXKBQvO9vFIWMu9ZlZn9NzVkS2jc5SVUZ9OlRlsBbyOPucdNNd+b1Yv2OYX7V+gFY3M4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699822; c=relaxed/simple; bh=3hy5UwOtuFS4dIc6nIIiKvN+c/YITts//vNu261p+aU=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=QNip5ItLlaLxB4PyYem8InztyHt/Gvgmh3u/bOnxdIsnRqzDWdL4EjrMb4asm+UQMvRtRS2tlH/kEH4vwJrwrA/heiAT4wmz9NccUVzEIxpQ5DZz5dxSMqVzHfKLEQdnV4D5Iu30IOf2LMWfvQTMeZGQ0f7Hpot3vuPkBDsko+g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X9iBzSbO; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X9iBzSbO" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-416c4767b07so1720185e9.0 for ; Tue, 09 Apr 2024 14:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712699818; x=1713304618; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Lux/KgFIK1lW6Byknm7s+RfYwSbjJEEB4IGrwl4tIrE=; b=X9iBzSbOg2+wpGezbkxJOIhtBajaK1nch1k0b63SWWQbs40oTi7uFWV3cbPXx+6cgz 7TyyIXNQ++NWAzWJeGWgo7CXJDDWI4Gg6529MiUAW90A18fGIwR7QBqM10zf4gkZ3Vog 4Ul71JIlNpUGbToxn/d79iJt9u8lxiRaqHNSuziMTe0Bmz11q993vKRY3brAHdxFWFFm XJKyCJZYH3Ci5xwDLCeg8xB+5GY9FpQVpExdtSa0OLZ24BFTdVEUAkRxWwcCnMfKSS7X ewsRYb76o0lkb40rW9dav8AIZkTLTXMDP3ljkKpUgCp/mR8m/SL7czZ5SXRT2f68SVTa Gatw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712699818; x=1713304618; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lux/KgFIK1lW6Byknm7s+RfYwSbjJEEB4IGrwl4tIrE=; b=q4JD/N9xJKdia1AKbjwxfVS4s1rryGZfrFRK9U9lPYC9KrKFOWyB7ThxFQ0JaSwqs3 pXRh5QLVbAU1VCkLdY4aB8EPu4lg7Si1On8vnZ7vsHKqPCvuhhZFpK1ks4QGdD+0/iUq l1hTyAAGOI6uzSAiq46Xwi5KtcBpk1tknNnTrQEUEQrweRRL9VQzVzMxkQfn2Ipo7n8T tIkmjp3p6upUbMcirn1eus3Ww2cHVPVdEo0eB8nsly1e/vnt1vcGhk0XtvbLxWBkDXCx w6XaTPBBSVESv6N3Rahiirou+6lWifXwnGWudfnzIZ7kdkCrubSLAgm+7MRBSQmfcmSp 7O0g== X-Gm-Message-State: AOJu0YxKbuyXIRT62uhcYJv8s8cD0s5oF968QjftmDmpqIXexDVB4+9V cWB9dDIv7jxnLwIX66IW2ZsHoL05rPz5KyOtQbh1tbJzbkQHjl0KN3iJRMaw X-Google-Smtp-Source: AGHT+IGaD0fHZJp6UYKb2bbWusnDCs4r+M6Kr/Y4zEHP4B5SEh8mQKhrxWyYL+/e7jPVCejbNMSPKw== X-Received: by 2002:a05:600c:4e88:b0:416:a6ff:bba0 with SMTP id f8-20020a05600c4e8800b00416a6ffbba0mr672383wmq.11.1712699817906; Tue, 09 Apr 2024 14:56:57 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id i7-20020a05600c354700b00416928e239csm213391wmq.35.2024.04.09.14.56.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 14:56:57 -0700 (PDT) Message-Id: <1f65dc5ba3ded5b90ed929aa3884574e8b26cd9b.1712699815.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 09 Apr 2024 21:56:48 +0000 Subject: [PATCH v3 1/8] MyFirstContribution: mention contrib/contacts/git-contacts Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Although we've had this script since 4d06402b1b (contrib: add git-contacts helper, 2013-07-21), we don't mention it in our introductory docs. Do so now. Signed-off-by: Linus Arver --- Documentation/MyFirstContribution.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt index f06563e9817..00f4c63cb9f 100644 --- a/Documentation/MyFirstContribution.txt +++ b/Documentation/MyFirstContribution.txt @@ -1116,6 +1116,11 @@ $ git send-email --to=target@example.com psuh/*.patch NOTE: Check `git help send-email` for some other options which you may find valuable, such as changing the Reply-to address or adding more CC and BCC lines. +NOTE: If you're not sure who to CC, use `contrib/contacts/git-contacts` to get a +list of reviewers you should include in the CC list. In addition, you can do +`git send-email --cc-cmd='git contacts' feature/*.patch` to automatically pass +this list of emails to `send-email`. + NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but please don't send your patchset from the tutorial to the real mailing list! For now, you can send it to yourself, to make sure you understand how it will look. From patchwork Tue Apr 9 21:56:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13623270 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20918158A3C for ; Tue, 9 Apr 2024 21:57:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699822; cv=none; b=COR5wnTk/b6QhUH4D4nadNUw240sHWaosHa66A+GJAeIO4wnGzsF/zcrTpwSJbDF6V9RPTj8xHn4XPrXWBEQdl84lGnF3q17A3CP21IUfo4zll2zI6Ok9Nl5RnbORvvtM0p0XRQd4a8sTwDZNB0jJmXces0RimnGtRe1t8Q1GNI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699822; c=relaxed/simple; bh=xk57zUsLcULI4piYDwAtccyPpYcWKKlCtENISMpU5Eo=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=qoglhQTKBQaYzi6Wldz9P469EnfLf3UrfIrPGJYcraLVBpHCX2qnIUUxhNSCOVRbItWZjgdvC+U5xDuvq/7S1nEsunCrFAAQWr1ko8Cqzz+F6Tp4dtw0S9zD0N1l9INyBANXphr2D258rLL6OUs277TPHCq6GdopdUTJsl5bAJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NUlN1exb; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NUlN1exb" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-41550858cabso42163465e9.2 for ; Tue, 09 Apr 2024 14:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712699819; x=1713304619; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=waqH/iRrWNhiEfcSl3rSo7z9FkzRwk5MNMpC/HcssOg=; b=NUlN1exb+ODW04dQ9iOTXTvUNR2DusQ8AvggfoN1fgDahmf2+T/L+bBuDwVjqilq9/ 6RX9gy174BAwW1c2TU3vR320rc27mYBn0PDdtGr69afUELg4pqogClYFzfXthpZVjSUM jEIP1UxyrB+cX6qCjoYcsgKRWRcb+BIcL5TW6abkVIVvjgpptd0VeyVyz2eCrBoKVTfl oiJcKFHh6jYbVmFPH+Apt91vqq7MrnaDgIYoLaJbK23P6x3GHI0KHDPhSPty2wwULuZW eb8w36KxzjCggO8u0fNLN3rhYAJfWpquhOmNMVOpaZp7yXw7a6lIJ0IEalDthPaLa+7P F0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712699819; x=1713304619; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=waqH/iRrWNhiEfcSl3rSo7z9FkzRwk5MNMpC/HcssOg=; b=ZynjVzS1MIMzy1BSQ0/kaKFAq33caCd+UzXYsAXZY6EriQUH9A24xLbOatCT/9xJBc VRuzON1flSOcevRRSWAM81gLWTISJu6QmiMC7H8RVFMyt64hlfYyVfs1X0JQqKxsg/ot 2TwyhYZKfxI5fC5nkbd5YfgSosKELO98IoW0IzkBeUzTNwB6550thNoLwFVGYTlkvXjK TPRyOWc2i2Dd47QjMmhnwhU5DkFhjqnjCDhcLDLlga9AVsZ9yLJw/AMyZ3ZACEowHXeS 4Dk2sqC1W+nIkNVzpjZIU+lInxXUzw1ZjdKm0kqYwr7e74K68EKlZmEHt57WLgjoTJs2 1B+w== X-Gm-Message-State: AOJu0Yy/Oz68RsCwT1cSkSa0AaqGoHFnFq9w6FzxjlMU3SvBe/oeLNHD TIQi5QdkLZcDyruFRanWDM1a9DtDyWhqNKMalt1vHEZwmWIkL73AFHNAnMVg X-Google-Smtp-Source: AGHT+IEIVqLLrsAPEUdvohat9W9K1f+CVA3pO5T1Pg8vwvHhPueQUt138tyMWq72mj40BkQ+i/P3Bw== X-Received: by 2002:a5d:6802:0:b0:33e:800d:e87a with SMTP id w2-20020a5d6802000000b0033e800de87amr603554wru.34.1712699818739; Tue, 09 Apr 2024 14:56:58 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id z8-20020adfe548000000b0034335e47102sm12345864wrm.113.2024.04.09.14.56.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 14:56:58 -0700 (PDT) Message-Id: <6e8b1b50ac5a59a401f73d6e3e0ebf90e1259928.1712699815.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 09 Apr 2024 21:56:49 +0000 Subject: [PATCH v3 2/8] SubmittingPatches: make 'git contacts' grep-friendly Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Avoid splitting up the command over two lines. This way, a command like $ git grep git.contacts Documentation will return a positive hit for this location. Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index e734a3f0f17..a33fe7e11f6 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -494,8 +494,8 @@ mentioned below, but should instead be sent privately to the Git Security mailing list{security-ml-ref}. Send your patch with "To:" set to the mailing list, with "cc:" listing -people who are involved in the area you are touching (the `git -contacts` command in `contrib/contacts/` can help to +people who are involved in the area you are touching (the `git contacts` +command in `contrib/contacts/` can help to identify them), to solicit comments and reviews. Also, when you made trial merges of your topic to `next` and `seen`, you may have noticed work by others conflicting with your changes. There is a good possibility From patchwork Tue Apr 9 21:56:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13623271 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67AF0158D74 for ; Tue, 9 Apr 2024 21:57:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699824; cv=none; b=FBEaI7VsRM9jCGf0UCzq8E6lamqu/erB9i3UxeQZRf/HeFcx9R8436chyILIJZX3STHHMXRm3Lv4YE414ArKGW6EJL6zB59uy8FNP1O37jblUutyp9DorUAPDcan7mrnXdLf+BK7C3KM3/46NmDbWWXcsL8FGq2eNj15eOpuzJs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699824; c=relaxed/simple; bh=OS2xoQ0I3I/WzFYlGj0iXuJRTReu6U3egxUrzXd+0vg=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=lWmu6LzTyLJtnjNYeN8cTPZAu1PkM7yTJaS/KD5A/dnMNCapfQgoW2/iZBnvUOCsRloVo4VztU8J8kElpmjZT7/CpIbwmJ7vHrKdOAaha2KG68n2Cx6fVszstUMluu1zUazQkrw4oVWLe/VAPajBXnfBJ79N96+xolLIBmfLjNM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GJMvwnsd; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GJMvwnsd" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-416c4767b07so1720395e9.0 for ; Tue, 09 Apr 2024 14:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712699820; x=1713304620; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=g9jqNylnkl/Oo19J6SRdOvDdCpMoEF+q1h7XhVbXYK0=; b=GJMvwnsdcG8Ee+GYaUquQcOw/5Rp3d375MQMGqP+Er2nEkMWXHNQwGg+qSFVP7QZVr 8tujcIUGmjvaLvytX9b7x4XKGQqVHZburQ2vAMwBxKbfqh+kcJwvk2VG7PdFdmlS62SC LI4GhmV+yifXO7/blUMKEX0lCvyse1JubQn9xNbSaZQ5isRso9qBk7nsEkVOH3bbkHp+ xRGTLm1CG8SQ408C650QpIBYiz2wxRKQoZ78FPCUovAAcziHk3TJZljZ0G6EZE/8qTwv Kdjtev5HeQpAtBCvL42DNMylyB0/VkZR+pAXk1dY5wso7Z0bwtlOU2bIHhcf7OZVMOzj hRmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712699820; x=1713304620; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g9jqNylnkl/Oo19J6SRdOvDdCpMoEF+q1h7XhVbXYK0=; b=nwj1uMD5Cpqe84UMtjY5Ibosa+KfSdKEL/lO4fb2zHMC5LcAgUMtywJnhbm0apGQiI EE0ubuDNe2VOUF3dCLpPt0Aa2KpKoM9RrXTkSsVbJeGL0UcF1E3SfgXV3xbUYDYxkpzM PcDARSfj+3YnQ9HTVybpqBmEbcKDIsE7oDcDUGHPObPQ/2NPfCtR8rd2XTFDKCMAnd3s Khl3Ww4a09qNnJlTbQH/etMO3dyOLH08E/2DPdp7Y5wKw0GUxuoFD+24auzbYq9L2HtM FQk8Vx/kPYxkrxOUyykljaR/UQEt2xkxUpwEzj6TPsmSfdPnt217AE7OJLJhXMg1zxrc EKhA== X-Gm-Message-State: AOJu0Yz952K8Ytjph7QkNXHQZjaVFgKBEWADO9QPKi+YBvhfcfM6QGWl IBx+l7DGVUHoy39ombM0zThJHRSrvo9D8dadxjcjBWiVcrBSuEUECrvm23kJ X-Google-Smtp-Source: AGHT+IHXY11PuVYE8WBY0hbCYPapOqZH4BqlOjGTfEPwbPoAoMl6RXHJjFViRVNZJicv4CX1Nvt3ew== X-Received: by 2002:a5d:660b:0:b0:343:b9e4:d254 with SMTP id n11-20020a5d660b000000b00343b9e4d254mr609905wru.13.1712699820094; Tue, 09 Apr 2024 14:57:00 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id a21-20020a05600c349500b0041680911b0fsm211612wmq.30.2024.04.09.14.56.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 14:56:59 -0700 (PDT) Message-Id: <7f8fdc053f729076e5e8c18fa167c71d6eb8b2e7.1712699815.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 09 Apr 2024 21:56:50 +0000 Subject: [PATCH v3 3/8] SubmittingPatches: mention GitGitGadget Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index a33fe7e11f6..c1933c97cb7 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -408,6 +408,10 @@ are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME type e-mails) might render your patches unusable. +NOTE: Here we outline the procedure using `format-patch` and +`send-email`, but you can instead use GitGitGadget to send in your +patches (see link:MyFirstContribution.html[MyFirstContribution]). + People on the Git mailing list need to be able to read and comment on the changes you are submitting. It is important for a developer to be able to "quote" your changes, using standard From patchwork Tue Apr 9 21:56:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13623272 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2CE158D7A for ; Tue, 9 Apr 2024 21:57:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699824; cv=none; b=YVfz3euEelNlPKfNjzuonO3NgmBF6hVl7q50iqrnfuUxdXDtU8Y7veuA+wDoIdmF9clwnIHSWd18fQCBbNpLw8fZBQo6/kdQ7M1t1oRVYROtkgHmVJPY2bbmwiuivUPUM2SHmOVXEK1Ro4CN7AwWBIlbz6ZTnbIMsmZpWVbr0fM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699824; c=relaxed/simple; bh=Q/vav+OXIO6b1yL8IdPsVVRPa2Pwaw4Ysqwzc/OfNos=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=LN6AxMuK7TBnUbenQBUQgBWqL2nmS0bqFLKa5sGvSG2Nh2t5o/pJssUOvKW04t6ARmDE5z748f0flbaLZULe7D54QYQjYeGoMjIb44Ff3zhHW/VbaI1EyHkFn8TjczK0CKeOpy1vHqnPb/zx1+ZDMdhI/mnAZyotlqyuo7ziF3E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LN6bSx0p; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LN6bSx0p" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-416a208d496so9292825e9.1 for ; Tue, 09 Apr 2024 14:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712699821; x=1713304621; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=yZJ/1Z/ekxi+FA3GjXSC2OdJc+FvCkeYQzt915jLjfk=; b=LN6bSx0poAMoIs0apFa8PDwh62TRLQ+dBfqacx26d/XODKu9F0gTugPBBlsxUsKIAP v3uFhr/IDziQDX12i+GjZXGksEPbv8Lahe0dFyKx4LEjF8Xdlad5MkYwaA7xfHMUftbt eVq1qlbHCOBEINx9bJKdgFc41ruBh1b63iW0KoCHKN0Dq/NlstnERYiPnVscsbexTn1Q wqpq5Vg7Km/1lKZSZag19TCTzgaKqbSBkDlMbdrEP8eT6V4wvFLhWcB6MuUhW0UbXCEB mRDzErIOSFJrEGhsSmSKD3UiuHJH/lowvFX3MFqQHKSPmE7OILSavXAN8C3v3EZBm53h aO8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712699821; x=1713304621; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yZJ/1Z/ekxi+FA3GjXSC2OdJc+FvCkeYQzt915jLjfk=; b=cZMiAGYTOGEnVG+8x/2kJSu0c094oLPB5HP6dIfx8uzjPGWxJjBE2OmqcBMhf0Eygm gOo8+tXwli5nqg2A6iQ2aUmBREgmJvNKjvs9Hio3tcoXYkLuiEd4ZBwx1wCrwFxEN3HO MiPS6FTI2LaLPRO1uflGhWP5/lVtpePsYPTNv23Z6dcsSGEJzybGL2JrH1YKeZTp/wbu Ybz4vqfVvv+ypO65SnhsYHjjcJmrtY7rmXAiMsVstFjkTFCHq5JD4oQ1PQ6hk/gKevTi AOwtIU+gXngp37Dcrrm517MhYF5H/aKgwf/42VuVoDvlakWjR3dSSMkiFNk1Wg+PRkoe Z5CQ== X-Gm-Message-State: AOJu0Yxr8KLNeNH8ijnCHYEq8mJEMugUsJBBgCiGK5wH/3nUZLtHQPg/ F/zHa1++vnnE/xydC3aNkSQUTLwMypDt5PRJPkd2tGBDXf/DIopfa2xyYc0m X-Google-Smtp-Source: AGHT+IHp3dTqgur/YdjZvIODpS8j5d2F1a4CQu02kqjatC5+Pygp4bONW7q3lKasqEj/9tyJtHkXXg== X-Received: by 2002:a05:600c:d3:b0:416:3365:b9c7 with SMTP id u19-20020a05600c00d300b004163365b9c7mr656552wmm.13.1712699820847; Tue, 09 Apr 2024 14:57:00 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id e10-20020adffc4a000000b00343a66f6be4sm12367423wrs.24.2024.04.09.14.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 14:57:00 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Tue, 09 Apr 2024 21:56:51 +0000 Subject: [PATCH v3 4/8] SubmittingPatches: quote commands Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index c1933c97cb7..8594a3dda36 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -403,7 +403,7 @@ Before sending any patches, please note that patches that may be security relevant should be submitted privately to the Git Security mailing list{security-ml}, instead of the public mailing list. -Learn to use format-patch and send-email if possible. These commands +Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME type e-mails) might render your patches unusable. From patchwork Tue Apr 9 21:56:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13623273 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0001158D94 for ; Tue, 9 Apr 2024 21:57:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699825; cv=none; b=WX6BhuGxqTfOtLB9MapyJN+vFQ85V8JPEmvPig+eoEjLUiXrByc6nmIuRbSTex4suwF3YykrAxZNUlHBxeZM8dVV0Y3sPJ6deqPSY8ET2j9VbHtyLLPn4G3UBA3EC9GFAIPJLNM/vkZUVnNX2QnPXq7WFhTEf9xEFHhv6KYBi+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699825; c=relaxed/simple; bh=5cy1OPvy9KfvsVVcu4gzZ7WibGtKIPvhFkmkLIXlwAM=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=PJ6itETStaKVL0KYzhelq/Voo9uHxNbp99uCfoPPJgK8t4Ue5YXfXScrCWNorXteaMemBER7O7FS+WvY/2qAOn2se5/mpxqVvMzfhIqxyTLQPPaYSLS/DVOlotIaW1BiA+QxCbmgrTXm7iXDjM0AW7ryNSLCsOkCcnVstnBgDd4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fkdUXvaV; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fkdUXvaV" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-34388753650so2539122f8f.3 for ; Tue, 09 Apr 2024 14:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712699822; x=1713304622; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=6j860TExSUSDavYKKOlVuU1oRtbZEpDvs0vvv9ixh4A=; b=fkdUXvaV8v7TQ9IFbD1NqeaZzsc8CSJ3jiQV8/UAhbFolN8CKjDIE7e8uOK0inJew/ IHtEGVT/NzqUpIDBna5UviAOk8Sr9qbuGBJ7WVx9H6WTVMQKPbcYAzMOaJGNDUhKR3Ci vUM0avYqU7E5ojqBymPDDfmSP+ojkFj3O+qRpfTFfmclhaX0jqlCq8YaBkdC60BUB5gN udHvJoDIbaIp9gNFuqPOTa8uY9jpN3dS7E/G4EJ4XMy0a6M3xBNQjEDairMiTDRTjiai xJgAQ5GIyoUoIU1WNC4AJwv9WNE3UR6QWzMYUCI3M3PiLE/6FgnzXM8/rspGqDS7xMZF jYOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712699822; x=1713304622; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6j860TExSUSDavYKKOlVuU1oRtbZEpDvs0vvv9ixh4A=; b=INsJJq+8tu5/yM+gYBm7LC39gxlMJFsdm/CvGyYO/84+9UDateQ4qWJMiw/fT8WJwG iKSBcoRG+1qQiG/dJMWHQBcWzsHHNQpp+zrUWXDp1nqQJEXBzhCsZR/N6f9k1ZucnNCE VzUVyWMwDKIk7s2bMHejVXTylIlSw0TRRMQ8IkM+H5fgMLk5BA5CbP9e9xsevsfg4pWa c2HcGoyvK7oaVEcC106wlKLMiDS/vnT2CKzZqyPzhHD4SO5BVPzgbJcePTnvY8517EdB Eu38i31Rh2A9hG+WnsfkuBxSmHHDzYF8V4qEWFsdr+UJfrLqTX0phNncOqwUlTSPgR8m PosA== X-Gm-Message-State: AOJu0YxydUkLkHHWiLcQefbtN7z4/utdWadkYBLTPlncF6DxjwvnAYXe ZnWu+YLoUlalDaAzH7H+ltGZ7q7i4QsQmHSqnH5Mr9V/OEl+wxdrartkEZ7o X-Google-Smtp-Source: AGHT+IFfokPbCMI67w4kPcFOh8AdtvwSPC+Y3ewARvtN9dtnMM9KE1myQW7Auevhz1MdICKhBZ4EZQ== X-Received: by 2002:a5d:61cd:0:b0:343:6704:93b7 with SMTP id q13-20020a5d61cd000000b00343670493b7mr639729wrv.59.1712699821932; Tue, 09 Apr 2024 14:57:01 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id d6-20020a056000114600b003456c693fa4sm8128889wrx.93.2024.04.09.14.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 14:57:01 -0700 (PDT) Message-Id: <6f71b1731f2aed9c2f4dc101bf4349344b575d73.1712699815.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 09 Apr 2024 21:56:52 +0000 Subject: [PATCH v3 5/8] SubmittingPatches: discuss reviewers first Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver No matter how well someone configures their email tooling, understanding who to send the patches to is something that must always be considered. So discuss it first instead of at the end. In the following commit we will clean up the (now redundant) discussion about sending security patches to the Git Security mailing list. Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 58 +++++++++++++++++---------------- 1 file changed, 30 insertions(+), 28 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 8594a3dda36..392bbccc452 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -397,6 +397,36 @@ letter. [[send-patches]] === Sending your patches. +==== Choosing your reviewers + +:security-ml-ref: footnoteref:[security-ml] + +As mentioned at the beginning of the section, patches that may be +security relevant should not be submitted to the public mailing list +mentioned below, but should instead be sent privately to the Git +Security mailing list{security-ml-ref}. + +Send your patch with "To:" set to the mailing list, with "cc:" listing +people who are involved in the area you are touching (the `git contacts` +command in `contrib/contacts/` can help to +identify them), to solicit comments and reviews. Also, when you made +trial merges of your topic to `next` and `seen`, you may have noticed +work by others conflicting with your changes. There is a good possibility +that these people may know the area you are touching well. + +:current-maintainer: footnote:[The current maintainer: gitster@pobox.com] +:git-ml: footnote:[The mailing list: git@vger.kernel.org] + +After the list reached a consensus that it is a good idea to apply the +patch, re-send it with "To:" set to the maintainer{current-maintainer} +and "cc:" the list{git-ml} for inclusion. This is especially relevant +when the maintainer did not heavily participate in the discussion and +instead left the review to trusted others. + +Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and +`Tested-by:` lines as necessary to credit people who helped your +patch, and "cc:" them when sending such a final version for inclusion. + :security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] Before sending any patches, please note that patches that may be @@ -490,34 +520,6 @@ patch, format it as "multipart/signed", not a text/plain message that starts with `-----BEGIN PGP SIGNED MESSAGE-----`. That is not a text/plain, it's something else. -:security-ml-ref: footnoteref:[security-ml] - -As mentioned at the beginning of the section, patches that may be -security relevant should not be submitted to the public mailing list -mentioned below, but should instead be sent privately to the Git -Security mailing list{security-ml-ref}. - -Send your patch with "To:" set to the mailing list, with "cc:" listing -people who are involved in the area you are touching (the `git contacts` -command in `contrib/contacts/` can help to -identify them), to solicit comments and reviews. Also, when you made -trial merges of your topic to `next` and `seen`, you may have noticed -work by others conflicting with your changes. There is a good possibility -that these people may know the area you are touching well. - -:current-maintainer: footnote:[The current maintainer: gitster@pobox.com] -:git-ml: footnote:[The mailing list: git@vger.kernel.org] - -After the list reached a consensus that it is a good idea to apply the -patch, re-send it with "To:" set to the maintainer{current-maintainer} -and "cc:" the list{git-ml} for inclusion. This is especially relevant -when the maintainer did not heavily participate in the discussion and -instead left the review to trusted others. - -Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and -`Tested-by:` lines as necessary to credit people who helped your -patch, and "cc:" them when sending such a final version for inclusion. - == Subsystems with dedicated maintainers Some parts of the system have dedicated maintainers with their own From patchwork Tue Apr 9 21:56:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13623274 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 348BF158DA9 for ; Tue, 9 Apr 2024 21:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699826; cv=none; b=a3Ow74HXAQ7vzpplGE3KlhFqc0hHtBXr9+DVWlEQPFj0t1bIjPs3mTyB5VZe+pmYT239KbX5ymo2xY2rkQJ0dHtvQ1WviJETVHZ0rp+bGahONKc/wPFMCUzTi9HLOi+aY3xulH7+IfYv/IIJdZr2WcXVghaea4+w6PgUIj8uVMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699826; c=relaxed/simple; bh=2iPz4dlX8jpzRpeElSksbzrkIa+iQJpCgQuiEceurxU=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=PjSInXkPwO1easA+TjeQ1U0ezeEyjEcsfz3doje/dD2FOYcpEDvtuu1ZjQXDpiuh7eP0spxpGWjm3n8FaIFWEruDs3398n7LYa+KyZxoHsMYLigTr7xkxjYRlv7IzRajSnWZQBP4w5r7u/t694tUIoEO2L0n1gCyHPraMsZbbzM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a8lSB5sp; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a8lSB5sp" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-343bccc0b2cso4433343f8f.1 for ; Tue, 09 Apr 2024 14:57:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712699823; x=1713304623; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=1SFXfkxojmDlP+99gjHbt/LwyX0Yxr8umiMvLxJswPU=; b=a8lSB5sp6pfIvdVzFpGlGlOzYGpMjww2Jv4JOJ2PmW9vknLI6X21vQh6RAm1Web+cN WRDpfXJf2Sy8XSq3oiBywTvYogVfdmb2D857iAm6hE91W2et8Rc8LZ4hf5NE+iNb7sFY HkMhoqvugowa4LXuSdAH1QVSP0eqBYVvAzMdB3zAdnbaBWjSKeP6JZOiX/Ak+GfUAPaH 2Sev89ltAxHwcQL1q2RXCSWh9ErQooqHi6O8PSZBDCSb8/+ALAPAWRX3uuNwGskWHH27 rbYb9uUKzf8INfa2nkiXmBwg/zyKXI2lhm8j71RkfBUlciq+Ua5sZMsKuDh/dyTGgZOP KUhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712699823; x=1713304623; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1SFXfkxojmDlP+99gjHbt/LwyX0Yxr8umiMvLxJswPU=; b=ISZetU9lz4kCN1BgHjeYSr5AGXfzM14yFkhYJKSkNA8vV18uWQ3mP205hjUeNqqF0o qG3can/0ererGQc6tZ7cJ/OYbtcXsx7eZXdZh/O47yf/D31D2Gx8cYk6sfIS6dbpQx+g QuU8y3/XWEf6M9Nm4E7ZcZlumV5ZzFbYTR0QSeU7G8PkOUD+RcN04R030nQCb2eodRok wbdIIsyYEC+61Jyn6fzhgNZ9L+9U6eix4cQ30BihD3d0wji8MTApxauqQ2tNFWLSVuW7 sKvFCh3SHNNyV13GR6GXFzRF8Knd8LsrHH6Yge31aH7eJVHR4totuFabuUaiz4Flncda tgOw== X-Gm-Message-State: AOJu0Yyqjq/IZFv7Egg3OrRx0UHEJs5Xd6lQSttwK/g5f2Pe9/P7pERr 8AVM1wfuVJHcaqvlDEr6R7geHRgmB1vObKav/Su6wGDosTxgkpo7ibMQ6XbZ X-Google-Smtp-Source: AGHT+IHB+8TUa+KNcxr1aMA4skNCZVL3audpIIcng08XeF2/Ff3acNGQy2R5CstqnK/HFcuhFQcihA== X-Received: by 2002:adf:e488:0:b0:33e:bc7e:cadb with SMTP id i8-20020adfe488000000b0033ebc7ecadbmr583419wrm.41.1712699822960; Tue, 09 Apr 2024 14:57:02 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id o16-20020a056000011000b00343b252b096sm12363262wrx.23.2024.04.09.14.57.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 14:57:02 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Tue, 09 Apr 2024 21:56:53 +0000 Subject: [PATCH v3 6/8] SubmittingPatches: dedupe discussion of security patches Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 392bbccc452..98ec8170aeb 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -399,12 +399,11 @@ letter. ==== Choosing your reviewers -:security-ml-ref: footnoteref:[security-ml] +:security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] -As mentioned at the beginning of the section, patches that may be -security relevant should not be submitted to the public mailing list -mentioned below, but should instead be sent privately to the Git -Security mailing list{security-ml-ref}. +NOTE: Patches that may be +security relevant should be submitted privately to the Git Security +mailing list{security-ml}, instead of the public mailing list. Send your patch with "To:" set to the mailing list, with "cc:" listing people who are involved in the area you are touching (the `git contacts` @@ -427,12 +426,6 @@ Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your patch, and "cc:" them when sending such a final version for inclusion. -:security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] - -Before sending any patches, please note that patches that may be -security relevant should be submitted privately to the Git Security -mailing list{security-ml}, instead of the public mailing list. - Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME From patchwork Tue Apr 9 21:56:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13623275 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BADB3158DB1 for ; Tue, 9 Apr 2024 21:57:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699827; cv=none; b=m21yhRh6+vAb4b5noGlq/axTtHLrsykv5zchd4njl+1VKRd1r1kGJ7xEjpTVSnfTbpaOx488deRZlHC+PZiJ1biuyo44GUfpU6erY4Uyuh87QhipKXS+Plt0IlVvpgIkqyj40cy+6n2rBOkzJ4/z/z8OhkSu2Wrbf1rtLarZBtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699827; c=relaxed/simple; bh=yVwWzomOuqumczx8qiJjN0ddsUHGMc1ItM0fpeK8IPA=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=Ihx7KDLRAKhHTg8BdWNV+ggEA3ecL2QwoSuLW2r435yHFYAec+oLOx+nqcb4lthLRevPIEAmdl0P8HbzL9uGQqhaXCwiy/NYrq4SIfK2z8vB3GPTsI36ZKZwv9I5adoEl1uVzlFp3v7qaCn+9P/2eISMLw307eM7nlI8FqZ8xWc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ABjY08LK; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ABjY08LK" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4168a5d7564so13875625e9.3 for ; Tue, 09 Apr 2024 14:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712699824; x=1713304624; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=HdWdrZDi/XyXCZA+chwRbfdhAoQjsUXIcslctsO8abk=; b=ABjY08LKFw839Rbt4xAFhmaoEjvu+Ls9YcLOM3a56ylXTcf64LAGaxuHHEHUy6K4ET 1ERwYlilznEN5HO4EDefC9KZ/aj3J7HE1RNqKXDBo6kTM/ZZ6pVB8HWt+8Qk9LtZgooR 4fV2JRBPbke7WSI+e4zg6EKxlPqPheZag3iHJ+DC84tehjUpGRb+T3R+uwesEHSPNl5l /EF/TIx/+GFngaN+t6GXqhdx995my55QXFFX7eTw+G4CzUKLitFbXsW2Ao+lUQQuKalN /dZUxAjAZeCwAAQBymAEC9AmfCi6owwNtuQyGwsXqSenjzemfTciuZ4ZLgZNSndYXr/b VN6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712699824; x=1713304624; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HdWdrZDi/XyXCZA+chwRbfdhAoQjsUXIcslctsO8abk=; b=gBOhMZJ9n80rdP3ITRtJOc3T1649fSZITR311k3fD8UY+/iscHmfxAnZ29Thb8ScYJ yYpYDtcla61lFKetQVIHI4Ps2jWJ5WTjlaTnJy1OvlNakqkWx/x+2RVCeAc63+gi1i7T b0sOiNPaDbls2enuvGHwFjQAuW69ybqK8wbCfDLPV2tU3eeJudxcesksDQITsfSTa0Ky I1c306xGZLXi/DIjfNVVjMX4Wdkp2VB6Y62vZhWgqgt7M+BHuIevRU4/JVOtdRxRDVbI nvYgfdaGbwG6dFXd3YQiyID+wu17vz+KGcWTn06uqdx7klFklYKODGEUAfUSX77x1Ene MasQ== X-Gm-Message-State: AOJu0YwEWnq/vBhKht5/TEhhDZ90Z+0r3Pv5Z07vLvPyDRBtkmYEb31x RpfCqRrGcir/g8OSbNORZ6vqGt+RvaujLuHlkzmcte08OBx/f2pnzVUEujWL X-Google-Smtp-Source: AGHT+IE8RuEmd9+wM0tbEzzjK3rKQNrrvQsgo7PfTj5fVb442+QlTqr8T9apd2fM0T6e0AOFpmJ68g== X-Received: by 2002:a05:600c:46c6:b0:416:9ba1:622d with SMTP id q6-20020a05600c46c600b004169ba1622dmr635680wmo.38.1712699823637; Tue, 09 Apr 2024 14:57:03 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id m3-20020a05600c4f4300b004167df5ed4bsm208221wmq.29.2024.04.09.14.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 14:57:03 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Tue, 09 Apr 2024 21:56:54 +0000 Subject: [PATCH v3 7/8] SubmittingPatches: add heading for format-patch and send-email Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 98ec8170aeb..bafb1ee0157 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -426,6 +426,8 @@ Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your patch, and "cc:" them when sending such a final version for inclusion. +==== `format-patch` and `send-email` + Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME From patchwork Tue Apr 9 21:56:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13623276 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E151E158DBD for ; Tue, 9 Apr 2024 21:57:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699828; cv=none; b=Ov1cGWgWq3LGGlTrN0mS/ZNnyh1uPrElgT1Ptmoib1BQfiPpz0W07sPPY9bZ+IVCX0DTSzE8C5gspZwc/03TabYxgPkw7IMtt2ivqTYWT1tC930ZrOiWaiDyzDnq8IrT/G6idNwQ7zj0TINn0FWXt5EUv7qdroVQEDLxx4+EazY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712699828; c=relaxed/simple; bh=xoKPgz6S7m4akW3oF0B6oWglXsx7fiv8kxMqTndFlsk=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=FbHVdRo7ktBF9T8LUIX2/U9aPD1j+CUhwNzGulaNKKq2byGU61pXZK/xd8FQhfDJX07FNRK3I6ZNxNd3q3v8efCw9trn0q67Ae1ZFX8iSoh73XaCRBJym/63HXjv/V2HPY7VtMJ38Hujz+MFoXzOjEUCBScsKFoOWfS2Uxy42S8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gqF9jWRf; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gqF9jWRf" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4166d6dab3dso19695915e9.0 for ; Tue, 09 Apr 2024 14:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712699824; x=1713304624; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=4sYkM0tUAr4BggkmFvibmlBmY0KXYSu3PaveFclcdBQ=; b=gqF9jWRfRUXQKwmSdudphBarmdDcQykcNMfMF434jf+t5lbF30+/NMcegZrueKd488 hqRMS1MYjiWgfZbao9jgaY2eob0Kg0LPBtgHA3pHnYM0TUZadPfLz6CQU7bXf6egrqAw LN9zQZxYw874FiSG3OKLiwbP5h9RrSFWMo7phy45Iirg+riNaznMN6HOKMynfC2+fazl uN0JA/8JHSWeGmli0A9T4xVMAeq3XvduGLe+Vn4lLC1kREJ7hibYVk9gWTHmaUhx3/L2 3D5DO8sPtS+ybDZTQaFfV5UjD5Es+JNuRa2u2P4pRrSiC/+AryerzfKiyA90Bz15VNIn yRsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712699824; x=1713304624; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4sYkM0tUAr4BggkmFvibmlBmY0KXYSu3PaveFclcdBQ=; b=Rapbs5P3FM850wDZ282LbyvdfNTTjLA8b9fixmzVU8+YmP4RfxE/tCocqnYSRHzDgJ pk2Xb7yaq+ovyJPLC6fERa48ny9RQQPeqT8PsMGLN/z+eqm7Vwp18Fj/Svt5o2LQxLmd 0MQa30SEjIyKyzzOrIgIsCqEk+u/O1BZ3HPoTpFbF3ZPDt7Hk0WWPdWPbfEg94wXOqrN sDsc/Qs2uHWZgy4y46OPh5h3hzRWdBkJcJzzbwW7OTqlY1kexwepnSimS4t5JwS3I0BG hxo9w4m5bW96LexsQs18JCwSKoFR3vavvLxwLcRcBBtX4NkD1/9C11WjhTLa8hsCrt+x FlxA== X-Gm-Message-State: AOJu0YwL+P77nKUW5hLIrRV31CuaeRcjTQuZgLflQR7LgXLUtheACq1X O6ltR7TWWPoLTysMCVVi8p0A0S1NW13uTgaM94hdu01MiCzVOkV36yqHMtpM X-Google-Smtp-Source: AGHT+IGU4Nxi2zIkXdX6bdvpQQuV0m5lrrfFTUzc2Zi3hNw0oxpbqwyxaQm1VGyli2c3G5RA6p6wAg== X-Received: by 2002:a05:600c:5253:b0:414:71b2:c915 with SMTP id fc19-20020a05600c525300b0041471b2c915mr631482wmb.34.1712699824675; Tue, 09 Apr 2024 14:57:04 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id r4-20020a05600c35c400b004163321790esm226013wmq.19.2024.04.09.14.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 14:57:04 -0700 (PDT) Message-Id: <4fcab0d3319fa47c2f4126139ca636d6848e9e3d.1712699815.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 09 Apr 2024 21:56:55 +0000 Subject: [PATCH v3 8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index bafb1ee0157..57953898cee 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -413,6 +413,13 @@ trial merges of your topic to `next` and `seen`, you may have noticed work by others conflicting with your changes. There is a good possibility that these people may know the area you are touching well. +If you are using `send-email`, you can feed it the output of `git contacts` like +this: + +.... + git send-email --cc-cmd='git contacts' feature/*.patch +.... + :current-maintainer: footnote:[The current maintainer: gitster@pobox.com] :git-ml: footnote:[The mailing list: git@vger.kernel.org]